/[gentoo-x86]/dev-vcs/git/files/git-1.7.3.4-avoid-shell-issues.patch
Gentoo

Contents of /dev-vcs/git/files/git-1.7.3.4-avoid-shell-issues.patch

Parent Directory Parent Directory | Revision Log Revision Log


Revision 1.1 - (show annotations) (download)
Sun Dec 26 22:40:40 2010 UTC (3 years, 8 months ago) by robbat2
Branch: MAIN
Bug #349083: Fix a false positive in the Git testsuite, triggered when the portage user had a shell of /bin/false.

(Portage version: 2.2.0_alpha6/cvs/Linux x86_64)

1 Fix false positives in t3404 due to SHELL=/bin/false
2
3 If the user's shell in NSS passwd is /bin/false (eg as found during Gentoo's
4 package building), the git-rebase exec tests will fail, because they call
5 $SHELL around the command, and in the existing testcase, $SHELL was not being
6 cleared sufficently.
7
8 This lead to false positive failures of t3404 on systems where the package
9 build user was locked down as noted above.
10
11 Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>
12
13 diff -Nuar git-1.7.3.4.orig/t/t3404-rebase-interactive.sh git-1.7.3.4/t/t3404-rebase-interactive.sh
14 --- git-1.7.3.4.orig/t/t3404-rebase-interactive.sh 2010-12-16 02:52:11.000000000 +0000
15 +++ git-1.7.3.4/t/t3404-rebase-interactive.sh 2010-12-26 22:30:47.826421313 +0000
16 @@ -67,8 +67,8 @@
17 # "exec" commands are ran with the user shell by default, but this may
18 # be non-POSIX. For example, if SHELL=zsh then ">file" doesn't work
19 # to create a file. Unseting SHELL avoids such non-portable behavior
20 -# in tests.
21 -SHELL=
22 +# in tests. It must be exported for it to take effect where needed.
23 +export SHELL=
24
25 test_expect_success 'rebase -i with the exec command' '
26 git checkout master &&

  ViewVC Help
Powered by ViewVC 1.1.20