| 1 |
From stable-bounces@linux.kernel.org Mon Jan 9 09:41:37 2006 |
| 2 |
Message-ID: <43C27662.2030400@openvz.org> |
| 3 |
Date: Mon, 09 Jan 2006 17:42:42 +0300 |
| 4 |
From: Kirill Korotaev <dev@openvz.org> |
| 5 |
To: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>, |
| 6 |
linux-kernel@vger.kernel.org, "Dmitry Mishin" <dim@sw.ru>, |
| 7 |
Stanislav Protassov <st@sw.ru> |
| 8 |
Cc: |
| 9 |
Subject: [PATCH] netlink oops fix due to incorrect error code |
| 10 |
|
| 11 |
Fixed oops after failed netlink socket creation. |
| 12 |
Wrong parathenses in if() statement caused err to be 1, |
| 13 |
instead of negative value. |
| 14 |
Trivial fix, not trivial to find though. |
| 15 |
|
| 16 |
Signed-Off-By: Dmitry Mishin <dim@sw.ru> |
| 17 |
Signed-Off-By: Kirill Korotaev <dev@openvz.org> |
| 18 |
Signed-off-by: Chris Wright <chrisw@sous-sol.org> |
| 19 |
--- |
| 20 |
net/netlink/af_netlink.c | 2 +- |
| 21 |
1 file changed, 1 insertion(+), 1 deletion(-) |
| 22 |
|
| 23 |
--- linux-2.6.15.y.orig/net/netlink/af_netlink.c |
| 24 |
+++ linux-2.6.15.y/net/netlink/af_netlink.c |
| 25 |
@@ -402,7 +402,7 @@ static int netlink_create(struct socket |
| 26 |
groups = nl_table[protocol].groups; |
| 27 |
netlink_unlock_table(); |
| 28 |
|
| 29 |
- if ((err = __netlink_create(sock, protocol) < 0)) |
| 30 |
+ if ((err = __netlink_create(sock, protocol)) < 0) |
| 31 |
goto out_module; |
| 32 |
|
| 33 |
nlk = nlk_sk(sock->sk); |
Parent Directory
| 
Revision Log