/[path-sandbox]/trunk/ChangeLog.0
Gentoo

Contents of /trunk/ChangeLog.0

Parent Directory Parent Directory | Revision Log Revision Log


Revision 119 - (hide annotations) (download)
Sat Jun 11 10:01:11 2005 UTC (9 years, 2 months ago) by azarah
Original Path: trunk/ChangeLog
File size: 24765 byte(s)
Remove the unneeded canonicalize() calls in the wrappers - we do it anyhow
in check_syscall().  Should speed things up a bit (at least for the getcwd()
and long path name test it goes down to under a second, and not 10+ seconds
like before).  Also warn if we skip checking due to the canonicalized path
being too long.

1 ferringb 2 # ChangeLog for Path Sandbox
2 vapier 53 # Copyright 1999-2005 Gentoo Foundation; Distributed under the GPL v2
3 ferringb 2 # $Header$
4    
5 azarah 118 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
6 azarah 119 Remove the unneeded canonicalize() calls in the wrappers - we do it anyhow
7     in check_syscall(). Should speed things up a bit (at least for the getcwd()
8     and long path name test it goes down to under a second, and not 10+ seconds
9     like before). Also warn if we skip checking due to the canonicalized path
10     being too long.
11    
12     11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
13 azarah 118 More comment/readability cleanups.
14    
15 azarah 117 10 June 2005; Martin Schlemmer <azarah@gentoo.org> canonicalize.c, getcwd.c,
16     sandbox_futils.c, libsandbox.c:
17     Some strncpy/strncat and other cleanups.
18    
19 azarah 115 * sandbox-1.2.9 (2005/06/09)
20    
21 azarah 114 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
22     Move symlink hack down a bit to try and minimize on the amount of lstat()
23     calls we do.
24    
25 azarah 113 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
26     Add hack to allow writing to /proc/self/fd (or /dev/fd), bug #91516.
27    
28 azarah 112 09 June 2005; Martin Schlemmer <azarah@gentoo.org> symbols.in, libsandbox.c:
29     Add wrapper for access() function, bug #85413.
30    
31 azarah 111 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c:
32     Use generic getcwd() implementation from uclibc - should be more portable
33     and looks a bit cleaner.
34    
35 azarah 110 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c:
36     Make sure our true_* pointers are initialized to NULL, and that we check for
37     all references that they are valid.
38    
39 azarah 109 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
40     Be default we will fail if the path name we try to canonicalize is too long.
41     This however could cause issues with some things (bug #94630 and #21766), so
42     if fail_nametoolong == 0, canonicalize() will return a null length string and
43     do not fail.
44    
45 azarah 108 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c:
46     Do not abort if TMPDIR is not valid, but rather use '/tmp', bug #94360. Also
47     make sure we re-export the new TMPDIR environment variable.
48    
49 azarah 106 08 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
50     Fix incorrect free of non-malloc'd array, bug #92313 and #94020. Fix noted
51     by Marcus D. Hanwell <cryos@gentoo.org>.
52    
53 azarah 105 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
54     Add /dev/console to write list, bug #38588.
55    
56 azarah 102 * sandbox-1.2.8 (2005/05/13)
57    
58 azarah 99 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
59 azarah 101 sandbox.h, sandbox_futils.c:
60     General cleanups.
61    
62     13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
63 azarah 100 sandbox.h:
64     Various LD_PRELOAD cleanups. Do not unset LD_PRELOAD for parent.
65    
66     13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
67 azarah 99 sandbox.h, sandbox_futils.c:
68     Modify get_sandbox_pids_file(), get_sandbox_log() and get_sandbox_debug_log()
69     to use TMPDIR if present in environment.
70    
71 azarah 98 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
72     Remove sandbox_log_file from main() as its no longer used.
73    
74 azarah 97 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
75     sandbox_futils.c:
76     Add get_sandbox_debug_log(), and use it (add behaviour similar to SANDBOX_LOG
77     if already exported when sandbox started). Fix get_sandbox_log() and new
78     get_sandbox_debug_log() to not use already exported environment variables if
79     they have '/' in them. Use snprintf()'s instead of strncpy()'s. More
80     SB_PATH_MAX fixes.
81    
82 azarah 94 * sandbox-1.2.7 (2005/05/12)
83    
84 azarah 93 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
85     sandbox_futils.c:
86     More path limit fixes. Declare SB_BUF_LEN global and use it where needed.
87    
88 azarah 92 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
89     Fix paths limited to 255 chars. Fix get_sandbox_dir() returning a string
90     with '(null)' in it if we did not call sandbox with absolute path.
91    
92 azarah 89 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
93 azarah 91 Set SANDBOX_ON *before* doing the child's env stuff, else its not set
94     for the child.
95    
96     12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
97 azarah 90 Remove global preload_adaptable as it is no longer used.
98    
99     12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
100 azarah 89 Rewrite environment stuff to only be set when execve'ing the child process
101     to try and avoid issues like bug #91541 that causes sandbox to crash if
102     we set LD_PRELOAD sandbox side already.
103    
104 azarah 87 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
105 azarah 88 Move print_sandbox_log() up to make things neater.
106    
107     11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
108 azarah 87 Remove load_preload_libs(), as its not used anymore.
109    
110 azarah 83 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
111 azarah 86 Remove NO_FORK stuff, as its not used, and 'strace -f' works just fine.
112    
113     11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
114 azarah 84 Remove USE_SYSTEM_SHELL stuff, as it is not secure, and not in use.
115    
116     11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
117 azarah 83 Remove ld.so.preload crap - we are not going to use it again.
118    
119 azarah 82 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
120     Fix typo in code that checks if we got valid group information, causing a
121     segmentation fault, bug #91637.
122    
123 azarah 79 * sandbox-1.2.6 (2005/05/10)
124    
125 azarah 78 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
126     Do not use LD_PRELOAD if it contains libtsocks.so, as it breaks sandbox
127     for some odd reason, bug #91541.
128    
129 azarah 77 09 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
130     Fix typo (sizeof -> strlen).
131    
132 ferringb 76 08 May 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
133     rewrote the sbcontext caching code so it accounts for env changes since lib
134     initialization.
135    
136 azarah 75 05 May 2005; Martin Schlemmer <azarah@gentoo.org> configure.in, libctest.c:
137     We create libctest.c via configure, so no need to keep it around. Do some
138     cleanup related to libctest.c and libctest during configure.
139    
140 azarah 74 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
141     Add rename support of symlinks pointing to protected files/directories.
142    
143 azarah 72 * sandbox-1.2.5 (2005/05/04)
144    
145 azarah 71 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
146     sandbox.bashrc:
147     Do not reset already set LD_PRELOAD when starting sandbox. If LD_PRELOAD is
148     already set, init of the env vars fails for some reason, so do this later on,
149     and do not warn (bug #91431).
150    
151 azarah 70 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
152     sandbox.bashrc:
153     Fixup sandbox and sandbox.bashrc to call bash with the proper .bashrc.
154    
155 azarah 68 * sandbox-1.2.4 (2005/05/03)
156    
157 azarah 66 03 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
158     Do not init the env entries with each call, as it creates too many calls to
159 azarah 67 lstat, etc. Should speedup things a bit, bug #91040.
160 azarah 66
161 azarah 65 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
162     Add /dev/pty to default write list. Noticed by Morfic.
163    
164 vapier 62 02 May 2005; Mike Frysinger <vapier@gentoo.org> configure.in, localdecls.h,
165     sandbox.h:
166     uClibc doesn't support dlvsym() so add a configure check to make sure it doesn't
167     exist. Also update localdecls.h so BROKEN_RTLD_NEXT isn't defined in uClibc.
168    
169 azarah 59 * sandbox-1.2.3 (2005/04/29)
170    
171 azarah 56 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> configure.in:
172     Do not check for (*&#$(* CXX or F77.
173    
174 azarah 54 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
175     Do not append '/' to pathname in filter_path() if it already ends with it.
176    
177 vapier 53 28 Apr 2005; Mike Frysinger <vapier@gentoo.org> Makefile.am, configure.in:
178     With az's help, clean up autotools to work with cross-compiling.
179    
180 azarah 59 * sandbox-1.2.2 (2005/04/28)
181 azarah 48
182 azarah 47 28 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
183     Only check for /dev/{null,zero} for unlink hack, else ricers using /dev/shm
184     have issues; bug #90592.
185    
186 azarah 59 * sandbox-1.2.1 (2005/04/23)
187 azarah 44
188 azarah 43 23 Apr 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
189     getcwd.c, libsandbox.c, localdecls.h, sandbox.h, sandbox_futils.c:
190     Make sure all functions used in libsandbox.c is declared static. Define
191     SB_STATIC in localdecls.h for this. Include sandbox_futils.c rather than
192     linking with its object. Hopefully this will fix bug #90153.
193    
194 azarah 59 * sandbox-1.2 (2005/04/23)
195 azarah 46
196 azarah 40 22 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
197     Allow lchown a symlink in write-allowed path pointing to write-denied
198     target.
199    
200 genone 39 21 Mar 2005; Marius Mauch <genone@gentoo.org> libsandbox.c:
201     Also show resolved symlink names in the log.
202    
203 azarah 37 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, libsandbox.c:
204     Seems -nostdlib was the problem with the constructor/destructor - remove it
205     from Makefile.am, and change the constructor/destructor names again.
206    
207 azarah 36 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
208     Also rename the _init() and _fini() declarations.
209    
210 azarah 35 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
211     Fixup the constructor/destructor function names again (they should be _init()
212     and _fini() it seems, and not being called caused sandbox_lib_path to be
213     unset, and thus breaking the execve() wrapper's LD_PRELOAD protection).
214     Add both the path in given SANDBOX_x variable, as well as its symlink
215     resolved path in init_env_entries(). Modify filter_path() to be able to
216     resolve paths without resolving symlinks, as well as to be able to resolve
217     symlinks. Fix a possible segfault in check_access(). Add symlink resolving
218     to check_access() resolving bug #31019. Add 'hack' for unlink, as the fix
219     for bug #31019 cause access violations if we try to remove a symlink that is
220     not in protected path, but points to a protected path. Fix a memory leak in
221     sandbox.c (sandbox_pids_file in main()). Fix the realpath() calls in main()
222     (sandbox.c) being unchecked. Fix the debug logname not having the pid in it
223     (pid_string was uninitialized). General syntax cleanups.
224    
225 ferringb 34 09 Mar 2005; Brian Harring <ferringb@gentoo.org> sandbox.c: Fixed the
226     infamous "pids file is not a regular file" w/out newline bug.
227    
228 ferringb 33 09 Mar 2005; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in:
229     Correct libc_version path detection, since it was screwing up if libdir !=
230     "/lib/".
231    
232     02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
233 azarah 32 Hack to make sure sandboxed process cannot remove a device node, bug #79836.
234    
235 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am:
236 azarah 31 Fix symbols.in not added to dist.
237    
238 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
239 azarah 30 getcwd.c, libsandbox.c, sandbox.c, sandbox.h, sandbox_futils.c:
240     White space fixes.
241    
242 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
243 azarah 30 configure.in, getcwd.c, libsandbox.c, symbols.in:
244 azarah 29 Fix inverse test logic in canonicalize.c, use a strncpy. Fix gcc warning in
245     getcwd.c. Add symbols.in and logic to Makefile.am to generate symbol versions
246     for glibc and other libc's that use this. Update libsandbox.c to use these
247     symbol versions if available. Fix exec wrapper to re-export LD_PRELOAD if the
248     process unset it.
249    
250 ferringb 33 01 Mar 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
251 ferringb 28 killed off _init and _fini in favor of
252     void __attribute__ ((constructor)) init_func and
253     void __attribute__ ((destructor)) closing_func. _(init|func) were deprecated.
254    
255 ferringb 26 06 Dec 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, libsandbox.c,
256     canonicalize.c, getcwd.c: Fixed compilation *again*. Hopefully cvs is done
257     having the hick-ups.
258    
259 ferringb 24 04 Dec 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, getcwd.c,
260     Makefile.am: Fixed compilation.
261    
262 ferringb 18 01 Dec 2004; Brian Harring <ferringb@gentoo.org> aclocal.m4:
263     Gutted the bugger so it stops checking for a c++ and fortran compiler.
264     Do *not* regenerate aclocal.m4 for making a release until a better
265     solution is created.
266    
267 ferringb 16 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, sandbox_futils.c:
268     Removal of more hardcoded paths.
269    
270 ferringb 13 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in,
271     sandbox_futils.c: tweaks to install sandbox.bashrc, and use it.
272    
273     19 Nov 2004; Brian Harring <ferringb@gentoo.org>:
274 ferringb 6 Sandbox is now autotooled, create-localdecls needs to be killed and the code
275     shifted into configure.in. Currently builds *one* libsandbox.so- if multiple
276     are desired (-m64 and -m32 for amd64), the ebuild should do it (imo).
277     To get to a point of testing, automake && autoconf; created requisite files w/
278     a(utomake|clocal)-1.8, and autoconf 2.59. Installs to /usr/, instead of
279     /lib and /usr/lib/portage/bin.
280    
281 ferringb 2 14 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox.c:
282     closing out bug #70225, potential overflow of the sandbox_pids_file var.
283    
284     07 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c: c99 standard,
285     (think it was at least) allows intermixing of code and data segments. bug #70351
286     should be fixed by this.
287    
288     03 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox_futils.c:
289     futils fix from bug #65201 via solar, and libsandbox log path checks via #69137
290    
291     02 Aug 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Code from
292     Seth Robertson that tracked down all adjuct flags for read operations that
293     do not invoke a write operation.
294    
295     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
296     Another fix from jstubbs regarding a free() on a stack variable for the
297     environment -- tracking now prevents extraneous free()'s segfault.
298    
299     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
300     J. Stubbs tracked down a new bug where mkdir was failing to the patch on
301     the lstat in mkdir... it now only returns 0 or -1 as documented for mkdir.
302     Also remove the errno = ESUCCESS settings as documentation points out that
303     a library isn't allowed to do that.
304    
305     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Added a
306     file_security_check() function to check random potential exploits on files
307     that sandbox is to load and read -- Normally sandboxpids.tmp. This fixes
308     the 'system-crippling' exploits (bug 21923) and catches a few other
309     potential problems.
310    
311     20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> Makefile: Updates for
312     32/64 bit sandbox. Made CC and LD '?=' values to allow passed in CC to work.
313    
314     20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c:
315     bug 42048 -- Fixed the lstat/errno conditions for mkdir <caleb@g.o>.
316     Added the 64/32 bit sandbox patch for AMD64 bug 32963 <brad/azarah>.
317    
318     29 Feb 2004; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c :
319     Fix permissions and group of pids file and logs. Permissions should be 0664
320     and group should be 'portage'. Bug #34260.
321    
322     28 Feb 2004; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
323     Besides a small cleanup, redo how we replace LD_PRELOAD in the environ passed
324     to the real execve (in our execve wrapper). Seems that on some arches (sparc
325     among others) do not allow us to tamper with the readonly copy passed to
326     execve, so pass our own copy of the environment. Bug #42290.
327    
328     11 Jan 2004; Nicholas Jones <carpaski@gentoo.org> create-decls:
329     Changed tail to head and added a notice about duration of glibc check.
330    
331     21 Dec 2003; Nicholas Jones <carpaski@gentoo.org> create-decls:
332     Changed the glibc subversion check to use /usr/bin/* instead of /bin/sh
333     as there isn't a guarentee that it is dynamic.
334    
335     02 Nov 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
336     If 'file' passed to before_syscall(const char *func, const char *file) is
337     invalid, we should set errno to ENOENT, and not EINVAL. This should
338     close bug #32238.
339    
340     14 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
341     Fix a bug that occurs mainly on 64bit arch, where the file passed to
342     the functions we wrap, is invalid, and then cause canonicalize to pass
343     garbage to before_syscall(), thanks to great detective work from
344     Andrea Luzzardi <al@sig11.org> (bug #29846).
345    
346     13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
347     Add a uClibc detection patch from Peter S. Mazinger <ps.m@gmx.net>.
348    
349     13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
350     Fix a bug in libsandbox.c 's checking in the rename wrapper - it basically
351     only checked the destination patch, and not the source, so we could move
352     a protected file to a unprotected directory, and then delete/modify it.
353     Thanks to Andrea Luzzardi (scox) <al@sig11.org>, bug #30992, for this fix.
354    
355     12 Oct 2003; Nicholas Jones <carpaski@gentoo.org> sandbox.c :
356     Added python2.3 to the predict section/variable.
357    
358     28 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
359     sandbox.h, sandbox_futils.c :
360     Add support to set the pids file via SANDBOX_PIDS_FILE at startup. If
361     it is not set, it will revert to its old value.
362    
363     27 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
364     Fix our mkdir wrapper to check if the dir exist, and return EEXIST if so,
365     rather than failing with a violation, bug #29748.
366    
367     27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
368     Fix canonicalize() to ignore calls with path = "".
369    
370     27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c,
371     sandbox_futils.c, canonicalize.c :
372     Once again coreutils fails, as my systems had 2.5 kernel, the getcwd system
373     call handled strings larger than PATH_MAX (bug #21766). It however does not
374     work the same on 2.4 kernels.
375    
376     To fix, I added the posix implementation of getcwd() (from glibc cvs) that
377     do not need the system call. We use the default getcwd() function via a
378     wrapper (egetcwd), and then lstat the returned path. If lstat fails, it
379     means the current directory was removed, OR that the the system call for
380     getcwd failed (curious is that it do not fail and return NULL or set
381     errno, but rather just truncate the retured directory - usually from the
382     start), and if so, we use the generic getcwd() function (__egetcwd). Note
383     that we do not use the generic version all the time, as it calls lstat()
384     a great number of times, and performance degrade much.
385    
386     29 Jun 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls,
387     libsandbox.c :
388     Make sure SB_PATH_MAX will not wrap. Fix two possible memory leaks.
389    
390     22 Jun 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, canonicalize.c
391     create-localdecls :
392     When checking path names of files accessed, we need to canonicalize it, else
393     it may be a symlink in a 'write allowed' directory pointing to a file in a
394     directory we should not have write access to.
395    
396     With something like coreutils-5.0, we have two problems:
397     1) One of the tests checks if getcwd() can return a path longer than
398     PATH_MAX. This test then tries to create a dir which even while
399     created local (mkdir("conftest2")), it ends up being resolved with
400     a name that is much larger than PATH_MAX. The problem now is that
401     canonicalize() have undefined behaviour when the path was too long
402     (returned wrongly truncated paths, etc), and pass the wrong path to
403     before_syscall() (causing the bogus sandbox violations).
404     2) The ecanonicalize() function we used, along with the canonicalize()
405     function did not support longer than PATH_MAX. This is partly a
406     cause for 1), but the error checking (rather lack of it) of calls
407     to erealpath() in canonicalize() was the prime reason for 1).
408    
409     As we do not use this canonicalized name to call the function, we resolve this
410     by fixing canonicalize() to do better error checking, and ecanonicalize() as
411     well as all functions in libsandbox.c to use a PATH_MAX of 'PATH_MAX * 2'.
412     While they will resolve paths properly now, and can check if a write/read is
413     allowed, the functions called from the sandboxed environment will still work
414     as expected.
415    
416     This should resolve bug #21766.
417    
418     06 Apr 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
419     For some reason sandbox fails with a 'open_wr' if you run 'locale -a' under
420     it (bug #16298).
421    
422     Problem is that for some reason locale fopen's locale.alias with mode "rm".
423    
424     -------------------------------------------------------
425     nosferatu root # grep fopen locale.log
426     fopen("/usr/share/locale/locale.alias", "rm"ACCESS DENIED open_wr: /usr/share/locale/locale.alias
427     nosferatu root #
428     --------------------------------------------------------
429    
430     I checked the source of locale, but it have fopen with mode 'r', so
431     not sure where the "rm" mode comes from. Anyhow, changed the check in
432     before_syscall_open_char() to also see mode "rm" as readonly.
433    
434     23 Feb 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
435    
436     Add glibc-2.3 support.
437    
438     22 Feb 2003; Martin Schlemmer <azarah@gentoo.org> sandbox.c :
439    
440     Some /etc/ld.so.preload fixes. Just changed the #if defines to cover all
441     operations releated to preload, as well as only try to modify ld.so.preload
442     if we can. Also modify to write the pid to /tmp/sandboxpids.tmp even when
443     not using ld.so.preload. Fix to not write this instance of sandbox's pid
444     to /tmp/sandboxpids.tmp on exit if this is not the last sandbox running.
445    
446     22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> Makefile :
447    
448     Changed the LD to CC for hppa.
449    
450     22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
451    
452     Killed the previous changes I made.
453    
454     17 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
455    
456     Added parisc to BROKEN_RTLD_ARCHLIST to see if it we can fix the relocation probs.
457    
458     09 Jan 2003; J Robert Ray <jrray@gentoo.org> sandbox.c :
459    
460     Don't segfault if $HOME isn't set, set $HOME to "/" instead. Fixes bug 10868.
461    
462     16 Dec 2002; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
463    
464     Fix memory leak for mips, bug #12236. Thanks to Torgeir Hansen <torgeir@trenger.ro>
465     for this fix.
466    
467     4 Dec 2002; J Robert Ray <jrray@gentoo.org> sandbox.h sandbox_futils.c :
468    
469     sandbox_futils defined a dirname() function that was masking the same
470     function in glibc and was broken (e.g.: SANDBOX_DIR was being set to
471     '/usr/lib/portage/bi/'). Fixed function to return expected results and
472     renamed it to sb_dirname() to no longer mask the glibc function. Closes bug
473     11231.
474    
475     4 Dec 2002; Martin Schlemmer <azarah@gentoo.org> :
476    
477     Fix a segfault in libsandbox.c if canonicalize() was called with
478     first parameter = NULL.
479    
480     1 Sep 2002; Martin Schlemmer <azarah@gentoo.org> :
481    
482     Fix my braindead 'return 1;' in a void function. Updated sandbox.c,
483     cleanup() for this.
484    
485     Change cleanup() in sandbox.c not to exit with fail status if
486     the pidsfile is missing. We really should still display sandbox
487     violations if they occured.
488    
489     31 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
490    
491     Update cleanup() in sandbox.c to remove the PIDSFILE if this is
492     the last sandbox running.
493    
494     25 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
495    
496     Major cleanups to mainly libsandbox.c again.
497    
498     22 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
499    
500     Add copyrights to sandbox.h and sandbox_futils.h. If wrong, the
501     parties involved should please contact me so that we can fix it.
502    
503     Add opendir wrapper to libsandbox.c.
504    
505     21 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
506    
507     Do some more cleanups to ecanonicalize(), as it dropped filenames in
508     rare cases (after my symlink cleanups), and caused glibc to bork.
509     These fixes went into canonicalize.c.
510    
511     20 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
512    
513     Fix spawn_shell() and main() in sandbox.c to properly return fail
514     status.
515    
516     19 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
517    
518     The new canonicalize() function in libsandbox.c also resolved symlinks,
519     which caused on cleaning sandbox errors if the symlink pointed to a
520     file in the live root. Ripped out canonicalize() and realpath() from
521     glibc; removed the symlink stuff, and changed them to ecanonicalize()
522     and erealpath().
523    
524     18 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
525    
526     Ripped out all the wrappers, and implemented those of InstallWatch.
527     Losts of cleanups and bugfixes. Implement a execve that forces
528     $LIBSANDBOX in $LD_PRELOAD. We can now thus do away with the feared
529     /etc/ld.so.preload (*g*) ... Made the needed changes to sandbox.c,
530     sandbox.h and sandbox_futils.c. Rewrote the Makefile for most
531     parts; it now have an install target.
532    
533     Reformat the whole thing to look somewhat like the reworked sandbox.c
534     and new sandbox.h and sandbox_futils.c from:
535    
536     Brad House <brad@mainstreetsoftworks.com>.
537    
538     Additional Copyrights now due to the InstallWatch code:
539    
540     Copyright (C) 1998-9 Pancrazio `Ezio' de Mauro <p@demauro.net>

Properties

Name Value
svn:eol-style native
svn:keywords Author Date Id Revision

  ViewVC Help
Powered by ViewVC 1.1.20