/[path-sandbox]/trunk/ChangeLog.0
Gentoo

Contents of /trunk/ChangeLog.0

Parent Directory Parent Directory | Revision Log Revision Log


Revision 126 - (hide annotations) (download)
Sun Jul 3 18:46:52 2005 UTC (9 years ago) by azarah
Original Path: trunk/ChangeLog
File size: 25426 byte(s)
Add PREDICT items for nss-db, bug #92079.  Patch from Robin Johnson.
1 ferringb 2 # ChangeLog for Path Sandbox
2 vapier 53 # Copyright 1999-2005 Gentoo Foundation; Distributed under the GPL v2
3 ferringb 2 # $Header$
4    
5 azarah 126 03 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
6     Add PREDICT items for nss-db, bug #92079. Patch from Robin Johnson.
7    
8 azarah 123 17 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
9     General cleanups:
10     - Remove fooling around with exit codes - we error out on presence of a log
11     anyhow.
12 azarah 124 - Move get_sandbox_*_envvar() to sandbox_setup_environ(), as its more
13     appropriate there.
14 azarah 123
15 azarah 121 12 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
16     Cleanup the fail_nametoolong stuff a bit more.
17    
18 azarah 118 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
19 azarah 120 Remove hopefully the last ld.so.preload bits we do not use anymore.
20    
21     11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
22 azarah 119 Remove the unneeded canonicalize() calls in the wrappers - we do it anyhow
23     in check_syscall(). Should speed things up a bit (at least for the getcwd()
24     and long path name test it goes down to under a second, and not 10+ seconds
25     like before). Also warn if we skip checking due to the canonicalized path
26     being too long.
27    
28     11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
29 azarah 118 More comment/readability cleanups.
30    
31 azarah 117 10 June 2005; Martin Schlemmer <azarah@gentoo.org> canonicalize.c, getcwd.c,
32     sandbox_futils.c, libsandbox.c:
33     Some strncpy/strncat and other cleanups.
34    
35 azarah 115 * sandbox-1.2.9 (2005/06/09)
36    
37 azarah 114 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
38     Move symlink hack down a bit to try and minimize on the amount of lstat()
39     calls we do.
40    
41 azarah 113 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
42     Add hack to allow writing to /proc/self/fd (or /dev/fd), bug #91516.
43    
44 azarah 112 09 June 2005; Martin Schlemmer <azarah@gentoo.org> symbols.in, libsandbox.c:
45     Add wrapper for access() function, bug #85413.
46    
47 azarah 111 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c:
48     Use generic getcwd() implementation from uclibc - should be more portable
49     and looks a bit cleaner.
50    
51 azarah 110 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c:
52     Make sure our true_* pointers are initialized to NULL, and that we check for
53     all references that they are valid.
54    
55 azarah 109 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
56     Be default we will fail if the path name we try to canonicalize is too long.
57     This however could cause issues with some things (bug #94630 and #21766), so
58     if fail_nametoolong == 0, canonicalize() will return a null length string and
59     do not fail.
60    
61 azarah 108 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c:
62     Do not abort if TMPDIR is not valid, but rather use '/tmp', bug #94360. Also
63     make sure we re-export the new TMPDIR environment variable.
64    
65 azarah 106 08 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
66     Fix incorrect free of non-malloc'd array, bug #92313 and #94020. Fix noted
67     by Marcus D. Hanwell <cryos@gentoo.org>.
68    
69 azarah 105 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
70     Add /dev/console to write list, bug #38588.
71    
72 azarah 102 * sandbox-1.2.8 (2005/05/13)
73    
74 azarah 99 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
75 azarah 101 sandbox.h, sandbox_futils.c:
76     General cleanups.
77    
78     13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
79 azarah 100 sandbox.h:
80     Various LD_PRELOAD cleanups. Do not unset LD_PRELOAD for parent.
81    
82     13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
83 azarah 99 sandbox.h, sandbox_futils.c:
84     Modify get_sandbox_pids_file(), get_sandbox_log() and get_sandbox_debug_log()
85     to use TMPDIR if present in environment.
86    
87 azarah 98 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
88     Remove sandbox_log_file from main() as its no longer used.
89    
90 azarah 97 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
91     sandbox_futils.c:
92     Add get_sandbox_debug_log(), and use it (add behaviour similar to SANDBOX_LOG
93     if already exported when sandbox started). Fix get_sandbox_log() and new
94     get_sandbox_debug_log() to not use already exported environment variables if
95     they have '/' in them. Use snprintf()'s instead of strncpy()'s. More
96     SB_PATH_MAX fixes.
97    
98 azarah 94 * sandbox-1.2.7 (2005/05/12)
99    
100 azarah 93 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
101     sandbox_futils.c:
102     More path limit fixes. Declare SB_BUF_LEN global and use it where needed.
103    
104 azarah 92 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
105     Fix paths limited to 255 chars. Fix get_sandbox_dir() returning a string
106     with '(null)' in it if we did not call sandbox with absolute path.
107    
108 azarah 89 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
109 azarah 91 Set SANDBOX_ON *before* doing the child's env stuff, else its not set
110     for the child.
111    
112     12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
113 azarah 90 Remove global preload_adaptable as it is no longer used.
114    
115     12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
116 azarah 89 Rewrite environment stuff to only be set when execve'ing the child process
117     to try and avoid issues like bug #91541 that causes sandbox to crash if
118     we set LD_PRELOAD sandbox side already.
119    
120 azarah 87 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
121 azarah 88 Move print_sandbox_log() up to make things neater.
122    
123     11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
124 azarah 87 Remove load_preload_libs(), as its not used anymore.
125    
126 azarah 83 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
127 azarah 86 Remove NO_FORK stuff, as its not used, and 'strace -f' works just fine.
128    
129     11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
130 azarah 84 Remove USE_SYSTEM_SHELL stuff, as it is not secure, and not in use.
131    
132     11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
133 azarah 83 Remove ld.so.preload crap - we are not going to use it again.
134    
135 azarah 82 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
136     Fix typo in code that checks if we got valid group information, causing a
137     segmentation fault, bug #91637.
138    
139 azarah 79 * sandbox-1.2.6 (2005/05/10)
140    
141 azarah 78 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
142     Do not use LD_PRELOAD if it contains libtsocks.so, as it breaks sandbox
143     for some odd reason, bug #91541.
144    
145 azarah 77 09 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
146     Fix typo (sizeof -> strlen).
147    
148 ferringb 76 08 May 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
149     rewrote the sbcontext caching code so it accounts for env changes since lib
150     initialization.
151    
152 azarah 75 05 May 2005; Martin Schlemmer <azarah@gentoo.org> configure.in, libctest.c:
153     We create libctest.c via configure, so no need to keep it around. Do some
154     cleanup related to libctest.c and libctest during configure.
155    
156 azarah 74 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
157     Add rename support of symlinks pointing to protected files/directories.
158    
159 azarah 72 * sandbox-1.2.5 (2005/05/04)
160    
161 azarah 71 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
162     sandbox.bashrc:
163     Do not reset already set LD_PRELOAD when starting sandbox. If LD_PRELOAD is
164     already set, init of the env vars fails for some reason, so do this later on,
165     and do not warn (bug #91431).
166    
167 azarah 70 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
168     sandbox.bashrc:
169     Fixup sandbox and sandbox.bashrc to call bash with the proper .bashrc.
170    
171 azarah 68 * sandbox-1.2.4 (2005/05/03)
172    
173 azarah 66 03 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
174     Do not init the env entries with each call, as it creates too many calls to
175 azarah 67 lstat, etc. Should speedup things a bit, bug #91040.
176 azarah 66
177 azarah 65 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
178     Add /dev/pty to default write list. Noticed by Morfic.
179    
180 vapier 62 02 May 2005; Mike Frysinger <vapier@gentoo.org> configure.in, localdecls.h,
181     sandbox.h:
182     uClibc doesn't support dlvsym() so add a configure check to make sure it doesn't
183     exist. Also update localdecls.h so BROKEN_RTLD_NEXT isn't defined in uClibc.
184    
185 azarah 59 * sandbox-1.2.3 (2005/04/29)
186    
187 azarah 56 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> configure.in:
188     Do not check for (*&#$(* CXX or F77.
189    
190 azarah 54 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
191     Do not append '/' to pathname in filter_path() if it already ends with it.
192    
193 vapier 53 28 Apr 2005; Mike Frysinger <vapier@gentoo.org> Makefile.am, configure.in:
194     With az's help, clean up autotools to work with cross-compiling.
195    
196 azarah 59 * sandbox-1.2.2 (2005/04/28)
197 azarah 48
198 azarah 47 28 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
199     Only check for /dev/{null,zero} for unlink hack, else ricers using /dev/shm
200     have issues; bug #90592.
201    
202 azarah 59 * sandbox-1.2.1 (2005/04/23)
203 azarah 44
204 azarah 43 23 Apr 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
205     getcwd.c, libsandbox.c, localdecls.h, sandbox.h, sandbox_futils.c:
206     Make sure all functions used in libsandbox.c is declared static. Define
207     SB_STATIC in localdecls.h for this. Include sandbox_futils.c rather than
208     linking with its object. Hopefully this will fix bug #90153.
209    
210 azarah 59 * sandbox-1.2 (2005/04/23)
211 azarah 46
212 azarah 40 22 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
213     Allow lchown a symlink in write-allowed path pointing to write-denied
214     target.
215    
216 genone 39 21 Mar 2005; Marius Mauch <genone@gentoo.org> libsandbox.c:
217     Also show resolved symlink names in the log.
218    
219 azarah 37 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, libsandbox.c:
220     Seems -nostdlib was the problem with the constructor/destructor - remove it
221     from Makefile.am, and change the constructor/destructor names again.
222    
223 azarah 36 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
224     Also rename the _init() and _fini() declarations.
225    
226 azarah 35 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
227     Fixup the constructor/destructor function names again (they should be _init()
228     and _fini() it seems, and not being called caused sandbox_lib_path to be
229     unset, and thus breaking the execve() wrapper's LD_PRELOAD protection).
230     Add both the path in given SANDBOX_x variable, as well as its symlink
231     resolved path in init_env_entries(). Modify filter_path() to be able to
232     resolve paths without resolving symlinks, as well as to be able to resolve
233     symlinks. Fix a possible segfault in check_access(). Add symlink resolving
234     to check_access() resolving bug #31019. Add 'hack' for unlink, as the fix
235     for bug #31019 cause access violations if we try to remove a symlink that is
236     not in protected path, but points to a protected path. Fix a memory leak in
237     sandbox.c (sandbox_pids_file in main()). Fix the realpath() calls in main()
238     (sandbox.c) being unchecked. Fix the debug logname not having the pid in it
239     (pid_string was uninitialized). General syntax cleanups.
240    
241 ferringb 34 09 Mar 2005; Brian Harring <ferringb@gentoo.org> sandbox.c: Fixed the
242     infamous "pids file is not a regular file" w/out newline bug.
243    
244 ferringb 33 09 Mar 2005; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in:
245     Correct libc_version path detection, since it was screwing up if libdir !=
246     "/lib/".
247    
248     02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
249 azarah 32 Hack to make sure sandboxed process cannot remove a device node, bug #79836.
250    
251 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am:
252 azarah 31 Fix symbols.in not added to dist.
253    
254 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
255 azarah 30 getcwd.c, libsandbox.c, sandbox.c, sandbox.h, sandbox_futils.c:
256     White space fixes.
257    
258 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
259 azarah 30 configure.in, getcwd.c, libsandbox.c, symbols.in:
260 azarah 29 Fix inverse test logic in canonicalize.c, use a strncpy. Fix gcc warning in
261     getcwd.c. Add symbols.in and logic to Makefile.am to generate symbol versions
262     for glibc and other libc's that use this. Update libsandbox.c to use these
263     symbol versions if available. Fix exec wrapper to re-export LD_PRELOAD if the
264     process unset it.
265    
266 ferringb 33 01 Mar 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
267 ferringb 28 killed off _init and _fini in favor of
268     void __attribute__ ((constructor)) init_func and
269     void __attribute__ ((destructor)) closing_func. _(init|func) were deprecated.
270    
271 ferringb 26 06 Dec 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, libsandbox.c,
272     canonicalize.c, getcwd.c: Fixed compilation *again*. Hopefully cvs is done
273     having the hick-ups.
274    
275 ferringb 24 04 Dec 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, getcwd.c,
276     Makefile.am: Fixed compilation.
277    
278 ferringb 18 01 Dec 2004; Brian Harring <ferringb@gentoo.org> aclocal.m4:
279     Gutted the bugger so it stops checking for a c++ and fortran compiler.
280     Do *not* regenerate aclocal.m4 for making a release until a better
281     solution is created.
282    
283 ferringb 16 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, sandbox_futils.c:
284     Removal of more hardcoded paths.
285    
286 ferringb 13 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in,
287     sandbox_futils.c: tweaks to install sandbox.bashrc, and use it.
288    
289     19 Nov 2004; Brian Harring <ferringb@gentoo.org>:
290 ferringb 6 Sandbox is now autotooled, create-localdecls needs to be killed and the code
291     shifted into configure.in. Currently builds *one* libsandbox.so- if multiple
292     are desired (-m64 and -m32 for amd64), the ebuild should do it (imo).
293     To get to a point of testing, automake && autoconf; created requisite files w/
294     a(utomake|clocal)-1.8, and autoconf 2.59. Installs to /usr/, instead of
295     /lib and /usr/lib/portage/bin.
296    
297 ferringb 2 14 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox.c:
298     closing out bug #70225, potential overflow of the sandbox_pids_file var.
299    
300     07 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c: c99 standard,
301     (think it was at least) allows intermixing of code and data segments. bug #70351
302     should be fixed by this.
303    
304     03 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox_futils.c:
305     futils fix from bug #65201 via solar, and libsandbox log path checks via #69137
306    
307     02 Aug 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Code from
308     Seth Robertson that tracked down all adjuct flags for read operations that
309     do not invoke a write operation.
310    
311     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
312     Another fix from jstubbs regarding a free() on a stack variable for the
313     environment -- tracking now prevents extraneous free()'s segfault.
314    
315     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
316     J. Stubbs tracked down a new bug where mkdir was failing to the patch on
317     the lstat in mkdir... it now only returns 0 or -1 as documented for mkdir.
318     Also remove the errno = ESUCCESS settings as documentation points out that
319     a library isn't allowed to do that.
320    
321     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Added a
322     file_security_check() function to check random potential exploits on files
323     that sandbox is to load and read -- Normally sandboxpids.tmp. This fixes
324     the 'system-crippling' exploits (bug 21923) and catches a few other
325     potential problems.
326    
327     20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> Makefile: Updates for
328     32/64 bit sandbox. Made CC and LD '?=' values to allow passed in CC to work.
329    
330     20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c:
331     bug 42048 -- Fixed the lstat/errno conditions for mkdir <caleb@g.o>.
332     Added the 64/32 bit sandbox patch for AMD64 bug 32963 <brad/azarah>.
333    
334     29 Feb 2004; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c :
335     Fix permissions and group of pids file and logs. Permissions should be 0664
336     and group should be 'portage'. Bug #34260.
337    
338     28 Feb 2004; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
339     Besides a small cleanup, redo how we replace LD_PRELOAD in the environ passed
340     to the real execve (in our execve wrapper). Seems that on some arches (sparc
341     among others) do not allow us to tamper with the readonly copy passed to
342     execve, so pass our own copy of the environment. Bug #42290.
343    
344     11 Jan 2004; Nicholas Jones <carpaski@gentoo.org> create-decls:
345     Changed tail to head and added a notice about duration of glibc check.
346    
347     21 Dec 2003; Nicholas Jones <carpaski@gentoo.org> create-decls:
348     Changed the glibc subversion check to use /usr/bin/* instead of /bin/sh
349     as there isn't a guarentee that it is dynamic.
350    
351     02 Nov 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
352     If 'file' passed to before_syscall(const char *func, const char *file) is
353     invalid, we should set errno to ENOENT, and not EINVAL. This should
354     close bug #32238.
355    
356     14 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
357     Fix a bug that occurs mainly on 64bit arch, where the file passed to
358     the functions we wrap, is invalid, and then cause canonicalize to pass
359     garbage to before_syscall(), thanks to great detective work from
360     Andrea Luzzardi <al@sig11.org> (bug #29846).
361    
362     13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
363     Add a uClibc detection patch from Peter S. Mazinger <ps.m@gmx.net>.
364    
365     13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
366     Fix a bug in libsandbox.c 's checking in the rename wrapper - it basically
367     only checked the destination patch, and not the source, so we could move
368     a protected file to a unprotected directory, and then delete/modify it.
369     Thanks to Andrea Luzzardi (scox) <al@sig11.org>, bug #30992, for this fix.
370    
371     12 Oct 2003; Nicholas Jones <carpaski@gentoo.org> sandbox.c :
372     Added python2.3 to the predict section/variable.
373    
374     28 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
375     sandbox.h, sandbox_futils.c :
376     Add support to set the pids file via SANDBOX_PIDS_FILE at startup. If
377     it is not set, it will revert to its old value.
378    
379     27 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
380     Fix our mkdir wrapper to check if the dir exist, and return EEXIST if so,
381     rather than failing with a violation, bug #29748.
382    
383     27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
384     Fix canonicalize() to ignore calls with path = "".
385    
386     27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c,
387     sandbox_futils.c, canonicalize.c :
388     Once again coreutils fails, as my systems had 2.5 kernel, the getcwd system
389     call handled strings larger than PATH_MAX (bug #21766). It however does not
390     work the same on 2.4 kernels.
391    
392     To fix, I added the posix implementation of getcwd() (from glibc cvs) that
393     do not need the system call. We use the default getcwd() function via a
394     wrapper (egetcwd), and then lstat the returned path. If lstat fails, it
395     means the current directory was removed, OR that the the system call for
396     getcwd failed (curious is that it do not fail and return NULL or set
397     errno, but rather just truncate the retured directory - usually from the
398     start), and if so, we use the generic getcwd() function (__egetcwd). Note
399     that we do not use the generic version all the time, as it calls lstat()
400     a great number of times, and performance degrade much.
401    
402     29 Jun 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls,
403     libsandbox.c :
404     Make sure SB_PATH_MAX will not wrap. Fix two possible memory leaks.
405    
406     22 Jun 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, canonicalize.c
407     create-localdecls :
408     When checking path names of files accessed, we need to canonicalize it, else
409     it may be a symlink in a 'write allowed' directory pointing to a file in a
410     directory we should not have write access to.
411    
412     With something like coreutils-5.0, we have two problems:
413     1) One of the tests checks if getcwd() can return a path longer than
414     PATH_MAX. This test then tries to create a dir which even while
415     created local (mkdir("conftest2")), it ends up being resolved with
416     a name that is much larger than PATH_MAX. The problem now is that
417     canonicalize() have undefined behaviour when the path was too long
418     (returned wrongly truncated paths, etc), and pass the wrong path to
419     before_syscall() (causing the bogus sandbox violations).
420     2) The ecanonicalize() function we used, along with the canonicalize()
421     function did not support longer than PATH_MAX. This is partly a
422     cause for 1), but the error checking (rather lack of it) of calls
423     to erealpath() in canonicalize() was the prime reason for 1).
424    
425     As we do not use this canonicalized name to call the function, we resolve this
426     by fixing canonicalize() to do better error checking, and ecanonicalize() as
427     well as all functions in libsandbox.c to use a PATH_MAX of 'PATH_MAX * 2'.
428     While they will resolve paths properly now, and can check if a write/read is
429     allowed, the functions called from the sandboxed environment will still work
430     as expected.
431    
432     This should resolve bug #21766.
433    
434     06 Apr 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
435     For some reason sandbox fails with a 'open_wr' if you run 'locale -a' under
436     it (bug #16298).
437    
438     Problem is that for some reason locale fopen's locale.alias with mode "rm".
439    
440     -------------------------------------------------------
441     nosferatu root # grep fopen locale.log
442     fopen("/usr/share/locale/locale.alias", "rm"ACCESS DENIED open_wr: /usr/share/locale/locale.alias
443     nosferatu root #
444     --------------------------------------------------------
445    
446     I checked the source of locale, but it have fopen with mode 'r', so
447     not sure where the "rm" mode comes from. Anyhow, changed the check in
448     before_syscall_open_char() to also see mode "rm" as readonly.
449    
450     23 Feb 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
451    
452     Add glibc-2.3 support.
453    
454     22 Feb 2003; Martin Schlemmer <azarah@gentoo.org> sandbox.c :
455    
456     Some /etc/ld.so.preload fixes. Just changed the #if defines to cover all
457     operations releated to preload, as well as only try to modify ld.so.preload
458     if we can. Also modify to write the pid to /tmp/sandboxpids.tmp even when
459     not using ld.so.preload. Fix to not write this instance of sandbox's pid
460     to /tmp/sandboxpids.tmp on exit if this is not the last sandbox running.
461    
462     22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> Makefile :
463    
464     Changed the LD to CC for hppa.
465    
466     22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
467    
468     Killed the previous changes I made.
469    
470     17 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
471    
472     Added parisc to BROKEN_RTLD_ARCHLIST to see if it we can fix the relocation probs.
473    
474     09 Jan 2003; J Robert Ray <jrray@gentoo.org> sandbox.c :
475    
476     Don't segfault if $HOME isn't set, set $HOME to "/" instead. Fixes bug 10868.
477    
478     16 Dec 2002; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
479    
480     Fix memory leak for mips, bug #12236. Thanks to Torgeir Hansen <torgeir@trenger.ro>
481     for this fix.
482    
483     4 Dec 2002; J Robert Ray <jrray@gentoo.org> sandbox.h sandbox_futils.c :
484    
485     sandbox_futils defined a dirname() function that was masking the same
486     function in glibc and was broken (e.g.: SANDBOX_DIR was being set to
487     '/usr/lib/portage/bi/'). Fixed function to return expected results and
488     renamed it to sb_dirname() to no longer mask the glibc function. Closes bug
489     11231.
490    
491     4 Dec 2002; Martin Schlemmer <azarah@gentoo.org> :
492    
493     Fix a segfault in libsandbox.c if canonicalize() was called with
494     first parameter = NULL.
495    
496     1 Sep 2002; Martin Schlemmer <azarah@gentoo.org> :
497    
498     Fix my braindead 'return 1;' in a void function. Updated sandbox.c,
499     cleanup() for this.
500    
501     Change cleanup() in sandbox.c not to exit with fail status if
502     the pidsfile is missing. We really should still display sandbox
503     violations if they occured.
504    
505     31 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
506    
507     Update cleanup() in sandbox.c to remove the PIDSFILE if this is
508     the last sandbox running.
509    
510     25 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
511    
512     Major cleanups to mainly libsandbox.c again.
513    
514     22 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
515    
516     Add copyrights to sandbox.h and sandbox_futils.h. If wrong, the
517     parties involved should please contact me so that we can fix it.
518    
519     Add opendir wrapper to libsandbox.c.
520    
521     21 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
522    
523     Do some more cleanups to ecanonicalize(), as it dropped filenames in
524     rare cases (after my symlink cleanups), and caused glibc to bork.
525     These fixes went into canonicalize.c.
526    
527     20 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
528    
529     Fix spawn_shell() and main() in sandbox.c to properly return fail
530     status.
531    
532     19 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
533    
534     The new canonicalize() function in libsandbox.c also resolved symlinks,
535     which caused on cleaning sandbox errors if the symlink pointed to a
536     file in the live root. Ripped out canonicalize() and realpath() from
537     glibc; removed the symlink stuff, and changed them to ecanonicalize()
538     and erealpath().
539    
540     18 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
541    
542     Ripped out all the wrappers, and implemented those of InstallWatch.
543     Losts of cleanups and bugfixes. Implement a execve that forces
544     $LIBSANDBOX in $LD_PRELOAD. We can now thus do away with the feared
545     /etc/ld.so.preload (*g*) ... Made the needed changes to sandbox.c,
546     sandbox.h and sandbox_futils.c. Rewrote the Makefile for most
547     parts; it now have an install target.
548    
549     Reformat the whole thing to look somewhat like the reworked sandbox.c
550     and new sandbox.h and sandbox_futils.c from:
551    
552     Brad House <brad@mainstreetsoftworks.com>.
553    
554     Additional Copyrights now due to the InstallWatch code:
555    
556     Copyright (C) 1998-9 Pancrazio `Ezio' de Mauro <p@demauro.net>

Properties

Name Value
svn:eol-style native
svn:keywords Author Date Id Revision

  ViewVC Help
Powered by ViewVC 1.1.20