/[path-sandbox]/trunk/ChangeLog.0
Gentoo

Contents of /trunk/ChangeLog.0

Parent Directory Parent Directory | Revision Log Revision Log


Revision 137 - (hide annotations) (download)
Wed Jul 6 21:33:23 2005 UTC (9 years, 3 months ago) by azarah
Original Path: trunk/ChangeLog
File size: 25991 byte(s)
Cleanup init_env_entries() and check_prefixes().
1 ferringb 2 # ChangeLog for Path Sandbox
2 vapier 53 # Copyright 1999-2005 Gentoo Foundation; Distributed under the GPL v2
3 ferringb 2 # $Header$
4    
5 azarah 134 06 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.h, sandbox_futils.c,
6     libsandbox.c:
7     - Change log dir to /var/log/sandbox/. Make sure the sandboxed process cannot
8     write to it.
9 azarah 135 - Clean up logging in libsandbox.c, and hopefully make it more consistant.
10 azarah 136 - Add check_prefixes() with major cleanup on check_access().
11 azarah 137 - Cleanup init_env_entries() and check_prefixes().
12 azarah 134
13 azarah 133 05 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
14     sandbox_futils.c, libsandbox.c:
15     Remove unused 'pids file' code.
16    
17 azarah 128 * sandbox-1.2.10 (2005/07/03)
18    
19 azarah 126 03 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
20     Add PREDICT items for nss-db, bug #92079. Patch from Robin Johnson.
21    
22 azarah 123 17 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
23     General cleanups:
24     - Remove fooling around with exit codes - we error out on presence of a log
25     anyhow.
26 azarah 124 - Move get_sandbox_*_envvar() to sandbox_setup_environ(), as its more
27     appropriate there.
28 azarah 123
29 azarah 121 12 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
30     Cleanup the fail_nametoolong stuff a bit more.
31    
32 azarah 118 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
33 azarah 120 Remove hopefully the last ld.so.preload bits we do not use anymore.
34    
35     11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
36 azarah 119 Remove the unneeded canonicalize() calls in the wrappers - we do it anyhow
37     in check_syscall(). Should speed things up a bit (at least for the getcwd()
38     and long path name test it goes down to under a second, and not 10+ seconds
39     like before). Also warn if we skip checking due to the canonicalized path
40     being too long.
41    
42     11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
43 azarah 118 More comment/readability cleanups.
44    
45 azarah 117 10 June 2005; Martin Schlemmer <azarah@gentoo.org> canonicalize.c, getcwd.c,
46     sandbox_futils.c, libsandbox.c:
47     Some strncpy/strncat and other cleanups.
48    
49 azarah 115 * sandbox-1.2.9 (2005/06/09)
50    
51 azarah 114 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
52     Move symlink hack down a bit to try and minimize on the amount of lstat()
53     calls we do.
54    
55 azarah 113 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
56     Add hack to allow writing to /proc/self/fd (or /dev/fd), bug #91516.
57    
58 azarah 112 09 June 2005; Martin Schlemmer <azarah@gentoo.org> symbols.in, libsandbox.c:
59     Add wrapper for access() function, bug #85413.
60    
61 azarah 111 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c:
62     Use generic getcwd() implementation from uclibc - should be more portable
63     and looks a bit cleaner.
64    
65 azarah 110 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c:
66     Make sure our true_* pointers are initialized to NULL, and that we check for
67     all references that they are valid.
68    
69 azarah 109 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
70     Be default we will fail if the path name we try to canonicalize is too long.
71     This however could cause issues with some things (bug #94630 and #21766), so
72     if fail_nametoolong == 0, canonicalize() will return a null length string and
73     do not fail.
74    
75 azarah 108 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c:
76     Do not abort if TMPDIR is not valid, but rather use '/tmp', bug #94360. Also
77     make sure we re-export the new TMPDIR environment variable.
78    
79 azarah 106 08 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
80     Fix incorrect free of non-malloc'd array, bug #92313 and #94020. Fix noted
81     by Marcus D. Hanwell <cryos@gentoo.org>.
82    
83 azarah 105 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
84     Add /dev/console to write list, bug #38588.
85    
86 azarah 102 * sandbox-1.2.8 (2005/05/13)
87    
88 azarah 99 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
89 azarah 101 sandbox.h, sandbox_futils.c:
90     General cleanups.
91    
92     13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
93 azarah 100 sandbox.h:
94     Various LD_PRELOAD cleanups. Do not unset LD_PRELOAD for parent.
95    
96     13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
97 azarah 99 sandbox.h, sandbox_futils.c:
98     Modify get_sandbox_pids_file(), get_sandbox_log() and get_sandbox_debug_log()
99     to use TMPDIR if present in environment.
100    
101 azarah 98 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
102     Remove sandbox_log_file from main() as its no longer used.
103    
104 azarah 97 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
105     sandbox_futils.c:
106     Add get_sandbox_debug_log(), and use it (add behaviour similar to SANDBOX_LOG
107     if already exported when sandbox started). Fix get_sandbox_log() and new
108     get_sandbox_debug_log() to not use already exported environment variables if
109     they have '/' in them. Use snprintf()'s instead of strncpy()'s. More
110     SB_PATH_MAX fixes.
111    
112 azarah 94 * sandbox-1.2.7 (2005/05/12)
113    
114 azarah 93 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
115     sandbox_futils.c:
116     More path limit fixes. Declare SB_BUF_LEN global and use it where needed.
117    
118 azarah 92 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
119     Fix paths limited to 255 chars. Fix get_sandbox_dir() returning a string
120     with '(null)' in it if we did not call sandbox with absolute path.
121    
122 azarah 89 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
123 azarah 91 Set SANDBOX_ON *before* doing the child's env stuff, else its not set
124     for the child.
125    
126     12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
127 azarah 90 Remove global preload_adaptable as it is no longer used.
128    
129     12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
130 azarah 89 Rewrite environment stuff to only be set when execve'ing the child process
131     to try and avoid issues like bug #91541 that causes sandbox to crash if
132     we set LD_PRELOAD sandbox side already.
133    
134 azarah 87 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
135 azarah 88 Move print_sandbox_log() up to make things neater.
136    
137     11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
138 azarah 87 Remove load_preload_libs(), as its not used anymore.
139    
140 azarah 83 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
141 azarah 86 Remove NO_FORK stuff, as its not used, and 'strace -f' works just fine.
142    
143     11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
144 azarah 84 Remove USE_SYSTEM_SHELL stuff, as it is not secure, and not in use.
145    
146     11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
147 azarah 83 Remove ld.so.preload crap - we are not going to use it again.
148    
149 azarah 82 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
150     Fix typo in code that checks if we got valid group information, causing a
151     segmentation fault, bug #91637.
152    
153 azarah 79 * sandbox-1.2.6 (2005/05/10)
154    
155 azarah 78 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
156     Do not use LD_PRELOAD if it contains libtsocks.so, as it breaks sandbox
157     for some odd reason, bug #91541.
158    
159 azarah 77 09 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
160     Fix typo (sizeof -> strlen).
161    
162 ferringb 76 08 May 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
163     rewrote the sbcontext caching code so it accounts for env changes since lib
164     initialization.
165    
166 azarah 75 05 May 2005; Martin Schlemmer <azarah@gentoo.org> configure.in, libctest.c:
167     We create libctest.c via configure, so no need to keep it around. Do some
168     cleanup related to libctest.c and libctest during configure.
169    
170 azarah 74 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
171     Add rename support of symlinks pointing to protected files/directories.
172    
173 azarah 72 * sandbox-1.2.5 (2005/05/04)
174    
175 azarah 71 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
176     sandbox.bashrc:
177     Do not reset already set LD_PRELOAD when starting sandbox. If LD_PRELOAD is
178     already set, init of the env vars fails for some reason, so do this later on,
179     and do not warn (bug #91431).
180    
181 azarah 70 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
182     sandbox.bashrc:
183     Fixup sandbox and sandbox.bashrc to call bash with the proper .bashrc.
184    
185 azarah 68 * sandbox-1.2.4 (2005/05/03)
186    
187 azarah 66 03 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
188     Do not init the env entries with each call, as it creates too many calls to
189 azarah 67 lstat, etc. Should speedup things a bit, bug #91040.
190 azarah 66
191 azarah 65 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
192     Add /dev/pty to default write list. Noticed by Morfic.
193    
194 vapier 62 02 May 2005; Mike Frysinger <vapier@gentoo.org> configure.in, localdecls.h,
195     sandbox.h:
196     uClibc doesn't support dlvsym() so add a configure check to make sure it doesn't
197     exist. Also update localdecls.h so BROKEN_RTLD_NEXT isn't defined in uClibc.
198    
199 azarah 59 * sandbox-1.2.3 (2005/04/29)
200    
201 azarah 56 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> configure.in:
202     Do not check for (*&#$(* CXX or F77.
203    
204 azarah 54 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
205     Do not append '/' to pathname in filter_path() if it already ends with it.
206    
207 vapier 53 28 Apr 2005; Mike Frysinger <vapier@gentoo.org> Makefile.am, configure.in:
208     With az's help, clean up autotools to work with cross-compiling.
209    
210 azarah 59 * sandbox-1.2.2 (2005/04/28)
211 azarah 48
212 azarah 47 28 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
213     Only check for /dev/{null,zero} for unlink hack, else ricers using /dev/shm
214     have issues; bug #90592.
215    
216 azarah 59 * sandbox-1.2.1 (2005/04/23)
217 azarah 44
218 azarah 43 23 Apr 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
219     getcwd.c, libsandbox.c, localdecls.h, sandbox.h, sandbox_futils.c:
220     Make sure all functions used in libsandbox.c is declared static. Define
221     SB_STATIC in localdecls.h for this. Include sandbox_futils.c rather than
222     linking with its object. Hopefully this will fix bug #90153.
223    
224 azarah 59 * sandbox-1.2 (2005/04/23)
225 azarah 46
226 azarah 40 22 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
227     Allow lchown a symlink in write-allowed path pointing to write-denied
228     target.
229    
230 genone 39 21 Mar 2005; Marius Mauch <genone@gentoo.org> libsandbox.c:
231     Also show resolved symlink names in the log.
232    
233 azarah 37 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, libsandbox.c:
234     Seems -nostdlib was the problem with the constructor/destructor - remove it
235     from Makefile.am, and change the constructor/destructor names again.
236    
237 azarah 36 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
238     Also rename the _init() and _fini() declarations.
239    
240 azarah 35 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
241     Fixup the constructor/destructor function names again (they should be _init()
242     and _fini() it seems, and not being called caused sandbox_lib_path to be
243     unset, and thus breaking the execve() wrapper's LD_PRELOAD protection).
244     Add both the path in given SANDBOX_x variable, as well as its symlink
245     resolved path in init_env_entries(). Modify filter_path() to be able to
246     resolve paths without resolving symlinks, as well as to be able to resolve
247     symlinks. Fix a possible segfault in check_access(). Add symlink resolving
248     to check_access() resolving bug #31019. Add 'hack' for unlink, as the fix
249     for bug #31019 cause access violations if we try to remove a symlink that is
250     not in protected path, but points to a protected path. Fix a memory leak in
251     sandbox.c (sandbox_pids_file in main()). Fix the realpath() calls in main()
252     (sandbox.c) being unchecked. Fix the debug logname not having the pid in it
253     (pid_string was uninitialized). General syntax cleanups.
254    
255 ferringb 34 09 Mar 2005; Brian Harring <ferringb@gentoo.org> sandbox.c: Fixed the
256     infamous "pids file is not a regular file" w/out newline bug.
257    
258 ferringb 33 09 Mar 2005; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in:
259     Correct libc_version path detection, since it was screwing up if libdir !=
260     "/lib/".
261    
262     02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
263 azarah 32 Hack to make sure sandboxed process cannot remove a device node, bug #79836.
264    
265 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am:
266 azarah 31 Fix symbols.in not added to dist.
267    
268 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
269 azarah 30 getcwd.c, libsandbox.c, sandbox.c, sandbox.h, sandbox_futils.c:
270     White space fixes.
271    
272 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
273 azarah 30 configure.in, getcwd.c, libsandbox.c, symbols.in:
274 azarah 29 Fix inverse test logic in canonicalize.c, use a strncpy. Fix gcc warning in
275     getcwd.c. Add symbols.in and logic to Makefile.am to generate symbol versions
276     for glibc and other libc's that use this. Update libsandbox.c to use these
277     symbol versions if available. Fix exec wrapper to re-export LD_PRELOAD if the
278     process unset it.
279    
280 ferringb 33 01 Mar 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
281 ferringb 28 killed off _init and _fini in favor of
282     void __attribute__ ((constructor)) init_func and
283     void __attribute__ ((destructor)) closing_func. _(init|func) were deprecated.
284    
285 ferringb 26 06 Dec 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, libsandbox.c,
286     canonicalize.c, getcwd.c: Fixed compilation *again*. Hopefully cvs is done
287     having the hick-ups.
288    
289 ferringb 24 04 Dec 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, getcwd.c,
290     Makefile.am: Fixed compilation.
291    
292 ferringb 18 01 Dec 2004; Brian Harring <ferringb@gentoo.org> aclocal.m4:
293     Gutted the bugger so it stops checking for a c++ and fortran compiler.
294     Do *not* regenerate aclocal.m4 for making a release until a better
295     solution is created.
296    
297 ferringb 16 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, sandbox_futils.c:
298     Removal of more hardcoded paths.
299    
300 ferringb 13 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in,
301     sandbox_futils.c: tweaks to install sandbox.bashrc, and use it.
302    
303     19 Nov 2004; Brian Harring <ferringb@gentoo.org>:
304 ferringb 6 Sandbox is now autotooled, create-localdecls needs to be killed and the code
305     shifted into configure.in. Currently builds *one* libsandbox.so- if multiple
306     are desired (-m64 and -m32 for amd64), the ebuild should do it (imo).
307     To get to a point of testing, automake && autoconf; created requisite files w/
308     a(utomake|clocal)-1.8, and autoconf 2.59. Installs to /usr/, instead of
309     /lib and /usr/lib/portage/bin.
310    
311 ferringb 2 14 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox.c:
312     closing out bug #70225, potential overflow of the sandbox_pids_file var.
313    
314     07 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c: c99 standard,
315     (think it was at least) allows intermixing of code and data segments. bug #70351
316     should be fixed by this.
317    
318     03 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox_futils.c:
319     futils fix from bug #65201 via solar, and libsandbox log path checks via #69137
320    
321     02 Aug 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Code from
322     Seth Robertson that tracked down all adjuct flags for read operations that
323     do not invoke a write operation.
324    
325     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
326     Another fix from jstubbs regarding a free() on a stack variable for the
327     environment -- tracking now prevents extraneous free()'s segfault.
328    
329     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
330     J. Stubbs tracked down a new bug where mkdir was failing to the patch on
331     the lstat in mkdir... it now only returns 0 or -1 as documented for mkdir.
332     Also remove the errno = ESUCCESS settings as documentation points out that
333     a library isn't allowed to do that.
334    
335     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Added a
336     file_security_check() function to check random potential exploits on files
337     that sandbox is to load and read -- Normally sandboxpids.tmp. This fixes
338     the 'system-crippling' exploits (bug 21923) and catches a few other
339     potential problems.
340    
341     20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> Makefile: Updates for
342     32/64 bit sandbox. Made CC and LD '?=' values to allow passed in CC to work.
343    
344     20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c:
345     bug 42048 -- Fixed the lstat/errno conditions for mkdir <caleb@g.o>.
346     Added the 64/32 bit sandbox patch for AMD64 bug 32963 <brad/azarah>.
347    
348     29 Feb 2004; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c :
349     Fix permissions and group of pids file and logs. Permissions should be 0664
350     and group should be 'portage'. Bug #34260.
351    
352     28 Feb 2004; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
353     Besides a small cleanup, redo how we replace LD_PRELOAD in the environ passed
354     to the real execve (in our execve wrapper). Seems that on some arches (sparc
355     among others) do not allow us to tamper with the readonly copy passed to
356     execve, so pass our own copy of the environment. Bug #42290.
357    
358     11 Jan 2004; Nicholas Jones <carpaski@gentoo.org> create-decls:
359     Changed tail to head and added a notice about duration of glibc check.
360    
361     21 Dec 2003; Nicholas Jones <carpaski@gentoo.org> create-decls:
362     Changed the glibc subversion check to use /usr/bin/* instead of /bin/sh
363     as there isn't a guarentee that it is dynamic.
364    
365     02 Nov 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
366     If 'file' passed to before_syscall(const char *func, const char *file) is
367     invalid, we should set errno to ENOENT, and not EINVAL. This should
368     close bug #32238.
369    
370     14 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
371     Fix a bug that occurs mainly on 64bit arch, where the file passed to
372     the functions we wrap, is invalid, and then cause canonicalize to pass
373     garbage to before_syscall(), thanks to great detective work from
374     Andrea Luzzardi <al@sig11.org> (bug #29846).
375    
376     13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
377     Add a uClibc detection patch from Peter S. Mazinger <ps.m@gmx.net>.
378    
379     13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
380     Fix a bug in libsandbox.c 's checking in the rename wrapper - it basically
381     only checked the destination patch, and not the source, so we could move
382     a protected file to a unprotected directory, and then delete/modify it.
383     Thanks to Andrea Luzzardi (scox) <al@sig11.org>, bug #30992, for this fix.
384    
385     12 Oct 2003; Nicholas Jones <carpaski@gentoo.org> sandbox.c :
386     Added python2.3 to the predict section/variable.
387    
388     28 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
389     sandbox.h, sandbox_futils.c :
390     Add support to set the pids file via SANDBOX_PIDS_FILE at startup. If
391     it is not set, it will revert to its old value.
392    
393     27 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
394     Fix our mkdir wrapper to check if the dir exist, and return EEXIST if so,
395     rather than failing with a violation, bug #29748.
396    
397     27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
398     Fix canonicalize() to ignore calls with path = "".
399    
400     27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c,
401     sandbox_futils.c, canonicalize.c :
402     Once again coreutils fails, as my systems had 2.5 kernel, the getcwd system
403     call handled strings larger than PATH_MAX (bug #21766). It however does not
404     work the same on 2.4 kernels.
405    
406     To fix, I added the posix implementation of getcwd() (from glibc cvs) that
407     do not need the system call. We use the default getcwd() function via a
408     wrapper (egetcwd), and then lstat the returned path. If lstat fails, it
409     means the current directory was removed, OR that the the system call for
410     getcwd failed (curious is that it do not fail and return NULL or set
411     errno, but rather just truncate the retured directory - usually from the
412     start), and if so, we use the generic getcwd() function (__egetcwd). Note
413     that we do not use the generic version all the time, as it calls lstat()
414     a great number of times, and performance degrade much.
415    
416     29 Jun 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls,
417     libsandbox.c :
418     Make sure SB_PATH_MAX will not wrap. Fix two possible memory leaks.
419    
420     22 Jun 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, canonicalize.c
421     create-localdecls :
422     When checking path names of files accessed, we need to canonicalize it, else
423     it may be a symlink in a 'write allowed' directory pointing to a file in a
424     directory we should not have write access to.
425    
426     With something like coreutils-5.0, we have two problems:
427     1) One of the tests checks if getcwd() can return a path longer than
428     PATH_MAX. This test then tries to create a dir which even while
429     created local (mkdir("conftest2")), it ends up being resolved with
430     a name that is much larger than PATH_MAX. The problem now is that
431     canonicalize() have undefined behaviour when the path was too long
432     (returned wrongly truncated paths, etc), and pass the wrong path to
433     before_syscall() (causing the bogus sandbox violations).
434     2) The ecanonicalize() function we used, along with the canonicalize()
435     function did not support longer than PATH_MAX. This is partly a
436     cause for 1), but the error checking (rather lack of it) of calls
437     to erealpath() in canonicalize() was the prime reason for 1).
438    
439     As we do not use this canonicalized name to call the function, we resolve this
440     by fixing canonicalize() to do better error checking, and ecanonicalize() as
441     well as all functions in libsandbox.c to use a PATH_MAX of 'PATH_MAX * 2'.
442     While they will resolve paths properly now, and can check if a write/read is
443     allowed, the functions called from the sandboxed environment will still work
444     as expected.
445    
446     This should resolve bug #21766.
447    
448     06 Apr 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
449     For some reason sandbox fails with a 'open_wr' if you run 'locale -a' under
450     it (bug #16298).
451    
452     Problem is that for some reason locale fopen's locale.alias with mode "rm".
453    
454     -------------------------------------------------------
455     nosferatu root # grep fopen locale.log
456     fopen("/usr/share/locale/locale.alias", "rm"ACCESS DENIED open_wr: /usr/share/locale/locale.alias
457     nosferatu root #
458     --------------------------------------------------------
459    
460     I checked the source of locale, but it have fopen with mode 'r', so
461     not sure where the "rm" mode comes from. Anyhow, changed the check in
462     before_syscall_open_char() to also see mode "rm" as readonly.
463    
464     23 Feb 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
465    
466     Add glibc-2.3 support.
467    
468     22 Feb 2003; Martin Schlemmer <azarah@gentoo.org> sandbox.c :
469    
470     Some /etc/ld.so.preload fixes. Just changed the #if defines to cover all
471     operations releated to preload, as well as only try to modify ld.so.preload
472     if we can. Also modify to write the pid to /tmp/sandboxpids.tmp even when
473     not using ld.so.preload. Fix to not write this instance of sandbox's pid
474     to /tmp/sandboxpids.tmp on exit if this is not the last sandbox running.
475    
476     22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> Makefile :
477    
478     Changed the LD to CC for hppa.
479    
480     22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
481    
482     Killed the previous changes I made.
483    
484     17 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
485    
486     Added parisc to BROKEN_RTLD_ARCHLIST to see if it we can fix the relocation probs.
487    
488     09 Jan 2003; J Robert Ray <jrray@gentoo.org> sandbox.c :
489    
490     Don't segfault if $HOME isn't set, set $HOME to "/" instead. Fixes bug 10868.
491    
492     16 Dec 2002; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
493    
494     Fix memory leak for mips, bug #12236. Thanks to Torgeir Hansen <torgeir@trenger.ro>
495     for this fix.
496    
497     4 Dec 2002; J Robert Ray <jrray@gentoo.org> sandbox.h sandbox_futils.c :
498    
499     sandbox_futils defined a dirname() function that was masking the same
500     function in glibc and was broken (e.g.: SANDBOX_DIR was being set to
501     '/usr/lib/portage/bi/'). Fixed function to return expected results and
502     renamed it to sb_dirname() to no longer mask the glibc function. Closes bug
503     11231.
504    
505     4 Dec 2002; Martin Schlemmer <azarah@gentoo.org> :
506    
507     Fix a segfault in libsandbox.c if canonicalize() was called with
508     first parameter = NULL.
509    
510     1 Sep 2002; Martin Schlemmer <azarah@gentoo.org> :
511    
512     Fix my braindead 'return 1;' in a void function. Updated sandbox.c,
513     cleanup() for this.
514    
515     Change cleanup() in sandbox.c not to exit with fail status if
516     the pidsfile is missing. We really should still display sandbox
517     violations if they occured.
518    
519     31 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
520    
521     Update cleanup() in sandbox.c to remove the PIDSFILE if this is
522     the last sandbox running.
523    
524     25 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
525    
526     Major cleanups to mainly libsandbox.c again.
527    
528     22 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
529    
530     Add copyrights to sandbox.h and sandbox_futils.h. If wrong, the
531     parties involved should please contact me so that we can fix it.
532    
533     Add opendir wrapper to libsandbox.c.
534    
535     21 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
536    
537     Do some more cleanups to ecanonicalize(), as it dropped filenames in
538     rare cases (after my symlink cleanups), and caused glibc to bork.
539     These fixes went into canonicalize.c.
540    
541     20 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
542    
543     Fix spawn_shell() and main() in sandbox.c to properly return fail
544     status.
545    
546     19 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
547    
548     The new canonicalize() function in libsandbox.c also resolved symlinks,
549     which caused on cleaning sandbox errors if the symlink pointed to a
550     file in the live root. Ripped out canonicalize() and realpath() from
551     glibc; removed the symlink stuff, and changed them to ecanonicalize()
552     and erealpath().
553    
554     18 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
555    
556     Ripped out all the wrappers, and implemented those of InstallWatch.
557     Losts of cleanups and bugfixes. Implement a execve that forces
558     $LIBSANDBOX in $LD_PRELOAD. We can now thus do away with the feared
559     /etc/ld.so.preload (*g*) ... Made the needed changes to sandbox.c,
560     sandbox.h and sandbox_futils.c. Rewrote the Makefile for most
561     parts; it now have an install target.
562    
563     Reformat the whole thing to look somewhat like the reworked sandbox.c
564     and new sandbox.h and sandbox_futils.c from:
565    
566     Brad House <brad@mainstreetsoftworks.com>.
567    
568     Additional Copyrights now due to the InstallWatch code:
569    
570     Copyright (C) 1998-9 Pancrazio `Ezio' de Mauro <p@demauro.net>

Properties

Name Value
svn:eol-style native
svn:keywords Author Date Id Revision

  ViewVC Help
Powered by ViewVC 1.1.20