/[path-sandbox]/trunk/ChangeLog.0
Gentoo

Contents of /trunk/ChangeLog.0

Parent Directory Parent Directory | Revision Log Revision Log


Revision 138 - (hide annotations) (download)
Thu Jul 7 13:01:31 2005 UTC (9 years, 5 months ago) by azarah
Original Path: trunk/ChangeLog
File size: 26101 byte(s)
Fix possible segfault in env init code.
1 ferringb 2 # ChangeLog for Path Sandbox
2 vapier 53 # Copyright 1999-2005 Gentoo Foundation; Distributed under the GPL v2
3 ferringb 2 # $Header$
4    
5 azarah 138 07 July 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
6     Fix possible segfault in env init code.
7    
8 azarah 134 06 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.h, sandbox_futils.c,
9     libsandbox.c:
10     - Change log dir to /var/log/sandbox/. Make sure the sandboxed process cannot
11     write to it.
12 azarah 135 - Clean up logging in libsandbox.c, and hopefully make it more consistant.
13 azarah 136 - Add check_prefixes() with major cleanup on check_access().
14 azarah 137 - Cleanup init_env_entries() and check_prefixes().
15 azarah 134
16 azarah 133 05 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
17     sandbox_futils.c, libsandbox.c:
18     Remove unused 'pids file' code.
19    
20 azarah 128 * sandbox-1.2.10 (2005/07/03)
21    
22 azarah 126 03 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
23     Add PREDICT items for nss-db, bug #92079. Patch from Robin Johnson.
24    
25 azarah 123 17 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
26     General cleanups:
27     - Remove fooling around with exit codes - we error out on presence of a log
28     anyhow.
29 azarah 124 - Move get_sandbox_*_envvar() to sandbox_setup_environ(), as its more
30     appropriate there.
31 azarah 123
32 azarah 121 12 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
33     Cleanup the fail_nametoolong stuff a bit more.
34    
35 azarah 118 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
36 azarah 120 Remove hopefully the last ld.so.preload bits we do not use anymore.
37    
38     11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
39 azarah 119 Remove the unneeded canonicalize() calls in the wrappers - we do it anyhow
40     in check_syscall(). Should speed things up a bit (at least for the getcwd()
41     and long path name test it goes down to under a second, and not 10+ seconds
42     like before). Also warn if we skip checking due to the canonicalized path
43     being too long.
44    
45     11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
46 azarah 118 More comment/readability cleanups.
47    
48 azarah 117 10 June 2005; Martin Schlemmer <azarah@gentoo.org> canonicalize.c, getcwd.c,
49     sandbox_futils.c, libsandbox.c:
50     Some strncpy/strncat and other cleanups.
51    
52 azarah 115 * sandbox-1.2.9 (2005/06/09)
53    
54 azarah 114 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
55     Move symlink hack down a bit to try and minimize on the amount of lstat()
56     calls we do.
57    
58 azarah 113 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
59     Add hack to allow writing to /proc/self/fd (or /dev/fd), bug #91516.
60    
61 azarah 112 09 June 2005; Martin Schlemmer <azarah@gentoo.org> symbols.in, libsandbox.c:
62     Add wrapper for access() function, bug #85413.
63    
64 azarah 111 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c:
65     Use generic getcwd() implementation from uclibc - should be more portable
66     and looks a bit cleaner.
67    
68 azarah 110 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c:
69     Make sure our true_* pointers are initialized to NULL, and that we check for
70     all references that they are valid.
71    
72 azarah 109 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
73     Be default we will fail if the path name we try to canonicalize is too long.
74     This however could cause issues with some things (bug #94630 and #21766), so
75     if fail_nametoolong == 0, canonicalize() will return a null length string and
76     do not fail.
77    
78 azarah 108 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c:
79     Do not abort if TMPDIR is not valid, but rather use '/tmp', bug #94360. Also
80     make sure we re-export the new TMPDIR environment variable.
81    
82 azarah 106 08 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
83     Fix incorrect free of non-malloc'd array, bug #92313 and #94020. Fix noted
84     by Marcus D. Hanwell <cryos@gentoo.org>.
85    
86 azarah 105 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
87     Add /dev/console to write list, bug #38588.
88    
89 azarah 102 * sandbox-1.2.8 (2005/05/13)
90    
91 azarah 99 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
92 azarah 101 sandbox.h, sandbox_futils.c:
93     General cleanups.
94    
95     13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
96 azarah 100 sandbox.h:
97     Various LD_PRELOAD cleanups. Do not unset LD_PRELOAD for parent.
98    
99     13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
100 azarah 99 sandbox.h, sandbox_futils.c:
101     Modify get_sandbox_pids_file(), get_sandbox_log() and get_sandbox_debug_log()
102     to use TMPDIR if present in environment.
103    
104 azarah 98 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
105     Remove sandbox_log_file from main() as its no longer used.
106    
107 azarah 97 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
108     sandbox_futils.c:
109     Add get_sandbox_debug_log(), and use it (add behaviour similar to SANDBOX_LOG
110     if already exported when sandbox started). Fix get_sandbox_log() and new
111     get_sandbox_debug_log() to not use already exported environment variables if
112     they have '/' in them. Use snprintf()'s instead of strncpy()'s. More
113     SB_PATH_MAX fixes.
114    
115 azarah 94 * sandbox-1.2.7 (2005/05/12)
116    
117 azarah 93 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
118     sandbox_futils.c:
119     More path limit fixes. Declare SB_BUF_LEN global and use it where needed.
120    
121 azarah 92 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
122     Fix paths limited to 255 chars. Fix get_sandbox_dir() returning a string
123     with '(null)' in it if we did not call sandbox with absolute path.
124    
125 azarah 89 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
126 azarah 91 Set SANDBOX_ON *before* doing the child's env stuff, else its not set
127     for the child.
128    
129     12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
130 azarah 90 Remove global preload_adaptable as it is no longer used.
131    
132     12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
133 azarah 89 Rewrite environment stuff to only be set when execve'ing the child process
134     to try and avoid issues like bug #91541 that causes sandbox to crash if
135     we set LD_PRELOAD sandbox side already.
136    
137 azarah 87 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
138 azarah 88 Move print_sandbox_log() up to make things neater.
139    
140     11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
141 azarah 87 Remove load_preload_libs(), as its not used anymore.
142    
143 azarah 83 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
144 azarah 86 Remove NO_FORK stuff, as its not used, and 'strace -f' works just fine.
145    
146     11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
147 azarah 84 Remove USE_SYSTEM_SHELL stuff, as it is not secure, and not in use.
148    
149     11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
150 azarah 83 Remove ld.so.preload crap - we are not going to use it again.
151    
152 azarah 82 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
153     Fix typo in code that checks if we got valid group information, causing a
154     segmentation fault, bug #91637.
155    
156 azarah 79 * sandbox-1.2.6 (2005/05/10)
157    
158 azarah 78 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
159     Do not use LD_PRELOAD if it contains libtsocks.so, as it breaks sandbox
160     for some odd reason, bug #91541.
161    
162 azarah 77 09 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
163     Fix typo (sizeof -> strlen).
164    
165 ferringb 76 08 May 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
166     rewrote the sbcontext caching code so it accounts for env changes since lib
167     initialization.
168    
169 azarah 75 05 May 2005; Martin Schlemmer <azarah@gentoo.org> configure.in, libctest.c:
170     We create libctest.c via configure, so no need to keep it around. Do some
171     cleanup related to libctest.c and libctest during configure.
172    
173 azarah 74 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
174     Add rename support of symlinks pointing to protected files/directories.
175    
176 azarah 72 * sandbox-1.2.5 (2005/05/04)
177    
178 azarah 71 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
179     sandbox.bashrc:
180     Do not reset already set LD_PRELOAD when starting sandbox. If LD_PRELOAD is
181     already set, init of the env vars fails for some reason, so do this later on,
182     and do not warn (bug #91431).
183    
184 azarah 70 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
185     sandbox.bashrc:
186     Fixup sandbox and sandbox.bashrc to call bash with the proper .bashrc.
187    
188 azarah 68 * sandbox-1.2.4 (2005/05/03)
189    
190 azarah 66 03 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
191     Do not init the env entries with each call, as it creates too many calls to
192 azarah 67 lstat, etc. Should speedup things a bit, bug #91040.
193 azarah 66
194 azarah 65 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
195     Add /dev/pty to default write list. Noticed by Morfic.
196    
197 vapier 62 02 May 2005; Mike Frysinger <vapier@gentoo.org> configure.in, localdecls.h,
198     sandbox.h:
199     uClibc doesn't support dlvsym() so add a configure check to make sure it doesn't
200     exist. Also update localdecls.h so BROKEN_RTLD_NEXT isn't defined in uClibc.
201    
202 azarah 59 * sandbox-1.2.3 (2005/04/29)
203    
204 azarah 56 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> configure.in:
205     Do not check for (*&#$(* CXX or F77.
206    
207 azarah 54 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
208     Do not append '/' to pathname in filter_path() if it already ends with it.
209    
210 vapier 53 28 Apr 2005; Mike Frysinger <vapier@gentoo.org> Makefile.am, configure.in:
211     With az's help, clean up autotools to work with cross-compiling.
212    
213 azarah 59 * sandbox-1.2.2 (2005/04/28)
214 azarah 48
215 azarah 47 28 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
216     Only check for /dev/{null,zero} for unlink hack, else ricers using /dev/shm
217     have issues; bug #90592.
218    
219 azarah 59 * sandbox-1.2.1 (2005/04/23)
220 azarah 44
221 azarah 43 23 Apr 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
222     getcwd.c, libsandbox.c, localdecls.h, sandbox.h, sandbox_futils.c:
223     Make sure all functions used in libsandbox.c is declared static. Define
224     SB_STATIC in localdecls.h for this. Include sandbox_futils.c rather than
225     linking with its object. Hopefully this will fix bug #90153.
226    
227 azarah 59 * sandbox-1.2 (2005/04/23)
228 azarah 46
229 azarah 40 22 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
230     Allow lchown a symlink in write-allowed path pointing to write-denied
231     target.
232    
233 genone 39 21 Mar 2005; Marius Mauch <genone@gentoo.org> libsandbox.c:
234     Also show resolved symlink names in the log.
235    
236 azarah 37 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, libsandbox.c:
237     Seems -nostdlib was the problem with the constructor/destructor - remove it
238     from Makefile.am, and change the constructor/destructor names again.
239    
240 azarah 36 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
241     Also rename the _init() and _fini() declarations.
242    
243 azarah 35 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
244     Fixup the constructor/destructor function names again (they should be _init()
245     and _fini() it seems, and not being called caused sandbox_lib_path to be
246     unset, and thus breaking the execve() wrapper's LD_PRELOAD protection).
247     Add both the path in given SANDBOX_x variable, as well as its symlink
248     resolved path in init_env_entries(). Modify filter_path() to be able to
249     resolve paths without resolving symlinks, as well as to be able to resolve
250     symlinks. Fix a possible segfault in check_access(). Add symlink resolving
251     to check_access() resolving bug #31019. Add 'hack' for unlink, as the fix
252     for bug #31019 cause access violations if we try to remove a symlink that is
253     not in protected path, but points to a protected path. Fix a memory leak in
254     sandbox.c (sandbox_pids_file in main()). Fix the realpath() calls in main()
255     (sandbox.c) being unchecked. Fix the debug logname not having the pid in it
256     (pid_string was uninitialized). General syntax cleanups.
257    
258 ferringb 34 09 Mar 2005; Brian Harring <ferringb@gentoo.org> sandbox.c: Fixed the
259     infamous "pids file is not a regular file" w/out newline bug.
260    
261 ferringb 33 09 Mar 2005; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in:
262     Correct libc_version path detection, since it was screwing up if libdir !=
263     "/lib/".
264    
265     02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
266 azarah 32 Hack to make sure sandboxed process cannot remove a device node, bug #79836.
267    
268 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am:
269 azarah 31 Fix symbols.in not added to dist.
270    
271 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
272 azarah 30 getcwd.c, libsandbox.c, sandbox.c, sandbox.h, sandbox_futils.c:
273     White space fixes.
274    
275 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
276 azarah 30 configure.in, getcwd.c, libsandbox.c, symbols.in:
277 azarah 29 Fix inverse test logic in canonicalize.c, use a strncpy. Fix gcc warning in
278     getcwd.c. Add symbols.in and logic to Makefile.am to generate symbol versions
279     for glibc and other libc's that use this. Update libsandbox.c to use these
280     symbol versions if available. Fix exec wrapper to re-export LD_PRELOAD if the
281     process unset it.
282    
283 ferringb 33 01 Mar 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
284 ferringb 28 killed off _init and _fini in favor of
285     void __attribute__ ((constructor)) init_func and
286     void __attribute__ ((destructor)) closing_func. _(init|func) were deprecated.
287    
288 ferringb 26 06 Dec 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, libsandbox.c,
289     canonicalize.c, getcwd.c: Fixed compilation *again*. Hopefully cvs is done
290     having the hick-ups.
291    
292 ferringb 24 04 Dec 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, getcwd.c,
293     Makefile.am: Fixed compilation.
294    
295 ferringb 18 01 Dec 2004; Brian Harring <ferringb@gentoo.org> aclocal.m4:
296     Gutted the bugger so it stops checking for a c++ and fortran compiler.
297     Do *not* regenerate aclocal.m4 for making a release until a better
298     solution is created.
299    
300 ferringb 16 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, sandbox_futils.c:
301     Removal of more hardcoded paths.
302    
303 ferringb 13 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in,
304     sandbox_futils.c: tweaks to install sandbox.bashrc, and use it.
305    
306     19 Nov 2004; Brian Harring <ferringb@gentoo.org>:
307 ferringb 6 Sandbox is now autotooled, create-localdecls needs to be killed and the code
308     shifted into configure.in. Currently builds *one* libsandbox.so- if multiple
309     are desired (-m64 and -m32 for amd64), the ebuild should do it (imo).
310     To get to a point of testing, automake && autoconf; created requisite files w/
311     a(utomake|clocal)-1.8, and autoconf 2.59. Installs to /usr/, instead of
312     /lib and /usr/lib/portage/bin.
313    
314 ferringb 2 14 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox.c:
315     closing out bug #70225, potential overflow of the sandbox_pids_file var.
316    
317     07 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c: c99 standard,
318     (think it was at least) allows intermixing of code and data segments. bug #70351
319     should be fixed by this.
320    
321     03 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox_futils.c:
322     futils fix from bug #65201 via solar, and libsandbox log path checks via #69137
323    
324     02 Aug 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Code from
325     Seth Robertson that tracked down all adjuct flags for read operations that
326     do not invoke a write operation.
327    
328     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
329     Another fix from jstubbs regarding a free() on a stack variable for the
330     environment -- tracking now prevents extraneous free()'s segfault.
331    
332     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
333     J. Stubbs tracked down a new bug where mkdir was failing to the patch on
334     the lstat in mkdir... it now only returns 0 or -1 as documented for mkdir.
335     Also remove the errno = ESUCCESS settings as documentation points out that
336     a library isn't allowed to do that.
337    
338     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Added a
339     file_security_check() function to check random potential exploits on files
340     that sandbox is to load and read -- Normally sandboxpids.tmp. This fixes
341     the 'system-crippling' exploits (bug 21923) and catches a few other
342     potential problems.
343    
344     20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> Makefile: Updates for
345     32/64 bit sandbox. Made CC and LD '?=' values to allow passed in CC to work.
346    
347     20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c:
348     bug 42048 -- Fixed the lstat/errno conditions for mkdir <caleb@g.o>.
349     Added the 64/32 bit sandbox patch for AMD64 bug 32963 <brad/azarah>.
350    
351     29 Feb 2004; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c :
352     Fix permissions and group of pids file and logs. Permissions should be 0664
353     and group should be 'portage'. Bug #34260.
354    
355     28 Feb 2004; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
356     Besides a small cleanup, redo how we replace LD_PRELOAD in the environ passed
357     to the real execve (in our execve wrapper). Seems that on some arches (sparc
358     among others) do not allow us to tamper with the readonly copy passed to
359     execve, so pass our own copy of the environment. Bug #42290.
360    
361     11 Jan 2004; Nicholas Jones <carpaski@gentoo.org> create-decls:
362     Changed tail to head and added a notice about duration of glibc check.
363    
364     21 Dec 2003; Nicholas Jones <carpaski@gentoo.org> create-decls:
365     Changed the glibc subversion check to use /usr/bin/* instead of /bin/sh
366     as there isn't a guarentee that it is dynamic.
367    
368     02 Nov 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
369     If 'file' passed to before_syscall(const char *func, const char *file) is
370     invalid, we should set errno to ENOENT, and not EINVAL. This should
371     close bug #32238.
372    
373     14 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
374     Fix a bug that occurs mainly on 64bit arch, where the file passed to
375     the functions we wrap, is invalid, and then cause canonicalize to pass
376     garbage to before_syscall(), thanks to great detective work from
377     Andrea Luzzardi <al@sig11.org> (bug #29846).
378    
379     13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
380     Add a uClibc detection patch from Peter S. Mazinger <ps.m@gmx.net>.
381    
382     13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
383     Fix a bug in libsandbox.c 's checking in the rename wrapper - it basically
384     only checked the destination patch, and not the source, so we could move
385     a protected file to a unprotected directory, and then delete/modify it.
386     Thanks to Andrea Luzzardi (scox) <al@sig11.org>, bug #30992, for this fix.
387    
388     12 Oct 2003; Nicholas Jones <carpaski@gentoo.org> sandbox.c :
389     Added python2.3 to the predict section/variable.
390    
391     28 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
392     sandbox.h, sandbox_futils.c :
393     Add support to set the pids file via SANDBOX_PIDS_FILE at startup. If
394     it is not set, it will revert to its old value.
395    
396     27 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
397     Fix our mkdir wrapper to check if the dir exist, and return EEXIST if so,
398     rather than failing with a violation, bug #29748.
399    
400     27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
401     Fix canonicalize() to ignore calls with path = "".
402    
403     27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c,
404     sandbox_futils.c, canonicalize.c :
405     Once again coreutils fails, as my systems had 2.5 kernel, the getcwd system
406     call handled strings larger than PATH_MAX (bug #21766). It however does not
407     work the same on 2.4 kernels.
408    
409     To fix, I added the posix implementation of getcwd() (from glibc cvs) that
410     do not need the system call. We use the default getcwd() function via a
411     wrapper (egetcwd), and then lstat the returned path. If lstat fails, it
412     means the current directory was removed, OR that the the system call for
413     getcwd failed (curious is that it do not fail and return NULL or set
414     errno, but rather just truncate the retured directory - usually from the
415     start), and if so, we use the generic getcwd() function (__egetcwd). Note
416     that we do not use the generic version all the time, as it calls lstat()
417     a great number of times, and performance degrade much.
418    
419     29 Jun 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls,
420     libsandbox.c :
421     Make sure SB_PATH_MAX will not wrap. Fix two possible memory leaks.
422    
423     22 Jun 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, canonicalize.c
424     create-localdecls :
425     When checking path names of files accessed, we need to canonicalize it, else
426     it may be a symlink in a 'write allowed' directory pointing to a file in a
427     directory we should not have write access to.
428    
429     With something like coreutils-5.0, we have two problems:
430     1) One of the tests checks if getcwd() can return a path longer than
431     PATH_MAX. This test then tries to create a dir which even while
432     created local (mkdir("conftest2")), it ends up being resolved with
433     a name that is much larger than PATH_MAX. The problem now is that
434     canonicalize() have undefined behaviour when the path was too long
435     (returned wrongly truncated paths, etc), and pass the wrong path to
436     before_syscall() (causing the bogus sandbox violations).
437     2) The ecanonicalize() function we used, along with the canonicalize()
438     function did not support longer than PATH_MAX. This is partly a
439     cause for 1), but the error checking (rather lack of it) of calls
440     to erealpath() in canonicalize() was the prime reason for 1).
441    
442     As we do not use this canonicalized name to call the function, we resolve this
443     by fixing canonicalize() to do better error checking, and ecanonicalize() as
444     well as all functions in libsandbox.c to use a PATH_MAX of 'PATH_MAX * 2'.
445     While they will resolve paths properly now, and can check if a write/read is
446     allowed, the functions called from the sandboxed environment will still work
447     as expected.
448    
449     This should resolve bug #21766.
450    
451     06 Apr 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
452     For some reason sandbox fails with a 'open_wr' if you run 'locale -a' under
453     it (bug #16298).
454    
455     Problem is that for some reason locale fopen's locale.alias with mode "rm".
456    
457     -------------------------------------------------------
458     nosferatu root # grep fopen locale.log
459     fopen("/usr/share/locale/locale.alias", "rm"ACCESS DENIED open_wr: /usr/share/locale/locale.alias
460     nosferatu root #
461     --------------------------------------------------------
462    
463     I checked the source of locale, but it have fopen with mode 'r', so
464     not sure where the "rm" mode comes from. Anyhow, changed the check in
465     before_syscall_open_char() to also see mode "rm" as readonly.
466    
467     23 Feb 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
468    
469     Add glibc-2.3 support.
470    
471     22 Feb 2003; Martin Schlemmer <azarah@gentoo.org> sandbox.c :
472    
473     Some /etc/ld.so.preload fixes. Just changed the #if defines to cover all
474     operations releated to preload, as well as only try to modify ld.so.preload
475     if we can. Also modify to write the pid to /tmp/sandboxpids.tmp even when
476     not using ld.so.preload. Fix to not write this instance of sandbox's pid
477     to /tmp/sandboxpids.tmp on exit if this is not the last sandbox running.
478    
479     22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> Makefile :
480    
481     Changed the LD to CC for hppa.
482    
483     22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
484    
485     Killed the previous changes I made.
486    
487     17 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
488    
489     Added parisc to BROKEN_RTLD_ARCHLIST to see if it we can fix the relocation probs.
490    
491     09 Jan 2003; J Robert Ray <jrray@gentoo.org> sandbox.c :
492    
493     Don't segfault if $HOME isn't set, set $HOME to "/" instead. Fixes bug 10868.
494    
495     16 Dec 2002; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
496    
497     Fix memory leak for mips, bug #12236. Thanks to Torgeir Hansen <torgeir@trenger.ro>
498     for this fix.
499    
500     4 Dec 2002; J Robert Ray <jrray@gentoo.org> sandbox.h sandbox_futils.c :
501    
502     sandbox_futils defined a dirname() function that was masking the same
503     function in glibc and was broken (e.g.: SANDBOX_DIR was being set to
504     '/usr/lib/portage/bi/'). Fixed function to return expected results and
505     renamed it to sb_dirname() to no longer mask the glibc function. Closes bug
506     11231.
507    
508     4 Dec 2002; Martin Schlemmer <azarah@gentoo.org> :
509    
510     Fix a segfault in libsandbox.c if canonicalize() was called with
511     first parameter = NULL.
512    
513     1 Sep 2002; Martin Schlemmer <azarah@gentoo.org> :
514    
515     Fix my braindead 'return 1;' in a void function. Updated sandbox.c,
516     cleanup() for this.
517    
518     Change cleanup() in sandbox.c not to exit with fail status if
519     the pidsfile is missing. We really should still display sandbox
520     violations if they occured.
521    
522     31 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
523    
524     Update cleanup() in sandbox.c to remove the PIDSFILE if this is
525     the last sandbox running.
526    
527     25 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
528    
529     Major cleanups to mainly libsandbox.c again.
530    
531     22 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
532    
533     Add copyrights to sandbox.h and sandbox_futils.h. If wrong, the
534     parties involved should please contact me so that we can fix it.
535    
536     Add opendir wrapper to libsandbox.c.
537    
538     21 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
539    
540     Do some more cleanups to ecanonicalize(), as it dropped filenames in
541     rare cases (after my symlink cleanups), and caused glibc to bork.
542     These fixes went into canonicalize.c.
543    
544     20 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
545    
546     Fix spawn_shell() and main() in sandbox.c to properly return fail
547     status.
548    
549     19 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
550    
551     The new canonicalize() function in libsandbox.c also resolved symlinks,
552     which caused on cleaning sandbox errors if the symlink pointed to a
553     file in the live root. Ripped out canonicalize() and realpath() from
554     glibc; removed the symlink stuff, and changed them to ecanonicalize()
555     and erealpath().
556    
557     18 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
558    
559     Ripped out all the wrappers, and implemented those of InstallWatch.
560     Losts of cleanups and bugfixes. Implement a execve that forces
561     $LIBSANDBOX in $LD_PRELOAD. We can now thus do away with the feared
562     /etc/ld.so.preload (*g*) ... Made the needed changes to sandbox.c,
563     sandbox.h and sandbox_futils.c. Rewrote the Makefile for most
564     parts; it now have an install target.
565    
566     Reformat the whole thing to look somewhat like the reworked sandbox.c
567     and new sandbox.h and sandbox_futils.c from:
568    
569     Brad House <brad@mainstreetsoftworks.com>.
570    
571     Additional Copyrights now due to the InstallWatch code:
572    
573     Copyright (C) 1998-9 Pancrazio `Ezio' de Mauro <p@demauro.net>

Properties

Name Value
svn:eol-style native
svn:keywords Author Date Id Revision

  ViewVC Help
Powered by ViewVC 1.1.20