/[path-sandbox]/trunk/ChangeLog.0
Gentoo

Contents of /trunk/ChangeLog.0

Parent Directory Parent Directory | Revision Log Revision Log


Revision 32 - (hide annotations) (download)
Wed Mar 2 17:30:16 2005 UTC (9 years, 9 months ago) by azarah
Original Path: trunk/ChangeLog
File size: 14590 byte(s)
Hack to make sure sandboxed process cannot remove a device node, bug #79836.

1 ferringb 2 # ChangeLog for Path Sandbox
2     # Copyright 1999-2004 Gentoo Foundation; Distributed under the GPL v2
3     # $Header$
4    
5 azarah 32 02 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
6     Hack to make sure sandboxed process cannot remove a device node, bug #79836.
7    
8 azarah 31 02 May 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am:
9     Fix symbols.in not added to dist.
10    
11 azarah 29 02 May 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
12 azarah 30 getcwd.c, libsandbox.c, sandbox.c, sandbox.h, sandbox_futils.c:
13     White space fixes.
14    
15     02 May 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
16     configure.in, getcwd.c, libsandbox.c, symbols.in:
17 azarah 29 Fix inverse test logic in canonicalize.c, use a strncpy. Fix gcc warning in
18     getcwd.c. Add symbols.in and logic to Makefile.am to generate symbol versions
19     for glibc and other libc's that use this. Update libsandbox.c to use these
20     symbol versions if available. Fix exec wrapper to re-export LD_PRELOAD if the
21     process unset it.
22    
23 ferringb 28 01 May 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
24     killed off _init and _fini in favor of
25     void __attribute__ ((constructor)) init_func and
26     void __attribute__ ((destructor)) closing_func. _(init|func) were deprecated.
27    
28 ferringb 26 06 Dec 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, libsandbox.c,
29     canonicalize.c, getcwd.c: Fixed compilation *again*. Hopefully cvs is done
30     having the hick-ups.
31    
32 ferringb 24 04 Dec 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, getcwd.c,
33     Makefile.am: Fixed compilation.
34    
35 ferringb 18 01 Dec 2004; Brian Harring <ferringb@gentoo.org> aclocal.m4:
36     Gutted the bugger so it stops checking for a c++ and fortran compiler.
37     Do *not* regenerate aclocal.m4 for making a release until a better
38     solution is created.
39    
40 ferringb 16 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, sandbox_futils.c:
41     Removal of more hardcoded paths.
42    
43 ferringb 13 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in,
44     sandbox_futils.c: tweaks to install sandbox.bashrc, and use it.
45    
46     19 Nov 2004; Brian Harring <ferringb@gentoo.org>:
47 ferringb 6 Sandbox is now autotooled, create-localdecls needs to be killed and the code
48     shifted into configure.in. Currently builds *one* libsandbox.so- if multiple
49     are desired (-m64 and -m32 for amd64), the ebuild should do it (imo).
50     To get to a point of testing, automake && autoconf; created requisite files w/
51     a(utomake|clocal)-1.8, and autoconf 2.59. Installs to /usr/, instead of
52     /lib and /usr/lib/portage/bin.
53    
54 ferringb 2 14 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox.c:
55     closing out bug #70225, potential overflow of the sandbox_pids_file var.
56    
57     07 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c: c99 standard,
58     (think it was at least) allows intermixing of code and data segments. bug #70351
59     should be fixed by this.
60    
61     03 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox_futils.c:
62     futils fix from bug #65201 via solar, and libsandbox log path checks via #69137
63    
64     02 Aug 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Code from
65     Seth Robertson that tracked down all adjuct flags for read operations that
66     do not invoke a write operation.
67    
68     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
69     Another fix from jstubbs regarding a free() on a stack variable for the
70     environment -- tracking now prevents extraneous free()'s segfault.
71    
72     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
73     J. Stubbs tracked down a new bug where mkdir was failing to the patch on
74     the lstat in mkdir... it now only returns 0 or -1 as documented for mkdir.
75     Also remove the errno = ESUCCESS settings as documentation points out that
76     a library isn't allowed to do that.
77    
78     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Added a
79     file_security_check() function to check random potential exploits on files
80     that sandbox is to load and read -- Normally sandboxpids.tmp. This fixes
81     the 'system-crippling' exploits (bug 21923) and catches a few other
82     potential problems.
83    
84     20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> Makefile: Updates for
85     32/64 bit sandbox. Made CC and LD '?=' values to allow passed in CC to work.
86    
87     20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c:
88     bug 42048 -- Fixed the lstat/errno conditions for mkdir <caleb@g.o>.
89     Added the 64/32 bit sandbox patch for AMD64 bug 32963 <brad/azarah>.
90    
91     29 Feb 2004; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c :
92     Fix permissions and group of pids file and logs. Permissions should be 0664
93     and group should be 'portage'. Bug #34260.
94    
95     28 Feb 2004; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
96     Besides a small cleanup, redo how we replace LD_PRELOAD in the environ passed
97     to the real execve (in our execve wrapper). Seems that on some arches (sparc
98     among others) do not allow us to tamper with the readonly copy passed to
99     execve, so pass our own copy of the environment. Bug #42290.
100    
101     11 Jan 2004; Nicholas Jones <carpaski@gentoo.org> create-decls:
102     Changed tail to head and added a notice about duration of glibc check.
103    
104     21 Dec 2003; Nicholas Jones <carpaski@gentoo.org> create-decls:
105     Changed the glibc subversion check to use /usr/bin/* instead of /bin/sh
106     as there isn't a guarentee that it is dynamic.
107    
108     02 Nov 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
109     If 'file' passed to before_syscall(const char *func, const char *file) is
110     invalid, we should set errno to ENOENT, and not EINVAL. This should
111     close bug #32238.
112    
113     14 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
114     Fix a bug that occurs mainly on 64bit arch, where the file passed to
115     the functions we wrap, is invalid, and then cause canonicalize to pass
116     garbage to before_syscall(), thanks to great detective work from
117     Andrea Luzzardi <al@sig11.org> (bug #29846).
118    
119     13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
120     Add a uClibc detection patch from Peter S. Mazinger <ps.m@gmx.net>.
121    
122     13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
123     Fix a bug in libsandbox.c 's checking in the rename wrapper - it basically
124     only checked the destination patch, and not the source, so we could move
125     a protected file to a unprotected directory, and then delete/modify it.
126     Thanks to Andrea Luzzardi (scox) <al@sig11.org>, bug #30992, for this fix.
127    
128     12 Oct 2003; Nicholas Jones <carpaski@gentoo.org> sandbox.c :
129     Added python2.3 to the predict section/variable.
130    
131     28 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
132     sandbox.h, sandbox_futils.c :
133     Add support to set the pids file via SANDBOX_PIDS_FILE at startup. If
134     it is not set, it will revert to its old value.
135    
136     27 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
137     Fix our mkdir wrapper to check if the dir exist, and return EEXIST if so,
138     rather than failing with a violation, bug #29748.
139    
140     27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
141     Fix canonicalize() to ignore calls with path = "".
142    
143     27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c,
144     sandbox_futils.c, canonicalize.c :
145     Once again coreutils fails, as my systems had 2.5 kernel, the getcwd system
146     call handled strings larger than PATH_MAX (bug #21766). It however does not
147     work the same on 2.4 kernels.
148    
149     To fix, I added the posix implementation of getcwd() (from glibc cvs) that
150     do not need the system call. We use the default getcwd() function via a
151     wrapper (egetcwd), and then lstat the returned path. If lstat fails, it
152     means the current directory was removed, OR that the the system call for
153     getcwd failed (curious is that it do not fail and return NULL or set
154     errno, but rather just truncate the retured directory - usually from the
155     start), and if so, we use the generic getcwd() function (__egetcwd). Note
156     that we do not use the generic version all the time, as it calls lstat()
157     a great number of times, and performance degrade much.
158    
159     29 Jun 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls,
160     libsandbox.c :
161     Make sure SB_PATH_MAX will not wrap. Fix two possible memory leaks.
162    
163     22 Jun 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, canonicalize.c
164     create-localdecls :
165     When checking path names of files accessed, we need to canonicalize it, else
166     it may be a symlink in a 'write allowed' directory pointing to a file in a
167     directory we should not have write access to.
168    
169     With something like coreutils-5.0, we have two problems:
170     1) One of the tests checks if getcwd() can return a path longer than
171     PATH_MAX. This test then tries to create a dir which even while
172     created local (mkdir("conftest2")), it ends up being resolved with
173     a name that is much larger than PATH_MAX. The problem now is that
174     canonicalize() have undefined behaviour when the path was too long
175     (returned wrongly truncated paths, etc), and pass the wrong path to
176     before_syscall() (causing the bogus sandbox violations).
177     2) The ecanonicalize() function we used, along with the canonicalize()
178     function did not support longer than PATH_MAX. This is partly a
179     cause for 1), but the error checking (rather lack of it) of calls
180     to erealpath() in canonicalize() was the prime reason for 1).
181    
182     As we do not use this canonicalized name to call the function, we resolve this
183     by fixing canonicalize() to do better error checking, and ecanonicalize() as
184     well as all functions in libsandbox.c to use a PATH_MAX of 'PATH_MAX * 2'.
185     While they will resolve paths properly now, and can check if a write/read is
186     allowed, the functions called from the sandboxed environment will still work
187     as expected.
188    
189     This should resolve bug #21766.
190    
191     06 Apr 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
192     For some reason sandbox fails with a 'open_wr' if you run 'locale -a' under
193     it (bug #16298).
194    
195     Problem is that for some reason locale fopen's locale.alias with mode "rm".
196    
197     -------------------------------------------------------
198     nosferatu root # grep fopen locale.log
199     fopen("/usr/share/locale/locale.alias", "rm"ACCESS DENIED open_wr: /usr/share/locale/locale.alias
200     nosferatu root #
201     --------------------------------------------------------
202    
203     I checked the source of locale, but it have fopen with mode 'r', so
204     not sure where the "rm" mode comes from. Anyhow, changed the check in
205     before_syscall_open_char() to also see mode "rm" as readonly.
206    
207     23 Feb 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
208    
209     Add glibc-2.3 support.
210    
211     22 Feb 2003; Martin Schlemmer <azarah@gentoo.org> sandbox.c :
212    
213     Some /etc/ld.so.preload fixes. Just changed the #if defines to cover all
214     operations releated to preload, as well as only try to modify ld.so.preload
215     if we can. Also modify to write the pid to /tmp/sandboxpids.tmp even when
216     not using ld.so.preload. Fix to not write this instance of sandbox's pid
217     to /tmp/sandboxpids.tmp on exit if this is not the last sandbox running.
218    
219     22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> Makefile :
220    
221     Changed the LD to CC for hppa.
222    
223     22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
224    
225     Killed the previous changes I made.
226    
227     17 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
228    
229     Added parisc to BROKEN_RTLD_ARCHLIST to see if it we can fix the relocation probs.
230    
231     09 Jan 2003; J Robert Ray <jrray@gentoo.org> sandbox.c :
232    
233     Don't segfault if $HOME isn't set, set $HOME to "/" instead. Fixes bug 10868.
234    
235     16 Dec 2002; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
236    
237     Fix memory leak for mips, bug #12236. Thanks to Torgeir Hansen <torgeir@trenger.ro>
238     for this fix.
239    
240     4 Dec 2002; J Robert Ray <jrray@gentoo.org> sandbox.h sandbox_futils.c :
241    
242     sandbox_futils defined a dirname() function that was masking the same
243     function in glibc and was broken (e.g.: SANDBOX_DIR was being set to
244     '/usr/lib/portage/bi/'). Fixed function to return expected results and
245     renamed it to sb_dirname() to no longer mask the glibc function. Closes bug
246     11231.
247    
248     4 Dec 2002; Martin Schlemmer <azarah@gentoo.org> :
249    
250     Fix a segfault in libsandbox.c if canonicalize() was called with
251     first parameter = NULL.
252    
253     1 Sep 2002; Martin Schlemmer <azarah@gentoo.org> :
254    
255     Fix my braindead 'return 1;' in a void function. Updated sandbox.c,
256     cleanup() for this.
257    
258     Change cleanup() in sandbox.c not to exit with fail status if
259     the pidsfile is missing. We really should still display sandbox
260     violations if they occured.
261    
262     31 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
263    
264     Update cleanup() in sandbox.c to remove the PIDSFILE if this is
265     the last sandbox running.
266    
267     25 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
268    
269     Major cleanups to mainly libsandbox.c again.
270    
271     22 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
272    
273     Add copyrights to sandbox.h and sandbox_futils.h. If wrong, the
274     parties involved should please contact me so that we can fix it.
275    
276     Add opendir wrapper to libsandbox.c.
277    
278     21 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
279    
280     Do some more cleanups to ecanonicalize(), as it dropped filenames in
281     rare cases (after my symlink cleanups), and caused glibc to bork.
282     These fixes went into canonicalize.c.
283    
284     20 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
285    
286     Fix spawn_shell() and main() in sandbox.c to properly return fail
287     status.
288    
289     19 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
290    
291     The new canonicalize() function in libsandbox.c also resolved symlinks,
292     which caused on cleaning sandbox errors if the symlink pointed to a
293     file in the live root. Ripped out canonicalize() and realpath() from
294     glibc; removed the symlink stuff, and changed them to ecanonicalize()
295     and erealpath().
296    
297     18 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
298    
299     Ripped out all the wrappers, and implemented those of InstallWatch.
300     Losts of cleanups and bugfixes. Implement a execve that forces
301     $LIBSANDBOX in $LD_PRELOAD. We can now thus do away with the feared
302     /etc/ld.so.preload (*g*) ... Made the needed changes to sandbox.c,
303     sandbox.h and sandbox_futils.c. Rewrote the Makefile for most
304     parts; it now have an install target.
305    
306     Reformat the whole thing to look somewhat like the reworked sandbox.c
307     and new sandbox.h and sandbox_futils.c from:
308    
309     Brad House <brad@mainstreetsoftworks.com>.
310    
311     Additional Copyrights now due to the InstallWatch code:
312    
313     Copyright (C) 1998-9 Pancrazio `Ezio' de Mauro <p@demauro.net>

Properties

Name Value
svn:eol-style native
svn:keywords Author Date Id Revision

  ViewVC Help
Powered by ViewVC 1.1.20