/[path-sandbox]/trunk/ChangeLog.0
Gentoo

Contents of /trunk/ChangeLog.0

Parent Directory Parent Directory | Revision Log Revision Log


Revision 143 - (show annotations) (download)
Thu Jul 7 22:19:52 2005 UTC (9 years ago) by azarah
Original Path: trunk/ChangeLog
File size: 26593 byte(s)
Only declare functions in sandbox_futils.c that are used in libsandbox.c when
OUTSIDE_LIBSANDBOX is not defined.

1 # ChangeLog for Path Sandbox
2 # Copyright 1999-2005 Gentoo Foundation; Distributed under the GPL v2
3 # $Header$
4
5 07 July 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
6 sandbox.h, sandbox_futils.c:
7 - Fix possible segfault in env init code.
8 - Major cleanup of sandbox_futils.c. Removed most of the functions as we now
9 write to /var/log/sandbox/, so in theory do not need all that.
10 - Redo the interface of the get_* functions so that we do not leak memory.
11 - Remove sandbox_dir and co - we are not using it anymore.
12 - Remove unused includes and variables.
13 - Only declare functions in sandbox_futils.c that are used in libsandbox.c when
14 OUTSIDE_LIBSANDBOX is not defined.
15
16 06 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.h, sandbox_futils.c,
17 libsandbox.c:
18 - Change log dir to /var/log/sandbox/. Make sure the sandboxed process cannot
19 write to it.
20 - Clean up logging in libsandbox.c, and hopefully make it more consistant.
21 - Add check_prefixes() with major cleanup on check_access().
22 - Cleanup init_env_entries() and check_prefixes().
23
24 05 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
25 sandbox_futils.c, libsandbox.c:
26 Remove unused 'pids file' code.
27
28 * sandbox-1.2.10 (2005/07/03)
29
30 03 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
31 Add PREDICT items for nss-db, bug #92079. Patch from Robin Johnson.
32
33 17 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
34 General cleanups:
35 - Remove fooling around with exit codes - we error out on presence of a log
36 anyhow.
37 - Move get_sandbox_*_envvar() to sandbox_setup_environ(), as its more
38 appropriate there.
39
40 12 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
41 Cleanup the fail_nametoolong stuff a bit more.
42
43 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
44 Remove hopefully the last ld.so.preload bits we do not use anymore.
45
46 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
47 Remove the unneeded canonicalize() calls in the wrappers - we do it anyhow
48 in check_syscall(). Should speed things up a bit (at least for the getcwd()
49 and long path name test it goes down to under a second, and not 10+ seconds
50 like before). Also warn if we skip checking due to the canonicalized path
51 being too long.
52
53 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
54 More comment/readability cleanups.
55
56 10 June 2005; Martin Schlemmer <azarah@gentoo.org> canonicalize.c, getcwd.c,
57 sandbox_futils.c, libsandbox.c:
58 Some strncpy/strncat and other cleanups.
59
60 * sandbox-1.2.9 (2005/06/09)
61
62 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
63 Move symlink hack down a bit to try and minimize on the amount of lstat()
64 calls we do.
65
66 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
67 Add hack to allow writing to /proc/self/fd (or /dev/fd), bug #91516.
68
69 09 June 2005; Martin Schlemmer <azarah@gentoo.org> symbols.in, libsandbox.c:
70 Add wrapper for access() function, bug #85413.
71
72 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c:
73 Use generic getcwd() implementation from uclibc - should be more portable
74 and looks a bit cleaner.
75
76 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c:
77 Make sure our true_* pointers are initialized to NULL, and that we check for
78 all references that they are valid.
79
80 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
81 Be default we will fail if the path name we try to canonicalize is too long.
82 This however could cause issues with some things (bug #94630 and #21766), so
83 if fail_nametoolong == 0, canonicalize() will return a null length string and
84 do not fail.
85
86 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c:
87 Do not abort if TMPDIR is not valid, but rather use '/tmp', bug #94360. Also
88 make sure we re-export the new TMPDIR environment variable.
89
90 08 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
91 Fix incorrect free of non-malloc'd array, bug #92313 and #94020. Fix noted
92 by Marcus D. Hanwell <cryos@gentoo.org>.
93
94 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
95 Add /dev/console to write list, bug #38588.
96
97 * sandbox-1.2.8 (2005/05/13)
98
99 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
100 sandbox.h, sandbox_futils.c:
101 General cleanups.
102
103 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
104 sandbox.h:
105 Various LD_PRELOAD cleanups. Do not unset LD_PRELOAD for parent.
106
107 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
108 sandbox.h, sandbox_futils.c:
109 Modify get_sandbox_pids_file(), get_sandbox_log() and get_sandbox_debug_log()
110 to use TMPDIR if present in environment.
111
112 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
113 Remove sandbox_log_file from main() as its no longer used.
114
115 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
116 sandbox_futils.c:
117 Add get_sandbox_debug_log(), and use it (add behaviour similar to SANDBOX_LOG
118 if already exported when sandbox started). Fix get_sandbox_log() and new
119 get_sandbox_debug_log() to not use already exported environment variables if
120 they have '/' in them. Use snprintf()'s instead of strncpy()'s. More
121 SB_PATH_MAX fixes.
122
123 * sandbox-1.2.7 (2005/05/12)
124
125 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
126 sandbox_futils.c:
127 More path limit fixes. Declare SB_BUF_LEN global and use it where needed.
128
129 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
130 Fix paths limited to 255 chars. Fix get_sandbox_dir() returning a string
131 with '(null)' in it if we did not call sandbox with absolute path.
132
133 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
134 Set SANDBOX_ON *before* doing the child's env stuff, else its not set
135 for the child.
136
137 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
138 Remove global preload_adaptable as it is no longer used.
139
140 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
141 Rewrite environment stuff to only be set when execve'ing the child process
142 to try and avoid issues like bug #91541 that causes sandbox to crash if
143 we set LD_PRELOAD sandbox side already.
144
145 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
146 Move print_sandbox_log() up to make things neater.
147
148 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
149 Remove load_preload_libs(), as its not used anymore.
150
151 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
152 Remove NO_FORK stuff, as its not used, and 'strace -f' works just fine.
153
154 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
155 Remove USE_SYSTEM_SHELL stuff, as it is not secure, and not in use.
156
157 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
158 Remove ld.so.preload crap - we are not going to use it again.
159
160 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
161 Fix typo in code that checks if we got valid group information, causing a
162 segmentation fault, bug #91637.
163
164 * sandbox-1.2.6 (2005/05/10)
165
166 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
167 Do not use LD_PRELOAD if it contains libtsocks.so, as it breaks sandbox
168 for some odd reason, bug #91541.
169
170 09 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
171 Fix typo (sizeof -> strlen).
172
173 08 May 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
174 rewrote the sbcontext caching code so it accounts for env changes since lib
175 initialization.
176
177 05 May 2005; Martin Schlemmer <azarah@gentoo.org> configure.in, libctest.c:
178 We create libctest.c via configure, so no need to keep it around. Do some
179 cleanup related to libctest.c and libctest during configure.
180
181 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
182 Add rename support of symlinks pointing to protected files/directories.
183
184 * sandbox-1.2.5 (2005/05/04)
185
186 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
187 sandbox.bashrc:
188 Do not reset already set LD_PRELOAD when starting sandbox. If LD_PRELOAD is
189 already set, init of the env vars fails for some reason, so do this later on,
190 and do not warn (bug #91431).
191
192 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
193 sandbox.bashrc:
194 Fixup sandbox and sandbox.bashrc to call bash with the proper .bashrc.
195
196 * sandbox-1.2.4 (2005/05/03)
197
198 03 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
199 Do not init the env entries with each call, as it creates too many calls to
200 lstat, etc. Should speedup things a bit, bug #91040.
201
202 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
203 Add /dev/pty to default write list. Noticed by Morfic.
204
205 02 May 2005; Mike Frysinger <vapier@gentoo.org> configure.in, localdecls.h,
206 sandbox.h:
207 uClibc doesn't support dlvsym() so add a configure check to make sure it doesn't
208 exist. Also update localdecls.h so BROKEN_RTLD_NEXT isn't defined in uClibc.
209
210 * sandbox-1.2.3 (2005/04/29)
211
212 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> configure.in:
213 Do not check for (*&#$(* CXX or F77.
214
215 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
216 Do not append '/' to pathname in filter_path() if it already ends with it.
217
218 28 Apr 2005; Mike Frysinger <vapier@gentoo.org> Makefile.am, configure.in:
219 With az's help, clean up autotools to work with cross-compiling.
220
221 * sandbox-1.2.2 (2005/04/28)
222
223 28 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
224 Only check for /dev/{null,zero} for unlink hack, else ricers using /dev/shm
225 have issues; bug #90592.
226
227 * sandbox-1.2.1 (2005/04/23)
228
229 23 Apr 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
230 getcwd.c, libsandbox.c, localdecls.h, sandbox.h, sandbox_futils.c:
231 Make sure all functions used in libsandbox.c is declared static. Define
232 SB_STATIC in localdecls.h for this. Include sandbox_futils.c rather than
233 linking with its object. Hopefully this will fix bug #90153.
234
235 * sandbox-1.2 (2005/04/23)
236
237 22 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
238 Allow lchown a symlink in write-allowed path pointing to write-denied
239 target.
240
241 21 Mar 2005; Marius Mauch <genone@gentoo.org> libsandbox.c:
242 Also show resolved symlink names in the log.
243
244 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, libsandbox.c:
245 Seems -nostdlib was the problem with the constructor/destructor - remove it
246 from Makefile.am, and change the constructor/destructor names again.
247
248 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
249 Also rename the _init() and _fini() declarations.
250
251 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
252 Fixup the constructor/destructor function names again (they should be _init()
253 and _fini() it seems, and not being called caused sandbox_lib_path to be
254 unset, and thus breaking the execve() wrapper's LD_PRELOAD protection).
255 Add both the path in given SANDBOX_x variable, as well as its symlink
256 resolved path in init_env_entries(). Modify filter_path() to be able to
257 resolve paths without resolving symlinks, as well as to be able to resolve
258 symlinks. Fix a possible segfault in check_access(). Add symlink resolving
259 to check_access() resolving bug #31019. Add 'hack' for unlink, as the fix
260 for bug #31019 cause access violations if we try to remove a symlink that is
261 not in protected path, but points to a protected path. Fix a memory leak in
262 sandbox.c (sandbox_pids_file in main()). Fix the realpath() calls in main()
263 (sandbox.c) being unchecked. Fix the debug logname not having the pid in it
264 (pid_string was uninitialized). General syntax cleanups.
265
266 09 Mar 2005; Brian Harring <ferringb@gentoo.org> sandbox.c: Fixed the
267 infamous "pids file is not a regular file" w/out newline bug.
268
269 09 Mar 2005; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in:
270 Correct libc_version path detection, since it was screwing up if libdir !=
271 "/lib/".
272
273 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
274 Hack to make sure sandboxed process cannot remove a device node, bug #79836.
275
276 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am:
277 Fix symbols.in not added to dist.
278
279 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
280 getcwd.c, libsandbox.c, sandbox.c, sandbox.h, sandbox_futils.c:
281 White space fixes.
282
283 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
284 configure.in, getcwd.c, libsandbox.c, symbols.in:
285 Fix inverse test logic in canonicalize.c, use a strncpy. Fix gcc warning in
286 getcwd.c. Add symbols.in and logic to Makefile.am to generate symbol versions
287 for glibc and other libc's that use this. Update libsandbox.c to use these
288 symbol versions if available. Fix exec wrapper to re-export LD_PRELOAD if the
289 process unset it.
290
291 01 Mar 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
292 killed off _init and _fini in favor of
293 void __attribute__ ((constructor)) init_func and
294 void __attribute__ ((destructor)) closing_func. _(init|func) were deprecated.
295
296 06 Dec 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, libsandbox.c,
297 canonicalize.c, getcwd.c: Fixed compilation *again*. Hopefully cvs is done
298 having the hick-ups.
299
300 04 Dec 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, getcwd.c,
301 Makefile.am: Fixed compilation.
302
303 01 Dec 2004; Brian Harring <ferringb@gentoo.org> aclocal.m4:
304 Gutted the bugger so it stops checking for a c++ and fortran compiler.
305 Do *not* regenerate aclocal.m4 for making a release until a better
306 solution is created.
307
308 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, sandbox_futils.c:
309 Removal of more hardcoded paths.
310
311 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in,
312 sandbox_futils.c: tweaks to install sandbox.bashrc, and use it.
313
314 19 Nov 2004; Brian Harring <ferringb@gentoo.org>:
315 Sandbox is now autotooled, create-localdecls needs to be killed and the code
316 shifted into configure.in. Currently builds *one* libsandbox.so- if multiple
317 are desired (-m64 and -m32 for amd64), the ebuild should do it (imo).
318 To get to a point of testing, automake && autoconf; created requisite files w/
319 a(utomake|clocal)-1.8, and autoconf 2.59. Installs to /usr/, instead of
320 /lib and /usr/lib/portage/bin.
321
322 14 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox.c:
323 closing out bug #70225, potential overflow of the sandbox_pids_file var.
324
325 07 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c: c99 standard,
326 (think it was at least) allows intermixing of code and data segments. bug #70351
327 should be fixed by this.
328
329 03 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox_futils.c:
330 futils fix from bug #65201 via solar, and libsandbox log path checks via #69137
331
332 02 Aug 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Code from
333 Seth Robertson that tracked down all adjuct flags for read operations that
334 do not invoke a write operation.
335
336 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
337 Another fix from jstubbs regarding a free() on a stack variable for the
338 environment -- tracking now prevents extraneous free()'s segfault.
339
340 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
341 J. Stubbs tracked down a new bug where mkdir was failing to the patch on
342 the lstat in mkdir... it now only returns 0 or -1 as documented for mkdir.
343 Also remove the errno = ESUCCESS settings as documentation points out that
344 a library isn't allowed to do that.
345
346 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Added a
347 file_security_check() function to check random potential exploits on files
348 that sandbox is to load and read -- Normally sandboxpids.tmp. This fixes
349 the 'system-crippling' exploits (bug 21923) and catches a few other
350 potential problems.
351
352 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> Makefile: Updates for
353 32/64 bit sandbox. Made CC and LD '?=' values to allow passed in CC to work.
354
355 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c:
356 bug 42048 -- Fixed the lstat/errno conditions for mkdir <caleb@g.o>.
357 Added the 64/32 bit sandbox patch for AMD64 bug 32963 <brad/azarah>.
358
359 29 Feb 2004; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c :
360 Fix permissions and group of pids file and logs. Permissions should be 0664
361 and group should be 'portage'. Bug #34260.
362
363 28 Feb 2004; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
364 Besides a small cleanup, redo how we replace LD_PRELOAD in the environ passed
365 to the real execve (in our execve wrapper). Seems that on some arches (sparc
366 among others) do not allow us to tamper with the readonly copy passed to
367 execve, so pass our own copy of the environment. Bug #42290.
368
369 11 Jan 2004; Nicholas Jones <carpaski@gentoo.org> create-decls:
370 Changed tail to head and added a notice about duration of glibc check.
371
372 21 Dec 2003; Nicholas Jones <carpaski@gentoo.org> create-decls:
373 Changed the glibc subversion check to use /usr/bin/* instead of /bin/sh
374 as there isn't a guarentee that it is dynamic.
375
376 02 Nov 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
377 If 'file' passed to before_syscall(const char *func, const char *file) is
378 invalid, we should set errno to ENOENT, and not EINVAL. This should
379 close bug #32238.
380
381 14 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
382 Fix a bug that occurs mainly on 64bit arch, where the file passed to
383 the functions we wrap, is invalid, and then cause canonicalize to pass
384 garbage to before_syscall(), thanks to great detective work from
385 Andrea Luzzardi <al@sig11.org> (bug #29846).
386
387 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
388 Add a uClibc detection patch from Peter S. Mazinger <ps.m@gmx.net>.
389
390 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
391 Fix a bug in libsandbox.c 's checking in the rename wrapper - it basically
392 only checked the destination patch, and not the source, so we could move
393 a protected file to a unprotected directory, and then delete/modify it.
394 Thanks to Andrea Luzzardi (scox) <al@sig11.org>, bug #30992, for this fix.
395
396 12 Oct 2003; Nicholas Jones <carpaski@gentoo.org> sandbox.c :
397 Added python2.3 to the predict section/variable.
398
399 28 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
400 sandbox.h, sandbox_futils.c :
401 Add support to set the pids file via SANDBOX_PIDS_FILE at startup. If
402 it is not set, it will revert to its old value.
403
404 27 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
405 Fix our mkdir wrapper to check if the dir exist, and return EEXIST if so,
406 rather than failing with a violation, bug #29748.
407
408 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
409 Fix canonicalize() to ignore calls with path = "".
410
411 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c,
412 sandbox_futils.c, canonicalize.c :
413 Once again coreutils fails, as my systems had 2.5 kernel, the getcwd system
414 call handled strings larger than PATH_MAX (bug #21766). It however does not
415 work the same on 2.4 kernels.
416
417 To fix, I added the posix implementation of getcwd() (from glibc cvs) that
418 do not need the system call. We use the default getcwd() function via a
419 wrapper (egetcwd), and then lstat the returned path. If lstat fails, it
420 means the current directory was removed, OR that the the system call for
421 getcwd failed (curious is that it do not fail and return NULL or set
422 errno, but rather just truncate the retured directory - usually from the
423 start), and if so, we use the generic getcwd() function (__egetcwd). Note
424 that we do not use the generic version all the time, as it calls lstat()
425 a great number of times, and performance degrade much.
426
427 29 Jun 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls,
428 libsandbox.c :
429 Make sure SB_PATH_MAX will not wrap. Fix two possible memory leaks.
430
431 22 Jun 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, canonicalize.c
432 create-localdecls :
433 When checking path names of files accessed, we need to canonicalize it, else
434 it may be a symlink in a 'write allowed' directory pointing to a file in a
435 directory we should not have write access to.
436
437 With something like coreutils-5.0, we have two problems:
438 1) One of the tests checks if getcwd() can return a path longer than
439 PATH_MAX. This test then tries to create a dir which even while
440 created local (mkdir("conftest2")), it ends up being resolved with
441 a name that is much larger than PATH_MAX. The problem now is that
442 canonicalize() have undefined behaviour when the path was too long
443 (returned wrongly truncated paths, etc), and pass the wrong path to
444 before_syscall() (causing the bogus sandbox violations).
445 2) The ecanonicalize() function we used, along with the canonicalize()
446 function did not support longer than PATH_MAX. This is partly a
447 cause for 1), but the error checking (rather lack of it) of calls
448 to erealpath() in canonicalize() was the prime reason for 1).
449
450 As we do not use this canonicalized name to call the function, we resolve this
451 by fixing canonicalize() to do better error checking, and ecanonicalize() as
452 well as all functions in libsandbox.c to use a PATH_MAX of 'PATH_MAX * 2'.
453 While they will resolve paths properly now, and can check if a write/read is
454 allowed, the functions called from the sandboxed environment will still work
455 as expected.
456
457 This should resolve bug #21766.
458
459 06 Apr 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
460 For some reason sandbox fails with a 'open_wr' if you run 'locale -a' under
461 it (bug #16298).
462
463 Problem is that for some reason locale fopen's locale.alias with mode "rm".
464
465 -------------------------------------------------------
466 nosferatu root # grep fopen locale.log
467 fopen("/usr/share/locale/locale.alias", "rm"ACCESS DENIED open_wr: /usr/share/locale/locale.alias
468 nosferatu root #
469 --------------------------------------------------------
470
471 I checked the source of locale, but it have fopen with mode 'r', so
472 not sure where the "rm" mode comes from. Anyhow, changed the check in
473 before_syscall_open_char() to also see mode "rm" as readonly.
474
475 23 Feb 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
476
477 Add glibc-2.3 support.
478
479 22 Feb 2003; Martin Schlemmer <azarah@gentoo.org> sandbox.c :
480
481 Some /etc/ld.so.preload fixes. Just changed the #if defines to cover all
482 operations releated to preload, as well as only try to modify ld.so.preload
483 if we can. Also modify to write the pid to /tmp/sandboxpids.tmp even when
484 not using ld.so.preload. Fix to not write this instance of sandbox's pid
485 to /tmp/sandboxpids.tmp on exit if this is not the last sandbox running.
486
487 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> Makefile :
488
489 Changed the LD to CC for hppa.
490
491 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
492
493 Killed the previous changes I made.
494
495 17 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
496
497 Added parisc to BROKEN_RTLD_ARCHLIST to see if it we can fix the relocation probs.
498
499 09 Jan 2003; J Robert Ray <jrray@gentoo.org> sandbox.c :
500
501 Don't segfault if $HOME isn't set, set $HOME to "/" instead. Fixes bug 10868.
502
503 16 Dec 2002; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
504
505 Fix memory leak for mips, bug #12236. Thanks to Torgeir Hansen <torgeir@trenger.ro>
506 for this fix.
507
508 4 Dec 2002; J Robert Ray <jrray@gentoo.org> sandbox.h sandbox_futils.c :
509
510 sandbox_futils defined a dirname() function that was masking the same
511 function in glibc and was broken (e.g.: SANDBOX_DIR was being set to
512 '/usr/lib/portage/bi/'). Fixed function to return expected results and
513 renamed it to sb_dirname() to no longer mask the glibc function. Closes bug
514 11231.
515
516 4 Dec 2002; Martin Schlemmer <azarah@gentoo.org> :
517
518 Fix a segfault in libsandbox.c if canonicalize() was called with
519 first parameter = NULL.
520
521 1 Sep 2002; Martin Schlemmer <azarah@gentoo.org> :
522
523 Fix my braindead 'return 1;' in a void function. Updated sandbox.c,
524 cleanup() for this.
525
526 Change cleanup() in sandbox.c not to exit with fail status if
527 the pidsfile is missing. We really should still display sandbox
528 violations if they occured.
529
530 31 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
531
532 Update cleanup() in sandbox.c to remove the PIDSFILE if this is
533 the last sandbox running.
534
535 25 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
536
537 Major cleanups to mainly libsandbox.c again.
538
539 22 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
540
541 Add copyrights to sandbox.h and sandbox_futils.h. If wrong, the
542 parties involved should please contact me so that we can fix it.
543
544 Add opendir wrapper to libsandbox.c.
545
546 21 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
547
548 Do some more cleanups to ecanonicalize(), as it dropped filenames in
549 rare cases (after my symlink cleanups), and caused glibc to bork.
550 These fixes went into canonicalize.c.
551
552 20 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
553
554 Fix spawn_shell() and main() in sandbox.c to properly return fail
555 status.
556
557 19 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
558
559 The new canonicalize() function in libsandbox.c also resolved symlinks,
560 which caused on cleaning sandbox errors if the symlink pointed to a
561 file in the live root. Ripped out canonicalize() and realpath() from
562 glibc; removed the symlink stuff, and changed them to ecanonicalize()
563 and erealpath().
564
565 18 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
566
567 Ripped out all the wrappers, and implemented those of InstallWatch.
568 Losts of cleanups and bugfixes. Implement a execve that forces
569 $LIBSANDBOX in $LD_PRELOAD. We can now thus do away with the feared
570 /etc/ld.so.preload (*g*) ... Made the needed changes to sandbox.c,
571 sandbox.h and sandbox_futils.c. Rewrote the Makefile for most
572 parts; it now have an install target.
573
574 Reformat the whole thing to look somewhat like the reworked sandbox.c
575 and new sandbox.h and sandbox_futils.c from:
576
577 Brad House <brad@mainstreetsoftworks.com>.
578
579 Additional Copyrights now due to the InstallWatch code:
580
581 Copyright (C) 1998-9 Pancrazio `Ezio' de Mauro <p@demauro.net>

Properties

Name Value
svn:eol-style native
svn:keywords Author Date Id Revision

  ViewVC Help
Powered by ViewVC 1.1.20