/[path-sandbox]/trunk/ChangeLog.0
Gentoo

Contents of /trunk/ChangeLog.0

Parent Directory Parent Directory | Revision Log Revision Log


Revision 146 - (show annotations) (download)
Fri Jul 8 15:07:50 2005 UTC (9 years, 1 month ago) by azarah
Original Path: trunk/ChangeLog
File size: 26945 byte(s)
Remove old logs if present and conflicting with current.
1 # ChangeLog for Path Sandbox
2 # Copyright 1999-2005 Gentoo Foundation; Distributed under the GPL v2
3 # $Header$
4
5 08 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c,
6 libsandbox.c:
7 - Try to cleanup and make error handling/printing consistent.
8 - Remove old logs if present and conflicting with current.
9
10 07 July 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
11 sandbox.h, sandbox_futils.c:
12 - Fix possible segfault in env init code.
13 - Major cleanup of sandbox_futils.c. Removed most of the functions as we now
14 write to /var/log/sandbox/, so in theory do not need all that.
15 - Redo the interface of the get_* functions so that we do not leak memory.
16 - Remove sandbox_dir and co - we are not using it anymore.
17 - Remove unused includes and variables.
18 - Only declare functions in sandbox_futils.c that are used in libsandbox.c when
19 OUTSIDE_LIBSANDBOX is not defined.
20 - Cleanup access/log printing. Make access printing honour NOCOLOR. Fix log
21 printing's last line not honouring NOCOLOR.
22
23 06 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.h, sandbox_futils.c,
24 libsandbox.c:
25 - Change log dir to /var/log/sandbox/. Make sure the sandboxed process cannot
26 write to it.
27 - Clean up logging in libsandbox.c, and hopefully make it more consistant.
28 - Add check_prefixes() with major cleanup on check_access().
29 - Cleanup init_env_entries() and check_prefixes().
30
31 05 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
32 sandbox_futils.c, libsandbox.c:
33 Remove unused 'pids file' code.
34
35 * sandbox-1.2.10 (2005/07/03)
36
37 03 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
38 Add PREDICT items for nss-db, bug #92079. Patch from Robin Johnson.
39
40 17 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
41 General cleanups:
42 - Remove fooling around with exit codes - we error out on presence of a log
43 anyhow.
44 - Move get_sandbox_*_envvar() to sandbox_setup_environ(), as its more
45 appropriate there.
46
47 12 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
48 Cleanup the fail_nametoolong stuff a bit more.
49
50 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
51 Remove hopefully the last ld.so.preload bits we do not use anymore.
52
53 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
54 Remove the unneeded canonicalize() calls in the wrappers - we do it anyhow
55 in check_syscall(). Should speed things up a bit (at least for the getcwd()
56 and long path name test it goes down to under a second, and not 10+ seconds
57 like before). Also warn if we skip checking due to the canonicalized path
58 being too long.
59
60 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
61 More comment/readability cleanups.
62
63 10 June 2005; Martin Schlemmer <azarah@gentoo.org> canonicalize.c, getcwd.c,
64 sandbox_futils.c, libsandbox.c:
65 Some strncpy/strncat and other cleanups.
66
67 * sandbox-1.2.9 (2005/06/09)
68
69 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
70 Move symlink hack down a bit to try and minimize on the amount of lstat()
71 calls we do.
72
73 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
74 Add hack to allow writing to /proc/self/fd (or /dev/fd), bug #91516.
75
76 09 June 2005; Martin Schlemmer <azarah@gentoo.org> symbols.in, libsandbox.c:
77 Add wrapper for access() function, bug #85413.
78
79 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c:
80 Use generic getcwd() implementation from uclibc - should be more portable
81 and looks a bit cleaner.
82
83 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c:
84 Make sure our true_* pointers are initialized to NULL, and that we check for
85 all references that they are valid.
86
87 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
88 Be default we will fail if the path name we try to canonicalize is too long.
89 This however could cause issues with some things (bug #94630 and #21766), so
90 if fail_nametoolong == 0, canonicalize() will return a null length string and
91 do not fail.
92
93 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c:
94 Do not abort if TMPDIR is not valid, but rather use '/tmp', bug #94360. Also
95 make sure we re-export the new TMPDIR environment variable.
96
97 08 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
98 Fix incorrect free of non-malloc'd array, bug #92313 and #94020. Fix noted
99 by Marcus D. Hanwell <cryos@gentoo.org>.
100
101 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
102 Add /dev/console to write list, bug #38588.
103
104 * sandbox-1.2.8 (2005/05/13)
105
106 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
107 sandbox.h, sandbox_futils.c:
108 General cleanups.
109
110 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
111 sandbox.h:
112 Various LD_PRELOAD cleanups. Do not unset LD_PRELOAD for parent.
113
114 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
115 sandbox.h, sandbox_futils.c:
116 Modify get_sandbox_pids_file(), get_sandbox_log() and get_sandbox_debug_log()
117 to use TMPDIR if present in environment.
118
119 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
120 Remove sandbox_log_file from main() as its no longer used.
121
122 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
123 sandbox_futils.c:
124 Add get_sandbox_debug_log(), and use it (add behaviour similar to SANDBOX_LOG
125 if already exported when sandbox started). Fix get_sandbox_log() and new
126 get_sandbox_debug_log() to not use already exported environment variables if
127 they have '/' in them. Use snprintf()'s instead of strncpy()'s. More
128 SB_PATH_MAX fixes.
129
130 * sandbox-1.2.7 (2005/05/12)
131
132 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
133 sandbox_futils.c:
134 More path limit fixes. Declare SB_BUF_LEN global and use it where needed.
135
136 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
137 Fix paths limited to 255 chars. Fix get_sandbox_dir() returning a string
138 with '(null)' in it if we did not call sandbox with absolute path.
139
140 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
141 Set SANDBOX_ON *before* doing the child's env stuff, else its not set
142 for the child.
143
144 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
145 Remove global preload_adaptable as it is no longer used.
146
147 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
148 Rewrite environment stuff to only be set when execve'ing the child process
149 to try and avoid issues like bug #91541 that causes sandbox to crash if
150 we set LD_PRELOAD sandbox side already.
151
152 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
153 Move print_sandbox_log() up to make things neater.
154
155 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
156 Remove load_preload_libs(), as its not used anymore.
157
158 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
159 Remove NO_FORK stuff, as its not used, and 'strace -f' works just fine.
160
161 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
162 Remove USE_SYSTEM_SHELL stuff, as it is not secure, and not in use.
163
164 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
165 Remove ld.so.preload crap - we are not going to use it again.
166
167 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
168 Fix typo in code that checks if we got valid group information, causing a
169 segmentation fault, bug #91637.
170
171 * sandbox-1.2.6 (2005/05/10)
172
173 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
174 Do not use LD_PRELOAD if it contains libtsocks.so, as it breaks sandbox
175 for some odd reason, bug #91541.
176
177 09 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
178 Fix typo (sizeof -> strlen).
179
180 08 May 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
181 rewrote the sbcontext caching code so it accounts for env changes since lib
182 initialization.
183
184 05 May 2005; Martin Schlemmer <azarah@gentoo.org> configure.in, libctest.c:
185 We create libctest.c via configure, so no need to keep it around. Do some
186 cleanup related to libctest.c and libctest during configure.
187
188 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
189 Add rename support of symlinks pointing to protected files/directories.
190
191 * sandbox-1.2.5 (2005/05/04)
192
193 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
194 sandbox.bashrc:
195 Do not reset already set LD_PRELOAD when starting sandbox. If LD_PRELOAD is
196 already set, init of the env vars fails for some reason, so do this later on,
197 and do not warn (bug #91431).
198
199 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
200 sandbox.bashrc:
201 Fixup sandbox and sandbox.bashrc to call bash with the proper .bashrc.
202
203 * sandbox-1.2.4 (2005/05/03)
204
205 03 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
206 Do not init the env entries with each call, as it creates too many calls to
207 lstat, etc. Should speedup things a bit, bug #91040.
208
209 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
210 Add /dev/pty to default write list. Noticed by Morfic.
211
212 02 May 2005; Mike Frysinger <vapier@gentoo.org> configure.in, localdecls.h,
213 sandbox.h:
214 uClibc doesn't support dlvsym() so add a configure check to make sure it doesn't
215 exist. Also update localdecls.h so BROKEN_RTLD_NEXT isn't defined in uClibc.
216
217 * sandbox-1.2.3 (2005/04/29)
218
219 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> configure.in:
220 Do not check for (*&#$(* CXX or F77.
221
222 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
223 Do not append '/' to pathname in filter_path() if it already ends with it.
224
225 28 Apr 2005; Mike Frysinger <vapier@gentoo.org> Makefile.am, configure.in:
226 With az's help, clean up autotools to work with cross-compiling.
227
228 * sandbox-1.2.2 (2005/04/28)
229
230 28 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
231 Only check for /dev/{null,zero} for unlink hack, else ricers using /dev/shm
232 have issues; bug #90592.
233
234 * sandbox-1.2.1 (2005/04/23)
235
236 23 Apr 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
237 getcwd.c, libsandbox.c, localdecls.h, sandbox.h, sandbox_futils.c:
238 Make sure all functions used in libsandbox.c is declared static. Define
239 SB_STATIC in localdecls.h for this. Include sandbox_futils.c rather than
240 linking with its object. Hopefully this will fix bug #90153.
241
242 * sandbox-1.2 (2005/04/23)
243
244 22 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
245 Allow lchown a symlink in write-allowed path pointing to write-denied
246 target.
247
248 21 Mar 2005; Marius Mauch <genone@gentoo.org> libsandbox.c:
249 Also show resolved symlink names in the log.
250
251 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, libsandbox.c:
252 Seems -nostdlib was the problem with the constructor/destructor - remove it
253 from Makefile.am, and change the constructor/destructor names again.
254
255 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
256 Also rename the _init() and _fini() declarations.
257
258 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
259 Fixup the constructor/destructor function names again (they should be _init()
260 and _fini() it seems, and not being called caused sandbox_lib_path to be
261 unset, and thus breaking the execve() wrapper's LD_PRELOAD protection).
262 Add both the path in given SANDBOX_x variable, as well as its symlink
263 resolved path in init_env_entries(). Modify filter_path() to be able to
264 resolve paths without resolving symlinks, as well as to be able to resolve
265 symlinks. Fix a possible segfault in check_access(). Add symlink resolving
266 to check_access() resolving bug #31019. Add 'hack' for unlink, as the fix
267 for bug #31019 cause access violations if we try to remove a symlink that is
268 not in protected path, but points to a protected path. Fix a memory leak in
269 sandbox.c (sandbox_pids_file in main()). Fix the realpath() calls in main()
270 (sandbox.c) being unchecked. Fix the debug logname not having the pid in it
271 (pid_string was uninitialized). General syntax cleanups.
272
273 09 Mar 2005; Brian Harring <ferringb@gentoo.org> sandbox.c: Fixed the
274 infamous "pids file is not a regular file" w/out newline bug.
275
276 09 Mar 2005; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in:
277 Correct libc_version path detection, since it was screwing up if libdir !=
278 "/lib/".
279
280 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
281 Hack to make sure sandboxed process cannot remove a device node, bug #79836.
282
283 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am:
284 Fix symbols.in not added to dist.
285
286 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
287 getcwd.c, libsandbox.c, sandbox.c, sandbox.h, sandbox_futils.c:
288 White space fixes.
289
290 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
291 configure.in, getcwd.c, libsandbox.c, symbols.in:
292 Fix inverse test logic in canonicalize.c, use a strncpy. Fix gcc warning in
293 getcwd.c. Add symbols.in and logic to Makefile.am to generate symbol versions
294 for glibc and other libc's that use this. Update libsandbox.c to use these
295 symbol versions if available. Fix exec wrapper to re-export LD_PRELOAD if the
296 process unset it.
297
298 01 Mar 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
299 killed off _init and _fini in favor of
300 void __attribute__ ((constructor)) init_func and
301 void __attribute__ ((destructor)) closing_func. _(init|func) were deprecated.
302
303 06 Dec 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, libsandbox.c,
304 canonicalize.c, getcwd.c: Fixed compilation *again*. Hopefully cvs is done
305 having the hick-ups.
306
307 04 Dec 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, getcwd.c,
308 Makefile.am: Fixed compilation.
309
310 01 Dec 2004; Brian Harring <ferringb@gentoo.org> aclocal.m4:
311 Gutted the bugger so it stops checking for a c++ and fortran compiler.
312 Do *not* regenerate aclocal.m4 for making a release until a better
313 solution is created.
314
315 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, sandbox_futils.c:
316 Removal of more hardcoded paths.
317
318 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in,
319 sandbox_futils.c: tweaks to install sandbox.bashrc, and use it.
320
321 19 Nov 2004; Brian Harring <ferringb@gentoo.org>:
322 Sandbox is now autotooled, create-localdecls needs to be killed and the code
323 shifted into configure.in. Currently builds *one* libsandbox.so- if multiple
324 are desired (-m64 and -m32 for amd64), the ebuild should do it (imo).
325 To get to a point of testing, automake && autoconf; created requisite files w/
326 a(utomake|clocal)-1.8, and autoconf 2.59. Installs to /usr/, instead of
327 /lib and /usr/lib/portage/bin.
328
329 14 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox.c:
330 closing out bug #70225, potential overflow of the sandbox_pids_file var.
331
332 07 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c: c99 standard,
333 (think it was at least) allows intermixing of code and data segments. bug #70351
334 should be fixed by this.
335
336 03 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox_futils.c:
337 futils fix from bug #65201 via solar, and libsandbox log path checks via #69137
338
339 02 Aug 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Code from
340 Seth Robertson that tracked down all adjuct flags for read operations that
341 do not invoke a write operation.
342
343 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
344 Another fix from jstubbs regarding a free() on a stack variable for the
345 environment -- tracking now prevents extraneous free()'s segfault.
346
347 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
348 J. Stubbs tracked down a new bug where mkdir was failing to the patch on
349 the lstat in mkdir... it now only returns 0 or -1 as documented for mkdir.
350 Also remove the errno = ESUCCESS settings as documentation points out that
351 a library isn't allowed to do that.
352
353 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Added a
354 file_security_check() function to check random potential exploits on files
355 that sandbox is to load and read -- Normally sandboxpids.tmp. This fixes
356 the 'system-crippling' exploits (bug 21923) and catches a few other
357 potential problems.
358
359 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> Makefile: Updates for
360 32/64 bit sandbox. Made CC and LD '?=' values to allow passed in CC to work.
361
362 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c:
363 bug 42048 -- Fixed the lstat/errno conditions for mkdir <caleb@g.o>.
364 Added the 64/32 bit sandbox patch for AMD64 bug 32963 <brad/azarah>.
365
366 29 Feb 2004; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c :
367 Fix permissions and group of pids file and logs. Permissions should be 0664
368 and group should be 'portage'. Bug #34260.
369
370 28 Feb 2004; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
371 Besides a small cleanup, redo how we replace LD_PRELOAD in the environ passed
372 to the real execve (in our execve wrapper). Seems that on some arches (sparc
373 among others) do not allow us to tamper with the readonly copy passed to
374 execve, so pass our own copy of the environment. Bug #42290.
375
376 11 Jan 2004; Nicholas Jones <carpaski@gentoo.org> create-decls:
377 Changed tail to head and added a notice about duration of glibc check.
378
379 21 Dec 2003; Nicholas Jones <carpaski@gentoo.org> create-decls:
380 Changed the glibc subversion check to use /usr/bin/* instead of /bin/sh
381 as there isn't a guarentee that it is dynamic.
382
383 02 Nov 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
384 If 'file' passed to before_syscall(const char *func, const char *file) is
385 invalid, we should set errno to ENOENT, and not EINVAL. This should
386 close bug #32238.
387
388 14 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
389 Fix a bug that occurs mainly on 64bit arch, where the file passed to
390 the functions we wrap, is invalid, and then cause canonicalize to pass
391 garbage to before_syscall(), thanks to great detective work from
392 Andrea Luzzardi <al@sig11.org> (bug #29846).
393
394 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
395 Add a uClibc detection patch from Peter S. Mazinger <ps.m@gmx.net>.
396
397 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
398 Fix a bug in libsandbox.c 's checking in the rename wrapper - it basically
399 only checked the destination patch, and not the source, so we could move
400 a protected file to a unprotected directory, and then delete/modify it.
401 Thanks to Andrea Luzzardi (scox) <al@sig11.org>, bug #30992, for this fix.
402
403 12 Oct 2003; Nicholas Jones <carpaski@gentoo.org> sandbox.c :
404 Added python2.3 to the predict section/variable.
405
406 28 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
407 sandbox.h, sandbox_futils.c :
408 Add support to set the pids file via SANDBOX_PIDS_FILE at startup. If
409 it is not set, it will revert to its old value.
410
411 27 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
412 Fix our mkdir wrapper to check if the dir exist, and return EEXIST if so,
413 rather than failing with a violation, bug #29748.
414
415 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
416 Fix canonicalize() to ignore calls with path = "".
417
418 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c,
419 sandbox_futils.c, canonicalize.c :
420 Once again coreutils fails, as my systems had 2.5 kernel, the getcwd system
421 call handled strings larger than PATH_MAX (bug #21766). It however does not
422 work the same on 2.4 kernels.
423
424 To fix, I added the posix implementation of getcwd() (from glibc cvs) that
425 do not need the system call. We use the default getcwd() function via a
426 wrapper (egetcwd), and then lstat the returned path. If lstat fails, it
427 means the current directory was removed, OR that the the system call for
428 getcwd failed (curious is that it do not fail and return NULL or set
429 errno, but rather just truncate the retured directory - usually from the
430 start), and if so, we use the generic getcwd() function (__egetcwd). Note
431 that we do not use the generic version all the time, as it calls lstat()
432 a great number of times, and performance degrade much.
433
434 29 Jun 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls,
435 libsandbox.c :
436 Make sure SB_PATH_MAX will not wrap. Fix two possible memory leaks.
437
438 22 Jun 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, canonicalize.c
439 create-localdecls :
440 When checking path names of files accessed, we need to canonicalize it, else
441 it may be a symlink in a 'write allowed' directory pointing to a file in a
442 directory we should not have write access to.
443
444 With something like coreutils-5.0, we have two problems:
445 1) One of the tests checks if getcwd() can return a path longer than
446 PATH_MAX. This test then tries to create a dir which even while
447 created local (mkdir("conftest2")), it ends up being resolved with
448 a name that is much larger than PATH_MAX. The problem now is that
449 canonicalize() have undefined behaviour when the path was too long
450 (returned wrongly truncated paths, etc), and pass the wrong path to
451 before_syscall() (causing the bogus sandbox violations).
452 2) The ecanonicalize() function we used, along with the canonicalize()
453 function did not support longer than PATH_MAX. This is partly a
454 cause for 1), but the error checking (rather lack of it) of calls
455 to erealpath() in canonicalize() was the prime reason for 1).
456
457 As we do not use this canonicalized name to call the function, we resolve this
458 by fixing canonicalize() to do better error checking, and ecanonicalize() as
459 well as all functions in libsandbox.c to use a PATH_MAX of 'PATH_MAX * 2'.
460 While they will resolve paths properly now, and can check if a write/read is
461 allowed, the functions called from the sandboxed environment will still work
462 as expected.
463
464 This should resolve bug #21766.
465
466 06 Apr 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
467 For some reason sandbox fails with a 'open_wr' if you run 'locale -a' under
468 it (bug #16298).
469
470 Problem is that for some reason locale fopen's locale.alias with mode "rm".
471
472 -------------------------------------------------------
473 nosferatu root # grep fopen locale.log
474 fopen("/usr/share/locale/locale.alias", "rm"ACCESS DENIED open_wr: /usr/share/locale/locale.alias
475 nosferatu root #
476 --------------------------------------------------------
477
478 I checked the source of locale, but it have fopen with mode 'r', so
479 not sure where the "rm" mode comes from. Anyhow, changed the check in
480 before_syscall_open_char() to also see mode "rm" as readonly.
481
482 23 Feb 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
483
484 Add glibc-2.3 support.
485
486 22 Feb 2003; Martin Schlemmer <azarah@gentoo.org> sandbox.c :
487
488 Some /etc/ld.so.preload fixes. Just changed the #if defines to cover all
489 operations releated to preload, as well as only try to modify ld.so.preload
490 if we can. Also modify to write the pid to /tmp/sandboxpids.tmp even when
491 not using ld.so.preload. Fix to not write this instance of sandbox's pid
492 to /tmp/sandboxpids.tmp on exit if this is not the last sandbox running.
493
494 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> Makefile :
495
496 Changed the LD to CC for hppa.
497
498 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
499
500 Killed the previous changes I made.
501
502 17 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
503
504 Added parisc to BROKEN_RTLD_ARCHLIST to see if it we can fix the relocation probs.
505
506 09 Jan 2003; J Robert Ray <jrray@gentoo.org> sandbox.c :
507
508 Don't segfault if $HOME isn't set, set $HOME to "/" instead. Fixes bug 10868.
509
510 16 Dec 2002; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
511
512 Fix memory leak for mips, bug #12236. Thanks to Torgeir Hansen <torgeir@trenger.ro>
513 for this fix.
514
515 4 Dec 2002; J Robert Ray <jrray@gentoo.org> sandbox.h sandbox_futils.c :
516
517 sandbox_futils defined a dirname() function that was masking the same
518 function in glibc and was broken (e.g.: SANDBOX_DIR was being set to
519 '/usr/lib/portage/bi/'). Fixed function to return expected results and
520 renamed it to sb_dirname() to no longer mask the glibc function. Closes bug
521 11231.
522
523 4 Dec 2002; Martin Schlemmer <azarah@gentoo.org> :
524
525 Fix a segfault in libsandbox.c if canonicalize() was called with
526 first parameter = NULL.
527
528 1 Sep 2002; Martin Schlemmer <azarah@gentoo.org> :
529
530 Fix my braindead 'return 1;' in a void function. Updated sandbox.c,
531 cleanup() for this.
532
533 Change cleanup() in sandbox.c not to exit with fail status if
534 the pidsfile is missing. We really should still display sandbox
535 violations if they occured.
536
537 31 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
538
539 Update cleanup() in sandbox.c to remove the PIDSFILE if this is
540 the last sandbox running.
541
542 25 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
543
544 Major cleanups to mainly libsandbox.c again.
545
546 22 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
547
548 Add copyrights to sandbox.h and sandbox_futils.h. If wrong, the
549 parties involved should please contact me so that we can fix it.
550
551 Add opendir wrapper to libsandbox.c.
552
553 21 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
554
555 Do some more cleanups to ecanonicalize(), as it dropped filenames in
556 rare cases (after my symlink cleanups), and caused glibc to bork.
557 These fixes went into canonicalize.c.
558
559 20 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
560
561 Fix spawn_shell() and main() in sandbox.c to properly return fail
562 status.
563
564 19 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
565
566 The new canonicalize() function in libsandbox.c also resolved symlinks,
567 which caused on cleaning sandbox errors if the symlink pointed to a
568 file in the live root. Ripped out canonicalize() and realpath() from
569 glibc; removed the symlink stuff, and changed them to ecanonicalize()
570 and erealpath().
571
572 18 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
573
574 Ripped out all the wrappers, and implemented those of InstallWatch.
575 Losts of cleanups and bugfixes. Implement a execve that forces
576 $LIBSANDBOX in $LD_PRELOAD. We can now thus do away with the feared
577 /etc/ld.so.preload (*g*) ... Made the needed changes to sandbox.c,
578 sandbox.h and sandbox_futils.c. Rewrote the Makefile for most
579 parts; it now have an install target.
580
581 Reformat the whole thing to look somewhat like the reworked sandbox.c
582 and new sandbox.h and sandbox_futils.c from:
583
584 Brad House <brad@mainstreetsoftworks.com>.
585
586 Additional Copyrights now due to the InstallWatch code:
587
588 Copyright (C) 1998-9 Pancrazio `Ezio' de Mauro <p@demauro.net>

Properties

Name Value
svn:eol-style native
svn:keywords Author Date Id Revision

  ViewVC Help
Powered by ViewVC 1.1.20