/[path-sandbox]/trunk/ChangeLog.0
Gentoo

Contents of /trunk/ChangeLog.0

Parent Directory Parent Directory | Revision Log Revision Log


Revision 148 - (show annotations) (download)
Thu Jul 14 11:06:38 2005 UTC (9 years, 1 month ago) by azarah
Original Path: trunk/ChangeLog
File size: 27110 byte(s)
Fix getcwd, bug #98419.
1 # ChangeLog for Path Sandbox
2 # Copyright 1999-2005 Gentoo Foundation; Distributed under the GPL v2
3 # $Header$
4
5 14 July 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c:
6 Fix getcwd, bug #98419.
7
8 08 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c,
9 libsandbox.c:
10 - Try to cleanup and make error handling/printing consistent.
11 - Remove old logs if present and conflicting with current.
12 - Fix compile error with previous change, and return rather then exit().
13
14 07 July 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
15 sandbox.h, sandbox_futils.c:
16 - Fix possible segfault in env init code.
17 - Major cleanup of sandbox_futils.c. Removed most of the functions as we now
18 write to /var/log/sandbox/, so in theory do not need all that.
19 - Redo the interface of the get_* functions so that we do not leak memory.
20 - Remove sandbox_dir and co - we are not using it anymore.
21 - Remove unused includes and variables.
22 - Only declare functions in sandbox_futils.c that are used in libsandbox.c when
23 OUTSIDE_LIBSANDBOX is not defined.
24 - Cleanup access/log printing. Make access printing honour NOCOLOR. Fix log
25 printing's last line not honouring NOCOLOR.
26
27 06 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.h, sandbox_futils.c,
28 libsandbox.c:
29 - Change log dir to /var/log/sandbox/. Make sure the sandboxed process cannot
30 write to it.
31 - Clean up logging in libsandbox.c, and hopefully make it more consistant.
32 - Add check_prefixes() with major cleanup on check_access().
33 - Cleanup init_env_entries() and check_prefixes().
34
35 05 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
36 sandbox_futils.c, libsandbox.c:
37 Remove unused 'pids file' code.
38
39 * sandbox-1.2.10 (2005/07/03)
40
41 03 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
42 Add PREDICT items for nss-db, bug #92079. Patch from Robin Johnson.
43
44 17 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
45 General cleanups:
46 - Remove fooling around with exit codes - we error out on presence of a log
47 anyhow.
48 - Move get_sandbox_*_envvar() to sandbox_setup_environ(), as its more
49 appropriate there.
50
51 12 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
52 Cleanup the fail_nametoolong stuff a bit more.
53
54 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
55 Remove hopefully the last ld.so.preload bits we do not use anymore.
56
57 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
58 Remove the unneeded canonicalize() calls in the wrappers - we do it anyhow
59 in check_syscall(). Should speed things up a bit (at least for the getcwd()
60 and long path name test it goes down to under a second, and not 10+ seconds
61 like before). Also warn if we skip checking due to the canonicalized path
62 being too long.
63
64 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
65 More comment/readability cleanups.
66
67 10 June 2005; Martin Schlemmer <azarah@gentoo.org> canonicalize.c, getcwd.c,
68 sandbox_futils.c, libsandbox.c:
69 Some strncpy/strncat and other cleanups.
70
71 * sandbox-1.2.9 (2005/06/09)
72
73 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
74 Move symlink hack down a bit to try and minimize on the amount of lstat()
75 calls we do.
76
77 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
78 Add hack to allow writing to /proc/self/fd (or /dev/fd), bug #91516.
79
80 09 June 2005; Martin Schlemmer <azarah@gentoo.org> symbols.in, libsandbox.c:
81 Add wrapper for access() function, bug #85413.
82
83 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c:
84 Use generic getcwd() implementation from uclibc - should be more portable
85 and looks a bit cleaner.
86
87 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c:
88 Make sure our true_* pointers are initialized to NULL, and that we check for
89 all references that they are valid.
90
91 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
92 Be default we will fail if the path name we try to canonicalize is too long.
93 This however could cause issues with some things (bug #94630 and #21766), so
94 if fail_nametoolong == 0, canonicalize() will return a null length string and
95 do not fail.
96
97 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c:
98 Do not abort if TMPDIR is not valid, but rather use '/tmp', bug #94360. Also
99 make sure we re-export the new TMPDIR environment variable.
100
101 08 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
102 Fix incorrect free of non-malloc'd array, bug #92313 and #94020. Fix noted
103 by Marcus D. Hanwell <cryos@gentoo.org>.
104
105 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
106 Add /dev/console to write list, bug #38588.
107
108 * sandbox-1.2.8 (2005/05/13)
109
110 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
111 sandbox.h, sandbox_futils.c:
112 General cleanups.
113
114 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
115 sandbox.h:
116 Various LD_PRELOAD cleanups. Do not unset LD_PRELOAD for parent.
117
118 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
119 sandbox.h, sandbox_futils.c:
120 Modify get_sandbox_pids_file(), get_sandbox_log() and get_sandbox_debug_log()
121 to use TMPDIR if present in environment.
122
123 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
124 Remove sandbox_log_file from main() as its no longer used.
125
126 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
127 sandbox_futils.c:
128 Add get_sandbox_debug_log(), and use it (add behaviour similar to SANDBOX_LOG
129 if already exported when sandbox started). Fix get_sandbox_log() and new
130 get_sandbox_debug_log() to not use already exported environment variables if
131 they have '/' in them. Use snprintf()'s instead of strncpy()'s. More
132 SB_PATH_MAX fixes.
133
134 * sandbox-1.2.7 (2005/05/12)
135
136 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
137 sandbox_futils.c:
138 More path limit fixes. Declare SB_BUF_LEN global and use it where needed.
139
140 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
141 Fix paths limited to 255 chars. Fix get_sandbox_dir() returning a string
142 with '(null)' in it if we did not call sandbox with absolute path.
143
144 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
145 Set SANDBOX_ON *before* doing the child's env stuff, else its not set
146 for the child.
147
148 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
149 Remove global preload_adaptable as it is no longer used.
150
151 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
152 Rewrite environment stuff to only be set when execve'ing the child process
153 to try and avoid issues like bug #91541 that causes sandbox to crash if
154 we set LD_PRELOAD sandbox side already.
155
156 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
157 Move print_sandbox_log() up to make things neater.
158
159 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
160 Remove load_preload_libs(), as its not used anymore.
161
162 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
163 Remove NO_FORK stuff, as its not used, and 'strace -f' works just fine.
164
165 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
166 Remove USE_SYSTEM_SHELL stuff, as it is not secure, and not in use.
167
168 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
169 Remove ld.so.preload crap - we are not going to use it again.
170
171 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
172 Fix typo in code that checks if we got valid group information, causing a
173 segmentation fault, bug #91637.
174
175 * sandbox-1.2.6 (2005/05/10)
176
177 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
178 Do not use LD_PRELOAD if it contains libtsocks.so, as it breaks sandbox
179 for some odd reason, bug #91541.
180
181 09 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
182 Fix typo (sizeof -> strlen).
183
184 08 May 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
185 rewrote the sbcontext caching code so it accounts for env changes since lib
186 initialization.
187
188 05 May 2005; Martin Schlemmer <azarah@gentoo.org> configure.in, libctest.c:
189 We create libctest.c via configure, so no need to keep it around. Do some
190 cleanup related to libctest.c and libctest during configure.
191
192 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
193 Add rename support of symlinks pointing to protected files/directories.
194
195 * sandbox-1.2.5 (2005/05/04)
196
197 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
198 sandbox.bashrc:
199 Do not reset already set LD_PRELOAD when starting sandbox. If LD_PRELOAD is
200 already set, init of the env vars fails for some reason, so do this later on,
201 and do not warn (bug #91431).
202
203 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
204 sandbox.bashrc:
205 Fixup sandbox and sandbox.bashrc to call bash with the proper .bashrc.
206
207 * sandbox-1.2.4 (2005/05/03)
208
209 03 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
210 Do not init the env entries with each call, as it creates too many calls to
211 lstat, etc. Should speedup things a bit, bug #91040.
212
213 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
214 Add /dev/pty to default write list. Noticed by Morfic.
215
216 02 May 2005; Mike Frysinger <vapier@gentoo.org> configure.in, localdecls.h,
217 sandbox.h:
218 uClibc doesn't support dlvsym() so add a configure check to make sure it doesn't
219 exist. Also update localdecls.h so BROKEN_RTLD_NEXT isn't defined in uClibc.
220
221 * sandbox-1.2.3 (2005/04/29)
222
223 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> configure.in:
224 Do not check for (*&#$(* CXX or F77.
225
226 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
227 Do not append '/' to pathname in filter_path() if it already ends with it.
228
229 28 Apr 2005; Mike Frysinger <vapier@gentoo.org> Makefile.am, configure.in:
230 With az's help, clean up autotools to work with cross-compiling.
231
232 * sandbox-1.2.2 (2005/04/28)
233
234 28 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
235 Only check for /dev/{null,zero} for unlink hack, else ricers using /dev/shm
236 have issues; bug #90592.
237
238 * sandbox-1.2.1 (2005/04/23)
239
240 23 Apr 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
241 getcwd.c, libsandbox.c, localdecls.h, sandbox.h, sandbox_futils.c:
242 Make sure all functions used in libsandbox.c is declared static. Define
243 SB_STATIC in localdecls.h for this. Include sandbox_futils.c rather than
244 linking with its object. Hopefully this will fix bug #90153.
245
246 * sandbox-1.2 (2005/04/23)
247
248 22 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
249 Allow lchown a symlink in write-allowed path pointing to write-denied
250 target.
251
252 21 Mar 2005; Marius Mauch <genone@gentoo.org> libsandbox.c:
253 Also show resolved symlink names in the log.
254
255 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, libsandbox.c:
256 Seems -nostdlib was the problem with the constructor/destructor - remove it
257 from Makefile.am, and change the constructor/destructor names again.
258
259 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
260 Also rename the _init() and _fini() declarations.
261
262 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
263 Fixup the constructor/destructor function names again (they should be _init()
264 and _fini() it seems, and not being called caused sandbox_lib_path to be
265 unset, and thus breaking the execve() wrapper's LD_PRELOAD protection).
266 Add both the path in given SANDBOX_x variable, as well as its symlink
267 resolved path in init_env_entries(). Modify filter_path() to be able to
268 resolve paths without resolving symlinks, as well as to be able to resolve
269 symlinks. Fix a possible segfault in check_access(). Add symlink resolving
270 to check_access() resolving bug #31019. Add 'hack' for unlink, as the fix
271 for bug #31019 cause access violations if we try to remove a symlink that is
272 not in protected path, but points to a protected path. Fix a memory leak in
273 sandbox.c (sandbox_pids_file in main()). Fix the realpath() calls in main()
274 (sandbox.c) being unchecked. Fix the debug logname not having the pid in it
275 (pid_string was uninitialized). General syntax cleanups.
276
277 09 Mar 2005; Brian Harring <ferringb@gentoo.org> sandbox.c: Fixed the
278 infamous "pids file is not a regular file" w/out newline bug.
279
280 09 Mar 2005; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in:
281 Correct libc_version path detection, since it was screwing up if libdir !=
282 "/lib/".
283
284 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
285 Hack to make sure sandboxed process cannot remove a device node, bug #79836.
286
287 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am:
288 Fix symbols.in not added to dist.
289
290 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
291 getcwd.c, libsandbox.c, sandbox.c, sandbox.h, sandbox_futils.c:
292 White space fixes.
293
294 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
295 configure.in, getcwd.c, libsandbox.c, symbols.in:
296 Fix inverse test logic in canonicalize.c, use a strncpy. Fix gcc warning in
297 getcwd.c. Add symbols.in and logic to Makefile.am to generate symbol versions
298 for glibc and other libc's that use this. Update libsandbox.c to use these
299 symbol versions if available. Fix exec wrapper to re-export LD_PRELOAD if the
300 process unset it.
301
302 01 Mar 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
303 killed off _init and _fini in favor of
304 void __attribute__ ((constructor)) init_func and
305 void __attribute__ ((destructor)) closing_func. _(init|func) were deprecated.
306
307 06 Dec 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, libsandbox.c,
308 canonicalize.c, getcwd.c: Fixed compilation *again*. Hopefully cvs is done
309 having the hick-ups.
310
311 04 Dec 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, getcwd.c,
312 Makefile.am: Fixed compilation.
313
314 01 Dec 2004; Brian Harring <ferringb@gentoo.org> aclocal.m4:
315 Gutted the bugger so it stops checking for a c++ and fortran compiler.
316 Do *not* regenerate aclocal.m4 for making a release until a better
317 solution is created.
318
319 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, sandbox_futils.c:
320 Removal of more hardcoded paths.
321
322 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in,
323 sandbox_futils.c: tweaks to install sandbox.bashrc, and use it.
324
325 19 Nov 2004; Brian Harring <ferringb@gentoo.org>:
326 Sandbox is now autotooled, create-localdecls needs to be killed and the code
327 shifted into configure.in. Currently builds *one* libsandbox.so- if multiple
328 are desired (-m64 and -m32 for amd64), the ebuild should do it (imo).
329 To get to a point of testing, automake && autoconf; created requisite files w/
330 a(utomake|clocal)-1.8, and autoconf 2.59. Installs to /usr/, instead of
331 /lib and /usr/lib/portage/bin.
332
333 14 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox.c:
334 closing out bug #70225, potential overflow of the sandbox_pids_file var.
335
336 07 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c: c99 standard,
337 (think it was at least) allows intermixing of code and data segments. bug #70351
338 should be fixed by this.
339
340 03 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox_futils.c:
341 futils fix from bug #65201 via solar, and libsandbox log path checks via #69137
342
343 02 Aug 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Code from
344 Seth Robertson that tracked down all adjuct flags for read operations that
345 do not invoke a write operation.
346
347 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
348 Another fix from jstubbs regarding a free() on a stack variable for the
349 environment -- tracking now prevents extraneous free()'s segfault.
350
351 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
352 J. Stubbs tracked down a new bug where mkdir was failing to the patch on
353 the lstat in mkdir... it now only returns 0 or -1 as documented for mkdir.
354 Also remove the errno = ESUCCESS settings as documentation points out that
355 a library isn't allowed to do that.
356
357 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Added a
358 file_security_check() function to check random potential exploits on files
359 that sandbox is to load and read -- Normally sandboxpids.tmp. This fixes
360 the 'system-crippling' exploits (bug 21923) and catches a few other
361 potential problems.
362
363 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> Makefile: Updates for
364 32/64 bit sandbox. Made CC and LD '?=' values to allow passed in CC to work.
365
366 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c:
367 bug 42048 -- Fixed the lstat/errno conditions for mkdir <caleb@g.o>.
368 Added the 64/32 bit sandbox patch for AMD64 bug 32963 <brad/azarah>.
369
370 29 Feb 2004; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c :
371 Fix permissions and group of pids file and logs. Permissions should be 0664
372 and group should be 'portage'. Bug #34260.
373
374 28 Feb 2004; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
375 Besides a small cleanup, redo how we replace LD_PRELOAD in the environ passed
376 to the real execve (in our execve wrapper). Seems that on some arches (sparc
377 among others) do not allow us to tamper with the readonly copy passed to
378 execve, so pass our own copy of the environment. Bug #42290.
379
380 11 Jan 2004; Nicholas Jones <carpaski@gentoo.org> create-decls:
381 Changed tail to head and added a notice about duration of glibc check.
382
383 21 Dec 2003; Nicholas Jones <carpaski@gentoo.org> create-decls:
384 Changed the glibc subversion check to use /usr/bin/* instead of /bin/sh
385 as there isn't a guarentee that it is dynamic.
386
387 02 Nov 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
388 If 'file' passed to before_syscall(const char *func, const char *file) is
389 invalid, we should set errno to ENOENT, and not EINVAL. This should
390 close bug #32238.
391
392 14 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
393 Fix a bug that occurs mainly on 64bit arch, where the file passed to
394 the functions we wrap, is invalid, and then cause canonicalize to pass
395 garbage to before_syscall(), thanks to great detective work from
396 Andrea Luzzardi <al@sig11.org> (bug #29846).
397
398 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
399 Add a uClibc detection patch from Peter S. Mazinger <ps.m@gmx.net>.
400
401 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
402 Fix a bug in libsandbox.c 's checking in the rename wrapper - it basically
403 only checked the destination patch, and not the source, so we could move
404 a protected file to a unprotected directory, and then delete/modify it.
405 Thanks to Andrea Luzzardi (scox) <al@sig11.org>, bug #30992, for this fix.
406
407 12 Oct 2003; Nicholas Jones <carpaski@gentoo.org> sandbox.c :
408 Added python2.3 to the predict section/variable.
409
410 28 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
411 sandbox.h, sandbox_futils.c :
412 Add support to set the pids file via SANDBOX_PIDS_FILE at startup. If
413 it is not set, it will revert to its old value.
414
415 27 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
416 Fix our mkdir wrapper to check if the dir exist, and return EEXIST if so,
417 rather than failing with a violation, bug #29748.
418
419 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
420 Fix canonicalize() to ignore calls with path = "".
421
422 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c,
423 sandbox_futils.c, canonicalize.c :
424 Once again coreutils fails, as my systems had 2.5 kernel, the getcwd system
425 call handled strings larger than PATH_MAX (bug #21766). It however does not
426 work the same on 2.4 kernels.
427
428 To fix, I added the posix implementation of getcwd() (from glibc cvs) that
429 do not need the system call. We use the default getcwd() function via a
430 wrapper (egetcwd), and then lstat the returned path. If lstat fails, it
431 means the current directory was removed, OR that the the system call for
432 getcwd failed (curious is that it do not fail and return NULL or set
433 errno, but rather just truncate the retured directory - usually from the
434 start), and if so, we use the generic getcwd() function (__egetcwd). Note
435 that we do not use the generic version all the time, as it calls lstat()
436 a great number of times, and performance degrade much.
437
438 29 Jun 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls,
439 libsandbox.c :
440 Make sure SB_PATH_MAX will not wrap. Fix two possible memory leaks.
441
442 22 Jun 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, canonicalize.c
443 create-localdecls :
444 When checking path names of files accessed, we need to canonicalize it, else
445 it may be a symlink in a 'write allowed' directory pointing to a file in a
446 directory we should not have write access to.
447
448 With something like coreutils-5.0, we have two problems:
449 1) One of the tests checks if getcwd() can return a path longer than
450 PATH_MAX. This test then tries to create a dir which even while
451 created local (mkdir("conftest2")), it ends up being resolved with
452 a name that is much larger than PATH_MAX. The problem now is that
453 canonicalize() have undefined behaviour when the path was too long
454 (returned wrongly truncated paths, etc), and pass the wrong path to
455 before_syscall() (causing the bogus sandbox violations).
456 2) The ecanonicalize() function we used, along with the canonicalize()
457 function did not support longer than PATH_MAX. This is partly a
458 cause for 1), but the error checking (rather lack of it) of calls
459 to erealpath() in canonicalize() was the prime reason for 1).
460
461 As we do not use this canonicalized name to call the function, we resolve this
462 by fixing canonicalize() to do better error checking, and ecanonicalize() as
463 well as all functions in libsandbox.c to use a PATH_MAX of 'PATH_MAX * 2'.
464 While they will resolve paths properly now, and can check if a write/read is
465 allowed, the functions called from the sandboxed environment will still work
466 as expected.
467
468 This should resolve bug #21766.
469
470 06 Apr 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
471 For some reason sandbox fails with a 'open_wr' if you run 'locale -a' under
472 it (bug #16298).
473
474 Problem is that for some reason locale fopen's locale.alias with mode "rm".
475
476 -------------------------------------------------------
477 nosferatu root # grep fopen locale.log
478 fopen("/usr/share/locale/locale.alias", "rm"ACCESS DENIED open_wr: /usr/share/locale/locale.alias
479 nosferatu root #
480 --------------------------------------------------------
481
482 I checked the source of locale, but it have fopen with mode 'r', so
483 not sure where the "rm" mode comes from. Anyhow, changed the check in
484 before_syscall_open_char() to also see mode "rm" as readonly.
485
486 23 Feb 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
487
488 Add glibc-2.3 support.
489
490 22 Feb 2003; Martin Schlemmer <azarah@gentoo.org> sandbox.c :
491
492 Some /etc/ld.so.preload fixes. Just changed the #if defines to cover all
493 operations releated to preload, as well as only try to modify ld.so.preload
494 if we can. Also modify to write the pid to /tmp/sandboxpids.tmp even when
495 not using ld.so.preload. Fix to not write this instance of sandbox's pid
496 to /tmp/sandboxpids.tmp on exit if this is not the last sandbox running.
497
498 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> Makefile :
499
500 Changed the LD to CC for hppa.
501
502 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
503
504 Killed the previous changes I made.
505
506 17 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
507
508 Added parisc to BROKEN_RTLD_ARCHLIST to see if it we can fix the relocation probs.
509
510 09 Jan 2003; J Robert Ray <jrray@gentoo.org> sandbox.c :
511
512 Don't segfault if $HOME isn't set, set $HOME to "/" instead. Fixes bug 10868.
513
514 16 Dec 2002; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
515
516 Fix memory leak for mips, bug #12236. Thanks to Torgeir Hansen <torgeir@trenger.ro>
517 for this fix.
518
519 4 Dec 2002; J Robert Ray <jrray@gentoo.org> sandbox.h sandbox_futils.c :
520
521 sandbox_futils defined a dirname() function that was masking the same
522 function in glibc and was broken (e.g.: SANDBOX_DIR was being set to
523 '/usr/lib/portage/bi/'). Fixed function to return expected results and
524 renamed it to sb_dirname() to no longer mask the glibc function. Closes bug
525 11231.
526
527 4 Dec 2002; Martin Schlemmer <azarah@gentoo.org> :
528
529 Fix a segfault in libsandbox.c if canonicalize() was called with
530 first parameter = NULL.
531
532 1 Sep 2002; Martin Schlemmer <azarah@gentoo.org> :
533
534 Fix my braindead 'return 1;' in a void function. Updated sandbox.c,
535 cleanup() for this.
536
537 Change cleanup() in sandbox.c not to exit with fail status if
538 the pidsfile is missing. We really should still display sandbox
539 violations if they occured.
540
541 31 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
542
543 Update cleanup() in sandbox.c to remove the PIDSFILE if this is
544 the last sandbox running.
545
546 25 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
547
548 Major cleanups to mainly libsandbox.c again.
549
550 22 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
551
552 Add copyrights to sandbox.h and sandbox_futils.h. If wrong, the
553 parties involved should please contact me so that we can fix it.
554
555 Add opendir wrapper to libsandbox.c.
556
557 21 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
558
559 Do some more cleanups to ecanonicalize(), as it dropped filenames in
560 rare cases (after my symlink cleanups), and caused glibc to bork.
561 These fixes went into canonicalize.c.
562
563 20 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
564
565 Fix spawn_shell() and main() in sandbox.c to properly return fail
566 status.
567
568 19 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
569
570 The new canonicalize() function in libsandbox.c also resolved symlinks,
571 which caused on cleaning sandbox errors if the symlink pointed to a
572 file in the live root. Ripped out canonicalize() and realpath() from
573 glibc; removed the symlink stuff, and changed them to ecanonicalize()
574 and erealpath().
575
576 18 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
577
578 Ripped out all the wrappers, and implemented those of InstallWatch.
579 Losts of cleanups and bugfixes. Implement a execve that forces
580 $LIBSANDBOX in $LD_PRELOAD. We can now thus do away with the feared
581 /etc/ld.so.preload (*g*) ... Made the needed changes to sandbox.c,
582 sandbox.h and sandbox_futils.c. Rewrote the Makefile for most
583 parts; it now have an install target.
584
585 Reformat the whole thing to look somewhat like the reworked sandbox.c
586 and new sandbox.h and sandbox_futils.c from:
587
588 Brad House <brad@mainstreetsoftworks.com>.
589
590 Additional Copyrights now due to the InstallWatch code:
591
592 Copyright (C) 1998-9 Pancrazio `Ezio' de Mauro <p@demauro.net>

Properties

Name Value
svn:eol-style native
svn:keywords Author Date Id Revision

  ViewVC Help
Powered by ViewVC 1.1.20