/[path-sandbox]/trunk/ChangeLog.0
Gentoo

Contents of /trunk/ChangeLog.0

Parent Directory Parent Directory | Revision Log Revision Log


Revision 152 - (show annotations) (download)
Wed Jul 27 18:04:35 2005 UTC (9 years, 4 months ago) by azarah
Original Path: trunk/ChangeLog
File size: 27485 byte(s)
Do not resolve symlinks in PORTAGE_TMPDIR in sandbox .. we will handle that
in libsandbox .. bug #100309.

1 # ChangeLog for Path Sandbox
2 # Copyright 1999-2005 Gentoo Foundation; Distributed under the GPL v2
3 # $Header$
4
5 27 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
6 sandbox_futils.c:
7
8 Do not resolve symlinks in PORTAGE_TMPDIR in sandbox .. we will handle that
9 in libsandbox .. bug #100309.
10
11 22 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.h:
12
13 Print all logging to stderr, bug #90343, comment #15, by Zac Medico.
14
15 * sandbox-1.2.11 (2005/07/14)
16
17 14 July 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c:
18 Fix getcwd, bug #98419.
19
20 08 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c,
21 libsandbox.c:
22 - Try to cleanup and make error handling/printing consistent.
23 - Remove old logs if present and conflicting with current.
24 - Fix compile error with previous change, and return rather then exit().
25
26 07 July 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
27 sandbox.h, sandbox_futils.c:
28 - Fix possible segfault in env init code.
29 - Major cleanup of sandbox_futils.c. Removed most of the functions as we now
30 write to /var/log/sandbox/, so in theory do not need all that.
31 - Redo the interface of the get_* functions so that we do not leak memory.
32 - Remove sandbox_dir and co - we are not using it anymore.
33 - Remove unused includes and variables.
34 - Only declare functions in sandbox_futils.c that are used in libsandbox.c when
35 OUTSIDE_LIBSANDBOX is not defined.
36 - Cleanup access/log printing. Make access printing honour NOCOLOR. Fix log
37 printing's last line not honouring NOCOLOR.
38
39 06 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.h, sandbox_futils.c,
40 libsandbox.c:
41 - Change log dir to /var/log/sandbox/. Make sure the sandboxed process cannot
42 write to it.
43 - Clean up logging in libsandbox.c, and hopefully make it more consistant.
44 - Add check_prefixes() with major cleanup on check_access().
45 - Cleanup init_env_entries() and check_prefixes().
46
47 05 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
48 sandbox_futils.c, libsandbox.c:
49 Remove unused 'pids file' code.
50
51 * sandbox-1.2.10 (2005/07/03)
52
53 03 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
54 Add PREDICT items for nss-db, bug #92079. Patch from Robin Johnson.
55
56 17 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
57 General cleanups:
58 - Remove fooling around with exit codes - we error out on presence of a log
59 anyhow.
60 - Move get_sandbox_*_envvar() to sandbox_setup_environ(), as its more
61 appropriate there.
62
63 12 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
64 Cleanup the fail_nametoolong stuff a bit more.
65
66 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
67 Remove hopefully the last ld.so.preload bits we do not use anymore.
68
69 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
70 Remove the unneeded canonicalize() calls in the wrappers - we do it anyhow
71 in check_syscall(). Should speed things up a bit (at least for the getcwd()
72 and long path name test it goes down to under a second, and not 10+ seconds
73 like before). Also warn if we skip checking due to the canonicalized path
74 being too long.
75
76 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
77 More comment/readability cleanups.
78
79 10 June 2005; Martin Schlemmer <azarah@gentoo.org> canonicalize.c, getcwd.c,
80 sandbox_futils.c, libsandbox.c:
81 Some strncpy/strncat and other cleanups.
82
83 * sandbox-1.2.9 (2005/06/09)
84
85 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
86 Move symlink hack down a bit to try and minimize on the amount of lstat()
87 calls we do.
88
89 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
90 Add hack to allow writing to /proc/self/fd (or /dev/fd), bug #91516.
91
92 09 June 2005; Martin Schlemmer <azarah@gentoo.org> symbols.in, libsandbox.c:
93 Add wrapper for access() function, bug #85413.
94
95 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c:
96 Use generic getcwd() implementation from uclibc - should be more portable
97 and looks a bit cleaner.
98
99 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c:
100 Make sure our true_* pointers are initialized to NULL, and that we check for
101 all references that they are valid.
102
103 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
104 Be default we will fail if the path name we try to canonicalize is too long.
105 This however could cause issues with some things (bug #94630 and #21766), so
106 if fail_nametoolong == 0, canonicalize() will return a null length string and
107 do not fail.
108
109 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c:
110 Do not abort if TMPDIR is not valid, but rather use '/tmp', bug #94360. Also
111 make sure we re-export the new TMPDIR environment variable.
112
113 08 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
114 Fix incorrect free of non-malloc'd array, bug #92313 and #94020. Fix noted
115 by Marcus D. Hanwell <cryos@gentoo.org>.
116
117 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
118 Add /dev/console to write list, bug #38588.
119
120 * sandbox-1.2.8 (2005/05/13)
121
122 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
123 sandbox.h, sandbox_futils.c:
124 General cleanups.
125
126 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
127 sandbox.h:
128 Various LD_PRELOAD cleanups. Do not unset LD_PRELOAD for parent.
129
130 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
131 sandbox.h, sandbox_futils.c:
132 Modify get_sandbox_pids_file(), get_sandbox_log() and get_sandbox_debug_log()
133 to use TMPDIR if present in environment.
134
135 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
136 Remove sandbox_log_file from main() as its no longer used.
137
138 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
139 sandbox_futils.c:
140 Add get_sandbox_debug_log(), and use it (add behaviour similar to SANDBOX_LOG
141 if already exported when sandbox started). Fix get_sandbox_log() and new
142 get_sandbox_debug_log() to not use already exported environment variables if
143 they have '/' in them. Use snprintf()'s instead of strncpy()'s. More
144 SB_PATH_MAX fixes.
145
146 * sandbox-1.2.7 (2005/05/12)
147
148 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
149 sandbox_futils.c:
150 More path limit fixes. Declare SB_BUF_LEN global and use it where needed.
151
152 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
153 Fix paths limited to 255 chars. Fix get_sandbox_dir() returning a string
154 with '(null)' in it if we did not call sandbox with absolute path.
155
156 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
157 Set SANDBOX_ON *before* doing the child's env stuff, else its not set
158 for the child.
159
160 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
161 Remove global preload_adaptable as it is no longer used.
162
163 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
164 Rewrite environment stuff to only be set when execve'ing the child process
165 to try and avoid issues like bug #91541 that causes sandbox to crash if
166 we set LD_PRELOAD sandbox side already.
167
168 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
169 Move print_sandbox_log() up to make things neater.
170
171 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
172 Remove load_preload_libs(), as its not used anymore.
173
174 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
175 Remove NO_FORK stuff, as its not used, and 'strace -f' works just fine.
176
177 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
178 Remove USE_SYSTEM_SHELL stuff, as it is not secure, and not in use.
179
180 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
181 Remove ld.so.preload crap - we are not going to use it again.
182
183 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
184 Fix typo in code that checks if we got valid group information, causing a
185 segmentation fault, bug #91637.
186
187 * sandbox-1.2.6 (2005/05/10)
188
189 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
190 Do not use LD_PRELOAD if it contains libtsocks.so, as it breaks sandbox
191 for some odd reason, bug #91541.
192
193 09 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
194 Fix typo (sizeof -> strlen).
195
196 08 May 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
197 rewrote the sbcontext caching code so it accounts for env changes since lib
198 initialization.
199
200 05 May 2005; Martin Schlemmer <azarah@gentoo.org> configure.in, libctest.c:
201 We create libctest.c via configure, so no need to keep it around. Do some
202 cleanup related to libctest.c and libctest during configure.
203
204 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
205 Add rename support of symlinks pointing to protected files/directories.
206
207 * sandbox-1.2.5 (2005/05/04)
208
209 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
210 sandbox.bashrc:
211 Do not reset already set LD_PRELOAD when starting sandbox. If LD_PRELOAD is
212 already set, init of the env vars fails for some reason, so do this later on,
213 and do not warn (bug #91431).
214
215 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
216 sandbox.bashrc:
217 Fixup sandbox and sandbox.bashrc to call bash with the proper .bashrc.
218
219 * sandbox-1.2.4 (2005/05/03)
220
221 03 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
222 Do not init the env entries with each call, as it creates too many calls to
223 lstat, etc. Should speedup things a bit, bug #91040.
224
225 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
226 Add /dev/pty to default write list. Noticed by Morfic.
227
228 02 May 2005; Mike Frysinger <vapier@gentoo.org> configure.in, localdecls.h,
229 sandbox.h:
230 uClibc doesn't support dlvsym() so add a configure check to make sure it doesn't
231 exist. Also update localdecls.h so BROKEN_RTLD_NEXT isn't defined in uClibc.
232
233 * sandbox-1.2.3 (2005/04/29)
234
235 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> configure.in:
236 Do not check for (*&#$(* CXX or F77.
237
238 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
239 Do not append '/' to pathname in filter_path() if it already ends with it.
240
241 28 Apr 2005; Mike Frysinger <vapier@gentoo.org> Makefile.am, configure.in:
242 With az's help, clean up autotools to work with cross-compiling.
243
244 * sandbox-1.2.2 (2005/04/28)
245
246 28 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
247 Only check for /dev/{null,zero} for unlink hack, else ricers using /dev/shm
248 have issues; bug #90592.
249
250 * sandbox-1.2.1 (2005/04/23)
251
252 23 Apr 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
253 getcwd.c, libsandbox.c, localdecls.h, sandbox.h, sandbox_futils.c:
254 Make sure all functions used in libsandbox.c is declared static. Define
255 SB_STATIC in localdecls.h for this. Include sandbox_futils.c rather than
256 linking with its object. Hopefully this will fix bug #90153.
257
258 * sandbox-1.2 (2005/04/23)
259
260 22 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
261 Allow lchown a symlink in write-allowed path pointing to write-denied
262 target.
263
264 21 Mar 2005; Marius Mauch <genone@gentoo.org> libsandbox.c:
265 Also show resolved symlink names in the log.
266
267 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, libsandbox.c:
268 Seems -nostdlib was the problem with the constructor/destructor - remove it
269 from Makefile.am, and change the constructor/destructor names again.
270
271 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
272 Also rename the _init() and _fini() declarations.
273
274 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
275 Fixup the constructor/destructor function names again (they should be _init()
276 and _fini() it seems, and not being called caused sandbox_lib_path to be
277 unset, and thus breaking the execve() wrapper's LD_PRELOAD protection).
278 Add both the path in given SANDBOX_x variable, as well as its symlink
279 resolved path in init_env_entries(). Modify filter_path() to be able to
280 resolve paths without resolving symlinks, as well as to be able to resolve
281 symlinks. Fix a possible segfault in check_access(). Add symlink resolving
282 to check_access() resolving bug #31019. Add 'hack' for unlink, as the fix
283 for bug #31019 cause access violations if we try to remove a symlink that is
284 not in protected path, but points to a protected path. Fix a memory leak in
285 sandbox.c (sandbox_pids_file in main()). Fix the realpath() calls in main()
286 (sandbox.c) being unchecked. Fix the debug logname not having the pid in it
287 (pid_string was uninitialized). General syntax cleanups.
288
289 09 Mar 2005; Brian Harring <ferringb@gentoo.org> sandbox.c: Fixed the
290 infamous "pids file is not a regular file" w/out newline bug.
291
292 09 Mar 2005; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in:
293 Correct libc_version path detection, since it was screwing up if libdir !=
294 "/lib/".
295
296 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
297 Hack to make sure sandboxed process cannot remove a device node, bug #79836.
298
299 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am:
300 Fix symbols.in not added to dist.
301
302 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
303 getcwd.c, libsandbox.c, sandbox.c, sandbox.h, sandbox_futils.c:
304 White space fixes.
305
306 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
307 configure.in, getcwd.c, libsandbox.c, symbols.in:
308 Fix inverse test logic in canonicalize.c, use a strncpy. Fix gcc warning in
309 getcwd.c. Add symbols.in and logic to Makefile.am to generate symbol versions
310 for glibc and other libc's that use this. Update libsandbox.c to use these
311 symbol versions if available. Fix exec wrapper to re-export LD_PRELOAD if the
312 process unset it.
313
314 01 Mar 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
315 killed off _init and _fini in favor of
316 void __attribute__ ((constructor)) init_func and
317 void __attribute__ ((destructor)) closing_func. _(init|func) were deprecated.
318
319 06 Dec 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, libsandbox.c,
320 canonicalize.c, getcwd.c: Fixed compilation *again*. Hopefully cvs is done
321 having the hick-ups.
322
323 04 Dec 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, getcwd.c,
324 Makefile.am: Fixed compilation.
325
326 01 Dec 2004; Brian Harring <ferringb@gentoo.org> aclocal.m4:
327 Gutted the bugger so it stops checking for a c++ and fortran compiler.
328 Do *not* regenerate aclocal.m4 for making a release until a better
329 solution is created.
330
331 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, sandbox_futils.c:
332 Removal of more hardcoded paths.
333
334 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in,
335 sandbox_futils.c: tweaks to install sandbox.bashrc, and use it.
336
337 19 Nov 2004; Brian Harring <ferringb@gentoo.org>:
338 Sandbox is now autotooled, create-localdecls needs to be killed and the code
339 shifted into configure.in. Currently builds *one* libsandbox.so- if multiple
340 are desired (-m64 and -m32 for amd64), the ebuild should do it (imo).
341 To get to a point of testing, automake && autoconf; created requisite files w/
342 a(utomake|clocal)-1.8, and autoconf 2.59. Installs to /usr/, instead of
343 /lib and /usr/lib/portage/bin.
344
345 14 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox.c:
346 closing out bug #70225, potential overflow of the sandbox_pids_file var.
347
348 07 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c: c99 standard,
349 (think it was at least) allows intermixing of code and data segments. bug #70351
350 should be fixed by this.
351
352 03 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox_futils.c:
353 futils fix from bug #65201 via solar, and libsandbox log path checks via #69137
354
355 02 Aug 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Code from
356 Seth Robertson that tracked down all adjuct flags for read operations that
357 do not invoke a write operation.
358
359 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
360 Another fix from jstubbs regarding a free() on a stack variable for the
361 environment -- tracking now prevents extraneous free()'s segfault.
362
363 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
364 J. Stubbs tracked down a new bug where mkdir was failing to the patch on
365 the lstat in mkdir... it now only returns 0 or -1 as documented for mkdir.
366 Also remove the errno = ESUCCESS settings as documentation points out that
367 a library isn't allowed to do that.
368
369 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Added a
370 file_security_check() function to check random potential exploits on files
371 that sandbox is to load and read -- Normally sandboxpids.tmp. This fixes
372 the 'system-crippling' exploits (bug 21923) and catches a few other
373 potential problems.
374
375 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> Makefile: Updates for
376 32/64 bit sandbox. Made CC and LD '?=' values to allow passed in CC to work.
377
378 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c:
379 bug 42048 -- Fixed the lstat/errno conditions for mkdir <caleb@g.o>.
380 Added the 64/32 bit sandbox patch for AMD64 bug 32963 <brad/azarah>.
381
382 29 Feb 2004; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c :
383 Fix permissions and group of pids file and logs. Permissions should be 0664
384 and group should be 'portage'. Bug #34260.
385
386 28 Feb 2004; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
387 Besides a small cleanup, redo how we replace LD_PRELOAD in the environ passed
388 to the real execve (in our execve wrapper). Seems that on some arches (sparc
389 among others) do not allow us to tamper with the readonly copy passed to
390 execve, so pass our own copy of the environment. Bug #42290.
391
392 11 Jan 2004; Nicholas Jones <carpaski@gentoo.org> create-decls:
393 Changed tail to head and added a notice about duration of glibc check.
394
395 21 Dec 2003; Nicholas Jones <carpaski@gentoo.org> create-decls:
396 Changed the glibc subversion check to use /usr/bin/* instead of /bin/sh
397 as there isn't a guarentee that it is dynamic.
398
399 02 Nov 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
400 If 'file' passed to before_syscall(const char *func, const char *file) is
401 invalid, we should set errno to ENOENT, and not EINVAL. This should
402 close bug #32238.
403
404 14 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
405 Fix a bug that occurs mainly on 64bit arch, where the file passed to
406 the functions we wrap, is invalid, and then cause canonicalize to pass
407 garbage to before_syscall(), thanks to great detective work from
408 Andrea Luzzardi <al@sig11.org> (bug #29846).
409
410 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
411 Add a uClibc detection patch from Peter S. Mazinger <ps.m@gmx.net>.
412
413 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
414 Fix a bug in libsandbox.c 's checking in the rename wrapper - it basically
415 only checked the destination patch, and not the source, so we could move
416 a protected file to a unprotected directory, and then delete/modify it.
417 Thanks to Andrea Luzzardi (scox) <al@sig11.org>, bug #30992, for this fix.
418
419 12 Oct 2003; Nicholas Jones <carpaski@gentoo.org> sandbox.c :
420 Added python2.3 to the predict section/variable.
421
422 28 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
423 sandbox.h, sandbox_futils.c :
424 Add support to set the pids file via SANDBOX_PIDS_FILE at startup. If
425 it is not set, it will revert to its old value.
426
427 27 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
428 Fix our mkdir wrapper to check if the dir exist, and return EEXIST if so,
429 rather than failing with a violation, bug #29748.
430
431 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
432 Fix canonicalize() to ignore calls with path = "".
433
434 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c,
435 sandbox_futils.c, canonicalize.c :
436 Once again coreutils fails, as my systems had 2.5 kernel, the getcwd system
437 call handled strings larger than PATH_MAX (bug #21766). It however does not
438 work the same on 2.4 kernels.
439
440 To fix, I added the posix implementation of getcwd() (from glibc cvs) that
441 do not need the system call. We use the default getcwd() function via a
442 wrapper (egetcwd), and then lstat the returned path. If lstat fails, it
443 means the current directory was removed, OR that the the system call for
444 getcwd failed (curious is that it do not fail and return NULL or set
445 errno, but rather just truncate the retured directory - usually from the
446 start), and if so, we use the generic getcwd() function (__egetcwd). Note
447 that we do not use the generic version all the time, as it calls lstat()
448 a great number of times, and performance degrade much.
449
450 29 Jun 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls,
451 libsandbox.c :
452 Make sure SB_PATH_MAX will not wrap. Fix two possible memory leaks.
453
454 22 Jun 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, canonicalize.c
455 create-localdecls :
456 When checking path names of files accessed, we need to canonicalize it, else
457 it may be a symlink in a 'write allowed' directory pointing to a file in a
458 directory we should not have write access to.
459
460 With something like coreutils-5.0, we have two problems:
461 1) One of the tests checks if getcwd() can return a path longer than
462 PATH_MAX. This test then tries to create a dir which even while
463 created local (mkdir("conftest2")), it ends up being resolved with
464 a name that is much larger than PATH_MAX. The problem now is that
465 canonicalize() have undefined behaviour when the path was too long
466 (returned wrongly truncated paths, etc), and pass the wrong path to
467 before_syscall() (causing the bogus sandbox violations).
468 2) The ecanonicalize() function we used, along with the canonicalize()
469 function did not support longer than PATH_MAX. This is partly a
470 cause for 1), but the error checking (rather lack of it) of calls
471 to erealpath() in canonicalize() was the prime reason for 1).
472
473 As we do not use this canonicalized name to call the function, we resolve this
474 by fixing canonicalize() to do better error checking, and ecanonicalize() as
475 well as all functions in libsandbox.c to use a PATH_MAX of 'PATH_MAX * 2'.
476 While they will resolve paths properly now, and can check if a write/read is
477 allowed, the functions called from the sandboxed environment will still work
478 as expected.
479
480 This should resolve bug #21766.
481
482 06 Apr 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
483 For some reason sandbox fails with a 'open_wr' if you run 'locale -a' under
484 it (bug #16298).
485
486 Problem is that for some reason locale fopen's locale.alias with mode "rm".
487
488 -------------------------------------------------------
489 nosferatu root # grep fopen locale.log
490 fopen("/usr/share/locale/locale.alias", "rm"ACCESS DENIED open_wr: /usr/share/locale/locale.alias
491 nosferatu root #
492 --------------------------------------------------------
493
494 I checked the source of locale, but it have fopen with mode 'r', so
495 not sure where the "rm" mode comes from. Anyhow, changed the check in
496 before_syscall_open_char() to also see mode "rm" as readonly.
497
498 23 Feb 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
499
500 Add glibc-2.3 support.
501
502 22 Feb 2003; Martin Schlemmer <azarah@gentoo.org> sandbox.c :
503
504 Some /etc/ld.so.preload fixes. Just changed the #if defines to cover all
505 operations releated to preload, as well as only try to modify ld.so.preload
506 if we can. Also modify to write the pid to /tmp/sandboxpids.tmp even when
507 not using ld.so.preload. Fix to not write this instance of sandbox's pid
508 to /tmp/sandboxpids.tmp on exit if this is not the last sandbox running.
509
510 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> Makefile :
511
512 Changed the LD to CC for hppa.
513
514 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
515
516 Killed the previous changes I made.
517
518 17 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
519
520 Added parisc to BROKEN_RTLD_ARCHLIST to see if it we can fix the relocation probs.
521
522 09 Jan 2003; J Robert Ray <jrray@gentoo.org> sandbox.c :
523
524 Don't segfault if $HOME isn't set, set $HOME to "/" instead. Fixes bug 10868.
525
526 16 Dec 2002; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
527
528 Fix memory leak for mips, bug #12236. Thanks to Torgeir Hansen <torgeir@trenger.ro>
529 for this fix.
530
531 4 Dec 2002; J Robert Ray <jrray@gentoo.org> sandbox.h sandbox_futils.c :
532
533 sandbox_futils defined a dirname() function that was masking the same
534 function in glibc and was broken (e.g.: SANDBOX_DIR was being set to
535 '/usr/lib/portage/bi/'). Fixed function to return expected results and
536 renamed it to sb_dirname() to no longer mask the glibc function. Closes bug
537 11231.
538
539 4 Dec 2002; Martin Schlemmer <azarah@gentoo.org> :
540
541 Fix a segfault in libsandbox.c if canonicalize() was called with
542 first parameter = NULL.
543
544 1 Sep 2002; Martin Schlemmer <azarah@gentoo.org> :
545
546 Fix my braindead 'return 1;' in a void function. Updated sandbox.c,
547 cleanup() for this.
548
549 Change cleanup() in sandbox.c not to exit with fail status if
550 the pidsfile is missing. We really should still display sandbox
551 violations if they occured.
552
553 31 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
554
555 Update cleanup() in sandbox.c to remove the PIDSFILE if this is
556 the last sandbox running.
557
558 25 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
559
560 Major cleanups to mainly libsandbox.c again.
561
562 22 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
563
564 Add copyrights to sandbox.h and sandbox_futils.h. If wrong, the
565 parties involved should please contact me so that we can fix it.
566
567 Add opendir wrapper to libsandbox.c.
568
569 21 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
570
571 Do some more cleanups to ecanonicalize(), as it dropped filenames in
572 rare cases (after my symlink cleanups), and caused glibc to bork.
573 These fixes went into canonicalize.c.
574
575 20 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
576
577 Fix spawn_shell() and main() in sandbox.c to properly return fail
578 status.
579
580 19 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
581
582 The new canonicalize() function in libsandbox.c also resolved symlinks,
583 which caused on cleaning sandbox errors if the symlink pointed to a
584 file in the live root. Ripped out canonicalize() and realpath() from
585 glibc; removed the symlink stuff, and changed them to ecanonicalize()
586 and erealpath().
587
588 18 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
589
590 Ripped out all the wrappers, and implemented those of InstallWatch.
591 Losts of cleanups and bugfixes. Implement a execve that forces
592 $LIBSANDBOX in $LD_PRELOAD. We can now thus do away with the feared
593 /etc/ld.so.preload (*g*) ... Made the needed changes to sandbox.c,
594 sandbox.h and sandbox_futils.c. Rewrote the Makefile for most
595 parts; it now have an install target.
596
597 Reformat the whole thing to look somewhat like the reworked sandbox.c
598 and new sandbox.h and sandbox_futils.c from:
599
600 Brad House <brad@mainstreetsoftworks.com>.
601
602 Additional Copyrights now due to the InstallWatch code:
603
604 Copyright (C) 1998-9 Pancrazio `Ezio' de Mauro <p@demauro.net>

Properties

Name Value
svn:eol-style native
svn:keywords Author Date Id Revision

  ViewVC Help
Powered by ViewVC 1.1.20