/[path-sandbox]/trunk/ChangeLog.0
Gentoo

Contents of /trunk/ChangeLog.0

Parent Directory Parent Directory | Revision Log Revision Log


Revision 154 - (show annotations) (download)
Mon Aug 1 08:08:08 2005 UTC (9 years, 2 months ago) by azarah
Original Path: trunk/ChangeLog
File size: 27724 byte(s)
Add support for SANDBOX_VERBOSE (enabled by default).  Adjust SANDBOX_DEBUG
to only enable if equal to 1 or yes.

1 # ChangeLog for Path Sandbox
2 # Copyright 1999-2005 Gentoo Foundation; Distributed under the GPL v2
3 # $Header$
4
5 01 Aug 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
6
7 Still do normal log if debugging is requested.
8
9 Add support for SANDBOX_VERBOSE (enabled by default). Adjust SANDBOX_DEBUG
10 to only enable if equal to "1" or "yes".
11
12 27 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
13 sandbox_futils.c:
14
15 Do not resolve symlinks in PORTAGE_TMPDIR in sandbox .. we will handle that
16 in libsandbox .. bug #100309.
17
18 22 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.h:
19
20 Print all logging to stderr, bug #90343, comment #15, by Zac Medico.
21
22 * sandbox-1.2.11 (2005/07/14)
23
24 14 July 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c:
25 Fix getcwd, bug #98419.
26
27 08 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c,
28 libsandbox.c:
29 - Try to cleanup and make error handling/printing consistent.
30 - Remove old logs if present and conflicting with current.
31 - Fix compile error with previous change, and return rather then exit().
32
33 07 July 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
34 sandbox.h, sandbox_futils.c:
35 - Fix possible segfault in env init code.
36 - Major cleanup of sandbox_futils.c. Removed most of the functions as we now
37 write to /var/log/sandbox/, so in theory do not need all that.
38 - Redo the interface of the get_* functions so that we do not leak memory.
39 - Remove sandbox_dir and co - we are not using it anymore.
40 - Remove unused includes and variables.
41 - Only declare functions in sandbox_futils.c that are used in libsandbox.c when
42 OUTSIDE_LIBSANDBOX is not defined.
43 - Cleanup access/log printing. Make access printing honour NOCOLOR. Fix log
44 printing's last line not honouring NOCOLOR.
45
46 06 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.h, sandbox_futils.c,
47 libsandbox.c:
48 - Change log dir to /var/log/sandbox/. Make sure the sandboxed process cannot
49 write to it.
50 - Clean up logging in libsandbox.c, and hopefully make it more consistant.
51 - Add check_prefixes() with major cleanup on check_access().
52 - Cleanup init_env_entries() and check_prefixes().
53
54 05 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
55 sandbox_futils.c, libsandbox.c:
56 Remove unused 'pids file' code.
57
58 * sandbox-1.2.10 (2005/07/03)
59
60 03 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
61 Add PREDICT items for nss-db, bug #92079. Patch from Robin Johnson.
62
63 17 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
64 General cleanups:
65 - Remove fooling around with exit codes - we error out on presence of a log
66 anyhow.
67 - Move get_sandbox_*_envvar() to sandbox_setup_environ(), as its more
68 appropriate there.
69
70 12 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
71 Cleanup the fail_nametoolong stuff a bit more.
72
73 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
74 Remove hopefully the last ld.so.preload bits we do not use anymore.
75
76 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
77 Remove the unneeded canonicalize() calls in the wrappers - we do it anyhow
78 in check_syscall(). Should speed things up a bit (at least for the getcwd()
79 and long path name test it goes down to under a second, and not 10+ seconds
80 like before). Also warn if we skip checking due to the canonicalized path
81 being too long.
82
83 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
84 More comment/readability cleanups.
85
86 10 June 2005; Martin Schlemmer <azarah@gentoo.org> canonicalize.c, getcwd.c,
87 sandbox_futils.c, libsandbox.c:
88 Some strncpy/strncat and other cleanups.
89
90 * sandbox-1.2.9 (2005/06/09)
91
92 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
93 Move symlink hack down a bit to try and minimize on the amount of lstat()
94 calls we do.
95
96 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
97 Add hack to allow writing to /proc/self/fd (or /dev/fd), bug #91516.
98
99 09 June 2005; Martin Schlemmer <azarah@gentoo.org> symbols.in, libsandbox.c:
100 Add wrapper for access() function, bug #85413.
101
102 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c:
103 Use generic getcwd() implementation from uclibc - should be more portable
104 and looks a bit cleaner.
105
106 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c:
107 Make sure our true_* pointers are initialized to NULL, and that we check for
108 all references that they are valid.
109
110 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
111 Be default we will fail if the path name we try to canonicalize is too long.
112 This however could cause issues with some things (bug #94630 and #21766), so
113 if fail_nametoolong == 0, canonicalize() will return a null length string and
114 do not fail.
115
116 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c:
117 Do not abort if TMPDIR is not valid, but rather use '/tmp', bug #94360. Also
118 make sure we re-export the new TMPDIR environment variable.
119
120 08 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
121 Fix incorrect free of non-malloc'd array, bug #92313 and #94020. Fix noted
122 by Marcus D. Hanwell <cryos@gentoo.org>.
123
124 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
125 Add /dev/console to write list, bug #38588.
126
127 * sandbox-1.2.8 (2005/05/13)
128
129 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
130 sandbox.h, sandbox_futils.c:
131 General cleanups.
132
133 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
134 sandbox.h:
135 Various LD_PRELOAD cleanups. Do not unset LD_PRELOAD for parent.
136
137 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
138 sandbox.h, sandbox_futils.c:
139 Modify get_sandbox_pids_file(), get_sandbox_log() and get_sandbox_debug_log()
140 to use TMPDIR if present in environment.
141
142 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
143 Remove sandbox_log_file from main() as its no longer used.
144
145 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
146 sandbox_futils.c:
147 Add get_sandbox_debug_log(), and use it (add behaviour similar to SANDBOX_LOG
148 if already exported when sandbox started). Fix get_sandbox_log() and new
149 get_sandbox_debug_log() to not use already exported environment variables if
150 they have '/' in them. Use snprintf()'s instead of strncpy()'s. More
151 SB_PATH_MAX fixes.
152
153 * sandbox-1.2.7 (2005/05/12)
154
155 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
156 sandbox_futils.c:
157 More path limit fixes. Declare SB_BUF_LEN global and use it where needed.
158
159 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
160 Fix paths limited to 255 chars. Fix get_sandbox_dir() returning a string
161 with '(null)' in it if we did not call sandbox with absolute path.
162
163 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
164 Set SANDBOX_ON *before* doing the child's env stuff, else its not set
165 for the child.
166
167 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
168 Remove global preload_adaptable as it is no longer used.
169
170 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
171 Rewrite environment stuff to only be set when execve'ing the child process
172 to try and avoid issues like bug #91541 that causes sandbox to crash if
173 we set LD_PRELOAD sandbox side already.
174
175 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
176 Move print_sandbox_log() up to make things neater.
177
178 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
179 Remove load_preload_libs(), as its not used anymore.
180
181 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
182 Remove NO_FORK stuff, as its not used, and 'strace -f' works just fine.
183
184 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
185 Remove USE_SYSTEM_SHELL stuff, as it is not secure, and not in use.
186
187 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
188 Remove ld.so.preload crap - we are not going to use it again.
189
190 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
191 Fix typo in code that checks if we got valid group information, causing a
192 segmentation fault, bug #91637.
193
194 * sandbox-1.2.6 (2005/05/10)
195
196 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
197 Do not use LD_PRELOAD if it contains libtsocks.so, as it breaks sandbox
198 for some odd reason, bug #91541.
199
200 09 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
201 Fix typo (sizeof -> strlen).
202
203 08 May 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
204 rewrote the sbcontext caching code so it accounts for env changes since lib
205 initialization.
206
207 05 May 2005; Martin Schlemmer <azarah@gentoo.org> configure.in, libctest.c:
208 We create libctest.c via configure, so no need to keep it around. Do some
209 cleanup related to libctest.c and libctest during configure.
210
211 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
212 Add rename support of symlinks pointing to protected files/directories.
213
214 * sandbox-1.2.5 (2005/05/04)
215
216 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
217 sandbox.bashrc:
218 Do not reset already set LD_PRELOAD when starting sandbox. If LD_PRELOAD is
219 already set, init of the env vars fails for some reason, so do this later on,
220 and do not warn (bug #91431).
221
222 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
223 sandbox.bashrc:
224 Fixup sandbox and sandbox.bashrc to call bash with the proper .bashrc.
225
226 * sandbox-1.2.4 (2005/05/03)
227
228 03 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
229 Do not init the env entries with each call, as it creates too many calls to
230 lstat, etc. Should speedup things a bit, bug #91040.
231
232 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
233 Add /dev/pty to default write list. Noticed by Morfic.
234
235 02 May 2005; Mike Frysinger <vapier@gentoo.org> configure.in, localdecls.h,
236 sandbox.h:
237 uClibc doesn't support dlvsym() so add a configure check to make sure it doesn't
238 exist. Also update localdecls.h so BROKEN_RTLD_NEXT isn't defined in uClibc.
239
240 * sandbox-1.2.3 (2005/04/29)
241
242 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> configure.in:
243 Do not check for (*&#$(* CXX or F77.
244
245 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
246 Do not append '/' to pathname in filter_path() if it already ends with it.
247
248 28 Apr 2005; Mike Frysinger <vapier@gentoo.org> Makefile.am, configure.in:
249 With az's help, clean up autotools to work with cross-compiling.
250
251 * sandbox-1.2.2 (2005/04/28)
252
253 28 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
254 Only check for /dev/{null,zero} for unlink hack, else ricers using /dev/shm
255 have issues; bug #90592.
256
257 * sandbox-1.2.1 (2005/04/23)
258
259 23 Apr 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
260 getcwd.c, libsandbox.c, localdecls.h, sandbox.h, sandbox_futils.c:
261 Make sure all functions used in libsandbox.c is declared static. Define
262 SB_STATIC in localdecls.h for this. Include sandbox_futils.c rather than
263 linking with its object. Hopefully this will fix bug #90153.
264
265 * sandbox-1.2 (2005/04/23)
266
267 22 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
268 Allow lchown a symlink in write-allowed path pointing to write-denied
269 target.
270
271 21 Mar 2005; Marius Mauch <genone@gentoo.org> libsandbox.c:
272 Also show resolved symlink names in the log.
273
274 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, libsandbox.c:
275 Seems -nostdlib was the problem with the constructor/destructor - remove it
276 from Makefile.am, and change the constructor/destructor names again.
277
278 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
279 Also rename the _init() and _fini() declarations.
280
281 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
282 Fixup the constructor/destructor function names again (they should be _init()
283 and _fini() it seems, and not being called caused sandbox_lib_path to be
284 unset, and thus breaking the execve() wrapper's LD_PRELOAD protection).
285 Add both the path in given SANDBOX_x variable, as well as its symlink
286 resolved path in init_env_entries(). Modify filter_path() to be able to
287 resolve paths without resolving symlinks, as well as to be able to resolve
288 symlinks. Fix a possible segfault in check_access(). Add symlink resolving
289 to check_access() resolving bug #31019. Add 'hack' for unlink, as the fix
290 for bug #31019 cause access violations if we try to remove a symlink that is
291 not in protected path, but points to a protected path. Fix a memory leak in
292 sandbox.c (sandbox_pids_file in main()). Fix the realpath() calls in main()
293 (sandbox.c) being unchecked. Fix the debug logname not having the pid in it
294 (pid_string was uninitialized). General syntax cleanups.
295
296 09 Mar 2005; Brian Harring <ferringb@gentoo.org> sandbox.c: Fixed the
297 infamous "pids file is not a regular file" w/out newline bug.
298
299 09 Mar 2005; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in:
300 Correct libc_version path detection, since it was screwing up if libdir !=
301 "/lib/".
302
303 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
304 Hack to make sure sandboxed process cannot remove a device node, bug #79836.
305
306 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am:
307 Fix symbols.in not added to dist.
308
309 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
310 getcwd.c, libsandbox.c, sandbox.c, sandbox.h, sandbox_futils.c:
311 White space fixes.
312
313 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
314 configure.in, getcwd.c, libsandbox.c, symbols.in:
315 Fix inverse test logic in canonicalize.c, use a strncpy. Fix gcc warning in
316 getcwd.c. Add symbols.in and logic to Makefile.am to generate symbol versions
317 for glibc and other libc's that use this. Update libsandbox.c to use these
318 symbol versions if available. Fix exec wrapper to re-export LD_PRELOAD if the
319 process unset it.
320
321 01 Mar 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
322 killed off _init and _fini in favor of
323 void __attribute__ ((constructor)) init_func and
324 void __attribute__ ((destructor)) closing_func. _(init|func) were deprecated.
325
326 06 Dec 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, libsandbox.c,
327 canonicalize.c, getcwd.c: Fixed compilation *again*. Hopefully cvs is done
328 having the hick-ups.
329
330 04 Dec 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, getcwd.c,
331 Makefile.am: Fixed compilation.
332
333 01 Dec 2004; Brian Harring <ferringb@gentoo.org> aclocal.m4:
334 Gutted the bugger so it stops checking for a c++ and fortran compiler.
335 Do *not* regenerate aclocal.m4 for making a release until a better
336 solution is created.
337
338 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, sandbox_futils.c:
339 Removal of more hardcoded paths.
340
341 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in,
342 sandbox_futils.c: tweaks to install sandbox.bashrc, and use it.
343
344 19 Nov 2004; Brian Harring <ferringb@gentoo.org>:
345 Sandbox is now autotooled, create-localdecls needs to be killed and the code
346 shifted into configure.in. Currently builds *one* libsandbox.so- if multiple
347 are desired (-m64 and -m32 for amd64), the ebuild should do it (imo).
348 To get to a point of testing, automake && autoconf; created requisite files w/
349 a(utomake|clocal)-1.8, and autoconf 2.59. Installs to /usr/, instead of
350 /lib and /usr/lib/portage/bin.
351
352 14 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox.c:
353 closing out bug #70225, potential overflow of the sandbox_pids_file var.
354
355 07 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c: c99 standard,
356 (think it was at least) allows intermixing of code and data segments. bug #70351
357 should be fixed by this.
358
359 03 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox_futils.c:
360 futils fix from bug #65201 via solar, and libsandbox log path checks via #69137
361
362 02 Aug 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Code from
363 Seth Robertson that tracked down all adjuct flags for read operations that
364 do not invoke a write operation.
365
366 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
367 Another fix from jstubbs regarding a free() on a stack variable for the
368 environment -- tracking now prevents extraneous free()'s segfault.
369
370 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
371 J. Stubbs tracked down a new bug where mkdir was failing to the patch on
372 the lstat in mkdir... it now only returns 0 or -1 as documented for mkdir.
373 Also remove the errno = ESUCCESS settings as documentation points out that
374 a library isn't allowed to do that.
375
376 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Added a
377 file_security_check() function to check random potential exploits on files
378 that sandbox is to load and read -- Normally sandboxpids.tmp. This fixes
379 the 'system-crippling' exploits (bug 21923) and catches a few other
380 potential problems.
381
382 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> Makefile: Updates for
383 32/64 bit sandbox. Made CC and LD '?=' values to allow passed in CC to work.
384
385 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c:
386 bug 42048 -- Fixed the lstat/errno conditions for mkdir <caleb@g.o>.
387 Added the 64/32 bit sandbox patch for AMD64 bug 32963 <brad/azarah>.
388
389 29 Feb 2004; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c :
390 Fix permissions and group of pids file and logs. Permissions should be 0664
391 and group should be 'portage'. Bug #34260.
392
393 28 Feb 2004; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
394 Besides a small cleanup, redo how we replace LD_PRELOAD in the environ passed
395 to the real execve (in our execve wrapper). Seems that on some arches (sparc
396 among others) do not allow us to tamper with the readonly copy passed to
397 execve, so pass our own copy of the environment. Bug #42290.
398
399 11 Jan 2004; Nicholas Jones <carpaski@gentoo.org> create-decls:
400 Changed tail to head and added a notice about duration of glibc check.
401
402 21 Dec 2003; Nicholas Jones <carpaski@gentoo.org> create-decls:
403 Changed the glibc subversion check to use /usr/bin/* instead of /bin/sh
404 as there isn't a guarentee that it is dynamic.
405
406 02 Nov 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
407 If 'file' passed to before_syscall(const char *func, const char *file) is
408 invalid, we should set errno to ENOENT, and not EINVAL. This should
409 close bug #32238.
410
411 14 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
412 Fix a bug that occurs mainly on 64bit arch, where the file passed to
413 the functions we wrap, is invalid, and then cause canonicalize to pass
414 garbage to before_syscall(), thanks to great detective work from
415 Andrea Luzzardi <al@sig11.org> (bug #29846).
416
417 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
418 Add a uClibc detection patch from Peter S. Mazinger <ps.m@gmx.net>.
419
420 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
421 Fix a bug in libsandbox.c 's checking in the rename wrapper - it basically
422 only checked the destination patch, and not the source, so we could move
423 a protected file to a unprotected directory, and then delete/modify it.
424 Thanks to Andrea Luzzardi (scox) <al@sig11.org>, bug #30992, for this fix.
425
426 12 Oct 2003; Nicholas Jones <carpaski@gentoo.org> sandbox.c :
427 Added python2.3 to the predict section/variable.
428
429 28 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
430 sandbox.h, sandbox_futils.c :
431 Add support to set the pids file via SANDBOX_PIDS_FILE at startup. If
432 it is not set, it will revert to its old value.
433
434 27 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
435 Fix our mkdir wrapper to check if the dir exist, and return EEXIST if so,
436 rather than failing with a violation, bug #29748.
437
438 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
439 Fix canonicalize() to ignore calls with path = "".
440
441 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c,
442 sandbox_futils.c, canonicalize.c :
443 Once again coreutils fails, as my systems had 2.5 kernel, the getcwd system
444 call handled strings larger than PATH_MAX (bug #21766). It however does not
445 work the same on 2.4 kernels.
446
447 To fix, I added the posix implementation of getcwd() (from glibc cvs) that
448 do not need the system call. We use the default getcwd() function via a
449 wrapper (egetcwd), and then lstat the returned path. If lstat fails, it
450 means the current directory was removed, OR that the the system call for
451 getcwd failed (curious is that it do not fail and return NULL or set
452 errno, but rather just truncate the retured directory - usually from the
453 start), and if so, we use the generic getcwd() function (__egetcwd). Note
454 that we do not use the generic version all the time, as it calls lstat()
455 a great number of times, and performance degrade much.
456
457 29 Jun 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls,
458 libsandbox.c :
459 Make sure SB_PATH_MAX will not wrap. Fix two possible memory leaks.
460
461 22 Jun 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, canonicalize.c
462 create-localdecls :
463 When checking path names of files accessed, we need to canonicalize it, else
464 it may be a symlink in a 'write allowed' directory pointing to a file in a
465 directory we should not have write access to.
466
467 With something like coreutils-5.0, we have two problems:
468 1) One of the tests checks if getcwd() can return a path longer than
469 PATH_MAX. This test then tries to create a dir which even while
470 created local (mkdir("conftest2")), it ends up being resolved with
471 a name that is much larger than PATH_MAX. The problem now is that
472 canonicalize() have undefined behaviour when the path was too long
473 (returned wrongly truncated paths, etc), and pass the wrong path to
474 before_syscall() (causing the bogus sandbox violations).
475 2) The ecanonicalize() function we used, along with the canonicalize()
476 function did not support longer than PATH_MAX. This is partly a
477 cause for 1), but the error checking (rather lack of it) of calls
478 to erealpath() in canonicalize() was the prime reason for 1).
479
480 As we do not use this canonicalized name to call the function, we resolve this
481 by fixing canonicalize() to do better error checking, and ecanonicalize() as
482 well as all functions in libsandbox.c to use a PATH_MAX of 'PATH_MAX * 2'.
483 While they will resolve paths properly now, and can check if a write/read is
484 allowed, the functions called from the sandboxed environment will still work
485 as expected.
486
487 This should resolve bug #21766.
488
489 06 Apr 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
490 For some reason sandbox fails with a 'open_wr' if you run 'locale -a' under
491 it (bug #16298).
492
493 Problem is that for some reason locale fopen's locale.alias with mode "rm".
494
495 -------------------------------------------------------
496 nosferatu root # grep fopen locale.log
497 fopen("/usr/share/locale/locale.alias", "rm"ACCESS DENIED open_wr: /usr/share/locale/locale.alias
498 nosferatu root #
499 --------------------------------------------------------
500
501 I checked the source of locale, but it have fopen with mode 'r', so
502 not sure where the "rm" mode comes from. Anyhow, changed the check in
503 before_syscall_open_char() to also see mode "rm" as readonly.
504
505 23 Feb 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
506
507 Add glibc-2.3 support.
508
509 22 Feb 2003; Martin Schlemmer <azarah@gentoo.org> sandbox.c :
510
511 Some /etc/ld.so.preload fixes. Just changed the #if defines to cover all
512 operations releated to preload, as well as only try to modify ld.so.preload
513 if we can. Also modify to write the pid to /tmp/sandboxpids.tmp even when
514 not using ld.so.preload. Fix to not write this instance of sandbox's pid
515 to /tmp/sandboxpids.tmp on exit if this is not the last sandbox running.
516
517 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> Makefile :
518
519 Changed the LD to CC for hppa.
520
521 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
522
523 Killed the previous changes I made.
524
525 17 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
526
527 Added parisc to BROKEN_RTLD_ARCHLIST to see if it we can fix the relocation probs.
528
529 09 Jan 2003; J Robert Ray <jrray@gentoo.org> sandbox.c :
530
531 Don't segfault if $HOME isn't set, set $HOME to "/" instead. Fixes bug 10868.
532
533 16 Dec 2002; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
534
535 Fix memory leak for mips, bug #12236. Thanks to Torgeir Hansen <torgeir@trenger.ro>
536 for this fix.
537
538 4 Dec 2002; J Robert Ray <jrray@gentoo.org> sandbox.h sandbox_futils.c :
539
540 sandbox_futils defined a dirname() function that was masking the same
541 function in glibc and was broken (e.g.: SANDBOX_DIR was being set to
542 '/usr/lib/portage/bi/'). Fixed function to return expected results and
543 renamed it to sb_dirname() to no longer mask the glibc function. Closes bug
544 11231.
545
546 4 Dec 2002; Martin Schlemmer <azarah@gentoo.org> :
547
548 Fix a segfault in libsandbox.c if canonicalize() was called with
549 first parameter = NULL.
550
551 1 Sep 2002; Martin Schlemmer <azarah@gentoo.org> :
552
553 Fix my braindead 'return 1;' in a void function. Updated sandbox.c,
554 cleanup() for this.
555
556 Change cleanup() in sandbox.c not to exit with fail status if
557 the pidsfile is missing. We really should still display sandbox
558 violations if they occured.
559
560 31 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
561
562 Update cleanup() in sandbox.c to remove the PIDSFILE if this is
563 the last sandbox running.
564
565 25 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
566
567 Major cleanups to mainly libsandbox.c again.
568
569 22 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
570
571 Add copyrights to sandbox.h and sandbox_futils.h. If wrong, the
572 parties involved should please contact me so that we can fix it.
573
574 Add opendir wrapper to libsandbox.c.
575
576 21 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
577
578 Do some more cleanups to ecanonicalize(), as it dropped filenames in
579 rare cases (after my symlink cleanups), and caused glibc to bork.
580 These fixes went into canonicalize.c.
581
582 20 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
583
584 Fix spawn_shell() and main() in sandbox.c to properly return fail
585 status.
586
587 19 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
588
589 The new canonicalize() function in libsandbox.c also resolved symlinks,
590 which caused on cleaning sandbox errors if the symlink pointed to a
591 file in the live root. Ripped out canonicalize() and realpath() from
592 glibc; removed the symlink stuff, and changed them to ecanonicalize()
593 and erealpath().
594
595 18 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
596
597 Ripped out all the wrappers, and implemented those of InstallWatch.
598 Losts of cleanups and bugfixes. Implement a execve that forces
599 $LIBSANDBOX in $LD_PRELOAD. We can now thus do away with the feared
600 /etc/ld.so.preload (*g*) ... Made the needed changes to sandbox.c,
601 sandbox.h and sandbox_futils.c. Rewrote the Makefile for most
602 parts; it now have an install target.
603
604 Reformat the whole thing to look somewhat like the reworked sandbox.c
605 and new sandbox.h and sandbox_futils.c from:
606
607 Brad House <brad@mainstreetsoftworks.com>.
608
609 Additional Copyrights now due to the InstallWatch code:
610
611 Copyright (C) 1998-9 Pancrazio `Ezio' de Mauro <p@demauro.net>

Properties

Name Value
svn:eol-style native
svn:keywords Author Date Id Revision

  ViewVC Help
Powered by ViewVC 1.1.20