/[path-sandbox]/trunk/ChangeLog.0
Gentoo

Contents of /trunk/ChangeLog.0

Parent Directory Parent Directory | Revision Log Revision Log


Revision 43 - (show annotations) (download)
Sat Apr 23 20:44:15 2005 UTC (9 years, 7 months ago) by azarah
Original Path: trunk/ChangeLog
File size: 16932 byte(s)
Make sure all functions used in libsandbox.c is declared static.  Define
SB_STATIC in localdecls.h for this.  Include sandbox_futils.c rather than
linking with its object.  Hopefully this will fix bug #90153.

1 # ChangeLog for Path Sandbox
2 # Copyright 1999-2004 Gentoo Foundation; Distributed under the GPL v2
3 # $Header$
4
5 23 Apr 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
6 getcwd.c, libsandbox.c, localdecls.h, sandbox.h, sandbox_futils.c:
7 Make sure all functions used in libsandbox.c is declared static. Define
8 SB_STATIC in localdecls.h for this. Include sandbox_futils.c rather than
9 linking with its object. Hopefully this will fix bug #90153.
10
11 22 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
12 Allow lchown a symlink in write-allowed path pointing to write-denied
13 target.
14
15 21 Mar 2005; Marius Mauch <genone@gentoo.org> libsandbox.c:
16 Also show resolved symlink names in the log.
17
18 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, libsandbox.c:
19 Seems -nostdlib was the problem with the constructor/destructor - remove it
20 from Makefile.am, and change the constructor/destructor names again.
21
22 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
23 Also rename the _init() and _fini() declarations.
24
25 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
26 Fixup the constructor/destructor function names again (they should be _init()
27 and _fini() it seems, and not being called caused sandbox_lib_path to be
28 unset, and thus breaking the execve() wrapper's LD_PRELOAD protection).
29 Add both the path in given SANDBOX_x variable, as well as its symlink
30 resolved path in init_env_entries(). Modify filter_path() to be able to
31 resolve paths without resolving symlinks, as well as to be able to resolve
32 symlinks. Fix a possible segfault in check_access(). Add symlink resolving
33 to check_access() resolving bug #31019. Add 'hack' for unlink, as the fix
34 for bug #31019 cause access violations if we try to remove a symlink that is
35 not in protected path, but points to a protected path. Fix a memory leak in
36 sandbox.c (sandbox_pids_file in main()). Fix the realpath() calls in main()
37 (sandbox.c) being unchecked. Fix the debug logname not having the pid in it
38 (pid_string was uninitialized). General syntax cleanups.
39
40 09 Mar 2005; Brian Harring <ferringb@gentoo.org> sandbox.c: Fixed the
41 infamous "pids file is not a regular file" w/out newline bug.
42
43 09 Mar 2005; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in:
44 Correct libc_version path detection, since it was screwing up if libdir !=
45 "/lib/".
46
47 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
48 Hack to make sure sandboxed process cannot remove a device node, bug #79836.
49
50 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am:
51 Fix symbols.in not added to dist.
52
53 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
54 getcwd.c, libsandbox.c, sandbox.c, sandbox.h, sandbox_futils.c:
55 White space fixes.
56
57 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
58 configure.in, getcwd.c, libsandbox.c, symbols.in:
59 Fix inverse test logic in canonicalize.c, use a strncpy. Fix gcc warning in
60 getcwd.c. Add symbols.in and logic to Makefile.am to generate symbol versions
61 for glibc and other libc's that use this. Update libsandbox.c to use these
62 symbol versions if available. Fix exec wrapper to re-export LD_PRELOAD if the
63 process unset it.
64
65 01 Mar 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
66 killed off _init and _fini in favor of
67 void __attribute__ ((constructor)) init_func and
68 void __attribute__ ((destructor)) closing_func. _(init|func) were deprecated.
69
70 06 Dec 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, libsandbox.c,
71 canonicalize.c, getcwd.c: Fixed compilation *again*. Hopefully cvs is done
72 having the hick-ups.
73
74 04 Dec 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, getcwd.c,
75 Makefile.am: Fixed compilation.
76
77 01 Dec 2004; Brian Harring <ferringb@gentoo.org> aclocal.m4:
78 Gutted the bugger so it stops checking for a c++ and fortran compiler.
79 Do *not* regenerate aclocal.m4 for making a release until a better
80 solution is created.
81
82 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, sandbox_futils.c:
83 Removal of more hardcoded paths.
84
85 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in,
86 sandbox_futils.c: tweaks to install sandbox.bashrc, and use it.
87
88 19 Nov 2004; Brian Harring <ferringb@gentoo.org>:
89 Sandbox is now autotooled, create-localdecls needs to be killed and the code
90 shifted into configure.in. Currently builds *one* libsandbox.so- if multiple
91 are desired (-m64 and -m32 for amd64), the ebuild should do it (imo).
92 To get to a point of testing, automake && autoconf; created requisite files w/
93 a(utomake|clocal)-1.8, and autoconf 2.59. Installs to /usr/, instead of
94 /lib and /usr/lib/portage/bin.
95
96 14 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox.c:
97 closing out bug #70225, potential overflow of the sandbox_pids_file var.
98
99 07 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c: c99 standard,
100 (think it was at least) allows intermixing of code and data segments. bug #70351
101 should be fixed by this.
102
103 03 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox_futils.c:
104 futils fix from bug #65201 via solar, and libsandbox log path checks via #69137
105
106 02 Aug 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Code from
107 Seth Robertson that tracked down all adjuct flags for read operations that
108 do not invoke a write operation.
109
110 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
111 Another fix from jstubbs regarding a free() on a stack variable for the
112 environment -- tracking now prevents extraneous free()'s segfault.
113
114 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
115 J. Stubbs tracked down a new bug where mkdir was failing to the patch on
116 the lstat in mkdir... it now only returns 0 or -1 as documented for mkdir.
117 Also remove the errno = ESUCCESS settings as documentation points out that
118 a library isn't allowed to do that.
119
120 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Added a
121 file_security_check() function to check random potential exploits on files
122 that sandbox is to load and read -- Normally sandboxpids.tmp. This fixes
123 the 'system-crippling' exploits (bug 21923) and catches a few other
124 potential problems.
125
126 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> Makefile: Updates for
127 32/64 bit sandbox. Made CC and LD '?=' values to allow passed in CC to work.
128
129 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c:
130 bug 42048 -- Fixed the lstat/errno conditions for mkdir <caleb@g.o>.
131 Added the 64/32 bit sandbox patch for AMD64 bug 32963 <brad/azarah>.
132
133 29 Feb 2004; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c :
134 Fix permissions and group of pids file and logs. Permissions should be 0664
135 and group should be 'portage'. Bug #34260.
136
137 28 Feb 2004; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
138 Besides a small cleanup, redo how we replace LD_PRELOAD in the environ passed
139 to the real execve (in our execve wrapper). Seems that on some arches (sparc
140 among others) do not allow us to tamper with the readonly copy passed to
141 execve, so pass our own copy of the environment. Bug #42290.
142
143 11 Jan 2004; Nicholas Jones <carpaski@gentoo.org> create-decls:
144 Changed tail to head and added a notice about duration of glibc check.
145
146 21 Dec 2003; Nicholas Jones <carpaski@gentoo.org> create-decls:
147 Changed the glibc subversion check to use /usr/bin/* instead of /bin/sh
148 as there isn't a guarentee that it is dynamic.
149
150 02 Nov 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
151 If 'file' passed to before_syscall(const char *func, const char *file) is
152 invalid, we should set errno to ENOENT, and not EINVAL. This should
153 close bug #32238.
154
155 14 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
156 Fix a bug that occurs mainly on 64bit arch, where the file passed to
157 the functions we wrap, is invalid, and then cause canonicalize to pass
158 garbage to before_syscall(), thanks to great detective work from
159 Andrea Luzzardi <al@sig11.org> (bug #29846).
160
161 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
162 Add a uClibc detection patch from Peter S. Mazinger <ps.m@gmx.net>.
163
164 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
165 Fix a bug in libsandbox.c 's checking in the rename wrapper - it basically
166 only checked the destination patch, and not the source, so we could move
167 a protected file to a unprotected directory, and then delete/modify it.
168 Thanks to Andrea Luzzardi (scox) <al@sig11.org>, bug #30992, for this fix.
169
170 12 Oct 2003; Nicholas Jones <carpaski@gentoo.org> sandbox.c :
171 Added python2.3 to the predict section/variable.
172
173 28 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
174 sandbox.h, sandbox_futils.c :
175 Add support to set the pids file via SANDBOX_PIDS_FILE at startup. If
176 it is not set, it will revert to its old value.
177
178 27 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
179 Fix our mkdir wrapper to check if the dir exist, and return EEXIST if so,
180 rather than failing with a violation, bug #29748.
181
182 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
183 Fix canonicalize() to ignore calls with path = "".
184
185 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c,
186 sandbox_futils.c, canonicalize.c :
187 Once again coreutils fails, as my systems had 2.5 kernel, the getcwd system
188 call handled strings larger than PATH_MAX (bug #21766). It however does not
189 work the same on 2.4 kernels.
190
191 To fix, I added the posix implementation of getcwd() (from glibc cvs) that
192 do not need the system call. We use the default getcwd() function via a
193 wrapper (egetcwd), and then lstat the returned path. If lstat fails, it
194 means the current directory was removed, OR that the the system call for
195 getcwd failed (curious is that it do not fail and return NULL or set
196 errno, but rather just truncate the retured directory - usually from the
197 start), and if so, we use the generic getcwd() function (__egetcwd). Note
198 that we do not use the generic version all the time, as it calls lstat()
199 a great number of times, and performance degrade much.
200
201 29 Jun 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls,
202 libsandbox.c :
203 Make sure SB_PATH_MAX will not wrap. Fix two possible memory leaks.
204
205 22 Jun 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, canonicalize.c
206 create-localdecls :
207 When checking path names of files accessed, we need to canonicalize it, else
208 it may be a symlink in a 'write allowed' directory pointing to a file in a
209 directory we should not have write access to.
210
211 With something like coreutils-5.0, we have two problems:
212 1) One of the tests checks if getcwd() can return a path longer than
213 PATH_MAX. This test then tries to create a dir which even while
214 created local (mkdir("conftest2")), it ends up being resolved with
215 a name that is much larger than PATH_MAX. The problem now is that
216 canonicalize() have undefined behaviour when the path was too long
217 (returned wrongly truncated paths, etc), and pass the wrong path to
218 before_syscall() (causing the bogus sandbox violations).
219 2) The ecanonicalize() function we used, along with the canonicalize()
220 function did not support longer than PATH_MAX. This is partly a
221 cause for 1), but the error checking (rather lack of it) of calls
222 to erealpath() in canonicalize() was the prime reason for 1).
223
224 As we do not use this canonicalized name to call the function, we resolve this
225 by fixing canonicalize() to do better error checking, and ecanonicalize() as
226 well as all functions in libsandbox.c to use a PATH_MAX of 'PATH_MAX * 2'.
227 While they will resolve paths properly now, and can check if a write/read is
228 allowed, the functions called from the sandboxed environment will still work
229 as expected.
230
231 This should resolve bug #21766.
232
233 06 Apr 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
234 For some reason sandbox fails with a 'open_wr' if you run 'locale -a' under
235 it (bug #16298).
236
237 Problem is that for some reason locale fopen's locale.alias with mode "rm".
238
239 -------------------------------------------------------
240 nosferatu root # grep fopen locale.log
241 fopen("/usr/share/locale/locale.alias", "rm"ACCESS DENIED open_wr: /usr/share/locale/locale.alias
242 nosferatu root #
243 --------------------------------------------------------
244
245 I checked the source of locale, but it have fopen with mode 'r', so
246 not sure where the "rm" mode comes from. Anyhow, changed the check in
247 before_syscall_open_char() to also see mode "rm" as readonly.
248
249 23 Feb 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
250
251 Add glibc-2.3 support.
252
253 22 Feb 2003; Martin Schlemmer <azarah@gentoo.org> sandbox.c :
254
255 Some /etc/ld.so.preload fixes. Just changed the #if defines to cover all
256 operations releated to preload, as well as only try to modify ld.so.preload
257 if we can. Also modify to write the pid to /tmp/sandboxpids.tmp even when
258 not using ld.so.preload. Fix to not write this instance of sandbox's pid
259 to /tmp/sandboxpids.tmp on exit if this is not the last sandbox running.
260
261 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> Makefile :
262
263 Changed the LD to CC for hppa.
264
265 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
266
267 Killed the previous changes I made.
268
269 17 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
270
271 Added parisc to BROKEN_RTLD_ARCHLIST to see if it we can fix the relocation probs.
272
273 09 Jan 2003; J Robert Ray <jrray@gentoo.org> sandbox.c :
274
275 Don't segfault if $HOME isn't set, set $HOME to "/" instead. Fixes bug 10868.
276
277 16 Dec 2002; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
278
279 Fix memory leak for mips, bug #12236. Thanks to Torgeir Hansen <torgeir@trenger.ro>
280 for this fix.
281
282 4 Dec 2002; J Robert Ray <jrray@gentoo.org> sandbox.h sandbox_futils.c :
283
284 sandbox_futils defined a dirname() function that was masking the same
285 function in glibc and was broken (e.g.: SANDBOX_DIR was being set to
286 '/usr/lib/portage/bi/'). Fixed function to return expected results and
287 renamed it to sb_dirname() to no longer mask the glibc function. Closes bug
288 11231.
289
290 4 Dec 2002; Martin Schlemmer <azarah@gentoo.org> :
291
292 Fix a segfault in libsandbox.c if canonicalize() was called with
293 first parameter = NULL.
294
295 1 Sep 2002; Martin Schlemmer <azarah@gentoo.org> :
296
297 Fix my braindead 'return 1;' in a void function. Updated sandbox.c,
298 cleanup() for this.
299
300 Change cleanup() in sandbox.c not to exit with fail status if
301 the pidsfile is missing. We really should still display sandbox
302 violations if they occured.
303
304 31 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
305
306 Update cleanup() in sandbox.c to remove the PIDSFILE if this is
307 the last sandbox running.
308
309 25 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
310
311 Major cleanups to mainly libsandbox.c again.
312
313 22 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
314
315 Add copyrights to sandbox.h and sandbox_futils.h. If wrong, the
316 parties involved should please contact me so that we can fix it.
317
318 Add opendir wrapper to libsandbox.c.
319
320 21 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
321
322 Do some more cleanups to ecanonicalize(), as it dropped filenames in
323 rare cases (after my symlink cleanups), and caused glibc to bork.
324 These fixes went into canonicalize.c.
325
326 20 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
327
328 Fix spawn_shell() and main() in sandbox.c to properly return fail
329 status.
330
331 19 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
332
333 The new canonicalize() function in libsandbox.c also resolved symlinks,
334 which caused on cleaning sandbox errors if the symlink pointed to a
335 file in the live root. Ripped out canonicalize() and realpath() from
336 glibc; removed the symlink stuff, and changed them to ecanonicalize()
337 and erealpath().
338
339 18 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
340
341 Ripped out all the wrappers, and implemented those of InstallWatch.
342 Losts of cleanups and bugfixes. Implement a execve that forces
343 $LIBSANDBOX in $LD_PRELOAD. We can now thus do away with the feared
344 /etc/ld.so.preload (*g*) ... Made the needed changes to sandbox.c,
345 sandbox.h and sandbox_futils.c. Rewrote the Makefile for most
346 parts; it now have an install target.
347
348 Reformat the whole thing to look somewhat like the reworked sandbox.c
349 and new sandbox.h and sandbox_futils.c from:
350
351 Brad House <brad@mainstreetsoftworks.com>.
352
353 Additional Copyrights now due to the InstallWatch code:
354
355 Copyright (C) 1998-9 Pancrazio `Ezio' de Mauro <p@demauro.net>

Properties

Name Value
svn:eol-style native
svn:keywords Author Date Id Revision

  ViewVC Help
Powered by ViewVC 1.1.20