/[path-sandbox]/trunk/ChangeLog
Gentoo

Contents of /trunk/ChangeLog

Parent Directory Parent Directory | Revision Log Revision Log


Revision 123 - (hide annotations) (download)
Fri Jun 17 12:10:14 2005 UTC (9 years, 5 months ago) by azarah
File size: 25195 byte(s)
Remove fooling around with exit codes - we error out on presence of a log anyhow.
1 ferringb 2 # ChangeLog for Path Sandbox
2 vapier 53 # Copyright 1999-2005 Gentoo Foundation; Distributed under the GPL v2
3 ferringb 2 # $Header$
4    
5 azarah 123 17 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
6     General cleanups:
7     - Remove fooling around with exit codes - we error out on presence of a log
8     anyhow.
9    
10 azarah 121 12 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
11     Cleanup the fail_nametoolong stuff a bit more.
12    
13 azarah 118 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
14 azarah 120 Remove hopefully the last ld.so.preload bits we do not use anymore.
15    
16     11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
17 azarah 119 Remove the unneeded canonicalize() calls in the wrappers - we do it anyhow
18     in check_syscall(). Should speed things up a bit (at least for the getcwd()
19     and long path name test it goes down to under a second, and not 10+ seconds
20     like before). Also warn if we skip checking due to the canonicalized path
21     being too long.
22    
23     11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
24 azarah 118 More comment/readability cleanups.
25    
26 azarah 117 10 June 2005; Martin Schlemmer <azarah@gentoo.org> canonicalize.c, getcwd.c,
27     sandbox_futils.c, libsandbox.c:
28     Some strncpy/strncat and other cleanups.
29    
30 azarah 115 * sandbox-1.2.9 (2005/06/09)
31    
32 azarah 114 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
33     Move symlink hack down a bit to try and minimize on the amount of lstat()
34     calls we do.
35    
36 azarah 113 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
37     Add hack to allow writing to /proc/self/fd (or /dev/fd), bug #91516.
38    
39 azarah 112 09 June 2005; Martin Schlemmer <azarah@gentoo.org> symbols.in, libsandbox.c:
40     Add wrapper for access() function, bug #85413.
41    
42 azarah 111 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c:
43     Use generic getcwd() implementation from uclibc - should be more portable
44     and looks a bit cleaner.
45    
46 azarah 110 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c:
47     Make sure our true_* pointers are initialized to NULL, and that we check for
48     all references that they are valid.
49    
50 azarah 109 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
51     Be default we will fail if the path name we try to canonicalize is too long.
52     This however could cause issues with some things (bug #94630 and #21766), so
53     if fail_nametoolong == 0, canonicalize() will return a null length string and
54     do not fail.
55    
56 azarah 108 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c:
57     Do not abort if TMPDIR is not valid, but rather use '/tmp', bug #94360. Also
58     make sure we re-export the new TMPDIR environment variable.
59    
60 azarah 106 08 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
61     Fix incorrect free of non-malloc'd array, bug #92313 and #94020. Fix noted
62     by Marcus D. Hanwell <cryos@gentoo.org>.
63    
64 azarah 105 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
65     Add /dev/console to write list, bug #38588.
66    
67 azarah 102 * sandbox-1.2.8 (2005/05/13)
68    
69 azarah 99 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
70 azarah 101 sandbox.h, sandbox_futils.c:
71     General cleanups.
72    
73     13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
74 azarah 100 sandbox.h:
75     Various LD_PRELOAD cleanups. Do not unset LD_PRELOAD for parent.
76    
77     13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
78 azarah 99 sandbox.h, sandbox_futils.c:
79     Modify get_sandbox_pids_file(), get_sandbox_log() and get_sandbox_debug_log()
80     to use TMPDIR if present in environment.
81    
82 azarah 98 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
83     Remove sandbox_log_file from main() as its no longer used.
84    
85 azarah 97 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
86     sandbox_futils.c:
87     Add get_sandbox_debug_log(), and use it (add behaviour similar to SANDBOX_LOG
88     if already exported when sandbox started). Fix get_sandbox_log() and new
89     get_sandbox_debug_log() to not use already exported environment variables if
90     they have '/' in them. Use snprintf()'s instead of strncpy()'s. More
91     SB_PATH_MAX fixes.
92    
93 azarah 94 * sandbox-1.2.7 (2005/05/12)
94    
95 azarah 93 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
96     sandbox_futils.c:
97     More path limit fixes. Declare SB_BUF_LEN global and use it where needed.
98    
99 azarah 92 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
100     Fix paths limited to 255 chars. Fix get_sandbox_dir() returning a string
101     with '(null)' in it if we did not call sandbox with absolute path.
102    
103 azarah 89 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
104 azarah 91 Set SANDBOX_ON *before* doing the child's env stuff, else its not set
105     for the child.
106    
107     12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
108 azarah 90 Remove global preload_adaptable as it is no longer used.
109    
110     12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
111 azarah 89 Rewrite environment stuff to only be set when execve'ing the child process
112     to try and avoid issues like bug #91541 that causes sandbox to crash if
113     we set LD_PRELOAD sandbox side already.
114    
115 azarah 87 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
116 azarah 88 Move print_sandbox_log() up to make things neater.
117    
118     11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
119 azarah 87 Remove load_preload_libs(), as its not used anymore.
120    
121 azarah 83 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
122 azarah 86 Remove NO_FORK stuff, as its not used, and 'strace -f' works just fine.
123    
124     11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
125 azarah 84 Remove USE_SYSTEM_SHELL stuff, as it is not secure, and not in use.
126    
127     11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
128 azarah 83 Remove ld.so.preload crap - we are not going to use it again.
129    
130 azarah 82 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
131     Fix typo in code that checks if we got valid group information, causing a
132     segmentation fault, bug #91637.
133    
134 azarah 79 * sandbox-1.2.6 (2005/05/10)
135    
136 azarah 78 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
137     Do not use LD_PRELOAD if it contains libtsocks.so, as it breaks sandbox
138     for some odd reason, bug #91541.
139    
140 azarah 77 09 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
141     Fix typo (sizeof -> strlen).
142    
143 ferringb 76 08 May 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
144     rewrote the sbcontext caching code so it accounts for env changes since lib
145     initialization.
146    
147 azarah 75 05 May 2005; Martin Schlemmer <azarah@gentoo.org> configure.in, libctest.c:
148     We create libctest.c via configure, so no need to keep it around. Do some
149     cleanup related to libctest.c and libctest during configure.
150    
151 azarah 74 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
152     Add rename support of symlinks pointing to protected files/directories.
153    
154 azarah 72 * sandbox-1.2.5 (2005/05/04)
155    
156 azarah 71 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
157     sandbox.bashrc:
158     Do not reset already set LD_PRELOAD when starting sandbox. If LD_PRELOAD is
159     already set, init of the env vars fails for some reason, so do this later on,
160     and do not warn (bug #91431).
161    
162 azarah 70 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
163     sandbox.bashrc:
164     Fixup sandbox and sandbox.bashrc to call bash with the proper .bashrc.
165    
166 azarah 68 * sandbox-1.2.4 (2005/05/03)
167    
168 azarah 66 03 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
169     Do not init the env entries with each call, as it creates too many calls to
170 azarah 67 lstat, etc. Should speedup things a bit, bug #91040.
171 azarah 66
172 azarah 65 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
173     Add /dev/pty to default write list. Noticed by Morfic.
174    
175 vapier 62 02 May 2005; Mike Frysinger <vapier@gentoo.org> configure.in, localdecls.h,
176     sandbox.h:
177     uClibc doesn't support dlvsym() so add a configure check to make sure it doesn't
178     exist. Also update localdecls.h so BROKEN_RTLD_NEXT isn't defined in uClibc.
179    
180 azarah 59 * sandbox-1.2.3 (2005/04/29)
181    
182 azarah 56 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> configure.in:
183     Do not check for (*&#$(* CXX or F77.
184    
185 azarah 54 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
186     Do not append '/' to pathname in filter_path() if it already ends with it.
187    
188 vapier 53 28 Apr 2005; Mike Frysinger <vapier@gentoo.org> Makefile.am, configure.in:
189     With az's help, clean up autotools to work with cross-compiling.
190    
191 azarah 59 * sandbox-1.2.2 (2005/04/28)
192 azarah 48
193 azarah 47 28 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
194     Only check for /dev/{null,zero} for unlink hack, else ricers using /dev/shm
195     have issues; bug #90592.
196    
197 azarah 59 * sandbox-1.2.1 (2005/04/23)
198 azarah 44
199 azarah 43 23 Apr 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
200     getcwd.c, libsandbox.c, localdecls.h, sandbox.h, sandbox_futils.c:
201     Make sure all functions used in libsandbox.c is declared static. Define
202     SB_STATIC in localdecls.h for this. Include sandbox_futils.c rather than
203     linking with its object. Hopefully this will fix bug #90153.
204    
205 azarah 59 * sandbox-1.2 (2005/04/23)
206 azarah 46
207 azarah 40 22 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
208     Allow lchown a symlink in write-allowed path pointing to write-denied
209     target.
210    
211 genone 39 21 Mar 2005; Marius Mauch <genone@gentoo.org> libsandbox.c:
212     Also show resolved symlink names in the log.
213    
214 azarah 37 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, libsandbox.c:
215     Seems -nostdlib was the problem with the constructor/destructor - remove it
216     from Makefile.am, and change the constructor/destructor names again.
217    
218 azarah 36 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
219     Also rename the _init() and _fini() declarations.
220    
221 azarah 35 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
222     Fixup the constructor/destructor function names again (they should be _init()
223     and _fini() it seems, and not being called caused sandbox_lib_path to be
224     unset, and thus breaking the execve() wrapper's LD_PRELOAD protection).
225     Add both the path in given SANDBOX_x variable, as well as its symlink
226     resolved path in init_env_entries(). Modify filter_path() to be able to
227     resolve paths without resolving symlinks, as well as to be able to resolve
228     symlinks. Fix a possible segfault in check_access(). Add symlink resolving
229     to check_access() resolving bug #31019. Add 'hack' for unlink, as the fix
230     for bug #31019 cause access violations if we try to remove a symlink that is
231     not in protected path, but points to a protected path. Fix a memory leak in
232     sandbox.c (sandbox_pids_file in main()). Fix the realpath() calls in main()
233     (sandbox.c) being unchecked. Fix the debug logname not having the pid in it
234     (pid_string was uninitialized). General syntax cleanups.
235    
236 ferringb 34 09 Mar 2005; Brian Harring <ferringb@gentoo.org> sandbox.c: Fixed the
237     infamous "pids file is not a regular file" w/out newline bug.
238    
239 ferringb 33 09 Mar 2005; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in:
240     Correct libc_version path detection, since it was screwing up if libdir !=
241     "/lib/".
242    
243     02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
244 azarah 32 Hack to make sure sandboxed process cannot remove a device node, bug #79836.
245    
246 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am:
247 azarah 31 Fix symbols.in not added to dist.
248    
249 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
250 azarah 30 getcwd.c, libsandbox.c, sandbox.c, sandbox.h, sandbox_futils.c:
251     White space fixes.
252    
253 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
254 azarah 30 configure.in, getcwd.c, libsandbox.c, symbols.in:
255 azarah 29 Fix inverse test logic in canonicalize.c, use a strncpy. Fix gcc warning in
256     getcwd.c. Add symbols.in and logic to Makefile.am to generate symbol versions
257     for glibc and other libc's that use this. Update libsandbox.c to use these
258     symbol versions if available. Fix exec wrapper to re-export LD_PRELOAD if the
259     process unset it.
260    
261 ferringb 33 01 Mar 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
262 ferringb 28 killed off _init and _fini in favor of
263     void __attribute__ ((constructor)) init_func and
264     void __attribute__ ((destructor)) closing_func. _(init|func) were deprecated.
265    
266 ferringb 26 06 Dec 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, libsandbox.c,
267     canonicalize.c, getcwd.c: Fixed compilation *again*. Hopefully cvs is done
268     having the hick-ups.
269    
270 ferringb 24 04 Dec 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, getcwd.c,
271     Makefile.am: Fixed compilation.
272    
273 ferringb 18 01 Dec 2004; Brian Harring <ferringb@gentoo.org> aclocal.m4:
274     Gutted the bugger so it stops checking for a c++ and fortran compiler.
275     Do *not* regenerate aclocal.m4 for making a release until a better
276     solution is created.
277    
278 ferringb 16 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, sandbox_futils.c:
279     Removal of more hardcoded paths.
280    
281 ferringb 13 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in,
282     sandbox_futils.c: tweaks to install sandbox.bashrc, and use it.
283    
284     19 Nov 2004; Brian Harring <ferringb@gentoo.org>:
285 ferringb 6 Sandbox is now autotooled, create-localdecls needs to be killed and the code
286     shifted into configure.in. Currently builds *one* libsandbox.so- if multiple
287     are desired (-m64 and -m32 for amd64), the ebuild should do it (imo).
288     To get to a point of testing, automake && autoconf; created requisite files w/
289     a(utomake|clocal)-1.8, and autoconf 2.59. Installs to /usr/, instead of
290     /lib and /usr/lib/portage/bin.
291    
292 ferringb 2 14 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox.c:
293     closing out bug #70225, potential overflow of the sandbox_pids_file var.
294    
295     07 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c: c99 standard,
296     (think it was at least) allows intermixing of code and data segments. bug #70351
297     should be fixed by this.
298    
299     03 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox_futils.c:
300     futils fix from bug #65201 via solar, and libsandbox log path checks via #69137
301    
302     02 Aug 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Code from
303     Seth Robertson that tracked down all adjuct flags for read operations that
304     do not invoke a write operation.
305    
306     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
307     Another fix from jstubbs regarding a free() on a stack variable for the
308     environment -- tracking now prevents extraneous free()'s segfault.
309    
310     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
311     J. Stubbs tracked down a new bug where mkdir was failing to the patch on
312     the lstat in mkdir... it now only returns 0 or -1 as documented for mkdir.
313     Also remove the errno = ESUCCESS settings as documentation points out that
314     a library isn't allowed to do that.
315    
316     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Added a
317     file_security_check() function to check random potential exploits on files
318     that sandbox is to load and read -- Normally sandboxpids.tmp. This fixes
319     the 'system-crippling' exploits (bug 21923) and catches a few other
320     potential problems.
321    
322     20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> Makefile: Updates for
323     32/64 bit sandbox. Made CC and LD '?=' values to allow passed in CC to work.
324    
325     20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c:
326     bug 42048 -- Fixed the lstat/errno conditions for mkdir <caleb@g.o>.
327     Added the 64/32 bit sandbox patch for AMD64 bug 32963 <brad/azarah>.
328    
329     29 Feb 2004; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c :
330     Fix permissions and group of pids file and logs. Permissions should be 0664
331     and group should be 'portage'. Bug #34260.
332    
333     28 Feb 2004; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
334     Besides a small cleanup, redo how we replace LD_PRELOAD in the environ passed
335     to the real execve (in our execve wrapper). Seems that on some arches (sparc
336     among others) do not allow us to tamper with the readonly copy passed to
337     execve, so pass our own copy of the environment. Bug #42290.
338    
339     11 Jan 2004; Nicholas Jones <carpaski@gentoo.org> create-decls:
340     Changed tail to head and added a notice about duration of glibc check.
341    
342     21 Dec 2003; Nicholas Jones <carpaski@gentoo.org> create-decls:
343     Changed the glibc subversion check to use /usr/bin/* instead of /bin/sh
344     as there isn't a guarentee that it is dynamic.
345    
346     02 Nov 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
347     If 'file' passed to before_syscall(const char *func, const char *file) is
348     invalid, we should set errno to ENOENT, and not EINVAL. This should
349     close bug #32238.
350    
351     14 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
352     Fix a bug that occurs mainly on 64bit arch, where the file passed to
353     the functions we wrap, is invalid, and then cause canonicalize to pass
354     garbage to before_syscall(), thanks to great detective work from
355     Andrea Luzzardi <al@sig11.org> (bug #29846).
356    
357     13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
358     Add a uClibc detection patch from Peter S. Mazinger <ps.m@gmx.net>.
359    
360     13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
361     Fix a bug in libsandbox.c 's checking in the rename wrapper - it basically
362     only checked the destination patch, and not the source, so we could move
363     a protected file to a unprotected directory, and then delete/modify it.
364     Thanks to Andrea Luzzardi (scox) <al@sig11.org>, bug #30992, for this fix.
365    
366     12 Oct 2003; Nicholas Jones <carpaski@gentoo.org> sandbox.c :
367     Added python2.3 to the predict section/variable.
368    
369     28 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
370     sandbox.h, sandbox_futils.c :
371     Add support to set the pids file via SANDBOX_PIDS_FILE at startup. If
372     it is not set, it will revert to its old value.
373    
374     27 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
375     Fix our mkdir wrapper to check if the dir exist, and return EEXIST if so,
376     rather than failing with a violation, bug #29748.
377    
378     27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
379     Fix canonicalize() to ignore calls with path = "".
380    
381     27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c,
382     sandbox_futils.c, canonicalize.c :
383     Once again coreutils fails, as my systems had 2.5 kernel, the getcwd system
384     call handled strings larger than PATH_MAX (bug #21766). It however does not
385     work the same on 2.4 kernels.
386    
387     To fix, I added the posix implementation of getcwd() (from glibc cvs) that
388     do not need the system call. We use the default getcwd() function via a
389     wrapper (egetcwd), and then lstat the returned path. If lstat fails, it
390     means the current directory was removed, OR that the the system call for
391     getcwd failed (curious is that it do not fail and return NULL or set
392     errno, but rather just truncate the retured directory - usually from the
393     start), and if so, we use the generic getcwd() function (__egetcwd). Note
394     that we do not use the generic version all the time, as it calls lstat()
395     a great number of times, and performance degrade much.
396    
397     29 Jun 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls,
398     libsandbox.c :
399     Make sure SB_PATH_MAX will not wrap. Fix two possible memory leaks.
400    
401     22 Jun 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, canonicalize.c
402     create-localdecls :
403     When checking path names of files accessed, we need to canonicalize it, else
404     it may be a symlink in a 'write allowed' directory pointing to a file in a
405     directory we should not have write access to.
406    
407     With something like coreutils-5.0, we have two problems:
408     1) One of the tests checks if getcwd() can return a path longer than
409     PATH_MAX. This test then tries to create a dir which even while
410     created local (mkdir("conftest2")), it ends up being resolved with
411     a name that is much larger than PATH_MAX. The problem now is that
412     canonicalize() have undefined behaviour when the path was too long
413     (returned wrongly truncated paths, etc), and pass the wrong path to
414     before_syscall() (causing the bogus sandbox violations).
415     2) The ecanonicalize() function we used, along with the canonicalize()
416     function did not support longer than PATH_MAX. This is partly a
417     cause for 1), but the error checking (rather lack of it) of calls
418     to erealpath() in canonicalize() was the prime reason for 1).
419    
420     As we do not use this canonicalized name to call the function, we resolve this
421     by fixing canonicalize() to do better error checking, and ecanonicalize() as
422     well as all functions in libsandbox.c to use a PATH_MAX of 'PATH_MAX * 2'.
423     While they will resolve paths properly now, and can check if a write/read is
424     allowed, the functions called from the sandboxed environment will still work
425     as expected.
426    
427     This should resolve bug #21766.
428    
429     06 Apr 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
430     For some reason sandbox fails with a 'open_wr' if you run 'locale -a' under
431     it (bug #16298).
432    
433     Problem is that for some reason locale fopen's locale.alias with mode "rm".
434    
435     -------------------------------------------------------
436     nosferatu root # grep fopen locale.log
437     fopen("/usr/share/locale/locale.alias", "rm"ACCESS DENIED open_wr: /usr/share/locale/locale.alias
438     nosferatu root #
439     --------------------------------------------------------
440    
441     I checked the source of locale, but it have fopen with mode 'r', so
442     not sure where the "rm" mode comes from. Anyhow, changed the check in
443     before_syscall_open_char() to also see mode "rm" as readonly.
444    
445     23 Feb 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
446    
447     Add glibc-2.3 support.
448    
449     22 Feb 2003; Martin Schlemmer <azarah@gentoo.org> sandbox.c :
450    
451     Some /etc/ld.so.preload fixes. Just changed the #if defines to cover all
452     operations releated to preload, as well as only try to modify ld.so.preload
453     if we can. Also modify to write the pid to /tmp/sandboxpids.tmp even when
454     not using ld.so.preload. Fix to not write this instance of sandbox's pid
455     to /tmp/sandboxpids.tmp on exit if this is not the last sandbox running.
456    
457     22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> Makefile :
458    
459     Changed the LD to CC for hppa.
460    
461     22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
462    
463     Killed the previous changes I made.
464    
465     17 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
466    
467     Added parisc to BROKEN_RTLD_ARCHLIST to see if it we can fix the relocation probs.
468    
469     09 Jan 2003; J Robert Ray <jrray@gentoo.org> sandbox.c :
470    
471     Don't segfault if $HOME isn't set, set $HOME to "/" instead. Fixes bug 10868.
472    
473     16 Dec 2002; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
474    
475     Fix memory leak for mips, bug #12236. Thanks to Torgeir Hansen <torgeir@trenger.ro>
476     for this fix.
477    
478     4 Dec 2002; J Robert Ray <jrray@gentoo.org> sandbox.h sandbox_futils.c :
479    
480     sandbox_futils defined a dirname() function that was masking the same
481     function in glibc and was broken (e.g.: SANDBOX_DIR was being set to
482     '/usr/lib/portage/bi/'). Fixed function to return expected results and
483     renamed it to sb_dirname() to no longer mask the glibc function. Closes bug
484     11231.
485    
486     4 Dec 2002; Martin Schlemmer <azarah@gentoo.org> :
487    
488     Fix a segfault in libsandbox.c if canonicalize() was called with
489     first parameter = NULL.
490    
491     1 Sep 2002; Martin Schlemmer <azarah@gentoo.org> :
492    
493     Fix my braindead 'return 1;' in a void function. Updated sandbox.c,
494     cleanup() for this.
495    
496     Change cleanup() in sandbox.c not to exit with fail status if
497     the pidsfile is missing. We really should still display sandbox
498     violations if they occured.
499    
500     31 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
501    
502     Update cleanup() in sandbox.c to remove the PIDSFILE if this is
503     the last sandbox running.
504    
505     25 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
506    
507     Major cleanups to mainly libsandbox.c again.
508    
509     22 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
510    
511     Add copyrights to sandbox.h and sandbox_futils.h. If wrong, the
512     parties involved should please contact me so that we can fix it.
513    
514     Add opendir wrapper to libsandbox.c.
515    
516     21 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
517    
518     Do some more cleanups to ecanonicalize(), as it dropped filenames in
519     rare cases (after my symlink cleanups), and caused glibc to bork.
520     These fixes went into canonicalize.c.
521    
522     20 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
523    
524     Fix spawn_shell() and main() in sandbox.c to properly return fail
525     status.
526    
527     19 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
528    
529     The new canonicalize() function in libsandbox.c also resolved symlinks,
530     which caused on cleaning sandbox errors if the symlink pointed to a
531     file in the live root. Ripped out canonicalize() and realpath() from
532     glibc; removed the symlink stuff, and changed them to ecanonicalize()
533     and erealpath().
534    
535     18 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
536    
537     Ripped out all the wrappers, and implemented those of InstallWatch.
538     Losts of cleanups and bugfixes. Implement a execve that forces
539     $LIBSANDBOX in $LD_PRELOAD. We can now thus do away with the feared
540     /etc/ld.so.preload (*g*) ... Made the needed changes to sandbox.c,
541     sandbox.h and sandbox_futils.c. Rewrote the Makefile for most
542     parts; it now have an install target.
543    
544     Reformat the whole thing to look somewhat like the reworked sandbox.c
545     and new sandbox.h and sandbox_futils.c from:
546    
547     Brad House <brad@mainstreetsoftworks.com>.
548    
549     Additional Copyrights now due to the InstallWatch code:
550    
551     Copyright (C) 1998-9 Pancrazio `Ezio' de Mauro <p@demauro.net>

Properties

Name Value
svn:eol-style native
svn:keywords Author Date Id Revision

  ViewVC Help
Powered by ViewVC 1.1.20