/[path-sandbox]/trunk/ChangeLog
Gentoo

Contents of /trunk/ChangeLog

Parent Directory Parent Directory | Revision Log Revision Log


Revision 124 - (hide annotations) (download)
Fri Jun 17 12:32:02 2005 UTC (8 years, 10 months ago) by azarah
File size: 25290 byte(s)
Move get_sandbox_*_envvar() to sandbox_setup_environ(), as its more appropriate there.
1 ferringb 2 # ChangeLog for Path Sandbox
2 vapier 53 # Copyright 1999-2005 Gentoo Foundation; Distributed under the GPL v2
3 ferringb 2 # $Header$
4    
5 azarah 123 17 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
6     General cleanups:
7     - Remove fooling around with exit codes - we error out on presence of a log
8     anyhow.
9 azarah 124 - Move get_sandbox_*_envvar() to sandbox_setup_environ(), as its more
10     appropriate there.
11 azarah 123
12 azarah 121 12 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
13     Cleanup the fail_nametoolong stuff a bit more.
14    
15 azarah 118 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
16 azarah 120 Remove hopefully the last ld.so.preload bits we do not use anymore.
17    
18     11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
19 azarah 119 Remove the unneeded canonicalize() calls in the wrappers - we do it anyhow
20     in check_syscall(). Should speed things up a bit (at least for the getcwd()
21     and long path name test it goes down to under a second, and not 10+ seconds
22     like before). Also warn if we skip checking due to the canonicalized path
23     being too long.
24    
25     11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
26 azarah 118 More comment/readability cleanups.
27    
28 azarah 117 10 June 2005; Martin Schlemmer <azarah@gentoo.org> canonicalize.c, getcwd.c,
29     sandbox_futils.c, libsandbox.c:
30     Some strncpy/strncat and other cleanups.
31    
32 azarah 115 * sandbox-1.2.9 (2005/06/09)
33    
34 azarah 114 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
35     Move symlink hack down a bit to try and minimize on the amount of lstat()
36     calls we do.
37    
38 azarah 113 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
39     Add hack to allow writing to /proc/self/fd (or /dev/fd), bug #91516.
40    
41 azarah 112 09 June 2005; Martin Schlemmer <azarah@gentoo.org> symbols.in, libsandbox.c:
42     Add wrapper for access() function, bug #85413.
43    
44 azarah 111 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c:
45     Use generic getcwd() implementation from uclibc - should be more portable
46     and looks a bit cleaner.
47    
48 azarah 110 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c:
49     Make sure our true_* pointers are initialized to NULL, and that we check for
50     all references that they are valid.
51    
52 azarah 109 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
53     Be default we will fail if the path name we try to canonicalize is too long.
54     This however could cause issues with some things (bug #94630 and #21766), so
55     if fail_nametoolong == 0, canonicalize() will return a null length string and
56     do not fail.
57    
58 azarah 108 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c:
59     Do not abort if TMPDIR is not valid, but rather use '/tmp', bug #94360. Also
60     make sure we re-export the new TMPDIR environment variable.
61    
62 azarah 106 08 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
63     Fix incorrect free of non-malloc'd array, bug #92313 and #94020. Fix noted
64     by Marcus D. Hanwell <cryos@gentoo.org>.
65    
66 azarah 105 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
67     Add /dev/console to write list, bug #38588.
68    
69 azarah 102 * sandbox-1.2.8 (2005/05/13)
70    
71 azarah 99 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
72 azarah 101 sandbox.h, sandbox_futils.c:
73     General cleanups.
74    
75     13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
76 azarah 100 sandbox.h:
77     Various LD_PRELOAD cleanups. Do not unset LD_PRELOAD for parent.
78    
79     13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
80 azarah 99 sandbox.h, sandbox_futils.c:
81     Modify get_sandbox_pids_file(), get_sandbox_log() and get_sandbox_debug_log()
82     to use TMPDIR if present in environment.
83    
84 azarah 98 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
85     Remove sandbox_log_file from main() as its no longer used.
86    
87 azarah 97 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
88     sandbox_futils.c:
89     Add get_sandbox_debug_log(), and use it (add behaviour similar to SANDBOX_LOG
90     if already exported when sandbox started). Fix get_sandbox_log() and new
91     get_sandbox_debug_log() to not use already exported environment variables if
92     they have '/' in them. Use snprintf()'s instead of strncpy()'s. More
93     SB_PATH_MAX fixes.
94    
95 azarah 94 * sandbox-1.2.7 (2005/05/12)
96    
97 azarah 93 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
98     sandbox_futils.c:
99     More path limit fixes. Declare SB_BUF_LEN global and use it where needed.
100    
101 azarah 92 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
102     Fix paths limited to 255 chars. Fix get_sandbox_dir() returning a string
103     with '(null)' in it if we did not call sandbox with absolute path.
104    
105 azarah 89 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
106 azarah 91 Set SANDBOX_ON *before* doing the child's env stuff, else its not set
107     for the child.
108    
109     12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
110 azarah 90 Remove global preload_adaptable as it is no longer used.
111    
112     12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
113 azarah 89 Rewrite environment stuff to only be set when execve'ing the child process
114     to try and avoid issues like bug #91541 that causes sandbox to crash if
115     we set LD_PRELOAD sandbox side already.
116    
117 azarah 87 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
118 azarah 88 Move print_sandbox_log() up to make things neater.
119    
120     11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
121 azarah 87 Remove load_preload_libs(), as its not used anymore.
122    
123 azarah 83 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
124 azarah 86 Remove NO_FORK stuff, as its not used, and 'strace -f' works just fine.
125    
126     11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
127 azarah 84 Remove USE_SYSTEM_SHELL stuff, as it is not secure, and not in use.
128    
129     11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
130 azarah 83 Remove ld.so.preload crap - we are not going to use it again.
131    
132 azarah 82 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
133     Fix typo in code that checks if we got valid group information, causing a
134     segmentation fault, bug #91637.
135    
136 azarah 79 * sandbox-1.2.6 (2005/05/10)
137    
138 azarah 78 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
139     Do not use LD_PRELOAD if it contains libtsocks.so, as it breaks sandbox
140     for some odd reason, bug #91541.
141    
142 azarah 77 09 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
143     Fix typo (sizeof -> strlen).
144    
145 ferringb 76 08 May 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
146     rewrote the sbcontext caching code so it accounts for env changes since lib
147     initialization.
148    
149 azarah 75 05 May 2005; Martin Schlemmer <azarah@gentoo.org> configure.in, libctest.c:
150     We create libctest.c via configure, so no need to keep it around. Do some
151     cleanup related to libctest.c and libctest during configure.
152    
153 azarah 74 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
154     Add rename support of symlinks pointing to protected files/directories.
155    
156 azarah 72 * sandbox-1.2.5 (2005/05/04)
157    
158 azarah 71 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
159     sandbox.bashrc:
160     Do not reset already set LD_PRELOAD when starting sandbox. If LD_PRELOAD is
161     already set, init of the env vars fails for some reason, so do this later on,
162     and do not warn (bug #91431).
163    
164 azarah 70 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
165     sandbox.bashrc:
166     Fixup sandbox and sandbox.bashrc to call bash with the proper .bashrc.
167    
168 azarah 68 * sandbox-1.2.4 (2005/05/03)
169    
170 azarah 66 03 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
171     Do not init the env entries with each call, as it creates too many calls to
172 azarah 67 lstat, etc. Should speedup things a bit, bug #91040.
173 azarah 66
174 azarah 65 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
175     Add /dev/pty to default write list. Noticed by Morfic.
176    
177 vapier 62 02 May 2005; Mike Frysinger <vapier@gentoo.org> configure.in, localdecls.h,
178     sandbox.h:
179     uClibc doesn't support dlvsym() so add a configure check to make sure it doesn't
180     exist. Also update localdecls.h so BROKEN_RTLD_NEXT isn't defined in uClibc.
181    
182 azarah 59 * sandbox-1.2.3 (2005/04/29)
183    
184 azarah 56 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> configure.in:
185     Do not check for (*&#$(* CXX or F77.
186    
187 azarah 54 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
188     Do not append '/' to pathname in filter_path() if it already ends with it.
189    
190 vapier 53 28 Apr 2005; Mike Frysinger <vapier@gentoo.org> Makefile.am, configure.in:
191     With az's help, clean up autotools to work with cross-compiling.
192    
193 azarah 59 * sandbox-1.2.2 (2005/04/28)
194 azarah 48
195 azarah 47 28 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
196     Only check for /dev/{null,zero} for unlink hack, else ricers using /dev/shm
197     have issues; bug #90592.
198    
199 azarah 59 * sandbox-1.2.1 (2005/04/23)
200 azarah 44
201 azarah 43 23 Apr 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
202     getcwd.c, libsandbox.c, localdecls.h, sandbox.h, sandbox_futils.c:
203     Make sure all functions used in libsandbox.c is declared static. Define
204     SB_STATIC in localdecls.h for this. Include sandbox_futils.c rather than
205     linking with its object. Hopefully this will fix bug #90153.
206    
207 azarah 59 * sandbox-1.2 (2005/04/23)
208 azarah 46
209 azarah 40 22 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
210     Allow lchown a symlink in write-allowed path pointing to write-denied
211     target.
212    
213 genone 39 21 Mar 2005; Marius Mauch <genone@gentoo.org> libsandbox.c:
214     Also show resolved symlink names in the log.
215    
216 azarah 37 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, libsandbox.c:
217     Seems -nostdlib was the problem with the constructor/destructor - remove it
218     from Makefile.am, and change the constructor/destructor names again.
219    
220 azarah 36 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
221     Also rename the _init() and _fini() declarations.
222    
223 azarah 35 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
224     Fixup the constructor/destructor function names again (they should be _init()
225     and _fini() it seems, and not being called caused sandbox_lib_path to be
226     unset, and thus breaking the execve() wrapper's LD_PRELOAD protection).
227     Add both the path in given SANDBOX_x variable, as well as its symlink
228     resolved path in init_env_entries(). Modify filter_path() to be able to
229     resolve paths without resolving symlinks, as well as to be able to resolve
230     symlinks. Fix a possible segfault in check_access(). Add symlink resolving
231     to check_access() resolving bug #31019. Add 'hack' for unlink, as the fix
232     for bug #31019 cause access violations if we try to remove a symlink that is
233     not in protected path, but points to a protected path. Fix a memory leak in
234     sandbox.c (sandbox_pids_file in main()). Fix the realpath() calls in main()
235     (sandbox.c) being unchecked. Fix the debug logname not having the pid in it
236     (pid_string was uninitialized). General syntax cleanups.
237    
238 ferringb 34 09 Mar 2005; Brian Harring <ferringb@gentoo.org> sandbox.c: Fixed the
239     infamous "pids file is not a regular file" w/out newline bug.
240    
241 ferringb 33 09 Mar 2005; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in:
242     Correct libc_version path detection, since it was screwing up if libdir !=
243     "/lib/".
244    
245     02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
246 azarah 32 Hack to make sure sandboxed process cannot remove a device node, bug #79836.
247    
248 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am:
249 azarah 31 Fix symbols.in not added to dist.
250    
251 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
252 azarah 30 getcwd.c, libsandbox.c, sandbox.c, sandbox.h, sandbox_futils.c:
253     White space fixes.
254    
255 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
256 azarah 30 configure.in, getcwd.c, libsandbox.c, symbols.in:
257 azarah 29 Fix inverse test logic in canonicalize.c, use a strncpy. Fix gcc warning in
258     getcwd.c. Add symbols.in and logic to Makefile.am to generate symbol versions
259     for glibc and other libc's that use this. Update libsandbox.c to use these
260     symbol versions if available. Fix exec wrapper to re-export LD_PRELOAD if the
261     process unset it.
262    
263 ferringb 33 01 Mar 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
264 ferringb 28 killed off _init and _fini in favor of
265     void __attribute__ ((constructor)) init_func and
266     void __attribute__ ((destructor)) closing_func. _(init|func) were deprecated.
267    
268 ferringb 26 06 Dec 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, libsandbox.c,
269     canonicalize.c, getcwd.c: Fixed compilation *again*. Hopefully cvs is done
270     having the hick-ups.
271    
272 ferringb 24 04 Dec 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, getcwd.c,
273     Makefile.am: Fixed compilation.
274    
275 ferringb 18 01 Dec 2004; Brian Harring <ferringb@gentoo.org> aclocal.m4:
276     Gutted the bugger so it stops checking for a c++ and fortran compiler.
277     Do *not* regenerate aclocal.m4 for making a release until a better
278     solution is created.
279    
280 ferringb 16 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, sandbox_futils.c:
281     Removal of more hardcoded paths.
282    
283 ferringb 13 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in,
284     sandbox_futils.c: tweaks to install sandbox.bashrc, and use it.
285    
286     19 Nov 2004; Brian Harring <ferringb@gentoo.org>:
287 ferringb 6 Sandbox is now autotooled, create-localdecls needs to be killed and the code
288     shifted into configure.in. Currently builds *one* libsandbox.so- if multiple
289     are desired (-m64 and -m32 for amd64), the ebuild should do it (imo).
290     To get to a point of testing, automake && autoconf; created requisite files w/
291     a(utomake|clocal)-1.8, and autoconf 2.59. Installs to /usr/, instead of
292     /lib and /usr/lib/portage/bin.
293    
294 ferringb 2 14 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox.c:
295     closing out bug #70225, potential overflow of the sandbox_pids_file var.
296    
297     07 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c: c99 standard,
298     (think it was at least) allows intermixing of code and data segments. bug #70351
299     should be fixed by this.
300    
301     03 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox_futils.c:
302     futils fix from bug #65201 via solar, and libsandbox log path checks via #69137
303    
304     02 Aug 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Code from
305     Seth Robertson that tracked down all adjuct flags for read operations that
306     do not invoke a write operation.
307    
308     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
309     Another fix from jstubbs regarding a free() on a stack variable for the
310     environment -- tracking now prevents extraneous free()'s segfault.
311    
312     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
313     J. Stubbs tracked down a new bug where mkdir was failing to the patch on
314     the lstat in mkdir... it now only returns 0 or -1 as documented for mkdir.
315     Also remove the errno = ESUCCESS settings as documentation points out that
316     a library isn't allowed to do that.
317    
318     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Added a
319     file_security_check() function to check random potential exploits on files
320     that sandbox is to load and read -- Normally sandboxpids.tmp. This fixes
321     the 'system-crippling' exploits (bug 21923) and catches a few other
322     potential problems.
323    
324     20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> Makefile: Updates for
325     32/64 bit sandbox. Made CC and LD '?=' values to allow passed in CC to work.
326    
327     20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c:
328     bug 42048 -- Fixed the lstat/errno conditions for mkdir <caleb@g.o>.
329     Added the 64/32 bit sandbox patch for AMD64 bug 32963 <brad/azarah>.
330    
331     29 Feb 2004; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c :
332     Fix permissions and group of pids file and logs. Permissions should be 0664
333     and group should be 'portage'. Bug #34260.
334    
335     28 Feb 2004; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
336     Besides a small cleanup, redo how we replace LD_PRELOAD in the environ passed
337     to the real execve (in our execve wrapper). Seems that on some arches (sparc
338     among others) do not allow us to tamper with the readonly copy passed to
339     execve, so pass our own copy of the environment. Bug #42290.
340    
341     11 Jan 2004; Nicholas Jones <carpaski@gentoo.org> create-decls:
342     Changed tail to head and added a notice about duration of glibc check.
343    
344     21 Dec 2003; Nicholas Jones <carpaski@gentoo.org> create-decls:
345     Changed the glibc subversion check to use /usr/bin/* instead of /bin/sh
346     as there isn't a guarentee that it is dynamic.
347    
348     02 Nov 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
349     If 'file' passed to before_syscall(const char *func, const char *file) is
350     invalid, we should set errno to ENOENT, and not EINVAL. This should
351     close bug #32238.
352    
353     14 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
354     Fix a bug that occurs mainly on 64bit arch, where the file passed to
355     the functions we wrap, is invalid, and then cause canonicalize to pass
356     garbage to before_syscall(), thanks to great detective work from
357     Andrea Luzzardi <al@sig11.org> (bug #29846).
358    
359     13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
360     Add a uClibc detection patch from Peter S. Mazinger <ps.m@gmx.net>.
361    
362     13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
363     Fix a bug in libsandbox.c 's checking in the rename wrapper - it basically
364     only checked the destination patch, and not the source, so we could move
365     a protected file to a unprotected directory, and then delete/modify it.
366     Thanks to Andrea Luzzardi (scox) <al@sig11.org>, bug #30992, for this fix.
367    
368     12 Oct 2003; Nicholas Jones <carpaski@gentoo.org> sandbox.c :
369     Added python2.3 to the predict section/variable.
370    
371     28 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
372     sandbox.h, sandbox_futils.c :
373     Add support to set the pids file via SANDBOX_PIDS_FILE at startup. If
374     it is not set, it will revert to its old value.
375    
376     27 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
377     Fix our mkdir wrapper to check if the dir exist, and return EEXIST if so,
378     rather than failing with a violation, bug #29748.
379    
380     27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
381     Fix canonicalize() to ignore calls with path = "".
382    
383     27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c,
384     sandbox_futils.c, canonicalize.c :
385     Once again coreutils fails, as my systems had 2.5 kernel, the getcwd system
386     call handled strings larger than PATH_MAX (bug #21766). It however does not
387     work the same on 2.4 kernels.
388    
389     To fix, I added the posix implementation of getcwd() (from glibc cvs) that
390     do not need the system call. We use the default getcwd() function via a
391     wrapper (egetcwd), and then lstat the returned path. If lstat fails, it
392     means the current directory was removed, OR that the the system call for
393     getcwd failed (curious is that it do not fail and return NULL or set
394     errno, but rather just truncate the retured directory - usually from the
395     start), and if so, we use the generic getcwd() function (__egetcwd). Note
396     that we do not use the generic version all the time, as it calls lstat()
397     a great number of times, and performance degrade much.
398    
399     29 Jun 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls,
400     libsandbox.c :
401     Make sure SB_PATH_MAX will not wrap. Fix two possible memory leaks.
402    
403     22 Jun 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, canonicalize.c
404     create-localdecls :
405     When checking path names of files accessed, we need to canonicalize it, else
406     it may be a symlink in a 'write allowed' directory pointing to a file in a
407     directory we should not have write access to.
408    
409     With something like coreutils-5.0, we have two problems:
410     1) One of the tests checks if getcwd() can return a path longer than
411     PATH_MAX. This test then tries to create a dir which even while
412     created local (mkdir("conftest2")), it ends up being resolved with
413     a name that is much larger than PATH_MAX. The problem now is that
414     canonicalize() have undefined behaviour when the path was too long
415     (returned wrongly truncated paths, etc), and pass the wrong path to
416     before_syscall() (causing the bogus sandbox violations).
417     2) The ecanonicalize() function we used, along with the canonicalize()
418     function did not support longer than PATH_MAX. This is partly a
419     cause for 1), but the error checking (rather lack of it) of calls
420     to erealpath() in canonicalize() was the prime reason for 1).
421    
422     As we do not use this canonicalized name to call the function, we resolve this
423     by fixing canonicalize() to do better error checking, and ecanonicalize() as
424     well as all functions in libsandbox.c to use a PATH_MAX of 'PATH_MAX * 2'.
425     While they will resolve paths properly now, and can check if a write/read is
426     allowed, the functions called from the sandboxed environment will still work
427     as expected.
428    
429     This should resolve bug #21766.
430    
431     06 Apr 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
432     For some reason sandbox fails with a 'open_wr' if you run 'locale -a' under
433     it (bug #16298).
434    
435     Problem is that for some reason locale fopen's locale.alias with mode "rm".
436    
437     -------------------------------------------------------
438     nosferatu root # grep fopen locale.log
439     fopen("/usr/share/locale/locale.alias", "rm"ACCESS DENIED open_wr: /usr/share/locale/locale.alias
440     nosferatu root #
441     --------------------------------------------------------
442    
443     I checked the source of locale, but it have fopen with mode 'r', so
444     not sure where the "rm" mode comes from. Anyhow, changed the check in
445     before_syscall_open_char() to also see mode "rm" as readonly.
446    
447     23 Feb 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
448    
449     Add glibc-2.3 support.
450    
451     22 Feb 2003; Martin Schlemmer <azarah@gentoo.org> sandbox.c :
452    
453     Some /etc/ld.so.preload fixes. Just changed the #if defines to cover all
454     operations releated to preload, as well as only try to modify ld.so.preload
455     if we can. Also modify to write the pid to /tmp/sandboxpids.tmp even when
456     not using ld.so.preload. Fix to not write this instance of sandbox's pid
457     to /tmp/sandboxpids.tmp on exit if this is not the last sandbox running.
458    
459     22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> Makefile :
460    
461     Changed the LD to CC for hppa.
462    
463     22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
464    
465     Killed the previous changes I made.
466    
467     17 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
468    
469     Added parisc to BROKEN_RTLD_ARCHLIST to see if it we can fix the relocation probs.
470    
471     09 Jan 2003; J Robert Ray <jrray@gentoo.org> sandbox.c :
472    
473     Don't segfault if $HOME isn't set, set $HOME to "/" instead. Fixes bug 10868.
474    
475     16 Dec 2002; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
476    
477     Fix memory leak for mips, bug #12236. Thanks to Torgeir Hansen <torgeir@trenger.ro>
478     for this fix.
479    
480     4 Dec 2002; J Robert Ray <jrray@gentoo.org> sandbox.h sandbox_futils.c :
481    
482     sandbox_futils defined a dirname() function that was masking the same
483     function in glibc and was broken (e.g.: SANDBOX_DIR was being set to
484     '/usr/lib/portage/bi/'). Fixed function to return expected results and
485     renamed it to sb_dirname() to no longer mask the glibc function. Closes bug
486     11231.
487    
488     4 Dec 2002; Martin Schlemmer <azarah@gentoo.org> :
489    
490     Fix a segfault in libsandbox.c if canonicalize() was called with
491     first parameter = NULL.
492    
493     1 Sep 2002; Martin Schlemmer <azarah@gentoo.org> :
494    
495     Fix my braindead 'return 1;' in a void function. Updated sandbox.c,
496     cleanup() for this.
497    
498     Change cleanup() in sandbox.c not to exit with fail status if
499     the pidsfile is missing. We really should still display sandbox
500     violations if they occured.
501    
502     31 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
503    
504     Update cleanup() in sandbox.c to remove the PIDSFILE if this is
505     the last sandbox running.
506    
507     25 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
508    
509     Major cleanups to mainly libsandbox.c again.
510    
511     22 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
512    
513     Add copyrights to sandbox.h and sandbox_futils.h. If wrong, the
514     parties involved should please contact me so that we can fix it.
515    
516     Add opendir wrapper to libsandbox.c.
517    
518     21 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
519    
520     Do some more cleanups to ecanonicalize(), as it dropped filenames in
521     rare cases (after my symlink cleanups), and caused glibc to bork.
522     These fixes went into canonicalize.c.
523    
524     20 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
525    
526     Fix spawn_shell() and main() in sandbox.c to properly return fail
527     status.
528    
529     19 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
530    
531     The new canonicalize() function in libsandbox.c also resolved symlinks,
532     which caused on cleaning sandbox errors if the symlink pointed to a
533     file in the live root. Ripped out canonicalize() and realpath() from
534     glibc; removed the symlink stuff, and changed them to ecanonicalize()
535     and erealpath().
536    
537     18 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
538    
539     Ripped out all the wrappers, and implemented those of InstallWatch.
540     Losts of cleanups and bugfixes. Implement a execve that forces
541     $LIBSANDBOX in $LD_PRELOAD. We can now thus do away with the feared
542     /etc/ld.so.preload (*g*) ... Made the needed changes to sandbox.c,
543     sandbox.h and sandbox_futils.c. Rewrote the Makefile for most
544     parts; it now have an install target.
545    
546     Reformat the whole thing to look somewhat like the reworked sandbox.c
547     and new sandbox.h and sandbox_futils.c from:
548    
549     Brad House <brad@mainstreetsoftworks.com>.
550    
551     Additional Copyrights now due to the InstallWatch code:
552    
553     Copyright (C) 1998-9 Pancrazio `Ezio' de Mauro <p@demauro.net>

Properties

Name Value
svn:eol-style native
svn:keywords Author Date Id Revision

  ViewVC Help
Powered by ViewVC 1.1.20