/[path-sandbox]/trunk/ChangeLog
Gentoo

Contents of /trunk/ChangeLog

Parent Directory Parent Directory | Revision Log Revision Log


Revision 134 - (hide annotations) (download)
Wed Jul 6 17:35:30 2005 UTC (9 years, 2 months ago) by azarah
File size: 25798 byte(s)
Change log dir to /var/log/sandbox/.  Make sure the sandboxed process cannot write to it.
1 ferringb 2 # ChangeLog for Path Sandbox
2 vapier 53 # Copyright 1999-2005 Gentoo Foundation; Distributed under the GPL v2
3 ferringb 2 # $Header$
4    
5 azarah 134 06 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.h, sandbox_futils.c,
6     libsandbox.c:
7     - Change log dir to /var/log/sandbox/. Make sure the sandboxed process cannot
8     write to it.
9    
10 azarah 133 05 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
11     sandbox_futils.c, libsandbox.c:
12     Remove unused 'pids file' code.
13    
14 azarah 128 * sandbox-1.2.10 (2005/07/03)
15    
16 azarah 126 03 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
17     Add PREDICT items for nss-db, bug #92079. Patch from Robin Johnson.
18    
19 azarah 123 17 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
20     General cleanups:
21     - Remove fooling around with exit codes - we error out on presence of a log
22     anyhow.
23 azarah 124 - Move get_sandbox_*_envvar() to sandbox_setup_environ(), as its more
24     appropriate there.
25 azarah 123
26 azarah 121 12 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
27     Cleanup the fail_nametoolong stuff a bit more.
28    
29 azarah 118 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
30 azarah 120 Remove hopefully the last ld.so.preload bits we do not use anymore.
31    
32     11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
33 azarah 119 Remove the unneeded canonicalize() calls in the wrappers - we do it anyhow
34     in check_syscall(). Should speed things up a bit (at least for the getcwd()
35     and long path name test it goes down to under a second, and not 10+ seconds
36     like before). Also warn if we skip checking due to the canonicalized path
37     being too long.
38    
39     11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
40 azarah 118 More comment/readability cleanups.
41    
42 azarah 117 10 June 2005; Martin Schlemmer <azarah@gentoo.org> canonicalize.c, getcwd.c,
43     sandbox_futils.c, libsandbox.c:
44     Some strncpy/strncat and other cleanups.
45    
46 azarah 115 * sandbox-1.2.9 (2005/06/09)
47    
48 azarah 114 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
49     Move symlink hack down a bit to try and minimize on the amount of lstat()
50     calls we do.
51    
52 azarah 113 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
53     Add hack to allow writing to /proc/self/fd (or /dev/fd), bug #91516.
54    
55 azarah 112 09 June 2005; Martin Schlemmer <azarah@gentoo.org> symbols.in, libsandbox.c:
56     Add wrapper for access() function, bug #85413.
57    
58 azarah 111 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c:
59     Use generic getcwd() implementation from uclibc - should be more portable
60     and looks a bit cleaner.
61    
62 azarah 110 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c:
63     Make sure our true_* pointers are initialized to NULL, and that we check for
64     all references that they are valid.
65    
66 azarah 109 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
67     Be default we will fail if the path name we try to canonicalize is too long.
68     This however could cause issues with some things (bug #94630 and #21766), so
69     if fail_nametoolong == 0, canonicalize() will return a null length string and
70     do not fail.
71    
72 azarah 108 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c:
73     Do not abort if TMPDIR is not valid, but rather use '/tmp', bug #94360. Also
74     make sure we re-export the new TMPDIR environment variable.
75    
76 azarah 106 08 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
77     Fix incorrect free of non-malloc'd array, bug #92313 and #94020. Fix noted
78     by Marcus D. Hanwell <cryos@gentoo.org>.
79    
80 azarah 105 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
81     Add /dev/console to write list, bug #38588.
82    
83 azarah 102 * sandbox-1.2.8 (2005/05/13)
84    
85 azarah 99 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
86 azarah 101 sandbox.h, sandbox_futils.c:
87     General cleanups.
88    
89     13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
90 azarah 100 sandbox.h:
91     Various LD_PRELOAD cleanups. Do not unset LD_PRELOAD for parent.
92    
93     13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
94 azarah 99 sandbox.h, sandbox_futils.c:
95     Modify get_sandbox_pids_file(), get_sandbox_log() and get_sandbox_debug_log()
96     to use TMPDIR if present in environment.
97    
98 azarah 98 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
99     Remove sandbox_log_file from main() as its no longer used.
100    
101 azarah 97 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
102     sandbox_futils.c:
103     Add get_sandbox_debug_log(), and use it (add behaviour similar to SANDBOX_LOG
104     if already exported when sandbox started). Fix get_sandbox_log() and new
105     get_sandbox_debug_log() to not use already exported environment variables if
106     they have '/' in them. Use snprintf()'s instead of strncpy()'s. More
107     SB_PATH_MAX fixes.
108    
109 azarah 94 * sandbox-1.2.7 (2005/05/12)
110    
111 azarah 93 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
112     sandbox_futils.c:
113     More path limit fixes. Declare SB_BUF_LEN global and use it where needed.
114    
115 azarah 92 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
116     Fix paths limited to 255 chars. Fix get_sandbox_dir() returning a string
117     with '(null)' in it if we did not call sandbox with absolute path.
118    
119 azarah 89 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
120 azarah 91 Set SANDBOX_ON *before* doing the child's env stuff, else its not set
121     for the child.
122    
123     12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
124 azarah 90 Remove global preload_adaptable as it is no longer used.
125    
126     12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
127 azarah 89 Rewrite environment stuff to only be set when execve'ing the child process
128     to try and avoid issues like bug #91541 that causes sandbox to crash if
129     we set LD_PRELOAD sandbox side already.
130    
131 azarah 87 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
132 azarah 88 Move print_sandbox_log() up to make things neater.
133    
134     11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
135 azarah 87 Remove load_preload_libs(), as its not used anymore.
136    
137 azarah 83 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
138 azarah 86 Remove NO_FORK stuff, as its not used, and 'strace -f' works just fine.
139    
140     11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
141 azarah 84 Remove USE_SYSTEM_SHELL stuff, as it is not secure, and not in use.
142    
143     11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
144 azarah 83 Remove ld.so.preload crap - we are not going to use it again.
145    
146 azarah 82 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
147     Fix typo in code that checks if we got valid group information, causing a
148     segmentation fault, bug #91637.
149    
150 azarah 79 * sandbox-1.2.6 (2005/05/10)
151    
152 azarah 78 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
153     Do not use LD_PRELOAD if it contains libtsocks.so, as it breaks sandbox
154     for some odd reason, bug #91541.
155    
156 azarah 77 09 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
157     Fix typo (sizeof -> strlen).
158    
159 ferringb 76 08 May 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
160     rewrote the sbcontext caching code so it accounts for env changes since lib
161     initialization.
162    
163 azarah 75 05 May 2005; Martin Schlemmer <azarah@gentoo.org> configure.in, libctest.c:
164     We create libctest.c via configure, so no need to keep it around. Do some
165     cleanup related to libctest.c and libctest during configure.
166    
167 azarah 74 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
168     Add rename support of symlinks pointing to protected files/directories.
169    
170 azarah 72 * sandbox-1.2.5 (2005/05/04)
171    
172 azarah 71 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
173     sandbox.bashrc:
174     Do not reset already set LD_PRELOAD when starting sandbox. If LD_PRELOAD is
175     already set, init of the env vars fails for some reason, so do this later on,
176     and do not warn (bug #91431).
177    
178 azarah 70 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
179     sandbox.bashrc:
180     Fixup sandbox and sandbox.bashrc to call bash with the proper .bashrc.
181    
182 azarah 68 * sandbox-1.2.4 (2005/05/03)
183    
184 azarah 66 03 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
185     Do not init the env entries with each call, as it creates too many calls to
186 azarah 67 lstat, etc. Should speedup things a bit, bug #91040.
187 azarah 66
188 azarah 65 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
189     Add /dev/pty to default write list. Noticed by Morfic.
190    
191 vapier 62 02 May 2005; Mike Frysinger <vapier@gentoo.org> configure.in, localdecls.h,
192     sandbox.h:
193     uClibc doesn't support dlvsym() so add a configure check to make sure it doesn't
194     exist. Also update localdecls.h so BROKEN_RTLD_NEXT isn't defined in uClibc.
195    
196 azarah 59 * sandbox-1.2.3 (2005/04/29)
197    
198 azarah 56 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> configure.in:
199     Do not check for (*&#$(* CXX or F77.
200    
201 azarah 54 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
202     Do not append '/' to pathname in filter_path() if it already ends with it.
203    
204 vapier 53 28 Apr 2005; Mike Frysinger <vapier@gentoo.org> Makefile.am, configure.in:
205     With az's help, clean up autotools to work with cross-compiling.
206    
207 azarah 59 * sandbox-1.2.2 (2005/04/28)
208 azarah 48
209 azarah 47 28 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
210     Only check for /dev/{null,zero} for unlink hack, else ricers using /dev/shm
211     have issues; bug #90592.
212    
213 azarah 59 * sandbox-1.2.1 (2005/04/23)
214 azarah 44
215 azarah 43 23 Apr 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
216     getcwd.c, libsandbox.c, localdecls.h, sandbox.h, sandbox_futils.c:
217     Make sure all functions used in libsandbox.c is declared static. Define
218     SB_STATIC in localdecls.h for this. Include sandbox_futils.c rather than
219     linking with its object. Hopefully this will fix bug #90153.
220    
221 azarah 59 * sandbox-1.2 (2005/04/23)
222 azarah 46
223 azarah 40 22 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
224     Allow lchown a symlink in write-allowed path pointing to write-denied
225     target.
226    
227 genone 39 21 Mar 2005; Marius Mauch <genone@gentoo.org> libsandbox.c:
228     Also show resolved symlink names in the log.
229    
230 azarah 37 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, libsandbox.c:
231     Seems -nostdlib was the problem with the constructor/destructor - remove it
232     from Makefile.am, and change the constructor/destructor names again.
233    
234 azarah 36 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
235     Also rename the _init() and _fini() declarations.
236    
237 azarah 35 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
238     Fixup the constructor/destructor function names again (they should be _init()
239     and _fini() it seems, and not being called caused sandbox_lib_path to be
240     unset, and thus breaking the execve() wrapper's LD_PRELOAD protection).
241     Add both the path in given SANDBOX_x variable, as well as its symlink
242     resolved path in init_env_entries(). Modify filter_path() to be able to
243     resolve paths without resolving symlinks, as well as to be able to resolve
244     symlinks. Fix a possible segfault in check_access(). Add symlink resolving
245     to check_access() resolving bug #31019. Add 'hack' for unlink, as the fix
246     for bug #31019 cause access violations if we try to remove a symlink that is
247     not in protected path, but points to a protected path. Fix a memory leak in
248     sandbox.c (sandbox_pids_file in main()). Fix the realpath() calls in main()
249     (sandbox.c) being unchecked. Fix the debug logname not having the pid in it
250     (pid_string was uninitialized). General syntax cleanups.
251    
252 ferringb 34 09 Mar 2005; Brian Harring <ferringb@gentoo.org> sandbox.c: Fixed the
253     infamous "pids file is not a regular file" w/out newline bug.
254    
255 ferringb 33 09 Mar 2005; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in:
256     Correct libc_version path detection, since it was screwing up if libdir !=
257     "/lib/".
258    
259     02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
260 azarah 32 Hack to make sure sandboxed process cannot remove a device node, bug #79836.
261    
262 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am:
263 azarah 31 Fix symbols.in not added to dist.
264    
265 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
266 azarah 30 getcwd.c, libsandbox.c, sandbox.c, sandbox.h, sandbox_futils.c:
267     White space fixes.
268    
269 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
270 azarah 30 configure.in, getcwd.c, libsandbox.c, symbols.in:
271 azarah 29 Fix inverse test logic in canonicalize.c, use a strncpy. Fix gcc warning in
272     getcwd.c. Add symbols.in and logic to Makefile.am to generate symbol versions
273     for glibc and other libc's that use this. Update libsandbox.c to use these
274     symbol versions if available. Fix exec wrapper to re-export LD_PRELOAD if the
275     process unset it.
276    
277 ferringb 33 01 Mar 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
278 ferringb 28 killed off _init and _fini in favor of
279     void __attribute__ ((constructor)) init_func and
280     void __attribute__ ((destructor)) closing_func. _(init|func) were deprecated.
281    
282 ferringb 26 06 Dec 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, libsandbox.c,
283     canonicalize.c, getcwd.c: Fixed compilation *again*. Hopefully cvs is done
284     having the hick-ups.
285    
286 ferringb 24 04 Dec 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, getcwd.c,
287     Makefile.am: Fixed compilation.
288    
289 ferringb 18 01 Dec 2004; Brian Harring <ferringb@gentoo.org> aclocal.m4:
290     Gutted the bugger so it stops checking for a c++ and fortran compiler.
291     Do *not* regenerate aclocal.m4 for making a release until a better
292     solution is created.
293    
294 ferringb 16 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, sandbox_futils.c:
295     Removal of more hardcoded paths.
296    
297 ferringb 13 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in,
298     sandbox_futils.c: tweaks to install sandbox.bashrc, and use it.
299    
300     19 Nov 2004; Brian Harring <ferringb@gentoo.org>:
301 ferringb 6 Sandbox is now autotooled, create-localdecls needs to be killed and the code
302     shifted into configure.in. Currently builds *one* libsandbox.so- if multiple
303     are desired (-m64 and -m32 for amd64), the ebuild should do it (imo).
304     To get to a point of testing, automake && autoconf; created requisite files w/
305     a(utomake|clocal)-1.8, and autoconf 2.59. Installs to /usr/, instead of
306     /lib and /usr/lib/portage/bin.
307    
308 ferringb 2 14 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox.c:
309     closing out bug #70225, potential overflow of the sandbox_pids_file var.
310    
311     07 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c: c99 standard,
312     (think it was at least) allows intermixing of code and data segments. bug #70351
313     should be fixed by this.
314    
315     03 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox_futils.c:
316     futils fix from bug #65201 via solar, and libsandbox log path checks via #69137
317    
318     02 Aug 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Code from
319     Seth Robertson that tracked down all adjuct flags for read operations that
320     do not invoke a write operation.
321    
322     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
323     Another fix from jstubbs regarding a free() on a stack variable for the
324     environment -- tracking now prevents extraneous free()'s segfault.
325    
326     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
327     J. Stubbs tracked down a new bug where mkdir was failing to the patch on
328     the lstat in mkdir... it now only returns 0 or -1 as documented for mkdir.
329     Also remove the errno = ESUCCESS settings as documentation points out that
330     a library isn't allowed to do that.
331    
332     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Added a
333     file_security_check() function to check random potential exploits on files
334     that sandbox is to load and read -- Normally sandboxpids.tmp. This fixes
335     the 'system-crippling' exploits (bug 21923) and catches a few other
336     potential problems.
337    
338     20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> Makefile: Updates for
339     32/64 bit sandbox. Made CC and LD '?=' values to allow passed in CC to work.
340    
341     20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c:
342     bug 42048 -- Fixed the lstat/errno conditions for mkdir <caleb@g.o>.
343     Added the 64/32 bit sandbox patch for AMD64 bug 32963 <brad/azarah>.
344    
345     29 Feb 2004; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c :
346     Fix permissions and group of pids file and logs. Permissions should be 0664
347     and group should be 'portage'. Bug #34260.
348    
349     28 Feb 2004; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
350     Besides a small cleanup, redo how we replace LD_PRELOAD in the environ passed
351     to the real execve (in our execve wrapper). Seems that on some arches (sparc
352     among others) do not allow us to tamper with the readonly copy passed to
353     execve, so pass our own copy of the environment. Bug #42290.
354    
355     11 Jan 2004; Nicholas Jones <carpaski@gentoo.org> create-decls:
356     Changed tail to head and added a notice about duration of glibc check.
357    
358     21 Dec 2003; Nicholas Jones <carpaski@gentoo.org> create-decls:
359     Changed the glibc subversion check to use /usr/bin/* instead of /bin/sh
360     as there isn't a guarentee that it is dynamic.
361    
362     02 Nov 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
363     If 'file' passed to before_syscall(const char *func, const char *file) is
364     invalid, we should set errno to ENOENT, and not EINVAL. This should
365     close bug #32238.
366    
367     14 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
368     Fix a bug that occurs mainly on 64bit arch, where the file passed to
369     the functions we wrap, is invalid, and then cause canonicalize to pass
370     garbage to before_syscall(), thanks to great detective work from
371     Andrea Luzzardi <al@sig11.org> (bug #29846).
372    
373     13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
374     Add a uClibc detection patch from Peter S. Mazinger <ps.m@gmx.net>.
375    
376     13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
377     Fix a bug in libsandbox.c 's checking in the rename wrapper - it basically
378     only checked the destination patch, and not the source, so we could move
379     a protected file to a unprotected directory, and then delete/modify it.
380     Thanks to Andrea Luzzardi (scox) <al@sig11.org>, bug #30992, for this fix.
381    
382     12 Oct 2003; Nicholas Jones <carpaski@gentoo.org> sandbox.c :
383     Added python2.3 to the predict section/variable.
384    
385     28 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
386     sandbox.h, sandbox_futils.c :
387     Add support to set the pids file via SANDBOX_PIDS_FILE at startup. If
388     it is not set, it will revert to its old value.
389    
390     27 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
391     Fix our mkdir wrapper to check if the dir exist, and return EEXIST if so,
392     rather than failing with a violation, bug #29748.
393    
394     27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
395     Fix canonicalize() to ignore calls with path = "".
396    
397     27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c,
398     sandbox_futils.c, canonicalize.c :
399     Once again coreutils fails, as my systems had 2.5 kernel, the getcwd system
400     call handled strings larger than PATH_MAX (bug #21766). It however does not
401     work the same on 2.4 kernels.
402    
403     To fix, I added the posix implementation of getcwd() (from glibc cvs) that
404     do not need the system call. We use the default getcwd() function via a
405     wrapper (egetcwd), and then lstat the returned path. If lstat fails, it
406     means the current directory was removed, OR that the the system call for
407     getcwd failed (curious is that it do not fail and return NULL or set
408     errno, but rather just truncate the retured directory - usually from the
409     start), and if so, we use the generic getcwd() function (__egetcwd). Note
410     that we do not use the generic version all the time, as it calls lstat()
411     a great number of times, and performance degrade much.
412    
413     29 Jun 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls,
414     libsandbox.c :
415     Make sure SB_PATH_MAX will not wrap. Fix two possible memory leaks.
416    
417     22 Jun 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, canonicalize.c
418     create-localdecls :
419     When checking path names of files accessed, we need to canonicalize it, else
420     it may be a symlink in a 'write allowed' directory pointing to a file in a
421     directory we should not have write access to.
422    
423     With something like coreutils-5.0, we have two problems:
424     1) One of the tests checks if getcwd() can return a path longer than
425     PATH_MAX. This test then tries to create a dir which even while
426     created local (mkdir("conftest2")), it ends up being resolved with
427     a name that is much larger than PATH_MAX. The problem now is that
428     canonicalize() have undefined behaviour when the path was too long
429     (returned wrongly truncated paths, etc), and pass the wrong path to
430     before_syscall() (causing the bogus sandbox violations).
431     2) The ecanonicalize() function we used, along with the canonicalize()
432     function did not support longer than PATH_MAX. This is partly a
433     cause for 1), but the error checking (rather lack of it) of calls
434     to erealpath() in canonicalize() was the prime reason for 1).
435    
436     As we do not use this canonicalized name to call the function, we resolve this
437     by fixing canonicalize() to do better error checking, and ecanonicalize() as
438     well as all functions in libsandbox.c to use a PATH_MAX of 'PATH_MAX * 2'.
439     While they will resolve paths properly now, and can check if a write/read is
440     allowed, the functions called from the sandboxed environment will still work
441     as expected.
442    
443     This should resolve bug #21766.
444    
445     06 Apr 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
446     For some reason sandbox fails with a 'open_wr' if you run 'locale -a' under
447     it (bug #16298).
448    
449     Problem is that for some reason locale fopen's locale.alias with mode "rm".
450    
451     -------------------------------------------------------
452     nosferatu root # grep fopen locale.log
453     fopen("/usr/share/locale/locale.alias", "rm"ACCESS DENIED open_wr: /usr/share/locale/locale.alias
454     nosferatu root #
455     --------------------------------------------------------
456    
457     I checked the source of locale, but it have fopen with mode 'r', so
458     not sure where the "rm" mode comes from. Anyhow, changed the check in
459     before_syscall_open_char() to also see mode "rm" as readonly.
460    
461     23 Feb 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
462    
463     Add glibc-2.3 support.
464    
465     22 Feb 2003; Martin Schlemmer <azarah@gentoo.org> sandbox.c :
466    
467     Some /etc/ld.so.preload fixes. Just changed the #if defines to cover all
468     operations releated to preload, as well as only try to modify ld.so.preload
469     if we can. Also modify to write the pid to /tmp/sandboxpids.tmp even when
470     not using ld.so.preload. Fix to not write this instance of sandbox's pid
471     to /tmp/sandboxpids.tmp on exit if this is not the last sandbox running.
472    
473     22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> Makefile :
474    
475     Changed the LD to CC for hppa.
476    
477     22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
478    
479     Killed the previous changes I made.
480    
481     17 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
482    
483     Added parisc to BROKEN_RTLD_ARCHLIST to see if it we can fix the relocation probs.
484    
485     09 Jan 2003; J Robert Ray <jrray@gentoo.org> sandbox.c :
486    
487     Don't segfault if $HOME isn't set, set $HOME to "/" instead. Fixes bug 10868.
488    
489     16 Dec 2002; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
490    
491     Fix memory leak for mips, bug #12236. Thanks to Torgeir Hansen <torgeir@trenger.ro>
492     for this fix.
493    
494     4 Dec 2002; J Robert Ray <jrray@gentoo.org> sandbox.h sandbox_futils.c :
495    
496     sandbox_futils defined a dirname() function that was masking the same
497     function in glibc and was broken (e.g.: SANDBOX_DIR was being set to
498     '/usr/lib/portage/bi/'). Fixed function to return expected results and
499     renamed it to sb_dirname() to no longer mask the glibc function. Closes bug
500     11231.
501    
502     4 Dec 2002; Martin Schlemmer <azarah@gentoo.org> :
503    
504     Fix a segfault in libsandbox.c if canonicalize() was called with
505     first parameter = NULL.
506    
507     1 Sep 2002; Martin Schlemmer <azarah@gentoo.org> :
508    
509     Fix my braindead 'return 1;' in a void function. Updated sandbox.c,
510     cleanup() for this.
511    
512     Change cleanup() in sandbox.c not to exit with fail status if
513     the pidsfile is missing. We really should still display sandbox
514     violations if they occured.
515    
516     31 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
517    
518     Update cleanup() in sandbox.c to remove the PIDSFILE if this is
519     the last sandbox running.
520    
521     25 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
522    
523     Major cleanups to mainly libsandbox.c again.
524    
525     22 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
526    
527     Add copyrights to sandbox.h and sandbox_futils.h. If wrong, the
528     parties involved should please contact me so that we can fix it.
529    
530     Add opendir wrapper to libsandbox.c.
531    
532     21 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
533    
534     Do some more cleanups to ecanonicalize(), as it dropped filenames in
535     rare cases (after my symlink cleanups), and caused glibc to bork.
536     These fixes went into canonicalize.c.
537    
538     20 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
539    
540     Fix spawn_shell() and main() in sandbox.c to properly return fail
541     status.
542    
543     19 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
544    
545     The new canonicalize() function in libsandbox.c also resolved symlinks,
546     which caused on cleaning sandbox errors if the symlink pointed to a
547     file in the live root. Ripped out canonicalize() and realpath() from
548     glibc; removed the symlink stuff, and changed them to ecanonicalize()
549     and erealpath().
550    
551     18 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
552    
553     Ripped out all the wrappers, and implemented those of InstallWatch.
554     Losts of cleanups and bugfixes. Implement a execve that forces
555     $LIBSANDBOX in $LD_PRELOAD. We can now thus do away with the feared
556     /etc/ld.so.preload (*g*) ... Made the needed changes to sandbox.c,
557     sandbox.h and sandbox_futils.c. Rewrote the Makefile for most
558     parts; it now have an install target.
559    
560     Reformat the whole thing to look somewhat like the reworked sandbox.c
561     and new sandbox.h and sandbox_futils.c from:
562    
563     Brad House <brad@mainstreetsoftworks.com>.
564    
565     Additional Copyrights now due to the InstallWatch code:
566    
567     Copyright (C) 1998-9 Pancrazio `Ezio' de Mauro <p@demauro.net>

Properties

Name Value
svn:eol-style native
svn:keywords Author Date Id Revision

  ViewVC Help
Powered by ViewVC 1.1.20