/[path-sandbox]/trunk/ChangeLog
Gentoo

Contents of /trunk/ChangeLog

Parent Directory Parent Directory | Revision Log Revision Log


Revision 136 - (hide annotations) (download)
Wed Jul 6 19:41:26 2005 UTC (9 years, 3 months ago) by azarah
File size: 25938 byte(s)
Add check_prefixes() with major cleanup on check_access().
1 ferringb 2 # ChangeLog for Path Sandbox
2 vapier 53 # Copyright 1999-2005 Gentoo Foundation; Distributed under the GPL v2
3 ferringb 2 # $Header$
4    
5 azarah 134 06 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.h, sandbox_futils.c,
6     libsandbox.c:
7     - Change log dir to /var/log/sandbox/. Make sure the sandboxed process cannot
8     write to it.
9 azarah 135 - Clean up logging in libsandbox.c, and hopefully make it more consistant.
10 azarah 136 - Add check_prefixes() with major cleanup on check_access().
11 azarah 134
12 azarah 133 05 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
13     sandbox_futils.c, libsandbox.c:
14     Remove unused 'pids file' code.
15    
16 azarah 128 * sandbox-1.2.10 (2005/07/03)
17    
18 azarah 126 03 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
19     Add PREDICT items for nss-db, bug #92079. Patch from Robin Johnson.
20    
21 azarah 123 17 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
22     General cleanups:
23     - Remove fooling around with exit codes - we error out on presence of a log
24     anyhow.
25 azarah 124 - Move get_sandbox_*_envvar() to sandbox_setup_environ(), as its more
26     appropriate there.
27 azarah 123
28 azarah 121 12 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
29     Cleanup the fail_nametoolong stuff a bit more.
30    
31 azarah 118 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
32 azarah 120 Remove hopefully the last ld.so.preload bits we do not use anymore.
33    
34     11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
35 azarah 119 Remove the unneeded canonicalize() calls in the wrappers - we do it anyhow
36     in check_syscall(). Should speed things up a bit (at least for the getcwd()
37     and long path name test it goes down to under a second, and not 10+ seconds
38     like before). Also warn if we skip checking due to the canonicalized path
39     being too long.
40    
41     11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
42 azarah 118 More comment/readability cleanups.
43    
44 azarah 117 10 June 2005; Martin Schlemmer <azarah@gentoo.org> canonicalize.c, getcwd.c,
45     sandbox_futils.c, libsandbox.c:
46     Some strncpy/strncat and other cleanups.
47    
48 azarah 115 * sandbox-1.2.9 (2005/06/09)
49    
50 azarah 114 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
51     Move symlink hack down a bit to try and minimize on the amount of lstat()
52     calls we do.
53    
54 azarah 113 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
55     Add hack to allow writing to /proc/self/fd (or /dev/fd), bug #91516.
56    
57 azarah 112 09 June 2005; Martin Schlemmer <azarah@gentoo.org> symbols.in, libsandbox.c:
58     Add wrapper for access() function, bug #85413.
59    
60 azarah 111 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c:
61     Use generic getcwd() implementation from uclibc - should be more portable
62     and looks a bit cleaner.
63    
64 azarah 110 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c:
65     Make sure our true_* pointers are initialized to NULL, and that we check for
66     all references that they are valid.
67    
68 azarah 109 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
69     Be default we will fail if the path name we try to canonicalize is too long.
70     This however could cause issues with some things (bug #94630 and #21766), so
71     if fail_nametoolong == 0, canonicalize() will return a null length string and
72     do not fail.
73    
74 azarah 108 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c:
75     Do not abort if TMPDIR is not valid, but rather use '/tmp', bug #94360. Also
76     make sure we re-export the new TMPDIR environment variable.
77    
78 azarah 106 08 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
79     Fix incorrect free of non-malloc'd array, bug #92313 and #94020. Fix noted
80     by Marcus D. Hanwell <cryos@gentoo.org>.
81    
82 azarah 105 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
83     Add /dev/console to write list, bug #38588.
84    
85 azarah 102 * sandbox-1.2.8 (2005/05/13)
86    
87 azarah 99 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
88 azarah 101 sandbox.h, sandbox_futils.c:
89     General cleanups.
90    
91     13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
92 azarah 100 sandbox.h:
93     Various LD_PRELOAD cleanups. Do not unset LD_PRELOAD for parent.
94    
95     13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
96 azarah 99 sandbox.h, sandbox_futils.c:
97     Modify get_sandbox_pids_file(), get_sandbox_log() and get_sandbox_debug_log()
98     to use TMPDIR if present in environment.
99    
100 azarah 98 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
101     Remove sandbox_log_file from main() as its no longer used.
102    
103 azarah 97 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
104     sandbox_futils.c:
105     Add get_sandbox_debug_log(), and use it (add behaviour similar to SANDBOX_LOG
106     if already exported when sandbox started). Fix get_sandbox_log() and new
107     get_sandbox_debug_log() to not use already exported environment variables if
108     they have '/' in them. Use snprintf()'s instead of strncpy()'s. More
109     SB_PATH_MAX fixes.
110    
111 azarah 94 * sandbox-1.2.7 (2005/05/12)
112    
113 azarah 93 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
114     sandbox_futils.c:
115     More path limit fixes. Declare SB_BUF_LEN global and use it where needed.
116    
117 azarah 92 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
118     Fix paths limited to 255 chars. Fix get_sandbox_dir() returning a string
119     with '(null)' in it if we did not call sandbox with absolute path.
120    
121 azarah 89 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
122 azarah 91 Set SANDBOX_ON *before* doing the child's env stuff, else its not set
123     for the child.
124    
125     12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
126 azarah 90 Remove global preload_adaptable as it is no longer used.
127    
128     12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
129 azarah 89 Rewrite environment stuff to only be set when execve'ing the child process
130     to try and avoid issues like bug #91541 that causes sandbox to crash if
131     we set LD_PRELOAD sandbox side already.
132    
133 azarah 87 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
134 azarah 88 Move print_sandbox_log() up to make things neater.
135    
136     11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
137 azarah 87 Remove load_preload_libs(), as its not used anymore.
138    
139 azarah 83 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
140 azarah 86 Remove NO_FORK stuff, as its not used, and 'strace -f' works just fine.
141    
142     11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
143 azarah 84 Remove USE_SYSTEM_SHELL stuff, as it is not secure, and not in use.
144    
145     11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
146 azarah 83 Remove ld.so.preload crap - we are not going to use it again.
147    
148 azarah 82 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
149     Fix typo in code that checks if we got valid group information, causing a
150     segmentation fault, bug #91637.
151    
152 azarah 79 * sandbox-1.2.6 (2005/05/10)
153    
154 azarah 78 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
155     Do not use LD_PRELOAD if it contains libtsocks.so, as it breaks sandbox
156     for some odd reason, bug #91541.
157    
158 azarah 77 09 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
159     Fix typo (sizeof -> strlen).
160    
161 ferringb 76 08 May 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
162     rewrote the sbcontext caching code so it accounts for env changes since lib
163     initialization.
164    
165 azarah 75 05 May 2005; Martin Schlemmer <azarah@gentoo.org> configure.in, libctest.c:
166     We create libctest.c via configure, so no need to keep it around. Do some
167     cleanup related to libctest.c and libctest during configure.
168    
169 azarah 74 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
170     Add rename support of symlinks pointing to protected files/directories.
171    
172 azarah 72 * sandbox-1.2.5 (2005/05/04)
173    
174 azarah 71 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
175     sandbox.bashrc:
176     Do not reset already set LD_PRELOAD when starting sandbox. If LD_PRELOAD is
177     already set, init of the env vars fails for some reason, so do this later on,
178     and do not warn (bug #91431).
179    
180 azarah 70 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
181     sandbox.bashrc:
182     Fixup sandbox and sandbox.bashrc to call bash with the proper .bashrc.
183    
184 azarah 68 * sandbox-1.2.4 (2005/05/03)
185    
186 azarah 66 03 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
187     Do not init the env entries with each call, as it creates too many calls to
188 azarah 67 lstat, etc. Should speedup things a bit, bug #91040.
189 azarah 66
190 azarah 65 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
191     Add /dev/pty to default write list. Noticed by Morfic.
192    
193 vapier 62 02 May 2005; Mike Frysinger <vapier@gentoo.org> configure.in, localdecls.h,
194     sandbox.h:
195     uClibc doesn't support dlvsym() so add a configure check to make sure it doesn't
196     exist. Also update localdecls.h so BROKEN_RTLD_NEXT isn't defined in uClibc.
197    
198 azarah 59 * sandbox-1.2.3 (2005/04/29)
199    
200 azarah 56 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> configure.in:
201     Do not check for (*&#$(* CXX or F77.
202    
203 azarah 54 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
204     Do not append '/' to pathname in filter_path() if it already ends with it.
205    
206 vapier 53 28 Apr 2005; Mike Frysinger <vapier@gentoo.org> Makefile.am, configure.in:
207     With az's help, clean up autotools to work with cross-compiling.
208    
209 azarah 59 * sandbox-1.2.2 (2005/04/28)
210 azarah 48
211 azarah 47 28 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
212     Only check for /dev/{null,zero} for unlink hack, else ricers using /dev/shm
213     have issues; bug #90592.
214    
215 azarah 59 * sandbox-1.2.1 (2005/04/23)
216 azarah 44
217 azarah 43 23 Apr 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
218     getcwd.c, libsandbox.c, localdecls.h, sandbox.h, sandbox_futils.c:
219     Make sure all functions used in libsandbox.c is declared static. Define
220     SB_STATIC in localdecls.h for this. Include sandbox_futils.c rather than
221     linking with its object. Hopefully this will fix bug #90153.
222    
223 azarah 59 * sandbox-1.2 (2005/04/23)
224 azarah 46
225 azarah 40 22 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
226     Allow lchown a symlink in write-allowed path pointing to write-denied
227     target.
228    
229 genone 39 21 Mar 2005; Marius Mauch <genone@gentoo.org> libsandbox.c:
230     Also show resolved symlink names in the log.
231    
232 azarah 37 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, libsandbox.c:
233     Seems -nostdlib was the problem with the constructor/destructor - remove it
234     from Makefile.am, and change the constructor/destructor names again.
235    
236 azarah 36 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
237     Also rename the _init() and _fini() declarations.
238    
239 azarah 35 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
240     Fixup the constructor/destructor function names again (they should be _init()
241     and _fini() it seems, and not being called caused sandbox_lib_path to be
242     unset, and thus breaking the execve() wrapper's LD_PRELOAD protection).
243     Add both the path in given SANDBOX_x variable, as well as its symlink
244     resolved path in init_env_entries(). Modify filter_path() to be able to
245     resolve paths without resolving symlinks, as well as to be able to resolve
246     symlinks. Fix a possible segfault in check_access(). Add symlink resolving
247     to check_access() resolving bug #31019. Add 'hack' for unlink, as the fix
248     for bug #31019 cause access violations if we try to remove a symlink that is
249     not in protected path, but points to a protected path. Fix a memory leak in
250     sandbox.c (sandbox_pids_file in main()). Fix the realpath() calls in main()
251     (sandbox.c) being unchecked. Fix the debug logname not having the pid in it
252     (pid_string was uninitialized). General syntax cleanups.
253    
254 ferringb 34 09 Mar 2005; Brian Harring <ferringb@gentoo.org> sandbox.c: Fixed the
255     infamous "pids file is not a regular file" w/out newline bug.
256    
257 ferringb 33 09 Mar 2005; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in:
258     Correct libc_version path detection, since it was screwing up if libdir !=
259     "/lib/".
260    
261     02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
262 azarah 32 Hack to make sure sandboxed process cannot remove a device node, bug #79836.
263    
264 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am:
265 azarah 31 Fix symbols.in not added to dist.
266    
267 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
268 azarah 30 getcwd.c, libsandbox.c, sandbox.c, sandbox.h, sandbox_futils.c:
269     White space fixes.
270    
271 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
272 azarah 30 configure.in, getcwd.c, libsandbox.c, symbols.in:
273 azarah 29 Fix inverse test logic in canonicalize.c, use a strncpy. Fix gcc warning in
274     getcwd.c. Add symbols.in and logic to Makefile.am to generate symbol versions
275     for glibc and other libc's that use this. Update libsandbox.c to use these
276     symbol versions if available. Fix exec wrapper to re-export LD_PRELOAD if the
277     process unset it.
278    
279 ferringb 33 01 Mar 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
280 ferringb 28 killed off _init and _fini in favor of
281     void __attribute__ ((constructor)) init_func and
282     void __attribute__ ((destructor)) closing_func. _(init|func) were deprecated.
283    
284 ferringb 26 06 Dec 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, libsandbox.c,
285     canonicalize.c, getcwd.c: Fixed compilation *again*. Hopefully cvs is done
286     having the hick-ups.
287    
288 ferringb 24 04 Dec 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, getcwd.c,
289     Makefile.am: Fixed compilation.
290    
291 ferringb 18 01 Dec 2004; Brian Harring <ferringb@gentoo.org> aclocal.m4:
292     Gutted the bugger so it stops checking for a c++ and fortran compiler.
293     Do *not* regenerate aclocal.m4 for making a release until a better
294     solution is created.
295    
296 ferringb 16 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, sandbox_futils.c:
297     Removal of more hardcoded paths.
298    
299 ferringb 13 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in,
300     sandbox_futils.c: tweaks to install sandbox.bashrc, and use it.
301    
302     19 Nov 2004; Brian Harring <ferringb@gentoo.org>:
303 ferringb 6 Sandbox is now autotooled, create-localdecls needs to be killed and the code
304     shifted into configure.in. Currently builds *one* libsandbox.so- if multiple
305     are desired (-m64 and -m32 for amd64), the ebuild should do it (imo).
306     To get to a point of testing, automake && autoconf; created requisite files w/
307     a(utomake|clocal)-1.8, and autoconf 2.59. Installs to /usr/, instead of
308     /lib and /usr/lib/portage/bin.
309    
310 ferringb 2 14 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox.c:
311     closing out bug #70225, potential overflow of the sandbox_pids_file var.
312    
313     07 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c: c99 standard,
314     (think it was at least) allows intermixing of code and data segments. bug #70351
315     should be fixed by this.
316    
317     03 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox_futils.c:
318     futils fix from bug #65201 via solar, and libsandbox log path checks via #69137
319    
320     02 Aug 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Code from
321     Seth Robertson that tracked down all adjuct flags for read operations that
322     do not invoke a write operation.
323    
324     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
325     Another fix from jstubbs regarding a free() on a stack variable for the
326     environment -- tracking now prevents extraneous free()'s segfault.
327    
328     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
329     J. Stubbs tracked down a new bug where mkdir was failing to the patch on
330     the lstat in mkdir... it now only returns 0 or -1 as documented for mkdir.
331     Also remove the errno = ESUCCESS settings as documentation points out that
332     a library isn't allowed to do that.
333    
334     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Added a
335     file_security_check() function to check random potential exploits on files
336     that sandbox is to load and read -- Normally sandboxpids.tmp. This fixes
337     the 'system-crippling' exploits (bug 21923) and catches a few other
338     potential problems.
339    
340     20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> Makefile: Updates for
341     32/64 bit sandbox. Made CC and LD '?=' values to allow passed in CC to work.
342    
343     20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c:
344     bug 42048 -- Fixed the lstat/errno conditions for mkdir <caleb@g.o>.
345     Added the 64/32 bit sandbox patch for AMD64 bug 32963 <brad/azarah>.
346    
347     29 Feb 2004; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c :
348     Fix permissions and group of pids file and logs. Permissions should be 0664
349     and group should be 'portage'. Bug #34260.
350    
351     28 Feb 2004; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
352     Besides a small cleanup, redo how we replace LD_PRELOAD in the environ passed
353     to the real execve (in our execve wrapper). Seems that on some arches (sparc
354     among others) do not allow us to tamper with the readonly copy passed to
355     execve, so pass our own copy of the environment. Bug #42290.
356    
357     11 Jan 2004; Nicholas Jones <carpaski@gentoo.org> create-decls:
358     Changed tail to head and added a notice about duration of glibc check.
359    
360     21 Dec 2003; Nicholas Jones <carpaski@gentoo.org> create-decls:
361     Changed the glibc subversion check to use /usr/bin/* instead of /bin/sh
362     as there isn't a guarentee that it is dynamic.
363    
364     02 Nov 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
365     If 'file' passed to before_syscall(const char *func, const char *file) is
366     invalid, we should set errno to ENOENT, and not EINVAL. This should
367     close bug #32238.
368    
369     14 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
370     Fix a bug that occurs mainly on 64bit arch, where the file passed to
371     the functions we wrap, is invalid, and then cause canonicalize to pass
372     garbage to before_syscall(), thanks to great detective work from
373     Andrea Luzzardi <al@sig11.org> (bug #29846).
374    
375     13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
376     Add a uClibc detection patch from Peter S. Mazinger <ps.m@gmx.net>.
377    
378     13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
379     Fix a bug in libsandbox.c 's checking in the rename wrapper - it basically
380     only checked the destination patch, and not the source, so we could move
381     a protected file to a unprotected directory, and then delete/modify it.
382     Thanks to Andrea Luzzardi (scox) <al@sig11.org>, bug #30992, for this fix.
383    
384     12 Oct 2003; Nicholas Jones <carpaski@gentoo.org> sandbox.c :
385     Added python2.3 to the predict section/variable.
386    
387     28 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
388     sandbox.h, sandbox_futils.c :
389     Add support to set the pids file via SANDBOX_PIDS_FILE at startup. If
390     it is not set, it will revert to its old value.
391    
392     27 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
393     Fix our mkdir wrapper to check if the dir exist, and return EEXIST if so,
394     rather than failing with a violation, bug #29748.
395    
396     27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
397     Fix canonicalize() to ignore calls with path = "".
398    
399     27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c,
400     sandbox_futils.c, canonicalize.c :
401     Once again coreutils fails, as my systems had 2.5 kernel, the getcwd system
402     call handled strings larger than PATH_MAX (bug #21766). It however does not
403     work the same on 2.4 kernels.
404    
405     To fix, I added the posix implementation of getcwd() (from glibc cvs) that
406     do not need the system call. We use the default getcwd() function via a
407     wrapper (egetcwd), and then lstat the returned path. If lstat fails, it
408     means the current directory was removed, OR that the the system call for
409     getcwd failed (curious is that it do not fail and return NULL or set
410     errno, but rather just truncate the retured directory - usually from the
411     start), and if so, we use the generic getcwd() function (__egetcwd). Note
412     that we do not use the generic version all the time, as it calls lstat()
413     a great number of times, and performance degrade much.
414    
415     29 Jun 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls,
416     libsandbox.c :
417     Make sure SB_PATH_MAX will not wrap. Fix two possible memory leaks.
418    
419     22 Jun 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, canonicalize.c
420     create-localdecls :
421     When checking path names of files accessed, we need to canonicalize it, else
422     it may be a symlink in a 'write allowed' directory pointing to a file in a
423     directory we should not have write access to.
424    
425     With something like coreutils-5.0, we have two problems:
426     1) One of the tests checks if getcwd() can return a path longer than
427     PATH_MAX. This test then tries to create a dir which even while
428     created local (mkdir("conftest2")), it ends up being resolved with
429     a name that is much larger than PATH_MAX. The problem now is that
430     canonicalize() have undefined behaviour when the path was too long
431     (returned wrongly truncated paths, etc), and pass the wrong path to
432     before_syscall() (causing the bogus sandbox violations).
433     2) The ecanonicalize() function we used, along with the canonicalize()
434     function did not support longer than PATH_MAX. This is partly a
435     cause for 1), but the error checking (rather lack of it) of calls
436     to erealpath() in canonicalize() was the prime reason for 1).
437    
438     As we do not use this canonicalized name to call the function, we resolve this
439     by fixing canonicalize() to do better error checking, and ecanonicalize() as
440     well as all functions in libsandbox.c to use a PATH_MAX of 'PATH_MAX * 2'.
441     While they will resolve paths properly now, and can check if a write/read is
442     allowed, the functions called from the sandboxed environment will still work
443     as expected.
444    
445     This should resolve bug #21766.
446    
447     06 Apr 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
448     For some reason sandbox fails with a 'open_wr' if you run 'locale -a' under
449     it (bug #16298).
450    
451     Problem is that for some reason locale fopen's locale.alias with mode "rm".
452    
453     -------------------------------------------------------
454     nosferatu root # grep fopen locale.log
455     fopen("/usr/share/locale/locale.alias", "rm"ACCESS DENIED open_wr: /usr/share/locale/locale.alias
456     nosferatu root #
457     --------------------------------------------------------
458    
459     I checked the source of locale, but it have fopen with mode 'r', so
460     not sure where the "rm" mode comes from. Anyhow, changed the check in
461     before_syscall_open_char() to also see mode "rm" as readonly.
462    
463     23 Feb 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
464    
465     Add glibc-2.3 support.
466    
467     22 Feb 2003; Martin Schlemmer <azarah@gentoo.org> sandbox.c :
468    
469     Some /etc/ld.so.preload fixes. Just changed the #if defines to cover all
470     operations releated to preload, as well as only try to modify ld.so.preload
471     if we can. Also modify to write the pid to /tmp/sandboxpids.tmp even when
472     not using ld.so.preload. Fix to not write this instance of sandbox's pid
473     to /tmp/sandboxpids.tmp on exit if this is not the last sandbox running.
474    
475     22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> Makefile :
476    
477     Changed the LD to CC for hppa.
478    
479     22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
480    
481     Killed the previous changes I made.
482    
483     17 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
484    
485     Added parisc to BROKEN_RTLD_ARCHLIST to see if it we can fix the relocation probs.
486    
487     09 Jan 2003; J Robert Ray <jrray@gentoo.org> sandbox.c :
488    
489     Don't segfault if $HOME isn't set, set $HOME to "/" instead. Fixes bug 10868.
490    
491     16 Dec 2002; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
492    
493     Fix memory leak for mips, bug #12236. Thanks to Torgeir Hansen <torgeir@trenger.ro>
494     for this fix.
495    
496     4 Dec 2002; J Robert Ray <jrray@gentoo.org> sandbox.h sandbox_futils.c :
497    
498     sandbox_futils defined a dirname() function that was masking the same
499     function in glibc and was broken (e.g.: SANDBOX_DIR was being set to
500     '/usr/lib/portage/bi/'). Fixed function to return expected results and
501     renamed it to sb_dirname() to no longer mask the glibc function. Closes bug
502     11231.
503    
504     4 Dec 2002; Martin Schlemmer <azarah@gentoo.org> :
505    
506     Fix a segfault in libsandbox.c if canonicalize() was called with
507     first parameter = NULL.
508    
509     1 Sep 2002; Martin Schlemmer <azarah@gentoo.org> :
510    
511     Fix my braindead 'return 1;' in a void function. Updated sandbox.c,
512     cleanup() for this.
513    
514     Change cleanup() in sandbox.c not to exit with fail status if
515     the pidsfile is missing. We really should still display sandbox
516     violations if they occured.
517    
518     31 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
519    
520     Update cleanup() in sandbox.c to remove the PIDSFILE if this is
521     the last sandbox running.
522    
523     25 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
524    
525     Major cleanups to mainly libsandbox.c again.
526    
527     22 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
528    
529     Add copyrights to sandbox.h and sandbox_futils.h. If wrong, the
530     parties involved should please contact me so that we can fix it.
531    
532     Add opendir wrapper to libsandbox.c.
533    
534     21 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
535    
536     Do some more cleanups to ecanonicalize(), as it dropped filenames in
537     rare cases (after my symlink cleanups), and caused glibc to bork.
538     These fixes went into canonicalize.c.
539    
540     20 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
541    
542     Fix spawn_shell() and main() in sandbox.c to properly return fail
543     status.
544    
545     19 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
546    
547     The new canonicalize() function in libsandbox.c also resolved symlinks,
548     which caused on cleaning sandbox errors if the symlink pointed to a
549     file in the live root. Ripped out canonicalize() and realpath() from
550     glibc; removed the symlink stuff, and changed them to ecanonicalize()
551     and erealpath().
552    
553     18 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
554    
555     Ripped out all the wrappers, and implemented those of InstallWatch.
556     Losts of cleanups and bugfixes. Implement a execve that forces
557     $LIBSANDBOX in $LD_PRELOAD. We can now thus do away with the feared
558     /etc/ld.so.preload (*g*) ... Made the needed changes to sandbox.c,
559     sandbox.h and sandbox_futils.c. Rewrote the Makefile for most
560     parts; it now have an install target.
561    
562     Reformat the whole thing to look somewhat like the reworked sandbox.c
563     and new sandbox.h and sandbox_futils.c from:
564    
565     Brad House <brad@mainstreetsoftworks.com>.
566    
567     Additional Copyrights now due to the InstallWatch code:
568    
569     Copyright (C) 1998-9 Pancrazio `Ezio' de Mauro <p@demauro.net>

Properties

Name Value
svn:eol-style native
svn:keywords Author Date Id Revision

  ViewVC Help
Powered by ViewVC 1.1.20