/[path-sandbox]/trunk/ChangeLog
Gentoo

Contents of /trunk/ChangeLog

Parent Directory Parent Directory | Revision Log Revision Log


Revision 145 - (hide annotations) (download)
Fri Jul 8 14:52:26 2005 UTC (9 years, 2 months ago) by azarah
File size: 26882 byte(s)
Try to cleanup and make error handling/printing consistent.
1 ferringb 2 # ChangeLog for Path Sandbox
2 vapier 53 # Copyright 1999-2005 Gentoo Foundation; Distributed under the GPL v2
3 ferringb 2 # $Header$
4    
5 azarah 145 08 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c,
6     libsandbox.c:
7     Try to cleanup and make error handling/printing consistent.
8    
9 azarah 139 07 July 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
10     sandbox.h, sandbox_futils.c:
11     - Fix possible segfault in env init code.
12     - Major cleanup of sandbox_futils.c. Removed most of the functions as we now
13     write to /var/log/sandbox/, so in theory do not need all that.
14 azarah 140 - Redo the interface of the get_* functions so that we do not leak memory.
15 azarah 141 - Remove sandbox_dir and co - we are not using it anymore.
16 azarah 142 - Remove unused includes and variables.
17 azarah 143 - Only declare functions in sandbox_futils.c that are used in libsandbox.c when
18     OUTSIDE_LIBSANDBOX is not defined.
19 azarah 144 - Cleanup access/log printing. Make access printing honour NOCOLOR. Fix log
20     printing's last line not honouring NOCOLOR.
21 azarah 138
22 azarah 134 06 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.h, sandbox_futils.c,
23     libsandbox.c:
24     - Change log dir to /var/log/sandbox/. Make sure the sandboxed process cannot
25     write to it.
26 azarah 135 - Clean up logging in libsandbox.c, and hopefully make it more consistant.
27 azarah 136 - Add check_prefixes() with major cleanup on check_access().
28 azarah 137 - Cleanup init_env_entries() and check_prefixes().
29 azarah 134
30 azarah 133 05 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
31     sandbox_futils.c, libsandbox.c:
32     Remove unused 'pids file' code.
33    
34 azarah 128 * sandbox-1.2.10 (2005/07/03)
35    
36 azarah 126 03 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
37     Add PREDICT items for nss-db, bug #92079. Patch from Robin Johnson.
38    
39 azarah 123 17 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
40     General cleanups:
41     - Remove fooling around with exit codes - we error out on presence of a log
42     anyhow.
43 azarah 124 - Move get_sandbox_*_envvar() to sandbox_setup_environ(), as its more
44     appropriate there.
45 azarah 123
46 azarah 121 12 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
47     Cleanup the fail_nametoolong stuff a bit more.
48    
49 azarah 118 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
50 azarah 120 Remove hopefully the last ld.so.preload bits we do not use anymore.
51    
52     11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
53 azarah 119 Remove the unneeded canonicalize() calls in the wrappers - we do it anyhow
54     in check_syscall(). Should speed things up a bit (at least for the getcwd()
55     and long path name test it goes down to under a second, and not 10+ seconds
56     like before). Also warn if we skip checking due to the canonicalized path
57     being too long.
58    
59     11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
60 azarah 118 More comment/readability cleanups.
61    
62 azarah 117 10 June 2005; Martin Schlemmer <azarah@gentoo.org> canonicalize.c, getcwd.c,
63     sandbox_futils.c, libsandbox.c:
64     Some strncpy/strncat and other cleanups.
65    
66 azarah 115 * sandbox-1.2.9 (2005/06/09)
67    
68 azarah 114 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
69     Move symlink hack down a bit to try and minimize on the amount of lstat()
70     calls we do.
71    
72 azarah 113 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
73     Add hack to allow writing to /proc/self/fd (or /dev/fd), bug #91516.
74    
75 azarah 112 09 June 2005; Martin Schlemmer <azarah@gentoo.org> symbols.in, libsandbox.c:
76     Add wrapper for access() function, bug #85413.
77    
78 azarah 111 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c:
79     Use generic getcwd() implementation from uclibc - should be more portable
80     and looks a bit cleaner.
81    
82 azarah 110 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c:
83     Make sure our true_* pointers are initialized to NULL, and that we check for
84     all references that they are valid.
85    
86 azarah 109 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
87     Be default we will fail if the path name we try to canonicalize is too long.
88     This however could cause issues with some things (bug #94630 and #21766), so
89     if fail_nametoolong == 0, canonicalize() will return a null length string and
90     do not fail.
91    
92 azarah 108 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c:
93     Do not abort if TMPDIR is not valid, but rather use '/tmp', bug #94360. Also
94     make sure we re-export the new TMPDIR environment variable.
95    
96 azarah 106 08 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
97     Fix incorrect free of non-malloc'd array, bug #92313 and #94020. Fix noted
98     by Marcus D. Hanwell <cryos@gentoo.org>.
99    
100 azarah 105 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
101     Add /dev/console to write list, bug #38588.
102    
103 azarah 102 * sandbox-1.2.8 (2005/05/13)
104    
105 azarah 99 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
106 azarah 101 sandbox.h, sandbox_futils.c:
107     General cleanups.
108    
109     13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
110 azarah 100 sandbox.h:
111     Various LD_PRELOAD cleanups. Do not unset LD_PRELOAD for parent.
112    
113     13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
114 azarah 99 sandbox.h, sandbox_futils.c:
115     Modify get_sandbox_pids_file(), get_sandbox_log() and get_sandbox_debug_log()
116     to use TMPDIR if present in environment.
117    
118 azarah 98 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
119     Remove sandbox_log_file from main() as its no longer used.
120    
121 azarah 97 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
122     sandbox_futils.c:
123     Add get_sandbox_debug_log(), and use it (add behaviour similar to SANDBOX_LOG
124     if already exported when sandbox started). Fix get_sandbox_log() and new
125     get_sandbox_debug_log() to not use already exported environment variables if
126     they have '/' in them. Use snprintf()'s instead of strncpy()'s. More
127     SB_PATH_MAX fixes.
128    
129 azarah 94 * sandbox-1.2.7 (2005/05/12)
130    
131 azarah 93 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
132     sandbox_futils.c:
133     More path limit fixes. Declare SB_BUF_LEN global and use it where needed.
134    
135 azarah 92 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
136     Fix paths limited to 255 chars. Fix get_sandbox_dir() returning a string
137     with '(null)' in it if we did not call sandbox with absolute path.
138    
139 azarah 89 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
140 azarah 91 Set SANDBOX_ON *before* doing the child's env stuff, else its not set
141     for the child.
142    
143     12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
144 azarah 90 Remove global preload_adaptable as it is no longer used.
145    
146     12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
147 azarah 89 Rewrite environment stuff to only be set when execve'ing the child process
148     to try and avoid issues like bug #91541 that causes sandbox to crash if
149     we set LD_PRELOAD sandbox side already.
150    
151 azarah 87 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
152 azarah 88 Move print_sandbox_log() up to make things neater.
153    
154     11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
155 azarah 87 Remove load_preload_libs(), as its not used anymore.
156    
157 azarah 83 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
158 azarah 86 Remove NO_FORK stuff, as its not used, and 'strace -f' works just fine.
159    
160     11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
161 azarah 84 Remove USE_SYSTEM_SHELL stuff, as it is not secure, and not in use.
162    
163     11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
164 azarah 83 Remove ld.so.preload crap - we are not going to use it again.
165    
166 azarah 82 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
167     Fix typo in code that checks if we got valid group information, causing a
168     segmentation fault, bug #91637.
169    
170 azarah 79 * sandbox-1.2.6 (2005/05/10)
171    
172 azarah 78 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
173     Do not use LD_PRELOAD if it contains libtsocks.so, as it breaks sandbox
174     for some odd reason, bug #91541.
175    
176 azarah 77 09 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
177     Fix typo (sizeof -> strlen).
178    
179 ferringb 76 08 May 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
180     rewrote the sbcontext caching code so it accounts for env changes since lib
181     initialization.
182    
183 azarah 75 05 May 2005; Martin Schlemmer <azarah@gentoo.org> configure.in, libctest.c:
184     We create libctest.c via configure, so no need to keep it around. Do some
185     cleanup related to libctest.c and libctest during configure.
186    
187 azarah 74 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
188     Add rename support of symlinks pointing to protected files/directories.
189    
190 azarah 72 * sandbox-1.2.5 (2005/05/04)
191    
192 azarah 71 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
193     sandbox.bashrc:
194     Do not reset already set LD_PRELOAD when starting sandbox. If LD_PRELOAD is
195     already set, init of the env vars fails for some reason, so do this later on,
196     and do not warn (bug #91431).
197    
198 azarah 70 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
199     sandbox.bashrc:
200     Fixup sandbox and sandbox.bashrc to call bash with the proper .bashrc.
201    
202 azarah 68 * sandbox-1.2.4 (2005/05/03)
203    
204 azarah 66 03 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
205     Do not init the env entries with each call, as it creates too many calls to
206 azarah 67 lstat, etc. Should speedup things a bit, bug #91040.
207 azarah 66
208 azarah 65 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
209     Add /dev/pty to default write list. Noticed by Morfic.
210    
211 vapier 62 02 May 2005; Mike Frysinger <vapier@gentoo.org> configure.in, localdecls.h,
212     sandbox.h:
213     uClibc doesn't support dlvsym() so add a configure check to make sure it doesn't
214     exist. Also update localdecls.h so BROKEN_RTLD_NEXT isn't defined in uClibc.
215    
216 azarah 59 * sandbox-1.2.3 (2005/04/29)
217    
218 azarah 56 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> configure.in:
219     Do not check for (*&#$(* CXX or F77.
220    
221 azarah 54 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
222     Do not append '/' to pathname in filter_path() if it already ends with it.
223    
224 vapier 53 28 Apr 2005; Mike Frysinger <vapier@gentoo.org> Makefile.am, configure.in:
225     With az's help, clean up autotools to work with cross-compiling.
226    
227 azarah 59 * sandbox-1.2.2 (2005/04/28)
228 azarah 48
229 azarah 47 28 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
230     Only check for /dev/{null,zero} for unlink hack, else ricers using /dev/shm
231     have issues; bug #90592.
232    
233 azarah 59 * sandbox-1.2.1 (2005/04/23)
234 azarah 44
235 azarah 43 23 Apr 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
236     getcwd.c, libsandbox.c, localdecls.h, sandbox.h, sandbox_futils.c:
237     Make sure all functions used in libsandbox.c is declared static. Define
238     SB_STATIC in localdecls.h for this. Include sandbox_futils.c rather than
239     linking with its object. Hopefully this will fix bug #90153.
240    
241 azarah 59 * sandbox-1.2 (2005/04/23)
242 azarah 46
243 azarah 40 22 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
244     Allow lchown a symlink in write-allowed path pointing to write-denied
245     target.
246    
247 genone 39 21 Mar 2005; Marius Mauch <genone@gentoo.org> libsandbox.c:
248     Also show resolved symlink names in the log.
249    
250 azarah 37 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, libsandbox.c:
251     Seems -nostdlib was the problem with the constructor/destructor - remove it
252     from Makefile.am, and change the constructor/destructor names again.
253    
254 azarah 36 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
255     Also rename the _init() and _fini() declarations.
256    
257 azarah 35 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
258     Fixup the constructor/destructor function names again (they should be _init()
259     and _fini() it seems, and not being called caused sandbox_lib_path to be
260     unset, and thus breaking the execve() wrapper's LD_PRELOAD protection).
261     Add both the path in given SANDBOX_x variable, as well as its symlink
262     resolved path in init_env_entries(). Modify filter_path() to be able to
263     resolve paths without resolving symlinks, as well as to be able to resolve
264     symlinks. Fix a possible segfault in check_access(). Add symlink resolving
265     to check_access() resolving bug #31019. Add 'hack' for unlink, as the fix
266     for bug #31019 cause access violations if we try to remove a symlink that is
267     not in protected path, but points to a protected path. Fix a memory leak in
268     sandbox.c (sandbox_pids_file in main()). Fix the realpath() calls in main()
269     (sandbox.c) being unchecked. Fix the debug logname not having the pid in it
270     (pid_string was uninitialized). General syntax cleanups.
271    
272 ferringb 34 09 Mar 2005; Brian Harring <ferringb@gentoo.org> sandbox.c: Fixed the
273     infamous "pids file is not a regular file" w/out newline bug.
274    
275 ferringb 33 09 Mar 2005; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in:
276     Correct libc_version path detection, since it was screwing up if libdir !=
277     "/lib/".
278    
279     02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
280 azarah 32 Hack to make sure sandboxed process cannot remove a device node, bug #79836.
281    
282 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am:
283 azarah 31 Fix symbols.in not added to dist.
284    
285 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
286 azarah 30 getcwd.c, libsandbox.c, sandbox.c, sandbox.h, sandbox_futils.c:
287     White space fixes.
288    
289 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
290 azarah 30 configure.in, getcwd.c, libsandbox.c, symbols.in:
291 azarah 29 Fix inverse test logic in canonicalize.c, use a strncpy. Fix gcc warning in
292     getcwd.c. Add symbols.in and logic to Makefile.am to generate symbol versions
293     for glibc and other libc's that use this. Update libsandbox.c to use these
294     symbol versions if available. Fix exec wrapper to re-export LD_PRELOAD if the
295     process unset it.
296    
297 ferringb 33 01 Mar 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
298 ferringb 28 killed off _init and _fini in favor of
299     void __attribute__ ((constructor)) init_func and
300     void __attribute__ ((destructor)) closing_func. _(init|func) were deprecated.
301    
302 ferringb 26 06 Dec 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, libsandbox.c,
303     canonicalize.c, getcwd.c: Fixed compilation *again*. Hopefully cvs is done
304     having the hick-ups.
305    
306 ferringb 24 04 Dec 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, getcwd.c,
307     Makefile.am: Fixed compilation.
308    
309 ferringb 18 01 Dec 2004; Brian Harring <ferringb@gentoo.org> aclocal.m4:
310     Gutted the bugger so it stops checking for a c++ and fortran compiler.
311     Do *not* regenerate aclocal.m4 for making a release until a better
312     solution is created.
313    
314 ferringb 16 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, sandbox_futils.c:
315     Removal of more hardcoded paths.
316    
317 ferringb 13 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in,
318     sandbox_futils.c: tweaks to install sandbox.bashrc, and use it.
319    
320     19 Nov 2004; Brian Harring <ferringb@gentoo.org>:
321 ferringb 6 Sandbox is now autotooled, create-localdecls needs to be killed and the code
322     shifted into configure.in. Currently builds *one* libsandbox.so- if multiple
323     are desired (-m64 and -m32 for amd64), the ebuild should do it (imo).
324     To get to a point of testing, automake && autoconf; created requisite files w/
325     a(utomake|clocal)-1.8, and autoconf 2.59. Installs to /usr/, instead of
326     /lib and /usr/lib/portage/bin.
327    
328 ferringb 2 14 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox.c:
329     closing out bug #70225, potential overflow of the sandbox_pids_file var.
330    
331     07 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c: c99 standard,
332     (think it was at least) allows intermixing of code and data segments. bug #70351
333     should be fixed by this.
334    
335     03 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox_futils.c:
336     futils fix from bug #65201 via solar, and libsandbox log path checks via #69137
337    
338     02 Aug 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Code from
339     Seth Robertson that tracked down all adjuct flags for read operations that
340     do not invoke a write operation.
341    
342     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
343     Another fix from jstubbs regarding a free() on a stack variable for the
344     environment -- tracking now prevents extraneous free()'s segfault.
345    
346     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
347     J. Stubbs tracked down a new bug where mkdir was failing to the patch on
348     the lstat in mkdir... it now only returns 0 or -1 as documented for mkdir.
349     Also remove the errno = ESUCCESS settings as documentation points out that
350     a library isn't allowed to do that.
351    
352     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Added a
353     file_security_check() function to check random potential exploits on files
354     that sandbox is to load and read -- Normally sandboxpids.tmp. This fixes
355     the 'system-crippling' exploits (bug 21923) and catches a few other
356     potential problems.
357    
358     20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> Makefile: Updates for
359     32/64 bit sandbox. Made CC and LD '?=' values to allow passed in CC to work.
360    
361     20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c:
362     bug 42048 -- Fixed the lstat/errno conditions for mkdir <caleb@g.o>.
363     Added the 64/32 bit sandbox patch for AMD64 bug 32963 <brad/azarah>.
364    
365     29 Feb 2004; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c :
366     Fix permissions and group of pids file and logs. Permissions should be 0664
367     and group should be 'portage'. Bug #34260.
368    
369     28 Feb 2004; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
370     Besides a small cleanup, redo how we replace LD_PRELOAD in the environ passed
371     to the real execve (in our execve wrapper). Seems that on some arches (sparc
372     among others) do not allow us to tamper with the readonly copy passed to
373     execve, so pass our own copy of the environment. Bug #42290.
374    
375     11 Jan 2004; Nicholas Jones <carpaski@gentoo.org> create-decls:
376     Changed tail to head and added a notice about duration of glibc check.
377    
378     21 Dec 2003; Nicholas Jones <carpaski@gentoo.org> create-decls:
379     Changed the glibc subversion check to use /usr/bin/* instead of /bin/sh
380     as there isn't a guarentee that it is dynamic.
381    
382     02 Nov 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
383     If 'file' passed to before_syscall(const char *func, const char *file) is
384     invalid, we should set errno to ENOENT, and not EINVAL. This should
385     close bug #32238.
386    
387     14 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
388     Fix a bug that occurs mainly on 64bit arch, where the file passed to
389     the functions we wrap, is invalid, and then cause canonicalize to pass
390     garbage to before_syscall(), thanks to great detective work from
391     Andrea Luzzardi <al@sig11.org> (bug #29846).
392    
393     13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
394     Add a uClibc detection patch from Peter S. Mazinger <ps.m@gmx.net>.
395    
396     13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
397     Fix a bug in libsandbox.c 's checking in the rename wrapper - it basically
398     only checked the destination patch, and not the source, so we could move
399     a protected file to a unprotected directory, and then delete/modify it.
400     Thanks to Andrea Luzzardi (scox) <al@sig11.org>, bug #30992, for this fix.
401    
402     12 Oct 2003; Nicholas Jones <carpaski@gentoo.org> sandbox.c :
403     Added python2.3 to the predict section/variable.
404    
405     28 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
406     sandbox.h, sandbox_futils.c :
407     Add support to set the pids file via SANDBOX_PIDS_FILE at startup. If
408     it is not set, it will revert to its old value.
409    
410     27 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
411     Fix our mkdir wrapper to check if the dir exist, and return EEXIST if so,
412     rather than failing with a violation, bug #29748.
413    
414     27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
415     Fix canonicalize() to ignore calls with path = "".
416    
417     27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c,
418     sandbox_futils.c, canonicalize.c :
419     Once again coreutils fails, as my systems had 2.5 kernel, the getcwd system
420     call handled strings larger than PATH_MAX (bug #21766). It however does not
421     work the same on 2.4 kernels.
422    
423     To fix, I added the posix implementation of getcwd() (from glibc cvs) that
424     do not need the system call. We use the default getcwd() function via a
425     wrapper (egetcwd), and then lstat the returned path. If lstat fails, it
426     means the current directory was removed, OR that the the system call for
427     getcwd failed (curious is that it do not fail and return NULL or set
428     errno, but rather just truncate the retured directory - usually from the
429     start), and if so, we use the generic getcwd() function (__egetcwd). Note
430     that we do not use the generic version all the time, as it calls lstat()
431     a great number of times, and performance degrade much.
432    
433     29 Jun 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls,
434     libsandbox.c :
435     Make sure SB_PATH_MAX will not wrap. Fix two possible memory leaks.
436    
437     22 Jun 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, canonicalize.c
438     create-localdecls :
439     When checking path names of files accessed, we need to canonicalize it, else
440     it may be a symlink in a 'write allowed' directory pointing to a file in a
441     directory we should not have write access to.
442    
443     With something like coreutils-5.0, we have two problems:
444     1) One of the tests checks if getcwd() can return a path longer than
445     PATH_MAX. This test then tries to create a dir which even while
446     created local (mkdir("conftest2")), it ends up being resolved with
447     a name that is much larger than PATH_MAX. The problem now is that
448     canonicalize() have undefined behaviour when the path was too long
449     (returned wrongly truncated paths, etc), and pass the wrong path to
450     before_syscall() (causing the bogus sandbox violations).
451     2) The ecanonicalize() function we used, along with the canonicalize()
452     function did not support longer than PATH_MAX. This is partly a
453     cause for 1), but the error checking (rather lack of it) of calls
454     to erealpath() in canonicalize() was the prime reason for 1).
455    
456     As we do not use this canonicalized name to call the function, we resolve this
457     by fixing canonicalize() to do better error checking, and ecanonicalize() as
458     well as all functions in libsandbox.c to use a PATH_MAX of 'PATH_MAX * 2'.
459     While they will resolve paths properly now, and can check if a write/read is
460     allowed, the functions called from the sandboxed environment will still work
461     as expected.
462    
463     This should resolve bug #21766.
464    
465     06 Apr 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
466     For some reason sandbox fails with a 'open_wr' if you run 'locale -a' under
467     it (bug #16298).
468    
469     Problem is that for some reason locale fopen's locale.alias with mode "rm".
470    
471     -------------------------------------------------------
472     nosferatu root # grep fopen locale.log
473     fopen("/usr/share/locale/locale.alias", "rm"ACCESS DENIED open_wr: /usr/share/locale/locale.alias
474     nosferatu root #
475     --------------------------------------------------------
476    
477     I checked the source of locale, but it have fopen with mode 'r', so
478     not sure where the "rm" mode comes from. Anyhow, changed the check in
479     before_syscall_open_char() to also see mode "rm" as readonly.
480    
481     23 Feb 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
482    
483     Add glibc-2.3 support.
484    
485     22 Feb 2003; Martin Schlemmer <azarah@gentoo.org> sandbox.c :
486    
487     Some /etc/ld.so.preload fixes. Just changed the #if defines to cover all
488     operations releated to preload, as well as only try to modify ld.so.preload
489     if we can. Also modify to write the pid to /tmp/sandboxpids.tmp even when
490     not using ld.so.preload. Fix to not write this instance of sandbox's pid
491     to /tmp/sandboxpids.tmp on exit if this is not the last sandbox running.
492    
493     22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> Makefile :
494    
495     Changed the LD to CC for hppa.
496    
497     22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
498    
499     Killed the previous changes I made.
500    
501     17 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
502    
503     Added parisc to BROKEN_RTLD_ARCHLIST to see if it we can fix the relocation probs.
504    
505     09 Jan 2003; J Robert Ray <jrray@gentoo.org> sandbox.c :
506    
507     Don't segfault if $HOME isn't set, set $HOME to "/" instead. Fixes bug 10868.
508    
509     16 Dec 2002; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
510    
511     Fix memory leak for mips, bug #12236. Thanks to Torgeir Hansen <torgeir@trenger.ro>
512     for this fix.
513    
514     4 Dec 2002; J Robert Ray <jrray@gentoo.org> sandbox.h sandbox_futils.c :
515    
516     sandbox_futils defined a dirname() function that was masking the same
517     function in glibc and was broken (e.g.: SANDBOX_DIR was being set to
518     '/usr/lib/portage/bi/'). Fixed function to return expected results and
519     renamed it to sb_dirname() to no longer mask the glibc function. Closes bug
520     11231.
521    
522     4 Dec 2002; Martin Schlemmer <azarah@gentoo.org> :
523    
524     Fix a segfault in libsandbox.c if canonicalize() was called with
525     first parameter = NULL.
526    
527     1 Sep 2002; Martin Schlemmer <azarah@gentoo.org> :
528    
529     Fix my braindead 'return 1;' in a void function. Updated sandbox.c,
530     cleanup() for this.
531    
532     Change cleanup() in sandbox.c not to exit with fail status if
533     the pidsfile is missing. We really should still display sandbox
534     violations if they occured.
535    
536     31 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
537    
538     Update cleanup() in sandbox.c to remove the PIDSFILE if this is
539     the last sandbox running.
540    
541     25 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
542    
543     Major cleanups to mainly libsandbox.c again.
544    
545     22 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
546    
547     Add copyrights to sandbox.h and sandbox_futils.h. If wrong, the
548     parties involved should please contact me so that we can fix it.
549    
550     Add opendir wrapper to libsandbox.c.
551    
552     21 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
553    
554     Do some more cleanups to ecanonicalize(), as it dropped filenames in
555     rare cases (after my symlink cleanups), and caused glibc to bork.
556     These fixes went into canonicalize.c.
557    
558     20 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
559    
560     Fix spawn_shell() and main() in sandbox.c to properly return fail
561     status.
562    
563     19 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
564    
565     The new canonicalize() function in libsandbox.c also resolved symlinks,
566     which caused on cleaning sandbox errors if the symlink pointed to a
567     file in the live root. Ripped out canonicalize() and realpath() from
568     glibc; removed the symlink stuff, and changed them to ecanonicalize()
569     and erealpath().
570    
571     18 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
572    
573     Ripped out all the wrappers, and implemented those of InstallWatch.
574     Losts of cleanups and bugfixes. Implement a execve that forces
575     $LIBSANDBOX in $LD_PRELOAD. We can now thus do away with the feared
576     /etc/ld.so.preload (*g*) ... Made the needed changes to sandbox.c,
577     sandbox.h and sandbox_futils.c. Rewrote the Makefile for most
578     parts; it now have an install target.
579    
580     Reformat the whole thing to look somewhat like the reworked sandbox.c
581     and new sandbox.h and sandbox_futils.c from:
582    
583     Brad House <brad@mainstreetsoftworks.com>.
584    
585     Additional Copyrights now due to the InstallWatch code:
586    
587     Copyright (C) 1998-9 Pancrazio `Ezio' de Mauro <p@demauro.net>

Properties

Name Value
svn:eol-style native
svn:keywords Author Date Id Revision

  ViewVC Help
Powered by ViewVC 1.1.20