/[path-sandbox]/trunk/ChangeLog
Gentoo

Contents of /trunk/ChangeLog

Parent Directory Parent Directory | Revision Log Revision Log


Revision 159 - (hide annotations) (download)
Fri Aug 5 14:11:55 2005 UTC (9 years, 4 months ago) by azarah
File size: 28407 byte(s)
Improve error handling for get_sandbox_*_envvar() functions.
1 ferringb 2 # ChangeLog for Path Sandbox
2 vapier 53 # Copyright 1999-2005 Gentoo Foundation; Distributed under the GPL v2
3 ferringb 2 # $Header$
4    
5 azarah 159 05 Aug 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
6     sandbox.h:
7 azarah 156
8     Do not give an access violation if the access() system call do not have
9     write/read access - it does not actually modify, so we only need to return
10     not being able to write/read. Noted by Andres Loeh <kosmikus@gentoo.org>,
11     bug #101433.
12    
13 azarah 157 If we are called from the command line, do not care about PORTAGE_TMPDIR,
14     and make the current directory the work directory. Also rename the variable
15     portage_tmp_dir to work_dir.
16    
17 azarah 158 Remove the tmp_dir variable - we do not need it.
18    
19 azarah 159 Improve error handling for get_sandbox_*_envvar() functions.
20    
21 azarah 153 01 Aug 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
22    
23     Still do normal log if debugging is requested.
24    
25 azarah 154 Add support for SANDBOX_VERBOSE (enabled by default). Adjust SANDBOX_DEBUG
26     to only enable if equal to "1" or "yes".
27    
28 azarah 155 Add /dev/tts to write permit, bug #42809.
29    
30 azarah 152 27 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
31     sandbox_futils.c:
32    
33     Do not resolve symlinks in PORTAGE_TMPDIR in sandbox .. we will handle that
34     in libsandbox .. bug #100309.
35    
36 azarah 151 22 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.h:
37    
38     Print all logging to stderr, bug #90343, comment #15, by Zac Medico.
39    
40 azarah 149 * sandbox-1.2.11 (2005/07/14)
41    
42 azarah 148 14 July 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c:
43     Fix getcwd, bug #98419.
44    
45 azarah 145 08 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c,
46     libsandbox.c:
47 azarah 146 - Try to cleanup and make error handling/printing consistent.
48     - Remove old logs if present and conflicting with current.
49 azarah 147 - Fix compile error with previous change, and return rather then exit().
50 azarah 145
51 azarah 139 07 July 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
52     sandbox.h, sandbox_futils.c:
53     - Fix possible segfault in env init code.
54     - Major cleanup of sandbox_futils.c. Removed most of the functions as we now
55     write to /var/log/sandbox/, so in theory do not need all that.
56 azarah 140 - Redo the interface of the get_* functions so that we do not leak memory.
57 azarah 141 - Remove sandbox_dir and co - we are not using it anymore.
58 azarah 142 - Remove unused includes and variables.
59 azarah 143 - Only declare functions in sandbox_futils.c that are used in libsandbox.c when
60     OUTSIDE_LIBSANDBOX is not defined.
61 azarah 144 - Cleanup access/log printing. Make access printing honour NOCOLOR. Fix log
62     printing's last line not honouring NOCOLOR.
63 azarah 138
64 azarah 134 06 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.h, sandbox_futils.c,
65     libsandbox.c:
66     - Change log dir to /var/log/sandbox/. Make sure the sandboxed process cannot
67     write to it.
68 azarah 135 - Clean up logging in libsandbox.c, and hopefully make it more consistant.
69 azarah 136 - Add check_prefixes() with major cleanup on check_access().
70 azarah 137 - Cleanup init_env_entries() and check_prefixes().
71 azarah 134
72 azarah 133 05 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
73     sandbox_futils.c, libsandbox.c:
74     Remove unused 'pids file' code.
75    
76 azarah 128 * sandbox-1.2.10 (2005/07/03)
77    
78 azarah 126 03 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
79     Add PREDICT items for nss-db, bug #92079. Patch from Robin Johnson.
80    
81 azarah 123 17 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
82     General cleanups:
83     - Remove fooling around with exit codes - we error out on presence of a log
84     anyhow.
85 azarah 124 - Move get_sandbox_*_envvar() to sandbox_setup_environ(), as its more
86     appropriate there.
87 azarah 123
88 azarah 121 12 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
89     Cleanup the fail_nametoolong stuff a bit more.
90    
91 azarah 118 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
92 azarah 120 Remove hopefully the last ld.so.preload bits we do not use anymore.
93    
94     11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
95 azarah 119 Remove the unneeded canonicalize() calls in the wrappers - we do it anyhow
96     in check_syscall(). Should speed things up a bit (at least for the getcwd()
97     and long path name test it goes down to under a second, and not 10+ seconds
98     like before). Also warn if we skip checking due to the canonicalized path
99     being too long.
100    
101     11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
102 azarah 118 More comment/readability cleanups.
103    
104 azarah 117 10 June 2005; Martin Schlemmer <azarah@gentoo.org> canonicalize.c, getcwd.c,
105     sandbox_futils.c, libsandbox.c:
106     Some strncpy/strncat and other cleanups.
107    
108 azarah 115 * sandbox-1.2.9 (2005/06/09)
109    
110 azarah 114 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
111     Move symlink hack down a bit to try and minimize on the amount of lstat()
112     calls we do.
113    
114 azarah 113 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
115     Add hack to allow writing to /proc/self/fd (or /dev/fd), bug #91516.
116    
117 azarah 112 09 June 2005; Martin Schlemmer <azarah@gentoo.org> symbols.in, libsandbox.c:
118     Add wrapper for access() function, bug #85413.
119    
120 azarah 111 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c:
121     Use generic getcwd() implementation from uclibc - should be more portable
122     and looks a bit cleaner.
123    
124 azarah 110 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c:
125     Make sure our true_* pointers are initialized to NULL, and that we check for
126     all references that they are valid.
127    
128 azarah 109 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
129     Be default we will fail if the path name we try to canonicalize is too long.
130     This however could cause issues with some things (bug #94630 and #21766), so
131     if fail_nametoolong == 0, canonicalize() will return a null length string and
132     do not fail.
133    
134 azarah 108 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c:
135     Do not abort if TMPDIR is not valid, but rather use '/tmp', bug #94360. Also
136     make sure we re-export the new TMPDIR environment variable.
137    
138 azarah 106 08 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
139     Fix incorrect free of non-malloc'd array, bug #92313 and #94020. Fix noted
140     by Marcus D. Hanwell <cryos@gentoo.org>.
141    
142 azarah 105 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
143     Add /dev/console to write list, bug #38588.
144    
145 azarah 102 * sandbox-1.2.8 (2005/05/13)
146    
147 azarah 99 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
148 azarah 101 sandbox.h, sandbox_futils.c:
149     General cleanups.
150    
151     13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
152 azarah 100 sandbox.h:
153     Various LD_PRELOAD cleanups. Do not unset LD_PRELOAD for parent.
154    
155     13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
156 azarah 99 sandbox.h, sandbox_futils.c:
157     Modify get_sandbox_pids_file(), get_sandbox_log() and get_sandbox_debug_log()
158     to use TMPDIR if present in environment.
159    
160 azarah 98 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
161     Remove sandbox_log_file from main() as its no longer used.
162    
163 azarah 97 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
164     sandbox_futils.c:
165     Add get_sandbox_debug_log(), and use it (add behaviour similar to SANDBOX_LOG
166     if already exported when sandbox started). Fix get_sandbox_log() and new
167     get_sandbox_debug_log() to not use already exported environment variables if
168     they have '/' in them. Use snprintf()'s instead of strncpy()'s. More
169     SB_PATH_MAX fixes.
170    
171 azarah 94 * sandbox-1.2.7 (2005/05/12)
172    
173 azarah 93 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
174     sandbox_futils.c:
175     More path limit fixes. Declare SB_BUF_LEN global and use it where needed.
176    
177 azarah 92 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
178     Fix paths limited to 255 chars. Fix get_sandbox_dir() returning a string
179     with '(null)' in it if we did not call sandbox with absolute path.
180    
181 azarah 89 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
182 azarah 91 Set SANDBOX_ON *before* doing the child's env stuff, else its not set
183     for the child.
184    
185     12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
186 azarah 90 Remove global preload_adaptable as it is no longer used.
187    
188     12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
189 azarah 89 Rewrite environment stuff to only be set when execve'ing the child process
190     to try and avoid issues like bug #91541 that causes sandbox to crash if
191     we set LD_PRELOAD sandbox side already.
192    
193 azarah 87 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
194 azarah 88 Move print_sandbox_log() up to make things neater.
195    
196     11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
197 azarah 87 Remove load_preload_libs(), as its not used anymore.
198    
199 azarah 83 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
200 azarah 86 Remove NO_FORK stuff, as its not used, and 'strace -f' works just fine.
201    
202     11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
203 azarah 84 Remove USE_SYSTEM_SHELL stuff, as it is not secure, and not in use.
204    
205     11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
206 azarah 83 Remove ld.so.preload crap - we are not going to use it again.
207    
208 azarah 82 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
209     Fix typo in code that checks if we got valid group information, causing a
210     segmentation fault, bug #91637.
211    
212 azarah 79 * sandbox-1.2.6 (2005/05/10)
213    
214 azarah 78 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
215     Do not use LD_PRELOAD if it contains libtsocks.so, as it breaks sandbox
216     for some odd reason, bug #91541.
217    
218 azarah 77 09 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
219     Fix typo (sizeof -> strlen).
220    
221 ferringb 76 08 May 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
222     rewrote the sbcontext caching code so it accounts for env changes since lib
223     initialization.
224    
225 azarah 75 05 May 2005; Martin Schlemmer <azarah@gentoo.org> configure.in, libctest.c:
226     We create libctest.c via configure, so no need to keep it around. Do some
227     cleanup related to libctest.c and libctest during configure.
228    
229 azarah 74 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
230     Add rename support of symlinks pointing to protected files/directories.
231    
232 azarah 72 * sandbox-1.2.5 (2005/05/04)
233    
234 azarah 71 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
235     sandbox.bashrc:
236     Do not reset already set LD_PRELOAD when starting sandbox. If LD_PRELOAD is
237     already set, init of the env vars fails for some reason, so do this later on,
238     and do not warn (bug #91431).
239    
240 azarah 70 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
241     sandbox.bashrc:
242     Fixup sandbox and sandbox.bashrc to call bash with the proper .bashrc.
243    
244 azarah 68 * sandbox-1.2.4 (2005/05/03)
245    
246 azarah 66 03 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
247     Do not init the env entries with each call, as it creates too many calls to
248 azarah 67 lstat, etc. Should speedup things a bit, bug #91040.
249 azarah 66
250 azarah 65 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
251     Add /dev/pty to default write list. Noticed by Morfic.
252    
253 vapier 62 02 May 2005; Mike Frysinger <vapier@gentoo.org> configure.in, localdecls.h,
254     sandbox.h:
255     uClibc doesn't support dlvsym() so add a configure check to make sure it doesn't
256     exist. Also update localdecls.h so BROKEN_RTLD_NEXT isn't defined in uClibc.
257    
258 azarah 59 * sandbox-1.2.3 (2005/04/29)
259    
260 azarah 56 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> configure.in:
261     Do not check for (*&#$(* CXX or F77.
262    
263 azarah 54 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
264     Do not append '/' to pathname in filter_path() if it already ends with it.
265    
266 vapier 53 28 Apr 2005; Mike Frysinger <vapier@gentoo.org> Makefile.am, configure.in:
267     With az's help, clean up autotools to work with cross-compiling.
268    
269 azarah 59 * sandbox-1.2.2 (2005/04/28)
270 azarah 48
271 azarah 47 28 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
272     Only check for /dev/{null,zero} for unlink hack, else ricers using /dev/shm
273     have issues; bug #90592.
274    
275 azarah 59 * sandbox-1.2.1 (2005/04/23)
276 azarah 44
277 azarah 43 23 Apr 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
278     getcwd.c, libsandbox.c, localdecls.h, sandbox.h, sandbox_futils.c:
279     Make sure all functions used in libsandbox.c is declared static. Define
280     SB_STATIC in localdecls.h for this. Include sandbox_futils.c rather than
281     linking with its object. Hopefully this will fix bug #90153.
282    
283 azarah 59 * sandbox-1.2 (2005/04/23)
284 azarah 46
285 azarah 40 22 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
286     Allow lchown a symlink in write-allowed path pointing to write-denied
287     target.
288    
289 genone 39 21 Mar 2005; Marius Mauch <genone@gentoo.org> libsandbox.c:
290     Also show resolved symlink names in the log.
291    
292 azarah 37 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, libsandbox.c:
293     Seems -nostdlib was the problem with the constructor/destructor - remove it
294     from Makefile.am, and change the constructor/destructor names again.
295    
296 azarah 36 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
297     Also rename the _init() and _fini() declarations.
298    
299 azarah 35 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
300     Fixup the constructor/destructor function names again (they should be _init()
301     and _fini() it seems, and not being called caused sandbox_lib_path to be
302     unset, and thus breaking the execve() wrapper's LD_PRELOAD protection).
303     Add both the path in given SANDBOX_x variable, as well as its symlink
304     resolved path in init_env_entries(). Modify filter_path() to be able to
305     resolve paths without resolving symlinks, as well as to be able to resolve
306     symlinks. Fix a possible segfault in check_access(). Add symlink resolving
307     to check_access() resolving bug #31019. Add 'hack' for unlink, as the fix
308     for bug #31019 cause access violations if we try to remove a symlink that is
309     not in protected path, but points to a protected path. Fix a memory leak in
310     sandbox.c (sandbox_pids_file in main()). Fix the realpath() calls in main()
311     (sandbox.c) being unchecked. Fix the debug logname not having the pid in it
312     (pid_string was uninitialized). General syntax cleanups.
313    
314 ferringb 34 09 Mar 2005; Brian Harring <ferringb@gentoo.org> sandbox.c: Fixed the
315     infamous "pids file is not a regular file" w/out newline bug.
316    
317 ferringb 33 09 Mar 2005; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in:
318     Correct libc_version path detection, since it was screwing up if libdir !=
319     "/lib/".
320    
321     02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
322 azarah 32 Hack to make sure sandboxed process cannot remove a device node, bug #79836.
323    
324 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am:
325 azarah 31 Fix symbols.in not added to dist.
326    
327 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
328 azarah 30 getcwd.c, libsandbox.c, sandbox.c, sandbox.h, sandbox_futils.c:
329     White space fixes.
330    
331 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
332 azarah 30 configure.in, getcwd.c, libsandbox.c, symbols.in:
333 azarah 29 Fix inverse test logic in canonicalize.c, use a strncpy. Fix gcc warning in
334     getcwd.c. Add symbols.in and logic to Makefile.am to generate symbol versions
335     for glibc and other libc's that use this. Update libsandbox.c to use these
336     symbol versions if available. Fix exec wrapper to re-export LD_PRELOAD if the
337     process unset it.
338    
339 ferringb 33 01 Mar 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
340 ferringb 28 killed off _init and _fini in favor of
341     void __attribute__ ((constructor)) init_func and
342     void __attribute__ ((destructor)) closing_func. _(init|func) were deprecated.
343    
344 ferringb 26 06 Dec 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, libsandbox.c,
345     canonicalize.c, getcwd.c: Fixed compilation *again*. Hopefully cvs is done
346     having the hick-ups.
347    
348 ferringb 24 04 Dec 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, getcwd.c,
349     Makefile.am: Fixed compilation.
350    
351 ferringb 18 01 Dec 2004; Brian Harring <ferringb@gentoo.org> aclocal.m4:
352     Gutted the bugger so it stops checking for a c++ and fortran compiler.
353     Do *not* regenerate aclocal.m4 for making a release until a better
354     solution is created.
355    
356 ferringb 16 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, sandbox_futils.c:
357     Removal of more hardcoded paths.
358    
359 ferringb 13 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in,
360     sandbox_futils.c: tweaks to install sandbox.bashrc, and use it.
361    
362     19 Nov 2004; Brian Harring <ferringb@gentoo.org>:
363 ferringb 6 Sandbox is now autotooled, create-localdecls needs to be killed and the code
364     shifted into configure.in. Currently builds *one* libsandbox.so- if multiple
365     are desired (-m64 and -m32 for amd64), the ebuild should do it (imo).
366     To get to a point of testing, automake && autoconf; created requisite files w/
367     a(utomake|clocal)-1.8, and autoconf 2.59. Installs to /usr/, instead of
368     /lib and /usr/lib/portage/bin.
369    
370 ferringb 2 14 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox.c:
371     closing out bug #70225, potential overflow of the sandbox_pids_file var.
372    
373     07 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c: c99 standard,
374     (think it was at least) allows intermixing of code and data segments. bug #70351
375     should be fixed by this.
376    
377     03 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox_futils.c:
378     futils fix from bug #65201 via solar, and libsandbox log path checks via #69137
379    
380     02 Aug 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Code from
381     Seth Robertson that tracked down all adjuct flags for read operations that
382     do not invoke a write operation.
383    
384     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
385     Another fix from jstubbs regarding a free() on a stack variable for the
386     environment -- tracking now prevents extraneous free()'s segfault.
387    
388     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
389     J. Stubbs tracked down a new bug where mkdir was failing to the patch on
390     the lstat in mkdir... it now only returns 0 or -1 as documented for mkdir.
391     Also remove the errno = ESUCCESS settings as documentation points out that
392     a library isn't allowed to do that.
393    
394     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Added a
395     file_security_check() function to check random potential exploits on files
396     that sandbox is to load and read -- Normally sandboxpids.tmp. This fixes
397     the 'system-crippling' exploits (bug 21923) and catches a few other
398     potential problems.
399    
400     20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> Makefile: Updates for
401     32/64 bit sandbox. Made CC and LD '?=' values to allow passed in CC to work.
402    
403     20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c:
404     bug 42048 -- Fixed the lstat/errno conditions for mkdir <caleb@g.o>.
405     Added the 64/32 bit sandbox patch for AMD64 bug 32963 <brad/azarah>.
406    
407     29 Feb 2004; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c :
408     Fix permissions and group of pids file and logs. Permissions should be 0664
409     and group should be 'portage'. Bug #34260.
410    
411     28 Feb 2004; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
412     Besides a small cleanup, redo how we replace LD_PRELOAD in the environ passed
413     to the real execve (in our execve wrapper). Seems that on some arches (sparc
414     among others) do not allow us to tamper with the readonly copy passed to
415     execve, so pass our own copy of the environment. Bug #42290.
416    
417     11 Jan 2004; Nicholas Jones <carpaski@gentoo.org> create-decls:
418     Changed tail to head and added a notice about duration of glibc check.
419    
420     21 Dec 2003; Nicholas Jones <carpaski@gentoo.org> create-decls:
421     Changed the glibc subversion check to use /usr/bin/* instead of /bin/sh
422     as there isn't a guarentee that it is dynamic.
423    
424     02 Nov 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
425     If 'file' passed to before_syscall(const char *func, const char *file) is
426     invalid, we should set errno to ENOENT, and not EINVAL. This should
427     close bug #32238.
428    
429     14 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
430     Fix a bug that occurs mainly on 64bit arch, where the file passed to
431     the functions we wrap, is invalid, and then cause canonicalize to pass
432     garbage to before_syscall(), thanks to great detective work from
433     Andrea Luzzardi <al@sig11.org> (bug #29846).
434    
435     13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
436     Add a uClibc detection patch from Peter S. Mazinger <ps.m@gmx.net>.
437    
438     13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
439     Fix a bug in libsandbox.c 's checking in the rename wrapper - it basically
440     only checked the destination patch, and not the source, so we could move
441     a protected file to a unprotected directory, and then delete/modify it.
442     Thanks to Andrea Luzzardi (scox) <al@sig11.org>, bug #30992, for this fix.
443    
444     12 Oct 2003; Nicholas Jones <carpaski@gentoo.org> sandbox.c :
445     Added python2.3 to the predict section/variable.
446    
447     28 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
448     sandbox.h, sandbox_futils.c :
449     Add support to set the pids file via SANDBOX_PIDS_FILE at startup. If
450     it is not set, it will revert to its old value.
451    
452     27 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
453     Fix our mkdir wrapper to check if the dir exist, and return EEXIST if so,
454     rather than failing with a violation, bug #29748.
455    
456     27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
457     Fix canonicalize() to ignore calls with path = "".
458    
459     27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c,
460     sandbox_futils.c, canonicalize.c :
461     Once again coreutils fails, as my systems had 2.5 kernel, the getcwd system
462     call handled strings larger than PATH_MAX (bug #21766). It however does not
463     work the same on 2.4 kernels.
464    
465     To fix, I added the posix implementation of getcwd() (from glibc cvs) that
466     do not need the system call. We use the default getcwd() function via a
467     wrapper (egetcwd), and then lstat the returned path. If lstat fails, it
468     means the current directory was removed, OR that the the system call for
469     getcwd failed (curious is that it do not fail and return NULL or set
470     errno, but rather just truncate the retured directory - usually from the
471     start), and if so, we use the generic getcwd() function (__egetcwd). Note
472     that we do not use the generic version all the time, as it calls lstat()
473     a great number of times, and performance degrade much.
474    
475     29 Jun 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls,
476     libsandbox.c :
477     Make sure SB_PATH_MAX will not wrap. Fix two possible memory leaks.
478    
479     22 Jun 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, canonicalize.c
480     create-localdecls :
481     When checking path names of files accessed, we need to canonicalize it, else
482     it may be a symlink in a 'write allowed' directory pointing to a file in a
483     directory we should not have write access to.
484    
485     With something like coreutils-5.0, we have two problems:
486     1) One of the tests checks if getcwd() can return a path longer than
487     PATH_MAX. This test then tries to create a dir which even while
488     created local (mkdir("conftest2")), it ends up being resolved with
489     a name that is much larger than PATH_MAX. The problem now is that
490     canonicalize() have undefined behaviour when the path was too long
491     (returned wrongly truncated paths, etc), and pass the wrong path to
492     before_syscall() (causing the bogus sandbox violations).
493     2) The ecanonicalize() function we used, along with the canonicalize()
494     function did not support longer than PATH_MAX. This is partly a
495     cause for 1), but the error checking (rather lack of it) of calls
496     to erealpath() in canonicalize() was the prime reason for 1).
497    
498     As we do not use this canonicalized name to call the function, we resolve this
499     by fixing canonicalize() to do better error checking, and ecanonicalize() as
500     well as all functions in libsandbox.c to use a PATH_MAX of 'PATH_MAX * 2'.
501     While they will resolve paths properly now, and can check if a write/read is
502     allowed, the functions called from the sandboxed environment will still work
503     as expected.
504    
505     This should resolve bug #21766.
506    
507     06 Apr 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
508     For some reason sandbox fails with a 'open_wr' if you run 'locale -a' under
509     it (bug #16298).
510    
511     Problem is that for some reason locale fopen's locale.alias with mode "rm".
512    
513     -------------------------------------------------------
514     nosferatu root # grep fopen locale.log
515     fopen("/usr/share/locale/locale.alias", "rm"ACCESS DENIED open_wr: /usr/share/locale/locale.alias
516     nosferatu root #
517     --------------------------------------------------------
518    
519     I checked the source of locale, but it have fopen with mode 'r', so
520     not sure where the "rm" mode comes from. Anyhow, changed the check in
521     before_syscall_open_char() to also see mode "rm" as readonly.
522    
523     23 Feb 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
524    
525     Add glibc-2.3 support.
526    
527     22 Feb 2003; Martin Schlemmer <azarah@gentoo.org> sandbox.c :
528    
529     Some /etc/ld.so.preload fixes. Just changed the #if defines to cover all
530     operations releated to preload, as well as only try to modify ld.so.preload
531     if we can. Also modify to write the pid to /tmp/sandboxpids.tmp even when
532     not using ld.so.preload. Fix to not write this instance of sandbox's pid
533     to /tmp/sandboxpids.tmp on exit if this is not the last sandbox running.
534    
535     22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> Makefile :
536    
537     Changed the LD to CC for hppa.
538    
539     22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
540    
541     Killed the previous changes I made.
542    
543     17 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
544    
545     Added parisc to BROKEN_RTLD_ARCHLIST to see if it we can fix the relocation probs.
546    
547     09 Jan 2003; J Robert Ray <jrray@gentoo.org> sandbox.c :
548    
549     Don't segfault if $HOME isn't set, set $HOME to "/" instead. Fixes bug 10868.
550    
551     16 Dec 2002; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
552    
553     Fix memory leak for mips, bug #12236. Thanks to Torgeir Hansen <torgeir@trenger.ro>
554     for this fix.
555    
556     4 Dec 2002; J Robert Ray <jrray@gentoo.org> sandbox.h sandbox_futils.c :
557    
558     sandbox_futils defined a dirname() function that was masking the same
559     function in glibc and was broken (e.g.: SANDBOX_DIR was being set to
560     '/usr/lib/portage/bi/'). Fixed function to return expected results and
561     renamed it to sb_dirname() to no longer mask the glibc function. Closes bug
562     11231.
563    
564     4 Dec 2002; Martin Schlemmer <azarah@gentoo.org> :
565    
566     Fix a segfault in libsandbox.c if canonicalize() was called with
567     first parameter = NULL.
568    
569     1 Sep 2002; Martin Schlemmer <azarah@gentoo.org> :
570    
571     Fix my braindead 'return 1;' in a void function. Updated sandbox.c,
572     cleanup() for this.
573    
574     Change cleanup() in sandbox.c not to exit with fail status if
575     the pidsfile is missing. We really should still display sandbox
576     violations if they occured.
577    
578     31 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
579    
580     Update cleanup() in sandbox.c to remove the PIDSFILE if this is
581     the last sandbox running.
582    
583     25 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
584    
585     Major cleanups to mainly libsandbox.c again.
586    
587     22 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
588    
589     Add copyrights to sandbox.h and sandbox_futils.h. If wrong, the
590     parties involved should please contact me so that we can fix it.
591    
592     Add opendir wrapper to libsandbox.c.
593    
594     21 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
595    
596     Do some more cleanups to ecanonicalize(), as it dropped filenames in
597     rare cases (after my symlink cleanups), and caused glibc to bork.
598     These fixes went into canonicalize.c.
599    
600     20 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
601    
602     Fix spawn_shell() and main() in sandbox.c to properly return fail
603     status.
604    
605     19 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
606    
607     The new canonicalize() function in libsandbox.c also resolved symlinks,
608     which caused on cleaning sandbox errors if the symlink pointed to a
609     file in the live root. Ripped out canonicalize() and realpath() from
610     glibc; removed the symlink stuff, and changed them to ecanonicalize()
611     and erealpath().
612    
613     18 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
614    
615     Ripped out all the wrappers, and implemented those of InstallWatch.
616     Losts of cleanups and bugfixes. Implement a execve that forces
617     $LIBSANDBOX in $LD_PRELOAD. We can now thus do away with the feared
618     /etc/ld.so.preload (*g*) ... Made the needed changes to sandbox.c,
619     sandbox.h and sandbox_futils.c. Rewrote the Makefile for most
620     parts; it now have an install target.
621    
622     Reformat the whole thing to look somewhat like the reworked sandbox.c
623     and new sandbox.h and sandbox_futils.c from:
624    
625     Brad House <brad@mainstreetsoftworks.com>.
626    
627     Additional Copyrights now due to the InstallWatch code:
628    
629     Copyright (C) 1998-9 Pancrazio `Ezio' de Mauro <p@demauro.net>

Properties

Name Value
svn:eol-style native
svn:keywords Author Date Id Revision

  ViewVC Help
Powered by ViewVC 1.1.20