/[path-sandbox]/trunk/ChangeLog
Gentoo

Contents of /trunk/ChangeLog

Parent Directory Parent Directory | Revision Log Revision Log


Revision 36 - (hide annotations) (download)
Sun Mar 13 23:29:28 2005 UTC (9 years, 8 months ago) by azarah
File size: 16078 byte(s)
Also rename the _init() and _fini() declarations.

1 ferringb 2 # ChangeLog for Path Sandbox
2     # Copyright 1999-2004 Gentoo Foundation; Distributed under the GPL v2
3     # $Header$
4    
5 azarah 36 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
6     Also rename the _init() and _fini() declarations.
7    
8 azarah 35 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
9     Fixup the constructor/destructor function names again (they should be _init()
10     and _fini() it seems, and not being called caused sandbox_lib_path to be
11     unset, and thus breaking the execve() wrapper's LD_PRELOAD protection).
12     Add both the path in given SANDBOX_x variable, as well as its symlink
13     resolved path in init_env_entries(). Modify filter_path() to be able to
14     resolve paths without resolving symlinks, as well as to be able to resolve
15     symlinks. Fix a possible segfault in check_access(). Add symlink resolving
16     to check_access() resolving bug #31019. Add 'hack' for unlink, as the fix
17     for bug #31019 cause access violations if we try to remove a symlink that is
18     not in protected path, but points to a protected path. Fix a memory leak in
19     sandbox.c (sandbox_pids_file in main()). Fix the realpath() calls in main()
20     (sandbox.c) being unchecked. Fix the debug logname not having the pid in it
21     (pid_string was uninitialized). General syntax cleanups.
22    
23 ferringb 34 09 Mar 2005; Brian Harring <ferringb@gentoo.org> sandbox.c: Fixed the
24     infamous "pids file is not a regular file" w/out newline bug.
25    
26 ferringb 33 09 Mar 2005; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in:
27     Correct libc_version path detection, since it was screwing up if libdir !=
28     "/lib/".
29    
30     02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
31 azarah 32 Hack to make sure sandboxed process cannot remove a device node, bug #79836.
32    
33 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am:
34 azarah 31 Fix symbols.in not added to dist.
35    
36 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
37 azarah 30 getcwd.c, libsandbox.c, sandbox.c, sandbox.h, sandbox_futils.c:
38     White space fixes.
39    
40 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
41 azarah 30 configure.in, getcwd.c, libsandbox.c, symbols.in:
42 azarah 29 Fix inverse test logic in canonicalize.c, use a strncpy. Fix gcc warning in
43     getcwd.c. Add symbols.in and logic to Makefile.am to generate symbol versions
44     for glibc and other libc's that use this. Update libsandbox.c to use these
45     symbol versions if available. Fix exec wrapper to re-export LD_PRELOAD if the
46     process unset it.
47    
48 ferringb 33 01 Mar 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
49 ferringb 28 killed off _init and _fini in favor of
50     void __attribute__ ((constructor)) init_func and
51     void __attribute__ ((destructor)) closing_func. _(init|func) were deprecated.
52    
53 ferringb 26 06 Dec 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, libsandbox.c,
54     canonicalize.c, getcwd.c: Fixed compilation *again*. Hopefully cvs is done
55     having the hick-ups.
56    
57 ferringb 24 04 Dec 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, getcwd.c,
58     Makefile.am: Fixed compilation.
59    
60 ferringb 18 01 Dec 2004; Brian Harring <ferringb@gentoo.org> aclocal.m4:
61     Gutted the bugger so it stops checking for a c++ and fortran compiler.
62     Do *not* regenerate aclocal.m4 for making a release until a better
63     solution is created.
64    
65 ferringb 16 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, sandbox_futils.c:
66     Removal of more hardcoded paths.
67    
68 ferringb 13 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in,
69     sandbox_futils.c: tweaks to install sandbox.bashrc, and use it.
70    
71     19 Nov 2004; Brian Harring <ferringb@gentoo.org>:
72 ferringb 6 Sandbox is now autotooled, create-localdecls needs to be killed and the code
73     shifted into configure.in. Currently builds *one* libsandbox.so- if multiple
74     are desired (-m64 and -m32 for amd64), the ebuild should do it (imo).
75     To get to a point of testing, automake && autoconf; created requisite files w/
76     a(utomake|clocal)-1.8, and autoconf 2.59. Installs to /usr/, instead of
77     /lib and /usr/lib/portage/bin.
78    
79 ferringb 2 14 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox.c:
80     closing out bug #70225, potential overflow of the sandbox_pids_file var.
81    
82     07 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c: c99 standard,
83     (think it was at least) allows intermixing of code and data segments. bug #70351
84     should be fixed by this.
85    
86     03 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox_futils.c:
87     futils fix from bug #65201 via solar, and libsandbox log path checks via #69137
88    
89     02 Aug 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Code from
90     Seth Robertson that tracked down all adjuct flags for read operations that
91     do not invoke a write operation.
92    
93     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
94     Another fix from jstubbs regarding a free() on a stack variable for the
95     environment -- tracking now prevents extraneous free()'s segfault.
96    
97     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
98     J. Stubbs tracked down a new bug where mkdir was failing to the patch on
99     the lstat in mkdir... it now only returns 0 or -1 as documented for mkdir.
100     Also remove the errno = ESUCCESS settings as documentation points out that
101     a library isn't allowed to do that.
102    
103     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Added a
104     file_security_check() function to check random potential exploits on files
105     that sandbox is to load and read -- Normally sandboxpids.tmp. This fixes
106     the 'system-crippling' exploits (bug 21923) and catches a few other
107     potential problems.
108    
109     20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> Makefile: Updates for
110     32/64 bit sandbox. Made CC and LD '?=' values to allow passed in CC to work.
111    
112     20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c:
113     bug 42048 -- Fixed the lstat/errno conditions for mkdir <caleb@g.o>.
114     Added the 64/32 bit sandbox patch for AMD64 bug 32963 <brad/azarah>.
115    
116     29 Feb 2004; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c :
117     Fix permissions and group of pids file and logs. Permissions should be 0664
118     and group should be 'portage'. Bug #34260.
119    
120     28 Feb 2004; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
121     Besides a small cleanup, redo how we replace LD_PRELOAD in the environ passed
122     to the real execve (in our execve wrapper). Seems that on some arches (sparc
123     among others) do not allow us to tamper with the readonly copy passed to
124     execve, so pass our own copy of the environment. Bug #42290.
125    
126     11 Jan 2004; Nicholas Jones <carpaski@gentoo.org> create-decls:
127     Changed tail to head and added a notice about duration of glibc check.
128    
129     21 Dec 2003; Nicholas Jones <carpaski@gentoo.org> create-decls:
130     Changed the glibc subversion check to use /usr/bin/* instead of /bin/sh
131     as there isn't a guarentee that it is dynamic.
132    
133     02 Nov 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
134     If 'file' passed to before_syscall(const char *func, const char *file) is
135     invalid, we should set errno to ENOENT, and not EINVAL. This should
136     close bug #32238.
137    
138     14 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
139     Fix a bug that occurs mainly on 64bit arch, where the file passed to
140     the functions we wrap, is invalid, and then cause canonicalize to pass
141     garbage to before_syscall(), thanks to great detective work from
142     Andrea Luzzardi <al@sig11.org> (bug #29846).
143    
144     13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
145     Add a uClibc detection patch from Peter S. Mazinger <ps.m@gmx.net>.
146    
147     13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
148     Fix a bug in libsandbox.c 's checking in the rename wrapper - it basically
149     only checked the destination patch, and not the source, so we could move
150     a protected file to a unprotected directory, and then delete/modify it.
151     Thanks to Andrea Luzzardi (scox) <al@sig11.org>, bug #30992, for this fix.
152    
153     12 Oct 2003; Nicholas Jones <carpaski@gentoo.org> sandbox.c :
154     Added python2.3 to the predict section/variable.
155    
156     28 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
157     sandbox.h, sandbox_futils.c :
158     Add support to set the pids file via SANDBOX_PIDS_FILE at startup. If
159     it is not set, it will revert to its old value.
160    
161     27 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
162     Fix our mkdir wrapper to check if the dir exist, and return EEXIST if so,
163     rather than failing with a violation, bug #29748.
164    
165     27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
166     Fix canonicalize() to ignore calls with path = "".
167    
168     27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c,
169     sandbox_futils.c, canonicalize.c :
170     Once again coreutils fails, as my systems had 2.5 kernel, the getcwd system
171     call handled strings larger than PATH_MAX (bug #21766). It however does not
172     work the same on 2.4 kernels.
173    
174     To fix, I added the posix implementation of getcwd() (from glibc cvs) that
175     do not need the system call. We use the default getcwd() function via a
176     wrapper (egetcwd), and then lstat the returned path. If lstat fails, it
177     means the current directory was removed, OR that the the system call for
178     getcwd failed (curious is that it do not fail and return NULL or set
179     errno, but rather just truncate the retured directory - usually from the
180     start), and if so, we use the generic getcwd() function (__egetcwd). Note
181     that we do not use the generic version all the time, as it calls lstat()
182     a great number of times, and performance degrade much.
183    
184     29 Jun 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls,
185     libsandbox.c :
186     Make sure SB_PATH_MAX will not wrap. Fix two possible memory leaks.
187    
188     22 Jun 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, canonicalize.c
189     create-localdecls :
190     When checking path names of files accessed, we need to canonicalize it, else
191     it may be a symlink in a 'write allowed' directory pointing to a file in a
192     directory we should not have write access to.
193    
194     With something like coreutils-5.0, we have two problems:
195     1) One of the tests checks if getcwd() can return a path longer than
196     PATH_MAX. This test then tries to create a dir which even while
197     created local (mkdir("conftest2")), it ends up being resolved with
198     a name that is much larger than PATH_MAX. The problem now is that
199     canonicalize() have undefined behaviour when the path was too long
200     (returned wrongly truncated paths, etc), and pass the wrong path to
201     before_syscall() (causing the bogus sandbox violations).
202     2) The ecanonicalize() function we used, along with the canonicalize()
203     function did not support longer than PATH_MAX. This is partly a
204     cause for 1), but the error checking (rather lack of it) of calls
205     to erealpath() in canonicalize() was the prime reason for 1).
206    
207     As we do not use this canonicalized name to call the function, we resolve this
208     by fixing canonicalize() to do better error checking, and ecanonicalize() as
209     well as all functions in libsandbox.c to use a PATH_MAX of 'PATH_MAX * 2'.
210     While they will resolve paths properly now, and can check if a write/read is
211     allowed, the functions called from the sandboxed environment will still work
212     as expected.
213    
214     This should resolve bug #21766.
215    
216     06 Apr 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
217     For some reason sandbox fails with a 'open_wr' if you run 'locale -a' under
218     it (bug #16298).
219    
220     Problem is that for some reason locale fopen's locale.alias with mode "rm".
221    
222     -------------------------------------------------------
223     nosferatu root # grep fopen locale.log
224     fopen("/usr/share/locale/locale.alias", "rm"ACCESS DENIED open_wr: /usr/share/locale/locale.alias
225     nosferatu root #
226     --------------------------------------------------------
227    
228     I checked the source of locale, but it have fopen with mode 'r', so
229     not sure where the "rm" mode comes from. Anyhow, changed the check in
230     before_syscall_open_char() to also see mode "rm" as readonly.
231    
232     23 Feb 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
233    
234     Add glibc-2.3 support.
235    
236     22 Feb 2003; Martin Schlemmer <azarah@gentoo.org> sandbox.c :
237    
238     Some /etc/ld.so.preload fixes. Just changed the #if defines to cover all
239     operations releated to preload, as well as only try to modify ld.so.preload
240     if we can. Also modify to write the pid to /tmp/sandboxpids.tmp even when
241     not using ld.so.preload. Fix to not write this instance of sandbox's pid
242     to /tmp/sandboxpids.tmp on exit if this is not the last sandbox running.
243    
244     22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> Makefile :
245    
246     Changed the LD to CC for hppa.
247    
248     22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
249    
250     Killed the previous changes I made.
251    
252     17 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
253    
254     Added parisc to BROKEN_RTLD_ARCHLIST to see if it we can fix the relocation probs.
255    
256     09 Jan 2003; J Robert Ray <jrray@gentoo.org> sandbox.c :
257    
258     Don't segfault if $HOME isn't set, set $HOME to "/" instead. Fixes bug 10868.
259    
260     16 Dec 2002; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
261    
262     Fix memory leak for mips, bug #12236. Thanks to Torgeir Hansen <torgeir@trenger.ro>
263     for this fix.
264    
265     4 Dec 2002; J Robert Ray <jrray@gentoo.org> sandbox.h sandbox_futils.c :
266    
267     sandbox_futils defined a dirname() function that was masking the same
268     function in glibc and was broken (e.g.: SANDBOX_DIR was being set to
269     '/usr/lib/portage/bi/'). Fixed function to return expected results and
270     renamed it to sb_dirname() to no longer mask the glibc function. Closes bug
271     11231.
272    
273     4 Dec 2002; Martin Schlemmer <azarah@gentoo.org> :
274    
275     Fix a segfault in libsandbox.c if canonicalize() was called with
276     first parameter = NULL.
277    
278     1 Sep 2002; Martin Schlemmer <azarah@gentoo.org> :
279    
280     Fix my braindead 'return 1;' in a void function. Updated sandbox.c,
281     cleanup() for this.
282    
283     Change cleanup() in sandbox.c not to exit with fail status if
284     the pidsfile is missing. We really should still display sandbox
285     violations if they occured.
286    
287     31 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
288    
289     Update cleanup() in sandbox.c to remove the PIDSFILE if this is
290     the last sandbox running.
291    
292     25 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
293    
294     Major cleanups to mainly libsandbox.c again.
295    
296     22 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
297    
298     Add copyrights to sandbox.h and sandbox_futils.h. If wrong, the
299     parties involved should please contact me so that we can fix it.
300    
301     Add opendir wrapper to libsandbox.c.
302    
303     21 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
304    
305     Do some more cleanups to ecanonicalize(), as it dropped filenames in
306     rare cases (after my symlink cleanups), and caused glibc to bork.
307     These fixes went into canonicalize.c.
308    
309     20 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
310    
311     Fix spawn_shell() and main() in sandbox.c to properly return fail
312     status.
313    
314     19 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
315    
316     The new canonicalize() function in libsandbox.c also resolved symlinks,
317     which caused on cleaning sandbox errors if the symlink pointed to a
318     file in the live root. Ripped out canonicalize() and realpath() from
319     glibc; removed the symlink stuff, and changed them to ecanonicalize()
320     and erealpath().
321    
322     18 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
323    
324     Ripped out all the wrappers, and implemented those of InstallWatch.
325     Losts of cleanups and bugfixes. Implement a execve that forces
326     $LIBSANDBOX in $LD_PRELOAD. We can now thus do away with the feared
327     /etc/ld.so.preload (*g*) ... Made the needed changes to sandbox.c,
328     sandbox.h and sandbox_futils.c. Rewrote the Makefile for most
329     parts; it now have an install target.
330    
331     Reformat the whole thing to look somewhat like the reworked sandbox.c
332     and new sandbox.h and sandbox_futils.c from:
333    
334     Brad House <brad@mainstreetsoftworks.com>.
335    
336     Additional Copyrights now due to the InstallWatch code:
337    
338     Copyright (C) 1998-9 Pancrazio `Ezio' de Mauro <p@demauro.net>

Properties

Name Value
svn:eol-style native
svn:keywords Author Date Id Revision

  ViewVC Help
Powered by ViewVC 1.1.20