/[path-sandbox]/trunk/ChangeLog
Gentoo

Contents of /trunk/ChangeLog

Parent Directory Parent Directory | Revision Log Revision Log


Revision 46 - (hide annotations) (download)
Sat Apr 23 21:03:40 2005 UTC (9 years, 7 months ago) by azarah
File size: 16964 byte(s)
Add sandbox-1.2 release comment to ChangeLog

1 ferringb 2 # ChangeLog for Path Sandbox
2     # Copyright 1999-2004 Gentoo Foundation; Distributed under the GPL v2
3     # $Header$
4    
5 azarah 44 * sandbox-1.2.1
6    
7 azarah 43 23 Apr 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
8     getcwd.c, libsandbox.c, localdecls.h, sandbox.h, sandbox_futils.c:
9     Make sure all functions used in libsandbox.c is declared static. Define
10     SB_STATIC in localdecls.h for this. Include sandbox_futils.c rather than
11     linking with its object. Hopefully this will fix bug #90153.
12    
13 azarah 46 * sandbox-1.2
14    
15 azarah 40 22 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
16     Allow lchown a symlink in write-allowed path pointing to write-denied
17     target.
18    
19 genone 39 21 Mar 2005; Marius Mauch <genone@gentoo.org> libsandbox.c:
20     Also show resolved symlink names in the log.
21    
22 azarah 37 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, libsandbox.c:
23     Seems -nostdlib was the problem with the constructor/destructor - remove it
24     from Makefile.am, and change the constructor/destructor names again.
25    
26 azarah 36 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
27     Also rename the _init() and _fini() declarations.
28    
29 azarah 35 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
30     Fixup the constructor/destructor function names again (they should be _init()
31     and _fini() it seems, and not being called caused sandbox_lib_path to be
32     unset, and thus breaking the execve() wrapper's LD_PRELOAD protection).
33     Add both the path in given SANDBOX_x variable, as well as its symlink
34     resolved path in init_env_entries(). Modify filter_path() to be able to
35     resolve paths without resolving symlinks, as well as to be able to resolve
36     symlinks. Fix a possible segfault in check_access(). Add symlink resolving
37     to check_access() resolving bug #31019. Add 'hack' for unlink, as the fix
38     for bug #31019 cause access violations if we try to remove a symlink that is
39     not in protected path, but points to a protected path. Fix a memory leak in
40     sandbox.c (sandbox_pids_file in main()). Fix the realpath() calls in main()
41     (sandbox.c) being unchecked. Fix the debug logname not having the pid in it
42     (pid_string was uninitialized). General syntax cleanups.
43    
44 ferringb 34 09 Mar 2005; Brian Harring <ferringb@gentoo.org> sandbox.c: Fixed the
45     infamous "pids file is not a regular file" w/out newline bug.
46    
47 ferringb 33 09 Mar 2005; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in:
48     Correct libc_version path detection, since it was screwing up if libdir !=
49     "/lib/".
50    
51     02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
52 azarah 32 Hack to make sure sandboxed process cannot remove a device node, bug #79836.
53    
54 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am:
55 azarah 31 Fix symbols.in not added to dist.
56    
57 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
58 azarah 30 getcwd.c, libsandbox.c, sandbox.c, sandbox.h, sandbox_futils.c:
59     White space fixes.
60    
61 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
62 azarah 30 configure.in, getcwd.c, libsandbox.c, symbols.in:
63 azarah 29 Fix inverse test logic in canonicalize.c, use a strncpy. Fix gcc warning in
64     getcwd.c. Add symbols.in and logic to Makefile.am to generate symbol versions
65     for glibc and other libc's that use this. Update libsandbox.c to use these
66     symbol versions if available. Fix exec wrapper to re-export LD_PRELOAD if the
67     process unset it.
68    
69 ferringb 33 01 Mar 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
70 ferringb 28 killed off _init and _fini in favor of
71     void __attribute__ ((constructor)) init_func and
72     void __attribute__ ((destructor)) closing_func. _(init|func) were deprecated.
73    
74 ferringb 26 06 Dec 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, libsandbox.c,
75     canonicalize.c, getcwd.c: Fixed compilation *again*. Hopefully cvs is done
76     having the hick-ups.
77    
78 ferringb 24 04 Dec 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, getcwd.c,
79     Makefile.am: Fixed compilation.
80    
81 ferringb 18 01 Dec 2004; Brian Harring <ferringb@gentoo.org> aclocal.m4:
82     Gutted the bugger so it stops checking for a c++ and fortran compiler.
83     Do *not* regenerate aclocal.m4 for making a release until a better
84     solution is created.
85    
86 ferringb 16 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, sandbox_futils.c:
87     Removal of more hardcoded paths.
88    
89 ferringb 13 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in,
90     sandbox_futils.c: tweaks to install sandbox.bashrc, and use it.
91    
92     19 Nov 2004; Brian Harring <ferringb@gentoo.org>:
93 ferringb 6 Sandbox is now autotooled, create-localdecls needs to be killed and the code
94     shifted into configure.in. Currently builds *one* libsandbox.so- if multiple
95     are desired (-m64 and -m32 for amd64), the ebuild should do it (imo).
96     To get to a point of testing, automake && autoconf; created requisite files w/
97     a(utomake|clocal)-1.8, and autoconf 2.59. Installs to /usr/, instead of
98     /lib and /usr/lib/portage/bin.
99    
100 ferringb 2 14 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox.c:
101     closing out bug #70225, potential overflow of the sandbox_pids_file var.
102    
103     07 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c: c99 standard,
104     (think it was at least) allows intermixing of code and data segments. bug #70351
105     should be fixed by this.
106    
107     03 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox_futils.c:
108     futils fix from bug #65201 via solar, and libsandbox log path checks via #69137
109    
110     02 Aug 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Code from
111     Seth Robertson that tracked down all adjuct flags for read operations that
112     do not invoke a write operation.
113    
114     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
115     Another fix from jstubbs regarding a free() on a stack variable for the
116     environment -- tracking now prevents extraneous free()'s segfault.
117    
118     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
119     J. Stubbs tracked down a new bug where mkdir was failing to the patch on
120     the lstat in mkdir... it now only returns 0 or -1 as documented for mkdir.
121     Also remove the errno = ESUCCESS settings as documentation points out that
122     a library isn't allowed to do that.
123    
124     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Added a
125     file_security_check() function to check random potential exploits on files
126     that sandbox is to load and read -- Normally sandboxpids.tmp. This fixes
127     the 'system-crippling' exploits (bug 21923) and catches a few other
128     potential problems.
129    
130     20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> Makefile: Updates for
131     32/64 bit sandbox. Made CC and LD '?=' values to allow passed in CC to work.
132    
133     20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c:
134     bug 42048 -- Fixed the lstat/errno conditions for mkdir <caleb@g.o>.
135     Added the 64/32 bit sandbox patch for AMD64 bug 32963 <brad/azarah>.
136    
137     29 Feb 2004; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c :
138     Fix permissions and group of pids file and logs. Permissions should be 0664
139     and group should be 'portage'. Bug #34260.
140    
141     28 Feb 2004; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
142     Besides a small cleanup, redo how we replace LD_PRELOAD in the environ passed
143     to the real execve (in our execve wrapper). Seems that on some arches (sparc
144     among others) do not allow us to tamper with the readonly copy passed to
145     execve, so pass our own copy of the environment. Bug #42290.
146    
147     11 Jan 2004; Nicholas Jones <carpaski@gentoo.org> create-decls:
148     Changed tail to head and added a notice about duration of glibc check.
149    
150     21 Dec 2003; Nicholas Jones <carpaski@gentoo.org> create-decls:
151     Changed the glibc subversion check to use /usr/bin/* instead of /bin/sh
152     as there isn't a guarentee that it is dynamic.
153    
154     02 Nov 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
155     If 'file' passed to before_syscall(const char *func, const char *file) is
156     invalid, we should set errno to ENOENT, and not EINVAL. This should
157     close bug #32238.
158    
159     14 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
160     Fix a bug that occurs mainly on 64bit arch, where the file passed to
161     the functions we wrap, is invalid, and then cause canonicalize to pass
162     garbage to before_syscall(), thanks to great detective work from
163     Andrea Luzzardi <al@sig11.org> (bug #29846).
164    
165     13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
166     Add a uClibc detection patch from Peter S. Mazinger <ps.m@gmx.net>.
167    
168     13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
169     Fix a bug in libsandbox.c 's checking in the rename wrapper - it basically
170     only checked the destination patch, and not the source, so we could move
171     a protected file to a unprotected directory, and then delete/modify it.
172     Thanks to Andrea Luzzardi (scox) <al@sig11.org>, bug #30992, for this fix.
173    
174     12 Oct 2003; Nicholas Jones <carpaski@gentoo.org> sandbox.c :
175     Added python2.3 to the predict section/variable.
176    
177     28 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
178     sandbox.h, sandbox_futils.c :
179     Add support to set the pids file via SANDBOX_PIDS_FILE at startup. If
180     it is not set, it will revert to its old value.
181    
182     27 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
183     Fix our mkdir wrapper to check if the dir exist, and return EEXIST if so,
184     rather than failing with a violation, bug #29748.
185    
186     27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
187     Fix canonicalize() to ignore calls with path = "".
188    
189     27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c,
190     sandbox_futils.c, canonicalize.c :
191     Once again coreutils fails, as my systems had 2.5 kernel, the getcwd system
192     call handled strings larger than PATH_MAX (bug #21766). It however does not
193     work the same on 2.4 kernels.
194    
195     To fix, I added the posix implementation of getcwd() (from glibc cvs) that
196     do not need the system call. We use the default getcwd() function via a
197     wrapper (egetcwd), and then lstat the returned path. If lstat fails, it
198     means the current directory was removed, OR that the the system call for
199     getcwd failed (curious is that it do not fail and return NULL or set
200     errno, but rather just truncate the retured directory - usually from the
201     start), and if so, we use the generic getcwd() function (__egetcwd). Note
202     that we do not use the generic version all the time, as it calls lstat()
203     a great number of times, and performance degrade much.
204    
205     29 Jun 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls,
206     libsandbox.c :
207     Make sure SB_PATH_MAX will not wrap. Fix two possible memory leaks.
208    
209     22 Jun 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, canonicalize.c
210     create-localdecls :
211     When checking path names of files accessed, we need to canonicalize it, else
212     it may be a symlink in a 'write allowed' directory pointing to a file in a
213     directory we should not have write access to.
214    
215     With something like coreutils-5.0, we have two problems:
216     1) One of the tests checks if getcwd() can return a path longer than
217     PATH_MAX. This test then tries to create a dir which even while
218     created local (mkdir("conftest2")), it ends up being resolved with
219     a name that is much larger than PATH_MAX. The problem now is that
220     canonicalize() have undefined behaviour when the path was too long
221     (returned wrongly truncated paths, etc), and pass the wrong path to
222     before_syscall() (causing the bogus sandbox violations).
223     2) The ecanonicalize() function we used, along with the canonicalize()
224     function did not support longer than PATH_MAX. This is partly a
225     cause for 1), but the error checking (rather lack of it) of calls
226     to erealpath() in canonicalize() was the prime reason for 1).
227    
228     As we do not use this canonicalized name to call the function, we resolve this
229     by fixing canonicalize() to do better error checking, and ecanonicalize() as
230     well as all functions in libsandbox.c to use a PATH_MAX of 'PATH_MAX * 2'.
231     While they will resolve paths properly now, and can check if a write/read is
232     allowed, the functions called from the sandboxed environment will still work
233     as expected.
234    
235     This should resolve bug #21766.
236    
237     06 Apr 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
238     For some reason sandbox fails with a 'open_wr' if you run 'locale -a' under
239     it (bug #16298).
240    
241     Problem is that for some reason locale fopen's locale.alias with mode "rm".
242    
243     -------------------------------------------------------
244     nosferatu root # grep fopen locale.log
245     fopen("/usr/share/locale/locale.alias", "rm"ACCESS DENIED open_wr: /usr/share/locale/locale.alias
246     nosferatu root #
247     --------------------------------------------------------
248    
249     I checked the source of locale, but it have fopen with mode 'r', so
250     not sure where the "rm" mode comes from. Anyhow, changed the check in
251     before_syscall_open_char() to also see mode "rm" as readonly.
252    
253     23 Feb 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
254    
255     Add glibc-2.3 support.
256    
257     22 Feb 2003; Martin Schlemmer <azarah@gentoo.org> sandbox.c :
258    
259     Some /etc/ld.so.preload fixes. Just changed the #if defines to cover all
260     operations releated to preload, as well as only try to modify ld.so.preload
261     if we can. Also modify to write the pid to /tmp/sandboxpids.tmp even when
262     not using ld.so.preload. Fix to not write this instance of sandbox's pid
263     to /tmp/sandboxpids.tmp on exit if this is not the last sandbox running.
264    
265     22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> Makefile :
266    
267     Changed the LD to CC for hppa.
268    
269     22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
270    
271     Killed the previous changes I made.
272    
273     17 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
274    
275     Added parisc to BROKEN_RTLD_ARCHLIST to see if it we can fix the relocation probs.
276    
277     09 Jan 2003; J Robert Ray <jrray@gentoo.org> sandbox.c :
278    
279     Don't segfault if $HOME isn't set, set $HOME to "/" instead. Fixes bug 10868.
280    
281     16 Dec 2002; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
282    
283     Fix memory leak for mips, bug #12236. Thanks to Torgeir Hansen <torgeir@trenger.ro>
284     for this fix.
285    
286     4 Dec 2002; J Robert Ray <jrray@gentoo.org> sandbox.h sandbox_futils.c :
287    
288     sandbox_futils defined a dirname() function that was masking the same
289     function in glibc and was broken (e.g.: SANDBOX_DIR was being set to
290     '/usr/lib/portage/bi/'). Fixed function to return expected results and
291     renamed it to sb_dirname() to no longer mask the glibc function. Closes bug
292     11231.
293    
294     4 Dec 2002; Martin Schlemmer <azarah@gentoo.org> :
295    
296     Fix a segfault in libsandbox.c if canonicalize() was called with
297     first parameter = NULL.
298    
299     1 Sep 2002; Martin Schlemmer <azarah@gentoo.org> :
300    
301     Fix my braindead 'return 1;' in a void function. Updated sandbox.c,
302     cleanup() for this.
303    
304     Change cleanup() in sandbox.c not to exit with fail status if
305     the pidsfile is missing. We really should still display sandbox
306     violations if they occured.
307    
308     31 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
309    
310     Update cleanup() in sandbox.c to remove the PIDSFILE if this is
311     the last sandbox running.
312    
313     25 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
314    
315     Major cleanups to mainly libsandbox.c again.
316    
317     22 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
318    
319     Add copyrights to sandbox.h and sandbox_futils.h. If wrong, the
320     parties involved should please contact me so that we can fix it.
321    
322     Add opendir wrapper to libsandbox.c.
323    
324     21 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
325    
326     Do some more cleanups to ecanonicalize(), as it dropped filenames in
327     rare cases (after my symlink cleanups), and caused glibc to bork.
328     These fixes went into canonicalize.c.
329    
330     20 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
331    
332     Fix spawn_shell() and main() in sandbox.c to properly return fail
333     status.
334    
335     19 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
336    
337     The new canonicalize() function in libsandbox.c also resolved symlinks,
338     which caused on cleaning sandbox errors if the symlink pointed to a
339     file in the live root. Ripped out canonicalize() and realpath() from
340     glibc; removed the symlink stuff, and changed them to ecanonicalize()
341     and erealpath().
342    
343     18 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
344    
345     Ripped out all the wrappers, and implemented those of InstallWatch.
346     Losts of cleanups and bugfixes. Implement a execve that forces
347     $LIBSANDBOX in $LD_PRELOAD. We can now thus do away with the feared
348     /etc/ld.so.preload (*g*) ... Made the needed changes to sandbox.c,
349     sandbox.h and sandbox_futils.c. Rewrote the Makefile for most
350     parts; it now have an install target.
351    
352     Reformat the whole thing to look somewhat like the reworked sandbox.c
353     and new sandbox.h and sandbox_futils.c from:
354    
355     Brad House <brad@mainstreetsoftworks.com>.
356    
357     Additional Copyrights now due to the InstallWatch code:
358    
359     Copyright (C) 1998-9 Pancrazio `Ezio' de Mauro <p@demauro.net>

Properties

Name Value
svn:eol-style native
svn:keywords Author Date Id Revision

  ViewVC Help
Powered by ViewVC 1.1.20