/[path-sandbox]/trunk/ChangeLog
Gentoo

Contents of /trunk/ChangeLog

Parent Directory Parent Directory | Revision Log Revision Log


Revision 54 - (hide annotations) (download)
Thu Apr 28 22:41:57 2005 UTC (9 years, 7 months ago) by azarah
File size: 17442 byte(s)
Do not append '/' to pathname in filter_path() if it already ends with it.

1 ferringb 2 # ChangeLog for Path Sandbox
2 vapier 53 # Copyright 1999-2005 Gentoo Foundation; Distributed under the GPL v2
3 ferringb 2 # $Header$
4    
5 azarah 54 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
6     Do not append '/' to pathname in filter_path() if it already ends with it.
7    
8 vapier 53 28 Apr 2005; Mike Frysinger <vapier@gentoo.org> Makefile.am, configure.in:
9     With az's help, clean up autotools to work with cross-compiling.
10    
11 azarah 48 * sandbox-1.2.2
12    
13 azarah 47 28 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
14     Only check for /dev/{null,zero} for unlink hack, else ricers using /dev/shm
15     have issues; bug #90592.
16    
17 azarah 44 * sandbox-1.2.1
18    
19 azarah 43 23 Apr 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
20     getcwd.c, libsandbox.c, localdecls.h, sandbox.h, sandbox_futils.c:
21     Make sure all functions used in libsandbox.c is declared static. Define
22     SB_STATIC in localdecls.h for this. Include sandbox_futils.c rather than
23     linking with its object. Hopefully this will fix bug #90153.
24    
25 azarah 46 * sandbox-1.2
26    
27 azarah 40 22 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
28     Allow lchown a symlink in write-allowed path pointing to write-denied
29     target.
30    
31 genone 39 21 Mar 2005; Marius Mauch <genone@gentoo.org> libsandbox.c:
32     Also show resolved symlink names in the log.
33    
34 azarah 37 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, libsandbox.c:
35     Seems -nostdlib was the problem with the constructor/destructor - remove it
36     from Makefile.am, and change the constructor/destructor names again.
37    
38 azarah 36 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
39     Also rename the _init() and _fini() declarations.
40    
41 azarah 35 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
42     Fixup the constructor/destructor function names again (they should be _init()
43     and _fini() it seems, and not being called caused sandbox_lib_path to be
44     unset, and thus breaking the execve() wrapper's LD_PRELOAD protection).
45     Add both the path in given SANDBOX_x variable, as well as its symlink
46     resolved path in init_env_entries(). Modify filter_path() to be able to
47     resolve paths without resolving symlinks, as well as to be able to resolve
48     symlinks. Fix a possible segfault in check_access(). Add symlink resolving
49     to check_access() resolving bug #31019. Add 'hack' for unlink, as the fix
50     for bug #31019 cause access violations if we try to remove a symlink that is
51     not in protected path, but points to a protected path. Fix a memory leak in
52     sandbox.c (sandbox_pids_file in main()). Fix the realpath() calls in main()
53     (sandbox.c) being unchecked. Fix the debug logname not having the pid in it
54     (pid_string was uninitialized). General syntax cleanups.
55    
56 ferringb 34 09 Mar 2005; Brian Harring <ferringb@gentoo.org> sandbox.c: Fixed the
57     infamous "pids file is not a regular file" w/out newline bug.
58    
59 ferringb 33 09 Mar 2005; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in:
60     Correct libc_version path detection, since it was screwing up if libdir !=
61     "/lib/".
62    
63     02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
64 azarah 32 Hack to make sure sandboxed process cannot remove a device node, bug #79836.
65    
66 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am:
67 azarah 31 Fix symbols.in not added to dist.
68    
69 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
70 azarah 30 getcwd.c, libsandbox.c, sandbox.c, sandbox.h, sandbox_futils.c:
71     White space fixes.
72    
73 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
74 azarah 30 configure.in, getcwd.c, libsandbox.c, symbols.in:
75 azarah 29 Fix inverse test logic in canonicalize.c, use a strncpy. Fix gcc warning in
76     getcwd.c. Add symbols.in and logic to Makefile.am to generate symbol versions
77     for glibc and other libc's that use this. Update libsandbox.c to use these
78     symbol versions if available. Fix exec wrapper to re-export LD_PRELOAD if the
79     process unset it.
80    
81 ferringb 33 01 Mar 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
82 ferringb 28 killed off _init and _fini in favor of
83     void __attribute__ ((constructor)) init_func and
84     void __attribute__ ((destructor)) closing_func. _(init|func) were deprecated.
85    
86 ferringb 26 06 Dec 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, libsandbox.c,
87     canonicalize.c, getcwd.c: Fixed compilation *again*. Hopefully cvs is done
88     having the hick-ups.
89    
90 ferringb 24 04 Dec 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, getcwd.c,
91     Makefile.am: Fixed compilation.
92    
93 ferringb 18 01 Dec 2004; Brian Harring <ferringb@gentoo.org> aclocal.m4:
94     Gutted the bugger so it stops checking for a c++ and fortran compiler.
95     Do *not* regenerate aclocal.m4 for making a release until a better
96     solution is created.
97    
98 ferringb 16 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, sandbox_futils.c:
99     Removal of more hardcoded paths.
100    
101 ferringb 13 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in,
102     sandbox_futils.c: tweaks to install sandbox.bashrc, and use it.
103    
104     19 Nov 2004; Brian Harring <ferringb@gentoo.org>:
105 ferringb 6 Sandbox is now autotooled, create-localdecls needs to be killed and the code
106     shifted into configure.in. Currently builds *one* libsandbox.so- if multiple
107     are desired (-m64 and -m32 for amd64), the ebuild should do it (imo).
108     To get to a point of testing, automake && autoconf; created requisite files w/
109     a(utomake|clocal)-1.8, and autoconf 2.59. Installs to /usr/, instead of
110     /lib and /usr/lib/portage/bin.
111    
112 ferringb 2 14 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox.c:
113     closing out bug #70225, potential overflow of the sandbox_pids_file var.
114    
115     07 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c: c99 standard,
116     (think it was at least) allows intermixing of code and data segments. bug #70351
117     should be fixed by this.
118    
119     03 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox_futils.c:
120     futils fix from bug #65201 via solar, and libsandbox log path checks via #69137
121    
122     02 Aug 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Code from
123     Seth Robertson that tracked down all adjuct flags for read operations that
124     do not invoke a write operation.
125    
126     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
127     Another fix from jstubbs regarding a free() on a stack variable for the
128     environment -- tracking now prevents extraneous free()'s segfault.
129    
130     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
131     J. Stubbs tracked down a new bug where mkdir was failing to the patch on
132     the lstat in mkdir... it now only returns 0 or -1 as documented for mkdir.
133     Also remove the errno = ESUCCESS settings as documentation points out that
134     a library isn't allowed to do that.
135    
136     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Added a
137     file_security_check() function to check random potential exploits on files
138     that sandbox is to load and read -- Normally sandboxpids.tmp. This fixes
139     the 'system-crippling' exploits (bug 21923) and catches a few other
140     potential problems.
141    
142     20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> Makefile: Updates for
143     32/64 bit sandbox. Made CC and LD '?=' values to allow passed in CC to work.
144    
145     20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c:
146     bug 42048 -- Fixed the lstat/errno conditions for mkdir <caleb@g.o>.
147     Added the 64/32 bit sandbox patch for AMD64 bug 32963 <brad/azarah>.
148    
149     29 Feb 2004; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c :
150     Fix permissions and group of pids file and logs. Permissions should be 0664
151     and group should be 'portage'. Bug #34260.
152    
153     28 Feb 2004; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
154     Besides a small cleanup, redo how we replace LD_PRELOAD in the environ passed
155     to the real execve (in our execve wrapper). Seems that on some arches (sparc
156     among others) do not allow us to tamper with the readonly copy passed to
157     execve, so pass our own copy of the environment. Bug #42290.
158    
159     11 Jan 2004; Nicholas Jones <carpaski@gentoo.org> create-decls:
160     Changed tail to head and added a notice about duration of glibc check.
161    
162     21 Dec 2003; Nicholas Jones <carpaski@gentoo.org> create-decls:
163     Changed the glibc subversion check to use /usr/bin/* instead of /bin/sh
164     as there isn't a guarentee that it is dynamic.
165    
166     02 Nov 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
167     If 'file' passed to before_syscall(const char *func, const char *file) is
168     invalid, we should set errno to ENOENT, and not EINVAL. This should
169     close bug #32238.
170    
171     14 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
172     Fix a bug that occurs mainly on 64bit arch, where the file passed to
173     the functions we wrap, is invalid, and then cause canonicalize to pass
174     garbage to before_syscall(), thanks to great detective work from
175     Andrea Luzzardi <al@sig11.org> (bug #29846).
176    
177     13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
178     Add a uClibc detection patch from Peter S. Mazinger <ps.m@gmx.net>.
179    
180     13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
181     Fix a bug in libsandbox.c 's checking in the rename wrapper - it basically
182     only checked the destination patch, and not the source, so we could move
183     a protected file to a unprotected directory, and then delete/modify it.
184     Thanks to Andrea Luzzardi (scox) <al@sig11.org>, bug #30992, for this fix.
185    
186     12 Oct 2003; Nicholas Jones <carpaski@gentoo.org> sandbox.c :
187     Added python2.3 to the predict section/variable.
188    
189     28 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
190     sandbox.h, sandbox_futils.c :
191     Add support to set the pids file via SANDBOX_PIDS_FILE at startup. If
192     it is not set, it will revert to its old value.
193    
194     27 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
195     Fix our mkdir wrapper to check if the dir exist, and return EEXIST if so,
196     rather than failing with a violation, bug #29748.
197    
198     27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
199     Fix canonicalize() to ignore calls with path = "".
200    
201     27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c,
202     sandbox_futils.c, canonicalize.c :
203     Once again coreutils fails, as my systems had 2.5 kernel, the getcwd system
204     call handled strings larger than PATH_MAX (bug #21766). It however does not
205     work the same on 2.4 kernels.
206    
207     To fix, I added the posix implementation of getcwd() (from glibc cvs) that
208     do not need the system call. We use the default getcwd() function via a
209     wrapper (egetcwd), and then lstat the returned path. If lstat fails, it
210     means the current directory was removed, OR that the the system call for
211     getcwd failed (curious is that it do not fail and return NULL or set
212     errno, but rather just truncate the retured directory - usually from the
213     start), and if so, we use the generic getcwd() function (__egetcwd). Note
214     that we do not use the generic version all the time, as it calls lstat()
215     a great number of times, and performance degrade much.
216    
217     29 Jun 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls,
218     libsandbox.c :
219     Make sure SB_PATH_MAX will not wrap. Fix two possible memory leaks.
220    
221     22 Jun 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, canonicalize.c
222     create-localdecls :
223     When checking path names of files accessed, we need to canonicalize it, else
224     it may be a symlink in a 'write allowed' directory pointing to a file in a
225     directory we should not have write access to.
226    
227     With something like coreutils-5.0, we have two problems:
228     1) One of the tests checks if getcwd() can return a path longer than
229     PATH_MAX. This test then tries to create a dir which even while
230     created local (mkdir("conftest2")), it ends up being resolved with
231     a name that is much larger than PATH_MAX. The problem now is that
232     canonicalize() have undefined behaviour when the path was too long
233     (returned wrongly truncated paths, etc), and pass the wrong path to
234     before_syscall() (causing the bogus sandbox violations).
235     2) The ecanonicalize() function we used, along with the canonicalize()
236     function did not support longer than PATH_MAX. This is partly a
237     cause for 1), but the error checking (rather lack of it) of calls
238     to erealpath() in canonicalize() was the prime reason for 1).
239    
240     As we do not use this canonicalized name to call the function, we resolve this
241     by fixing canonicalize() to do better error checking, and ecanonicalize() as
242     well as all functions in libsandbox.c to use a PATH_MAX of 'PATH_MAX * 2'.
243     While they will resolve paths properly now, and can check if a write/read is
244     allowed, the functions called from the sandboxed environment will still work
245     as expected.
246    
247     This should resolve bug #21766.
248    
249     06 Apr 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
250     For some reason sandbox fails with a 'open_wr' if you run 'locale -a' under
251     it (bug #16298).
252    
253     Problem is that for some reason locale fopen's locale.alias with mode "rm".
254    
255     -------------------------------------------------------
256     nosferatu root # grep fopen locale.log
257     fopen("/usr/share/locale/locale.alias", "rm"ACCESS DENIED open_wr: /usr/share/locale/locale.alias
258     nosferatu root #
259     --------------------------------------------------------
260    
261     I checked the source of locale, but it have fopen with mode 'r', so
262     not sure where the "rm" mode comes from. Anyhow, changed the check in
263     before_syscall_open_char() to also see mode "rm" as readonly.
264    
265     23 Feb 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
266    
267     Add glibc-2.3 support.
268    
269     22 Feb 2003; Martin Schlemmer <azarah@gentoo.org> sandbox.c :
270    
271     Some /etc/ld.so.preload fixes. Just changed the #if defines to cover all
272     operations releated to preload, as well as only try to modify ld.so.preload
273     if we can. Also modify to write the pid to /tmp/sandboxpids.tmp even when
274     not using ld.so.preload. Fix to not write this instance of sandbox's pid
275     to /tmp/sandboxpids.tmp on exit if this is not the last sandbox running.
276    
277     22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> Makefile :
278    
279     Changed the LD to CC for hppa.
280    
281     22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
282    
283     Killed the previous changes I made.
284    
285     17 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
286    
287     Added parisc to BROKEN_RTLD_ARCHLIST to see if it we can fix the relocation probs.
288    
289     09 Jan 2003; J Robert Ray <jrray@gentoo.org> sandbox.c :
290    
291     Don't segfault if $HOME isn't set, set $HOME to "/" instead. Fixes bug 10868.
292    
293     16 Dec 2002; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
294    
295     Fix memory leak for mips, bug #12236. Thanks to Torgeir Hansen <torgeir@trenger.ro>
296     for this fix.
297    
298     4 Dec 2002; J Robert Ray <jrray@gentoo.org> sandbox.h sandbox_futils.c :
299    
300     sandbox_futils defined a dirname() function that was masking the same
301     function in glibc and was broken (e.g.: SANDBOX_DIR was being set to
302     '/usr/lib/portage/bi/'). Fixed function to return expected results and
303     renamed it to sb_dirname() to no longer mask the glibc function. Closes bug
304     11231.
305    
306     4 Dec 2002; Martin Schlemmer <azarah@gentoo.org> :
307    
308     Fix a segfault in libsandbox.c if canonicalize() was called with
309     first parameter = NULL.
310    
311     1 Sep 2002; Martin Schlemmer <azarah@gentoo.org> :
312    
313     Fix my braindead 'return 1;' in a void function. Updated sandbox.c,
314     cleanup() for this.
315    
316     Change cleanup() in sandbox.c not to exit with fail status if
317     the pidsfile is missing. We really should still display sandbox
318     violations if they occured.
319    
320     31 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
321    
322     Update cleanup() in sandbox.c to remove the PIDSFILE if this is
323     the last sandbox running.
324    
325     25 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
326    
327     Major cleanups to mainly libsandbox.c again.
328    
329     22 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
330    
331     Add copyrights to sandbox.h and sandbox_futils.h. If wrong, the
332     parties involved should please contact me so that we can fix it.
333    
334     Add opendir wrapper to libsandbox.c.
335    
336     21 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
337    
338     Do some more cleanups to ecanonicalize(), as it dropped filenames in
339     rare cases (after my symlink cleanups), and caused glibc to bork.
340     These fixes went into canonicalize.c.
341    
342     20 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
343    
344     Fix spawn_shell() and main() in sandbox.c to properly return fail
345     status.
346    
347     19 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
348    
349     The new canonicalize() function in libsandbox.c also resolved symlinks,
350     which caused on cleaning sandbox errors if the symlink pointed to a
351     file in the live root. Ripped out canonicalize() and realpath() from
352     glibc; removed the symlink stuff, and changed them to ecanonicalize()
353     and erealpath().
354    
355     18 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
356    
357     Ripped out all the wrappers, and implemented those of InstallWatch.
358     Losts of cleanups and bugfixes. Implement a execve that forces
359     $LIBSANDBOX in $LD_PRELOAD. We can now thus do away with the feared
360     /etc/ld.so.preload (*g*) ... Made the needed changes to sandbox.c,
361     sandbox.h and sandbox_futils.c. Rewrote the Makefile for most
362     parts; it now have an install target.
363    
364     Reformat the whole thing to look somewhat like the reworked sandbox.c
365     and new sandbox.h and sandbox_futils.c from:
366    
367     Brad House <brad@mainstreetsoftworks.com>.
368    
369     Additional Copyrights now due to the InstallWatch code:
370    
371     Copyright (C) 1998-9 Pancrazio `Ezio' de Mauro <p@demauro.net>

Properties

Name Value
svn:eol-style native
svn:keywords Author Date Id Revision

  ViewVC Help
Powered by ViewVC 1.1.20