/[path-sandbox]/trunk/ChangeLog
Gentoo

Contents of /trunk/ChangeLog

Parent Directory Parent Directory | Revision Log Revision Log


Revision 65 - (hide annotations) (download)
Tue May 3 09:59:26 2005 UTC (8 years, 11 months ago) by azarah
File size: 17996 byte(s)
Add /dev/pty to default write list.  Noticed by Morfic.

1 ferringb 2 # ChangeLog for Path Sandbox
2 vapier 53 # Copyright 1999-2005 Gentoo Foundation; Distributed under the GPL v2
3 ferringb 2 # $Header$
4    
5 azarah 65 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
6     Add /dev/pty to default write list. Noticed by Morfic.
7    
8 vapier 62 02 May 2005; Mike Frysinger <vapier@gentoo.org> configure.in, localdecls.h,
9     sandbox.h:
10     uClibc doesn't support dlvsym() so add a configure check to make sure it doesn't
11     exist. Also update localdecls.h so BROKEN_RTLD_NEXT isn't defined in uClibc.
12    
13 azarah 59 * sandbox-1.2.3 (2005/04/29)
14    
15 azarah 56 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> configure.in:
16     Do not check for (*&#$(* CXX or F77.
17    
18 azarah 54 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
19     Do not append '/' to pathname in filter_path() if it already ends with it.
20    
21 vapier 53 28 Apr 2005; Mike Frysinger <vapier@gentoo.org> Makefile.am, configure.in:
22     With az's help, clean up autotools to work with cross-compiling.
23    
24 azarah 59 * sandbox-1.2.2 (2005/04/28)
25 azarah 48
26 azarah 47 28 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
27     Only check for /dev/{null,zero} for unlink hack, else ricers using /dev/shm
28     have issues; bug #90592.
29    
30 azarah 59 * sandbox-1.2.1 (2005/04/23)
31 azarah 44
32 azarah 43 23 Apr 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
33     getcwd.c, libsandbox.c, localdecls.h, sandbox.h, sandbox_futils.c:
34     Make sure all functions used in libsandbox.c is declared static. Define
35     SB_STATIC in localdecls.h for this. Include sandbox_futils.c rather than
36     linking with its object. Hopefully this will fix bug #90153.
37    
38 azarah 59 * sandbox-1.2 (2005/04/23)
39 azarah 46
40 azarah 40 22 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
41     Allow lchown a symlink in write-allowed path pointing to write-denied
42     target.
43    
44 genone 39 21 Mar 2005; Marius Mauch <genone@gentoo.org> libsandbox.c:
45     Also show resolved symlink names in the log.
46    
47 azarah 37 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, libsandbox.c:
48     Seems -nostdlib was the problem with the constructor/destructor - remove it
49     from Makefile.am, and change the constructor/destructor names again.
50    
51 azarah 36 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
52     Also rename the _init() and _fini() declarations.
53    
54 azarah 35 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
55     Fixup the constructor/destructor function names again (they should be _init()
56     and _fini() it seems, and not being called caused sandbox_lib_path to be
57     unset, and thus breaking the execve() wrapper's LD_PRELOAD protection).
58     Add both the path in given SANDBOX_x variable, as well as its symlink
59     resolved path in init_env_entries(). Modify filter_path() to be able to
60     resolve paths without resolving symlinks, as well as to be able to resolve
61     symlinks. Fix a possible segfault in check_access(). Add symlink resolving
62     to check_access() resolving bug #31019. Add 'hack' for unlink, as the fix
63     for bug #31019 cause access violations if we try to remove a symlink that is
64     not in protected path, but points to a protected path. Fix a memory leak in
65     sandbox.c (sandbox_pids_file in main()). Fix the realpath() calls in main()
66     (sandbox.c) being unchecked. Fix the debug logname not having the pid in it
67     (pid_string was uninitialized). General syntax cleanups.
68    
69 ferringb 34 09 Mar 2005; Brian Harring <ferringb@gentoo.org> sandbox.c: Fixed the
70     infamous "pids file is not a regular file" w/out newline bug.
71    
72 ferringb 33 09 Mar 2005; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in:
73     Correct libc_version path detection, since it was screwing up if libdir !=
74     "/lib/".
75    
76     02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
77 azarah 32 Hack to make sure sandboxed process cannot remove a device node, bug #79836.
78    
79 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am:
80 azarah 31 Fix symbols.in not added to dist.
81    
82 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
83 azarah 30 getcwd.c, libsandbox.c, sandbox.c, sandbox.h, sandbox_futils.c:
84     White space fixes.
85    
86 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
87 azarah 30 configure.in, getcwd.c, libsandbox.c, symbols.in:
88 azarah 29 Fix inverse test logic in canonicalize.c, use a strncpy. Fix gcc warning in
89     getcwd.c. Add symbols.in and logic to Makefile.am to generate symbol versions
90     for glibc and other libc's that use this. Update libsandbox.c to use these
91     symbol versions if available. Fix exec wrapper to re-export LD_PRELOAD if the
92     process unset it.
93    
94 ferringb 33 01 Mar 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
95 ferringb 28 killed off _init and _fini in favor of
96     void __attribute__ ((constructor)) init_func and
97     void __attribute__ ((destructor)) closing_func. _(init|func) were deprecated.
98    
99 ferringb 26 06 Dec 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, libsandbox.c,
100     canonicalize.c, getcwd.c: Fixed compilation *again*. Hopefully cvs is done
101     having the hick-ups.
102    
103 ferringb 24 04 Dec 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, getcwd.c,
104     Makefile.am: Fixed compilation.
105    
106 ferringb 18 01 Dec 2004; Brian Harring <ferringb@gentoo.org> aclocal.m4:
107     Gutted the bugger so it stops checking for a c++ and fortran compiler.
108     Do *not* regenerate aclocal.m4 for making a release until a better
109     solution is created.
110    
111 ferringb 16 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, sandbox_futils.c:
112     Removal of more hardcoded paths.
113    
114 ferringb 13 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in,
115     sandbox_futils.c: tweaks to install sandbox.bashrc, and use it.
116    
117     19 Nov 2004; Brian Harring <ferringb@gentoo.org>:
118 ferringb 6 Sandbox is now autotooled, create-localdecls needs to be killed and the code
119     shifted into configure.in. Currently builds *one* libsandbox.so- if multiple
120     are desired (-m64 and -m32 for amd64), the ebuild should do it (imo).
121     To get to a point of testing, automake && autoconf; created requisite files w/
122     a(utomake|clocal)-1.8, and autoconf 2.59. Installs to /usr/, instead of
123     /lib and /usr/lib/portage/bin.
124    
125 ferringb 2 14 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox.c:
126     closing out bug #70225, potential overflow of the sandbox_pids_file var.
127    
128     07 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c: c99 standard,
129     (think it was at least) allows intermixing of code and data segments. bug #70351
130     should be fixed by this.
131    
132     03 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox_futils.c:
133     futils fix from bug #65201 via solar, and libsandbox log path checks via #69137
134    
135     02 Aug 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Code from
136     Seth Robertson that tracked down all adjuct flags for read operations that
137     do not invoke a write operation.
138    
139     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
140     Another fix from jstubbs regarding a free() on a stack variable for the
141     environment -- tracking now prevents extraneous free()'s segfault.
142    
143     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
144     J. Stubbs tracked down a new bug where mkdir was failing to the patch on
145     the lstat in mkdir... it now only returns 0 or -1 as documented for mkdir.
146     Also remove the errno = ESUCCESS settings as documentation points out that
147     a library isn't allowed to do that.
148    
149     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Added a
150     file_security_check() function to check random potential exploits on files
151     that sandbox is to load and read -- Normally sandboxpids.tmp. This fixes
152     the 'system-crippling' exploits (bug 21923) and catches a few other
153     potential problems.
154    
155     20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> Makefile: Updates for
156     32/64 bit sandbox. Made CC and LD '?=' values to allow passed in CC to work.
157    
158     20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c:
159     bug 42048 -- Fixed the lstat/errno conditions for mkdir <caleb@g.o>.
160     Added the 64/32 bit sandbox patch for AMD64 bug 32963 <brad/azarah>.
161    
162     29 Feb 2004; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c :
163     Fix permissions and group of pids file and logs. Permissions should be 0664
164     and group should be 'portage'. Bug #34260.
165    
166     28 Feb 2004; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
167     Besides a small cleanup, redo how we replace LD_PRELOAD in the environ passed
168     to the real execve (in our execve wrapper). Seems that on some arches (sparc
169     among others) do not allow us to tamper with the readonly copy passed to
170     execve, so pass our own copy of the environment. Bug #42290.
171    
172     11 Jan 2004; Nicholas Jones <carpaski@gentoo.org> create-decls:
173     Changed tail to head and added a notice about duration of glibc check.
174    
175     21 Dec 2003; Nicholas Jones <carpaski@gentoo.org> create-decls:
176     Changed the glibc subversion check to use /usr/bin/* instead of /bin/sh
177     as there isn't a guarentee that it is dynamic.
178    
179     02 Nov 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
180     If 'file' passed to before_syscall(const char *func, const char *file) is
181     invalid, we should set errno to ENOENT, and not EINVAL. This should
182     close bug #32238.
183    
184     14 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
185     Fix a bug that occurs mainly on 64bit arch, where the file passed to
186     the functions we wrap, is invalid, and then cause canonicalize to pass
187     garbage to before_syscall(), thanks to great detective work from
188     Andrea Luzzardi <al@sig11.org> (bug #29846).
189    
190     13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
191     Add a uClibc detection patch from Peter S. Mazinger <ps.m@gmx.net>.
192    
193     13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
194     Fix a bug in libsandbox.c 's checking in the rename wrapper - it basically
195     only checked the destination patch, and not the source, so we could move
196     a protected file to a unprotected directory, and then delete/modify it.
197     Thanks to Andrea Luzzardi (scox) <al@sig11.org>, bug #30992, for this fix.
198    
199     12 Oct 2003; Nicholas Jones <carpaski@gentoo.org> sandbox.c :
200     Added python2.3 to the predict section/variable.
201    
202     28 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
203     sandbox.h, sandbox_futils.c :
204     Add support to set the pids file via SANDBOX_PIDS_FILE at startup. If
205     it is not set, it will revert to its old value.
206    
207     27 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
208     Fix our mkdir wrapper to check if the dir exist, and return EEXIST if so,
209     rather than failing with a violation, bug #29748.
210    
211     27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
212     Fix canonicalize() to ignore calls with path = "".
213    
214     27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c,
215     sandbox_futils.c, canonicalize.c :
216     Once again coreutils fails, as my systems had 2.5 kernel, the getcwd system
217     call handled strings larger than PATH_MAX (bug #21766). It however does not
218     work the same on 2.4 kernels.
219    
220     To fix, I added the posix implementation of getcwd() (from glibc cvs) that
221     do not need the system call. We use the default getcwd() function via a
222     wrapper (egetcwd), and then lstat the returned path. If lstat fails, it
223     means the current directory was removed, OR that the the system call for
224     getcwd failed (curious is that it do not fail and return NULL or set
225     errno, but rather just truncate the retured directory - usually from the
226     start), and if so, we use the generic getcwd() function (__egetcwd). Note
227     that we do not use the generic version all the time, as it calls lstat()
228     a great number of times, and performance degrade much.
229    
230     29 Jun 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls,
231     libsandbox.c :
232     Make sure SB_PATH_MAX will not wrap. Fix two possible memory leaks.
233    
234     22 Jun 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, canonicalize.c
235     create-localdecls :
236     When checking path names of files accessed, we need to canonicalize it, else
237     it may be a symlink in a 'write allowed' directory pointing to a file in a
238     directory we should not have write access to.
239    
240     With something like coreutils-5.0, we have two problems:
241     1) One of the tests checks if getcwd() can return a path longer than
242     PATH_MAX. This test then tries to create a dir which even while
243     created local (mkdir("conftest2")), it ends up being resolved with
244     a name that is much larger than PATH_MAX. The problem now is that
245     canonicalize() have undefined behaviour when the path was too long
246     (returned wrongly truncated paths, etc), and pass the wrong path to
247     before_syscall() (causing the bogus sandbox violations).
248     2) The ecanonicalize() function we used, along with the canonicalize()
249     function did not support longer than PATH_MAX. This is partly a
250     cause for 1), but the error checking (rather lack of it) of calls
251     to erealpath() in canonicalize() was the prime reason for 1).
252    
253     As we do not use this canonicalized name to call the function, we resolve this
254     by fixing canonicalize() to do better error checking, and ecanonicalize() as
255     well as all functions in libsandbox.c to use a PATH_MAX of 'PATH_MAX * 2'.
256     While they will resolve paths properly now, and can check if a write/read is
257     allowed, the functions called from the sandboxed environment will still work
258     as expected.
259    
260     This should resolve bug #21766.
261    
262     06 Apr 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
263     For some reason sandbox fails with a 'open_wr' if you run 'locale -a' under
264     it (bug #16298).
265    
266     Problem is that for some reason locale fopen's locale.alias with mode "rm".
267    
268     -------------------------------------------------------
269     nosferatu root # grep fopen locale.log
270     fopen("/usr/share/locale/locale.alias", "rm"ACCESS DENIED open_wr: /usr/share/locale/locale.alias
271     nosferatu root #
272     --------------------------------------------------------
273    
274     I checked the source of locale, but it have fopen with mode 'r', so
275     not sure where the "rm" mode comes from. Anyhow, changed the check in
276     before_syscall_open_char() to also see mode "rm" as readonly.
277    
278     23 Feb 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
279    
280     Add glibc-2.3 support.
281    
282     22 Feb 2003; Martin Schlemmer <azarah@gentoo.org> sandbox.c :
283    
284     Some /etc/ld.so.preload fixes. Just changed the #if defines to cover all
285     operations releated to preload, as well as only try to modify ld.so.preload
286     if we can. Also modify to write the pid to /tmp/sandboxpids.tmp even when
287     not using ld.so.preload. Fix to not write this instance of sandbox's pid
288     to /tmp/sandboxpids.tmp on exit if this is not the last sandbox running.
289    
290     22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> Makefile :
291    
292     Changed the LD to CC for hppa.
293    
294     22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
295    
296     Killed the previous changes I made.
297    
298     17 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
299    
300     Added parisc to BROKEN_RTLD_ARCHLIST to see if it we can fix the relocation probs.
301    
302     09 Jan 2003; J Robert Ray <jrray@gentoo.org> sandbox.c :
303    
304     Don't segfault if $HOME isn't set, set $HOME to "/" instead. Fixes bug 10868.
305    
306     16 Dec 2002; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
307    
308     Fix memory leak for mips, bug #12236. Thanks to Torgeir Hansen <torgeir@trenger.ro>
309     for this fix.
310    
311     4 Dec 2002; J Robert Ray <jrray@gentoo.org> sandbox.h sandbox_futils.c :
312    
313     sandbox_futils defined a dirname() function that was masking the same
314     function in glibc and was broken (e.g.: SANDBOX_DIR was being set to
315     '/usr/lib/portage/bi/'). Fixed function to return expected results and
316     renamed it to sb_dirname() to no longer mask the glibc function. Closes bug
317     11231.
318    
319     4 Dec 2002; Martin Schlemmer <azarah@gentoo.org> :
320    
321     Fix a segfault in libsandbox.c if canonicalize() was called with
322     first parameter = NULL.
323    
324     1 Sep 2002; Martin Schlemmer <azarah@gentoo.org> :
325    
326     Fix my braindead 'return 1;' in a void function. Updated sandbox.c,
327     cleanup() for this.
328    
329     Change cleanup() in sandbox.c not to exit with fail status if
330     the pidsfile is missing. We really should still display sandbox
331     violations if they occured.
332    
333     31 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
334    
335     Update cleanup() in sandbox.c to remove the PIDSFILE if this is
336     the last sandbox running.
337    
338     25 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
339    
340     Major cleanups to mainly libsandbox.c again.
341    
342     22 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
343    
344     Add copyrights to sandbox.h and sandbox_futils.h. If wrong, the
345     parties involved should please contact me so that we can fix it.
346    
347     Add opendir wrapper to libsandbox.c.
348    
349     21 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
350    
351     Do some more cleanups to ecanonicalize(), as it dropped filenames in
352     rare cases (after my symlink cleanups), and caused glibc to bork.
353     These fixes went into canonicalize.c.
354    
355     20 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
356    
357     Fix spawn_shell() and main() in sandbox.c to properly return fail
358     status.
359    
360     19 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
361    
362     The new canonicalize() function in libsandbox.c also resolved symlinks,
363     which caused on cleaning sandbox errors if the symlink pointed to a
364     file in the live root. Ripped out canonicalize() and realpath() from
365     glibc; removed the symlink stuff, and changed them to ecanonicalize()
366     and erealpath().
367    
368     18 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
369    
370     Ripped out all the wrappers, and implemented those of InstallWatch.
371     Losts of cleanups and bugfixes. Implement a execve that forces
372     $LIBSANDBOX in $LD_PRELOAD. We can now thus do away with the feared
373     /etc/ld.so.preload (*g*) ... Made the needed changes to sandbox.c,
374     sandbox.h and sandbox_futils.c. Rewrote the Makefile for most
375     parts; it now have an install target.
376    
377     Reformat the whole thing to look somewhat like the reworked sandbox.c
378     and new sandbox.h and sandbox_futils.c from:
379    
380     Brad House <brad@mainstreetsoftworks.com>.
381    
382     Additional Copyrights now due to the InstallWatch code:
383    
384     Copyright (C) 1998-9 Pancrazio `Ezio' de Mauro <p@demauro.net>

Properties

Name Value
svn:eol-style native
svn:keywords Author Date Id Revision

  ViewVC Help
Powered by ViewVC 1.1.20