/[path-sandbox]/trunk/ChangeLog
Gentoo

Contents of /trunk/ChangeLog

Parent Directory Parent Directory | Revision Log Revision Log


Revision 66 - (hide annotations) (download)
Tue May 3 10:56:19 2005 UTC (9 years, 4 months ago) by azarah
File size: 18185 byte(s)
Do not init the env entries with each call, as it creates too many calls to
lstat, etc.  Should speedup things a bit.

1 ferringb 2 # ChangeLog for Path Sandbox
2 vapier 53 # Copyright 1999-2005 Gentoo Foundation; Distributed under the GPL v2
3 ferringb 2 # $Header$
4    
5 azarah 66 03 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
6     Do not init the env entries with each call, as it creates too many calls to
7     lstat, etc. Should speedup things a bit.
8    
9 azarah 65 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
10     Add /dev/pty to default write list. Noticed by Morfic.
11    
12 vapier 62 02 May 2005; Mike Frysinger <vapier@gentoo.org> configure.in, localdecls.h,
13     sandbox.h:
14     uClibc doesn't support dlvsym() so add a configure check to make sure it doesn't
15     exist. Also update localdecls.h so BROKEN_RTLD_NEXT isn't defined in uClibc.
16    
17 azarah 59 * sandbox-1.2.3 (2005/04/29)
18    
19 azarah 56 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> configure.in:
20     Do not check for (*&#$(* CXX or F77.
21    
22 azarah 54 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
23     Do not append '/' to pathname in filter_path() if it already ends with it.
24    
25 vapier 53 28 Apr 2005; Mike Frysinger <vapier@gentoo.org> Makefile.am, configure.in:
26     With az's help, clean up autotools to work with cross-compiling.
27    
28 azarah 59 * sandbox-1.2.2 (2005/04/28)
29 azarah 48
30 azarah 47 28 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
31     Only check for /dev/{null,zero} for unlink hack, else ricers using /dev/shm
32     have issues; bug #90592.
33    
34 azarah 59 * sandbox-1.2.1 (2005/04/23)
35 azarah 44
36 azarah 43 23 Apr 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
37     getcwd.c, libsandbox.c, localdecls.h, sandbox.h, sandbox_futils.c:
38     Make sure all functions used in libsandbox.c is declared static. Define
39     SB_STATIC in localdecls.h for this. Include sandbox_futils.c rather than
40     linking with its object. Hopefully this will fix bug #90153.
41    
42 azarah 59 * sandbox-1.2 (2005/04/23)
43 azarah 46
44 azarah 40 22 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
45     Allow lchown a symlink in write-allowed path pointing to write-denied
46     target.
47    
48 genone 39 21 Mar 2005; Marius Mauch <genone@gentoo.org> libsandbox.c:
49     Also show resolved symlink names in the log.
50    
51 azarah 37 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, libsandbox.c:
52     Seems -nostdlib was the problem with the constructor/destructor - remove it
53     from Makefile.am, and change the constructor/destructor names again.
54    
55 azarah 36 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
56     Also rename the _init() and _fini() declarations.
57    
58 azarah 35 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
59     Fixup the constructor/destructor function names again (they should be _init()
60     and _fini() it seems, and not being called caused sandbox_lib_path to be
61     unset, and thus breaking the execve() wrapper's LD_PRELOAD protection).
62     Add both the path in given SANDBOX_x variable, as well as its symlink
63     resolved path in init_env_entries(). Modify filter_path() to be able to
64     resolve paths without resolving symlinks, as well as to be able to resolve
65     symlinks. Fix a possible segfault in check_access(). Add symlink resolving
66     to check_access() resolving bug #31019. Add 'hack' for unlink, as the fix
67     for bug #31019 cause access violations if we try to remove a symlink that is
68     not in protected path, but points to a protected path. Fix a memory leak in
69     sandbox.c (sandbox_pids_file in main()). Fix the realpath() calls in main()
70     (sandbox.c) being unchecked. Fix the debug logname not having the pid in it
71     (pid_string was uninitialized). General syntax cleanups.
72    
73 ferringb 34 09 Mar 2005; Brian Harring <ferringb@gentoo.org> sandbox.c: Fixed the
74     infamous "pids file is not a regular file" w/out newline bug.
75    
76 ferringb 33 09 Mar 2005; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in:
77     Correct libc_version path detection, since it was screwing up if libdir !=
78     "/lib/".
79    
80     02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
81 azarah 32 Hack to make sure sandboxed process cannot remove a device node, bug #79836.
82    
83 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am:
84 azarah 31 Fix symbols.in not added to dist.
85    
86 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
87 azarah 30 getcwd.c, libsandbox.c, sandbox.c, sandbox.h, sandbox_futils.c:
88     White space fixes.
89    
90 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
91 azarah 30 configure.in, getcwd.c, libsandbox.c, symbols.in:
92 azarah 29 Fix inverse test logic in canonicalize.c, use a strncpy. Fix gcc warning in
93     getcwd.c. Add symbols.in and logic to Makefile.am to generate symbol versions
94     for glibc and other libc's that use this. Update libsandbox.c to use these
95     symbol versions if available. Fix exec wrapper to re-export LD_PRELOAD if the
96     process unset it.
97    
98 ferringb 33 01 Mar 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
99 ferringb 28 killed off _init and _fini in favor of
100     void __attribute__ ((constructor)) init_func and
101     void __attribute__ ((destructor)) closing_func. _(init|func) were deprecated.
102    
103 ferringb 26 06 Dec 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, libsandbox.c,
104     canonicalize.c, getcwd.c: Fixed compilation *again*. Hopefully cvs is done
105     having the hick-ups.
106    
107 ferringb 24 04 Dec 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, getcwd.c,
108     Makefile.am: Fixed compilation.
109    
110 ferringb 18 01 Dec 2004; Brian Harring <ferringb@gentoo.org> aclocal.m4:
111     Gutted the bugger so it stops checking for a c++ and fortran compiler.
112     Do *not* regenerate aclocal.m4 for making a release until a better
113     solution is created.
114    
115 ferringb 16 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, sandbox_futils.c:
116     Removal of more hardcoded paths.
117    
118 ferringb 13 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in,
119     sandbox_futils.c: tweaks to install sandbox.bashrc, and use it.
120    
121     19 Nov 2004; Brian Harring <ferringb@gentoo.org>:
122 ferringb 6 Sandbox is now autotooled, create-localdecls needs to be killed and the code
123     shifted into configure.in. Currently builds *one* libsandbox.so- if multiple
124     are desired (-m64 and -m32 for amd64), the ebuild should do it (imo).
125     To get to a point of testing, automake && autoconf; created requisite files w/
126     a(utomake|clocal)-1.8, and autoconf 2.59. Installs to /usr/, instead of
127     /lib and /usr/lib/portage/bin.
128    
129 ferringb 2 14 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox.c:
130     closing out bug #70225, potential overflow of the sandbox_pids_file var.
131    
132     07 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c: c99 standard,
133     (think it was at least) allows intermixing of code and data segments. bug #70351
134     should be fixed by this.
135    
136     03 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox_futils.c:
137     futils fix from bug #65201 via solar, and libsandbox log path checks via #69137
138    
139     02 Aug 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Code from
140     Seth Robertson that tracked down all adjuct flags for read operations that
141     do not invoke a write operation.
142    
143     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
144     Another fix from jstubbs regarding a free() on a stack variable for the
145     environment -- tracking now prevents extraneous free()'s segfault.
146    
147     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
148     J. Stubbs tracked down a new bug where mkdir was failing to the patch on
149     the lstat in mkdir... it now only returns 0 or -1 as documented for mkdir.
150     Also remove the errno = ESUCCESS settings as documentation points out that
151     a library isn't allowed to do that.
152    
153     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Added a
154     file_security_check() function to check random potential exploits on files
155     that sandbox is to load and read -- Normally sandboxpids.tmp. This fixes
156     the 'system-crippling' exploits (bug 21923) and catches a few other
157     potential problems.
158    
159     20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> Makefile: Updates for
160     32/64 bit sandbox. Made CC and LD '?=' values to allow passed in CC to work.
161    
162     20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c:
163     bug 42048 -- Fixed the lstat/errno conditions for mkdir <caleb@g.o>.
164     Added the 64/32 bit sandbox patch for AMD64 bug 32963 <brad/azarah>.
165    
166     29 Feb 2004; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c :
167     Fix permissions and group of pids file and logs. Permissions should be 0664
168     and group should be 'portage'. Bug #34260.
169    
170     28 Feb 2004; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
171     Besides a small cleanup, redo how we replace LD_PRELOAD in the environ passed
172     to the real execve (in our execve wrapper). Seems that on some arches (sparc
173     among others) do not allow us to tamper with the readonly copy passed to
174     execve, so pass our own copy of the environment. Bug #42290.
175    
176     11 Jan 2004; Nicholas Jones <carpaski@gentoo.org> create-decls:
177     Changed tail to head and added a notice about duration of glibc check.
178    
179     21 Dec 2003; Nicholas Jones <carpaski@gentoo.org> create-decls:
180     Changed the glibc subversion check to use /usr/bin/* instead of /bin/sh
181     as there isn't a guarentee that it is dynamic.
182    
183     02 Nov 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
184     If 'file' passed to before_syscall(const char *func, const char *file) is
185     invalid, we should set errno to ENOENT, and not EINVAL. This should
186     close bug #32238.
187    
188     14 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
189     Fix a bug that occurs mainly on 64bit arch, where the file passed to
190     the functions we wrap, is invalid, and then cause canonicalize to pass
191     garbage to before_syscall(), thanks to great detective work from
192     Andrea Luzzardi <al@sig11.org> (bug #29846).
193    
194     13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
195     Add a uClibc detection patch from Peter S. Mazinger <ps.m@gmx.net>.
196    
197     13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
198     Fix a bug in libsandbox.c 's checking in the rename wrapper - it basically
199     only checked the destination patch, and not the source, so we could move
200     a protected file to a unprotected directory, and then delete/modify it.
201     Thanks to Andrea Luzzardi (scox) <al@sig11.org>, bug #30992, for this fix.
202    
203     12 Oct 2003; Nicholas Jones <carpaski@gentoo.org> sandbox.c :
204     Added python2.3 to the predict section/variable.
205    
206     28 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
207     sandbox.h, sandbox_futils.c :
208     Add support to set the pids file via SANDBOX_PIDS_FILE at startup. If
209     it is not set, it will revert to its old value.
210    
211     27 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
212     Fix our mkdir wrapper to check if the dir exist, and return EEXIST if so,
213     rather than failing with a violation, bug #29748.
214    
215     27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
216     Fix canonicalize() to ignore calls with path = "".
217    
218     27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c,
219     sandbox_futils.c, canonicalize.c :
220     Once again coreutils fails, as my systems had 2.5 kernel, the getcwd system
221     call handled strings larger than PATH_MAX (bug #21766). It however does not
222     work the same on 2.4 kernels.
223    
224     To fix, I added the posix implementation of getcwd() (from glibc cvs) that
225     do not need the system call. We use the default getcwd() function via a
226     wrapper (egetcwd), and then lstat the returned path. If lstat fails, it
227     means the current directory was removed, OR that the the system call for
228     getcwd failed (curious is that it do not fail and return NULL or set
229     errno, but rather just truncate the retured directory - usually from the
230     start), and if so, we use the generic getcwd() function (__egetcwd). Note
231     that we do not use the generic version all the time, as it calls lstat()
232     a great number of times, and performance degrade much.
233    
234     29 Jun 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls,
235     libsandbox.c :
236     Make sure SB_PATH_MAX will not wrap. Fix two possible memory leaks.
237    
238     22 Jun 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, canonicalize.c
239     create-localdecls :
240     When checking path names of files accessed, we need to canonicalize it, else
241     it may be a symlink in a 'write allowed' directory pointing to a file in a
242     directory we should not have write access to.
243    
244     With something like coreutils-5.0, we have two problems:
245     1) One of the tests checks if getcwd() can return a path longer than
246     PATH_MAX. This test then tries to create a dir which even while
247     created local (mkdir("conftest2")), it ends up being resolved with
248     a name that is much larger than PATH_MAX. The problem now is that
249     canonicalize() have undefined behaviour when the path was too long
250     (returned wrongly truncated paths, etc), and pass the wrong path to
251     before_syscall() (causing the bogus sandbox violations).
252     2) The ecanonicalize() function we used, along with the canonicalize()
253     function did not support longer than PATH_MAX. This is partly a
254     cause for 1), but the error checking (rather lack of it) of calls
255     to erealpath() in canonicalize() was the prime reason for 1).
256    
257     As we do not use this canonicalized name to call the function, we resolve this
258     by fixing canonicalize() to do better error checking, and ecanonicalize() as
259     well as all functions in libsandbox.c to use a PATH_MAX of 'PATH_MAX * 2'.
260     While they will resolve paths properly now, and can check if a write/read is
261     allowed, the functions called from the sandboxed environment will still work
262     as expected.
263    
264     This should resolve bug #21766.
265    
266     06 Apr 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
267     For some reason sandbox fails with a 'open_wr' if you run 'locale -a' under
268     it (bug #16298).
269    
270     Problem is that for some reason locale fopen's locale.alias with mode "rm".
271    
272     -------------------------------------------------------
273     nosferatu root # grep fopen locale.log
274     fopen("/usr/share/locale/locale.alias", "rm"ACCESS DENIED open_wr: /usr/share/locale/locale.alias
275     nosferatu root #
276     --------------------------------------------------------
277    
278     I checked the source of locale, but it have fopen with mode 'r', so
279     not sure where the "rm" mode comes from. Anyhow, changed the check in
280     before_syscall_open_char() to also see mode "rm" as readonly.
281    
282     23 Feb 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
283    
284     Add glibc-2.3 support.
285    
286     22 Feb 2003; Martin Schlemmer <azarah@gentoo.org> sandbox.c :
287    
288     Some /etc/ld.so.preload fixes. Just changed the #if defines to cover all
289     operations releated to preload, as well as only try to modify ld.so.preload
290     if we can. Also modify to write the pid to /tmp/sandboxpids.tmp even when
291     not using ld.so.preload. Fix to not write this instance of sandbox's pid
292     to /tmp/sandboxpids.tmp on exit if this is not the last sandbox running.
293    
294     22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> Makefile :
295    
296     Changed the LD to CC for hppa.
297    
298     22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
299    
300     Killed the previous changes I made.
301    
302     17 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
303    
304     Added parisc to BROKEN_RTLD_ARCHLIST to see if it we can fix the relocation probs.
305    
306     09 Jan 2003; J Robert Ray <jrray@gentoo.org> sandbox.c :
307    
308     Don't segfault if $HOME isn't set, set $HOME to "/" instead. Fixes bug 10868.
309    
310     16 Dec 2002; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
311    
312     Fix memory leak for mips, bug #12236. Thanks to Torgeir Hansen <torgeir@trenger.ro>
313     for this fix.
314    
315     4 Dec 2002; J Robert Ray <jrray@gentoo.org> sandbox.h sandbox_futils.c :
316    
317     sandbox_futils defined a dirname() function that was masking the same
318     function in glibc and was broken (e.g.: SANDBOX_DIR was being set to
319     '/usr/lib/portage/bi/'). Fixed function to return expected results and
320     renamed it to sb_dirname() to no longer mask the glibc function. Closes bug
321     11231.
322    
323     4 Dec 2002; Martin Schlemmer <azarah@gentoo.org> :
324    
325     Fix a segfault in libsandbox.c if canonicalize() was called with
326     first parameter = NULL.
327    
328     1 Sep 2002; Martin Schlemmer <azarah@gentoo.org> :
329    
330     Fix my braindead 'return 1;' in a void function. Updated sandbox.c,
331     cleanup() for this.
332    
333     Change cleanup() in sandbox.c not to exit with fail status if
334     the pidsfile is missing. We really should still display sandbox
335     violations if they occured.
336    
337     31 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
338    
339     Update cleanup() in sandbox.c to remove the PIDSFILE if this is
340     the last sandbox running.
341    
342     25 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
343    
344     Major cleanups to mainly libsandbox.c again.
345    
346     22 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
347    
348     Add copyrights to sandbox.h and sandbox_futils.h. If wrong, the
349     parties involved should please contact me so that we can fix it.
350    
351     Add opendir wrapper to libsandbox.c.
352    
353     21 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
354    
355     Do some more cleanups to ecanonicalize(), as it dropped filenames in
356     rare cases (after my symlink cleanups), and caused glibc to bork.
357     These fixes went into canonicalize.c.
358    
359     20 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
360    
361     Fix spawn_shell() and main() in sandbox.c to properly return fail
362     status.
363    
364     19 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
365    
366     The new canonicalize() function in libsandbox.c also resolved symlinks,
367     which caused on cleaning sandbox errors if the symlink pointed to a
368     file in the live root. Ripped out canonicalize() and realpath() from
369     glibc; removed the symlink stuff, and changed them to ecanonicalize()
370     and erealpath().
371    
372     18 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
373    
374     Ripped out all the wrappers, and implemented those of InstallWatch.
375     Losts of cleanups and bugfixes. Implement a execve that forces
376     $LIBSANDBOX in $LD_PRELOAD. We can now thus do away with the feared
377     /etc/ld.so.preload (*g*) ... Made the needed changes to sandbox.c,
378     sandbox.h and sandbox_futils.c. Rewrote the Makefile for most
379     parts; it now have an install target.
380    
381     Reformat the whole thing to look somewhat like the reworked sandbox.c
382     and new sandbox.h and sandbox_futils.c from:
383    
384     Brad House <brad@mainstreetsoftworks.com>.
385    
386     Additional Copyrights now due to the InstallWatch code:
387    
388     Copyright (C) 1998-9 Pancrazio `Ezio' de Mauro <p@demauro.net>

Properties

Name Value
svn:eol-style native
svn:keywords Author Date Id Revision

  ViewVC Help
Powered by ViewVC 1.1.20