/[path-sandbox]/trunk/ChangeLog
Gentoo

Contents of /trunk/ChangeLog

Parent Directory Parent Directory | Revision Log Revision Log


Revision 76 - (hide annotations) (download)
Sun May 8 11:27:37 2005 UTC (9 years, 7 months ago) by ferringb
File size: 19232 byte(s)
rewrote sbcontext caching so it accounts for env changes since lib initialization.

1 ferringb 2 # ChangeLog for Path Sandbox
2 vapier 53 # Copyright 1999-2005 Gentoo Foundation; Distributed under the GPL v2
3 ferringb 2 # $Header$
4    
5 ferringb 76 08 May 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
6     rewrote the sbcontext caching code so it accounts for env changes since lib
7     initialization.
8    
9 azarah 75 05 May 2005; Martin Schlemmer <azarah@gentoo.org> configure.in, libctest.c:
10     We create libctest.c via configure, so no need to keep it around. Do some
11     cleanup related to libctest.c and libctest during configure.
12    
13 azarah 74 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
14     Add rename support of symlinks pointing to protected files/directories.
15    
16 azarah 72 * sandbox-1.2.5 (2005/05/04)
17    
18 azarah 71 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
19     sandbox.bashrc:
20     Do not reset already set LD_PRELOAD when starting sandbox. If LD_PRELOAD is
21     already set, init of the env vars fails for some reason, so do this later on,
22     and do not warn (bug #91431).
23    
24 azarah 70 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
25     sandbox.bashrc:
26     Fixup sandbox and sandbox.bashrc to call bash with the proper .bashrc.
27    
28 azarah 68 * sandbox-1.2.4 (2005/05/03)
29    
30 azarah 66 03 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
31     Do not init the env entries with each call, as it creates too many calls to
32 azarah 67 lstat, etc. Should speedup things a bit, bug #91040.
33 azarah 66
34 azarah 65 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
35     Add /dev/pty to default write list. Noticed by Morfic.
36    
37 vapier 62 02 May 2005; Mike Frysinger <vapier@gentoo.org> configure.in, localdecls.h,
38     sandbox.h:
39     uClibc doesn't support dlvsym() so add a configure check to make sure it doesn't
40     exist. Also update localdecls.h so BROKEN_RTLD_NEXT isn't defined in uClibc.
41    
42 azarah 59 * sandbox-1.2.3 (2005/04/29)
43    
44 azarah 56 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> configure.in:
45     Do not check for (*&#$(* CXX or F77.
46    
47 azarah 54 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
48     Do not append '/' to pathname in filter_path() if it already ends with it.
49    
50 vapier 53 28 Apr 2005; Mike Frysinger <vapier@gentoo.org> Makefile.am, configure.in:
51     With az's help, clean up autotools to work with cross-compiling.
52    
53 azarah 59 * sandbox-1.2.2 (2005/04/28)
54 azarah 48
55 azarah 47 28 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
56     Only check for /dev/{null,zero} for unlink hack, else ricers using /dev/shm
57     have issues; bug #90592.
58    
59 azarah 59 * sandbox-1.2.1 (2005/04/23)
60 azarah 44
61 azarah 43 23 Apr 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
62     getcwd.c, libsandbox.c, localdecls.h, sandbox.h, sandbox_futils.c:
63     Make sure all functions used in libsandbox.c is declared static. Define
64     SB_STATIC in localdecls.h for this. Include sandbox_futils.c rather than
65     linking with its object. Hopefully this will fix bug #90153.
66    
67 azarah 59 * sandbox-1.2 (2005/04/23)
68 azarah 46
69 azarah 40 22 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
70     Allow lchown a symlink in write-allowed path pointing to write-denied
71     target.
72    
73 genone 39 21 Mar 2005; Marius Mauch <genone@gentoo.org> libsandbox.c:
74     Also show resolved symlink names in the log.
75    
76 azarah 37 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, libsandbox.c:
77     Seems -nostdlib was the problem with the constructor/destructor - remove it
78     from Makefile.am, and change the constructor/destructor names again.
79    
80 azarah 36 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
81     Also rename the _init() and _fini() declarations.
82    
83 azarah 35 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
84     Fixup the constructor/destructor function names again (they should be _init()
85     and _fini() it seems, and not being called caused sandbox_lib_path to be
86     unset, and thus breaking the execve() wrapper's LD_PRELOAD protection).
87     Add both the path in given SANDBOX_x variable, as well as its symlink
88     resolved path in init_env_entries(). Modify filter_path() to be able to
89     resolve paths without resolving symlinks, as well as to be able to resolve
90     symlinks. Fix a possible segfault in check_access(). Add symlink resolving
91     to check_access() resolving bug #31019. Add 'hack' for unlink, as the fix
92     for bug #31019 cause access violations if we try to remove a symlink that is
93     not in protected path, but points to a protected path. Fix a memory leak in
94     sandbox.c (sandbox_pids_file in main()). Fix the realpath() calls in main()
95     (sandbox.c) being unchecked. Fix the debug logname not having the pid in it
96     (pid_string was uninitialized). General syntax cleanups.
97    
98 ferringb 34 09 Mar 2005; Brian Harring <ferringb@gentoo.org> sandbox.c: Fixed the
99     infamous "pids file is not a regular file" w/out newline bug.
100    
101 ferringb 33 09 Mar 2005; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in:
102     Correct libc_version path detection, since it was screwing up if libdir !=
103     "/lib/".
104    
105     02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
106 azarah 32 Hack to make sure sandboxed process cannot remove a device node, bug #79836.
107    
108 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am:
109 azarah 31 Fix symbols.in not added to dist.
110    
111 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
112 azarah 30 getcwd.c, libsandbox.c, sandbox.c, sandbox.h, sandbox_futils.c:
113     White space fixes.
114    
115 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
116 azarah 30 configure.in, getcwd.c, libsandbox.c, symbols.in:
117 azarah 29 Fix inverse test logic in canonicalize.c, use a strncpy. Fix gcc warning in
118     getcwd.c. Add symbols.in and logic to Makefile.am to generate symbol versions
119     for glibc and other libc's that use this. Update libsandbox.c to use these
120     symbol versions if available. Fix exec wrapper to re-export LD_PRELOAD if the
121     process unset it.
122    
123 ferringb 33 01 Mar 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
124 ferringb 28 killed off _init and _fini in favor of
125     void __attribute__ ((constructor)) init_func and
126     void __attribute__ ((destructor)) closing_func. _(init|func) were deprecated.
127    
128 ferringb 26 06 Dec 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, libsandbox.c,
129     canonicalize.c, getcwd.c: Fixed compilation *again*. Hopefully cvs is done
130     having the hick-ups.
131    
132 ferringb 24 04 Dec 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, getcwd.c,
133     Makefile.am: Fixed compilation.
134    
135 ferringb 18 01 Dec 2004; Brian Harring <ferringb@gentoo.org> aclocal.m4:
136     Gutted the bugger so it stops checking for a c++ and fortran compiler.
137     Do *not* regenerate aclocal.m4 for making a release until a better
138     solution is created.
139    
140 ferringb 16 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, sandbox_futils.c:
141     Removal of more hardcoded paths.
142    
143 ferringb 13 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in,
144     sandbox_futils.c: tweaks to install sandbox.bashrc, and use it.
145    
146     19 Nov 2004; Brian Harring <ferringb@gentoo.org>:
147 ferringb 6 Sandbox is now autotooled, create-localdecls needs to be killed and the code
148     shifted into configure.in. Currently builds *one* libsandbox.so- if multiple
149     are desired (-m64 and -m32 for amd64), the ebuild should do it (imo).
150     To get to a point of testing, automake && autoconf; created requisite files w/
151     a(utomake|clocal)-1.8, and autoconf 2.59. Installs to /usr/, instead of
152     /lib and /usr/lib/portage/bin.
153    
154 ferringb 2 14 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox.c:
155     closing out bug #70225, potential overflow of the sandbox_pids_file var.
156    
157     07 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c: c99 standard,
158     (think it was at least) allows intermixing of code and data segments. bug #70351
159     should be fixed by this.
160    
161     03 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox_futils.c:
162     futils fix from bug #65201 via solar, and libsandbox log path checks via #69137
163    
164     02 Aug 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Code from
165     Seth Robertson that tracked down all adjuct flags for read operations that
166     do not invoke a write operation.
167    
168     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
169     Another fix from jstubbs regarding a free() on a stack variable for the
170     environment -- tracking now prevents extraneous free()'s segfault.
171    
172     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
173     J. Stubbs tracked down a new bug where mkdir was failing to the patch on
174     the lstat in mkdir... it now only returns 0 or -1 as documented for mkdir.
175     Also remove the errno = ESUCCESS settings as documentation points out that
176     a library isn't allowed to do that.
177    
178     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Added a
179     file_security_check() function to check random potential exploits on files
180     that sandbox is to load and read -- Normally sandboxpids.tmp. This fixes
181     the 'system-crippling' exploits (bug 21923) and catches a few other
182     potential problems.
183    
184     20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> Makefile: Updates for
185     32/64 bit sandbox. Made CC and LD '?=' values to allow passed in CC to work.
186    
187     20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c:
188     bug 42048 -- Fixed the lstat/errno conditions for mkdir <caleb@g.o>.
189     Added the 64/32 bit sandbox patch for AMD64 bug 32963 <brad/azarah>.
190    
191     29 Feb 2004; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c :
192     Fix permissions and group of pids file and logs. Permissions should be 0664
193     and group should be 'portage'. Bug #34260.
194    
195     28 Feb 2004; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
196     Besides a small cleanup, redo how we replace LD_PRELOAD in the environ passed
197     to the real execve (in our execve wrapper). Seems that on some arches (sparc
198     among others) do not allow us to tamper with the readonly copy passed to
199     execve, so pass our own copy of the environment. Bug #42290.
200    
201     11 Jan 2004; Nicholas Jones <carpaski@gentoo.org> create-decls:
202     Changed tail to head and added a notice about duration of glibc check.
203    
204     21 Dec 2003; Nicholas Jones <carpaski@gentoo.org> create-decls:
205     Changed the glibc subversion check to use /usr/bin/* instead of /bin/sh
206     as there isn't a guarentee that it is dynamic.
207    
208     02 Nov 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
209     If 'file' passed to before_syscall(const char *func, const char *file) is
210     invalid, we should set errno to ENOENT, and not EINVAL. This should
211     close bug #32238.
212    
213     14 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
214     Fix a bug that occurs mainly on 64bit arch, where the file passed to
215     the functions we wrap, is invalid, and then cause canonicalize to pass
216     garbage to before_syscall(), thanks to great detective work from
217     Andrea Luzzardi <al@sig11.org> (bug #29846).
218    
219     13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
220     Add a uClibc detection patch from Peter S. Mazinger <ps.m@gmx.net>.
221    
222     13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
223     Fix a bug in libsandbox.c 's checking in the rename wrapper - it basically
224     only checked the destination patch, and not the source, so we could move
225     a protected file to a unprotected directory, and then delete/modify it.
226     Thanks to Andrea Luzzardi (scox) <al@sig11.org>, bug #30992, for this fix.
227    
228     12 Oct 2003; Nicholas Jones <carpaski@gentoo.org> sandbox.c :
229     Added python2.3 to the predict section/variable.
230    
231     28 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
232     sandbox.h, sandbox_futils.c :
233     Add support to set the pids file via SANDBOX_PIDS_FILE at startup. If
234     it is not set, it will revert to its old value.
235    
236     27 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
237     Fix our mkdir wrapper to check if the dir exist, and return EEXIST if so,
238     rather than failing with a violation, bug #29748.
239    
240     27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
241     Fix canonicalize() to ignore calls with path = "".
242    
243     27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c,
244     sandbox_futils.c, canonicalize.c :
245     Once again coreutils fails, as my systems had 2.5 kernel, the getcwd system
246     call handled strings larger than PATH_MAX (bug #21766). It however does not
247     work the same on 2.4 kernels.
248    
249     To fix, I added the posix implementation of getcwd() (from glibc cvs) that
250     do not need the system call. We use the default getcwd() function via a
251     wrapper (egetcwd), and then lstat the returned path. If lstat fails, it
252     means the current directory was removed, OR that the the system call for
253     getcwd failed (curious is that it do not fail and return NULL or set
254     errno, but rather just truncate the retured directory - usually from the
255     start), and if so, we use the generic getcwd() function (__egetcwd). Note
256     that we do not use the generic version all the time, as it calls lstat()
257     a great number of times, and performance degrade much.
258    
259     29 Jun 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls,
260     libsandbox.c :
261     Make sure SB_PATH_MAX will not wrap. Fix two possible memory leaks.
262    
263     22 Jun 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, canonicalize.c
264     create-localdecls :
265     When checking path names of files accessed, we need to canonicalize it, else
266     it may be a symlink in a 'write allowed' directory pointing to a file in a
267     directory we should not have write access to.
268    
269     With something like coreutils-5.0, we have two problems:
270     1) One of the tests checks if getcwd() can return a path longer than
271     PATH_MAX. This test then tries to create a dir which even while
272     created local (mkdir("conftest2")), it ends up being resolved with
273     a name that is much larger than PATH_MAX. The problem now is that
274     canonicalize() have undefined behaviour when the path was too long
275     (returned wrongly truncated paths, etc), and pass the wrong path to
276     before_syscall() (causing the bogus sandbox violations).
277     2) The ecanonicalize() function we used, along with the canonicalize()
278     function did not support longer than PATH_MAX. This is partly a
279     cause for 1), but the error checking (rather lack of it) of calls
280     to erealpath() in canonicalize() was the prime reason for 1).
281    
282     As we do not use this canonicalized name to call the function, we resolve this
283     by fixing canonicalize() to do better error checking, and ecanonicalize() as
284     well as all functions in libsandbox.c to use a PATH_MAX of 'PATH_MAX * 2'.
285     While they will resolve paths properly now, and can check if a write/read is
286     allowed, the functions called from the sandboxed environment will still work
287     as expected.
288    
289     This should resolve bug #21766.
290    
291     06 Apr 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
292     For some reason sandbox fails with a 'open_wr' if you run 'locale -a' under
293     it (bug #16298).
294    
295     Problem is that for some reason locale fopen's locale.alias with mode "rm".
296    
297     -------------------------------------------------------
298     nosferatu root # grep fopen locale.log
299     fopen("/usr/share/locale/locale.alias", "rm"ACCESS DENIED open_wr: /usr/share/locale/locale.alias
300     nosferatu root #
301     --------------------------------------------------------
302    
303     I checked the source of locale, but it have fopen with mode 'r', so
304     not sure where the "rm" mode comes from. Anyhow, changed the check in
305     before_syscall_open_char() to also see mode "rm" as readonly.
306    
307     23 Feb 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
308    
309     Add glibc-2.3 support.
310    
311     22 Feb 2003; Martin Schlemmer <azarah@gentoo.org> sandbox.c :
312    
313     Some /etc/ld.so.preload fixes. Just changed the #if defines to cover all
314     operations releated to preload, as well as only try to modify ld.so.preload
315     if we can. Also modify to write the pid to /tmp/sandboxpids.tmp even when
316     not using ld.so.preload. Fix to not write this instance of sandbox's pid
317     to /tmp/sandboxpids.tmp on exit if this is not the last sandbox running.
318    
319     22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> Makefile :
320    
321     Changed the LD to CC for hppa.
322    
323     22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
324    
325     Killed the previous changes I made.
326    
327     17 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
328    
329     Added parisc to BROKEN_RTLD_ARCHLIST to see if it we can fix the relocation probs.
330    
331     09 Jan 2003; J Robert Ray <jrray@gentoo.org> sandbox.c :
332    
333     Don't segfault if $HOME isn't set, set $HOME to "/" instead. Fixes bug 10868.
334    
335     16 Dec 2002; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
336    
337     Fix memory leak for mips, bug #12236. Thanks to Torgeir Hansen <torgeir@trenger.ro>
338     for this fix.
339    
340     4 Dec 2002; J Robert Ray <jrray@gentoo.org> sandbox.h sandbox_futils.c :
341    
342     sandbox_futils defined a dirname() function that was masking the same
343     function in glibc and was broken (e.g.: SANDBOX_DIR was being set to
344     '/usr/lib/portage/bi/'). Fixed function to return expected results and
345     renamed it to sb_dirname() to no longer mask the glibc function. Closes bug
346     11231.
347    
348     4 Dec 2002; Martin Schlemmer <azarah@gentoo.org> :
349    
350     Fix a segfault in libsandbox.c if canonicalize() was called with
351     first parameter = NULL.
352    
353     1 Sep 2002; Martin Schlemmer <azarah@gentoo.org> :
354    
355     Fix my braindead 'return 1;' in a void function. Updated sandbox.c,
356     cleanup() for this.
357    
358     Change cleanup() in sandbox.c not to exit with fail status if
359     the pidsfile is missing. We really should still display sandbox
360     violations if they occured.
361    
362     31 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
363    
364     Update cleanup() in sandbox.c to remove the PIDSFILE if this is
365     the last sandbox running.
366    
367     25 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
368    
369     Major cleanups to mainly libsandbox.c again.
370    
371     22 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
372    
373     Add copyrights to sandbox.h and sandbox_futils.h. If wrong, the
374     parties involved should please contact me so that we can fix it.
375    
376     Add opendir wrapper to libsandbox.c.
377    
378     21 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
379    
380     Do some more cleanups to ecanonicalize(), as it dropped filenames in
381     rare cases (after my symlink cleanups), and caused glibc to bork.
382     These fixes went into canonicalize.c.
383    
384     20 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
385    
386     Fix spawn_shell() and main() in sandbox.c to properly return fail
387     status.
388    
389     19 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
390    
391     The new canonicalize() function in libsandbox.c also resolved symlinks,
392     which caused on cleaning sandbox errors if the symlink pointed to a
393     file in the live root. Ripped out canonicalize() and realpath() from
394     glibc; removed the symlink stuff, and changed them to ecanonicalize()
395     and erealpath().
396    
397     18 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
398    
399     Ripped out all the wrappers, and implemented those of InstallWatch.
400     Losts of cleanups and bugfixes. Implement a execve that forces
401     $LIBSANDBOX in $LD_PRELOAD. We can now thus do away with the feared
402     /etc/ld.so.preload (*g*) ... Made the needed changes to sandbox.c,
403     sandbox.h and sandbox_futils.c. Rewrote the Makefile for most
404     parts; it now have an install target.
405    
406     Reformat the whole thing to look somewhat like the reworked sandbox.c
407     and new sandbox.h and sandbox_futils.c from:
408    
409     Brad House <brad@mainstreetsoftworks.com>.
410    
411     Additional Copyrights now due to the InstallWatch code:
412    
413     Copyright (C) 1998-9 Pancrazio `Ezio' de Mauro <p@demauro.net>

Properties

Name Value
svn:eol-style native
svn:keywords Author Date Id Revision

  ViewVC Help
Powered by ViewVC 1.1.20