/[path-sandbox]/trunk/ChangeLog
Gentoo

Contents of /trunk/ChangeLog

Parent Directory Parent Directory | Revision Log Revision Log


Revision 77 - (hide annotations) (download)
Mon May 9 18:00:45 2005 UTC (9 years, 2 months ago) by azarah
File size: 19327 byte(s)
Fix typo (sizeof -> strlen).

1 ferringb 2 # ChangeLog for Path Sandbox
2 vapier 53 # Copyright 1999-2005 Gentoo Foundation; Distributed under the GPL v2
3 ferringb 2 # $Header$
4    
5 azarah 77 09 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
6     Fix typo (sizeof -> strlen).
7    
8 ferringb 76 08 May 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
9     rewrote the sbcontext caching code so it accounts for env changes since lib
10     initialization.
11    
12 azarah 75 05 May 2005; Martin Schlemmer <azarah@gentoo.org> configure.in, libctest.c:
13     We create libctest.c via configure, so no need to keep it around. Do some
14     cleanup related to libctest.c and libctest during configure.
15    
16 azarah 74 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
17     Add rename support of symlinks pointing to protected files/directories.
18    
19 azarah 72 * sandbox-1.2.5 (2005/05/04)
20    
21 azarah 71 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
22     sandbox.bashrc:
23     Do not reset already set LD_PRELOAD when starting sandbox. If LD_PRELOAD is
24     already set, init of the env vars fails for some reason, so do this later on,
25     and do not warn (bug #91431).
26    
27 azarah 70 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
28     sandbox.bashrc:
29     Fixup sandbox and sandbox.bashrc to call bash with the proper .bashrc.
30    
31 azarah 68 * sandbox-1.2.4 (2005/05/03)
32    
33 azarah 66 03 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
34     Do not init the env entries with each call, as it creates too many calls to
35 azarah 67 lstat, etc. Should speedup things a bit, bug #91040.
36 azarah 66
37 azarah 65 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
38     Add /dev/pty to default write list. Noticed by Morfic.
39    
40 vapier 62 02 May 2005; Mike Frysinger <vapier@gentoo.org> configure.in, localdecls.h,
41     sandbox.h:
42     uClibc doesn't support dlvsym() so add a configure check to make sure it doesn't
43     exist. Also update localdecls.h so BROKEN_RTLD_NEXT isn't defined in uClibc.
44    
45 azarah 59 * sandbox-1.2.3 (2005/04/29)
46    
47 azarah 56 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> configure.in:
48     Do not check for (*&#$(* CXX or F77.
49    
50 azarah 54 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
51     Do not append '/' to pathname in filter_path() if it already ends with it.
52    
53 vapier 53 28 Apr 2005; Mike Frysinger <vapier@gentoo.org> Makefile.am, configure.in:
54     With az's help, clean up autotools to work with cross-compiling.
55    
56 azarah 59 * sandbox-1.2.2 (2005/04/28)
57 azarah 48
58 azarah 47 28 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
59     Only check for /dev/{null,zero} for unlink hack, else ricers using /dev/shm
60     have issues; bug #90592.
61    
62 azarah 59 * sandbox-1.2.1 (2005/04/23)
63 azarah 44
64 azarah 43 23 Apr 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
65     getcwd.c, libsandbox.c, localdecls.h, sandbox.h, sandbox_futils.c:
66     Make sure all functions used in libsandbox.c is declared static. Define
67     SB_STATIC in localdecls.h for this. Include sandbox_futils.c rather than
68     linking with its object. Hopefully this will fix bug #90153.
69    
70 azarah 59 * sandbox-1.2 (2005/04/23)
71 azarah 46
72 azarah 40 22 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
73     Allow lchown a symlink in write-allowed path pointing to write-denied
74     target.
75    
76 genone 39 21 Mar 2005; Marius Mauch <genone@gentoo.org> libsandbox.c:
77     Also show resolved symlink names in the log.
78    
79 azarah 37 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, libsandbox.c:
80     Seems -nostdlib was the problem with the constructor/destructor - remove it
81     from Makefile.am, and change the constructor/destructor names again.
82    
83 azarah 36 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
84     Also rename the _init() and _fini() declarations.
85    
86 azarah 35 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
87     Fixup the constructor/destructor function names again (they should be _init()
88     and _fini() it seems, and not being called caused sandbox_lib_path to be
89     unset, and thus breaking the execve() wrapper's LD_PRELOAD protection).
90     Add both the path in given SANDBOX_x variable, as well as its symlink
91     resolved path in init_env_entries(). Modify filter_path() to be able to
92     resolve paths without resolving symlinks, as well as to be able to resolve
93     symlinks. Fix a possible segfault in check_access(). Add symlink resolving
94     to check_access() resolving bug #31019. Add 'hack' for unlink, as the fix
95     for bug #31019 cause access violations if we try to remove a symlink that is
96     not in protected path, but points to a protected path. Fix a memory leak in
97     sandbox.c (sandbox_pids_file in main()). Fix the realpath() calls in main()
98     (sandbox.c) being unchecked. Fix the debug logname not having the pid in it
99     (pid_string was uninitialized). General syntax cleanups.
100    
101 ferringb 34 09 Mar 2005; Brian Harring <ferringb@gentoo.org> sandbox.c: Fixed the
102     infamous "pids file is not a regular file" w/out newline bug.
103    
104 ferringb 33 09 Mar 2005; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in:
105     Correct libc_version path detection, since it was screwing up if libdir !=
106     "/lib/".
107    
108     02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
109 azarah 32 Hack to make sure sandboxed process cannot remove a device node, bug #79836.
110    
111 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am:
112 azarah 31 Fix symbols.in not added to dist.
113    
114 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
115 azarah 30 getcwd.c, libsandbox.c, sandbox.c, sandbox.h, sandbox_futils.c:
116     White space fixes.
117    
118 ferringb 33 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
119 azarah 30 configure.in, getcwd.c, libsandbox.c, symbols.in:
120 azarah 29 Fix inverse test logic in canonicalize.c, use a strncpy. Fix gcc warning in
121     getcwd.c. Add symbols.in and logic to Makefile.am to generate symbol versions
122     for glibc and other libc's that use this. Update libsandbox.c to use these
123     symbol versions if available. Fix exec wrapper to re-export LD_PRELOAD if the
124     process unset it.
125    
126 ferringb 33 01 Mar 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
127 ferringb 28 killed off _init and _fini in favor of
128     void __attribute__ ((constructor)) init_func and
129     void __attribute__ ((destructor)) closing_func. _(init|func) were deprecated.
130    
131 ferringb 26 06 Dec 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, libsandbox.c,
132     canonicalize.c, getcwd.c: Fixed compilation *again*. Hopefully cvs is done
133     having the hick-ups.
134    
135 ferringb 24 04 Dec 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, getcwd.c,
136     Makefile.am: Fixed compilation.
137    
138 ferringb 18 01 Dec 2004; Brian Harring <ferringb@gentoo.org> aclocal.m4:
139     Gutted the bugger so it stops checking for a c++ and fortran compiler.
140     Do *not* regenerate aclocal.m4 for making a release until a better
141     solution is created.
142    
143 ferringb 16 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, sandbox_futils.c:
144     Removal of more hardcoded paths.
145    
146 ferringb 13 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in,
147     sandbox_futils.c: tweaks to install sandbox.bashrc, and use it.
148    
149     19 Nov 2004; Brian Harring <ferringb@gentoo.org>:
150 ferringb 6 Sandbox is now autotooled, create-localdecls needs to be killed and the code
151     shifted into configure.in. Currently builds *one* libsandbox.so- if multiple
152     are desired (-m64 and -m32 for amd64), the ebuild should do it (imo).
153     To get to a point of testing, automake && autoconf; created requisite files w/
154     a(utomake|clocal)-1.8, and autoconf 2.59. Installs to /usr/, instead of
155     /lib and /usr/lib/portage/bin.
156    
157 ferringb 2 14 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox.c:
158     closing out bug #70225, potential overflow of the sandbox_pids_file var.
159    
160     07 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c: c99 standard,
161     (think it was at least) allows intermixing of code and data segments. bug #70351
162     should be fixed by this.
163    
164     03 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox_futils.c:
165     futils fix from bug #65201 via solar, and libsandbox log path checks via #69137
166    
167     02 Aug 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Code from
168     Seth Robertson that tracked down all adjuct flags for read operations that
169     do not invoke a write operation.
170    
171     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
172     Another fix from jstubbs regarding a free() on a stack variable for the
173     environment -- tracking now prevents extraneous free()'s segfault.
174    
175     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
176     J. Stubbs tracked down a new bug where mkdir was failing to the patch on
177     the lstat in mkdir... it now only returns 0 or -1 as documented for mkdir.
178     Also remove the errno = ESUCCESS settings as documentation points out that
179     a library isn't allowed to do that.
180    
181     04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Added a
182     file_security_check() function to check random potential exploits on files
183     that sandbox is to load and read -- Normally sandboxpids.tmp. This fixes
184     the 'system-crippling' exploits (bug 21923) and catches a few other
185     potential problems.
186    
187     20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> Makefile: Updates for
188     32/64 bit sandbox. Made CC and LD '?=' values to allow passed in CC to work.
189    
190     20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c:
191     bug 42048 -- Fixed the lstat/errno conditions for mkdir <caleb@g.o>.
192     Added the 64/32 bit sandbox patch for AMD64 bug 32963 <brad/azarah>.
193    
194     29 Feb 2004; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c :
195     Fix permissions and group of pids file and logs. Permissions should be 0664
196     and group should be 'portage'. Bug #34260.
197    
198     28 Feb 2004; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
199     Besides a small cleanup, redo how we replace LD_PRELOAD in the environ passed
200     to the real execve (in our execve wrapper). Seems that on some arches (sparc
201     among others) do not allow us to tamper with the readonly copy passed to
202     execve, so pass our own copy of the environment. Bug #42290.
203    
204     11 Jan 2004; Nicholas Jones <carpaski@gentoo.org> create-decls:
205     Changed tail to head and added a notice about duration of glibc check.
206    
207     21 Dec 2003; Nicholas Jones <carpaski@gentoo.org> create-decls:
208     Changed the glibc subversion check to use /usr/bin/* instead of /bin/sh
209     as there isn't a guarentee that it is dynamic.
210    
211     02 Nov 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
212     If 'file' passed to before_syscall(const char *func, const char *file) is
213     invalid, we should set errno to ENOENT, and not EINVAL. This should
214     close bug #32238.
215    
216     14 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
217     Fix a bug that occurs mainly on 64bit arch, where the file passed to
218     the functions we wrap, is invalid, and then cause canonicalize to pass
219     garbage to before_syscall(), thanks to great detective work from
220     Andrea Luzzardi <al@sig11.org> (bug #29846).
221    
222     13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
223     Add a uClibc detection patch from Peter S. Mazinger <ps.m@gmx.net>.
224    
225     13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
226     Fix a bug in libsandbox.c 's checking in the rename wrapper - it basically
227     only checked the destination patch, and not the source, so we could move
228     a protected file to a unprotected directory, and then delete/modify it.
229     Thanks to Andrea Luzzardi (scox) <al@sig11.org>, bug #30992, for this fix.
230    
231     12 Oct 2003; Nicholas Jones <carpaski@gentoo.org> sandbox.c :
232     Added python2.3 to the predict section/variable.
233    
234     28 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
235     sandbox.h, sandbox_futils.c :
236     Add support to set the pids file via SANDBOX_PIDS_FILE at startup. If
237     it is not set, it will revert to its old value.
238    
239     27 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
240     Fix our mkdir wrapper to check if the dir exist, and return EEXIST if so,
241     rather than failing with a violation, bug #29748.
242    
243     27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
244     Fix canonicalize() to ignore calls with path = "".
245    
246     27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c,
247     sandbox_futils.c, canonicalize.c :
248     Once again coreutils fails, as my systems had 2.5 kernel, the getcwd system
249     call handled strings larger than PATH_MAX (bug #21766). It however does not
250     work the same on 2.4 kernels.
251    
252     To fix, I added the posix implementation of getcwd() (from glibc cvs) that
253     do not need the system call. We use the default getcwd() function via a
254     wrapper (egetcwd), and then lstat the returned path. If lstat fails, it
255     means the current directory was removed, OR that the the system call for
256     getcwd failed (curious is that it do not fail and return NULL or set
257     errno, but rather just truncate the retured directory - usually from the
258     start), and if so, we use the generic getcwd() function (__egetcwd). Note
259     that we do not use the generic version all the time, as it calls lstat()
260     a great number of times, and performance degrade much.
261    
262     29 Jun 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls,
263     libsandbox.c :
264     Make sure SB_PATH_MAX will not wrap. Fix two possible memory leaks.
265    
266     22 Jun 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, canonicalize.c
267     create-localdecls :
268     When checking path names of files accessed, we need to canonicalize it, else
269     it may be a symlink in a 'write allowed' directory pointing to a file in a
270     directory we should not have write access to.
271    
272     With something like coreutils-5.0, we have two problems:
273     1) One of the tests checks if getcwd() can return a path longer than
274     PATH_MAX. This test then tries to create a dir which even while
275     created local (mkdir("conftest2")), it ends up being resolved with
276     a name that is much larger than PATH_MAX. The problem now is that
277     canonicalize() have undefined behaviour when the path was too long
278     (returned wrongly truncated paths, etc), and pass the wrong path to
279     before_syscall() (causing the bogus sandbox violations).
280     2) The ecanonicalize() function we used, along with the canonicalize()
281     function did not support longer than PATH_MAX. This is partly a
282     cause for 1), but the error checking (rather lack of it) of calls
283     to erealpath() in canonicalize() was the prime reason for 1).
284    
285     As we do not use this canonicalized name to call the function, we resolve this
286     by fixing canonicalize() to do better error checking, and ecanonicalize() as
287     well as all functions in libsandbox.c to use a PATH_MAX of 'PATH_MAX * 2'.
288     While they will resolve paths properly now, and can check if a write/read is
289     allowed, the functions called from the sandboxed environment will still work
290     as expected.
291    
292     This should resolve bug #21766.
293    
294     06 Apr 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
295     For some reason sandbox fails with a 'open_wr' if you run 'locale -a' under
296     it (bug #16298).
297    
298     Problem is that for some reason locale fopen's locale.alias with mode "rm".
299    
300     -------------------------------------------------------
301     nosferatu root # grep fopen locale.log
302     fopen("/usr/share/locale/locale.alias", "rm"ACCESS DENIED open_wr: /usr/share/locale/locale.alias
303     nosferatu root #
304     --------------------------------------------------------
305    
306     I checked the source of locale, but it have fopen with mode 'r', so
307     not sure where the "rm" mode comes from. Anyhow, changed the check in
308     before_syscall_open_char() to also see mode "rm" as readonly.
309    
310     23 Feb 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
311    
312     Add glibc-2.3 support.
313    
314     22 Feb 2003; Martin Schlemmer <azarah@gentoo.org> sandbox.c :
315    
316     Some /etc/ld.so.preload fixes. Just changed the #if defines to cover all
317     operations releated to preload, as well as only try to modify ld.so.preload
318     if we can. Also modify to write the pid to /tmp/sandboxpids.tmp even when
319     not using ld.so.preload. Fix to not write this instance of sandbox's pid
320     to /tmp/sandboxpids.tmp on exit if this is not the last sandbox running.
321    
322     22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> Makefile :
323    
324     Changed the LD to CC for hppa.
325    
326     22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
327    
328     Killed the previous changes I made.
329    
330     17 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
331    
332     Added parisc to BROKEN_RTLD_ARCHLIST to see if it we can fix the relocation probs.
333    
334     09 Jan 2003; J Robert Ray <jrray@gentoo.org> sandbox.c :
335    
336     Don't segfault if $HOME isn't set, set $HOME to "/" instead. Fixes bug 10868.
337    
338     16 Dec 2002; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
339    
340     Fix memory leak for mips, bug #12236. Thanks to Torgeir Hansen <torgeir@trenger.ro>
341     for this fix.
342    
343     4 Dec 2002; J Robert Ray <jrray@gentoo.org> sandbox.h sandbox_futils.c :
344    
345     sandbox_futils defined a dirname() function that was masking the same
346     function in glibc and was broken (e.g.: SANDBOX_DIR was being set to
347     '/usr/lib/portage/bi/'). Fixed function to return expected results and
348     renamed it to sb_dirname() to no longer mask the glibc function. Closes bug
349     11231.
350    
351     4 Dec 2002; Martin Schlemmer <azarah@gentoo.org> :
352    
353     Fix a segfault in libsandbox.c if canonicalize() was called with
354     first parameter = NULL.
355    
356     1 Sep 2002; Martin Schlemmer <azarah@gentoo.org> :
357    
358     Fix my braindead 'return 1;' in a void function. Updated sandbox.c,
359     cleanup() for this.
360    
361     Change cleanup() in sandbox.c not to exit with fail status if
362     the pidsfile is missing. We really should still display sandbox
363     violations if they occured.
364    
365     31 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
366    
367     Update cleanup() in sandbox.c to remove the PIDSFILE if this is
368     the last sandbox running.
369    
370     25 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
371    
372     Major cleanups to mainly libsandbox.c again.
373    
374     22 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
375    
376     Add copyrights to sandbox.h and sandbox_futils.h. If wrong, the
377     parties involved should please contact me so that we can fix it.
378    
379     Add opendir wrapper to libsandbox.c.
380    
381     21 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
382    
383     Do some more cleanups to ecanonicalize(), as it dropped filenames in
384     rare cases (after my symlink cleanups), and caused glibc to bork.
385     These fixes went into canonicalize.c.
386    
387     20 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
388    
389     Fix spawn_shell() and main() in sandbox.c to properly return fail
390     status.
391    
392     19 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
393    
394     The new canonicalize() function in libsandbox.c also resolved symlinks,
395     which caused on cleaning sandbox errors if the symlink pointed to a
396     file in the live root. Ripped out canonicalize() and realpath() from
397     glibc; removed the symlink stuff, and changed them to ecanonicalize()
398     and erealpath().
399    
400     18 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
401    
402     Ripped out all the wrappers, and implemented those of InstallWatch.
403     Losts of cleanups and bugfixes. Implement a execve that forces
404     $LIBSANDBOX in $LD_PRELOAD. We can now thus do away with the feared
405     /etc/ld.so.preload (*g*) ... Made the needed changes to sandbox.c,
406     sandbox.h and sandbox_futils.c. Rewrote the Makefile for most
407     parts; it now have an install target.
408    
409     Reformat the whole thing to look somewhat like the reworked sandbox.c
410     and new sandbox.h and sandbox_futils.c from:
411    
412     Brad House <brad@mainstreetsoftworks.com>.
413    
414     Additional Copyrights now due to the InstallWatch code:
415    
416     Copyright (C) 1998-9 Pancrazio `Ezio' de Mauro <p@demauro.net>

Properties

Name Value
svn:eol-style native
svn:keywords Author Date Id Revision

  ViewVC Help
Powered by ViewVC 1.1.20