/[path-sandbox]/trunk/ChangeLog
Gentoo

Contents of /trunk/ChangeLog

Parent Directory Parent Directory | Revision Log Revision Log


Revision 139 - (show annotations) (download)
Thu Jul 7 21:42:33 2005 UTC (9 years ago) by azarah
File size: 26292 byte(s)
Major cleanup of sandbox_futils.c.  Removed most of the functions as we now
write to /var/log/sandbox/, so in theory do not need all that.

1 # ChangeLog for Path Sandbox
2 # Copyright 1999-2005 Gentoo Foundation; Distributed under the GPL v2
3 # $Header$
4
5 07 July 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
6 sandbox.h, sandbox_futils.c:
7 - Fix possible segfault in env init code.
8 - Major cleanup of sandbox_futils.c. Removed most of the functions as we now
9 write to /var/log/sandbox/, so in theory do not need all that.
10
11 06 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.h, sandbox_futils.c,
12 libsandbox.c:
13 - Change log dir to /var/log/sandbox/. Make sure the sandboxed process cannot
14 write to it.
15 - Clean up logging in libsandbox.c, and hopefully make it more consistant.
16 - Add check_prefixes() with major cleanup on check_access().
17 - Cleanup init_env_entries() and check_prefixes().
18
19 05 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
20 sandbox_futils.c, libsandbox.c:
21 Remove unused 'pids file' code.
22
23 * sandbox-1.2.10 (2005/07/03)
24
25 03 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
26 Add PREDICT items for nss-db, bug #92079. Patch from Robin Johnson.
27
28 17 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
29 General cleanups:
30 - Remove fooling around with exit codes - we error out on presence of a log
31 anyhow.
32 - Move get_sandbox_*_envvar() to sandbox_setup_environ(), as its more
33 appropriate there.
34
35 12 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
36 Cleanup the fail_nametoolong stuff a bit more.
37
38 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
39 Remove hopefully the last ld.so.preload bits we do not use anymore.
40
41 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
42 Remove the unneeded canonicalize() calls in the wrappers - we do it anyhow
43 in check_syscall(). Should speed things up a bit (at least for the getcwd()
44 and long path name test it goes down to under a second, and not 10+ seconds
45 like before). Also warn if we skip checking due to the canonicalized path
46 being too long.
47
48 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
49 More comment/readability cleanups.
50
51 10 June 2005; Martin Schlemmer <azarah@gentoo.org> canonicalize.c, getcwd.c,
52 sandbox_futils.c, libsandbox.c:
53 Some strncpy/strncat and other cleanups.
54
55 * sandbox-1.2.9 (2005/06/09)
56
57 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
58 Move symlink hack down a bit to try and minimize on the amount of lstat()
59 calls we do.
60
61 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
62 Add hack to allow writing to /proc/self/fd (or /dev/fd), bug #91516.
63
64 09 June 2005; Martin Schlemmer <azarah@gentoo.org> symbols.in, libsandbox.c:
65 Add wrapper for access() function, bug #85413.
66
67 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c:
68 Use generic getcwd() implementation from uclibc - should be more portable
69 and looks a bit cleaner.
70
71 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c:
72 Make sure our true_* pointers are initialized to NULL, and that we check for
73 all references that they are valid.
74
75 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
76 Be default we will fail if the path name we try to canonicalize is too long.
77 This however could cause issues with some things (bug #94630 and #21766), so
78 if fail_nametoolong == 0, canonicalize() will return a null length string and
79 do not fail.
80
81 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c:
82 Do not abort if TMPDIR is not valid, but rather use '/tmp', bug #94360. Also
83 make sure we re-export the new TMPDIR environment variable.
84
85 08 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
86 Fix incorrect free of non-malloc'd array, bug #92313 and #94020. Fix noted
87 by Marcus D. Hanwell <cryos@gentoo.org>.
88
89 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
90 Add /dev/console to write list, bug #38588.
91
92 * sandbox-1.2.8 (2005/05/13)
93
94 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
95 sandbox.h, sandbox_futils.c:
96 General cleanups.
97
98 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
99 sandbox.h:
100 Various LD_PRELOAD cleanups. Do not unset LD_PRELOAD for parent.
101
102 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
103 sandbox.h, sandbox_futils.c:
104 Modify get_sandbox_pids_file(), get_sandbox_log() and get_sandbox_debug_log()
105 to use TMPDIR if present in environment.
106
107 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
108 Remove sandbox_log_file from main() as its no longer used.
109
110 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
111 sandbox_futils.c:
112 Add get_sandbox_debug_log(), and use it (add behaviour similar to SANDBOX_LOG
113 if already exported when sandbox started). Fix get_sandbox_log() and new
114 get_sandbox_debug_log() to not use already exported environment variables if
115 they have '/' in them. Use snprintf()'s instead of strncpy()'s. More
116 SB_PATH_MAX fixes.
117
118 * sandbox-1.2.7 (2005/05/12)
119
120 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
121 sandbox_futils.c:
122 More path limit fixes. Declare SB_BUF_LEN global and use it where needed.
123
124 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
125 Fix paths limited to 255 chars. Fix get_sandbox_dir() returning a string
126 with '(null)' in it if we did not call sandbox with absolute path.
127
128 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
129 Set SANDBOX_ON *before* doing the child's env stuff, else its not set
130 for the child.
131
132 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
133 Remove global preload_adaptable as it is no longer used.
134
135 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
136 Rewrite environment stuff to only be set when execve'ing the child process
137 to try and avoid issues like bug #91541 that causes sandbox to crash if
138 we set LD_PRELOAD sandbox side already.
139
140 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
141 Move print_sandbox_log() up to make things neater.
142
143 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
144 Remove load_preload_libs(), as its not used anymore.
145
146 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
147 Remove NO_FORK stuff, as its not used, and 'strace -f' works just fine.
148
149 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
150 Remove USE_SYSTEM_SHELL stuff, as it is not secure, and not in use.
151
152 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
153 Remove ld.so.preload crap - we are not going to use it again.
154
155 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
156 Fix typo in code that checks if we got valid group information, causing a
157 segmentation fault, bug #91637.
158
159 * sandbox-1.2.6 (2005/05/10)
160
161 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
162 Do not use LD_PRELOAD if it contains libtsocks.so, as it breaks sandbox
163 for some odd reason, bug #91541.
164
165 09 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
166 Fix typo (sizeof -> strlen).
167
168 08 May 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
169 rewrote the sbcontext caching code so it accounts for env changes since lib
170 initialization.
171
172 05 May 2005; Martin Schlemmer <azarah@gentoo.org> configure.in, libctest.c:
173 We create libctest.c via configure, so no need to keep it around. Do some
174 cleanup related to libctest.c and libctest during configure.
175
176 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
177 Add rename support of symlinks pointing to protected files/directories.
178
179 * sandbox-1.2.5 (2005/05/04)
180
181 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
182 sandbox.bashrc:
183 Do not reset already set LD_PRELOAD when starting sandbox. If LD_PRELOAD is
184 already set, init of the env vars fails for some reason, so do this later on,
185 and do not warn (bug #91431).
186
187 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
188 sandbox.bashrc:
189 Fixup sandbox and sandbox.bashrc to call bash with the proper .bashrc.
190
191 * sandbox-1.2.4 (2005/05/03)
192
193 03 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
194 Do not init the env entries with each call, as it creates too many calls to
195 lstat, etc. Should speedup things a bit, bug #91040.
196
197 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
198 Add /dev/pty to default write list. Noticed by Morfic.
199
200 02 May 2005; Mike Frysinger <vapier@gentoo.org> configure.in, localdecls.h,
201 sandbox.h:
202 uClibc doesn't support dlvsym() so add a configure check to make sure it doesn't
203 exist. Also update localdecls.h so BROKEN_RTLD_NEXT isn't defined in uClibc.
204
205 * sandbox-1.2.3 (2005/04/29)
206
207 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> configure.in:
208 Do not check for (*&#$(* CXX or F77.
209
210 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
211 Do not append '/' to pathname in filter_path() if it already ends with it.
212
213 28 Apr 2005; Mike Frysinger <vapier@gentoo.org> Makefile.am, configure.in:
214 With az's help, clean up autotools to work with cross-compiling.
215
216 * sandbox-1.2.2 (2005/04/28)
217
218 28 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
219 Only check for /dev/{null,zero} for unlink hack, else ricers using /dev/shm
220 have issues; bug #90592.
221
222 * sandbox-1.2.1 (2005/04/23)
223
224 23 Apr 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
225 getcwd.c, libsandbox.c, localdecls.h, sandbox.h, sandbox_futils.c:
226 Make sure all functions used in libsandbox.c is declared static. Define
227 SB_STATIC in localdecls.h for this. Include sandbox_futils.c rather than
228 linking with its object. Hopefully this will fix bug #90153.
229
230 * sandbox-1.2 (2005/04/23)
231
232 22 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
233 Allow lchown a symlink in write-allowed path pointing to write-denied
234 target.
235
236 21 Mar 2005; Marius Mauch <genone@gentoo.org> libsandbox.c:
237 Also show resolved symlink names in the log.
238
239 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, libsandbox.c:
240 Seems -nostdlib was the problem with the constructor/destructor - remove it
241 from Makefile.am, and change the constructor/destructor names again.
242
243 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
244 Also rename the _init() and _fini() declarations.
245
246 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
247 Fixup the constructor/destructor function names again (they should be _init()
248 and _fini() it seems, and not being called caused sandbox_lib_path to be
249 unset, and thus breaking the execve() wrapper's LD_PRELOAD protection).
250 Add both the path in given SANDBOX_x variable, as well as its symlink
251 resolved path in init_env_entries(). Modify filter_path() to be able to
252 resolve paths without resolving symlinks, as well as to be able to resolve
253 symlinks. Fix a possible segfault in check_access(). Add symlink resolving
254 to check_access() resolving bug #31019. Add 'hack' for unlink, as the fix
255 for bug #31019 cause access violations if we try to remove a symlink that is
256 not in protected path, but points to a protected path. Fix a memory leak in
257 sandbox.c (sandbox_pids_file in main()). Fix the realpath() calls in main()
258 (sandbox.c) being unchecked. Fix the debug logname not having the pid in it
259 (pid_string was uninitialized). General syntax cleanups.
260
261 09 Mar 2005; Brian Harring <ferringb@gentoo.org> sandbox.c: Fixed the
262 infamous "pids file is not a regular file" w/out newline bug.
263
264 09 Mar 2005; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in:
265 Correct libc_version path detection, since it was screwing up if libdir !=
266 "/lib/".
267
268 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
269 Hack to make sure sandboxed process cannot remove a device node, bug #79836.
270
271 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am:
272 Fix symbols.in not added to dist.
273
274 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
275 getcwd.c, libsandbox.c, sandbox.c, sandbox.h, sandbox_futils.c:
276 White space fixes.
277
278 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
279 configure.in, getcwd.c, libsandbox.c, symbols.in:
280 Fix inverse test logic in canonicalize.c, use a strncpy. Fix gcc warning in
281 getcwd.c. Add symbols.in and logic to Makefile.am to generate symbol versions
282 for glibc and other libc's that use this. Update libsandbox.c to use these
283 symbol versions if available. Fix exec wrapper to re-export LD_PRELOAD if the
284 process unset it.
285
286 01 Mar 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
287 killed off _init and _fini in favor of
288 void __attribute__ ((constructor)) init_func and
289 void __attribute__ ((destructor)) closing_func. _(init|func) were deprecated.
290
291 06 Dec 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, libsandbox.c,
292 canonicalize.c, getcwd.c: Fixed compilation *again*. Hopefully cvs is done
293 having the hick-ups.
294
295 04 Dec 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, getcwd.c,
296 Makefile.am: Fixed compilation.
297
298 01 Dec 2004; Brian Harring <ferringb@gentoo.org> aclocal.m4:
299 Gutted the bugger so it stops checking for a c++ and fortran compiler.
300 Do *not* regenerate aclocal.m4 for making a release until a better
301 solution is created.
302
303 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, sandbox_futils.c:
304 Removal of more hardcoded paths.
305
306 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in,
307 sandbox_futils.c: tweaks to install sandbox.bashrc, and use it.
308
309 19 Nov 2004; Brian Harring <ferringb@gentoo.org>:
310 Sandbox is now autotooled, create-localdecls needs to be killed and the code
311 shifted into configure.in. Currently builds *one* libsandbox.so- if multiple
312 are desired (-m64 and -m32 for amd64), the ebuild should do it (imo).
313 To get to a point of testing, automake && autoconf; created requisite files w/
314 a(utomake|clocal)-1.8, and autoconf 2.59. Installs to /usr/, instead of
315 /lib and /usr/lib/portage/bin.
316
317 14 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox.c:
318 closing out bug #70225, potential overflow of the sandbox_pids_file var.
319
320 07 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c: c99 standard,
321 (think it was at least) allows intermixing of code and data segments. bug #70351
322 should be fixed by this.
323
324 03 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox_futils.c:
325 futils fix from bug #65201 via solar, and libsandbox log path checks via #69137
326
327 02 Aug 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Code from
328 Seth Robertson that tracked down all adjuct flags for read operations that
329 do not invoke a write operation.
330
331 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
332 Another fix from jstubbs regarding a free() on a stack variable for the
333 environment -- tracking now prevents extraneous free()'s segfault.
334
335 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
336 J. Stubbs tracked down a new bug where mkdir was failing to the patch on
337 the lstat in mkdir... it now only returns 0 or -1 as documented for mkdir.
338 Also remove the errno = ESUCCESS settings as documentation points out that
339 a library isn't allowed to do that.
340
341 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Added a
342 file_security_check() function to check random potential exploits on files
343 that sandbox is to load and read -- Normally sandboxpids.tmp. This fixes
344 the 'system-crippling' exploits (bug 21923) and catches a few other
345 potential problems.
346
347 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> Makefile: Updates for
348 32/64 bit sandbox. Made CC and LD '?=' values to allow passed in CC to work.
349
350 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c:
351 bug 42048 -- Fixed the lstat/errno conditions for mkdir <caleb@g.o>.
352 Added the 64/32 bit sandbox patch for AMD64 bug 32963 <brad/azarah>.
353
354 29 Feb 2004; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c :
355 Fix permissions and group of pids file and logs. Permissions should be 0664
356 and group should be 'portage'. Bug #34260.
357
358 28 Feb 2004; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
359 Besides a small cleanup, redo how we replace LD_PRELOAD in the environ passed
360 to the real execve (in our execve wrapper). Seems that on some arches (sparc
361 among others) do not allow us to tamper with the readonly copy passed to
362 execve, so pass our own copy of the environment. Bug #42290.
363
364 11 Jan 2004; Nicholas Jones <carpaski@gentoo.org> create-decls:
365 Changed tail to head and added a notice about duration of glibc check.
366
367 21 Dec 2003; Nicholas Jones <carpaski@gentoo.org> create-decls:
368 Changed the glibc subversion check to use /usr/bin/* instead of /bin/sh
369 as there isn't a guarentee that it is dynamic.
370
371 02 Nov 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
372 If 'file' passed to before_syscall(const char *func, const char *file) is
373 invalid, we should set errno to ENOENT, and not EINVAL. This should
374 close bug #32238.
375
376 14 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
377 Fix a bug that occurs mainly on 64bit arch, where the file passed to
378 the functions we wrap, is invalid, and then cause canonicalize to pass
379 garbage to before_syscall(), thanks to great detective work from
380 Andrea Luzzardi <al@sig11.org> (bug #29846).
381
382 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
383 Add a uClibc detection patch from Peter S. Mazinger <ps.m@gmx.net>.
384
385 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
386 Fix a bug in libsandbox.c 's checking in the rename wrapper - it basically
387 only checked the destination patch, and not the source, so we could move
388 a protected file to a unprotected directory, and then delete/modify it.
389 Thanks to Andrea Luzzardi (scox) <al@sig11.org>, bug #30992, for this fix.
390
391 12 Oct 2003; Nicholas Jones <carpaski@gentoo.org> sandbox.c :
392 Added python2.3 to the predict section/variable.
393
394 28 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
395 sandbox.h, sandbox_futils.c :
396 Add support to set the pids file via SANDBOX_PIDS_FILE at startup. If
397 it is not set, it will revert to its old value.
398
399 27 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
400 Fix our mkdir wrapper to check if the dir exist, and return EEXIST if so,
401 rather than failing with a violation, bug #29748.
402
403 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
404 Fix canonicalize() to ignore calls with path = "".
405
406 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c,
407 sandbox_futils.c, canonicalize.c :
408 Once again coreutils fails, as my systems had 2.5 kernel, the getcwd system
409 call handled strings larger than PATH_MAX (bug #21766). It however does not
410 work the same on 2.4 kernels.
411
412 To fix, I added the posix implementation of getcwd() (from glibc cvs) that
413 do not need the system call. We use the default getcwd() function via a
414 wrapper (egetcwd), and then lstat the returned path. If lstat fails, it
415 means the current directory was removed, OR that the the system call for
416 getcwd failed (curious is that it do not fail and return NULL or set
417 errno, but rather just truncate the retured directory - usually from the
418 start), and if so, we use the generic getcwd() function (__egetcwd). Note
419 that we do not use the generic version all the time, as it calls lstat()
420 a great number of times, and performance degrade much.
421
422 29 Jun 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls,
423 libsandbox.c :
424 Make sure SB_PATH_MAX will not wrap. Fix two possible memory leaks.
425
426 22 Jun 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, canonicalize.c
427 create-localdecls :
428 When checking path names of files accessed, we need to canonicalize it, else
429 it may be a symlink in a 'write allowed' directory pointing to a file in a
430 directory we should not have write access to.
431
432 With something like coreutils-5.0, we have two problems:
433 1) One of the tests checks if getcwd() can return a path longer than
434 PATH_MAX. This test then tries to create a dir which even while
435 created local (mkdir("conftest2")), it ends up being resolved with
436 a name that is much larger than PATH_MAX. The problem now is that
437 canonicalize() have undefined behaviour when the path was too long
438 (returned wrongly truncated paths, etc), and pass the wrong path to
439 before_syscall() (causing the bogus sandbox violations).
440 2) The ecanonicalize() function we used, along with the canonicalize()
441 function did not support longer than PATH_MAX. This is partly a
442 cause for 1), but the error checking (rather lack of it) of calls
443 to erealpath() in canonicalize() was the prime reason for 1).
444
445 As we do not use this canonicalized name to call the function, we resolve this
446 by fixing canonicalize() to do better error checking, and ecanonicalize() as
447 well as all functions in libsandbox.c to use a PATH_MAX of 'PATH_MAX * 2'.
448 While they will resolve paths properly now, and can check if a write/read is
449 allowed, the functions called from the sandboxed environment will still work
450 as expected.
451
452 This should resolve bug #21766.
453
454 06 Apr 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
455 For some reason sandbox fails with a 'open_wr' if you run 'locale -a' under
456 it (bug #16298).
457
458 Problem is that for some reason locale fopen's locale.alias with mode "rm".
459
460 -------------------------------------------------------
461 nosferatu root # grep fopen locale.log
462 fopen("/usr/share/locale/locale.alias", "rm"ACCESS DENIED open_wr: /usr/share/locale/locale.alias
463 nosferatu root #
464 --------------------------------------------------------
465
466 I checked the source of locale, but it have fopen with mode 'r', so
467 not sure where the "rm" mode comes from. Anyhow, changed the check in
468 before_syscall_open_char() to also see mode "rm" as readonly.
469
470 23 Feb 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
471
472 Add glibc-2.3 support.
473
474 22 Feb 2003; Martin Schlemmer <azarah@gentoo.org> sandbox.c :
475
476 Some /etc/ld.so.preload fixes. Just changed the #if defines to cover all
477 operations releated to preload, as well as only try to modify ld.so.preload
478 if we can. Also modify to write the pid to /tmp/sandboxpids.tmp even when
479 not using ld.so.preload. Fix to not write this instance of sandbox's pid
480 to /tmp/sandboxpids.tmp on exit if this is not the last sandbox running.
481
482 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> Makefile :
483
484 Changed the LD to CC for hppa.
485
486 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
487
488 Killed the previous changes I made.
489
490 17 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
491
492 Added parisc to BROKEN_RTLD_ARCHLIST to see if it we can fix the relocation probs.
493
494 09 Jan 2003; J Robert Ray <jrray@gentoo.org> sandbox.c :
495
496 Don't segfault if $HOME isn't set, set $HOME to "/" instead. Fixes bug 10868.
497
498 16 Dec 2002; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
499
500 Fix memory leak for mips, bug #12236. Thanks to Torgeir Hansen <torgeir@trenger.ro>
501 for this fix.
502
503 4 Dec 2002; J Robert Ray <jrray@gentoo.org> sandbox.h sandbox_futils.c :
504
505 sandbox_futils defined a dirname() function that was masking the same
506 function in glibc and was broken (e.g.: SANDBOX_DIR was being set to
507 '/usr/lib/portage/bi/'). Fixed function to return expected results and
508 renamed it to sb_dirname() to no longer mask the glibc function. Closes bug
509 11231.
510
511 4 Dec 2002; Martin Schlemmer <azarah@gentoo.org> :
512
513 Fix a segfault in libsandbox.c if canonicalize() was called with
514 first parameter = NULL.
515
516 1 Sep 2002; Martin Schlemmer <azarah@gentoo.org> :
517
518 Fix my braindead 'return 1;' in a void function. Updated sandbox.c,
519 cleanup() for this.
520
521 Change cleanup() in sandbox.c not to exit with fail status if
522 the pidsfile is missing. We really should still display sandbox
523 violations if they occured.
524
525 31 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
526
527 Update cleanup() in sandbox.c to remove the PIDSFILE if this is
528 the last sandbox running.
529
530 25 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
531
532 Major cleanups to mainly libsandbox.c again.
533
534 22 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
535
536 Add copyrights to sandbox.h and sandbox_futils.h. If wrong, the
537 parties involved should please contact me so that we can fix it.
538
539 Add opendir wrapper to libsandbox.c.
540
541 21 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
542
543 Do some more cleanups to ecanonicalize(), as it dropped filenames in
544 rare cases (after my symlink cleanups), and caused glibc to bork.
545 These fixes went into canonicalize.c.
546
547 20 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
548
549 Fix spawn_shell() and main() in sandbox.c to properly return fail
550 status.
551
552 19 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
553
554 The new canonicalize() function in libsandbox.c also resolved symlinks,
555 which caused on cleaning sandbox errors if the symlink pointed to a
556 file in the live root. Ripped out canonicalize() and realpath() from
557 glibc; removed the symlink stuff, and changed them to ecanonicalize()
558 and erealpath().
559
560 18 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
561
562 Ripped out all the wrappers, and implemented those of InstallWatch.
563 Losts of cleanups and bugfixes. Implement a execve that forces
564 $LIBSANDBOX in $LD_PRELOAD. We can now thus do away with the feared
565 /etc/ld.so.preload (*g*) ... Made the needed changes to sandbox.c,
566 sandbox.h and sandbox_futils.c. Rewrote the Makefile for most
567 parts; it now have an install target.
568
569 Reformat the whole thing to look somewhat like the reworked sandbox.c
570 and new sandbox.h and sandbox_futils.c from:
571
572 Brad House <brad@mainstreetsoftworks.com>.
573
574 Additional Copyrights now due to the InstallWatch code:
575
576 Copyright (C) 1998-9 Pancrazio `Ezio' de Mauro <p@demauro.net>

Properties

Name Value
svn:eol-style native
svn:keywords Author Date Id Revision

  ViewVC Help
Powered by ViewVC 1.1.20