/[path-sandbox]/trunk/ChangeLog
Gentoo

Contents of /trunk/ChangeLog

Parent Directory Parent Directory | Revision Log Revision Log


Revision 140 - (show annotations) (download)
Thu Jul 7 22:01:14 2005 UTC (9 years, 4 months ago) by azarah
File size: 26369 byte(s)
Redo the interface of the get_* functions so that we do not leak memory.
1 # ChangeLog for Path Sandbox
2 # Copyright 1999-2005 Gentoo Foundation; Distributed under the GPL v2
3 # $Header$
4
5 07 July 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
6 sandbox.h, sandbox_futils.c:
7 - Fix possible segfault in env init code.
8 - Major cleanup of sandbox_futils.c. Removed most of the functions as we now
9 write to /var/log/sandbox/, so in theory do not need all that.
10 - Redo the interface of the get_* functions so that we do not leak memory.
11
12 06 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.h, sandbox_futils.c,
13 libsandbox.c:
14 - Change log dir to /var/log/sandbox/. Make sure the sandboxed process cannot
15 write to it.
16 - Clean up logging in libsandbox.c, and hopefully make it more consistant.
17 - Add check_prefixes() with major cleanup on check_access().
18 - Cleanup init_env_entries() and check_prefixes().
19
20 05 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
21 sandbox_futils.c, libsandbox.c:
22 Remove unused 'pids file' code.
23
24 * sandbox-1.2.10 (2005/07/03)
25
26 03 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
27 Add PREDICT items for nss-db, bug #92079. Patch from Robin Johnson.
28
29 17 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
30 General cleanups:
31 - Remove fooling around with exit codes - we error out on presence of a log
32 anyhow.
33 - Move get_sandbox_*_envvar() to sandbox_setup_environ(), as its more
34 appropriate there.
35
36 12 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
37 Cleanup the fail_nametoolong stuff a bit more.
38
39 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
40 Remove hopefully the last ld.so.preload bits we do not use anymore.
41
42 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
43 Remove the unneeded canonicalize() calls in the wrappers - we do it anyhow
44 in check_syscall(). Should speed things up a bit (at least for the getcwd()
45 and long path name test it goes down to under a second, and not 10+ seconds
46 like before). Also warn if we skip checking due to the canonicalized path
47 being too long.
48
49 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
50 More comment/readability cleanups.
51
52 10 June 2005; Martin Schlemmer <azarah@gentoo.org> canonicalize.c, getcwd.c,
53 sandbox_futils.c, libsandbox.c:
54 Some strncpy/strncat and other cleanups.
55
56 * sandbox-1.2.9 (2005/06/09)
57
58 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
59 Move symlink hack down a bit to try and minimize on the amount of lstat()
60 calls we do.
61
62 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
63 Add hack to allow writing to /proc/self/fd (or /dev/fd), bug #91516.
64
65 09 June 2005; Martin Schlemmer <azarah@gentoo.org> symbols.in, libsandbox.c:
66 Add wrapper for access() function, bug #85413.
67
68 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c:
69 Use generic getcwd() implementation from uclibc - should be more portable
70 and looks a bit cleaner.
71
72 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c:
73 Make sure our true_* pointers are initialized to NULL, and that we check for
74 all references that they are valid.
75
76 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
77 Be default we will fail if the path name we try to canonicalize is too long.
78 This however could cause issues with some things (bug #94630 and #21766), so
79 if fail_nametoolong == 0, canonicalize() will return a null length string and
80 do not fail.
81
82 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c:
83 Do not abort if TMPDIR is not valid, but rather use '/tmp', bug #94360. Also
84 make sure we re-export the new TMPDIR environment variable.
85
86 08 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
87 Fix incorrect free of non-malloc'd array, bug #92313 and #94020. Fix noted
88 by Marcus D. Hanwell <cryos@gentoo.org>.
89
90 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
91 Add /dev/console to write list, bug #38588.
92
93 * sandbox-1.2.8 (2005/05/13)
94
95 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
96 sandbox.h, sandbox_futils.c:
97 General cleanups.
98
99 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
100 sandbox.h:
101 Various LD_PRELOAD cleanups. Do not unset LD_PRELOAD for parent.
102
103 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
104 sandbox.h, sandbox_futils.c:
105 Modify get_sandbox_pids_file(), get_sandbox_log() and get_sandbox_debug_log()
106 to use TMPDIR if present in environment.
107
108 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
109 Remove sandbox_log_file from main() as its no longer used.
110
111 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
112 sandbox_futils.c:
113 Add get_sandbox_debug_log(), and use it (add behaviour similar to SANDBOX_LOG
114 if already exported when sandbox started). Fix get_sandbox_log() and new
115 get_sandbox_debug_log() to not use already exported environment variables if
116 they have '/' in them. Use snprintf()'s instead of strncpy()'s. More
117 SB_PATH_MAX fixes.
118
119 * sandbox-1.2.7 (2005/05/12)
120
121 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
122 sandbox_futils.c:
123 More path limit fixes. Declare SB_BUF_LEN global and use it where needed.
124
125 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
126 Fix paths limited to 255 chars. Fix get_sandbox_dir() returning a string
127 with '(null)' in it if we did not call sandbox with absolute path.
128
129 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
130 Set SANDBOX_ON *before* doing the child's env stuff, else its not set
131 for the child.
132
133 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
134 Remove global preload_adaptable as it is no longer used.
135
136 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
137 Rewrite environment stuff to only be set when execve'ing the child process
138 to try and avoid issues like bug #91541 that causes sandbox to crash if
139 we set LD_PRELOAD sandbox side already.
140
141 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
142 Move print_sandbox_log() up to make things neater.
143
144 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
145 Remove load_preload_libs(), as its not used anymore.
146
147 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
148 Remove NO_FORK stuff, as its not used, and 'strace -f' works just fine.
149
150 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
151 Remove USE_SYSTEM_SHELL stuff, as it is not secure, and not in use.
152
153 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
154 Remove ld.so.preload crap - we are not going to use it again.
155
156 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
157 Fix typo in code that checks if we got valid group information, causing a
158 segmentation fault, bug #91637.
159
160 * sandbox-1.2.6 (2005/05/10)
161
162 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
163 Do not use LD_PRELOAD if it contains libtsocks.so, as it breaks sandbox
164 for some odd reason, bug #91541.
165
166 09 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
167 Fix typo (sizeof -> strlen).
168
169 08 May 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
170 rewrote the sbcontext caching code so it accounts for env changes since lib
171 initialization.
172
173 05 May 2005; Martin Schlemmer <azarah@gentoo.org> configure.in, libctest.c:
174 We create libctest.c via configure, so no need to keep it around. Do some
175 cleanup related to libctest.c and libctest during configure.
176
177 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
178 Add rename support of symlinks pointing to protected files/directories.
179
180 * sandbox-1.2.5 (2005/05/04)
181
182 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
183 sandbox.bashrc:
184 Do not reset already set LD_PRELOAD when starting sandbox. If LD_PRELOAD is
185 already set, init of the env vars fails for some reason, so do this later on,
186 and do not warn (bug #91431).
187
188 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
189 sandbox.bashrc:
190 Fixup sandbox and sandbox.bashrc to call bash with the proper .bashrc.
191
192 * sandbox-1.2.4 (2005/05/03)
193
194 03 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
195 Do not init the env entries with each call, as it creates too many calls to
196 lstat, etc. Should speedup things a bit, bug #91040.
197
198 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
199 Add /dev/pty to default write list. Noticed by Morfic.
200
201 02 May 2005; Mike Frysinger <vapier@gentoo.org> configure.in, localdecls.h,
202 sandbox.h:
203 uClibc doesn't support dlvsym() so add a configure check to make sure it doesn't
204 exist. Also update localdecls.h so BROKEN_RTLD_NEXT isn't defined in uClibc.
205
206 * sandbox-1.2.3 (2005/04/29)
207
208 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> configure.in:
209 Do not check for (*&#$(* CXX or F77.
210
211 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
212 Do not append '/' to pathname in filter_path() if it already ends with it.
213
214 28 Apr 2005; Mike Frysinger <vapier@gentoo.org> Makefile.am, configure.in:
215 With az's help, clean up autotools to work with cross-compiling.
216
217 * sandbox-1.2.2 (2005/04/28)
218
219 28 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
220 Only check for /dev/{null,zero} for unlink hack, else ricers using /dev/shm
221 have issues; bug #90592.
222
223 * sandbox-1.2.1 (2005/04/23)
224
225 23 Apr 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
226 getcwd.c, libsandbox.c, localdecls.h, sandbox.h, sandbox_futils.c:
227 Make sure all functions used in libsandbox.c is declared static. Define
228 SB_STATIC in localdecls.h for this. Include sandbox_futils.c rather than
229 linking with its object. Hopefully this will fix bug #90153.
230
231 * sandbox-1.2 (2005/04/23)
232
233 22 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
234 Allow lchown a symlink in write-allowed path pointing to write-denied
235 target.
236
237 21 Mar 2005; Marius Mauch <genone@gentoo.org> libsandbox.c:
238 Also show resolved symlink names in the log.
239
240 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, libsandbox.c:
241 Seems -nostdlib was the problem with the constructor/destructor - remove it
242 from Makefile.am, and change the constructor/destructor names again.
243
244 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
245 Also rename the _init() and _fini() declarations.
246
247 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
248 Fixup the constructor/destructor function names again (they should be _init()
249 and _fini() it seems, and not being called caused sandbox_lib_path to be
250 unset, and thus breaking the execve() wrapper's LD_PRELOAD protection).
251 Add both the path in given SANDBOX_x variable, as well as its symlink
252 resolved path in init_env_entries(). Modify filter_path() to be able to
253 resolve paths without resolving symlinks, as well as to be able to resolve
254 symlinks. Fix a possible segfault in check_access(). Add symlink resolving
255 to check_access() resolving bug #31019. Add 'hack' for unlink, as the fix
256 for bug #31019 cause access violations if we try to remove a symlink that is
257 not in protected path, but points to a protected path. Fix a memory leak in
258 sandbox.c (sandbox_pids_file in main()). Fix the realpath() calls in main()
259 (sandbox.c) being unchecked. Fix the debug logname not having the pid in it
260 (pid_string was uninitialized). General syntax cleanups.
261
262 09 Mar 2005; Brian Harring <ferringb@gentoo.org> sandbox.c: Fixed the
263 infamous "pids file is not a regular file" w/out newline bug.
264
265 09 Mar 2005; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in:
266 Correct libc_version path detection, since it was screwing up if libdir !=
267 "/lib/".
268
269 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
270 Hack to make sure sandboxed process cannot remove a device node, bug #79836.
271
272 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am:
273 Fix symbols.in not added to dist.
274
275 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
276 getcwd.c, libsandbox.c, sandbox.c, sandbox.h, sandbox_futils.c:
277 White space fixes.
278
279 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
280 configure.in, getcwd.c, libsandbox.c, symbols.in:
281 Fix inverse test logic in canonicalize.c, use a strncpy. Fix gcc warning in
282 getcwd.c. Add symbols.in and logic to Makefile.am to generate symbol versions
283 for glibc and other libc's that use this. Update libsandbox.c to use these
284 symbol versions if available. Fix exec wrapper to re-export LD_PRELOAD if the
285 process unset it.
286
287 01 Mar 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
288 killed off _init and _fini in favor of
289 void __attribute__ ((constructor)) init_func and
290 void __attribute__ ((destructor)) closing_func. _(init|func) were deprecated.
291
292 06 Dec 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, libsandbox.c,
293 canonicalize.c, getcwd.c: Fixed compilation *again*. Hopefully cvs is done
294 having the hick-ups.
295
296 04 Dec 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, getcwd.c,
297 Makefile.am: Fixed compilation.
298
299 01 Dec 2004; Brian Harring <ferringb@gentoo.org> aclocal.m4:
300 Gutted the bugger so it stops checking for a c++ and fortran compiler.
301 Do *not* regenerate aclocal.m4 for making a release until a better
302 solution is created.
303
304 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, sandbox_futils.c:
305 Removal of more hardcoded paths.
306
307 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in,
308 sandbox_futils.c: tweaks to install sandbox.bashrc, and use it.
309
310 19 Nov 2004; Brian Harring <ferringb@gentoo.org>:
311 Sandbox is now autotooled, create-localdecls needs to be killed and the code
312 shifted into configure.in. Currently builds *one* libsandbox.so- if multiple
313 are desired (-m64 and -m32 for amd64), the ebuild should do it (imo).
314 To get to a point of testing, automake && autoconf; created requisite files w/
315 a(utomake|clocal)-1.8, and autoconf 2.59. Installs to /usr/, instead of
316 /lib and /usr/lib/portage/bin.
317
318 14 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox.c:
319 closing out bug #70225, potential overflow of the sandbox_pids_file var.
320
321 07 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c: c99 standard,
322 (think it was at least) allows intermixing of code and data segments. bug #70351
323 should be fixed by this.
324
325 03 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox_futils.c:
326 futils fix from bug #65201 via solar, and libsandbox log path checks via #69137
327
328 02 Aug 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Code from
329 Seth Robertson that tracked down all adjuct flags for read operations that
330 do not invoke a write operation.
331
332 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
333 Another fix from jstubbs regarding a free() on a stack variable for the
334 environment -- tracking now prevents extraneous free()'s segfault.
335
336 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
337 J. Stubbs tracked down a new bug where mkdir was failing to the patch on
338 the lstat in mkdir... it now only returns 0 or -1 as documented for mkdir.
339 Also remove the errno = ESUCCESS settings as documentation points out that
340 a library isn't allowed to do that.
341
342 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Added a
343 file_security_check() function to check random potential exploits on files
344 that sandbox is to load and read -- Normally sandboxpids.tmp. This fixes
345 the 'system-crippling' exploits (bug 21923) and catches a few other
346 potential problems.
347
348 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> Makefile: Updates for
349 32/64 bit sandbox. Made CC and LD '?=' values to allow passed in CC to work.
350
351 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c:
352 bug 42048 -- Fixed the lstat/errno conditions for mkdir <caleb@g.o>.
353 Added the 64/32 bit sandbox patch for AMD64 bug 32963 <brad/azarah>.
354
355 29 Feb 2004; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c :
356 Fix permissions and group of pids file and logs. Permissions should be 0664
357 and group should be 'portage'. Bug #34260.
358
359 28 Feb 2004; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
360 Besides a small cleanup, redo how we replace LD_PRELOAD in the environ passed
361 to the real execve (in our execve wrapper). Seems that on some arches (sparc
362 among others) do not allow us to tamper with the readonly copy passed to
363 execve, so pass our own copy of the environment. Bug #42290.
364
365 11 Jan 2004; Nicholas Jones <carpaski@gentoo.org> create-decls:
366 Changed tail to head and added a notice about duration of glibc check.
367
368 21 Dec 2003; Nicholas Jones <carpaski@gentoo.org> create-decls:
369 Changed the glibc subversion check to use /usr/bin/* instead of /bin/sh
370 as there isn't a guarentee that it is dynamic.
371
372 02 Nov 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
373 If 'file' passed to before_syscall(const char *func, const char *file) is
374 invalid, we should set errno to ENOENT, and not EINVAL. This should
375 close bug #32238.
376
377 14 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
378 Fix a bug that occurs mainly on 64bit arch, where the file passed to
379 the functions we wrap, is invalid, and then cause canonicalize to pass
380 garbage to before_syscall(), thanks to great detective work from
381 Andrea Luzzardi <al@sig11.org> (bug #29846).
382
383 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
384 Add a uClibc detection patch from Peter S. Mazinger <ps.m@gmx.net>.
385
386 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
387 Fix a bug in libsandbox.c 's checking in the rename wrapper - it basically
388 only checked the destination patch, and not the source, so we could move
389 a protected file to a unprotected directory, and then delete/modify it.
390 Thanks to Andrea Luzzardi (scox) <al@sig11.org>, bug #30992, for this fix.
391
392 12 Oct 2003; Nicholas Jones <carpaski@gentoo.org> sandbox.c :
393 Added python2.3 to the predict section/variable.
394
395 28 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
396 sandbox.h, sandbox_futils.c :
397 Add support to set the pids file via SANDBOX_PIDS_FILE at startup. If
398 it is not set, it will revert to its old value.
399
400 27 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
401 Fix our mkdir wrapper to check if the dir exist, and return EEXIST if so,
402 rather than failing with a violation, bug #29748.
403
404 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
405 Fix canonicalize() to ignore calls with path = "".
406
407 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c,
408 sandbox_futils.c, canonicalize.c :
409 Once again coreutils fails, as my systems had 2.5 kernel, the getcwd system
410 call handled strings larger than PATH_MAX (bug #21766). It however does not
411 work the same on 2.4 kernels.
412
413 To fix, I added the posix implementation of getcwd() (from glibc cvs) that
414 do not need the system call. We use the default getcwd() function via a
415 wrapper (egetcwd), and then lstat the returned path. If lstat fails, it
416 means the current directory was removed, OR that the the system call for
417 getcwd failed (curious is that it do not fail and return NULL or set
418 errno, but rather just truncate the retured directory - usually from the
419 start), and if so, we use the generic getcwd() function (__egetcwd). Note
420 that we do not use the generic version all the time, as it calls lstat()
421 a great number of times, and performance degrade much.
422
423 29 Jun 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls,
424 libsandbox.c :
425 Make sure SB_PATH_MAX will not wrap. Fix two possible memory leaks.
426
427 22 Jun 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, canonicalize.c
428 create-localdecls :
429 When checking path names of files accessed, we need to canonicalize it, else
430 it may be a symlink in a 'write allowed' directory pointing to a file in a
431 directory we should not have write access to.
432
433 With something like coreutils-5.0, we have two problems:
434 1) One of the tests checks if getcwd() can return a path longer than
435 PATH_MAX. This test then tries to create a dir which even while
436 created local (mkdir("conftest2")), it ends up being resolved with
437 a name that is much larger than PATH_MAX. The problem now is that
438 canonicalize() have undefined behaviour when the path was too long
439 (returned wrongly truncated paths, etc), and pass the wrong path to
440 before_syscall() (causing the bogus sandbox violations).
441 2) The ecanonicalize() function we used, along with the canonicalize()
442 function did not support longer than PATH_MAX. This is partly a
443 cause for 1), but the error checking (rather lack of it) of calls
444 to erealpath() in canonicalize() was the prime reason for 1).
445
446 As we do not use this canonicalized name to call the function, we resolve this
447 by fixing canonicalize() to do better error checking, and ecanonicalize() as
448 well as all functions in libsandbox.c to use a PATH_MAX of 'PATH_MAX * 2'.
449 While they will resolve paths properly now, and can check if a write/read is
450 allowed, the functions called from the sandboxed environment will still work
451 as expected.
452
453 This should resolve bug #21766.
454
455 06 Apr 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
456 For some reason sandbox fails with a 'open_wr' if you run 'locale -a' under
457 it (bug #16298).
458
459 Problem is that for some reason locale fopen's locale.alias with mode "rm".
460
461 -------------------------------------------------------
462 nosferatu root # grep fopen locale.log
463 fopen("/usr/share/locale/locale.alias", "rm"ACCESS DENIED open_wr: /usr/share/locale/locale.alias
464 nosferatu root #
465 --------------------------------------------------------
466
467 I checked the source of locale, but it have fopen with mode 'r', so
468 not sure where the "rm" mode comes from. Anyhow, changed the check in
469 before_syscall_open_char() to also see mode "rm" as readonly.
470
471 23 Feb 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
472
473 Add glibc-2.3 support.
474
475 22 Feb 2003; Martin Schlemmer <azarah@gentoo.org> sandbox.c :
476
477 Some /etc/ld.so.preload fixes. Just changed the #if defines to cover all
478 operations releated to preload, as well as only try to modify ld.so.preload
479 if we can. Also modify to write the pid to /tmp/sandboxpids.tmp even when
480 not using ld.so.preload. Fix to not write this instance of sandbox's pid
481 to /tmp/sandboxpids.tmp on exit if this is not the last sandbox running.
482
483 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> Makefile :
484
485 Changed the LD to CC for hppa.
486
487 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
488
489 Killed the previous changes I made.
490
491 17 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
492
493 Added parisc to BROKEN_RTLD_ARCHLIST to see if it we can fix the relocation probs.
494
495 09 Jan 2003; J Robert Ray <jrray@gentoo.org> sandbox.c :
496
497 Don't segfault if $HOME isn't set, set $HOME to "/" instead. Fixes bug 10868.
498
499 16 Dec 2002; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
500
501 Fix memory leak for mips, bug #12236. Thanks to Torgeir Hansen <torgeir@trenger.ro>
502 for this fix.
503
504 4 Dec 2002; J Robert Ray <jrray@gentoo.org> sandbox.h sandbox_futils.c :
505
506 sandbox_futils defined a dirname() function that was masking the same
507 function in glibc and was broken (e.g.: SANDBOX_DIR was being set to
508 '/usr/lib/portage/bi/'). Fixed function to return expected results and
509 renamed it to sb_dirname() to no longer mask the glibc function. Closes bug
510 11231.
511
512 4 Dec 2002; Martin Schlemmer <azarah@gentoo.org> :
513
514 Fix a segfault in libsandbox.c if canonicalize() was called with
515 first parameter = NULL.
516
517 1 Sep 2002; Martin Schlemmer <azarah@gentoo.org> :
518
519 Fix my braindead 'return 1;' in a void function. Updated sandbox.c,
520 cleanup() for this.
521
522 Change cleanup() in sandbox.c not to exit with fail status if
523 the pidsfile is missing. We really should still display sandbox
524 violations if they occured.
525
526 31 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
527
528 Update cleanup() in sandbox.c to remove the PIDSFILE if this is
529 the last sandbox running.
530
531 25 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
532
533 Major cleanups to mainly libsandbox.c again.
534
535 22 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
536
537 Add copyrights to sandbox.h and sandbox_futils.h. If wrong, the
538 parties involved should please contact me so that we can fix it.
539
540 Add opendir wrapper to libsandbox.c.
541
542 21 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
543
544 Do some more cleanups to ecanonicalize(), as it dropped filenames in
545 rare cases (after my symlink cleanups), and caused glibc to bork.
546 These fixes went into canonicalize.c.
547
548 20 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
549
550 Fix spawn_shell() and main() in sandbox.c to properly return fail
551 status.
552
553 19 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
554
555 The new canonicalize() function in libsandbox.c also resolved symlinks,
556 which caused on cleaning sandbox errors if the symlink pointed to a
557 file in the live root. Ripped out canonicalize() and realpath() from
558 glibc; removed the symlink stuff, and changed them to ecanonicalize()
559 and erealpath().
560
561 18 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
562
563 Ripped out all the wrappers, and implemented those of InstallWatch.
564 Losts of cleanups and bugfixes. Implement a execve that forces
565 $LIBSANDBOX in $LD_PRELOAD. We can now thus do away with the feared
566 /etc/ld.so.preload (*g*) ... Made the needed changes to sandbox.c,
567 sandbox.h and sandbox_futils.c. Rewrote the Makefile for most
568 parts; it now have an install target.
569
570 Reformat the whole thing to look somewhat like the reworked sandbox.c
571 and new sandbox.h and sandbox_futils.c from:
572
573 Brad House <brad@mainstreetsoftworks.com>.
574
575 Additional Copyrights now due to the InstallWatch code:
576
577 Copyright (C) 1998-9 Pancrazio `Ezio' de Mauro <p@demauro.net>

Properties

Name Value
svn:eol-style native
svn:keywords Author Date Id Revision

  ViewVC Help
Powered by ViewVC 1.1.20