/[path-sandbox]/trunk/ChangeLog
Gentoo

Contents of /trunk/ChangeLog

Parent Directory Parent Directory | Revision Log Revision Log


Revision 141 - (show annotations) (download)
Thu Jul 7 22:08:17 2005 UTC (9 years, 1 month ago) by azarah
File size: 26430 byte(s)
Remove sandbox_dir and co - we are not using it anymore.
1 # ChangeLog for Path Sandbox
2 # Copyright 1999-2005 Gentoo Foundation; Distributed under the GPL v2
3 # $Header$
4
5 07 July 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
6 sandbox.h, sandbox_futils.c:
7 - Fix possible segfault in env init code.
8 - Major cleanup of sandbox_futils.c. Removed most of the functions as we now
9 write to /var/log/sandbox/, so in theory do not need all that.
10 - Redo the interface of the get_* functions so that we do not leak memory.
11 - Remove sandbox_dir and co - we are not using it anymore.
12
13 06 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.h, sandbox_futils.c,
14 libsandbox.c:
15 - Change log dir to /var/log/sandbox/. Make sure the sandboxed process cannot
16 write to it.
17 - Clean up logging in libsandbox.c, and hopefully make it more consistant.
18 - Add check_prefixes() with major cleanup on check_access().
19 - Cleanup init_env_entries() and check_prefixes().
20
21 05 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
22 sandbox_futils.c, libsandbox.c:
23 Remove unused 'pids file' code.
24
25 * sandbox-1.2.10 (2005/07/03)
26
27 03 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
28 Add PREDICT items for nss-db, bug #92079. Patch from Robin Johnson.
29
30 17 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
31 General cleanups:
32 - Remove fooling around with exit codes - we error out on presence of a log
33 anyhow.
34 - Move get_sandbox_*_envvar() to sandbox_setup_environ(), as its more
35 appropriate there.
36
37 12 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
38 Cleanup the fail_nametoolong stuff a bit more.
39
40 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
41 Remove hopefully the last ld.so.preload bits we do not use anymore.
42
43 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
44 Remove the unneeded canonicalize() calls in the wrappers - we do it anyhow
45 in check_syscall(). Should speed things up a bit (at least for the getcwd()
46 and long path name test it goes down to under a second, and not 10+ seconds
47 like before). Also warn if we skip checking due to the canonicalized path
48 being too long.
49
50 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
51 More comment/readability cleanups.
52
53 10 June 2005; Martin Schlemmer <azarah@gentoo.org> canonicalize.c, getcwd.c,
54 sandbox_futils.c, libsandbox.c:
55 Some strncpy/strncat and other cleanups.
56
57 * sandbox-1.2.9 (2005/06/09)
58
59 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
60 Move symlink hack down a bit to try and minimize on the amount of lstat()
61 calls we do.
62
63 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
64 Add hack to allow writing to /proc/self/fd (or /dev/fd), bug #91516.
65
66 09 June 2005; Martin Schlemmer <azarah@gentoo.org> symbols.in, libsandbox.c:
67 Add wrapper for access() function, bug #85413.
68
69 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c:
70 Use generic getcwd() implementation from uclibc - should be more portable
71 and looks a bit cleaner.
72
73 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c:
74 Make sure our true_* pointers are initialized to NULL, and that we check for
75 all references that they are valid.
76
77 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
78 Be default we will fail if the path name we try to canonicalize is too long.
79 This however could cause issues with some things (bug #94630 and #21766), so
80 if fail_nametoolong == 0, canonicalize() will return a null length string and
81 do not fail.
82
83 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c:
84 Do not abort if TMPDIR is not valid, but rather use '/tmp', bug #94360. Also
85 make sure we re-export the new TMPDIR environment variable.
86
87 08 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
88 Fix incorrect free of non-malloc'd array, bug #92313 and #94020. Fix noted
89 by Marcus D. Hanwell <cryos@gentoo.org>.
90
91 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
92 Add /dev/console to write list, bug #38588.
93
94 * sandbox-1.2.8 (2005/05/13)
95
96 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
97 sandbox.h, sandbox_futils.c:
98 General cleanups.
99
100 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
101 sandbox.h:
102 Various LD_PRELOAD cleanups. Do not unset LD_PRELOAD for parent.
103
104 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
105 sandbox.h, sandbox_futils.c:
106 Modify get_sandbox_pids_file(), get_sandbox_log() and get_sandbox_debug_log()
107 to use TMPDIR if present in environment.
108
109 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
110 Remove sandbox_log_file from main() as its no longer used.
111
112 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
113 sandbox_futils.c:
114 Add get_sandbox_debug_log(), and use it (add behaviour similar to SANDBOX_LOG
115 if already exported when sandbox started). Fix get_sandbox_log() and new
116 get_sandbox_debug_log() to not use already exported environment variables if
117 they have '/' in them. Use snprintf()'s instead of strncpy()'s. More
118 SB_PATH_MAX fixes.
119
120 * sandbox-1.2.7 (2005/05/12)
121
122 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
123 sandbox_futils.c:
124 More path limit fixes. Declare SB_BUF_LEN global and use it where needed.
125
126 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
127 Fix paths limited to 255 chars. Fix get_sandbox_dir() returning a string
128 with '(null)' in it if we did not call sandbox with absolute path.
129
130 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
131 Set SANDBOX_ON *before* doing the child's env stuff, else its not set
132 for the child.
133
134 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
135 Remove global preload_adaptable as it is no longer used.
136
137 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
138 Rewrite environment stuff to only be set when execve'ing the child process
139 to try and avoid issues like bug #91541 that causes sandbox to crash if
140 we set LD_PRELOAD sandbox side already.
141
142 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
143 Move print_sandbox_log() up to make things neater.
144
145 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
146 Remove load_preload_libs(), as its not used anymore.
147
148 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
149 Remove NO_FORK stuff, as its not used, and 'strace -f' works just fine.
150
151 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
152 Remove USE_SYSTEM_SHELL stuff, as it is not secure, and not in use.
153
154 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
155 Remove ld.so.preload crap - we are not going to use it again.
156
157 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
158 Fix typo in code that checks if we got valid group information, causing a
159 segmentation fault, bug #91637.
160
161 * sandbox-1.2.6 (2005/05/10)
162
163 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
164 Do not use LD_PRELOAD if it contains libtsocks.so, as it breaks sandbox
165 for some odd reason, bug #91541.
166
167 09 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
168 Fix typo (sizeof -> strlen).
169
170 08 May 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
171 rewrote the sbcontext caching code so it accounts for env changes since lib
172 initialization.
173
174 05 May 2005; Martin Schlemmer <azarah@gentoo.org> configure.in, libctest.c:
175 We create libctest.c via configure, so no need to keep it around. Do some
176 cleanup related to libctest.c and libctest during configure.
177
178 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
179 Add rename support of symlinks pointing to protected files/directories.
180
181 * sandbox-1.2.5 (2005/05/04)
182
183 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
184 sandbox.bashrc:
185 Do not reset already set LD_PRELOAD when starting sandbox. If LD_PRELOAD is
186 already set, init of the env vars fails for some reason, so do this later on,
187 and do not warn (bug #91431).
188
189 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
190 sandbox.bashrc:
191 Fixup sandbox and sandbox.bashrc to call bash with the proper .bashrc.
192
193 * sandbox-1.2.4 (2005/05/03)
194
195 03 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
196 Do not init the env entries with each call, as it creates too many calls to
197 lstat, etc. Should speedup things a bit, bug #91040.
198
199 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
200 Add /dev/pty to default write list. Noticed by Morfic.
201
202 02 May 2005; Mike Frysinger <vapier@gentoo.org> configure.in, localdecls.h,
203 sandbox.h:
204 uClibc doesn't support dlvsym() so add a configure check to make sure it doesn't
205 exist. Also update localdecls.h so BROKEN_RTLD_NEXT isn't defined in uClibc.
206
207 * sandbox-1.2.3 (2005/04/29)
208
209 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> configure.in:
210 Do not check for (*&#$(* CXX or F77.
211
212 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
213 Do not append '/' to pathname in filter_path() if it already ends with it.
214
215 28 Apr 2005; Mike Frysinger <vapier@gentoo.org> Makefile.am, configure.in:
216 With az's help, clean up autotools to work with cross-compiling.
217
218 * sandbox-1.2.2 (2005/04/28)
219
220 28 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
221 Only check for /dev/{null,zero} for unlink hack, else ricers using /dev/shm
222 have issues; bug #90592.
223
224 * sandbox-1.2.1 (2005/04/23)
225
226 23 Apr 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
227 getcwd.c, libsandbox.c, localdecls.h, sandbox.h, sandbox_futils.c:
228 Make sure all functions used in libsandbox.c is declared static. Define
229 SB_STATIC in localdecls.h for this. Include sandbox_futils.c rather than
230 linking with its object. Hopefully this will fix bug #90153.
231
232 * sandbox-1.2 (2005/04/23)
233
234 22 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
235 Allow lchown a symlink in write-allowed path pointing to write-denied
236 target.
237
238 21 Mar 2005; Marius Mauch <genone@gentoo.org> libsandbox.c:
239 Also show resolved symlink names in the log.
240
241 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, libsandbox.c:
242 Seems -nostdlib was the problem with the constructor/destructor - remove it
243 from Makefile.am, and change the constructor/destructor names again.
244
245 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
246 Also rename the _init() and _fini() declarations.
247
248 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
249 Fixup the constructor/destructor function names again (they should be _init()
250 and _fini() it seems, and not being called caused sandbox_lib_path to be
251 unset, and thus breaking the execve() wrapper's LD_PRELOAD protection).
252 Add both the path in given SANDBOX_x variable, as well as its symlink
253 resolved path in init_env_entries(). Modify filter_path() to be able to
254 resolve paths without resolving symlinks, as well as to be able to resolve
255 symlinks. Fix a possible segfault in check_access(). Add symlink resolving
256 to check_access() resolving bug #31019. Add 'hack' for unlink, as the fix
257 for bug #31019 cause access violations if we try to remove a symlink that is
258 not in protected path, but points to a protected path. Fix a memory leak in
259 sandbox.c (sandbox_pids_file in main()). Fix the realpath() calls in main()
260 (sandbox.c) being unchecked. Fix the debug logname not having the pid in it
261 (pid_string was uninitialized). General syntax cleanups.
262
263 09 Mar 2005; Brian Harring <ferringb@gentoo.org> sandbox.c: Fixed the
264 infamous "pids file is not a regular file" w/out newline bug.
265
266 09 Mar 2005; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in:
267 Correct libc_version path detection, since it was screwing up if libdir !=
268 "/lib/".
269
270 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
271 Hack to make sure sandboxed process cannot remove a device node, bug #79836.
272
273 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am:
274 Fix symbols.in not added to dist.
275
276 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
277 getcwd.c, libsandbox.c, sandbox.c, sandbox.h, sandbox_futils.c:
278 White space fixes.
279
280 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
281 configure.in, getcwd.c, libsandbox.c, symbols.in:
282 Fix inverse test logic in canonicalize.c, use a strncpy. Fix gcc warning in
283 getcwd.c. Add symbols.in and logic to Makefile.am to generate symbol versions
284 for glibc and other libc's that use this. Update libsandbox.c to use these
285 symbol versions if available. Fix exec wrapper to re-export LD_PRELOAD if the
286 process unset it.
287
288 01 Mar 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
289 killed off _init and _fini in favor of
290 void __attribute__ ((constructor)) init_func and
291 void __attribute__ ((destructor)) closing_func. _(init|func) were deprecated.
292
293 06 Dec 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, libsandbox.c,
294 canonicalize.c, getcwd.c: Fixed compilation *again*. Hopefully cvs is done
295 having the hick-ups.
296
297 04 Dec 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, getcwd.c,
298 Makefile.am: Fixed compilation.
299
300 01 Dec 2004; Brian Harring <ferringb@gentoo.org> aclocal.m4:
301 Gutted the bugger so it stops checking for a c++ and fortran compiler.
302 Do *not* regenerate aclocal.m4 for making a release until a better
303 solution is created.
304
305 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, sandbox_futils.c:
306 Removal of more hardcoded paths.
307
308 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in,
309 sandbox_futils.c: tweaks to install sandbox.bashrc, and use it.
310
311 19 Nov 2004; Brian Harring <ferringb@gentoo.org>:
312 Sandbox is now autotooled, create-localdecls needs to be killed and the code
313 shifted into configure.in. Currently builds *one* libsandbox.so- if multiple
314 are desired (-m64 and -m32 for amd64), the ebuild should do it (imo).
315 To get to a point of testing, automake && autoconf; created requisite files w/
316 a(utomake|clocal)-1.8, and autoconf 2.59. Installs to /usr/, instead of
317 /lib and /usr/lib/portage/bin.
318
319 14 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox.c:
320 closing out bug #70225, potential overflow of the sandbox_pids_file var.
321
322 07 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c: c99 standard,
323 (think it was at least) allows intermixing of code and data segments. bug #70351
324 should be fixed by this.
325
326 03 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox_futils.c:
327 futils fix from bug #65201 via solar, and libsandbox log path checks via #69137
328
329 02 Aug 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Code from
330 Seth Robertson that tracked down all adjuct flags for read operations that
331 do not invoke a write operation.
332
333 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
334 Another fix from jstubbs regarding a free() on a stack variable for the
335 environment -- tracking now prevents extraneous free()'s segfault.
336
337 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
338 J. Stubbs tracked down a new bug where mkdir was failing to the patch on
339 the lstat in mkdir... it now only returns 0 or -1 as documented for mkdir.
340 Also remove the errno = ESUCCESS settings as documentation points out that
341 a library isn't allowed to do that.
342
343 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Added a
344 file_security_check() function to check random potential exploits on files
345 that sandbox is to load and read -- Normally sandboxpids.tmp. This fixes
346 the 'system-crippling' exploits (bug 21923) and catches a few other
347 potential problems.
348
349 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> Makefile: Updates for
350 32/64 bit sandbox. Made CC and LD '?=' values to allow passed in CC to work.
351
352 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c:
353 bug 42048 -- Fixed the lstat/errno conditions for mkdir <caleb@g.o>.
354 Added the 64/32 bit sandbox patch for AMD64 bug 32963 <brad/azarah>.
355
356 29 Feb 2004; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c :
357 Fix permissions and group of pids file and logs. Permissions should be 0664
358 and group should be 'portage'. Bug #34260.
359
360 28 Feb 2004; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
361 Besides a small cleanup, redo how we replace LD_PRELOAD in the environ passed
362 to the real execve (in our execve wrapper). Seems that on some arches (sparc
363 among others) do not allow us to tamper with the readonly copy passed to
364 execve, so pass our own copy of the environment. Bug #42290.
365
366 11 Jan 2004; Nicholas Jones <carpaski@gentoo.org> create-decls:
367 Changed tail to head and added a notice about duration of glibc check.
368
369 21 Dec 2003; Nicholas Jones <carpaski@gentoo.org> create-decls:
370 Changed the glibc subversion check to use /usr/bin/* instead of /bin/sh
371 as there isn't a guarentee that it is dynamic.
372
373 02 Nov 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
374 If 'file' passed to before_syscall(const char *func, const char *file) is
375 invalid, we should set errno to ENOENT, and not EINVAL. This should
376 close bug #32238.
377
378 14 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
379 Fix a bug that occurs mainly on 64bit arch, where the file passed to
380 the functions we wrap, is invalid, and then cause canonicalize to pass
381 garbage to before_syscall(), thanks to great detective work from
382 Andrea Luzzardi <al@sig11.org> (bug #29846).
383
384 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
385 Add a uClibc detection patch from Peter S. Mazinger <ps.m@gmx.net>.
386
387 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
388 Fix a bug in libsandbox.c 's checking in the rename wrapper - it basically
389 only checked the destination patch, and not the source, so we could move
390 a protected file to a unprotected directory, and then delete/modify it.
391 Thanks to Andrea Luzzardi (scox) <al@sig11.org>, bug #30992, for this fix.
392
393 12 Oct 2003; Nicholas Jones <carpaski@gentoo.org> sandbox.c :
394 Added python2.3 to the predict section/variable.
395
396 28 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
397 sandbox.h, sandbox_futils.c :
398 Add support to set the pids file via SANDBOX_PIDS_FILE at startup. If
399 it is not set, it will revert to its old value.
400
401 27 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
402 Fix our mkdir wrapper to check if the dir exist, and return EEXIST if so,
403 rather than failing with a violation, bug #29748.
404
405 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
406 Fix canonicalize() to ignore calls with path = "".
407
408 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c,
409 sandbox_futils.c, canonicalize.c :
410 Once again coreutils fails, as my systems had 2.5 kernel, the getcwd system
411 call handled strings larger than PATH_MAX (bug #21766). It however does not
412 work the same on 2.4 kernels.
413
414 To fix, I added the posix implementation of getcwd() (from glibc cvs) that
415 do not need the system call. We use the default getcwd() function via a
416 wrapper (egetcwd), and then lstat the returned path. If lstat fails, it
417 means the current directory was removed, OR that the the system call for
418 getcwd failed (curious is that it do not fail and return NULL or set
419 errno, but rather just truncate the retured directory - usually from the
420 start), and if so, we use the generic getcwd() function (__egetcwd). Note
421 that we do not use the generic version all the time, as it calls lstat()
422 a great number of times, and performance degrade much.
423
424 29 Jun 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls,
425 libsandbox.c :
426 Make sure SB_PATH_MAX will not wrap. Fix two possible memory leaks.
427
428 22 Jun 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, canonicalize.c
429 create-localdecls :
430 When checking path names of files accessed, we need to canonicalize it, else
431 it may be a symlink in a 'write allowed' directory pointing to a file in a
432 directory we should not have write access to.
433
434 With something like coreutils-5.0, we have two problems:
435 1) One of the tests checks if getcwd() can return a path longer than
436 PATH_MAX. This test then tries to create a dir which even while
437 created local (mkdir("conftest2")), it ends up being resolved with
438 a name that is much larger than PATH_MAX. The problem now is that
439 canonicalize() have undefined behaviour when the path was too long
440 (returned wrongly truncated paths, etc), and pass the wrong path to
441 before_syscall() (causing the bogus sandbox violations).
442 2) The ecanonicalize() function we used, along with the canonicalize()
443 function did not support longer than PATH_MAX. This is partly a
444 cause for 1), but the error checking (rather lack of it) of calls
445 to erealpath() in canonicalize() was the prime reason for 1).
446
447 As we do not use this canonicalized name to call the function, we resolve this
448 by fixing canonicalize() to do better error checking, and ecanonicalize() as
449 well as all functions in libsandbox.c to use a PATH_MAX of 'PATH_MAX * 2'.
450 While they will resolve paths properly now, and can check if a write/read is
451 allowed, the functions called from the sandboxed environment will still work
452 as expected.
453
454 This should resolve bug #21766.
455
456 06 Apr 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
457 For some reason sandbox fails with a 'open_wr' if you run 'locale -a' under
458 it (bug #16298).
459
460 Problem is that for some reason locale fopen's locale.alias with mode "rm".
461
462 -------------------------------------------------------
463 nosferatu root # grep fopen locale.log
464 fopen("/usr/share/locale/locale.alias", "rm"ACCESS DENIED open_wr: /usr/share/locale/locale.alias
465 nosferatu root #
466 --------------------------------------------------------
467
468 I checked the source of locale, but it have fopen with mode 'r', so
469 not sure where the "rm" mode comes from. Anyhow, changed the check in
470 before_syscall_open_char() to also see mode "rm" as readonly.
471
472 23 Feb 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
473
474 Add glibc-2.3 support.
475
476 22 Feb 2003; Martin Schlemmer <azarah@gentoo.org> sandbox.c :
477
478 Some /etc/ld.so.preload fixes. Just changed the #if defines to cover all
479 operations releated to preload, as well as only try to modify ld.so.preload
480 if we can. Also modify to write the pid to /tmp/sandboxpids.tmp even when
481 not using ld.so.preload. Fix to not write this instance of sandbox's pid
482 to /tmp/sandboxpids.tmp on exit if this is not the last sandbox running.
483
484 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> Makefile :
485
486 Changed the LD to CC for hppa.
487
488 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
489
490 Killed the previous changes I made.
491
492 17 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
493
494 Added parisc to BROKEN_RTLD_ARCHLIST to see if it we can fix the relocation probs.
495
496 09 Jan 2003; J Robert Ray <jrray@gentoo.org> sandbox.c :
497
498 Don't segfault if $HOME isn't set, set $HOME to "/" instead. Fixes bug 10868.
499
500 16 Dec 2002; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
501
502 Fix memory leak for mips, bug #12236. Thanks to Torgeir Hansen <torgeir@trenger.ro>
503 for this fix.
504
505 4 Dec 2002; J Robert Ray <jrray@gentoo.org> sandbox.h sandbox_futils.c :
506
507 sandbox_futils defined a dirname() function that was masking the same
508 function in glibc and was broken (e.g.: SANDBOX_DIR was being set to
509 '/usr/lib/portage/bi/'). Fixed function to return expected results and
510 renamed it to sb_dirname() to no longer mask the glibc function. Closes bug
511 11231.
512
513 4 Dec 2002; Martin Schlemmer <azarah@gentoo.org> :
514
515 Fix a segfault in libsandbox.c if canonicalize() was called with
516 first parameter = NULL.
517
518 1 Sep 2002; Martin Schlemmer <azarah@gentoo.org> :
519
520 Fix my braindead 'return 1;' in a void function. Updated sandbox.c,
521 cleanup() for this.
522
523 Change cleanup() in sandbox.c not to exit with fail status if
524 the pidsfile is missing. We really should still display sandbox
525 violations if they occured.
526
527 31 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
528
529 Update cleanup() in sandbox.c to remove the PIDSFILE if this is
530 the last sandbox running.
531
532 25 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
533
534 Major cleanups to mainly libsandbox.c again.
535
536 22 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
537
538 Add copyrights to sandbox.h and sandbox_futils.h. If wrong, the
539 parties involved should please contact me so that we can fix it.
540
541 Add opendir wrapper to libsandbox.c.
542
543 21 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
544
545 Do some more cleanups to ecanonicalize(), as it dropped filenames in
546 rare cases (after my symlink cleanups), and caused glibc to bork.
547 These fixes went into canonicalize.c.
548
549 20 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
550
551 Fix spawn_shell() and main() in sandbox.c to properly return fail
552 status.
553
554 19 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
555
556 The new canonicalize() function in libsandbox.c also resolved symlinks,
557 which caused on cleaning sandbox errors if the symlink pointed to a
558 file in the live root. Ripped out canonicalize() and realpath() from
559 glibc; removed the symlink stuff, and changed them to ecanonicalize()
560 and erealpath().
561
562 18 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
563
564 Ripped out all the wrappers, and implemented those of InstallWatch.
565 Losts of cleanups and bugfixes. Implement a execve that forces
566 $LIBSANDBOX in $LD_PRELOAD. We can now thus do away with the feared
567 /etc/ld.so.preload (*g*) ... Made the needed changes to sandbox.c,
568 sandbox.h and sandbox_futils.c. Rewrote the Makefile for most
569 parts; it now have an install target.
570
571 Reformat the whole thing to look somewhat like the reworked sandbox.c
572 and new sandbox.h and sandbox_futils.c from:
573
574 Brad House <brad@mainstreetsoftworks.com>.
575
576 Additional Copyrights now due to the InstallWatch code:
577
578 Copyright (C) 1998-9 Pancrazio `Ezio' de Mauro <p@demauro.net>

Properties

Name Value
svn:eol-style native
svn:keywords Author Date Id Revision

  ViewVC Help
Powered by ViewVC 1.1.20