/[path-sandbox]/trunk/ChangeLog
Gentoo

Contents of /trunk/ChangeLog

Parent Directory Parent Directory | Revision Log Revision Log


Revision 142 - (show annotations) (download)
Thu Jul 7 22:14:57 2005 UTC (8 years, 9 months ago) by azarah
File size: 26472 byte(s)
Remove unused includes and variables.
1 # ChangeLog for Path Sandbox
2 # Copyright 1999-2005 Gentoo Foundation; Distributed under the GPL v2
3 # $Header$
4
5 07 July 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
6 sandbox.h, sandbox_futils.c:
7 - Fix possible segfault in env init code.
8 - Major cleanup of sandbox_futils.c. Removed most of the functions as we now
9 write to /var/log/sandbox/, so in theory do not need all that.
10 - Redo the interface of the get_* functions so that we do not leak memory.
11 - Remove sandbox_dir and co - we are not using it anymore.
12 - Remove unused includes and variables.
13
14 06 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.h, sandbox_futils.c,
15 libsandbox.c:
16 - Change log dir to /var/log/sandbox/. Make sure the sandboxed process cannot
17 write to it.
18 - Clean up logging in libsandbox.c, and hopefully make it more consistant.
19 - Add check_prefixes() with major cleanup on check_access().
20 - Cleanup init_env_entries() and check_prefixes().
21
22 05 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
23 sandbox_futils.c, libsandbox.c:
24 Remove unused 'pids file' code.
25
26 * sandbox-1.2.10 (2005/07/03)
27
28 03 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
29 Add PREDICT items for nss-db, bug #92079. Patch from Robin Johnson.
30
31 17 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
32 General cleanups:
33 - Remove fooling around with exit codes - we error out on presence of a log
34 anyhow.
35 - Move get_sandbox_*_envvar() to sandbox_setup_environ(), as its more
36 appropriate there.
37
38 12 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
39 Cleanup the fail_nametoolong stuff a bit more.
40
41 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
42 Remove hopefully the last ld.so.preload bits we do not use anymore.
43
44 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
45 Remove the unneeded canonicalize() calls in the wrappers - we do it anyhow
46 in check_syscall(). Should speed things up a bit (at least for the getcwd()
47 and long path name test it goes down to under a second, and not 10+ seconds
48 like before). Also warn if we skip checking due to the canonicalized path
49 being too long.
50
51 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
52 More comment/readability cleanups.
53
54 10 June 2005; Martin Schlemmer <azarah@gentoo.org> canonicalize.c, getcwd.c,
55 sandbox_futils.c, libsandbox.c:
56 Some strncpy/strncat and other cleanups.
57
58 * sandbox-1.2.9 (2005/06/09)
59
60 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
61 Move symlink hack down a bit to try and minimize on the amount of lstat()
62 calls we do.
63
64 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
65 Add hack to allow writing to /proc/self/fd (or /dev/fd), bug #91516.
66
67 09 June 2005; Martin Schlemmer <azarah@gentoo.org> symbols.in, libsandbox.c:
68 Add wrapper for access() function, bug #85413.
69
70 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c:
71 Use generic getcwd() implementation from uclibc - should be more portable
72 and looks a bit cleaner.
73
74 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c:
75 Make sure our true_* pointers are initialized to NULL, and that we check for
76 all references that they are valid.
77
78 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
79 Be default we will fail if the path name we try to canonicalize is too long.
80 This however could cause issues with some things (bug #94630 and #21766), so
81 if fail_nametoolong == 0, canonicalize() will return a null length string and
82 do not fail.
83
84 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c:
85 Do not abort if TMPDIR is not valid, but rather use '/tmp', bug #94360. Also
86 make sure we re-export the new TMPDIR environment variable.
87
88 08 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
89 Fix incorrect free of non-malloc'd array, bug #92313 and #94020. Fix noted
90 by Marcus D. Hanwell <cryos@gentoo.org>.
91
92 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
93 Add /dev/console to write list, bug #38588.
94
95 * sandbox-1.2.8 (2005/05/13)
96
97 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
98 sandbox.h, sandbox_futils.c:
99 General cleanups.
100
101 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
102 sandbox.h:
103 Various LD_PRELOAD cleanups. Do not unset LD_PRELOAD for parent.
104
105 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
106 sandbox.h, sandbox_futils.c:
107 Modify get_sandbox_pids_file(), get_sandbox_log() and get_sandbox_debug_log()
108 to use TMPDIR if present in environment.
109
110 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
111 Remove sandbox_log_file from main() as its no longer used.
112
113 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
114 sandbox_futils.c:
115 Add get_sandbox_debug_log(), and use it (add behaviour similar to SANDBOX_LOG
116 if already exported when sandbox started). Fix get_sandbox_log() and new
117 get_sandbox_debug_log() to not use already exported environment variables if
118 they have '/' in them. Use snprintf()'s instead of strncpy()'s. More
119 SB_PATH_MAX fixes.
120
121 * sandbox-1.2.7 (2005/05/12)
122
123 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
124 sandbox_futils.c:
125 More path limit fixes. Declare SB_BUF_LEN global and use it where needed.
126
127 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
128 Fix paths limited to 255 chars. Fix get_sandbox_dir() returning a string
129 with '(null)' in it if we did not call sandbox with absolute path.
130
131 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
132 Set SANDBOX_ON *before* doing the child's env stuff, else its not set
133 for the child.
134
135 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
136 Remove global preload_adaptable as it is no longer used.
137
138 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
139 Rewrite environment stuff to only be set when execve'ing the child process
140 to try and avoid issues like bug #91541 that causes sandbox to crash if
141 we set LD_PRELOAD sandbox side already.
142
143 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
144 Move print_sandbox_log() up to make things neater.
145
146 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
147 Remove load_preload_libs(), as its not used anymore.
148
149 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
150 Remove NO_FORK stuff, as its not used, and 'strace -f' works just fine.
151
152 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
153 Remove USE_SYSTEM_SHELL stuff, as it is not secure, and not in use.
154
155 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
156 Remove ld.so.preload crap - we are not going to use it again.
157
158 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
159 Fix typo in code that checks if we got valid group information, causing a
160 segmentation fault, bug #91637.
161
162 * sandbox-1.2.6 (2005/05/10)
163
164 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
165 Do not use LD_PRELOAD if it contains libtsocks.so, as it breaks sandbox
166 for some odd reason, bug #91541.
167
168 09 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
169 Fix typo (sizeof -> strlen).
170
171 08 May 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
172 rewrote the sbcontext caching code so it accounts for env changes since lib
173 initialization.
174
175 05 May 2005; Martin Schlemmer <azarah@gentoo.org> configure.in, libctest.c:
176 We create libctest.c via configure, so no need to keep it around. Do some
177 cleanup related to libctest.c and libctest during configure.
178
179 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
180 Add rename support of symlinks pointing to protected files/directories.
181
182 * sandbox-1.2.5 (2005/05/04)
183
184 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
185 sandbox.bashrc:
186 Do not reset already set LD_PRELOAD when starting sandbox. If LD_PRELOAD is
187 already set, init of the env vars fails for some reason, so do this later on,
188 and do not warn (bug #91431).
189
190 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
191 sandbox.bashrc:
192 Fixup sandbox and sandbox.bashrc to call bash with the proper .bashrc.
193
194 * sandbox-1.2.4 (2005/05/03)
195
196 03 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
197 Do not init the env entries with each call, as it creates too many calls to
198 lstat, etc. Should speedup things a bit, bug #91040.
199
200 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
201 Add /dev/pty to default write list. Noticed by Morfic.
202
203 02 May 2005; Mike Frysinger <vapier@gentoo.org> configure.in, localdecls.h,
204 sandbox.h:
205 uClibc doesn't support dlvsym() so add a configure check to make sure it doesn't
206 exist. Also update localdecls.h so BROKEN_RTLD_NEXT isn't defined in uClibc.
207
208 * sandbox-1.2.3 (2005/04/29)
209
210 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> configure.in:
211 Do not check for (*&#$(* CXX or F77.
212
213 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
214 Do not append '/' to pathname in filter_path() if it already ends with it.
215
216 28 Apr 2005; Mike Frysinger <vapier@gentoo.org> Makefile.am, configure.in:
217 With az's help, clean up autotools to work with cross-compiling.
218
219 * sandbox-1.2.2 (2005/04/28)
220
221 28 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
222 Only check for /dev/{null,zero} for unlink hack, else ricers using /dev/shm
223 have issues; bug #90592.
224
225 * sandbox-1.2.1 (2005/04/23)
226
227 23 Apr 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
228 getcwd.c, libsandbox.c, localdecls.h, sandbox.h, sandbox_futils.c:
229 Make sure all functions used in libsandbox.c is declared static. Define
230 SB_STATIC in localdecls.h for this. Include sandbox_futils.c rather than
231 linking with its object. Hopefully this will fix bug #90153.
232
233 * sandbox-1.2 (2005/04/23)
234
235 22 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
236 Allow lchown a symlink in write-allowed path pointing to write-denied
237 target.
238
239 21 Mar 2005; Marius Mauch <genone@gentoo.org> libsandbox.c:
240 Also show resolved symlink names in the log.
241
242 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, libsandbox.c:
243 Seems -nostdlib was the problem with the constructor/destructor - remove it
244 from Makefile.am, and change the constructor/destructor names again.
245
246 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
247 Also rename the _init() and _fini() declarations.
248
249 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
250 Fixup the constructor/destructor function names again (they should be _init()
251 and _fini() it seems, and not being called caused sandbox_lib_path to be
252 unset, and thus breaking the execve() wrapper's LD_PRELOAD protection).
253 Add both the path in given SANDBOX_x variable, as well as its symlink
254 resolved path in init_env_entries(). Modify filter_path() to be able to
255 resolve paths without resolving symlinks, as well as to be able to resolve
256 symlinks. Fix a possible segfault in check_access(). Add symlink resolving
257 to check_access() resolving bug #31019. Add 'hack' for unlink, as the fix
258 for bug #31019 cause access violations if we try to remove a symlink that is
259 not in protected path, but points to a protected path. Fix a memory leak in
260 sandbox.c (sandbox_pids_file in main()). Fix the realpath() calls in main()
261 (sandbox.c) being unchecked. Fix the debug logname not having the pid in it
262 (pid_string was uninitialized). General syntax cleanups.
263
264 09 Mar 2005; Brian Harring <ferringb@gentoo.org> sandbox.c: Fixed the
265 infamous "pids file is not a regular file" w/out newline bug.
266
267 09 Mar 2005; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in:
268 Correct libc_version path detection, since it was screwing up if libdir !=
269 "/lib/".
270
271 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
272 Hack to make sure sandboxed process cannot remove a device node, bug #79836.
273
274 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am:
275 Fix symbols.in not added to dist.
276
277 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
278 getcwd.c, libsandbox.c, sandbox.c, sandbox.h, sandbox_futils.c:
279 White space fixes.
280
281 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
282 configure.in, getcwd.c, libsandbox.c, symbols.in:
283 Fix inverse test logic in canonicalize.c, use a strncpy. Fix gcc warning in
284 getcwd.c. Add symbols.in and logic to Makefile.am to generate symbol versions
285 for glibc and other libc's that use this. Update libsandbox.c to use these
286 symbol versions if available. Fix exec wrapper to re-export LD_PRELOAD if the
287 process unset it.
288
289 01 Mar 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
290 killed off _init and _fini in favor of
291 void __attribute__ ((constructor)) init_func and
292 void __attribute__ ((destructor)) closing_func. _(init|func) were deprecated.
293
294 06 Dec 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, libsandbox.c,
295 canonicalize.c, getcwd.c: Fixed compilation *again*. Hopefully cvs is done
296 having the hick-ups.
297
298 04 Dec 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, getcwd.c,
299 Makefile.am: Fixed compilation.
300
301 01 Dec 2004; Brian Harring <ferringb@gentoo.org> aclocal.m4:
302 Gutted the bugger so it stops checking for a c++ and fortran compiler.
303 Do *not* regenerate aclocal.m4 for making a release until a better
304 solution is created.
305
306 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, sandbox_futils.c:
307 Removal of more hardcoded paths.
308
309 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in,
310 sandbox_futils.c: tweaks to install sandbox.bashrc, and use it.
311
312 19 Nov 2004; Brian Harring <ferringb@gentoo.org>:
313 Sandbox is now autotooled, create-localdecls needs to be killed and the code
314 shifted into configure.in. Currently builds *one* libsandbox.so- if multiple
315 are desired (-m64 and -m32 for amd64), the ebuild should do it (imo).
316 To get to a point of testing, automake && autoconf; created requisite files w/
317 a(utomake|clocal)-1.8, and autoconf 2.59. Installs to /usr/, instead of
318 /lib and /usr/lib/portage/bin.
319
320 14 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox.c:
321 closing out bug #70225, potential overflow of the sandbox_pids_file var.
322
323 07 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c: c99 standard,
324 (think it was at least) allows intermixing of code and data segments. bug #70351
325 should be fixed by this.
326
327 03 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox_futils.c:
328 futils fix from bug #65201 via solar, and libsandbox log path checks via #69137
329
330 02 Aug 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Code from
331 Seth Robertson that tracked down all adjuct flags for read operations that
332 do not invoke a write operation.
333
334 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
335 Another fix from jstubbs regarding a free() on a stack variable for the
336 environment -- tracking now prevents extraneous free()'s segfault.
337
338 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
339 J. Stubbs tracked down a new bug where mkdir was failing to the patch on
340 the lstat in mkdir... it now only returns 0 or -1 as documented for mkdir.
341 Also remove the errno = ESUCCESS settings as documentation points out that
342 a library isn't allowed to do that.
343
344 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Added a
345 file_security_check() function to check random potential exploits on files
346 that sandbox is to load and read -- Normally sandboxpids.tmp. This fixes
347 the 'system-crippling' exploits (bug 21923) and catches a few other
348 potential problems.
349
350 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> Makefile: Updates for
351 32/64 bit sandbox. Made CC and LD '?=' values to allow passed in CC to work.
352
353 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c:
354 bug 42048 -- Fixed the lstat/errno conditions for mkdir <caleb@g.o>.
355 Added the 64/32 bit sandbox patch for AMD64 bug 32963 <brad/azarah>.
356
357 29 Feb 2004; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c :
358 Fix permissions and group of pids file and logs. Permissions should be 0664
359 and group should be 'portage'. Bug #34260.
360
361 28 Feb 2004; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
362 Besides a small cleanup, redo how we replace LD_PRELOAD in the environ passed
363 to the real execve (in our execve wrapper). Seems that on some arches (sparc
364 among others) do not allow us to tamper with the readonly copy passed to
365 execve, so pass our own copy of the environment. Bug #42290.
366
367 11 Jan 2004; Nicholas Jones <carpaski@gentoo.org> create-decls:
368 Changed tail to head and added a notice about duration of glibc check.
369
370 21 Dec 2003; Nicholas Jones <carpaski@gentoo.org> create-decls:
371 Changed the glibc subversion check to use /usr/bin/* instead of /bin/sh
372 as there isn't a guarentee that it is dynamic.
373
374 02 Nov 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
375 If 'file' passed to before_syscall(const char *func, const char *file) is
376 invalid, we should set errno to ENOENT, and not EINVAL. This should
377 close bug #32238.
378
379 14 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
380 Fix a bug that occurs mainly on 64bit arch, where the file passed to
381 the functions we wrap, is invalid, and then cause canonicalize to pass
382 garbage to before_syscall(), thanks to great detective work from
383 Andrea Luzzardi <al@sig11.org> (bug #29846).
384
385 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
386 Add a uClibc detection patch from Peter S. Mazinger <ps.m@gmx.net>.
387
388 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
389 Fix a bug in libsandbox.c 's checking in the rename wrapper - it basically
390 only checked the destination patch, and not the source, so we could move
391 a protected file to a unprotected directory, and then delete/modify it.
392 Thanks to Andrea Luzzardi (scox) <al@sig11.org>, bug #30992, for this fix.
393
394 12 Oct 2003; Nicholas Jones <carpaski@gentoo.org> sandbox.c :
395 Added python2.3 to the predict section/variable.
396
397 28 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
398 sandbox.h, sandbox_futils.c :
399 Add support to set the pids file via SANDBOX_PIDS_FILE at startup. If
400 it is not set, it will revert to its old value.
401
402 27 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
403 Fix our mkdir wrapper to check if the dir exist, and return EEXIST if so,
404 rather than failing with a violation, bug #29748.
405
406 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
407 Fix canonicalize() to ignore calls with path = "".
408
409 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c,
410 sandbox_futils.c, canonicalize.c :
411 Once again coreutils fails, as my systems had 2.5 kernel, the getcwd system
412 call handled strings larger than PATH_MAX (bug #21766). It however does not
413 work the same on 2.4 kernels.
414
415 To fix, I added the posix implementation of getcwd() (from glibc cvs) that
416 do not need the system call. We use the default getcwd() function via a
417 wrapper (egetcwd), and then lstat the returned path. If lstat fails, it
418 means the current directory was removed, OR that the the system call for
419 getcwd failed (curious is that it do not fail and return NULL or set
420 errno, but rather just truncate the retured directory - usually from the
421 start), and if so, we use the generic getcwd() function (__egetcwd). Note
422 that we do not use the generic version all the time, as it calls lstat()
423 a great number of times, and performance degrade much.
424
425 29 Jun 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls,
426 libsandbox.c :
427 Make sure SB_PATH_MAX will not wrap. Fix two possible memory leaks.
428
429 22 Jun 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, canonicalize.c
430 create-localdecls :
431 When checking path names of files accessed, we need to canonicalize it, else
432 it may be a symlink in a 'write allowed' directory pointing to a file in a
433 directory we should not have write access to.
434
435 With something like coreutils-5.0, we have two problems:
436 1) One of the tests checks if getcwd() can return a path longer than
437 PATH_MAX. This test then tries to create a dir which even while
438 created local (mkdir("conftest2")), it ends up being resolved with
439 a name that is much larger than PATH_MAX. The problem now is that
440 canonicalize() have undefined behaviour when the path was too long
441 (returned wrongly truncated paths, etc), and pass the wrong path to
442 before_syscall() (causing the bogus sandbox violations).
443 2) The ecanonicalize() function we used, along with the canonicalize()
444 function did not support longer than PATH_MAX. This is partly a
445 cause for 1), but the error checking (rather lack of it) of calls
446 to erealpath() in canonicalize() was the prime reason for 1).
447
448 As we do not use this canonicalized name to call the function, we resolve this
449 by fixing canonicalize() to do better error checking, and ecanonicalize() as
450 well as all functions in libsandbox.c to use a PATH_MAX of 'PATH_MAX * 2'.
451 While they will resolve paths properly now, and can check if a write/read is
452 allowed, the functions called from the sandboxed environment will still work
453 as expected.
454
455 This should resolve bug #21766.
456
457 06 Apr 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
458 For some reason sandbox fails with a 'open_wr' if you run 'locale -a' under
459 it (bug #16298).
460
461 Problem is that for some reason locale fopen's locale.alias with mode "rm".
462
463 -------------------------------------------------------
464 nosferatu root # grep fopen locale.log
465 fopen("/usr/share/locale/locale.alias", "rm"ACCESS DENIED open_wr: /usr/share/locale/locale.alias
466 nosferatu root #
467 --------------------------------------------------------
468
469 I checked the source of locale, but it have fopen with mode 'r', so
470 not sure where the "rm" mode comes from. Anyhow, changed the check in
471 before_syscall_open_char() to also see mode "rm" as readonly.
472
473 23 Feb 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
474
475 Add glibc-2.3 support.
476
477 22 Feb 2003; Martin Schlemmer <azarah@gentoo.org> sandbox.c :
478
479 Some /etc/ld.so.preload fixes. Just changed the #if defines to cover all
480 operations releated to preload, as well as only try to modify ld.so.preload
481 if we can. Also modify to write the pid to /tmp/sandboxpids.tmp even when
482 not using ld.so.preload. Fix to not write this instance of sandbox's pid
483 to /tmp/sandboxpids.tmp on exit if this is not the last sandbox running.
484
485 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> Makefile :
486
487 Changed the LD to CC for hppa.
488
489 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
490
491 Killed the previous changes I made.
492
493 17 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
494
495 Added parisc to BROKEN_RTLD_ARCHLIST to see if it we can fix the relocation probs.
496
497 09 Jan 2003; J Robert Ray <jrray@gentoo.org> sandbox.c :
498
499 Don't segfault if $HOME isn't set, set $HOME to "/" instead. Fixes bug 10868.
500
501 16 Dec 2002; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
502
503 Fix memory leak for mips, bug #12236. Thanks to Torgeir Hansen <torgeir@trenger.ro>
504 for this fix.
505
506 4 Dec 2002; J Robert Ray <jrray@gentoo.org> sandbox.h sandbox_futils.c :
507
508 sandbox_futils defined a dirname() function that was masking the same
509 function in glibc and was broken (e.g.: SANDBOX_DIR was being set to
510 '/usr/lib/portage/bi/'). Fixed function to return expected results and
511 renamed it to sb_dirname() to no longer mask the glibc function. Closes bug
512 11231.
513
514 4 Dec 2002; Martin Schlemmer <azarah@gentoo.org> :
515
516 Fix a segfault in libsandbox.c if canonicalize() was called with
517 first parameter = NULL.
518
519 1 Sep 2002; Martin Schlemmer <azarah@gentoo.org> :
520
521 Fix my braindead 'return 1;' in a void function. Updated sandbox.c,
522 cleanup() for this.
523
524 Change cleanup() in sandbox.c not to exit with fail status if
525 the pidsfile is missing. We really should still display sandbox
526 violations if they occured.
527
528 31 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
529
530 Update cleanup() in sandbox.c to remove the PIDSFILE if this is
531 the last sandbox running.
532
533 25 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
534
535 Major cleanups to mainly libsandbox.c again.
536
537 22 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
538
539 Add copyrights to sandbox.h and sandbox_futils.h. If wrong, the
540 parties involved should please contact me so that we can fix it.
541
542 Add opendir wrapper to libsandbox.c.
543
544 21 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
545
546 Do some more cleanups to ecanonicalize(), as it dropped filenames in
547 rare cases (after my symlink cleanups), and caused glibc to bork.
548 These fixes went into canonicalize.c.
549
550 20 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
551
552 Fix spawn_shell() and main() in sandbox.c to properly return fail
553 status.
554
555 19 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
556
557 The new canonicalize() function in libsandbox.c also resolved symlinks,
558 which caused on cleaning sandbox errors if the symlink pointed to a
559 file in the live root. Ripped out canonicalize() and realpath() from
560 glibc; removed the symlink stuff, and changed them to ecanonicalize()
561 and erealpath().
562
563 18 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
564
565 Ripped out all the wrappers, and implemented those of InstallWatch.
566 Losts of cleanups and bugfixes. Implement a execve that forces
567 $LIBSANDBOX in $LD_PRELOAD. We can now thus do away with the feared
568 /etc/ld.so.preload (*g*) ... Made the needed changes to sandbox.c,
569 sandbox.h and sandbox_futils.c. Rewrote the Makefile for most
570 parts; it now have an install target.
571
572 Reformat the whole thing to look somewhat like the reworked sandbox.c
573 and new sandbox.h and sandbox_futils.c from:
574
575 Brad House <brad@mainstreetsoftworks.com>.
576
577 Additional Copyrights now due to the InstallWatch code:
578
579 Copyright (C) 1998-9 Pancrazio `Ezio' de Mauro <p@demauro.net>

Properties

Name Value
svn:eol-style native
svn:keywords Author Date Id Revision

  ViewVC Help
Powered by ViewVC 1.1.20