/[path-sandbox]/trunk/ChangeLog
Gentoo

Contents of /trunk/ChangeLog

Parent Directory Parent Directory | Revision Log Revision Log


Revision 144 - (show annotations) (download)
Thu Jul 7 22:58:16 2005 UTC (9 years ago) by azarah
File size: 26721 byte(s)
Cleanup access/log printing.  Make access printing honour NOCOLOR.  Fix log
printing's last line not honouring NOCOLOR.

1 # ChangeLog for Path Sandbox
2 # Copyright 1999-2005 Gentoo Foundation; Distributed under the GPL v2
3 # $Header$
4
5 07 July 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
6 sandbox.h, sandbox_futils.c:
7 - Fix possible segfault in env init code.
8 - Major cleanup of sandbox_futils.c. Removed most of the functions as we now
9 write to /var/log/sandbox/, so in theory do not need all that.
10 - Redo the interface of the get_* functions so that we do not leak memory.
11 - Remove sandbox_dir and co - we are not using it anymore.
12 - Remove unused includes and variables.
13 - Only declare functions in sandbox_futils.c that are used in libsandbox.c when
14 OUTSIDE_LIBSANDBOX is not defined.
15 - Cleanup access/log printing. Make access printing honour NOCOLOR. Fix log
16 printing's last line not honouring NOCOLOR.
17
18 06 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.h, sandbox_futils.c,
19 libsandbox.c:
20 - Change log dir to /var/log/sandbox/. Make sure the sandboxed process cannot
21 write to it.
22 - Clean up logging in libsandbox.c, and hopefully make it more consistant.
23 - Add check_prefixes() with major cleanup on check_access().
24 - Cleanup init_env_entries() and check_prefixes().
25
26 05 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
27 sandbox_futils.c, libsandbox.c:
28 Remove unused 'pids file' code.
29
30 * sandbox-1.2.10 (2005/07/03)
31
32 03 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
33 Add PREDICT items for nss-db, bug #92079. Patch from Robin Johnson.
34
35 17 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
36 General cleanups:
37 - Remove fooling around with exit codes - we error out on presence of a log
38 anyhow.
39 - Move get_sandbox_*_envvar() to sandbox_setup_environ(), as its more
40 appropriate there.
41
42 12 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
43 Cleanup the fail_nametoolong stuff a bit more.
44
45 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
46 Remove hopefully the last ld.so.preload bits we do not use anymore.
47
48 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
49 Remove the unneeded canonicalize() calls in the wrappers - we do it anyhow
50 in check_syscall(). Should speed things up a bit (at least for the getcwd()
51 and long path name test it goes down to under a second, and not 10+ seconds
52 like before). Also warn if we skip checking due to the canonicalized path
53 being too long.
54
55 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
56 More comment/readability cleanups.
57
58 10 June 2005; Martin Schlemmer <azarah@gentoo.org> canonicalize.c, getcwd.c,
59 sandbox_futils.c, libsandbox.c:
60 Some strncpy/strncat and other cleanups.
61
62 * sandbox-1.2.9 (2005/06/09)
63
64 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
65 Move symlink hack down a bit to try and minimize on the amount of lstat()
66 calls we do.
67
68 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
69 Add hack to allow writing to /proc/self/fd (or /dev/fd), bug #91516.
70
71 09 June 2005; Martin Schlemmer <azarah@gentoo.org> symbols.in, libsandbox.c:
72 Add wrapper for access() function, bug #85413.
73
74 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c:
75 Use generic getcwd() implementation from uclibc - should be more portable
76 and looks a bit cleaner.
77
78 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c:
79 Make sure our true_* pointers are initialized to NULL, and that we check for
80 all references that they are valid.
81
82 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
83 Be default we will fail if the path name we try to canonicalize is too long.
84 This however could cause issues with some things (bug #94630 and #21766), so
85 if fail_nametoolong == 0, canonicalize() will return a null length string and
86 do not fail.
87
88 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c:
89 Do not abort if TMPDIR is not valid, but rather use '/tmp', bug #94360. Also
90 make sure we re-export the new TMPDIR environment variable.
91
92 08 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
93 Fix incorrect free of non-malloc'd array, bug #92313 and #94020. Fix noted
94 by Marcus D. Hanwell <cryos@gentoo.org>.
95
96 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
97 Add /dev/console to write list, bug #38588.
98
99 * sandbox-1.2.8 (2005/05/13)
100
101 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
102 sandbox.h, sandbox_futils.c:
103 General cleanups.
104
105 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
106 sandbox.h:
107 Various LD_PRELOAD cleanups. Do not unset LD_PRELOAD for parent.
108
109 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
110 sandbox.h, sandbox_futils.c:
111 Modify get_sandbox_pids_file(), get_sandbox_log() and get_sandbox_debug_log()
112 to use TMPDIR if present in environment.
113
114 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
115 Remove sandbox_log_file from main() as its no longer used.
116
117 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
118 sandbox_futils.c:
119 Add get_sandbox_debug_log(), and use it (add behaviour similar to SANDBOX_LOG
120 if already exported when sandbox started). Fix get_sandbox_log() and new
121 get_sandbox_debug_log() to not use already exported environment variables if
122 they have '/' in them. Use snprintf()'s instead of strncpy()'s. More
123 SB_PATH_MAX fixes.
124
125 * sandbox-1.2.7 (2005/05/12)
126
127 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
128 sandbox_futils.c:
129 More path limit fixes. Declare SB_BUF_LEN global and use it where needed.
130
131 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
132 Fix paths limited to 255 chars. Fix get_sandbox_dir() returning a string
133 with '(null)' in it if we did not call sandbox with absolute path.
134
135 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
136 Set SANDBOX_ON *before* doing the child's env stuff, else its not set
137 for the child.
138
139 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
140 Remove global preload_adaptable as it is no longer used.
141
142 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
143 Rewrite environment stuff to only be set when execve'ing the child process
144 to try and avoid issues like bug #91541 that causes sandbox to crash if
145 we set LD_PRELOAD sandbox side already.
146
147 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
148 Move print_sandbox_log() up to make things neater.
149
150 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
151 Remove load_preload_libs(), as its not used anymore.
152
153 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
154 Remove NO_FORK stuff, as its not used, and 'strace -f' works just fine.
155
156 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
157 Remove USE_SYSTEM_SHELL stuff, as it is not secure, and not in use.
158
159 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
160 Remove ld.so.preload crap - we are not going to use it again.
161
162 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
163 Fix typo in code that checks if we got valid group information, causing a
164 segmentation fault, bug #91637.
165
166 * sandbox-1.2.6 (2005/05/10)
167
168 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
169 Do not use LD_PRELOAD if it contains libtsocks.so, as it breaks sandbox
170 for some odd reason, bug #91541.
171
172 09 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
173 Fix typo (sizeof -> strlen).
174
175 08 May 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
176 rewrote the sbcontext caching code so it accounts for env changes since lib
177 initialization.
178
179 05 May 2005; Martin Schlemmer <azarah@gentoo.org> configure.in, libctest.c:
180 We create libctest.c via configure, so no need to keep it around. Do some
181 cleanup related to libctest.c and libctest during configure.
182
183 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
184 Add rename support of symlinks pointing to protected files/directories.
185
186 * sandbox-1.2.5 (2005/05/04)
187
188 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
189 sandbox.bashrc:
190 Do not reset already set LD_PRELOAD when starting sandbox. If LD_PRELOAD is
191 already set, init of the env vars fails for some reason, so do this later on,
192 and do not warn (bug #91431).
193
194 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
195 sandbox.bashrc:
196 Fixup sandbox and sandbox.bashrc to call bash with the proper .bashrc.
197
198 * sandbox-1.2.4 (2005/05/03)
199
200 03 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
201 Do not init the env entries with each call, as it creates too many calls to
202 lstat, etc. Should speedup things a bit, bug #91040.
203
204 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
205 Add /dev/pty to default write list. Noticed by Morfic.
206
207 02 May 2005; Mike Frysinger <vapier@gentoo.org> configure.in, localdecls.h,
208 sandbox.h:
209 uClibc doesn't support dlvsym() so add a configure check to make sure it doesn't
210 exist. Also update localdecls.h so BROKEN_RTLD_NEXT isn't defined in uClibc.
211
212 * sandbox-1.2.3 (2005/04/29)
213
214 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> configure.in:
215 Do not check for (*&#$(* CXX or F77.
216
217 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
218 Do not append '/' to pathname in filter_path() if it already ends with it.
219
220 28 Apr 2005; Mike Frysinger <vapier@gentoo.org> Makefile.am, configure.in:
221 With az's help, clean up autotools to work with cross-compiling.
222
223 * sandbox-1.2.2 (2005/04/28)
224
225 28 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
226 Only check for /dev/{null,zero} for unlink hack, else ricers using /dev/shm
227 have issues; bug #90592.
228
229 * sandbox-1.2.1 (2005/04/23)
230
231 23 Apr 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
232 getcwd.c, libsandbox.c, localdecls.h, sandbox.h, sandbox_futils.c:
233 Make sure all functions used in libsandbox.c is declared static. Define
234 SB_STATIC in localdecls.h for this. Include sandbox_futils.c rather than
235 linking with its object. Hopefully this will fix bug #90153.
236
237 * sandbox-1.2 (2005/04/23)
238
239 22 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
240 Allow lchown a symlink in write-allowed path pointing to write-denied
241 target.
242
243 21 Mar 2005; Marius Mauch <genone@gentoo.org> libsandbox.c:
244 Also show resolved symlink names in the log.
245
246 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, libsandbox.c:
247 Seems -nostdlib was the problem with the constructor/destructor - remove it
248 from Makefile.am, and change the constructor/destructor names again.
249
250 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
251 Also rename the _init() and _fini() declarations.
252
253 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
254 Fixup the constructor/destructor function names again (they should be _init()
255 and _fini() it seems, and not being called caused sandbox_lib_path to be
256 unset, and thus breaking the execve() wrapper's LD_PRELOAD protection).
257 Add both the path in given SANDBOX_x variable, as well as its symlink
258 resolved path in init_env_entries(). Modify filter_path() to be able to
259 resolve paths without resolving symlinks, as well as to be able to resolve
260 symlinks. Fix a possible segfault in check_access(). Add symlink resolving
261 to check_access() resolving bug #31019. Add 'hack' for unlink, as the fix
262 for bug #31019 cause access violations if we try to remove a symlink that is
263 not in protected path, but points to a protected path. Fix a memory leak in
264 sandbox.c (sandbox_pids_file in main()). Fix the realpath() calls in main()
265 (sandbox.c) being unchecked. Fix the debug logname not having the pid in it
266 (pid_string was uninitialized). General syntax cleanups.
267
268 09 Mar 2005; Brian Harring <ferringb@gentoo.org> sandbox.c: Fixed the
269 infamous "pids file is not a regular file" w/out newline bug.
270
271 09 Mar 2005; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in:
272 Correct libc_version path detection, since it was screwing up if libdir !=
273 "/lib/".
274
275 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
276 Hack to make sure sandboxed process cannot remove a device node, bug #79836.
277
278 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am:
279 Fix symbols.in not added to dist.
280
281 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
282 getcwd.c, libsandbox.c, sandbox.c, sandbox.h, sandbox_futils.c:
283 White space fixes.
284
285 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
286 configure.in, getcwd.c, libsandbox.c, symbols.in:
287 Fix inverse test logic in canonicalize.c, use a strncpy. Fix gcc warning in
288 getcwd.c. Add symbols.in and logic to Makefile.am to generate symbol versions
289 for glibc and other libc's that use this. Update libsandbox.c to use these
290 symbol versions if available. Fix exec wrapper to re-export LD_PRELOAD if the
291 process unset it.
292
293 01 Mar 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
294 killed off _init and _fini in favor of
295 void __attribute__ ((constructor)) init_func and
296 void __attribute__ ((destructor)) closing_func. _(init|func) were deprecated.
297
298 06 Dec 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, libsandbox.c,
299 canonicalize.c, getcwd.c: Fixed compilation *again*. Hopefully cvs is done
300 having the hick-ups.
301
302 04 Dec 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, getcwd.c,
303 Makefile.am: Fixed compilation.
304
305 01 Dec 2004; Brian Harring <ferringb@gentoo.org> aclocal.m4:
306 Gutted the bugger so it stops checking for a c++ and fortran compiler.
307 Do *not* regenerate aclocal.m4 for making a release until a better
308 solution is created.
309
310 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, sandbox_futils.c:
311 Removal of more hardcoded paths.
312
313 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in,
314 sandbox_futils.c: tweaks to install sandbox.bashrc, and use it.
315
316 19 Nov 2004; Brian Harring <ferringb@gentoo.org>:
317 Sandbox is now autotooled, create-localdecls needs to be killed and the code
318 shifted into configure.in. Currently builds *one* libsandbox.so- if multiple
319 are desired (-m64 and -m32 for amd64), the ebuild should do it (imo).
320 To get to a point of testing, automake && autoconf; created requisite files w/
321 a(utomake|clocal)-1.8, and autoconf 2.59. Installs to /usr/, instead of
322 /lib and /usr/lib/portage/bin.
323
324 14 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox.c:
325 closing out bug #70225, potential overflow of the sandbox_pids_file var.
326
327 07 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c: c99 standard,
328 (think it was at least) allows intermixing of code and data segments. bug #70351
329 should be fixed by this.
330
331 03 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox_futils.c:
332 futils fix from bug #65201 via solar, and libsandbox log path checks via #69137
333
334 02 Aug 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Code from
335 Seth Robertson that tracked down all adjuct flags for read operations that
336 do not invoke a write operation.
337
338 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
339 Another fix from jstubbs regarding a free() on a stack variable for the
340 environment -- tracking now prevents extraneous free()'s segfault.
341
342 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
343 J. Stubbs tracked down a new bug where mkdir was failing to the patch on
344 the lstat in mkdir... it now only returns 0 or -1 as documented for mkdir.
345 Also remove the errno = ESUCCESS settings as documentation points out that
346 a library isn't allowed to do that.
347
348 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Added a
349 file_security_check() function to check random potential exploits on files
350 that sandbox is to load and read -- Normally sandboxpids.tmp. This fixes
351 the 'system-crippling' exploits (bug 21923) and catches a few other
352 potential problems.
353
354 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> Makefile: Updates for
355 32/64 bit sandbox. Made CC and LD '?=' values to allow passed in CC to work.
356
357 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c:
358 bug 42048 -- Fixed the lstat/errno conditions for mkdir <caleb@g.o>.
359 Added the 64/32 bit sandbox patch for AMD64 bug 32963 <brad/azarah>.
360
361 29 Feb 2004; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c :
362 Fix permissions and group of pids file and logs. Permissions should be 0664
363 and group should be 'portage'. Bug #34260.
364
365 28 Feb 2004; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
366 Besides a small cleanup, redo how we replace LD_PRELOAD in the environ passed
367 to the real execve (in our execve wrapper). Seems that on some arches (sparc
368 among others) do not allow us to tamper with the readonly copy passed to
369 execve, so pass our own copy of the environment. Bug #42290.
370
371 11 Jan 2004; Nicholas Jones <carpaski@gentoo.org> create-decls:
372 Changed tail to head and added a notice about duration of glibc check.
373
374 21 Dec 2003; Nicholas Jones <carpaski@gentoo.org> create-decls:
375 Changed the glibc subversion check to use /usr/bin/* instead of /bin/sh
376 as there isn't a guarentee that it is dynamic.
377
378 02 Nov 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
379 If 'file' passed to before_syscall(const char *func, const char *file) is
380 invalid, we should set errno to ENOENT, and not EINVAL. This should
381 close bug #32238.
382
383 14 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
384 Fix a bug that occurs mainly on 64bit arch, where the file passed to
385 the functions we wrap, is invalid, and then cause canonicalize to pass
386 garbage to before_syscall(), thanks to great detective work from
387 Andrea Luzzardi <al@sig11.org> (bug #29846).
388
389 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
390 Add a uClibc detection patch from Peter S. Mazinger <ps.m@gmx.net>.
391
392 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
393 Fix a bug in libsandbox.c 's checking in the rename wrapper - it basically
394 only checked the destination patch, and not the source, so we could move
395 a protected file to a unprotected directory, and then delete/modify it.
396 Thanks to Andrea Luzzardi (scox) <al@sig11.org>, bug #30992, for this fix.
397
398 12 Oct 2003; Nicholas Jones <carpaski@gentoo.org> sandbox.c :
399 Added python2.3 to the predict section/variable.
400
401 28 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
402 sandbox.h, sandbox_futils.c :
403 Add support to set the pids file via SANDBOX_PIDS_FILE at startup. If
404 it is not set, it will revert to its old value.
405
406 27 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
407 Fix our mkdir wrapper to check if the dir exist, and return EEXIST if so,
408 rather than failing with a violation, bug #29748.
409
410 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
411 Fix canonicalize() to ignore calls with path = "".
412
413 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c,
414 sandbox_futils.c, canonicalize.c :
415 Once again coreutils fails, as my systems had 2.5 kernel, the getcwd system
416 call handled strings larger than PATH_MAX (bug #21766). It however does not
417 work the same on 2.4 kernels.
418
419 To fix, I added the posix implementation of getcwd() (from glibc cvs) that
420 do not need the system call. We use the default getcwd() function via a
421 wrapper (egetcwd), and then lstat the returned path. If lstat fails, it
422 means the current directory was removed, OR that the the system call for
423 getcwd failed (curious is that it do not fail and return NULL or set
424 errno, but rather just truncate the retured directory - usually from the
425 start), and if so, we use the generic getcwd() function (__egetcwd). Note
426 that we do not use the generic version all the time, as it calls lstat()
427 a great number of times, and performance degrade much.
428
429 29 Jun 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls,
430 libsandbox.c :
431 Make sure SB_PATH_MAX will not wrap. Fix two possible memory leaks.
432
433 22 Jun 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, canonicalize.c
434 create-localdecls :
435 When checking path names of files accessed, we need to canonicalize it, else
436 it may be a symlink in a 'write allowed' directory pointing to a file in a
437 directory we should not have write access to.
438
439 With something like coreutils-5.0, we have two problems:
440 1) One of the tests checks if getcwd() can return a path longer than
441 PATH_MAX. This test then tries to create a dir which even while
442 created local (mkdir("conftest2")), it ends up being resolved with
443 a name that is much larger than PATH_MAX. The problem now is that
444 canonicalize() have undefined behaviour when the path was too long
445 (returned wrongly truncated paths, etc), and pass the wrong path to
446 before_syscall() (causing the bogus sandbox violations).
447 2) The ecanonicalize() function we used, along with the canonicalize()
448 function did not support longer than PATH_MAX. This is partly a
449 cause for 1), but the error checking (rather lack of it) of calls
450 to erealpath() in canonicalize() was the prime reason for 1).
451
452 As we do not use this canonicalized name to call the function, we resolve this
453 by fixing canonicalize() to do better error checking, and ecanonicalize() as
454 well as all functions in libsandbox.c to use a PATH_MAX of 'PATH_MAX * 2'.
455 While they will resolve paths properly now, and can check if a write/read is
456 allowed, the functions called from the sandboxed environment will still work
457 as expected.
458
459 This should resolve bug #21766.
460
461 06 Apr 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
462 For some reason sandbox fails with a 'open_wr' if you run 'locale -a' under
463 it (bug #16298).
464
465 Problem is that for some reason locale fopen's locale.alias with mode "rm".
466
467 -------------------------------------------------------
468 nosferatu root # grep fopen locale.log
469 fopen("/usr/share/locale/locale.alias", "rm"ACCESS DENIED open_wr: /usr/share/locale/locale.alias
470 nosferatu root #
471 --------------------------------------------------------
472
473 I checked the source of locale, but it have fopen with mode 'r', so
474 not sure where the "rm" mode comes from. Anyhow, changed the check in
475 before_syscall_open_char() to also see mode "rm" as readonly.
476
477 23 Feb 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
478
479 Add glibc-2.3 support.
480
481 22 Feb 2003; Martin Schlemmer <azarah@gentoo.org> sandbox.c :
482
483 Some /etc/ld.so.preload fixes. Just changed the #if defines to cover all
484 operations releated to preload, as well as only try to modify ld.so.preload
485 if we can. Also modify to write the pid to /tmp/sandboxpids.tmp even when
486 not using ld.so.preload. Fix to not write this instance of sandbox's pid
487 to /tmp/sandboxpids.tmp on exit if this is not the last sandbox running.
488
489 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> Makefile :
490
491 Changed the LD to CC for hppa.
492
493 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
494
495 Killed the previous changes I made.
496
497 17 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
498
499 Added parisc to BROKEN_RTLD_ARCHLIST to see if it we can fix the relocation probs.
500
501 09 Jan 2003; J Robert Ray <jrray@gentoo.org> sandbox.c :
502
503 Don't segfault if $HOME isn't set, set $HOME to "/" instead. Fixes bug 10868.
504
505 16 Dec 2002; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
506
507 Fix memory leak for mips, bug #12236. Thanks to Torgeir Hansen <torgeir@trenger.ro>
508 for this fix.
509
510 4 Dec 2002; J Robert Ray <jrray@gentoo.org> sandbox.h sandbox_futils.c :
511
512 sandbox_futils defined a dirname() function that was masking the same
513 function in glibc and was broken (e.g.: SANDBOX_DIR was being set to
514 '/usr/lib/portage/bi/'). Fixed function to return expected results and
515 renamed it to sb_dirname() to no longer mask the glibc function. Closes bug
516 11231.
517
518 4 Dec 2002; Martin Schlemmer <azarah@gentoo.org> :
519
520 Fix a segfault in libsandbox.c if canonicalize() was called with
521 first parameter = NULL.
522
523 1 Sep 2002; Martin Schlemmer <azarah@gentoo.org> :
524
525 Fix my braindead 'return 1;' in a void function. Updated sandbox.c,
526 cleanup() for this.
527
528 Change cleanup() in sandbox.c not to exit with fail status if
529 the pidsfile is missing. We really should still display sandbox
530 violations if they occured.
531
532 31 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
533
534 Update cleanup() in sandbox.c to remove the PIDSFILE if this is
535 the last sandbox running.
536
537 25 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
538
539 Major cleanups to mainly libsandbox.c again.
540
541 22 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
542
543 Add copyrights to sandbox.h and sandbox_futils.h. If wrong, the
544 parties involved should please contact me so that we can fix it.
545
546 Add opendir wrapper to libsandbox.c.
547
548 21 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
549
550 Do some more cleanups to ecanonicalize(), as it dropped filenames in
551 rare cases (after my symlink cleanups), and caused glibc to bork.
552 These fixes went into canonicalize.c.
553
554 20 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
555
556 Fix spawn_shell() and main() in sandbox.c to properly return fail
557 status.
558
559 19 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
560
561 The new canonicalize() function in libsandbox.c also resolved symlinks,
562 which caused on cleaning sandbox errors if the symlink pointed to a
563 file in the live root. Ripped out canonicalize() and realpath() from
564 glibc; removed the symlink stuff, and changed them to ecanonicalize()
565 and erealpath().
566
567 18 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
568
569 Ripped out all the wrappers, and implemented those of InstallWatch.
570 Losts of cleanups and bugfixes. Implement a execve that forces
571 $LIBSANDBOX in $LD_PRELOAD. We can now thus do away with the feared
572 /etc/ld.so.preload (*g*) ... Made the needed changes to sandbox.c,
573 sandbox.h and sandbox_futils.c. Rewrote the Makefile for most
574 parts; it now have an install target.
575
576 Reformat the whole thing to look somewhat like the reworked sandbox.c
577 and new sandbox.h and sandbox_futils.c from:
578
579 Brad House <brad@mainstreetsoftworks.com>.
580
581 Additional Copyrights now due to the InstallWatch code:
582
583 Copyright (C) 1998-9 Pancrazio `Ezio' de Mauro <p@demauro.net>

Properties

Name Value
svn:eol-style native
svn:keywords Author Date Id Revision

  ViewVC Help
Powered by ViewVC 1.1.20