/[path-sandbox]/trunk/ChangeLog
Gentoo

Contents of /trunk/ChangeLog

Parent Directory Parent Directory | Revision Log Revision Log


Revision 147 - (show annotations) (download)
Fri Jul 8 15:49:23 2005 UTC (9 years, 1 month ago) by azarah
File size: 27020 byte(s)
Fix compile error with previous change, and return rather then exit().
1 # ChangeLog for Path Sandbox
2 # Copyright 1999-2005 Gentoo Foundation; Distributed under the GPL v2
3 # $Header$
4
5 08 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c,
6 libsandbox.c:
7 - Try to cleanup and make error handling/printing consistent.
8 - Remove old logs if present and conflicting with current.
9 - Fix compile error with previous change, and return rather then exit().
10
11 07 July 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
12 sandbox.h, sandbox_futils.c:
13 - Fix possible segfault in env init code.
14 - Major cleanup of sandbox_futils.c. Removed most of the functions as we now
15 write to /var/log/sandbox/, so in theory do not need all that.
16 - Redo the interface of the get_* functions so that we do not leak memory.
17 - Remove sandbox_dir and co - we are not using it anymore.
18 - Remove unused includes and variables.
19 - Only declare functions in sandbox_futils.c that are used in libsandbox.c when
20 OUTSIDE_LIBSANDBOX is not defined.
21 - Cleanup access/log printing. Make access printing honour NOCOLOR. Fix log
22 printing's last line not honouring NOCOLOR.
23
24 06 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.h, sandbox_futils.c,
25 libsandbox.c:
26 - Change log dir to /var/log/sandbox/. Make sure the sandboxed process cannot
27 write to it.
28 - Clean up logging in libsandbox.c, and hopefully make it more consistant.
29 - Add check_prefixes() with major cleanup on check_access().
30 - Cleanup init_env_entries() and check_prefixes().
31
32 05 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
33 sandbox_futils.c, libsandbox.c:
34 Remove unused 'pids file' code.
35
36 * sandbox-1.2.10 (2005/07/03)
37
38 03 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
39 Add PREDICT items for nss-db, bug #92079. Patch from Robin Johnson.
40
41 17 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
42 General cleanups:
43 - Remove fooling around with exit codes - we error out on presence of a log
44 anyhow.
45 - Move get_sandbox_*_envvar() to sandbox_setup_environ(), as its more
46 appropriate there.
47
48 12 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
49 Cleanup the fail_nametoolong stuff a bit more.
50
51 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
52 Remove hopefully the last ld.so.preload bits we do not use anymore.
53
54 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
55 Remove the unneeded canonicalize() calls in the wrappers - we do it anyhow
56 in check_syscall(). Should speed things up a bit (at least for the getcwd()
57 and long path name test it goes down to under a second, and not 10+ seconds
58 like before). Also warn if we skip checking due to the canonicalized path
59 being too long.
60
61 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
62 More comment/readability cleanups.
63
64 10 June 2005; Martin Schlemmer <azarah@gentoo.org> canonicalize.c, getcwd.c,
65 sandbox_futils.c, libsandbox.c:
66 Some strncpy/strncat and other cleanups.
67
68 * sandbox-1.2.9 (2005/06/09)
69
70 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
71 Move symlink hack down a bit to try and minimize on the amount of lstat()
72 calls we do.
73
74 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
75 Add hack to allow writing to /proc/self/fd (or /dev/fd), bug #91516.
76
77 09 June 2005; Martin Schlemmer <azarah@gentoo.org> symbols.in, libsandbox.c:
78 Add wrapper for access() function, bug #85413.
79
80 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c:
81 Use generic getcwd() implementation from uclibc - should be more portable
82 and looks a bit cleaner.
83
84 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c:
85 Make sure our true_* pointers are initialized to NULL, and that we check for
86 all references that they are valid.
87
88 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
89 Be default we will fail if the path name we try to canonicalize is too long.
90 This however could cause issues with some things (bug #94630 and #21766), so
91 if fail_nametoolong == 0, canonicalize() will return a null length string and
92 do not fail.
93
94 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c:
95 Do not abort if TMPDIR is not valid, but rather use '/tmp', bug #94360. Also
96 make sure we re-export the new TMPDIR environment variable.
97
98 08 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
99 Fix incorrect free of non-malloc'd array, bug #92313 and #94020. Fix noted
100 by Marcus D. Hanwell <cryos@gentoo.org>.
101
102 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
103 Add /dev/console to write list, bug #38588.
104
105 * sandbox-1.2.8 (2005/05/13)
106
107 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
108 sandbox.h, sandbox_futils.c:
109 General cleanups.
110
111 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
112 sandbox.h:
113 Various LD_PRELOAD cleanups. Do not unset LD_PRELOAD for parent.
114
115 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
116 sandbox.h, sandbox_futils.c:
117 Modify get_sandbox_pids_file(), get_sandbox_log() and get_sandbox_debug_log()
118 to use TMPDIR if present in environment.
119
120 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
121 Remove sandbox_log_file from main() as its no longer used.
122
123 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
124 sandbox_futils.c:
125 Add get_sandbox_debug_log(), and use it (add behaviour similar to SANDBOX_LOG
126 if already exported when sandbox started). Fix get_sandbox_log() and new
127 get_sandbox_debug_log() to not use already exported environment variables if
128 they have '/' in them. Use snprintf()'s instead of strncpy()'s. More
129 SB_PATH_MAX fixes.
130
131 * sandbox-1.2.7 (2005/05/12)
132
133 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
134 sandbox_futils.c:
135 More path limit fixes. Declare SB_BUF_LEN global and use it where needed.
136
137 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
138 Fix paths limited to 255 chars. Fix get_sandbox_dir() returning a string
139 with '(null)' in it if we did not call sandbox with absolute path.
140
141 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
142 Set SANDBOX_ON *before* doing the child's env stuff, else its not set
143 for the child.
144
145 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
146 Remove global preload_adaptable as it is no longer used.
147
148 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
149 Rewrite environment stuff to only be set when execve'ing the child process
150 to try and avoid issues like bug #91541 that causes sandbox to crash if
151 we set LD_PRELOAD sandbox side already.
152
153 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
154 Move print_sandbox_log() up to make things neater.
155
156 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
157 Remove load_preload_libs(), as its not used anymore.
158
159 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
160 Remove NO_FORK stuff, as its not used, and 'strace -f' works just fine.
161
162 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
163 Remove USE_SYSTEM_SHELL stuff, as it is not secure, and not in use.
164
165 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
166 Remove ld.so.preload crap - we are not going to use it again.
167
168 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
169 Fix typo in code that checks if we got valid group information, causing a
170 segmentation fault, bug #91637.
171
172 * sandbox-1.2.6 (2005/05/10)
173
174 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
175 Do not use LD_PRELOAD if it contains libtsocks.so, as it breaks sandbox
176 for some odd reason, bug #91541.
177
178 09 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
179 Fix typo (sizeof -> strlen).
180
181 08 May 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
182 rewrote the sbcontext caching code so it accounts for env changes since lib
183 initialization.
184
185 05 May 2005; Martin Schlemmer <azarah@gentoo.org> configure.in, libctest.c:
186 We create libctest.c via configure, so no need to keep it around. Do some
187 cleanup related to libctest.c and libctest during configure.
188
189 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
190 Add rename support of symlinks pointing to protected files/directories.
191
192 * sandbox-1.2.5 (2005/05/04)
193
194 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
195 sandbox.bashrc:
196 Do not reset already set LD_PRELOAD when starting sandbox. If LD_PRELOAD is
197 already set, init of the env vars fails for some reason, so do this later on,
198 and do not warn (bug #91431).
199
200 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
201 sandbox.bashrc:
202 Fixup sandbox and sandbox.bashrc to call bash with the proper .bashrc.
203
204 * sandbox-1.2.4 (2005/05/03)
205
206 03 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
207 Do not init the env entries with each call, as it creates too many calls to
208 lstat, etc. Should speedup things a bit, bug #91040.
209
210 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
211 Add /dev/pty to default write list. Noticed by Morfic.
212
213 02 May 2005; Mike Frysinger <vapier@gentoo.org> configure.in, localdecls.h,
214 sandbox.h:
215 uClibc doesn't support dlvsym() so add a configure check to make sure it doesn't
216 exist. Also update localdecls.h so BROKEN_RTLD_NEXT isn't defined in uClibc.
217
218 * sandbox-1.2.3 (2005/04/29)
219
220 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> configure.in:
221 Do not check for (*&#$(* CXX or F77.
222
223 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
224 Do not append '/' to pathname in filter_path() if it already ends with it.
225
226 28 Apr 2005; Mike Frysinger <vapier@gentoo.org> Makefile.am, configure.in:
227 With az's help, clean up autotools to work with cross-compiling.
228
229 * sandbox-1.2.2 (2005/04/28)
230
231 28 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
232 Only check for /dev/{null,zero} for unlink hack, else ricers using /dev/shm
233 have issues; bug #90592.
234
235 * sandbox-1.2.1 (2005/04/23)
236
237 23 Apr 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
238 getcwd.c, libsandbox.c, localdecls.h, sandbox.h, sandbox_futils.c:
239 Make sure all functions used in libsandbox.c is declared static. Define
240 SB_STATIC in localdecls.h for this. Include sandbox_futils.c rather than
241 linking with its object. Hopefully this will fix bug #90153.
242
243 * sandbox-1.2 (2005/04/23)
244
245 22 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
246 Allow lchown a symlink in write-allowed path pointing to write-denied
247 target.
248
249 21 Mar 2005; Marius Mauch <genone@gentoo.org> libsandbox.c:
250 Also show resolved symlink names in the log.
251
252 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, libsandbox.c:
253 Seems -nostdlib was the problem with the constructor/destructor - remove it
254 from Makefile.am, and change the constructor/destructor names again.
255
256 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
257 Also rename the _init() and _fini() declarations.
258
259 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
260 Fixup the constructor/destructor function names again (they should be _init()
261 and _fini() it seems, and not being called caused sandbox_lib_path to be
262 unset, and thus breaking the execve() wrapper's LD_PRELOAD protection).
263 Add both the path in given SANDBOX_x variable, as well as its symlink
264 resolved path in init_env_entries(). Modify filter_path() to be able to
265 resolve paths without resolving symlinks, as well as to be able to resolve
266 symlinks. Fix a possible segfault in check_access(). Add symlink resolving
267 to check_access() resolving bug #31019. Add 'hack' for unlink, as the fix
268 for bug #31019 cause access violations if we try to remove a symlink that is
269 not in protected path, but points to a protected path. Fix a memory leak in
270 sandbox.c (sandbox_pids_file in main()). Fix the realpath() calls in main()
271 (sandbox.c) being unchecked. Fix the debug logname not having the pid in it
272 (pid_string was uninitialized). General syntax cleanups.
273
274 09 Mar 2005; Brian Harring <ferringb@gentoo.org> sandbox.c: Fixed the
275 infamous "pids file is not a regular file" w/out newline bug.
276
277 09 Mar 2005; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in:
278 Correct libc_version path detection, since it was screwing up if libdir !=
279 "/lib/".
280
281 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
282 Hack to make sure sandboxed process cannot remove a device node, bug #79836.
283
284 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am:
285 Fix symbols.in not added to dist.
286
287 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
288 getcwd.c, libsandbox.c, sandbox.c, sandbox.h, sandbox_futils.c:
289 White space fixes.
290
291 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
292 configure.in, getcwd.c, libsandbox.c, symbols.in:
293 Fix inverse test logic in canonicalize.c, use a strncpy. Fix gcc warning in
294 getcwd.c. Add symbols.in and logic to Makefile.am to generate symbol versions
295 for glibc and other libc's that use this. Update libsandbox.c to use these
296 symbol versions if available. Fix exec wrapper to re-export LD_PRELOAD if the
297 process unset it.
298
299 01 Mar 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
300 killed off _init and _fini in favor of
301 void __attribute__ ((constructor)) init_func and
302 void __attribute__ ((destructor)) closing_func. _(init|func) were deprecated.
303
304 06 Dec 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, libsandbox.c,
305 canonicalize.c, getcwd.c: Fixed compilation *again*. Hopefully cvs is done
306 having the hick-ups.
307
308 04 Dec 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, getcwd.c,
309 Makefile.am: Fixed compilation.
310
311 01 Dec 2004; Brian Harring <ferringb@gentoo.org> aclocal.m4:
312 Gutted the bugger so it stops checking for a c++ and fortran compiler.
313 Do *not* regenerate aclocal.m4 for making a release until a better
314 solution is created.
315
316 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, sandbox_futils.c:
317 Removal of more hardcoded paths.
318
319 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in,
320 sandbox_futils.c: tweaks to install sandbox.bashrc, and use it.
321
322 19 Nov 2004; Brian Harring <ferringb@gentoo.org>:
323 Sandbox is now autotooled, create-localdecls needs to be killed and the code
324 shifted into configure.in. Currently builds *one* libsandbox.so- if multiple
325 are desired (-m64 and -m32 for amd64), the ebuild should do it (imo).
326 To get to a point of testing, automake && autoconf; created requisite files w/
327 a(utomake|clocal)-1.8, and autoconf 2.59. Installs to /usr/, instead of
328 /lib and /usr/lib/portage/bin.
329
330 14 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox.c:
331 closing out bug #70225, potential overflow of the sandbox_pids_file var.
332
333 07 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c: c99 standard,
334 (think it was at least) allows intermixing of code and data segments. bug #70351
335 should be fixed by this.
336
337 03 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox_futils.c:
338 futils fix from bug #65201 via solar, and libsandbox log path checks via #69137
339
340 02 Aug 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Code from
341 Seth Robertson that tracked down all adjuct flags for read operations that
342 do not invoke a write operation.
343
344 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
345 Another fix from jstubbs regarding a free() on a stack variable for the
346 environment -- tracking now prevents extraneous free()'s segfault.
347
348 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
349 J. Stubbs tracked down a new bug where mkdir was failing to the patch on
350 the lstat in mkdir... it now only returns 0 or -1 as documented for mkdir.
351 Also remove the errno = ESUCCESS settings as documentation points out that
352 a library isn't allowed to do that.
353
354 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Added a
355 file_security_check() function to check random potential exploits on files
356 that sandbox is to load and read -- Normally sandboxpids.tmp. This fixes
357 the 'system-crippling' exploits (bug 21923) and catches a few other
358 potential problems.
359
360 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> Makefile: Updates for
361 32/64 bit sandbox. Made CC and LD '?=' values to allow passed in CC to work.
362
363 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c:
364 bug 42048 -- Fixed the lstat/errno conditions for mkdir <caleb@g.o>.
365 Added the 64/32 bit sandbox patch for AMD64 bug 32963 <brad/azarah>.
366
367 29 Feb 2004; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c :
368 Fix permissions and group of pids file and logs. Permissions should be 0664
369 and group should be 'portage'. Bug #34260.
370
371 28 Feb 2004; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
372 Besides a small cleanup, redo how we replace LD_PRELOAD in the environ passed
373 to the real execve (in our execve wrapper). Seems that on some arches (sparc
374 among others) do not allow us to tamper with the readonly copy passed to
375 execve, so pass our own copy of the environment. Bug #42290.
376
377 11 Jan 2004; Nicholas Jones <carpaski@gentoo.org> create-decls:
378 Changed tail to head and added a notice about duration of glibc check.
379
380 21 Dec 2003; Nicholas Jones <carpaski@gentoo.org> create-decls:
381 Changed the glibc subversion check to use /usr/bin/* instead of /bin/sh
382 as there isn't a guarentee that it is dynamic.
383
384 02 Nov 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
385 If 'file' passed to before_syscall(const char *func, const char *file) is
386 invalid, we should set errno to ENOENT, and not EINVAL. This should
387 close bug #32238.
388
389 14 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
390 Fix a bug that occurs mainly on 64bit arch, where the file passed to
391 the functions we wrap, is invalid, and then cause canonicalize to pass
392 garbage to before_syscall(), thanks to great detective work from
393 Andrea Luzzardi <al@sig11.org> (bug #29846).
394
395 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
396 Add a uClibc detection patch from Peter S. Mazinger <ps.m@gmx.net>.
397
398 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
399 Fix a bug in libsandbox.c 's checking in the rename wrapper - it basically
400 only checked the destination patch, and not the source, so we could move
401 a protected file to a unprotected directory, and then delete/modify it.
402 Thanks to Andrea Luzzardi (scox) <al@sig11.org>, bug #30992, for this fix.
403
404 12 Oct 2003; Nicholas Jones <carpaski@gentoo.org> sandbox.c :
405 Added python2.3 to the predict section/variable.
406
407 28 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
408 sandbox.h, sandbox_futils.c :
409 Add support to set the pids file via SANDBOX_PIDS_FILE at startup. If
410 it is not set, it will revert to its old value.
411
412 27 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
413 Fix our mkdir wrapper to check if the dir exist, and return EEXIST if so,
414 rather than failing with a violation, bug #29748.
415
416 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
417 Fix canonicalize() to ignore calls with path = "".
418
419 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c,
420 sandbox_futils.c, canonicalize.c :
421 Once again coreutils fails, as my systems had 2.5 kernel, the getcwd system
422 call handled strings larger than PATH_MAX (bug #21766). It however does not
423 work the same on 2.4 kernels.
424
425 To fix, I added the posix implementation of getcwd() (from glibc cvs) that
426 do not need the system call. We use the default getcwd() function via a
427 wrapper (egetcwd), and then lstat the returned path. If lstat fails, it
428 means the current directory was removed, OR that the the system call for
429 getcwd failed (curious is that it do not fail and return NULL or set
430 errno, but rather just truncate the retured directory - usually from the
431 start), and if so, we use the generic getcwd() function (__egetcwd). Note
432 that we do not use the generic version all the time, as it calls lstat()
433 a great number of times, and performance degrade much.
434
435 29 Jun 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls,
436 libsandbox.c :
437 Make sure SB_PATH_MAX will not wrap. Fix two possible memory leaks.
438
439 22 Jun 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, canonicalize.c
440 create-localdecls :
441 When checking path names of files accessed, we need to canonicalize it, else
442 it may be a symlink in a 'write allowed' directory pointing to a file in a
443 directory we should not have write access to.
444
445 With something like coreutils-5.0, we have two problems:
446 1) One of the tests checks if getcwd() can return a path longer than
447 PATH_MAX. This test then tries to create a dir which even while
448 created local (mkdir("conftest2")), it ends up being resolved with
449 a name that is much larger than PATH_MAX. The problem now is that
450 canonicalize() have undefined behaviour when the path was too long
451 (returned wrongly truncated paths, etc), and pass the wrong path to
452 before_syscall() (causing the bogus sandbox violations).
453 2) The ecanonicalize() function we used, along with the canonicalize()
454 function did not support longer than PATH_MAX. This is partly a
455 cause for 1), but the error checking (rather lack of it) of calls
456 to erealpath() in canonicalize() was the prime reason for 1).
457
458 As we do not use this canonicalized name to call the function, we resolve this
459 by fixing canonicalize() to do better error checking, and ecanonicalize() as
460 well as all functions in libsandbox.c to use a PATH_MAX of 'PATH_MAX * 2'.
461 While they will resolve paths properly now, and can check if a write/read is
462 allowed, the functions called from the sandboxed environment will still work
463 as expected.
464
465 This should resolve bug #21766.
466
467 06 Apr 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
468 For some reason sandbox fails with a 'open_wr' if you run 'locale -a' under
469 it (bug #16298).
470
471 Problem is that for some reason locale fopen's locale.alias with mode "rm".
472
473 -------------------------------------------------------
474 nosferatu root # grep fopen locale.log
475 fopen("/usr/share/locale/locale.alias", "rm"ACCESS DENIED open_wr: /usr/share/locale/locale.alias
476 nosferatu root #
477 --------------------------------------------------------
478
479 I checked the source of locale, but it have fopen with mode 'r', so
480 not sure where the "rm" mode comes from. Anyhow, changed the check in
481 before_syscall_open_char() to also see mode "rm" as readonly.
482
483 23 Feb 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
484
485 Add glibc-2.3 support.
486
487 22 Feb 2003; Martin Schlemmer <azarah@gentoo.org> sandbox.c :
488
489 Some /etc/ld.so.preload fixes. Just changed the #if defines to cover all
490 operations releated to preload, as well as only try to modify ld.so.preload
491 if we can. Also modify to write the pid to /tmp/sandboxpids.tmp even when
492 not using ld.so.preload. Fix to not write this instance of sandbox's pid
493 to /tmp/sandboxpids.tmp on exit if this is not the last sandbox running.
494
495 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> Makefile :
496
497 Changed the LD to CC for hppa.
498
499 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
500
501 Killed the previous changes I made.
502
503 17 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
504
505 Added parisc to BROKEN_RTLD_ARCHLIST to see if it we can fix the relocation probs.
506
507 09 Jan 2003; J Robert Ray <jrray@gentoo.org> sandbox.c :
508
509 Don't segfault if $HOME isn't set, set $HOME to "/" instead. Fixes bug 10868.
510
511 16 Dec 2002; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
512
513 Fix memory leak for mips, bug #12236. Thanks to Torgeir Hansen <torgeir@trenger.ro>
514 for this fix.
515
516 4 Dec 2002; J Robert Ray <jrray@gentoo.org> sandbox.h sandbox_futils.c :
517
518 sandbox_futils defined a dirname() function that was masking the same
519 function in glibc and was broken (e.g.: SANDBOX_DIR was being set to
520 '/usr/lib/portage/bi/'). Fixed function to return expected results and
521 renamed it to sb_dirname() to no longer mask the glibc function. Closes bug
522 11231.
523
524 4 Dec 2002; Martin Schlemmer <azarah@gentoo.org> :
525
526 Fix a segfault in libsandbox.c if canonicalize() was called with
527 first parameter = NULL.
528
529 1 Sep 2002; Martin Schlemmer <azarah@gentoo.org> :
530
531 Fix my braindead 'return 1;' in a void function. Updated sandbox.c,
532 cleanup() for this.
533
534 Change cleanup() in sandbox.c not to exit with fail status if
535 the pidsfile is missing. We really should still display sandbox
536 violations if they occured.
537
538 31 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
539
540 Update cleanup() in sandbox.c to remove the PIDSFILE if this is
541 the last sandbox running.
542
543 25 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
544
545 Major cleanups to mainly libsandbox.c again.
546
547 22 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
548
549 Add copyrights to sandbox.h and sandbox_futils.h. If wrong, the
550 parties involved should please contact me so that we can fix it.
551
552 Add opendir wrapper to libsandbox.c.
553
554 21 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
555
556 Do some more cleanups to ecanonicalize(), as it dropped filenames in
557 rare cases (after my symlink cleanups), and caused glibc to bork.
558 These fixes went into canonicalize.c.
559
560 20 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
561
562 Fix spawn_shell() and main() in sandbox.c to properly return fail
563 status.
564
565 19 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
566
567 The new canonicalize() function in libsandbox.c also resolved symlinks,
568 which caused on cleaning sandbox errors if the symlink pointed to a
569 file in the live root. Ripped out canonicalize() and realpath() from
570 glibc; removed the symlink stuff, and changed them to ecanonicalize()
571 and erealpath().
572
573 18 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
574
575 Ripped out all the wrappers, and implemented those of InstallWatch.
576 Losts of cleanups and bugfixes. Implement a execve that forces
577 $LIBSANDBOX in $LD_PRELOAD. We can now thus do away with the feared
578 /etc/ld.so.preload (*g*) ... Made the needed changes to sandbox.c,
579 sandbox.h and sandbox_futils.c. Rewrote the Makefile for most
580 parts; it now have an install target.
581
582 Reformat the whole thing to look somewhat like the reworked sandbox.c
583 and new sandbox.h and sandbox_futils.c from:
584
585 Brad House <brad@mainstreetsoftworks.com>.
586
587 Additional Copyrights now due to the InstallWatch code:
588
589 Copyright (C) 1998-9 Pancrazio `Ezio' de Mauro <p@demauro.net>

Properties

Name Value
svn:eol-style native
svn:keywords Author Date Id Revision

  ViewVC Help
Powered by ViewVC 1.1.20