/[path-sandbox]/trunk/ChangeLog
Gentoo

Contents of /trunk/ChangeLog

Parent Directory Parent Directory | Revision Log Revision Log


Revision 151 - (show annotations) (download)
Fri Jul 22 08:13:25 2005 UTC (9 years ago) by azarah
File size: 27278 byte(s)
Print all logging to stderr, bug #90343, comment #15, by Zac Medico.
1 # ChangeLog for Path Sandbox
2 # Copyright 1999-2005 Gentoo Foundation; Distributed under the GPL v2
3 # $Header$
4
5 22 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.h:
6
7 Print all logging to stderr, bug #90343, comment #15, by Zac Medico.
8
9 * sandbox-1.2.11 (2005/07/14)
10
11 14 July 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c:
12 Fix getcwd, bug #98419.
13
14 08 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c,
15 libsandbox.c:
16 - Try to cleanup and make error handling/printing consistent.
17 - Remove old logs if present and conflicting with current.
18 - Fix compile error with previous change, and return rather then exit().
19
20 07 July 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
21 sandbox.h, sandbox_futils.c:
22 - Fix possible segfault in env init code.
23 - Major cleanup of sandbox_futils.c. Removed most of the functions as we now
24 write to /var/log/sandbox/, so in theory do not need all that.
25 - Redo the interface of the get_* functions so that we do not leak memory.
26 - Remove sandbox_dir and co - we are not using it anymore.
27 - Remove unused includes and variables.
28 - Only declare functions in sandbox_futils.c that are used in libsandbox.c when
29 OUTSIDE_LIBSANDBOX is not defined.
30 - Cleanup access/log printing. Make access printing honour NOCOLOR. Fix log
31 printing's last line not honouring NOCOLOR.
32
33 06 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.h, sandbox_futils.c,
34 libsandbox.c:
35 - Change log dir to /var/log/sandbox/. Make sure the sandboxed process cannot
36 write to it.
37 - Clean up logging in libsandbox.c, and hopefully make it more consistant.
38 - Add check_prefixes() with major cleanup on check_access().
39 - Cleanup init_env_entries() and check_prefixes().
40
41 05 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
42 sandbox_futils.c, libsandbox.c:
43 Remove unused 'pids file' code.
44
45 * sandbox-1.2.10 (2005/07/03)
46
47 03 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
48 Add PREDICT items for nss-db, bug #92079. Patch from Robin Johnson.
49
50 17 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
51 General cleanups:
52 - Remove fooling around with exit codes - we error out on presence of a log
53 anyhow.
54 - Move get_sandbox_*_envvar() to sandbox_setup_environ(), as its more
55 appropriate there.
56
57 12 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
58 Cleanup the fail_nametoolong stuff a bit more.
59
60 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
61 Remove hopefully the last ld.so.preload bits we do not use anymore.
62
63 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
64 Remove the unneeded canonicalize() calls in the wrappers - we do it anyhow
65 in check_syscall(). Should speed things up a bit (at least for the getcwd()
66 and long path name test it goes down to under a second, and not 10+ seconds
67 like before). Also warn if we skip checking due to the canonicalized path
68 being too long.
69
70 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
71 More comment/readability cleanups.
72
73 10 June 2005; Martin Schlemmer <azarah@gentoo.org> canonicalize.c, getcwd.c,
74 sandbox_futils.c, libsandbox.c:
75 Some strncpy/strncat and other cleanups.
76
77 * sandbox-1.2.9 (2005/06/09)
78
79 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
80 Move symlink hack down a bit to try and minimize on the amount of lstat()
81 calls we do.
82
83 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
84 Add hack to allow writing to /proc/self/fd (or /dev/fd), bug #91516.
85
86 09 June 2005; Martin Schlemmer <azarah@gentoo.org> symbols.in, libsandbox.c:
87 Add wrapper for access() function, bug #85413.
88
89 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c:
90 Use generic getcwd() implementation from uclibc - should be more portable
91 and looks a bit cleaner.
92
93 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c:
94 Make sure our true_* pointers are initialized to NULL, and that we check for
95 all references that they are valid.
96
97 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
98 Be default we will fail if the path name we try to canonicalize is too long.
99 This however could cause issues with some things (bug #94630 and #21766), so
100 if fail_nametoolong == 0, canonicalize() will return a null length string and
101 do not fail.
102
103 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c:
104 Do not abort if TMPDIR is not valid, but rather use '/tmp', bug #94360. Also
105 make sure we re-export the new TMPDIR environment variable.
106
107 08 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
108 Fix incorrect free of non-malloc'd array, bug #92313 and #94020. Fix noted
109 by Marcus D. Hanwell <cryos@gentoo.org>.
110
111 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
112 Add /dev/console to write list, bug #38588.
113
114 * sandbox-1.2.8 (2005/05/13)
115
116 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
117 sandbox.h, sandbox_futils.c:
118 General cleanups.
119
120 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
121 sandbox.h:
122 Various LD_PRELOAD cleanups. Do not unset LD_PRELOAD for parent.
123
124 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
125 sandbox.h, sandbox_futils.c:
126 Modify get_sandbox_pids_file(), get_sandbox_log() and get_sandbox_debug_log()
127 to use TMPDIR if present in environment.
128
129 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
130 Remove sandbox_log_file from main() as its no longer used.
131
132 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
133 sandbox_futils.c:
134 Add get_sandbox_debug_log(), and use it (add behaviour similar to SANDBOX_LOG
135 if already exported when sandbox started). Fix get_sandbox_log() and new
136 get_sandbox_debug_log() to not use already exported environment variables if
137 they have '/' in them. Use snprintf()'s instead of strncpy()'s. More
138 SB_PATH_MAX fixes.
139
140 * sandbox-1.2.7 (2005/05/12)
141
142 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
143 sandbox_futils.c:
144 More path limit fixes. Declare SB_BUF_LEN global and use it where needed.
145
146 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
147 Fix paths limited to 255 chars. Fix get_sandbox_dir() returning a string
148 with '(null)' in it if we did not call sandbox with absolute path.
149
150 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
151 Set SANDBOX_ON *before* doing the child's env stuff, else its not set
152 for the child.
153
154 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
155 Remove global preload_adaptable as it is no longer used.
156
157 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
158 Rewrite environment stuff to only be set when execve'ing the child process
159 to try and avoid issues like bug #91541 that causes sandbox to crash if
160 we set LD_PRELOAD sandbox side already.
161
162 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
163 Move print_sandbox_log() up to make things neater.
164
165 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
166 Remove load_preload_libs(), as its not used anymore.
167
168 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
169 Remove NO_FORK stuff, as its not used, and 'strace -f' works just fine.
170
171 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
172 Remove USE_SYSTEM_SHELL stuff, as it is not secure, and not in use.
173
174 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
175 Remove ld.so.preload crap - we are not going to use it again.
176
177 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
178 Fix typo in code that checks if we got valid group information, causing a
179 segmentation fault, bug #91637.
180
181 * sandbox-1.2.6 (2005/05/10)
182
183 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
184 Do not use LD_PRELOAD if it contains libtsocks.so, as it breaks sandbox
185 for some odd reason, bug #91541.
186
187 09 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
188 Fix typo (sizeof -> strlen).
189
190 08 May 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
191 rewrote the sbcontext caching code so it accounts for env changes since lib
192 initialization.
193
194 05 May 2005; Martin Schlemmer <azarah@gentoo.org> configure.in, libctest.c:
195 We create libctest.c via configure, so no need to keep it around. Do some
196 cleanup related to libctest.c and libctest during configure.
197
198 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
199 Add rename support of symlinks pointing to protected files/directories.
200
201 * sandbox-1.2.5 (2005/05/04)
202
203 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
204 sandbox.bashrc:
205 Do not reset already set LD_PRELOAD when starting sandbox. If LD_PRELOAD is
206 already set, init of the env vars fails for some reason, so do this later on,
207 and do not warn (bug #91431).
208
209 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
210 sandbox.bashrc:
211 Fixup sandbox and sandbox.bashrc to call bash with the proper .bashrc.
212
213 * sandbox-1.2.4 (2005/05/03)
214
215 03 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
216 Do not init the env entries with each call, as it creates too many calls to
217 lstat, etc. Should speedup things a bit, bug #91040.
218
219 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
220 Add /dev/pty to default write list. Noticed by Morfic.
221
222 02 May 2005; Mike Frysinger <vapier@gentoo.org> configure.in, localdecls.h,
223 sandbox.h:
224 uClibc doesn't support dlvsym() so add a configure check to make sure it doesn't
225 exist. Also update localdecls.h so BROKEN_RTLD_NEXT isn't defined in uClibc.
226
227 * sandbox-1.2.3 (2005/04/29)
228
229 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> configure.in:
230 Do not check for (*&#$(* CXX or F77.
231
232 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
233 Do not append '/' to pathname in filter_path() if it already ends with it.
234
235 28 Apr 2005; Mike Frysinger <vapier@gentoo.org> Makefile.am, configure.in:
236 With az's help, clean up autotools to work with cross-compiling.
237
238 * sandbox-1.2.2 (2005/04/28)
239
240 28 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
241 Only check for /dev/{null,zero} for unlink hack, else ricers using /dev/shm
242 have issues; bug #90592.
243
244 * sandbox-1.2.1 (2005/04/23)
245
246 23 Apr 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
247 getcwd.c, libsandbox.c, localdecls.h, sandbox.h, sandbox_futils.c:
248 Make sure all functions used in libsandbox.c is declared static. Define
249 SB_STATIC in localdecls.h for this. Include sandbox_futils.c rather than
250 linking with its object. Hopefully this will fix bug #90153.
251
252 * sandbox-1.2 (2005/04/23)
253
254 22 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
255 Allow lchown a symlink in write-allowed path pointing to write-denied
256 target.
257
258 21 Mar 2005; Marius Mauch <genone@gentoo.org> libsandbox.c:
259 Also show resolved symlink names in the log.
260
261 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, libsandbox.c:
262 Seems -nostdlib was the problem with the constructor/destructor - remove it
263 from Makefile.am, and change the constructor/destructor names again.
264
265 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
266 Also rename the _init() and _fini() declarations.
267
268 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
269 Fixup the constructor/destructor function names again (they should be _init()
270 and _fini() it seems, and not being called caused sandbox_lib_path to be
271 unset, and thus breaking the execve() wrapper's LD_PRELOAD protection).
272 Add both the path in given SANDBOX_x variable, as well as its symlink
273 resolved path in init_env_entries(). Modify filter_path() to be able to
274 resolve paths without resolving symlinks, as well as to be able to resolve
275 symlinks. Fix a possible segfault in check_access(). Add symlink resolving
276 to check_access() resolving bug #31019. Add 'hack' for unlink, as the fix
277 for bug #31019 cause access violations if we try to remove a symlink that is
278 not in protected path, but points to a protected path. Fix a memory leak in
279 sandbox.c (sandbox_pids_file in main()). Fix the realpath() calls in main()
280 (sandbox.c) being unchecked. Fix the debug logname not having the pid in it
281 (pid_string was uninitialized). General syntax cleanups.
282
283 09 Mar 2005; Brian Harring <ferringb@gentoo.org> sandbox.c: Fixed the
284 infamous "pids file is not a regular file" w/out newline bug.
285
286 09 Mar 2005; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in:
287 Correct libc_version path detection, since it was screwing up if libdir !=
288 "/lib/".
289
290 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
291 Hack to make sure sandboxed process cannot remove a device node, bug #79836.
292
293 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am:
294 Fix symbols.in not added to dist.
295
296 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
297 getcwd.c, libsandbox.c, sandbox.c, sandbox.h, sandbox_futils.c:
298 White space fixes.
299
300 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
301 configure.in, getcwd.c, libsandbox.c, symbols.in:
302 Fix inverse test logic in canonicalize.c, use a strncpy. Fix gcc warning in
303 getcwd.c. Add symbols.in and logic to Makefile.am to generate symbol versions
304 for glibc and other libc's that use this. Update libsandbox.c to use these
305 symbol versions if available. Fix exec wrapper to re-export LD_PRELOAD if the
306 process unset it.
307
308 01 Mar 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
309 killed off _init and _fini in favor of
310 void __attribute__ ((constructor)) init_func and
311 void __attribute__ ((destructor)) closing_func. _(init|func) were deprecated.
312
313 06 Dec 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, libsandbox.c,
314 canonicalize.c, getcwd.c: Fixed compilation *again*. Hopefully cvs is done
315 having the hick-ups.
316
317 04 Dec 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, getcwd.c,
318 Makefile.am: Fixed compilation.
319
320 01 Dec 2004; Brian Harring <ferringb@gentoo.org> aclocal.m4:
321 Gutted the bugger so it stops checking for a c++ and fortran compiler.
322 Do *not* regenerate aclocal.m4 for making a release until a better
323 solution is created.
324
325 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, sandbox_futils.c:
326 Removal of more hardcoded paths.
327
328 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in,
329 sandbox_futils.c: tweaks to install sandbox.bashrc, and use it.
330
331 19 Nov 2004; Brian Harring <ferringb@gentoo.org>:
332 Sandbox is now autotooled, create-localdecls needs to be killed and the code
333 shifted into configure.in. Currently builds *one* libsandbox.so- if multiple
334 are desired (-m64 and -m32 for amd64), the ebuild should do it (imo).
335 To get to a point of testing, automake && autoconf; created requisite files w/
336 a(utomake|clocal)-1.8, and autoconf 2.59. Installs to /usr/, instead of
337 /lib and /usr/lib/portage/bin.
338
339 14 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox.c:
340 closing out bug #70225, potential overflow of the sandbox_pids_file var.
341
342 07 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c: c99 standard,
343 (think it was at least) allows intermixing of code and data segments. bug #70351
344 should be fixed by this.
345
346 03 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox_futils.c:
347 futils fix from bug #65201 via solar, and libsandbox log path checks via #69137
348
349 02 Aug 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Code from
350 Seth Robertson that tracked down all adjuct flags for read operations that
351 do not invoke a write operation.
352
353 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
354 Another fix from jstubbs regarding a free() on a stack variable for the
355 environment -- tracking now prevents extraneous free()'s segfault.
356
357 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
358 J. Stubbs tracked down a new bug where mkdir was failing to the patch on
359 the lstat in mkdir... it now only returns 0 or -1 as documented for mkdir.
360 Also remove the errno = ESUCCESS settings as documentation points out that
361 a library isn't allowed to do that.
362
363 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Added a
364 file_security_check() function to check random potential exploits on files
365 that sandbox is to load and read -- Normally sandboxpids.tmp. This fixes
366 the 'system-crippling' exploits (bug 21923) and catches a few other
367 potential problems.
368
369 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> Makefile: Updates for
370 32/64 bit sandbox. Made CC and LD '?=' values to allow passed in CC to work.
371
372 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c:
373 bug 42048 -- Fixed the lstat/errno conditions for mkdir <caleb@g.o>.
374 Added the 64/32 bit sandbox patch for AMD64 bug 32963 <brad/azarah>.
375
376 29 Feb 2004; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c :
377 Fix permissions and group of pids file and logs. Permissions should be 0664
378 and group should be 'portage'. Bug #34260.
379
380 28 Feb 2004; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
381 Besides a small cleanup, redo how we replace LD_PRELOAD in the environ passed
382 to the real execve (in our execve wrapper). Seems that on some arches (sparc
383 among others) do not allow us to tamper with the readonly copy passed to
384 execve, so pass our own copy of the environment. Bug #42290.
385
386 11 Jan 2004; Nicholas Jones <carpaski@gentoo.org> create-decls:
387 Changed tail to head and added a notice about duration of glibc check.
388
389 21 Dec 2003; Nicholas Jones <carpaski@gentoo.org> create-decls:
390 Changed the glibc subversion check to use /usr/bin/* instead of /bin/sh
391 as there isn't a guarentee that it is dynamic.
392
393 02 Nov 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
394 If 'file' passed to before_syscall(const char *func, const char *file) is
395 invalid, we should set errno to ENOENT, and not EINVAL. This should
396 close bug #32238.
397
398 14 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
399 Fix a bug that occurs mainly on 64bit arch, where the file passed to
400 the functions we wrap, is invalid, and then cause canonicalize to pass
401 garbage to before_syscall(), thanks to great detective work from
402 Andrea Luzzardi <al@sig11.org> (bug #29846).
403
404 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
405 Add a uClibc detection patch from Peter S. Mazinger <ps.m@gmx.net>.
406
407 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
408 Fix a bug in libsandbox.c 's checking in the rename wrapper - it basically
409 only checked the destination patch, and not the source, so we could move
410 a protected file to a unprotected directory, and then delete/modify it.
411 Thanks to Andrea Luzzardi (scox) <al@sig11.org>, bug #30992, for this fix.
412
413 12 Oct 2003; Nicholas Jones <carpaski@gentoo.org> sandbox.c :
414 Added python2.3 to the predict section/variable.
415
416 28 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
417 sandbox.h, sandbox_futils.c :
418 Add support to set the pids file via SANDBOX_PIDS_FILE at startup. If
419 it is not set, it will revert to its old value.
420
421 27 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
422 Fix our mkdir wrapper to check if the dir exist, and return EEXIST if so,
423 rather than failing with a violation, bug #29748.
424
425 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
426 Fix canonicalize() to ignore calls with path = "".
427
428 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c,
429 sandbox_futils.c, canonicalize.c :
430 Once again coreutils fails, as my systems had 2.5 kernel, the getcwd system
431 call handled strings larger than PATH_MAX (bug #21766). It however does not
432 work the same on 2.4 kernels.
433
434 To fix, I added the posix implementation of getcwd() (from glibc cvs) that
435 do not need the system call. We use the default getcwd() function via a
436 wrapper (egetcwd), and then lstat the returned path. If lstat fails, it
437 means the current directory was removed, OR that the the system call for
438 getcwd failed (curious is that it do not fail and return NULL or set
439 errno, but rather just truncate the retured directory - usually from the
440 start), and if so, we use the generic getcwd() function (__egetcwd). Note
441 that we do not use the generic version all the time, as it calls lstat()
442 a great number of times, and performance degrade much.
443
444 29 Jun 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls,
445 libsandbox.c :
446 Make sure SB_PATH_MAX will not wrap. Fix two possible memory leaks.
447
448 22 Jun 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, canonicalize.c
449 create-localdecls :
450 When checking path names of files accessed, we need to canonicalize it, else
451 it may be a symlink in a 'write allowed' directory pointing to a file in a
452 directory we should not have write access to.
453
454 With something like coreutils-5.0, we have two problems:
455 1) One of the tests checks if getcwd() can return a path longer than
456 PATH_MAX. This test then tries to create a dir which even while
457 created local (mkdir("conftest2")), it ends up being resolved with
458 a name that is much larger than PATH_MAX. The problem now is that
459 canonicalize() have undefined behaviour when the path was too long
460 (returned wrongly truncated paths, etc), and pass the wrong path to
461 before_syscall() (causing the bogus sandbox violations).
462 2) The ecanonicalize() function we used, along with the canonicalize()
463 function did not support longer than PATH_MAX. This is partly a
464 cause for 1), but the error checking (rather lack of it) of calls
465 to erealpath() in canonicalize() was the prime reason for 1).
466
467 As we do not use this canonicalized name to call the function, we resolve this
468 by fixing canonicalize() to do better error checking, and ecanonicalize() as
469 well as all functions in libsandbox.c to use a PATH_MAX of 'PATH_MAX * 2'.
470 While they will resolve paths properly now, and can check if a write/read is
471 allowed, the functions called from the sandboxed environment will still work
472 as expected.
473
474 This should resolve bug #21766.
475
476 06 Apr 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
477 For some reason sandbox fails with a 'open_wr' if you run 'locale -a' under
478 it (bug #16298).
479
480 Problem is that for some reason locale fopen's locale.alias with mode "rm".
481
482 -------------------------------------------------------
483 nosferatu root # grep fopen locale.log
484 fopen("/usr/share/locale/locale.alias", "rm"ACCESS DENIED open_wr: /usr/share/locale/locale.alias
485 nosferatu root #
486 --------------------------------------------------------
487
488 I checked the source of locale, but it have fopen with mode 'r', so
489 not sure where the "rm" mode comes from. Anyhow, changed the check in
490 before_syscall_open_char() to also see mode "rm" as readonly.
491
492 23 Feb 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
493
494 Add glibc-2.3 support.
495
496 22 Feb 2003; Martin Schlemmer <azarah@gentoo.org> sandbox.c :
497
498 Some /etc/ld.so.preload fixes. Just changed the #if defines to cover all
499 operations releated to preload, as well as only try to modify ld.so.preload
500 if we can. Also modify to write the pid to /tmp/sandboxpids.tmp even when
501 not using ld.so.preload. Fix to not write this instance of sandbox's pid
502 to /tmp/sandboxpids.tmp on exit if this is not the last sandbox running.
503
504 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> Makefile :
505
506 Changed the LD to CC for hppa.
507
508 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
509
510 Killed the previous changes I made.
511
512 17 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
513
514 Added parisc to BROKEN_RTLD_ARCHLIST to see if it we can fix the relocation probs.
515
516 09 Jan 2003; J Robert Ray <jrray@gentoo.org> sandbox.c :
517
518 Don't segfault if $HOME isn't set, set $HOME to "/" instead. Fixes bug 10868.
519
520 16 Dec 2002; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
521
522 Fix memory leak for mips, bug #12236. Thanks to Torgeir Hansen <torgeir@trenger.ro>
523 for this fix.
524
525 4 Dec 2002; J Robert Ray <jrray@gentoo.org> sandbox.h sandbox_futils.c :
526
527 sandbox_futils defined a dirname() function that was masking the same
528 function in glibc and was broken (e.g.: SANDBOX_DIR was being set to
529 '/usr/lib/portage/bi/'). Fixed function to return expected results and
530 renamed it to sb_dirname() to no longer mask the glibc function. Closes bug
531 11231.
532
533 4 Dec 2002; Martin Schlemmer <azarah@gentoo.org> :
534
535 Fix a segfault in libsandbox.c if canonicalize() was called with
536 first parameter = NULL.
537
538 1 Sep 2002; Martin Schlemmer <azarah@gentoo.org> :
539
540 Fix my braindead 'return 1;' in a void function. Updated sandbox.c,
541 cleanup() for this.
542
543 Change cleanup() in sandbox.c not to exit with fail status if
544 the pidsfile is missing. We really should still display sandbox
545 violations if they occured.
546
547 31 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
548
549 Update cleanup() in sandbox.c to remove the PIDSFILE if this is
550 the last sandbox running.
551
552 25 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
553
554 Major cleanups to mainly libsandbox.c again.
555
556 22 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
557
558 Add copyrights to sandbox.h and sandbox_futils.h. If wrong, the
559 parties involved should please contact me so that we can fix it.
560
561 Add opendir wrapper to libsandbox.c.
562
563 21 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
564
565 Do some more cleanups to ecanonicalize(), as it dropped filenames in
566 rare cases (after my symlink cleanups), and caused glibc to bork.
567 These fixes went into canonicalize.c.
568
569 20 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
570
571 Fix spawn_shell() and main() in sandbox.c to properly return fail
572 status.
573
574 19 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
575
576 The new canonicalize() function in libsandbox.c also resolved symlinks,
577 which caused on cleaning sandbox errors if the symlink pointed to a
578 file in the live root. Ripped out canonicalize() and realpath() from
579 glibc; removed the symlink stuff, and changed them to ecanonicalize()
580 and erealpath().
581
582 18 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
583
584 Ripped out all the wrappers, and implemented those of InstallWatch.
585 Losts of cleanups and bugfixes. Implement a execve that forces
586 $LIBSANDBOX in $LD_PRELOAD. We can now thus do away with the feared
587 /etc/ld.so.preload (*g*) ... Made the needed changes to sandbox.c,
588 sandbox.h and sandbox_futils.c. Rewrote the Makefile for most
589 parts; it now have an install target.
590
591 Reformat the whole thing to look somewhat like the reworked sandbox.c
592 and new sandbox.h and sandbox_futils.c from:
593
594 Brad House <brad@mainstreetsoftworks.com>.
595
596 Additional Copyrights now due to the InstallWatch code:
597
598 Copyright (C) 1998-9 Pancrazio `Ezio' de Mauro <p@demauro.net>

Properties

Name Value
svn:eol-style native
svn:keywords Author Date Id Revision

  ViewVC Help
Powered by ViewVC 1.1.20