/[path-sandbox]/trunk/ChangeLog
Gentoo

Contents of /trunk/ChangeLog

Parent Directory Parent Directory | Revision Log Revision Log


Revision 155 - (show annotations) (download)
Mon Aug 1 14:02:17 2005 UTC (8 years, 8 months ago) by azarah
File size: 27769 byte(s)
Add /dev/tts to write permit, bug #42809.
1 # ChangeLog for Path Sandbox
2 # Copyright 1999-2005 Gentoo Foundation; Distributed under the GPL v2
3 # $Header$
4
5 01 Aug 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
6
7 Still do normal log if debugging is requested.
8
9 Add support for SANDBOX_VERBOSE (enabled by default). Adjust SANDBOX_DEBUG
10 to only enable if equal to "1" or "yes".
11
12 Add /dev/tts to write permit, bug #42809.
13
14 27 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
15 sandbox_futils.c:
16
17 Do not resolve symlinks in PORTAGE_TMPDIR in sandbox .. we will handle that
18 in libsandbox .. bug #100309.
19
20 22 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.h:
21
22 Print all logging to stderr, bug #90343, comment #15, by Zac Medico.
23
24 * sandbox-1.2.11 (2005/07/14)
25
26 14 July 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c:
27 Fix getcwd, bug #98419.
28
29 08 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c,
30 libsandbox.c:
31 - Try to cleanup and make error handling/printing consistent.
32 - Remove old logs if present and conflicting with current.
33 - Fix compile error with previous change, and return rather then exit().
34
35 07 July 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
36 sandbox.h, sandbox_futils.c:
37 - Fix possible segfault in env init code.
38 - Major cleanup of sandbox_futils.c. Removed most of the functions as we now
39 write to /var/log/sandbox/, so in theory do not need all that.
40 - Redo the interface of the get_* functions so that we do not leak memory.
41 - Remove sandbox_dir and co - we are not using it anymore.
42 - Remove unused includes and variables.
43 - Only declare functions in sandbox_futils.c that are used in libsandbox.c when
44 OUTSIDE_LIBSANDBOX is not defined.
45 - Cleanup access/log printing. Make access printing honour NOCOLOR. Fix log
46 printing's last line not honouring NOCOLOR.
47
48 06 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.h, sandbox_futils.c,
49 libsandbox.c:
50 - Change log dir to /var/log/sandbox/. Make sure the sandboxed process cannot
51 write to it.
52 - Clean up logging in libsandbox.c, and hopefully make it more consistant.
53 - Add check_prefixes() with major cleanup on check_access().
54 - Cleanup init_env_entries() and check_prefixes().
55
56 05 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
57 sandbox_futils.c, libsandbox.c:
58 Remove unused 'pids file' code.
59
60 * sandbox-1.2.10 (2005/07/03)
61
62 03 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
63 Add PREDICT items for nss-db, bug #92079. Patch from Robin Johnson.
64
65 17 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
66 General cleanups:
67 - Remove fooling around with exit codes - we error out on presence of a log
68 anyhow.
69 - Move get_sandbox_*_envvar() to sandbox_setup_environ(), as its more
70 appropriate there.
71
72 12 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
73 Cleanup the fail_nametoolong stuff a bit more.
74
75 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
76 Remove hopefully the last ld.so.preload bits we do not use anymore.
77
78 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
79 Remove the unneeded canonicalize() calls in the wrappers - we do it anyhow
80 in check_syscall(). Should speed things up a bit (at least for the getcwd()
81 and long path name test it goes down to under a second, and not 10+ seconds
82 like before). Also warn if we skip checking due to the canonicalized path
83 being too long.
84
85 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
86 More comment/readability cleanups.
87
88 10 June 2005; Martin Schlemmer <azarah@gentoo.org> canonicalize.c, getcwd.c,
89 sandbox_futils.c, libsandbox.c:
90 Some strncpy/strncat and other cleanups.
91
92 * sandbox-1.2.9 (2005/06/09)
93
94 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
95 Move symlink hack down a bit to try and minimize on the amount of lstat()
96 calls we do.
97
98 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
99 Add hack to allow writing to /proc/self/fd (or /dev/fd), bug #91516.
100
101 09 June 2005; Martin Schlemmer <azarah@gentoo.org> symbols.in, libsandbox.c:
102 Add wrapper for access() function, bug #85413.
103
104 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c:
105 Use generic getcwd() implementation from uclibc - should be more portable
106 and looks a bit cleaner.
107
108 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c:
109 Make sure our true_* pointers are initialized to NULL, and that we check for
110 all references that they are valid.
111
112 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
113 Be default we will fail if the path name we try to canonicalize is too long.
114 This however could cause issues with some things (bug #94630 and #21766), so
115 if fail_nametoolong == 0, canonicalize() will return a null length string and
116 do not fail.
117
118 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c:
119 Do not abort if TMPDIR is not valid, but rather use '/tmp', bug #94360. Also
120 make sure we re-export the new TMPDIR environment variable.
121
122 08 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
123 Fix incorrect free of non-malloc'd array, bug #92313 and #94020. Fix noted
124 by Marcus D. Hanwell <cryos@gentoo.org>.
125
126 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
127 Add /dev/console to write list, bug #38588.
128
129 * sandbox-1.2.8 (2005/05/13)
130
131 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
132 sandbox.h, sandbox_futils.c:
133 General cleanups.
134
135 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
136 sandbox.h:
137 Various LD_PRELOAD cleanups. Do not unset LD_PRELOAD for parent.
138
139 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
140 sandbox.h, sandbox_futils.c:
141 Modify get_sandbox_pids_file(), get_sandbox_log() and get_sandbox_debug_log()
142 to use TMPDIR if present in environment.
143
144 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
145 Remove sandbox_log_file from main() as its no longer used.
146
147 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
148 sandbox_futils.c:
149 Add get_sandbox_debug_log(), and use it (add behaviour similar to SANDBOX_LOG
150 if already exported when sandbox started). Fix get_sandbox_log() and new
151 get_sandbox_debug_log() to not use already exported environment variables if
152 they have '/' in them. Use snprintf()'s instead of strncpy()'s. More
153 SB_PATH_MAX fixes.
154
155 * sandbox-1.2.7 (2005/05/12)
156
157 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
158 sandbox_futils.c:
159 More path limit fixes. Declare SB_BUF_LEN global and use it where needed.
160
161 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
162 Fix paths limited to 255 chars. Fix get_sandbox_dir() returning a string
163 with '(null)' in it if we did not call sandbox with absolute path.
164
165 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
166 Set SANDBOX_ON *before* doing the child's env stuff, else its not set
167 for the child.
168
169 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
170 Remove global preload_adaptable as it is no longer used.
171
172 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
173 Rewrite environment stuff to only be set when execve'ing the child process
174 to try and avoid issues like bug #91541 that causes sandbox to crash if
175 we set LD_PRELOAD sandbox side already.
176
177 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
178 Move print_sandbox_log() up to make things neater.
179
180 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
181 Remove load_preload_libs(), as its not used anymore.
182
183 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
184 Remove NO_FORK stuff, as its not used, and 'strace -f' works just fine.
185
186 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
187 Remove USE_SYSTEM_SHELL stuff, as it is not secure, and not in use.
188
189 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
190 Remove ld.so.preload crap - we are not going to use it again.
191
192 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
193 Fix typo in code that checks if we got valid group information, causing a
194 segmentation fault, bug #91637.
195
196 * sandbox-1.2.6 (2005/05/10)
197
198 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
199 Do not use LD_PRELOAD if it contains libtsocks.so, as it breaks sandbox
200 for some odd reason, bug #91541.
201
202 09 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
203 Fix typo (sizeof -> strlen).
204
205 08 May 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
206 rewrote the sbcontext caching code so it accounts for env changes since lib
207 initialization.
208
209 05 May 2005; Martin Schlemmer <azarah@gentoo.org> configure.in, libctest.c:
210 We create libctest.c via configure, so no need to keep it around. Do some
211 cleanup related to libctest.c and libctest during configure.
212
213 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
214 Add rename support of symlinks pointing to protected files/directories.
215
216 * sandbox-1.2.5 (2005/05/04)
217
218 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
219 sandbox.bashrc:
220 Do not reset already set LD_PRELOAD when starting sandbox. If LD_PRELOAD is
221 already set, init of the env vars fails for some reason, so do this later on,
222 and do not warn (bug #91431).
223
224 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
225 sandbox.bashrc:
226 Fixup sandbox and sandbox.bashrc to call bash with the proper .bashrc.
227
228 * sandbox-1.2.4 (2005/05/03)
229
230 03 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
231 Do not init the env entries with each call, as it creates too many calls to
232 lstat, etc. Should speedup things a bit, bug #91040.
233
234 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
235 Add /dev/pty to default write list. Noticed by Morfic.
236
237 02 May 2005; Mike Frysinger <vapier@gentoo.org> configure.in, localdecls.h,
238 sandbox.h:
239 uClibc doesn't support dlvsym() so add a configure check to make sure it doesn't
240 exist. Also update localdecls.h so BROKEN_RTLD_NEXT isn't defined in uClibc.
241
242 * sandbox-1.2.3 (2005/04/29)
243
244 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> configure.in:
245 Do not check for (*&#$(* CXX or F77.
246
247 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
248 Do not append '/' to pathname in filter_path() if it already ends with it.
249
250 28 Apr 2005; Mike Frysinger <vapier@gentoo.org> Makefile.am, configure.in:
251 With az's help, clean up autotools to work with cross-compiling.
252
253 * sandbox-1.2.2 (2005/04/28)
254
255 28 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
256 Only check for /dev/{null,zero} for unlink hack, else ricers using /dev/shm
257 have issues; bug #90592.
258
259 * sandbox-1.2.1 (2005/04/23)
260
261 23 Apr 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
262 getcwd.c, libsandbox.c, localdecls.h, sandbox.h, sandbox_futils.c:
263 Make sure all functions used in libsandbox.c is declared static. Define
264 SB_STATIC in localdecls.h for this. Include sandbox_futils.c rather than
265 linking with its object. Hopefully this will fix bug #90153.
266
267 * sandbox-1.2 (2005/04/23)
268
269 22 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
270 Allow lchown a symlink in write-allowed path pointing to write-denied
271 target.
272
273 21 Mar 2005; Marius Mauch <genone@gentoo.org> libsandbox.c:
274 Also show resolved symlink names in the log.
275
276 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, libsandbox.c:
277 Seems -nostdlib was the problem with the constructor/destructor - remove it
278 from Makefile.am, and change the constructor/destructor names again.
279
280 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
281 Also rename the _init() and _fini() declarations.
282
283 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
284 Fixup the constructor/destructor function names again (they should be _init()
285 and _fini() it seems, and not being called caused sandbox_lib_path to be
286 unset, and thus breaking the execve() wrapper's LD_PRELOAD protection).
287 Add both the path in given SANDBOX_x variable, as well as its symlink
288 resolved path in init_env_entries(). Modify filter_path() to be able to
289 resolve paths without resolving symlinks, as well as to be able to resolve
290 symlinks. Fix a possible segfault in check_access(). Add symlink resolving
291 to check_access() resolving bug #31019. Add 'hack' for unlink, as the fix
292 for bug #31019 cause access violations if we try to remove a symlink that is
293 not in protected path, but points to a protected path. Fix a memory leak in
294 sandbox.c (sandbox_pids_file in main()). Fix the realpath() calls in main()
295 (sandbox.c) being unchecked. Fix the debug logname not having the pid in it
296 (pid_string was uninitialized). General syntax cleanups.
297
298 09 Mar 2005; Brian Harring <ferringb@gentoo.org> sandbox.c: Fixed the
299 infamous "pids file is not a regular file" w/out newline bug.
300
301 09 Mar 2005; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in:
302 Correct libc_version path detection, since it was screwing up if libdir !=
303 "/lib/".
304
305 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
306 Hack to make sure sandboxed process cannot remove a device node, bug #79836.
307
308 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am:
309 Fix symbols.in not added to dist.
310
311 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
312 getcwd.c, libsandbox.c, sandbox.c, sandbox.h, sandbox_futils.c:
313 White space fixes.
314
315 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
316 configure.in, getcwd.c, libsandbox.c, symbols.in:
317 Fix inverse test logic in canonicalize.c, use a strncpy. Fix gcc warning in
318 getcwd.c. Add symbols.in and logic to Makefile.am to generate symbol versions
319 for glibc and other libc's that use this. Update libsandbox.c to use these
320 symbol versions if available. Fix exec wrapper to re-export LD_PRELOAD if the
321 process unset it.
322
323 01 Mar 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
324 killed off _init and _fini in favor of
325 void __attribute__ ((constructor)) init_func and
326 void __attribute__ ((destructor)) closing_func. _(init|func) were deprecated.
327
328 06 Dec 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, libsandbox.c,
329 canonicalize.c, getcwd.c: Fixed compilation *again*. Hopefully cvs is done
330 having the hick-ups.
331
332 04 Dec 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, getcwd.c,
333 Makefile.am: Fixed compilation.
334
335 01 Dec 2004; Brian Harring <ferringb@gentoo.org> aclocal.m4:
336 Gutted the bugger so it stops checking for a c++ and fortran compiler.
337 Do *not* regenerate aclocal.m4 for making a release until a better
338 solution is created.
339
340 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, sandbox_futils.c:
341 Removal of more hardcoded paths.
342
343 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in,
344 sandbox_futils.c: tweaks to install sandbox.bashrc, and use it.
345
346 19 Nov 2004; Brian Harring <ferringb@gentoo.org>:
347 Sandbox is now autotooled, create-localdecls needs to be killed and the code
348 shifted into configure.in. Currently builds *one* libsandbox.so- if multiple
349 are desired (-m64 and -m32 for amd64), the ebuild should do it (imo).
350 To get to a point of testing, automake && autoconf; created requisite files w/
351 a(utomake|clocal)-1.8, and autoconf 2.59. Installs to /usr/, instead of
352 /lib and /usr/lib/portage/bin.
353
354 14 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox.c:
355 closing out bug #70225, potential overflow of the sandbox_pids_file var.
356
357 07 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c: c99 standard,
358 (think it was at least) allows intermixing of code and data segments. bug #70351
359 should be fixed by this.
360
361 03 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox_futils.c:
362 futils fix from bug #65201 via solar, and libsandbox log path checks via #69137
363
364 02 Aug 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Code from
365 Seth Robertson that tracked down all adjuct flags for read operations that
366 do not invoke a write operation.
367
368 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
369 Another fix from jstubbs regarding a free() on a stack variable for the
370 environment -- tracking now prevents extraneous free()'s segfault.
371
372 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
373 J. Stubbs tracked down a new bug where mkdir was failing to the patch on
374 the lstat in mkdir... it now only returns 0 or -1 as documented for mkdir.
375 Also remove the errno = ESUCCESS settings as documentation points out that
376 a library isn't allowed to do that.
377
378 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Added a
379 file_security_check() function to check random potential exploits on files
380 that sandbox is to load and read -- Normally sandboxpids.tmp. This fixes
381 the 'system-crippling' exploits (bug 21923) and catches a few other
382 potential problems.
383
384 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> Makefile: Updates for
385 32/64 bit sandbox. Made CC and LD '?=' values to allow passed in CC to work.
386
387 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c:
388 bug 42048 -- Fixed the lstat/errno conditions for mkdir <caleb@g.o>.
389 Added the 64/32 bit sandbox patch for AMD64 bug 32963 <brad/azarah>.
390
391 29 Feb 2004; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c :
392 Fix permissions and group of pids file and logs. Permissions should be 0664
393 and group should be 'portage'. Bug #34260.
394
395 28 Feb 2004; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
396 Besides a small cleanup, redo how we replace LD_PRELOAD in the environ passed
397 to the real execve (in our execve wrapper). Seems that on some arches (sparc
398 among others) do not allow us to tamper with the readonly copy passed to
399 execve, so pass our own copy of the environment. Bug #42290.
400
401 11 Jan 2004; Nicholas Jones <carpaski@gentoo.org> create-decls:
402 Changed tail to head and added a notice about duration of glibc check.
403
404 21 Dec 2003; Nicholas Jones <carpaski@gentoo.org> create-decls:
405 Changed the glibc subversion check to use /usr/bin/* instead of /bin/sh
406 as there isn't a guarentee that it is dynamic.
407
408 02 Nov 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
409 If 'file' passed to before_syscall(const char *func, const char *file) is
410 invalid, we should set errno to ENOENT, and not EINVAL. This should
411 close bug #32238.
412
413 14 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
414 Fix a bug that occurs mainly on 64bit arch, where the file passed to
415 the functions we wrap, is invalid, and then cause canonicalize to pass
416 garbage to before_syscall(), thanks to great detective work from
417 Andrea Luzzardi <al@sig11.org> (bug #29846).
418
419 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
420 Add a uClibc detection patch from Peter S. Mazinger <ps.m@gmx.net>.
421
422 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
423 Fix a bug in libsandbox.c 's checking in the rename wrapper - it basically
424 only checked the destination patch, and not the source, so we could move
425 a protected file to a unprotected directory, and then delete/modify it.
426 Thanks to Andrea Luzzardi (scox) <al@sig11.org>, bug #30992, for this fix.
427
428 12 Oct 2003; Nicholas Jones <carpaski@gentoo.org> sandbox.c :
429 Added python2.3 to the predict section/variable.
430
431 28 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
432 sandbox.h, sandbox_futils.c :
433 Add support to set the pids file via SANDBOX_PIDS_FILE at startup. If
434 it is not set, it will revert to its old value.
435
436 27 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
437 Fix our mkdir wrapper to check if the dir exist, and return EEXIST if so,
438 rather than failing with a violation, bug #29748.
439
440 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
441 Fix canonicalize() to ignore calls with path = "".
442
443 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c,
444 sandbox_futils.c, canonicalize.c :
445 Once again coreutils fails, as my systems had 2.5 kernel, the getcwd system
446 call handled strings larger than PATH_MAX (bug #21766). It however does not
447 work the same on 2.4 kernels.
448
449 To fix, I added the posix implementation of getcwd() (from glibc cvs) that
450 do not need the system call. We use the default getcwd() function via a
451 wrapper (egetcwd), and then lstat the returned path. If lstat fails, it
452 means the current directory was removed, OR that the the system call for
453 getcwd failed (curious is that it do not fail and return NULL or set
454 errno, but rather just truncate the retured directory - usually from the
455 start), and if so, we use the generic getcwd() function (__egetcwd). Note
456 that we do not use the generic version all the time, as it calls lstat()
457 a great number of times, and performance degrade much.
458
459 29 Jun 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls,
460 libsandbox.c :
461 Make sure SB_PATH_MAX will not wrap. Fix two possible memory leaks.
462
463 22 Jun 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, canonicalize.c
464 create-localdecls :
465 When checking path names of files accessed, we need to canonicalize it, else
466 it may be a symlink in a 'write allowed' directory pointing to a file in a
467 directory we should not have write access to.
468
469 With something like coreutils-5.0, we have two problems:
470 1) One of the tests checks if getcwd() can return a path longer than
471 PATH_MAX. This test then tries to create a dir which even while
472 created local (mkdir("conftest2")), it ends up being resolved with
473 a name that is much larger than PATH_MAX. The problem now is that
474 canonicalize() have undefined behaviour when the path was too long
475 (returned wrongly truncated paths, etc), and pass the wrong path to
476 before_syscall() (causing the bogus sandbox violations).
477 2) The ecanonicalize() function we used, along with the canonicalize()
478 function did not support longer than PATH_MAX. This is partly a
479 cause for 1), but the error checking (rather lack of it) of calls
480 to erealpath() in canonicalize() was the prime reason for 1).
481
482 As we do not use this canonicalized name to call the function, we resolve this
483 by fixing canonicalize() to do better error checking, and ecanonicalize() as
484 well as all functions in libsandbox.c to use a PATH_MAX of 'PATH_MAX * 2'.
485 While they will resolve paths properly now, and can check if a write/read is
486 allowed, the functions called from the sandboxed environment will still work
487 as expected.
488
489 This should resolve bug #21766.
490
491 06 Apr 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
492 For some reason sandbox fails with a 'open_wr' if you run 'locale -a' under
493 it (bug #16298).
494
495 Problem is that for some reason locale fopen's locale.alias with mode "rm".
496
497 -------------------------------------------------------
498 nosferatu root # grep fopen locale.log
499 fopen("/usr/share/locale/locale.alias", "rm"ACCESS DENIED open_wr: /usr/share/locale/locale.alias
500 nosferatu root #
501 --------------------------------------------------------
502
503 I checked the source of locale, but it have fopen with mode 'r', so
504 not sure where the "rm" mode comes from. Anyhow, changed the check in
505 before_syscall_open_char() to also see mode "rm" as readonly.
506
507 23 Feb 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
508
509 Add glibc-2.3 support.
510
511 22 Feb 2003; Martin Schlemmer <azarah@gentoo.org> sandbox.c :
512
513 Some /etc/ld.so.preload fixes. Just changed the #if defines to cover all
514 operations releated to preload, as well as only try to modify ld.so.preload
515 if we can. Also modify to write the pid to /tmp/sandboxpids.tmp even when
516 not using ld.so.preload. Fix to not write this instance of sandbox's pid
517 to /tmp/sandboxpids.tmp on exit if this is not the last sandbox running.
518
519 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> Makefile :
520
521 Changed the LD to CC for hppa.
522
523 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
524
525 Killed the previous changes I made.
526
527 17 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
528
529 Added parisc to BROKEN_RTLD_ARCHLIST to see if it we can fix the relocation probs.
530
531 09 Jan 2003; J Robert Ray <jrray@gentoo.org> sandbox.c :
532
533 Don't segfault if $HOME isn't set, set $HOME to "/" instead. Fixes bug 10868.
534
535 16 Dec 2002; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
536
537 Fix memory leak for mips, bug #12236. Thanks to Torgeir Hansen <torgeir@trenger.ro>
538 for this fix.
539
540 4 Dec 2002; J Robert Ray <jrray@gentoo.org> sandbox.h sandbox_futils.c :
541
542 sandbox_futils defined a dirname() function that was masking the same
543 function in glibc and was broken (e.g.: SANDBOX_DIR was being set to
544 '/usr/lib/portage/bi/'). Fixed function to return expected results and
545 renamed it to sb_dirname() to no longer mask the glibc function. Closes bug
546 11231.
547
548 4 Dec 2002; Martin Schlemmer <azarah@gentoo.org> :
549
550 Fix a segfault in libsandbox.c if canonicalize() was called with
551 first parameter = NULL.
552
553 1 Sep 2002; Martin Schlemmer <azarah@gentoo.org> :
554
555 Fix my braindead 'return 1;' in a void function. Updated sandbox.c,
556 cleanup() for this.
557
558 Change cleanup() in sandbox.c not to exit with fail status if
559 the pidsfile is missing. We really should still display sandbox
560 violations if they occured.
561
562 31 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
563
564 Update cleanup() in sandbox.c to remove the PIDSFILE if this is
565 the last sandbox running.
566
567 25 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
568
569 Major cleanups to mainly libsandbox.c again.
570
571 22 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
572
573 Add copyrights to sandbox.h and sandbox_futils.h. If wrong, the
574 parties involved should please contact me so that we can fix it.
575
576 Add opendir wrapper to libsandbox.c.
577
578 21 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
579
580 Do some more cleanups to ecanonicalize(), as it dropped filenames in
581 rare cases (after my symlink cleanups), and caused glibc to bork.
582 These fixes went into canonicalize.c.
583
584 20 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
585
586 Fix spawn_shell() and main() in sandbox.c to properly return fail
587 status.
588
589 19 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
590
591 The new canonicalize() function in libsandbox.c also resolved symlinks,
592 which caused on cleaning sandbox errors if the symlink pointed to a
593 file in the live root. Ripped out canonicalize() and realpath() from
594 glibc; removed the symlink stuff, and changed them to ecanonicalize()
595 and erealpath().
596
597 18 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
598
599 Ripped out all the wrappers, and implemented those of InstallWatch.
600 Losts of cleanups and bugfixes. Implement a execve that forces
601 $LIBSANDBOX in $LD_PRELOAD. We can now thus do away with the feared
602 /etc/ld.so.preload (*g*) ... Made the needed changes to sandbox.c,
603 sandbox.h and sandbox_futils.c. Rewrote the Makefile for most
604 parts; it now have an install target.
605
606 Reformat the whole thing to look somewhat like the reworked sandbox.c
607 and new sandbox.h and sandbox_futils.c from:
608
609 Brad House <brad@mainstreetsoftworks.com>.
610
611 Additional Copyrights now due to the InstallWatch code:
612
613 Copyright (C) 1998-9 Pancrazio `Ezio' de Mauro <p@demauro.net>

Properties

Name Value
svn:eol-style native
svn:keywords Author Date Id Revision

  ViewVC Help
Powered by ViewVC 1.1.20