/[path-sandbox]/trunk/ChangeLog
Gentoo

Contents of /trunk/ChangeLog

Parent Directory Parent Directory | Revision Log Revision Log


Revision 172 - (show annotations) (download)
Mon Nov 28 09:55:54 2005 UTC (8 years, 9 months ago) by azarah
File size: 29325 byte(s)
Check generic getcwd()'s return as well for validity, bug #101728.
1 # ChangeLog for Path Sandbox
2 # Copyright 1999-2005 Gentoo Foundation; Distributed under the GPL v2
3 # $Header$
4
5 28 Nov 2005 Martin Schlemmer <azarah@gentoo.org> getcwd.c:
6
7 Check generic getcwd()'s return as well for validity, bug #101728.
8
9 01 Nov 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
10
11 Do not pass mode to true_open and true_open64 if not needed. Should fix a
12 segfault in some cases.
13
14 * sandbox-1.2.13 (2005/09/12)
15
16 12 Sep 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, libsandbox.c:
17
18 Do not handle adding working directory to SANDBOX_WRITE, as portage does it
19 itself.
20
21 Make libsb_fini() do cleanup a bit more complete just in case we get another
22 uClibc 'call preloaded library fini before that of app' issue ... probably
23 will not help much, but we try.
24
25 04 Sep 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
26
27 Also allow symlink() system call to operate on a symlink in a writable path
28 that points to non-writable path, bug #104711.
29
30 * sandbox-1.2.12 (2005/08/05)
31
32 05 Aug 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
33 sandbox.h:
34
35 Do not give an access violation if the access() system call do not have
36 write/read access - it does not actually modify, so we only need to return
37 not being able to write/read. Noted by Andres Loeh <kosmikus@gentoo.org>,
38 bug #101433.
39
40 If we are called from the command line, do not care about PORTAGE_TMPDIR,
41 and make the current directory the work directory. Also rename the variable
42 portage_tmp_dir to work_dir.
43
44 Remove the tmp_dir variable - we do not need it.
45
46 Improve error handling for get_sandbox_*_envvar() functions.
47
48 01 Aug 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
49
50 Still do normal log if debugging is requested.
51
52 Add support for SANDBOX_VERBOSE (enabled by default). Adjust SANDBOX_DEBUG
53 to only enable if equal to "1" or "yes".
54
55 Add /dev/tts to write permit, bug #42809.
56
57 27 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
58 sandbox_futils.c:
59
60 Do not resolve symlinks in PORTAGE_TMPDIR in sandbox .. we will handle that
61 in libsandbox .. bug #100309.
62
63 22 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.h:
64
65 Print all logging to stderr, bug #90343, comment #15, by Zac Medico.
66
67 * sandbox-1.2.11 (2005/07/14)
68
69 14 July 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c:
70 Fix getcwd, bug #98419.
71
72 08 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c,
73 libsandbox.c:
74 - Try to cleanup and make error handling/printing consistent.
75 - Remove old logs if present and conflicting with current.
76 - Fix compile error with previous change, and return rather then exit().
77
78 07 July 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
79 sandbox.h, sandbox_futils.c:
80 - Fix possible segfault in env init code.
81 - Major cleanup of sandbox_futils.c. Removed most of the functions as we now
82 write to /var/log/sandbox/, so in theory do not need all that.
83 - Redo the interface of the get_* functions so that we do not leak memory.
84 - Remove sandbox_dir and co - we are not using it anymore.
85 - Remove unused includes and variables.
86 - Only declare functions in sandbox_futils.c that are used in libsandbox.c when
87 OUTSIDE_LIBSANDBOX is not defined.
88 - Cleanup access/log printing. Make access printing honour NOCOLOR. Fix log
89 printing's last line not honouring NOCOLOR.
90
91 06 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.h, sandbox_futils.c,
92 libsandbox.c:
93 - Change log dir to /var/log/sandbox/. Make sure the sandboxed process cannot
94 write to it.
95 - Clean up logging in libsandbox.c, and hopefully make it more consistant.
96 - Add check_prefixes() with major cleanup on check_access().
97 - Cleanup init_env_entries() and check_prefixes().
98
99 05 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
100 sandbox_futils.c, libsandbox.c:
101 Remove unused 'pids file' code.
102
103 * sandbox-1.2.10 (2005/07/03)
104
105 03 July 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
106 Add PREDICT items for nss-db, bug #92079. Patch from Robin Johnson.
107
108 17 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
109 General cleanups:
110 - Remove fooling around with exit codes - we error out on presence of a log
111 anyhow.
112 - Move get_sandbox_*_envvar() to sandbox_setup_environ(), as its more
113 appropriate there.
114
115 12 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
116 Cleanup the fail_nametoolong stuff a bit more.
117
118 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
119 Remove hopefully the last ld.so.preload bits we do not use anymore.
120
121 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
122 Remove the unneeded canonicalize() calls in the wrappers - we do it anyhow
123 in check_syscall(). Should speed things up a bit (at least for the getcwd()
124 and long path name test it goes down to under a second, and not 10+ seconds
125 like before). Also warn if we skip checking due to the canonicalized path
126 being too long.
127
128 11 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
129 More comment/readability cleanups.
130
131 10 June 2005; Martin Schlemmer <azarah@gentoo.org> canonicalize.c, getcwd.c,
132 sandbox_futils.c, libsandbox.c:
133 Some strncpy/strncat and other cleanups.
134
135 * sandbox-1.2.9 (2005/06/09)
136
137 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
138 Move symlink hack down a bit to try and minimize on the amount of lstat()
139 calls we do.
140
141 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
142 Add hack to allow writing to /proc/self/fd (or /dev/fd), bug #91516.
143
144 09 June 2005; Martin Schlemmer <azarah@gentoo.org> symbols.in, libsandbox.c:
145 Add wrapper for access() function, bug #85413.
146
147 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c:
148 Use generic getcwd() implementation from uclibc - should be more portable
149 and looks a bit cleaner.
150
151 09 June 2005; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c:
152 Make sure our true_* pointers are initialized to NULL, and that we check for
153 all references that they are valid.
154
155 09 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
156 Be default we will fail if the path name we try to canonicalize is too long.
157 This however could cause issues with some things (bug #94630 and #21766), so
158 if fail_nametoolong == 0, canonicalize() will return a null length string and
159 do not fail.
160
161 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c:
162 Do not abort if TMPDIR is not valid, but rather use '/tmp', bug #94360. Also
163 make sure we re-export the new TMPDIR environment variable.
164
165 08 June 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
166 Fix incorrect free of non-malloc'd array, bug #92313 and #94020. Fix noted
167 by Marcus D. Hanwell <cryos@gentoo.org>.
168
169 08 June 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
170 Add /dev/console to write list, bug #38588.
171
172 * sandbox-1.2.8 (2005/05/13)
173
174 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
175 sandbox.h, sandbox_futils.c:
176 General cleanups.
177
178 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
179 sandbox.h:
180 Various LD_PRELOAD cleanups. Do not unset LD_PRELOAD for parent.
181
182 13 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
183 sandbox.h, sandbox_futils.c:
184 Modify get_sandbox_pids_file(), get_sandbox_log() and get_sandbox_debug_log()
185 to use TMPDIR if present in environment.
186
187 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
188 Remove sandbox_log_file from main() as its no longer used.
189
190 13 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
191 sandbox_futils.c:
192 Add get_sandbox_debug_log(), and use it (add behaviour similar to SANDBOX_LOG
193 if already exported when sandbox started). Fix get_sandbox_log() and new
194 get_sandbox_debug_log() to not use already exported environment variables if
195 they have '/' in them. Use snprintf()'s instead of strncpy()'s. More
196 SB_PATH_MAX fixes.
197
198 * sandbox-1.2.7 (2005/05/12)
199
200 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
201 sandbox_futils.c:
202 More path limit fixes. Declare SB_BUF_LEN global and use it where needed.
203
204 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
205 Fix paths limited to 255 chars. Fix get_sandbox_dir() returning a string
206 with '(null)' in it if we did not call sandbox with absolute path.
207
208 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
209 Set SANDBOX_ON *before* doing the child's env stuff, else its not set
210 for the child.
211
212 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
213 Remove global preload_adaptable as it is no longer used.
214
215 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
216 Rewrite environment stuff to only be set when execve'ing the child process
217 to try and avoid issues like bug #91541 that causes sandbox to crash if
218 we set LD_PRELOAD sandbox side already.
219
220 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
221 Move print_sandbox_log() up to make things neater.
222
223 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
224 Remove load_preload_libs(), as its not used anymore.
225
226 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
227 Remove NO_FORK stuff, as its not used, and 'strace -f' works just fine.
228
229 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
230 Remove USE_SYSTEM_SHELL stuff, as it is not secure, and not in use.
231
232 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
233 Remove ld.so.preload crap - we are not going to use it again.
234
235 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
236 Fix typo in code that checks if we got valid group information, causing a
237 segmentation fault, bug #91637.
238
239 * sandbox-1.2.6 (2005/05/10)
240
241 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
242 Do not use LD_PRELOAD if it contains libtsocks.so, as it breaks sandbox
243 for some odd reason, bug #91541.
244
245 09 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
246 Fix typo (sizeof -> strlen).
247
248 08 May 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
249 rewrote the sbcontext caching code so it accounts for env changes since lib
250 initialization.
251
252 05 May 2005; Martin Schlemmer <azarah@gentoo.org> configure.in, libctest.c:
253 We create libctest.c via configure, so no need to keep it around. Do some
254 cleanup related to libctest.c and libctest during configure.
255
256 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
257 Add rename support of symlinks pointing to protected files/directories.
258
259 * sandbox-1.2.5 (2005/05/04)
260
261 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
262 sandbox.bashrc:
263 Do not reset already set LD_PRELOAD when starting sandbox. If LD_PRELOAD is
264 already set, init of the env vars fails for some reason, so do this later on,
265 and do not warn (bug #91431).
266
267 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
268 sandbox.bashrc:
269 Fixup sandbox and sandbox.bashrc to call bash with the proper .bashrc.
270
271 * sandbox-1.2.4 (2005/05/03)
272
273 03 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
274 Do not init the env entries with each call, as it creates too many calls to
275 lstat, etc. Should speedup things a bit, bug #91040.
276
277 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
278 Add /dev/pty to default write list. Noticed by Morfic.
279
280 02 May 2005; Mike Frysinger <vapier@gentoo.org> configure.in, localdecls.h,
281 sandbox.h:
282 uClibc doesn't support dlvsym() so add a configure check to make sure it doesn't
283 exist. Also update localdecls.h so BROKEN_RTLD_NEXT isn't defined in uClibc.
284
285 * sandbox-1.2.3 (2005/04/29)
286
287 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> configure.in:
288 Do not check for (*&#$(* CXX or F77.
289
290 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
291 Do not append '/' to pathname in filter_path() if it already ends with it.
292
293 28 Apr 2005; Mike Frysinger <vapier@gentoo.org> Makefile.am, configure.in:
294 With az's help, clean up autotools to work with cross-compiling.
295
296 * sandbox-1.2.2 (2005/04/28)
297
298 28 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
299 Only check for /dev/{null,zero} for unlink hack, else ricers using /dev/shm
300 have issues; bug #90592.
301
302 * sandbox-1.2.1 (2005/04/23)
303
304 23 Apr 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
305 getcwd.c, libsandbox.c, localdecls.h, sandbox.h, sandbox_futils.c:
306 Make sure all functions used in libsandbox.c is declared static. Define
307 SB_STATIC in localdecls.h for this. Include sandbox_futils.c rather than
308 linking with its object. Hopefully this will fix bug #90153.
309
310 * sandbox-1.2 (2005/04/23)
311
312 22 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
313 Allow lchown a symlink in write-allowed path pointing to write-denied
314 target.
315
316 21 Mar 2005; Marius Mauch <genone@gentoo.org> libsandbox.c:
317 Also show resolved symlink names in the log.
318
319 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, libsandbox.c:
320 Seems -nostdlib was the problem with the constructor/destructor - remove it
321 from Makefile.am, and change the constructor/destructor names again.
322
323 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
324 Also rename the _init() and _fini() declarations.
325
326 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
327 Fixup the constructor/destructor function names again (they should be _init()
328 and _fini() it seems, and not being called caused sandbox_lib_path to be
329 unset, and thus breaking the execve() wrapper's LD_PRELOAD protection).
330 Add both the path in given SANDBOX_x variable, as well as its symlink
331 resolved path in init_env_entries(). Modify filter_path() to be able to
332 resolve paths without resolving symlinks, as well as to be able to resolve
333 symlinks. Fix a possible segfault in check_access(). Add symlink resolving
334 to check_access() resolving bug #31019. Add 'hack' for unlink, as the fix
335 for bug #31019 cause access violations if we try to remove a symlink that is
336 not in protected path, but points to a protected path. Fix a memory leak in
337 sandbox.c (sandbox_pids_file in main()). Fix the realpath() calls in main()
338 (sandbox.c) being unchecked. Fix the debug logname not having the pid in it
339 (pid_string was uninitialized). General syntax cleanups.
340
341 09 Mar 2005; Brian Harring <ferringb@gentoo.org> sandbox.c: Fixed the
342 infamous "pids file is not a regular file" w/out newline bug.
343
344 09 Mar 2005; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in:
345 Correct libc_version path detection, since it was screwing up if libdir !=
346 "/lib/".
347
348 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
349 Hack to make sure sandboxed process cannot remove a device node, bug #79836.
350
351 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am:
352 Fix symbols.in not added to dist.
353
354 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
355 getcwd.c, libsandbox.c, sandbox.c, sandbox.h, sandbox_futils.c:
356 White space fixes.
357
358 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
359 configure.in, getcwd.c, libsandbox.c, symbols.in:
360 Fix inverse test logic in canonicalize.c, use a strncpy. Fix gcc warning in
361 getcwd.c. Add symbols.in and logic to Makefile.am to generate symbol versions
362 for glibc and other libc's that use this. Update libsandbox.c to use these
363 symbol versions if available. Fix exec wrapper to re-export LD_PRELOAD if the
364 process unset it.
365
366 01 Mar 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
367 killed off _init and _fini in favor of
368 void __attribute__ ((constructor)) init_func and
369 void __attribute__ ((destructor)) closing_func. _(init|func) were deprecated.
370
371 06 Dec 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, libsandbox.c,
372 canonicalize.c, getcwd.c: Fixed compilation *again*. Hopefully cvs is done
373 having the hick-ups.
374
375 04 Dec 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, getcwd.c,
376 Makefile.am: Fixed compilation.
377
378 01 Dec 2004; Brian Harring <ferringb@gentoo.org> aclocal.m4:
379 Gutted the bugger so it stops checking for a c++ and fortran compiler.
380 Do *not* regenerate aclocal.m4 for making a release until a better
381 solution is created.
382
383 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, sandbox_futils.c:
384 Removal of more hardcoded paths.
385
386 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in,
387 sandbox_futils.c: tweaks to install sandbox.bashrc, and use it.
388
389 19 Nov 2004; Brian Harring <ferringb@gentoo.org>:
390 Sandbox is now autotooled, create-localdecls needs to be killed and the code
391 shifted into configure.in. Currently builds *one* libsandbox.so- if multiple
392 are desired (-m64 and -m32 for amd64), the ebuild should do it (imo).
393 To get to a point of testing, automake && autoconf; created requisite files w/
394 a(utomake|clocal)-1.8, and autoconf 2.59. Installs to /usr/, instead of
395 /lib and /usr/lib/portage/bin.
396
397 14 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox.c:
398 closing out bug #70225, potential overflow of the sandbox_pids_file var.
399
400 07 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c: c99 standard,
401 (think it was at least) allows intermixing of code and data segments. bug #70351
402 should be fixed by this.
403
404 03 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox_futils.c:
405 futils fix from bug #65201 via solar, and libsandbox log path checks via #69137
406
407 02 Aug 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Code from
408 Seth Robertson that tracked down all adjuct flags for read operations that
409 do not invoke a write operation.
410
411 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
412 Another fix from jstubbs regarding a free() on a stack variable for the
413 environment -- tracking now prevents extraneous free()'s segfault.
414
415 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
416 J. Stubbs tracked down a new bug where mkdir was failing to the patch on
417 the lstat in mkdir... it now only returns 0 or -1 as documented for mkdir.
418 Also remove the errno = ESUCCESS settings as documentation points out that
419 a library isn't allowed to do that.
420
421 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Added a
422 file_security_check() function to check random potential exploits on files
423 that sandbox is to load and read -- Normally sandboxpids.tmp. This fixes
424 the 'system-crippling' exploits (bug 21923) and catches a few other
425 potential problems.
426
427 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> Makefile: Updates for
428 32/64 bit sandbox. Made CC and LD '?=' values to allow passed in CC to work.
429
430 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c:
431 bug 42048 -- Fixed the lstat/errno conditions for mkdir <caleb@g.o>.
432 Added the 64/32 bit sandbox patch for AMD64 bug 32963 <brad/azarah>.
433
434 29 Feb 2004; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c :
435 Fix permissions and group of pids file and logs. Permissions should be 0664
436 and group should be 'portage'. Bug #34260.
437
438 28 Feb 2004; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
439 Besides a small cleanup, redo how we replace LD_PRELOAD in the environ passed
440 to the real execve (in our execve wrapper). Seems that on some arches (sparc
441 among others) do not allow us to tamper with the readonly copy passed to
442 execve, so pass our own copy of the environment. Bug #42290.
443
444 11 Jan 2004; Nicholas Jones <carpaski@gentoo.org> create-decls:
445 Changed tail to head and added a notice about duration of glibc check.
446
447 21 Dec 2003; Nicholas Jones <carpaski@gentoo.org> create-decls:
448 Changed the glibc subversion check to use /usr/bin/* instead of /bin/sh
449 as there isn't a guarentee that it is dynamic.
450
451 02 Nov 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
452 If 'file' passed to before_syscall(const char *func, const char *file) is
453 invalid, we should set errno to ENOENT, and not EINVAL. This should
454 close bug #32238.
455
456 14 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
457 Fix a bug that occurs mainly on 64bit arch, where the file passed to
458 the functions we wrap, is invalid, and then cause canonicalize to pass
459 garbage to before_syscall(), thanks to great detective work from
460 Andrea Luzzardi <al@sig11.org> (bug #29846).
461
462 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
463 Add a uClibc detection patch from Peter S. Mazinger <ps.m@gmx.net>.
464
465 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
466 Fix a bug in libsandbox.c 's checking in the rename wrapper - it basically
467 only checked the destination patch, and not the source, so we could move
468 a protected file to a unprotected directory, and then delete/modify it.
469 Thanks to Andrea Luzzardi (scox) <al@sig11.org>, bug #30992, for this fix.
470
471 12 Oct 2003; Nicholas Jones <carpaski@gentoo.org> sandbox.c :
472 Added python2.3 to the predict section/variable.
473
474 28 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
475 sandbox.h, sandbox_futils.c :
476 Add support to set the pids file via SANDBOX_PIDS_FILE at startup. If
477 it is not set, it will revert to its old value.
478
479 27 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
480 Fix our mkdir wrapper to check if the dir exist, and return EEXIST if so,
481 rather than failing with a violation, bug #29748.
482
483 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
484 Fix canonicalize() to ignore calls with path = "".
485
486 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c,
487 sandbox_futils.c, canonicalize.c :
488 Once again coreutils fails, as my systems had 2.5 kernel, the getcwd system
489 call handled strings larger than PATH_MAX (bug #21766). It however does not
490 work the same on 2.4 kernels.
491
492 To fix, I added the posix implementation of getcwd() (from glibc cvs) that
493 do not need the system call. We use the default getcwd() function via a
494 wrapper (egetcwd), and then lstat the returned path. If lstat fails, it
495 means the current directory was removed, OR that the the system call for
496 getcwd failed (curious is that it do not fail and return NULL or set
497 errno, but rather just truncate the retured directory - usually from the
498 start), and if so, we use the generic getcwd() function (__egetcwd). Note
499 that we do not use the generic version all the time, as it calls lstat()
500 a great number of times, and performance degrade much.
501
502 29 Jun 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls,
503 libsandbox.c :
504 Make sure SB_PATH_MAX will not wrap. Fix two possible memory leaks.
505
506 22 Jun 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, canonicalize.c
507 create-localdecls :
508 When checking path names of files accessed, we need to canonicalize it, else
509 it may be a symlink in a 'write allowed' directory pointing to a file in a
510 directory we should not have write access to.
511
512 With something like coreutils-5.0, we have two problems:
513 1) One of the tests checks if getcwd() can return a path longer than
514 PATH_MAX. This test then tries to create a dir which even while
515 created local (mkdir("conftest2")), it ends up being resolved with
516 a name that is much larger than PATH_MAX. The problem now is that
517 canonicalize() have undefined behaviour when the path was too long
518 (returned wrongly truncated paths, etc), and pass the wrong path to
519 before_syscall() (causing the bogus sandbox violations).
520 2) The ecanonicalize() function we used, along with the canonicalize()
521 function did not support longer than PATH_MAX. This is partly a
522 cause for 1), but the error checking (rather lack of it) of calls
523 to erealpath() in canonicalize() was the prime reason for 1).
524
525 As we do not use this canonicalized name to call the function, we resolve this
526 by fixing canonicalize() to do better error checking, and ecanonicalize() as
527 well as all functions in libsandbox.c to use a PATH_MAX of 'PATH_MAX * 2'.
528 While they will resolve paths properly now, and can check if a write/read is
529 allowed, the functions called from the sandboxed environment will still work
530 as expected.
531
532 This should resolve bug #21766.
533
534 06 Apr 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
535 For some reason sandbox fails with a 'open_wr' if you run 'locale -a' under
536 it (bug #16298).
537
538 Problem is that for some reason locale fopen's locale.alias with mode "rm".
539
540 -------------------------------------------------------
541 nosferatu root # grep fopen locale.log
542 fopen("/usr/share/locale/locale.alias", "rm"ACCESS DENIED open_wr: /usr/share/locale/locale.alias
543 nosferatu root #
544 --------------------------------------------------------
545
546 I checked the source of locale, but it have fopen with mode 'r', so
547 not sure where the "rm" mode comes from. Anyhow, changed the check in
548 before_syscall_open_char() to also see mode "rm" as readonly.
549
550 23 Feb 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
551
552 Add glibc-2.3 support.
553
554 22 Feb 2003; Martin Schlemmer <azarah@gentoo.org> sandbox.c :
555
556 Some /etc/ld.so.preload fixes. Just changed the #if defines to cover all
557 operations releated to preload, as well as only try to modify ld.so.preload
558 if we can. Also modify to write the pid to /tmp/sandboxpids.tmp even when
559 not using ld.so.preload. Fix to not write this instance of sandbox's pid
560 to /tmp/sandboxpids.tmp on exit if this is not the last sandbox running.
561
562 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> Makefile :
563
564 Changed the LD to CC for hppa.
565
566 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
567
568 Killed the previous changes I made.
569
570 17 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
571
572 Added parisc to BROKEN_RTLD_ARCHLIST to see if it we can fix the relocation probs.
573
574 09 Jan 2003; J Robert Ray <jrray@gentoo.org> sandbox.c :
575
576 Don't segfault if $HOME isn't set, set $HOME to "/" instead. Fixes bug 10868.
577
578 16 Dec 2002; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
579
580 Fix memory leak for mips, bug #12236. Thanks to Torgeir Hansen <torgeir@trenger.ro>
581 for this fix.
582
583 4 Dec 2002; J Robert Ray <jrray@gentoo.org> sandbox.h sandbox_futils.c :
584
585 sandbox_futils defined a dirname() function that was masking the same
586 function in glibc and was broken (e.g.: SANDBOX_DIR was being set to
587 '/usr/lib/portage/bi/'). Fixed function to return expected results and
588 renamed it to sb_dirname() to no longer mask the glibc function. Closes bug
589 11231.
590
591 4 Dec 2002; Martin Schlemmer <azarah@gentoo.org> :
592
593 Fix a segfault in libsandbox.c if canonicalize() was called with
594 first parameter = NULL.
595
596 1 Sep 2002; Martin Schlemmer <azarah@gentoo.org> :
597
598 Fix my braindead 'return 1;' in a void function. Updated sandbox.c,
599 cleanup() for this.
600
601 Change cleanup() in sandbox.c not to exit with fail status if
602 the pidsfile is missing. We really should still display sandbox
603 violations if they occured.
604
605 31 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
606
607 Update cleanup() in sandbox.c to remove the PIDSFILE if this is
608 the last sandbox running.
609
610 25 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
611
612 Major cleanups to mainly libsandbox.c again.
613
614 22 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
615
616 Add copyrights to sandbox.h and sandbox_futils.h. If wrong, the
617 parties involved should please contact me so that we can fix it.
618
619 Add opendir wrapper to libsandbox.c.
620
621 21 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
622
623 Do some more cleanups to ecanonicalize(), as it dropped filenames in
624 rare cases (after my symlink cleanups), and caused glibc to bork.
625 These fixes went into canonicalize.c.
626
627 20 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
628
629 Fix spawn_shell() and main() in sandbox.c to properly return fail
630 status.
631
632 19 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
633
634 The new canonicalize() function in libsandbox.c also resolved symlinks,
635 which caused on cleaning sandbox errors if the symlink pointed to a
636 file in the live root. Ripped out canonicalize() and realpath() from
637 glibc; removed the symlink stuff, and changed them to ecanonicalize()
638 and erealpath().
639
640 18 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
641
642 Ripped out all the wrappers, and implemented those of InstallWatch.
643 Losts of cleanups and bugfixes. Implement a execve that forces
644 $LIBSANDBOX in $LD_PRELOAD. We can now thus do away with the feared
645 /etc/ld.so.preload (*g*) ... Made the needed changes to sandbox.c,
646 sandbox.h and sandbox_futils.c. Rewrote the Makefile for most
647 parts; it now have an install target.
648
649 Reformat the whole thing to look somewhat like the reworked sandbox.c
650 and new sandbox.h and sandbox_futils.c from:
651
652 Brad House <brad@mainstreetsoftworks.com>.
653
654 Additional Copyrights now due to the InstallWatch code:
655
656 Copyright (C) 1998-9 Pancrazio `Ezio' de Mauro <p@demauro.net>

Properties

Name Value
svn:eol-style native
svn:keywords Author Date Id Revision

  ViewVC Help
Powered by ViewVC 1.1.20