/[path-sandbox]/trunk/ChangeLog
Gentoo

Contents of /trunk/ChangeLog

Parent Directory Parent Directory | Revision Log Revision Log


Revision 44 - (show annotations) (download)
Sat Apr 23 20:52:57 2005 UTC (9 years, 4 months ago) by azarah
File size: 16949 byte(s)
sandbox-1.2.1

1 # ChangeLog for Path Sandbox
2 # Copyright 1999-2004 Gentoo Foundation; Distributed under the GPL v2
3 # $Header$
4
5 * sandbox-1.2.1
6
7 23 Apr 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
8 getcwd.c, libsandbox.c, localdecls.h, sandbox.h, sandbox_futils.c:
9 Make sure all functions used in libsandbox.c is declared static. Define
10 SB_STATIC in localdecls.h for this. Include sandbox_futils.c rather than
11 linking with its object. Hopefully this will fix bug #90153.
12
13 22 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
14 Allow lchown a symlink in write-allowed path pointing to write-denied
15 target.
16
17 21 Mar 2005; Marius Mauch <genone@gentoo.org> libsandbox.c:
18 Also show resolved symlink names in the log.
19
20 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, libsandbox.c:
21 Seems -nostdlib was the problem with the constructor/destructor - remove it
22 from Makefile.am, and change the constructor/destructor names again.
23
24 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
25 Also rename the _init() and _fini() declarations.
26
27 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
28 Fixup the constructor/destructor function names again (they should be _init()
29 and _fini() it seems, and not being called caused sandbox_lib_path to be
30 unset, and thus breaking the execve() wrapper's LD_PRELOAD protection).
31 Add both the path in given SANDBOX_x variable, as well as its symlink
32 resolved path in init_env_entries(). Modify filter_path() to be able to
33 resolve paths without resolving symlinks, as well as to be able to resolve
34 symlinks. Fix a possible segfault in check_access(). Add symlink resolving
35 to check_access() resolving bug #31019. Add 'hack' for unlink, as the fix
36 for bug #31019 cause access violations if we try to remove a symlink that is
37 not in protected path, but points to a protected path. Fix a memory leak in
38 sandbox.c (sandbox_pids_file in main()). Fix the realpath() calls in main()
39 (sandbox.c) being unchecked. Fix the debug logname not having the pid in it
40 (pid_string was uninitialized). General syntax cleanups.
41
42 09 Mar 2005; Brian Harring <ferringb@gentoo.org> sandbox.c: Fixed the
43 infamous "pids file is not a regular file" w/out newline bug.
44
45 09 Mar 2005; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in:
46 Correct libc_version path detection, since it was screwing up if libdir !=
47 "/lib/".
48
49 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
50 Hack to make sure sandboxed process cannot remove a device node, bug #79836.
51
52 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am:
53 Fix symbols.in not added to dist.
54
55 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
56 getcwd.c, libsandbox.c, sandbox.c, sandbox.h, sandbox_futils.c:
57 White space fixes.
58
59 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
60 configure.in, getcwd.c, libsandbox.c, symbols.in:
61 Fix inverse test logic in canonicalize.c, use a strncpy. Fix gcc warning in
62 getcwd.c. Add symbols.in and logic to Makefile.am to generate symbol versions
63 for glibc and other libc's that use this. Update libsandbox.c to use these
64 symbol versions if available. Fix exec wrapper to re-export LD_PRELOAD if the
65 process unset it.
66
67 01 Mar 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
68 killed off _init and _fini in favor of
69 void __attribute__ ((constructor)) init_func and
70 void __attribute__ ((destructor)) closing_func. _(init|func) were deprecated.
71
72 06 Dec 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, libsandbox.c,
73 canonicalize.c, getcwd.c: Fixed compilation *again*. Hopefully cvs is done
74 having the hick-ups.
75
76 04 Dec 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, getcwd.c,
77 Makefile.am: Fixed compilation.
78
79 01 Dec 2004; Brian Harring <ferringb@gentoo.org> aclocal.m4:
80 Gutted the bugger so it stops checking for a c++ and fortran compiler.
81 Do *not* regenerate aclocal.m4 for making a release until a better
82 solution is created.
83
84 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, sandbox_futils.c:
85 Removal of more hardcoded paths.
86
87 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in,
88 sandbox_futils.c: tweaks to install sandbox.bashrc, and use it.
89
90 19 Nov 2004; Brian Harring <ferringb@gentoo.org>:
91 Sandbox is now autotooled, create-localdecls needs to be killed and the code
92 shifted into configure.in. Currently builds *one* libsandbox.so- if multiple
93 are desired (-m64 and -m32 for amd64), the ebuild should do it (imo).
94 To get to a point of testing, automake && autoconf; created requisite files w/
95 a(utomake|clocal)-1.8, and autoconf 2.59. Installs to /usr/, instead of
96 /lib and /usr/lib/portage/bin.
97
98 14 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox.c:
99 closing out bug #70225, potential overflow of the sandbox_pids_file var.
100
101 07 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c: c99 standard,
102 (think it was at least) allows intermixing of code and data segments. bug #70351
103 should be fixed by this.
104
105 03 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox_futils.c:
106 futils fix from bug #65201 via solar, and libsandbox log path checks via #69137
107
108 02 Aug 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Code from
109 Seth Robertson that tracked down all adjuct flags for read operations that
110 do not invoke a write operation.
111
112 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
113 Another fix from jstubbs regarding a free() on a stack variable for the
114 environment -- tracking now prevents extraneous free()'s segfault.
115
116 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
117 J. Stubbs tracked down a new bug where mkdir was failing to the patch on
118 the lstat in mkdir... it now only returns 0 or -1 as documented for mkdir.
119 Also remove the errno = ESUCCESS settings as documentation points out that
120 a library isn't allowed to do that.
121
122 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Added a
123 file_security_check() function to check random potential exploits on files
124 that sandbox is to load and read -- Normally sandboxpids.tmp. This fixes
125 the 'system-crippling' exploits (bug 21923) and catches a few other
126 potential problems.
127
128 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> Makefile: Updates for
129 32/64 bit sandbox. Made CC and LD '?=' values to allow passed in CC to work.
130
131 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c:
132 bug 42048 -- Fixed the lstat/errno conditions for mkdir <caleb@g.o>.
133 Added the 64/32 bit sandbox patch for AMD64 bug 32963 <brad/azarah>.
134
135 29 Feb 2004; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c :
136 Fix permissions and group of pids file and logs. Permissions should be 0664
137 and group should be 'portage'. Bug #34260.
138
139 28 Feb 2004; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
140 Besides a small cleanup, redo how we replace LD_PRELOAD in the environ passed
141 to the real execve (in our execve wrapper). Seems that on some arches (sparc
142 among others) do not allow us to tamper with the readonly copy passed to
143 execve, so pass our own copy of the environment. Bug #42290.
144
145 11 Jan 2004; Nicholas Jones <carpaski@gentoo.org> create-decls:
146 Changed tail to head and added a notice about duration of glibc check.
147
148 21 Dec 2003; Nicholas Jones <carpaski@gentoo.org> create-decls:
149 Changed the glibc subversion check to use /usr/bin/* instead of /bin/sh
150 as there isn't a guarentee that it is dynamic.
151
152 02 Nov 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
153 If 'file' passed to before_syscall(const char *func, const char *file) is
154 invalid, we should set errno to ENOENT, and not EINVAL. This should
155 close bug #32238.
156
157 14 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
158 Fix a bug that occurs mainly on 64bit arch, where the file passed to
159 the functions we wrap, is invalid, and then cause canonicalize to pass
160 garbage to before_syscall(), thanks to great detective work from
161 Andrea Luzzardi <al@sig11.org> (bug #29846).
162
163 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
164 Add a uClibc detection patch from Peter S. Mazinger <ps.m@gmx.net>.
165
166 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
167 Fix a bug in libsandbox.c 's checking in the rename wrapper - it basically
168 only checked the destination patch, and not the source, so we could move
169 a protected file to a unprotected directory, and then delete/modify it.
170 Thanks to Andrea Luzzardi (scox) <al@sig11.org>, bug #30992, for this fix.
171
172 12 Oct 2003; Nicholas Jones <carpaski@gentoo.org> sandbox.c :
173 Added python2.3 to the predict section/variable.
174
175 28 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
176 sandbox.h, sandbox_futils.c :
177 Add support to set the pids file via SANDBOX_PIDS_FILE at startup. If
178 it is not set, it will revert to its old value.
179
180 27 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
181 Fix our mkdir wrapper to check if the dir exist, and return EEXIST if so,
182 rather than failing with a violation, bug #29748.
183
184 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
185 Fix canonicalize() to ignore calls with path = "".
186
187 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c,
188 sandbox_futils.c, canonicalize.c :
189 Once again coreutils fails, as my systems had 2.5 kernel, the getcwd system
190 call handled strings larger than PATH_MAX (bug #21766). It however does not
191 work the same on 2.4 kernels.
192
193 To fix, I added the posix implementation of getcwd() (from glibc cvs) that
194 do not need the system call. We use the default getcwd() function via a
195 wrapper (egetcwd), and then lstat the returned path. If lstat fails, it
196 means the current directory was removed, OR that the the system call for
197 getcwd failed (curious is that it do not fail and return NULL or set
198 errno, but rather just truncate the retured directory - usually from the
199 start), and if so, we use the generic getcwd() function (__egetcwd). Note
200 that we do not use the generic version all the time, as it calls lstat()
201 a great number of times, and performance degrade much.
202
203 29 Jun 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls,
204 libsandbox.c :
205 Make sure SB_PATH_MAX will not wrap. Fix two possible memory leaks.
206
207 22 Jun 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, canonicalize.c
208 create-localdecls :
209 When checking path names of files accessed, we need to canonicalize it, else
210 it may be a symlink in a 'write allowed' directory pointing to a file in a
211 directory we should not have write access to.
212
213 With something like coreutils-5.0, we have two problems:
214 1) One of the tests checks if getcwd() can return a path longer than
215 PATH_MAX. This test then tries to create a dir which even while
216 created local (mkdir("conftest2")), it ends up being resolved with
217 a name that is much larger than PATH_MAX. The problem now is that
218 canonicalize() have undefined behaviour when the path was too long
219 (returned wrongly truncated paths, etc), and pass the wrong path to
220 before_syscall() (causing the bogus sandbox violations).
221 2) The ecanonicalize() function we used, along with the canonicalize()
222 function did not support longer than PATH_MAX. This is partly a
223 cause for 1), but the error checking (rather lack of it) of calls
224 to erealpath() in canonicalize() was the prime reason for 1).
225
226 As we do not use this canonicalized name to call the function, we resolve this
227 by fixing canonicalize() to do better error checking, and ecanonicalize() as
228 well as all functions in libsandbox.c to use a PATH_MAX of 'PATH_MAX * 2'.
229 While they will resolve paths properly now, and can check if a write/read is
230 allowed, the functions called from the sandboxed environment will still work
231 as expected.
232
233 This should resolve bug #21766.
234
235 06 Apr 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
236 For some reason sandbox fails with a 'open_wr' if you run 'locale -a' under
237 it (bug #16298).
238
239 Problem is that for some reason locale fopen's locale.alias with mode "rm".
240
241 -------------------------------------------------------
242 nosferatu root # grep fopen locale.log
243 fopen("/usr/share/locale/locale.alias", "rm"ACCESS DENIED open_wr: /usr/share/locale/locale.alias
244 nosferatu root #
245 --------------------------------------------------------
246
247 I checked the source of locale, but it have fopen with mode 'r', so
248 not sure where the "rm" mode comes from. Anyhow, changed the check in
249 before_syscall_open_char() to also see mode "rm" as readonly.
250
251 23 Feb 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
252
253 Add glibc-2.3 support.
254
255 22 Feb 2003; Martin Schlemmer <azarah@gentoo.org> sandbox.c :
256
257 Some /etc/ld.so.preload fixes. Just changed the #if defines to cover all
258 operations releated to preload, as well as only try to modify ld.so.preload
259 if we can. Also modify to write the pid to /tmp/sandboxpids.tmp even when
260 not using ld.so.preload. Fix to not write this instance of sandbox's pid
261 to /tmp/sandboxpids.tmp on exit if this is not the last sandbox running.
262
263 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> Makefile :
264
265 Changed the LD to CC for hppa.
266
267 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
268
269 Killed the previous changes I made.
270
271 17 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
272
273 Added parisc to BROKEN_RTLD_ARCHLIST to see if it we can fix the relocation probs.
274
275 09 Jan 2003; J Robert Ray <jrray@gentoo.org> sandbox.c :
276
277 Don't segfault if $HOME isn't set, set $HOME to "/" instead. Fixes bug 10868.
278
279 16 Dec 2002; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
280
281 Fix memory leak for mips, bug #12236. Thanks to Torgeir Hansen <torgeir@trenger.ro>
282 for this fix.
283
284 4 Dec 2002; J Robert Ray <jrray@gentoo.org> sandbox.h sandbox_futils.c :
285
286 sandbox_futils defined a dirname() function that was masking the same
287 function in glibc and was broken (e.g.: SANDBOX_DIR was being set to
288 '/usr/lib/portage/bi/'). Fixed function to return expected results and
289 renamed it to sb_dirname() to no longer mask the glibc function. Closes bug
290 11231.
291
292 4 Dec 2002; Martin Schlemmer <azarah@gentoo.org> :
293
294 Fix a segfault in libsandbox.c if canonicalize() was called with
295 first parameter = NULL.
296
297 1 Sep 2002; Martin Schlemmer <azarah@gentoo.org> :
298
299 Fix my braindead 'return 1;' in a void function. Updated sandbox.c,
300 cleanup() for this.
301
302 Change cleanup() in sandbox.c not to exit with fail status if
303 the pidsfile is missing. We really should still display sandbox
304 violations if they occured.
305
306 31 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
307
308 Update cleanup() in sandbox.c to remove the PIDSFILE if this is
309 the last sandbox running.
310
311 25 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
312
313 Major cleanups to mainly libsandbox.c again.
314
315 22 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
316
317 Add copyrights to sandbox.h and sandbox_futils.h. If wrong, the
318 parties involved should please contact me so that we can fix it.
319
320 Add opendir wrapper to libsandbox.c.
321
322 21 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
323
324 Do some more cleanups to ecanonicalize(), as it dropped filenames in
325 rare cases (after my symlink cleanups), and caused glibc to bork.
326 These fixes went into canonicalize.c.
327
328 20 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
329
330 Fix spawn_shell() and main() in sandbox.c to properly return fail
331 status.
332
333 19 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
334
335 The new canonicalize() function in libsandbox.c also resolved symlinks,
336 which caused on cleaning sandbox errors if the symlink pointed to a
337 file in the live root. Ripped out canonicalize() and realpath() from
338 glibc; removed the symlink stuff, and changed them to ecanonicalize()
339 and erealpath().
340
341 18 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
342
343 Ripped out all the wrappers, and implemented those of InstallWatch.
344 Losts of cleanups and bugfixes. Implement a execve that forces
345 $LIBSANDBOX in $LD_PRELOAD. We can now thus do away with the feared
346 /etc/ld.so.preload (*g*) ... Made the needed changes to sandbox.c,
347 sandbox.h and sandbox_futils.c. Rewrote the Makefile for most
348 parts; it now have an install target.
349
350 Reformat the whole thing to look somewhat like the reworked sandbox.c
351 and new sandbox.h and sandbox_futils.c from:
352
353 Brad House <brad@mainstreetsoftworks.com>.
354
355 Additional Copyrights now due to the InstallWatch code:
356
357 Copyright (C) 1998-9 Pancrazio `Ezio' de Mauro <p@demauro.net>

Properties

Name Value
svn:eol-style native
svn:keywords Author Date Id Revision

  ViewVC Help
Powered by ViewVC 1.1.20