/[path-sandbox]/trunk/ChangeLog
Gentoo

Contents of /trunk/ChangeLog

Parent Directory Parent Directory | Revision Log Revision Log


Revision 47 - (show annotations) (download)
Thu Apr 28 15:49:30 2005 UTC (9 years, 4 months ago) by azarah
File size: 17136 byte(s)
Only check for /dev/{null,zero} for unlink hack, else ricers using /dev/shm
have issues; bug #90592.

1 # ChangeLog for Path Sandbox
2 # Copyright 1999-2004 Gentoo Foundation; Distributed under the GPL v2
3 # $Header$
4
5 28 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
6 Only check for /dev/{null,zero} for unlink hack, else ricers using /dev/shm
7 have issues; bug #90592.
8
9 * sandbox-1.2.1
10
11 23 Apr 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
12 getcwd.c, libsandbox.c, localdecls.h, sandbox.h, sandbox_futils.c:
13 Make sure all functions used in libsandbox.c is declared static. Define
14 SB_STATIC in localdecls.h for this. Include sandbox_futils.c rather than
15 linking with its object. Hopefully this will fix bug #90153.
16
17 * sandbox-1.2
18
19 22 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
20 Allow lchown a symlink in write-allowed path pointing to write-denied
21 target.
22
23 21 Mar 2005; Marius Mauch <genone@gentoo.org> libsandbox.c:
24 Also show resolved symlink names in the log.
25
26 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, libsandbox.c:
27 Seems -nostdlib was the problem with the constructor/destructor - remove it
28 from Makefile.am, and change the constructor/destructor names again.
29
30 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
31 Also rename the _init() and _fini() declarations.
32
33 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
34 Fixup the constructor/destructor function names again (they should be _init()
35 and _fini() it seems, and not being called caused sandbox_lib_path to be
36 unset, and thus breaking the execve() wrapper's LD_PRELOAD protection).
37 Add both the path in given SANDBOX_x variable, as well as its symlink
38 resolved path in init_env_entries(). Modify filter_path() to be able to
39 resolve paths without resolving symlinks, as well as to be able to resolve
40 symlinks. Fix a possible segfault in check_access(). Add symlink resolving
41 to check_access() resolving bug #31019. Add 'hack' for unlink, as the fix
42 for bug #31019 cause access violations if we try to remove a symlink that is
43 not in protected path, but points to a protected path. Fix a memory leak in
44 sandbox.c (sandbox_pids_file in main()). Fix the realpath() calls in main()
45 (sandbox.c) being unchecked. Fix the debug logname not having the pid in it
46 (pid_string was uninitialized). General syntax cleanups.
47
48 09 Mar 2005; Brian Harring <ferringb@gentoo.org> sandbox.c: Fixed the
49 infamous "pids file is not a regular file" w/out newline bug.
50
51 09 Mar 2005; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in:
52 Correct libc_version path detection, since it was screwing up if libdir !=
53 "/lib/".
54
55 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
56 Hack to make sure sandboxed process cannot remove a device node, bug #79836.
57
58 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am:
59 Fix symbols.in not added to dist.
60
61 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
62 getcwd.c, libsandbox.c, sandbox.c, sandbox.h, sandbox_futils.c:
63 White space fixes.
64
65 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
66 configure.in, getcwd.c, libsandbox.c, symbols.in:
67 Fix inverse test logic in canonicalize.c, use a strncpy. Fix gcc warning in
68 getcwd.c. Add symbols.in and logic to Makefile.am to generate symbol versions
69 for glibc and other libc's that use this. Update libsandbox.c to use these
70 symbol versions if available. Fix exec wrapper to re-export LD_PRELOAD if the
71 process unset it.
72
73 01 Mar 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
74 killed off _init and _fini in favor of
75 void __attribute__ ((constructor)) init_func and
76 void __attribute__ ((destructor)) closing_func. _(init|func) were deprecated.
77
78 06 Dec 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, libsandbox.c,
79 canonicalize.c, getcwd.c: Fixed compilation *again*. Hopefully cvs is done
80 having the hick-ups.
81
82 04 Dec 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, getcwd.c,
83 Makefile.am: Fixed compilation.
84
85 01 Dec 2004; Brian Harring <ferringb@gentoo.org> aclocal.m4:
86 Gutted the bugger so it stops checking for a c++ and fortran compiler.
87 Do *not* regenerate aclocal.m4 for making a release until a better
88 solution is created.
89
90 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, sandbox_futils.c:
91 Removal of more hardcoded paths.
92
93 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in,
94 sandbox_futils.c: tweaks to install sandbox.bashrc, and use it.
95
96 19 Nov 2004; Brian Harring <ferringb@gentoo.org>:
97 Sandbox is now autotooled, create-localdecls needs to be killed and the code
98 shifted into configure.in. Currently builds *one* libsandbox.so- if multiple
99 are desired (-m64 and -m32 for amd64), the ebuild should do it (imo).
100 To get to a point of testing, automake && autoconf; created requisite files w/
101 a(utomake|clocal)-1.8, and autoconf 2.59. Installs to /usr/, instead of
102 /lib and /usr/lib/portage/bin.
103
104 14 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox.c:
105 closing out bug #70225, potential overflow of the sandbox_pids_file var.
106
107 07 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c: c99 standard,
108 (think it was at least) allows intermixing of code and data segments. bug #70351
109 should be fixed by this.
110
111 03 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox_futils.c:
112 futils fix from bug #65201 via solar, and libsandbox log path checks via #69137
113
114 02 Aug 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Code from
115 Seth Robertson that tracked down all adjuct flags for read operations that
116 do not invoke a write operation.
117
118 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
119 Another fix from jstubbs regarding a free() on a stack variable for the
120 environment -- tracking now prevents extraneous free()'s segfault.
121
122 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
123 J. Stubbs tracked down a new bug where mkdir was failing to the patch on
124 the lstat in mkdir... it now only returns 0 or -1 as documented for mkdir.
125 Also remove the errno = ESUCCESS settings as documentation points out that
126 a library isn't allowed to do that.
127
128 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Added a
129 file_security_check() function to check random potential exploits on files
130 that sandbox is to load and read -- Normally sandboxpids.tmp. This fixes
131 the 'system-crippling' exploits (bug 21923) and catches a few other
132 potential problems.
133
134 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> Makefile: Updates for
135 32/64 bit sandbox. Made CC and LD '?=' values to allow passed in CC to work.
136
137 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c:
138 bug 42048 -- Fixed the lstat/errno conditions for mkdir <caleb@g.o>.
139 Added the 64/32 bit sandbox patch for AMD64 bug 32963 <brad/azarah>.
140
141 29 Feb 2004; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c :
142 Fix permissions and group of pids file and logs. Permissions should be 0664
143 and group should be 'portage'. Bug #34260.
144
145 28 Feb 2004; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
146 Besides a small cleanup, redo how we replace LD_PRELOAD in the environ passed
147 to the real execve (in our execve wrapper). Seems that on some arches (sparc
148 among others) do not allow us to tamper with the readonly copy passed to
149 execve, so pass our own copy of the environment. Bug #42290.
150
151 11 Jan 2004; Nicholas Jones <carpaski@gentoo.org> create-decls:
152 Changed tail to head and added a notice about duration of glibc check.
153
154 21 Dec 2003; Nicholas Jones <carpaski@gentoo.org> create-decls:
155 Changed the glibc subversion check to use /usr/bin/* instead of /bin/sh
156 as there isn't a guarentee that it is dynamic.
157
158 02 Nov 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
159 If 'file' passed to before_syscall(const char *func, const char *file) is
160 invalid, we should set errno to ENOENT, and not EINVAL. This should
161 close bug #32238.
162
163 14 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
164 Fix a bug that occurs mainly on 64bit arch, where the file passed to
165 the functions we wrap, is invalid, and then cause canonicalize to pass
166 garbage to before_syscall(), thanks to great detective work from
167 Andrea Luzzardi <al@sig11.org> (bug #29846).
168
169 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
170 Add a uClibc detection patch from Peter S. Mazinger <ps.m@gmx.net>.
171
172 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
173 Fix a bug in libsandbox.c 's checking in the rename wrapper - it basically
174 only checked the destination patch, and not the source, so we could move
175 a protected file to a unprotected directory, and then delete/modify it.
176 Thanks to Andrea Luzzardi (scox) <al@sig11.org>, bug #30992, for this fix.
177
178 12 Oct 2003; Nicholas Jones <carpaski@gentoo.org> sandbox.c :
179 Added python2.3 to the predict section/variable.
180
181 28 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
182 sandbox.h, sandbox_futils.c :
183 Add support to set the pids file via SANDBOX_PIDS_FILE at startup. If
184 it is not set, it will revert to its old value.
185
186 27 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
187 Fix our mkdir wrapper to check if the dir exist, and return EEXIST if so,
188 rather than failing with a violation, bug #29748.
189
190 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
191 Fix canonicalize() to ignore calls with path = "".
192
193 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c,
194 sandbox_futils.c, canonicalize.c :
195 Once again coreutils fails, as my systems had 2.5 kernel, the getcwd system
196 call handled strings larger than PATH_MAX (bug #21766). It however does not
197 work the same on 2.4 kernels.
198
199 To fix, I added the posix implementation of getcwd() (from glibc cvs) that
200 do not need the system call. We use the default getcwd() function via a
201 wrapper (egetcwd), and then lstat the returned path. If lstat fails, it
202 means the current directory was removed, OR that the the system call for
203 getcwd failed (curious is that it do not fail and return NULL or set
204 errno, but rather just truncate the retured directory - usually from the
205 start), and if so, we use the generic getcwd() function (__egetcwd). Note
206 that we do not use the generic version all the time, as it calls lstat()
207 a great number of times, and performance degrade much.
208
209 29 Jun 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls,
210 libsandbox.c :
211 Make sure SB_PATH_MAX will not wrap. Fix two possible memory leaks.
212
213 22 Jun 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, canonicalize.c
214 create-localdecls :
215 When checking path names of files accessed, we need to canonicalize it, else
216 it may be a symlink in a 'write allowed' directory pointing to a file in a
217 directory we should not have write access to.
218
219 With something like coreutils-5.0, we have two problems:
220 1) One of the tests checks if getcwd() can return a path longer than
221 PATH_MAX. This test then tries to create a dir which even while
222 created local (mkdir("conftest2")), it ends up being resolved with
223 a name that is much larger than PATH_MAX. The problem now is that
224 canonicalize() have undefined behaviour when the path was too long
225 (returned wrongly truncated paths, etc), and pass the wrong path to
226 before_syscall() (causing the bogus sandbox violations).
227 2) The ecanonicalize() function we used, along with the canonicalize()
228 function did not support longer than PATH_MAX. This is partly a
229 cause for 1), but the error checking (rather lack of it) of calls
230 to erealpath() in canonicalize() was the prime reason for 1).
231
232 As we do not use this canonicalized name to call the function, we resolve this
233 by fixing canonicalize() to do better error checking, and ecanonicalize() as
234 well as all functions in libsandbox.c to use a PATH_MAX of 'PATH_MAX * 2'.
235 While they will resolve paths properly now, and can check if a write/read is
236 allowed, the functions called from the sandboxed environment will still work
237 as expected.
238
239 This should resolve bug #21766.
240
241 06 Apr 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
242 For some reason sandbox fails with a 'open_wr' if you run 'locale -a' under
243 it (bug #16298).
244
245 Problem is that for some reason locale fopen's locale.alias with mode "rm".
246
247 -------------------------------------------------------
248 nosferatu root # grep fopen locale.log
249 fopen("/usr/share/locale/locale.alias", "rm"ACCESS DENIED open_wr: /usr/share/locale/locale.alias
250 nosferatu root #
251 --------------------------------------------------------
252
253 I checked the source of locale, but it have fopen with mode 'r', so
254 not sure where the "rm" mode comes from. Anyhow, changed the check in
255 before_syscall_open_char() to also see mode "rm" as readonly.
256
257 23 Feb 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
258
259 Add glibc-2.3 support.
260
261 22 Feb 2003; Martin Schlemmer <azarah@gentoo.org> sandbox.c :
262
263 Some /etc/ld.so.preload fixes. Just changed the #if defines to cover all
264 operations releated to preload, as well as only try to modify ld.so.preload
265 if we can. Also modify to write the pid to /tmp/sandboxpids.tmp even when
266 not using ld.so.preload. Fix to not write this instance of sandbox's pid
267 to /tmp/sandboxpids.tmp on exit if this is not the last sandbox running.
268
269 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> Makefile :
270
271 Changed the LD to CC for hppa.
272
273 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
274
275 Killed the previous changes I made.
276
277 17 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
278
279 Added parisc to BROKEN_RTLD_ARCHLIST to see if it we can fix the relocation probs.
280
281 09 Jan 2003; J Robert Ray <jrray@gentoo.org> sandbox.c :
282
283 Don't segfault if $HOME isn't set, set $HOME to "/" instead. Fixes bug 10868.
284
285 16 Dec 2002; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
286
287 Fix memory leak for mips, bug #12236. Thanks to Torgeir Hansen <torgeir@trenger.ro>
288 for this fix.
289
290 4 Dec 2002; J Robert Ray <jrray@gentoo.org> sandbox.h sandbox_futils.c :
291
292 sandbox_futils defined a dirname() function that was masking the same
293 function in glibc and was broken (e.g.: SANDBOX_DIR was being set to
294 '/usr/lib/portage/bi/'). Fixed function to return expected results and
295 renamed it to sb_dirname() to no longer mask the glibc function. Closes bug
296 11231.
297
298 4 Dec 2002; Martin Schlemmer <azarah@gentoo.org> :
299
300 Fix a segfault in libsandbox.c if canonicalize() was called with
301 first parameter = NULL.
302
303 1 Sep 2002; Martin Schlemmer <azarah@gentoo.org> :
304
305 Fix my braindead 'return 1;' in a void function. Updated sandbox.c,
306 cleanup() for this.
307
308 Change cleanup() in sandbox.c not to exit with fail status if
309 the pidsfile is missing. We really should still display sandbox
310 violations if they occured.
311
312 31 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
313
314 Update cleanup() in sandbox.c to remove the PIDSFILE if this is
315 the last sandbox running.
316
317 25 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
318
319 Major cleanups to mainly libsandbox.c again.
320
321 22 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
322
323 Add copyrights to sandbox.h and sandbox_futils.h. If wrong, the
324 parties involved should please contact me so that we can fix it.
325
326 Add opendir wrapper to libsandbox.c.
327
328 21 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
329
330 Do some more cleanups to ecanonicalize(), as it dropped filenames in
331 rare cases (after my symlink cleanups), and caused glibc to bork.
332 These fixes went into canonicalize.c.
333
334 20 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
335
336 Fix spawn_shell() and main() in sandbox.c to properly return fail
337 status.
338
339 19 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
340
341 The new canonicalize() function in libsandbox.c also resolved symlinks,
342 which caused on cleaning sandbox errors if the symlink pointed to a
343 file in the live root. Ripped out canonicalize() and realpath() from
344 glibc; removed the symlink stuff, and changed them to ecanonicalize()
345 and erealpath().
346
347 18 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
348
349 Ripped out all the wrappers, and implemented those of InstallWatch.
350 Losts of cleanups and bugfixes. Implement a execve that forces
351 $LIBSANDBOX in $LD_PRELOAD. We can now thus do away with the feared
352 /etc/ld.so.preload (*g*) ... Made the needed changes to sandbox.c,
353 sandbox.h and sandbox_futils.c. Rewrote the Makefile for most
354 parts; it now have an install target.
355
356 Reformat the whole thing to look somewhat like the reworked sandbox.c
357 and new sandbox.h and sandbox_futils.c from:
358
359 Brad House <brad@mainstreetsoftworks.com>.
360
361 Additional Copyrights now due to the InstallWatch code:
362
363 Copyright (C) 1998-9 Pancrazio `Ezio' de Mauro <p@demauro.net>

Properties

Name Value
svn:eol-style native
svn:keywords Author Date Id Revision

  ViewVC Help
Powered by ViewVC 1.1.20