/[path-sandbox]/trunk/ChangeLog
Gentoo

Contents of /trunk/ChangeLog

Parent Directory Parent Directory | Revision Log Revision Log


Revision 48 - (show annotations) (download)
Thu Apr 28 16:18:36 2005 UTC (9 years, 2 months ago) by azarah
File size: 17153 byte(s)
* sandbox-1.2.2

1 # ChangeLog for Path Sandbox
2 # Copyright 1999-2004 Gentoo Foundation; Distributed under the GPL v2
3 # $Header$
4
5 * sandbox-1.2.2
6
7 28 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
8 Only check for /dev/{null,zero} for unlink hack, else ricers using /dev/shm
9 have issues; bug #90592.
10
11 * sandbox-1.2.1
12
13 23 Apr 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
14 getcwd.c, libsandbox.c, localdecls.h, sandbox.h, sandbox_futils.c:
15 Make sure all functions used in libsandbox.c is declared static. Define
16 SB_STATIC in localdecls.h for this. Include sandbox_futils.c rather than
17 linking with its object. Hopefully this will fix bug #90153.
18
19 * sandbox-1.2
20
21 22 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
22 Allow lchown a symlink in write-allowed path pointing to write-denied
23 target.
24
25 21 Mar 2005; Marius Mauch <genone@gentoo.org> libsandbox.c:
26 Also show resolved symlink names in the log.
27
28 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, libsandbox.c:
29 Seems -nostdlib was the problem with the constructor/destructor - remove it
30 from Makefile.am, and change the constructor/destructor names again.
31
32 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
33 Also rename the _init() and _fini() declarations.
34
35 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
36 Fixup the constructor/destructor function names again (they should be _init()
37 and _fini() it seems, and not being called caused sandbox_lib_path to be
38 unset, and thus breaking the execve() wrapper's LD_PRELOAD protection).
39 Add both the path in given SANDBOX_x variable, as well as its symlink
40 resolved path in init_env_entries(). Modify filter_path() to be able to
41 resolve paths without resolving symlinks, as well as to be able to resolve
42 symlinks. Fix a possible segfault in check_access(). Add symlink resolving
43 to check_access() resolving bug #31019. Add 'hack' for unlink, as the fix
44 for bug #31019 cause access violations if we try to remove a symlink that is
45 not in protected path, but points to a protected path. Fix a memory leak in
46 sandbox.c (sandbox_pids_file in main()). Fix the realpath() calls in main()
47 (sandbox.c) being unchecked. Fix the debug logname not having the pid in it
48 (pid_string was uninitialized). General syntax cleanups.
49
50 09 Mar 2005; Brian Harring <ferringb@gentoo.org> sandbox.c: Fixed the
51 infamous "pids file is not a regular file" w/out newline bug.
52
53 09 Mar 2005; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in:
54 Correct libc_version path detection, since it was screwing up if libdir !=
55 "/lib/".
56
57 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
58 Hack to make sure sandboxed process cannot remove a device node, bug #79836.
59
60 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am:
61 Fix symbols.in not added to dist.
62
63 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
64 getcwd.c, libsandbox.c, sandbox.c, sandbox.h, sandbox_futils.c:
65 White space fixes.
66
67 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
68 configure.in, getcwd.c, libsandbox.c, symbols.in:
69 Fix inverse test logic in canonicalize.c, use a strncpy. Fix gcc warning in
70 getcwd.c. Add symbols.in and logic to Makefile.am to generate symbol versions
71 for glibc and other libc's that use this. Update libsandbox.c to use these
72 symbol versions if available. Fix exec wrapper to re-export LD_PRELOAD if the
73 process unset it.
74
75 01 Mar 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
76 killed off _init and _fini in favor of
77 void __attribute__ ((constructor)) init_func and
78 void __attribute__ ((destructor)) closing_func. _(init|func) were deprecated.
79
80 06 Dec 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, libsandbox.c,
81 canonicalize.c, getcwd.c: Fixed compilation *again*. Hopefully cvs is done
82 having the hick-ups.
83
84 04 Dec 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, getcwd.c,
85 Makefile.am: Fixed compilation.
86
87 01 Dec 2004; Brian Harring <ferringb@gentoo.org> aclocal.m4:
88 Gutted the bugger so it stops checking for a c++ and fortran compiler.
89 Do *not* regenerate aclocal.m4 for making a release until a better
90 solution is created.
91
92 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, sandbox_futils.c:
93 Removal of more hardcoded paths.
94
95 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in,
96 sandbox_futils.c: tweaks to install sandbox.bashrc, and use it.
97
98 19 Nov 2004; Brian Harring <ferringb@gentoo.org>:
99 Sandbox is now autotooled, create-localdecls needs to be killed and the code
100 shifted into configure.in. Currently builds *one* libsandbox.so- if multiple
101 are desired (-m64 and -m32 for amd64), the ebuild should do it (imo).
102 To get to a point of testing, automake && autoconf; created requisite files w/
103 a(utomake|clocal)-1.8, and autoconf 2.59. Installs to /usr/, instead of
104 /lib and /usr/lib/portage/bin.
105
106 14 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox.c:
107 closing out bug #70225, potential overflow of the sandbox_pids_file var.
108
109 07 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c: c99 standard,
110 (think it was at least) allows intermixing of code and data segments. bug #70351
111 should be fixed by this.
112
113 03 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox_futils.c:
114 futils fix from bug #65201 via solar, and libsandbox log path checks via #69137
115
116 02 Aug 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Code from
117 Seth Robertson that tracked down all adjuct flags for read operations that
118 do not invoke a write operation.
119
120 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
121 Another fix from jstubbs regarding a free() on a stack variable for the
122 environment -- tracking now prevents extraneous free()'s segfault.
123
124 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
125 J. Stubbs tracked down a new bug where mkdir was failing to the patch on
126 the lstat in mkdir... it now only returns 0 or -1 as documented for mkdir.
127 Also remove the errno = ESUCCESS settings as documentation points out that
128 a library isn't allowed to do that.
129
130 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Added a
131 file_security_check() function to check random potential exploits on files
132 that sandbox is to load and read -- Normally sandboxpids.tmp. This fixes
133 the 'system-crippling' exploits (bug 21923) and catches a few other
134 potential problems.
135
136 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> Makefile: Updates for
137 32/64 bit sandbox. Made CC and LD '?=' values to allow passed in CC to work.
138
139 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c:
140 bug 42048 -- Fixed the lstat/errno conditions for mkdir <caleb@g.o>.
141 Added the 64/32 bit sandbox patch for AMD64 bug 32963 <brad/azarah>.
142
143 29 Feb 2004; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c :
144 Fix permissions and group of pids file and logs. Permissions should be 0664
145 and group should be 'portage'. Bug #34260.
146
147 28 Feb 2004; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
148 Besides a small cleanup, redo how we replace LD_PRELOAD in the environ passed
149 to the real execve (in our execve wrapper). Seems that on some arches (sparc
150 among others) do not allow us to tamper with the readonly copy passed to
151 execve, so pass our own copy of the environment. Bug #42290.
152
153 11 Jan 2004; Nicholas Jones <carpaski@gentoo.org> create-decls:
154 Changed tail to head and added a notice about duration of glibc check.
155
156 21 Dec 2003; Nicholas Jones <carpaski@gentoo.org> create-decls:
157 Changed the glibc subversion check to use /usr/bin/* instead of /bin/sh
158 as there isn't a guarentee that it is dynamic.
159
160 02 Nov 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
161 If 'file' passed to before_syscall(const char *func, const char *file) is
162 invalid, we should set errno to ENOENT, and not EINVAL. This should
163 close bug #32238.
164
165 14 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
166 Fix a bug that occurs mainly on 64bit arch, where the file passed to
167 the functions we wrap, is invalid, and then cause canonicalize to pass
168 garbage to before_syscall(), thanks to great detective work from
169 Andrea Luzzardi <al@sig11.org> (bug #29846).
170
171 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
172 Add a uClibc detection patch from Peter S. Mazinger <ps.m@gmx.net>.
173
174 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
175 Fix a bug in libsandbox.c 's checking in the rename wrapper - it basically
176 only checked the destination patch, and not the source, so we could move
177 a protected file to a unprotected directory, and then delete/modify it.
178 Thanks to Andrea Luzzardi (scox) <al@sig11.org>, bug #30992, for this fix.
179
180 12 Oct 2003; Nicholas Jones <carpaski@gentoo.org> sandbox.c :
181 Added python2.3 to the predict section/variable.
182
183 28 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
184 sandbox.h, sandbox_futils.c :
185 Add support to set the pids file via SANDBOX_PIDS_FILE at startup. If
186 it is not set, it will revert to its old value.
187
188 27 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
189 Fix our mkdir wrapper to check if the dir exist, and return EEXIST if so,
190 rather than failing with a violation, bug #29748.
191
192 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
193 Fix canonicalize() to ignore calls with path = "".
194
195 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c,
196 sandbox_futils.c, canonicalize.c :
197 Once again coreutils fails, as my systems had 2.5 kernel, the getcwd system
198 call handled strings larger than PATH_MAX (bug #21766). It however does not
199 work the same on 2.4 kernels.
200
201 To fix, I added the posix implementation of getcwd() (from glibc cvs) that
202 do not need the system call. We use the default getcwd() function via a
203 wrapper (egetcwd), and then lstat the returned path. If lstat fails, it
204 means the current directory was removed, OR that the the system call for
205 getcwd failed (curious is that it do not fail and return NULL or set
206 errno, but rather just truncate the retured directory - usually from the
207 start), and if so, we use the generic getcwd() function (__egetcwd). Note
208 that we do not use the generic version all the time, as it calls lstat()
209 a great number of times, and performance degrade much.
210
211 29 Jun 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls,
212 libsandbox.c :
213 Make sure SB_PATH_MAX will not wrap. Fix two possible memory leaks.
214
215 22 Jun 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, canonicalize.c
216 create-localdecls :
217 When checking path names of files accessed, we need to canonicalize it, else
218 it may be a symlink in a 'write allowed' directory pointing to a file in a
219 directory we should not have write access to.
220
221 With something like coreutils-5.0, we have two problems:
222 1) One of the tests checks if getcwd() can return a path longer than
223 PATH_MAX. This test then tries to create a dir which even while
224 created local (mkdir("conftest2")), it ends up being resolved with
225 a name that is much larger than PATH_MAX. The problem now is that
226 canonicalize() have undefined behaviour when the path was too long
227 (returned wrongly truncated paths, etc), and pass the wrong path to
228 before_syscall() (causing the bogus sandbox violations).
229 2) The ecanonicalize() function we used, along with the canonicalize()
230 function did not support longer than PATH_MAX. This is partly a
231 cause for 1), but the error checking (rather lack of it) of calls
232 to erealpath() in canonicalize() was the prime reason for 1).
233
234 As we do not use this canonicalized name to call the function, we resolve this
235 by fixing canonicalize() to do better error checking, and ecanonicalize() as
236 well as all functions in libsandbox.c to use a PATH_MAX of 'PATH_MAX * 2'.
237 While they will resolve paths properly now, and can check if a write/read is
238 allowed, the functions called from the sandboxed environment will still work
239 as expected.
240
241 This should resolve bug #21766.
242
243 06 Apr 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
244 For some reason sandbox fails with a 'open_wr' if you run 'locale -a' under
245 it (bug #16298).
246
247 Problem is that for some reason locale fopen's locale.alias with mode "rm".
248
249 -------------------------------------------------------
250 nosferatu root # grep fopen locale.log
251 fopen("/usr/share/locale/locale.alias", "rm"ACCESS DENIED open_wr: /usr/share/locale/locale.alias
252 nosferatu root #
253 --------------------------------------------------------
254
255 I checked the source of locale, but it have fopen with mode 'r', so
256 not sure where the "rm" mode comes from. Anyhow, changed the check in
257 before_syscall_open_char() to also see mode "rm" as readonly.
258
259 23 Feb 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
260
261 Add glibc-2.3 support.
262
263 22 Feb 2003; Martin Schlemmer <azarah@gentoo.org> sandbox.c :
264
265 Some /etc/ld.so.preload fixes. Just changed the #if defines to cover all
266 operations releated to preload, as well as only try to modify ld.so.preload
267 if we can. Also modify to write the pid to /tmp/sandboxpids.tmp even when
268 not using ld.so.preload. Fix to not write this instance of sandbox's pid
269 to /tmp/sandboxpids.tmp on exit if this is not the last sandbox running.
270
271 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> Makefile :
272
273 Changed the LD to CC for hppa.
274
275 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
276
277 Killed the previous changes I made.
278
279 17 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
280
281 Added parisc to BROKEN_RTLD_ARCHLIST to see if it we can fix the relocation probs.
282
283 09 Jan 2003; J Robert Ray <jrray@gentoo.org> sandbox.c :
284
285 Don't segfault if $HOME isn't set, set $HOME to "/" instead. Fixes bug 10868.
286
287 16 Dec 2002; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
288
289 Fix memory leak for mips, bug #12236. Thanks to Torgeir Hansen <torgeir@trenger.ro>
290 for this fix.
291
292 4 Dec 2002; J Robert Ray <jrray@gentoo.org> sandbox.h sandbox_futils.c :
293
294 sandbox_futils defined a dirname() function that was masking the same
295 function in glibc and was broken (e.g.: SANDBOX_DIR was being set to
296 '/usr/lib/portage/bi/'). Fixed function to return expected results and
297 renamed it to sb_dirname() to no longer mask the glibc function. Closes bug
298 11231.
299
300 4 Dec 2002; Martin Schlemmer <azarah@gentoo.org> :
301
302 Fix a segfault in libsandbox.c if canonicalize() was called with
303 first parameter = NULL.
304
305 1 Sep 2002; Martin Schlemmer <azarah@gentoo.org> :
306
307 Fix my braindead 'return 1;' in a void function. Updated sandbox.c,
308 cleanup() for this.
309
310 Change cleanup() in sandbox.c not to exit with fail status if
311 the pidsfile is missing. We really should still display sandbox
312 violations if they occured.
313
314 31 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
315
316 Update cleanup() in sandbox.c to remove the PIDSFILE if this is
317 the last sandbox running.
318
319 25 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
320
321 Major cleanups to mainly libsandbox.c again.
322
323 22 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
324
325 Add copyrights to sandbox.h and sandbox_futils.h. If wrong, the
326 parties involved should please contact me so that we can fix it.
327
328 Add opendir wrapper to libsandbox.c.
329
330 21 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
331
332 Do some more cleanups to ecanonicalize(), as it dropped filenames in
333 rare cases (after my symlink cleanups), and caused glibc to bork.
334 These fixes went into canonicalize.c.
335
336 20 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
337
338 Fix spawn_shell() and main() in sandbox.c to properly return fail
339 status.
340
341 19 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
342
343 The new canonicalize() function in libsandbox.c also resolved symlinks,
344 which caused on cleaning sandbox errors if the symlink pointed to a
345 file in the live root. Ripped out canonicalize() and realpath() from
346 glibc; removed the symlink stuff, and changed them to ecanonicalize()
347 and erealpath().
348
349 18 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
350
351 Ripped out all the wrappers, and implemented those of InstallWatch.
352 Losts of cleanups and bugfixes. Implement a execve that forces
353 $LIBSANDBOX in $LD_PRELOAD. We can now thus do away with the feared
354 /etc/ld.so.preload (*g*) ... Made the needed changes to sandbox.c,
355 sandbox.h and sandbox_futils.c. Rewrote the Makefile for most
356 parts; it now have an install target.
357
358 Reformat the whole thing to look somewhat like the reworked sandbox.c
359 and new sandbox.h and sandbox_futils.c from:
360
361 Brad House <brad@mainstreetsoftworks.com>.
362
363 Additional Copyrights now due to the InstallWatch code:
364
365 Copyright (C) 1998-9 Pancrazio `Ezio' de Mauro <p@demauro.net>

Properties

Name Value
svn:eol-style native
svn:keywords Author Date Id Revision

  ViewVC Help
Powered by ViewVC 1.1.20