/[path-sandbox]/trunk/ChangeLog
Gentoo

Contents of /trunk/ChangeLog

Parent Directory Parent Directory | Revision Log Revision Log


Revision 53 - (show annotations) (download)
Thu Apr 28 22:21:10 2005 UTC (9 years, 4 months ago) by vapier
File size: 17298 byte(s)
fix cross-compiling and uclibc and all that jazz

1 # ChangeLog for Path Sandbox
2 # Copyright 1999-2005 Gentoo Foundation; Distributed under the GPL v2
3 # $Header$
4
5 28 Apr 2005; Mike Frysinger <vapier@gentoo.org> Makefile.am, configure.in:
6 With az's help, clean up autotools to work with cross-compiling.
7
8 * sandbox-1.2.2
9
10 28 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
11 Only check for /dev/{null,zero} for unlink hack, else ricers using /dev/shm
12 have issues; bug #90592.
13
14 * sandbox-1.2.1
15
16 23 Apr 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
17 getcwd.c, libsandbox.c, localdecls.h, sandbox.h, sandbox_futils.c:
18 Make sure all functions used in libsandbox.c is declared static. Define
19 SB_STATIC in localdecls.h for this. Include sandbox_futils.c rather than
20 linking with its object. Hopefully this will fix bug #90153.
21
22 * sandbox-1.2
23
24 22 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
25 Allow lchown a symlink in write-allowed path pointing to write-denied
26 target.
27
28 21 Mar 2005; Marius Mauch <genone@gentoo.org> libsandbox.c:
29 Also show resolved symlink names in the log.
30
31 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, libsandbox.c:
32 Seems -nostdlib was the problem with the constructor/destructor - remove it
33 from Makefile.am, and change the constructor/destructor names again.
34
35 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
36 Also rename the _init() and _fini() declarations.
37
38 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
39 Fixup the constructor/destructor function names again (they should be _init()
40 and _fini() it seems, and not being called caused sandbox_lib_path to be
41 unset, and thus breaking the execve() wrapper's LD_PRELOAD protection).
42 Add both the path in given SANDBOX_x variable, as well as its symlink
43 resolved path in init_env_entries(). Modify filter_path() to be able to
44 resolve paths without resolving symlinks, as well as to be able to resolve
45 symlinks. Fix a possible segfault in check_access(). Add symlink resolving
46 to check_access() resolving bug #31019. Add 'hack' for unlink, as the fix
47 for bug #31019 cause access violations if we try to remove a symlink that is
48 not in protected path, but points to a protected path. Fix a memory leak in
49 sandbox.c (sandbox_pids_file in main()). Fix the realpath() calls in main()
50 (sandbox.c) being unchecked. Fix the debug logname not having the pid in it
51 (pid_string was uninitialized). General syntax cleanups.
52
53 09 Mar 2005; Brian Harring <ferringb@gentoo.org> sandbox.c: Fixed the
54 infamous "pids file is not a regular file" w/out newline bug.
55
56 09 Mar 2005; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in:
57 Correct libc_version path detection, since it was screwing up if libdir !=
58 "/lib/".
59
60 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
61 Hack to make sure sandboxed process cannot remove a device node, bug #79836.
62
63 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am:
64 Fix symbols.in not added to dist.
65
66 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
67 getcwd.c, libsandbox.c, sandbox.c, sandbox.h, sandbox_futils.c:
68 White space fixes.
69
70 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
71 configure.in, getcwd.c, libsandbox.c, symbols.in:
72 Fix inverse test logic in canonicalize.c, use a strncpy. Fix gcc warning in
73 getcwd.c. Add symbols.in and logic to Makefile.am to generate symbol versions
74 for glibc and other libc's that use this. Update libsandbox.c to use these
75 symbol versions if available. Fix exec wrapper to re-export LD_PRELOAD if the
76 process unset it.
77
78 01 Mar 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
79 killed off _init and _fini in favor of
80 void __attribute__ ((constructor)) init_func and
81 void __attribute__ ((destructor)) closing_func. _(init|func) were deprecated.
82
83 06 Dec 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, libsandbox.c,
84 canonicalize.c, getcwd.c: Fixed compilation *again*. Hopefully cvs is done
85 having the hick-ups.
86
87 04 Dec 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, getcwd.c,
88 Makefile.am: Fixed compilation.
89
90 01 Dec 2004; Brian Harring <ferringb@gentoo.org> aclocal.m4:
91 Gutted the bugger so it stops checking for a c++ and fortran compiler.
92 Do *not* regenerate aclocal.m4 for making a release until a better
93 solution is created.
94
95 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, sandbox_futils.c:
96 Removal of more hardcoded paths.
97
98 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in,
99 sandbox_futils.c: tweaks to install sandbox.bashrc, and use it.
100
101 19 Nov 2004; Brian Harring <ferringb@gentoo.org>:
102 Sandbox is now autotooled, create-localdecls needs to be killed and the code
103 shifted into configure.in. Currently builds *one* libsandbox.so- if multiple
104 are desired (-m64 and -m32 for amd64), the ebuild should do it (imo).
105 To get to a point of testing, automake && autoconf; created requisite files w/
106 a(utomake|clocal)-1.8, and autoconf 2.59. Installs to /usr/, instead of
107 /lib and /usr/lib/portage/bin.
108
109 14 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox.c:
110 closing out bug #70225, potential overflow of the sandbox_pids_file var.
111
112 07 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c: c99 standard,
113 (think it was at least) allows intermixing of code and data segments. bug #70351
114 should be fixed by this.
115
116 03 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox_futils.c:
117 futils fix from bug #65201 via solar, and libsandbox log path checks via #69137
118
119 02 Aug 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Code from
120 Seth Robertson that tracked down all adjuct flags for read operations that
121 do not invoke a write operation.
122
123 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
124 Another fix from jstubbs regarding a free() on a stack variable for the
125 environment -- tracking now prevents extraneous free()'s segfault.
126
127 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
128 J. Stubbs tracked down a new bug where mkdir was failing to the patch on
129 the lstat in mkdir... it now only returns 0 or -1 as documented for mkdir.
130 Also remove the errno = ESUCCESS settings as documentation points out that
131 a library isn't allowed to do that.
132
133 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Added a
134 file_security_check() function to check random potential exploits on files
135 that sandbox is to load and read -- Normally sandboxpids.tmp. This fixes
136 the 'system-crippling' exploits (bug 21923) and catches a few other
137 potential problems.
138
139 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> Makefile: Updates for
140 32/64 bit sandbox. Made CC and LD '?=' values to allow passed in CC to work.
141
142 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c:
143 bug 42048 -- Fixed the lstat/errno conditions for mkdir <caleb@g.o>.
144 Added the 64/32 bit sandbox patch for AMD64 bug 32963 <brad/azarah>.
145
146 29 Feb 2004; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c :
147 Fix permissions and group of pids file and logs. Permissions should be 0664
148 and group should be 'portage'. Bug #34260.
149
150 28 Feb 2004; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
151 Besides a small cleanup, redo how we replace LD_PRELOAD in the environ passed
152 to the real execve (in our execve wrapper). Seems that on some arches (sparc
153 among others) do not allow us to tamper with the readonly copy passed to
154 execve, so pass our own copy of the environment. Bug #42290.
155
156 11 Jan 2004; Nicholas Jones <carpaski@gentoo.org> create-decls:
157 Changed tail to head and added a notice about duration of glibc check.
158
159 21 Dec 2003; Nicholas Jones <carpaski@gentoo.org> create-decls:
160 Changed the glibc subversion check to use /usr/bin/* instead of /bin/sh
161 as there isn't a guarentee that it is dynamic.
162
163 02 Nov 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
164 If 'file' passed to before_syscall(const char *func, const char *file) is
165 invalid, we should set errno to ENOENT, and not EINVAL. This should
166 close bug #32238.
167
168 14 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
169 Fix a bug that occurs mainly on 64bit arch, where the file passed to
170 the functions we wrap, is invalid, and then cause canonicalize to pass
171 garbage to before_syscall(), thanks to great detective work from
172 Andrea Luzzardi <al@sig11.org> (bug #29846).
173
174 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
175 Add a uClibc detection patch from Peter S. Mazinger <ps.m@gmx.net>.
176
177 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
178 Fix a bug in libsandbox.c 's checking in the rename wrapper - it basically
179 only checked the destination patch, and not the source, so we could move
180 a protected file to a unprotected directory, and then delete/modify it.
181 Thanks to Andrea Luzzardi (scox) <al@sig11.org>, bug #30992, for this fix.
182
183 12 Oct 2003; Nicholas Jones <carpaski@gentoo.org> sandbox.c :
184 Added python2.3 to the predict section/variable.
185
186 28 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
187 sandbox.h, sandbox_futils.c :
188 Add support to set the pids file via SANDBOX_PIDS_FILE at startup. If
189 it is not set, it will revert to its old value.
190
191 27 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
192 Fix our mkdir wrapper to check if the dir exist, and return EEXIST if so,
193 rather than failing with a violation, bug #29748.
194
195 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
196 Fix canonicalize() to ignore calls with path = "".
197
198 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c,
199 sandbox_futils.c, canonicalize.c :
200 Once again coreutils fails, as my systems had 2.5 kernel, the getcwd system
201 call handled strings larger than PATH_MAX (bug #21766). It however does not
202 work the same on 2.4 kernels.
203
204 To fix, I added the posix implementation of getcwd() (from glibc cvs) that
205 do not need the system call. We use the default getcwd() function via a
206 wrapper (egetcwd), and then lstat the returned path. If lstat fails, it
207 means the current directory was removed, OR that the the system call for
208 getcwd failed (curious is that it do not fail and return NULL or set
209 errno, but rather just truncate the retured directory - usually from the
210 start), and if so, we use the generic getcwd() function (__egetcwd). Note
211 that we do not use the generic version all the time, as it calls lstat()
212 a great number of times, and performance degrade much.
213
214 29 Jun 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls,
215 libsandbox.c :
216 Make sure SB_PATH_MAX will not wrap. Fix two possible memory leaks.
217
218 22 Jun 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, canonicalize.c
219 create-localdecls :
220 When checking path names of files accessed, we need to canonicalize it, else
221 it may be a symlink in a 'write allowed' directory pointing to a file in a
222 directory we should not have write access to.
223
224 With something like coreutils-5.0, we have two problems:
225 1) One of the tests checks if getcwd() can return a path longer than
226 PATH_MAX. This test then tries to create a dir which even while
227 created local (mkdir("conftest2")), it ends up being resolved with
228 a name that is much larger than PATH_MAX. The problem now is that
229 canonicalize() have undefined behaviour when the path was too long
230 (returned wrongly truncated paths, etc), and pass the wrong path to
231 before_syscall() (causing the bogus sandbox violations).
232 2) The ecanonicalize() function we used, along with the canonicalize()
233 function did not support longer than PATH_MAX. This is partly a
234 cause for 1), but the error checking (rather lack of it) of calls
235 to erealpath() in canonicalize() was the prime reason for 1).
236
237 As we do not use this canonicalized name to call the function, we resolve this
238 by fixing canonicalize() to do better error checking, and ecanonicalize() as
239 well as all functions in libsandbox.c to use a PATH_MAX of 'PATH_MAX * 2'.
240 While they will resolve paths properly now, and can check if a write/read is
241 allowed, the functions called from the sandboxed environment will still work
242 as expected.
243
244 This should resolve bug #21766.
245
246 06 Apr 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
247 For some reason sandbox fails with a 'open_wr' if you run 'locale -a' under
248 it (bug #16298).
249
250 Problem is that for some reason locale fopen's locale.alias with mode "rm".
251
252 -------------------------------------------------------
253 nosferatu root # grep fopen locale.log
254 fopen("/usr/share/locale/locale.alias", "rm"ACCESS DENIED open_wr: /usr/share/locale/locale.alias
255 nosferatu root #
256 --------------------------------------------------------
257
258 I checked the source of locale, but it have fopen with mode 'r', so
259 not sure where the "rm" mode comes from. Anyhow, changed the check in
260 before_syscall_open_char() to also see mode "rm" as readonly.
261
262 23 Feb 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
263
264 Add glibc-2.3 support.
265
266 22 Feb 2003; Martin Schlemmer <azarah@gentoo.org> sandbox.c :
267
268 Some /etc/ld.so.preload fixes. Just changed the #if defines to cover all
269 operations releated to preload, as well as only try to modify ld.so.preload
270 if we can. Also modify to write the pid to /tmp/sandboxpids.tmp even when
271 not using ld.so.preload. Fix to not write this instance of sandbox's pid
272 to /tmp/sandboxpids.tmp on exit if this is not the last sandbox running.
273
274 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> Makefile :
275
276 Changed the LD to CC for hppa.
277
278 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
279
280 Killed the previous changes I made.
281
282 17 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
283
284 Added parisc to BROKEN_RTLD_ARCHLIST to see if it we can fix the relocation probs.
285
286 09 Jan 2003; J Robert Ray <jrray@gentoo.org> sandbox.c :
287
288 Don't segfault if $HOME isn't set, set $HOME to "/" instead. Fixes bug 10868.
289
290 16 Dec 2002; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
291
292 Fix memory leak for mips, bug #12236. Thanks to Torgeir Hansen <torgeir@trenger.ro>
293 for this fix.
294
295 4 Dec 2002; J Robert Ray <jrray@gentoo.org> sandbox.h sandbox_futils.c :
296
297 sandbox_futils defined a dirname() function that was masking the same
298 function in glibc and was broken (e.g.: SANDBOX_DIR was being set to
299 '/usr/lib/portage/bi/'). Fixed function to return expected results and
300 renamed it to sb_dirname() to no longer mask the glibc function. Closes bug
301 11231.
302
303 4 Dec 2002; Martin Schlemmer <azarah@gentoo.org> :
304
305 Fix a segfault in libsandbox.c if canonicalize() was called with
306 first parameter = NULL.
307
308 1 Sep 2002; Martin Schlemmer <azarah@gentoo.org> :
309
310 Fix my braindead 'return 1;' in a void function. Updated sandbox.c,
311 cleanup() for this.
312
313 Change cleanup() in sandbox.c not to exit with fail status if
314 the pidsfile is missing. We really should still display sandbox
315 violations if they occured.
316
317 31 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
318
319 Update cleanup() in sandbox.c to remove the PIDSFILE if this is
320 the last sandbox running.
321
322 25 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
323
324 Major cleanups to mainly libsandbox.c again.
325
326 22 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
327
328 Add copyrights to sandbox.h and sandbox_futils.h. If wrong, the
329 parties involved should please contact me so that we can fix it.
330
331 Add opendir wrapper to libsandbox.c.
332
333 21 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
334
335 Do some more cleanups to ecanonicalize(), as it dropped filenames in
336 rare cases (after my symlink cleanups), and caused glibc to bork.
337 These fixes went into canonicalize.c.
338
339 20 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
340
341 Fix spawn_shell() and main() in sandbox.c to properly return fail
342 status.
343
344 19 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
345
346 The new canonicalize() function in libsandbox.c also resolved symlinks,
347 which caused on cleaning sandbox errors if the symlink pointed to a
348 file in the live root. Ripped out canonicalize() and realpath() from
349 glibc; removed the symlink stuff, and changed them to ecanonicalize()
350 and erealpath().
351
352 18 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
353
354 Ripped out all the wrappers, and implemented those of InstallWatch.
355 Losts of cleanups and bugfixes. Implement a execve that forces
356 $LIBSANDBOX in $LD_PRELOAD. We can now thus do away with the feared
357 /etc/ld.so.preload (*g*) ... Made the needed changes to sandbox.c,
358 sandbox.h and sandbox_futils.c. Rewrote the Makefile for most
359 parts; it now have an install target.
360
361 Reformat the whole thing to look somewhat like the reworked sandbox.c
362 and new sandbox.h and sandbox_futils.c from:
363
364 Brad House <brad@mainstreetsoftworks.com>.
365
366 Additional Copyrights now due to the InstallWatch code:
367
368 Copyright (C) 1998-9 Pancrazio `Ezio' de Mauro <p@demauro.net>

Properties

Name Value
svn:eol-style native
svn:keywords Author Date Id Revision

  ViewVC Help
Powered by ViewVC 1.1.20