/[path-sandbox]/trunk/ChangeLog
Gentoo

Contents of /trunk/ChangeLog

Parent Directory Parent Directory | Revision Log Revision Log


Revision 59 - (show annotations) (download)
Fri Apr 29 13:37:57 2005 UTC (9 years, 7 months ago) by azarah
File size: 17617 byte(s)
sandbox-1.2.3

1 # ChangeLog for Path Sandbox
2 # Copyright 1999-2005 Gentoo Foundation; Distributed under the GPL v2
3 # $Header$
4
5 * sandbox-1.2.3 (2005/04/29)
6
7 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> configure.in:
8 Do not check for (*&#$(* CXX or F77.
9
10 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
11 Do not append '/' to pathname in filter_path() if it already ends with it.
12
13 28 Apr 2005; Mike Frysinger <vapier@gentoo.org> Makefile.am, configure.in:
14 With az's help, clean up autotools to work with cross-compiling.
15
16 * sandbox-1.2.2 (2005/04/28)
17
18 28 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
19 Only check for /dev/{null,zero} for unlink hack, else ricers using /dev/shm
20 have issues; bug #90592.
21
22 * sandbox-1.2.1 (2005/04/23)
23
24 23 Apr 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
25 getcwd.c, libsandbox.c, localdecls.h, sandbox.h, sandbox_futils.c:
26 Make sure all functions used in libsandbox.c is declared static. Define
27 SB_STATIC in localdecls.h for this. Include sandbox_futils.c rather than
28 linking with its object. Hopefully this will fix bug #90153.
29
30 * sandbox-1.2 (2005/04/23)
31
32 22 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
33 Allow lchown a symlink in write-allowed path pointing to write-denied
34 target.
35
36 21 Mar 2005; Marius Mauch <genone@gentoo.org> libsandbox.c:
37 Also show resolved symlink names in the log.
38
39 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, libsandbox.c:
40 Seems -nostdlib was the problem with the constructor/destructor - remove it
41 from Makefile.am, and change the constructor/destructor names again.
42
43 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
44 Also rename the _init() and _fini() declarations.
45
46 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
47 Fixup the constructor/destructor function names again (they should be _init()
48 and _fini() it seems, and not being called caused sandbox_lib_path to be
49 unset, and thus breaking the execve() wrapper's LD_PRELOAD protection).
50 Add both the path in given SANDBOX_x variable, as well as its symlink
51 resolved path in init_env_entries(). Modify filter_path() to be able to
52 resolve paths without resolving symlinks, as well as to be able to resolve
53 symlinks. Fix a possible segfault in check_access(). Add symlink resolving
54 to check_access() resolving bug #31019. Add 'hack' for unlink, as the fix
55 for bug #31019 cause access violations if we try to remove a symlink that is
56 not in protected path, but points to a protected path. Fix a memory leak in
57 sandbox.c (sandbox_pids_file in main()). Fix the realpath() calls in main()
58 (sandbox.c) being unchecked. Fix the debug logname not having the pid in it
59 (pid_string was uninitialized). General syntax cleanups.
60
61 09 Mar 2005; Brian Harring <ferringb@gentoo.org> sandbox.c: Fixed the
62 infamous "pids file is not a regular file" w/out newline bug.
63
64 09 Mar 2005; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in:
65 Correct libc_version path detection, since it was screwing up if libdir !=
66 "/lib/".
67
68 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
69 Hack to make sure sandboxed process cannot remove a device node, bug #79836.
70
71 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am:
72 Fix symbols.in not added to dist.
73
74 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
75 getcwd.c, libsandbox.c, sandbox.c, sandbox.h, sandbox_futils.c:
76 White space fixes.
77
78 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
79 configure.in, getcwd.c, libsandbox.c, symbols.in:
80 Fix inverse test logic in canonicalize.c, use a strncpy. Fix gcc warning in
81 getcwd.c. Add symbols.in and logic to Makefile.am to generate symbol versions
82 for glibc and other libc's that use this. Update libsandbox.c to use these
83 symbol versions if available. Fix exec wrapper to re-export LD_PRELOAD if the
84 process unset it.
85
86 01 Mar 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
87 killed off _init and _fini in favor of
88 void __attribute__ ((constructor)) init_func and
89 void __attribute__ ((destructor)) closing_func. _(init|func) were deprecated.
90
91 06 Dec 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, libsandbox.c,
92 canonicalize.c, getcwd.c: Fixed compilation *again*. Hopefully cvs is done
93 having the hick-ups.
94
95 04 Dec 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, getcwd.c,
96 Makefile.am: Fixed compilation.
97
98 01 Dec 2004; Brian Harring <ferringb@gentoo.org> aclocal.m4:
99 Gutted the bugger so it stops checking for a c++ and fortran compiler.
100 Do *not* regenerate aclocal.m4 for making a release until a better
101 solution is created.
102
103 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, sandbox_futils.c:
104 Removal of more hardcoded paths.
105
106 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in,
107 sandbox_futils.c: tweaks to install sandbox.bashrc, and use it.
108
109 19 Nov 2004; Brian Harring <ferringb@gentoo.org>:
110 Sandbox is now autotooled, create-localdecls needs to be killed and the code
111 shifted into configure.in. Currently builds *one* libsandbox.so- if multiple
112 are desired (-m64 and -m32 for amd64), the ebuild should do it (imo).
113 To get to a point of testing, automake && autoconf; created requisite files w/
114 a(utomake|clocal)-1.8, and autoconf 2.59. Installs to /usr/, instead of
115 /lib and /usr/lib/portage/bin.
116
117 14 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox.c:
118 closing out bug #70225, potential overflow of the sandbox_pids_file var.
119
120 07 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c: c99 standard,
121 (think it was at least) allows intermixing of code and data segments. bug #70351
122 should be fixed by this.
123
124 03 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox_futils.c:
125 futils fix from bug #65201 via solar, and libsandbox log path checks via #69137
126
127 02 Aug 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Code from
128 Seth Robertson that tracked down all adjuct flags for read operations that
129 do not invoke a write operation.
130
131 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
132 Another fix from jstubbs regarding a free() on a stack variable for the
133 environment -- tracking now prevents extraneous free()'s segfault.
134
135 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
136 J. Stubbs tracked down a new bug where mkdir was failing to the patch on
137 the lstat in mkdir... it now only returns 0 or -1 as documented for mkdir.
138 Also remove the errno = ESUCCESS settings as documentation points out that
139 a library isn't allowed to do that.
140
141 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Added a
142 file_security_check() function to check random potential exploits on files
143 that sandbox is to load and read -- Normally sandboxpids.tmp. This fixes
144 the 'system-crippling' exploits (bug 21923) and catches a few other
145 potential problems.
146
147 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> Makefile: Updates for
148 32/64 bit sandbox. Made CC and LD '?=' values to allow passed in CC to work.
149
150 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c:
151 bug 42048 -- Fixed the lstat/errno conditions for mkdir <caleb@g.o>.
152 Added the 64/32 bit sandbox patch for AMD64 bug 32963 <brad/azarah>.
153
154 29 Feb 2004; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c :
155 Fix permissions and group of pids file and logs. Permissions should be 0664
156 and group should be 'portage'. Bug #34260.
157
158 28 Feb 2004; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
159 Besides a small cleanup, redo how we replace LD_PRELOAD in the environ passed
160 to the real execve (in our execve wrapper). Seems that on some arches (sparc
161 among others) do not allow us to tamper with the readonly copy passed to
162 execve, so pass our own copy of the environment. Bug #42290.
163
164 11 Jan 2004; Nicholas Jones <carpaski@gentoo.org> create-decls:
165 Changed tail to head and added a notice about duration of glibc check.
166
167 21 Dec 2003; Nicholas Jones <carpaski@gentoo.org> create-decls:
168 Changed the glibc subversion check to use /usr/bin/* instead of /bin/sh
169 as there isn't a guarentee that it is dynamic.
170
171 02 Nov 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
172 If 'file' passed to before_syscall(const char *func, const char *file) is
173 invalid, we should set errno to ENOENT, and not EINVAL. This should
174 close bug #32238.
175
176 14 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
177 Fix a bug that occurs mainly on 64bit arch, where the file passed to
178 the functions we wrap, is invalid, and then cause canonicalize to pass
179 garbage to before_syscall(), thanks to great detective work from
180 Andrea Luzzardi <al@sig11.org> (bug #29846).
181
182 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
183 Add a uClibc detection patch from Peter S. Mazinger <ps.m@gmx.net>.
184
185 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
186 Fix a bug in libsandbox.c 's checking in the rename wrapper - it basically
187 only checked the destination patch, and not the source, so we could move
188 a protected file to a unprotected directory, and then delete/modify it.
189 Thanks to Andrea Luzzardi (scox) <al@sig11.org>, bug #30992, for this fix.
190
191 12 Oct 2003; Nicholas Jones <carpaski@gentoo.org> sandbox.c :
192 Added python2.3 to the predict section/variable.
193
194 28 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
195 sandbox.h, sandbox_futils.c :
196 Add support to set the pids file via SANDBOX_PIDS_FILE at startup. If
197 it is not set, it will revert to its old value.
198
199 27 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
200 Fix our mkdir wrapper to check if the dir exist, and return EEXIST if so,
201 rather than failing with a violation, bug #29748.
202
203 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
204 Fix canonicalize() to ignore calls with path = "".
205
206 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c,
207 sandbox_futils.c, canonicalize.c :
208 Once again coreutils fails, as my systems had 2.5 kernel, the getcwd system
209 call handled strings larger than PATH_MAX (bug #21766). It however does not
210 work the same on 2.4 kernels.
211
212 To fix, I added the posix implementation of getcwd() (from glibc cvs) that
213 do not need the system call. We use the default getcwd() function via a
214 wrapper (egetcwd), and then lstat the returned path. If lstat fails, it
215 means the current directory was removed, OR that the the system call for
216 getcwd failed (curious is that it do not fail and return NULL or set
217 errno, but rather just truncate the retured directory - usually from the
218 start), and if so, we use the generic getcwd() function (__egetcwd). Note
219 that we do not use the generic version all the time, as it calls lstat()
220 a great number of times, and performance degrade much.
221
222 29 Jun 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls,
223 libsandbox.c :
224 Make sure SB_PATH_MAX will not wrap. Fix two possible memory leaks.
225
226 22 Jun 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, canonicalize.c
227 create-localdecls :
228 When checking path names of files accessed, we need to canonicalize it, else
229 it may be a symlink in a 'write allowed' directory pointing to a file in a
230 directory we should not have write access to.
231
232 With something like coreutils-5.0, we have two problems:
233 1) One of the tests checks if getcwd() can return a path longer than
234 PATH_MAX. This test then tries to create a dir which even while
235 created local (mkdir("conftest2")), it ends up being resolved with
236 a name that is much larger than PATH_MAX. The problem now is that
237 canonicalize() have undefined behaviour when the path was too long
238 (returned wrongly truncated paths, etc), and pass the wrong path to
239 before_syscall() (causing the bogus sandbox violations).
240 2) The ecanonicalize() function we used, along with the canonicalize()
241 function did not support longer than PATH_MAX. This is partly a
242 cause for 1), but the error checking (rather lack of it) of calls
243 to erealpath() in canonicalize() was the prime reason for 1).
244
245 As we do not use this canonicalized name to call the function, we resolve this
246 by fixing canonicalize() to do better error checking, and ecanonicalize() as
247 well as all functions in libsandbox.c to use a PATH_MAX of 'PATH_MAX * 2'.
248 While they will resolve paths properly now, and can check if a write/read is
249 allowed, the functions called from the sandboxed environment will still work
250 as expected.
251
252 This should resolve bug #21766.
253
254 06 Apr 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
255 For some reason sandbox fails with a 'open_wr' if you run 'locale -a' under
256 it (bug #16298).
257
258 Problem is that for some reason locale fopen's locale.alias with mode "rm".
259
260 -------------------------------------------------------
261 nosferatu root # grep fopen locale.log
262 fopen("/usr/share/locale/locale.alias", "rm"ACCESS DENIED open_wr: /usr/share/locale/locale.alias
263 nosferatu root #
264 --------------------------------------------------------
265
266 I checked the source of locale, but it have fopen with mode 'r', so
267 not sure where the "rm" mode comes from. Anyhow, changed the check in
268 before_syscall_open_char() to also see mode "rm" as readonly.
269
270 23 Feb 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
271
272 Add glibc-2.3 support.
273
274 22 Feb 2003; Martin Schlemmer <azarah@gentoo.org> sandbox.c :
275
276 Some /etc/ld.so.preload fixes. Just changed the #if defines to cover all
277 operations releated to preload, as well as only try to modify ld.so.preload
278 if we can. Also modify to write the pid to /tmp/sandboxpids.tmp even when
279 not using ld.so.preload. Fix to not write this instance of sandbox's pid
280 to /tmp/sandboxpids.tmp on exit if this is not the last sandbox running.
281
282 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> Makefile :
283
284 Changed the LD to CC for hppa.
285
286 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
287
288 Killed the previous changes I made.
289
290 17 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
291
292 Added parisc to BROKEN_RTLD_ARCHLIST to see if it we can fix the relocation probs.
293
294 09 Jan 2003; J Robert Ray <jrray@gentoo.org> sandbox.c :
295
296 Don't segfault if $HOME isn't set, set $HOME to "/" instead. Fixes bug 10868.
297
298 16 Dec 2002; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
299
300 Fix memory leak for mips, bug #12236. Thanks to Torgeir Hansen <torgeir@trenger.ro>
301 for this fix.
302
303 4 Dec 2002; J Robert Ray <jrray@gentoo.org> sandbox.h sandbox_futils.c :
304
305 sandbox_futils defined a dirname() function that was masking the same
306 function in glibc and was broken (e.g.: SANDBOX_DIR was being set to
307 '/usr/lib/portage/bi/'). Fixed function to return expected results and
308 renamed it to sb_dirname() to no longer mask the glibc function. Closes bug
309 11231.
310
311 4 Dec 2002; Martin Schlemmer <azarah@gentoo.org> :
312
313 Fix a segfault in libsandbox.c if canonicalize() was called with
314 first parameter = NULL.
315
316 1 Sep 2002; Martin Schlemmer <azarah@gentoo.org> :
317
318 Fix my braindead 'return 1;' in a void function. Updated sandbox.c,
319 cleanup() for this.
320
321 Change cleanup() in sandbox.c not to exit with fail status if
322 the pidsfile is missing. We really should still display sandbox
323 violations if they occured.
324
325 31 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
326
327 Update cleanup() in sandbox.c to remove the PIDSFILE if this is
328 the last sandbox running.
329
330 25 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
331
332 Major cleanups to mainly libsandbox.c again.
333
334 22 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
335
336 Add copyrights to sandbox.h and sandbox_futils.h. If wrong, the
337 parties involved should please contact me so that we can fix it.
338
339 Add opendir wrapper to libsandbox.c.
340
341 21 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
342
343 Do some more cleanups to ecanonicalize(), as it dropped filenames in
344 rare cases (after my symlink cleanups), and caused glibc to bork.
345 These fixes went into canonicalize.c.
346
347 20 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
348
349 Fix spawn_shell() and main() in sandbox.c to properly return fail
350 status.
351
352 19 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
353
354 The new canonicalize() function in libsandbox.c also resolved symlinks,
355 which caused on cleaning sandbox errors if the symlink pointed to a
356 file in the live root. Ripped out canonicalize() and realpath() from
357 glibc; removed the symlink stuff, and changed them to ecanonicalize()
358 and erealpath().
359
360 18 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
361
362 Ripped out all the wrappers, and implemented those of InstallWatch.
363 Losts of cleanups and bugfixes. Implement a execve that forces
364 $LIBSANDBOX in $LD_PRELOAD. We can now thus do away with the feared
365 /etc/ld.so.preload (*g*) ... Made the needed changes to sandbox.c,
366 sandbox.h and sandbox_futils.c. Rewrote the Makefile for most
367 parts; it now have an install target.
368
369 Reformat the whole thing to look somewhat like the reworked sandbox.c
370 and new sandbox.h and sandbox_futils.c from:
371
372 Brad House <brad@mainstreetsoftworks.com>.
373
374 Additional Copyrights now due to the InstallWatch code:
375
376 Copyright (C) 1998-9 Pancrazio `Ezio' de Mauro <p@demauro.net>

Properties

Name Value
svn:eol-style native
svn:keywords Author Date Id Revision

  ViewVC Help
Powered by ViewVC 1.1.20