/[path-sandbox]/trunk/ChangeLog
Gentoo

Contents of /trunk/ChangeLog

Parent Directory Parent Directory | Revision Log Revision Log


Revision 71 - (show annotations) (download)
Wed May 4 14:46:50 2005 UTC (9 years, 2 months ago) by azarah
File size: 18680 byte(s)
Do not reset already set LD_PRELOAD when starting sandbox.  If LD_PRELOAD is
already set, init of the env vars fails for some reason, so do this later on,
and do not warn (bug #91431).

1 # ChangeLog for Path Sandbox
2 # Copyright 1999-2005 Gentoo Foundation; Distributed under the GPL v2
3 # $Header$
4
5 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
6 sandbox.bashrc:
7 Do not reset already set LD_PRELOAD when starting sandbox. If LD_PRELOAD is
8 already set, init of the env vars fails for some reason, so do this later on,
9 and do not warn (bug #91431).
10
11 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
12 sandbox.bashrc:
13 Fixup sandbox and sandbox.bashrc to call bash with the proper .bashrc.
14
15 * sandbox-1.2.4 (2005/05/03)
16
17 03 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
18 Do not init the env entries with each call, as it creates too many calls to
19 lstat, etc. Should speedup things a bit, bug #91040.
20
21 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
22 Add /dev/pty to default write list. Noticed by Morfic.
23
24 02 May 2005; Mike Frysinger <vapier@gentoo.org> configure.in, localdecls.h,
25 sandbox.h:
26 uClibc doesn't support dlvsym() so add a configure check to make sure it doesn't
27 exist. Also update localdecls.h so BROKEN_RTLD_NEXT isn't defined in uClibc.
28
29 * sandbox-1.2.3 (2005/04/29)
30
31 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> configure.in:
32 Do not check for (*&#$(* CXX or F77.
33
34 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
35 Do not append '/' to pathname in filter_path() if it already ends with it.
36
37 28 Apr 2005; Mike Frysinger <vapier@gentoo.org> Makefile.am, configure.in:
38 With az's help, clean up autotools to work with cross-compiling.
39
40 * sandbox-1.2.2 (2005/04/28)
41
42 28 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
43 Only check for /dev/{null,zero} for unlink hack, else ricers using /dev/shm
44 have issues; bug #90592.
45
46 * sandbox-1.2.1 (2005/04/23)
47
48 23 Apr 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
49 getcwd.c, libsandbox.c, localdecls.h, sandbox.h, sandbox_futils.c:
50 Make sure all functions used in libsandbox.c is declared static. Define
51 SB_STATIC in localdecls.h for this. Include sandbox_futils.c rather than
52 linking with its object. Hopefully this will fix bug #90153.
53
54 * sandbox-1.2 (2005/04/23)
55
56 22 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
57 Allow lchown a symlink in write-allowed path pointing to write-denied
58 target.
59
60 21 Mar 2005; Marius Mauch <genone@gentoo.org> libsandbox.c:
61 Also show resolved symlink names in the log.
62
63 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, libsandbox.c:
64 Seems -nostdlib was the problem with the constructor/destructor - remove it
65 from Makefile.am, and change the constructor/destructor names again.
66
67 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
68 Also rename the _init() and _fini() declarations.
69
70 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
71 Fixup the constructor/destructor function names again (they should be _init()
72 and _fini() it seems, and not being called caused sandbox_lib_path to be
73 unset, and thus breaking the execve() wrapper's LD_PRELOAD protection).
74 Add both the path in given SANDBOX_x variable, as well as its symlink
75 resolved path in init_env_entries(). Modify filter_path() to be able to
76 resolve paths without resolving symlinks, as well as to be able to resolve
77 symlinks. Fix a possible segfault in check_access(). Add symlink resolving
78 to check_access() resolving bug #31019. Add 'hack' for unlink, as the fix
79 for bug #31019 cause access violations if we try to remove a symlink that is
80 not in protected path, but points to a protected path. Fix a memory leak in
81 sandbox.c (sandbox_pids_file in main()). Fix the realpath() calls in main()
82 (sandbox.c) being unchecked. Fix the debug logname not having the pid in it
83 (pid_string was uninitialized). General syntax cleanups.
84
85 09 Mar 2005; Brian Harring <ferringb@gentoo.org> sandbox.c: Fixed the
86 infamous "pids file is not a regular file" w/out newline bug.
87
88 09 Mar 2005; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in:
89 Correct libc_version path detection, since it was screwing up if libdir !=
90 "/lib/".
91
92 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
93 Hack to make sure sandboxed process cannot remove a device node, bug #79836.
94
95 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am:
96 Fix symbols.in not added to dist.
97
98 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
99 getcwd.c, libsandbox.c, sandbox.c, sandbox.h, sandbox_futils.c:
100 White space fixes.
101
102 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
103 configure.in, getcwd.c, libsandbox.c, symbols.in:
104 Fix inverse test logic in canonicalize.c, use a strncpy. Fix gcc warning in
105 getcwd.c. Add symbols.in and logic to Makefile.am to generate symbol versions
106 for glibc and other libc's that use this. Update libsandbox.c to use these
107 symbol versions if available. Fix exec wrapper to re-export LD_PRELOAD if the
108 process unset it.
109
110 01 Mar 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
111 killed off _init and _fini in favor of
112 void __attribute__ ((constructor)) init_func and
113 void __attribute__ ((destructor)) closing_func. _(init|func) were deprecated.
114
115 06 Dec 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, libsandbox.c,
116 canonicalize.c, getcwd.c: Fixed compilation *again*. Hopefully cvs is done
117 having the hick-ups.
118
119 04 Dec 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, getcwd.c,
120 Makefile.am: Fixed compilation.
121
122 01 Dec 2004; Brian Harring <ferringb@gentoo.org> aclocal.m4:
123 Gutted the bugger so it stops checking for a c++ and fortran compiler.
124 Do *not* regenerate aclocal.m4 for making a release until a better
125 solution is created.
126
127 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, sandbox_futils.c:
128 Removal of more hardcoded paths.
129
130 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in,
131 sandbox_futils.c: tweaks to install sandbox.bashrc, and use it.
132
133 19 Nov 2004; Brian Harring <ferringb@gentoo.org>:
134 Sandbox is now autotooled, create-localdecls needs to be killed and the code
135 shifted into configure.in. Currently builds *one* libsandbox.so- if multiple
136 are desired (-m64 and -m32 for amd64), the ebuild should do it (imo).
137 To get to a point of testing, automake && autoconf; created requisite files w/
138 a(utomake|clocal)-1.8, and autoconf 2.59. Installs to /usr/, instead of
139 /lib and /usr/lib/portage/bin.
140
141 14 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox.c:
142 closing out bug #70225, potential overflow of the sandbox_pids_file var.
143
144 07 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c: c99 standard,
145 (think it was at least) allows intermixing of code and data segments. bug #70351
146 should be fixed by this.
147
148 03 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox_futils.c:
149 futils fix from bug #65201 via solar, and libsandbox log path checks via #69137
150
151 02 Aug 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Code from
152 Seth Robertson that tracked down all adjuct flags for read operations that
153 do not invoke a write operation.
154
155 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
156 Another fix from jstubbs regarding a free() on a stack variable for the
157 environment -- tracking now prevents extraneous free()'s segfault.
158
159 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
160 J. Stubbs tracked down a new bug where mkdir was failing to the patch on
161 the lstat in mkdir... it now only returns 0 or -1 as documented for mkdir.
162 Also remove the errno = ESUCCESS settings as documentation points out that
163 a library isn't allowed to do that.
164
165 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Added a
166 file_security_check() function to check random potential exploits on files
167 that sandbox is to load and read -- Normally sandboxpids.tmp. This fixes
168 the 'system-crippling' exploits (bug 21923) and catches a few other
169 potential problems.
170
171 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> Makefile: Updates for
172 32/64 bit sandbox. Made CC and LD '?=' values to allow passed in CC to work.
173
174 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c:
175 bug 42048 -- Fixed the lstat/errno conditions for mkdir <caleb@g.o>.
176 Added the 64/32 bit sandbox patch for AMD64 bug 32963 <brad/azarah>.
177
178 29 Feb 2004; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c :
179 Fix permissions and group of pids file and logs. Permissions should be 0664
180 and group should be 'portage'. Bug #34260.
181
182 28 Feb 2004; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
183 Besides a small cleanup, redo how we replace LD_PRELOAD in the environ passed
184 to the real execve (in our execve wrapper). Seems that on some arches (sparc
185 among others) do not allow us to tamper with the readonly copy passed to
186 execve, so pass our own copy of the environment. Bug #42290.
187
188 11 Jan 2004; Nicholas Jones <carpaski@gentoo.org> create-decls:
189 Changed tail to head and added a notice about duration of glibc check.
190
191 21 Dec 2003; Nicholas Jones <carpaski@gentoo.org> create-decls:
192 Changed the glibc subversion check to use /usr/bin/* instead of /bin/sh
193 as there isn't a guarentee that it is dynamic.
194
195 02 Nov 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
196 If 'file' passed to before_syscall(const char *func, const char *file) is
197 invalid, we should set errno to ENOENT, and not EINVAL. This should
198 close bug #32238.
199
200 14 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
201 Fix a bug that occurs mainly on 64bit arch, where the file passed to
202 the functions we wrap, is invalid, and then cause canonicalize to pass
203 garbage to before_syscall(), thanks to great detective work from
204 Andrea Luzzardi <al@sig11.org> (bug #29846).
205
206 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
207 Add a uClibc detection patch from Peter S. Mazinger <ps.m@gmx.net>.
208
209 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
210 Fix a bug in libsandbox.c 's checking in the rename wrapper - it basically
211 only checked the destination patch, and not the source, so we could move
212 a protected file to a unprotected directory, and then delete/modify it.
213 Thanks to Andrea Luzzardi (scox) <al@sig11.org>, bug #30992, for this fix.
214
215 12 Oct 2003; Nicholas Jones <carpaski@gentoo.org> sandbox.c :
216 Added python2.3 to the predict section/variable.
217
218 28 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
219 sandbox.h, sandbox_futils.c :
220 Add support to set the pids file via SANDBOX_PIDS_FILE at startup. If
221 it is not set, it will revert to its old value.
222
223 27 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
224 Fix our mkdir wrapper to check if the dir exist, and return EEXIST if so,
225 rather than failing with a violation, bug #29748.
226
227 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
228 Fix canonicalize() to ignore calls with path = "".
229
230 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c,
231 sandbox_futils.c, canonicalize.c :
232 Once again coreutils fails, as my systems had 2.5 kernel, the getcwd system
233 call handled strings larger than PATH_MAX (bug #21766). It however does not
234 work the same on 2.4 kernels.
235
236 To fix, I added the posix implementation of getcwd() (from glibc cvs) that
237 do not need the system call. We use the default getcwd() function via a
238 wrapper (egetcwd), and then lstat the returned path. If lstat fails, it
239 means the current directory was removed, OR that the the system call for
240 getcwd failed (curious is that it do not fail and return NULL or set
241 errno, but rather just truncate the retured directory - usually from the
242 start), and if so, we use the generic getcwd() function (__egetcwd). Note
243 that we do not use the generic version all the time, as it calls lstat()
244 a great number of times, and performance degrade much.
245
246 29 Jun 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls,
247 libsandbox.c :
248 Make sure SB_PATH_MAX will not wrap. Fix two possible memory leaks.
249
250 22 Jun 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, canonicalize.c
251 create-localdecls :
252 When checking path names of files accessed, we need to canonicalize it, else
253 it may be a symlink in a 'write allowed' directory pointing to a file in a
254 directory we should not have write access to.
255
256 With something like coreutils-5.0, we have two problems:
257 1) One of the tests checks if getcwd() can return a path longer than
258 PATH_MAX. This test then tries to create a dir which even while
259 created local (mkdir("conftest2")), it ends up being resolved with
260 a name that is much larger than PATH_MAX. The problem now is that
261 canonicalize() have undefined behaviour when the path was too long
262 (returned wrongly truncated paths, etc), and pass the wrong path to
263 before_syscall() (causing the bogus sandbox violations).
264 2) The ecanonicalize() function we used, along with the canonicalize()
265 function did not support longer than PATH_MAX. This is partly a
266 cause for 1), but the error checking (rather lack of it) of calls
267 to erealpath() in canonicalize() was the prime reason for 1).
268
269 As we do not use this canonicalized name to call the function, we resolve this
270 by fixing canonicalize() to do better error checking, and ecanonicalize() as
271 well as all functions in libsandbox.c to use a PATH_MAX of 'PATH_MAX * 2'.
272 While they will resolve paths properly now, and can check if a write/read is
273 allowed, the functions called from the sandboxed environment will still work
274 as expected.
275
276 This should resolve bug #21766.
277
278 06 Apr 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
279 For some reason sandbox fails with a 'open_wr' if you run 'locale -a' under
280 it (bug #16298).
281
282 Problem is that for some reason locale fopen's locale.alias with mode "rm".
283
284 -------------------------------------------------------
285 nosferatu root # grep fopen locale.log
286 fopen("/usr/share/locale/locale.alias", "rm"ACCESS DENIED open_wr: /usr/share/locale/locale.alias
287 nosferatu root #
288 --------------------------------------------------------
289
290 I checked the source of locale, but it have fopen with mode 'r', so
291 not sure where the "rm" mode comes from. Anyhow, changed the check in
292 before_syscall_open_char() to also see mode "rm" as readonly.
293
294 23 Feb 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
295
296 Add glibc-2.3 support.
297
298 22 Feb 2003; Martin Schlemmer <azarah@gentoo.org> sandbox.c :
299
300 Some /etc/ld.so.preload fixes. Just changed the #if defines to cover all
301 operations releated to preload, as well as only try to modify ld.so.preload
302 if we can. Also modify to write the pid to /tmp/sandboxpids.tmp even when
303 not using ld.so.preload. Fix to not write this instance of sandbox's pid
304 to /tmp/sandboxpids.tmp on exit if this is not the last sandbox running.
305
306 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> Makefile :
307
308 Changed the LD to CC for hppa.
309
310 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
311
312 Killed the previous changes I made.
313
314 17 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
315
316 Added parisc to BROKEN_RTLD_ARCHLIST to see if it we can fix the relocation probs.
317
318 09 Jan 2003; J Robert Ray <jrray@gentoo.org> sandbox.c :
319
320 Don't segfault if $HOME isn't set, set $HOME to "/" instead. Fixes bug 10868.
321
322 16 Dec 2002; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
323
324 Fix memory leak for mips, bug #12236. Thanks to Torgeir Hansen <torgeir@trenger.ro>
325 for this fix.
326
327 4 Dec 2002; J Robert Ray <jrray@gentoo.org> sandbox.h sandbox_futils.c :
328
329 sandbox_futils defined a dirname() function that was masking the same
330 function in glibc and was broken (e.g.: SANDBOX_DIR was being set to
331 '/usr/lib/portage/bi/'). Fixed function to return expected results and
332 renamed it to sb_dirname() to no longer mask the glibc function. Closes bug
333 11231.
334
335 4 Dec 2002; Martin Schlemmer <azarah@gentoo.org> :
336
337 Fix a segfault in libsandbox.c if canonicalize() was called with
338 first parameter = NULL.
339
340 1 Sep 2002; Martin Schlemmer <azarah@gentoo.org> :
341
342 Fix my braindead 'return 1;' in a void function. Updated sandbox.c,
343 cleanup() for this.
344
345 Change cleanup() in sandbox.c not to exit with fail status if
346 the pidsfile is missing. We really should still display sandbox
347 violations if they occured.
348
349 31 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
350
351 Update cleanup() in sandbox.c to remove the PIDSFILE if this is
352 the last sandbox running.
353
354 25 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
355
356 Major cleanups to mainly libsandbox.c again.
357
358 22 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
359
360 Add copyrights to sandbox.h and sandbox_futils.h. If wrong, the
361 parties involved should please contact me so that we can fix it.
362
363 Add opendir wrapper to libsandbox.c.
364
365 21 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
366
367 Do some more cleanups to ecanonicalize(), as it dropped filenames in
368 rare cases (after my symlink cleanups), and caused glibc to bork.
369 These fixes went into canonicalize.c.
370
371 20 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
372
373 Fix spawn_shell() and main() in sandbox.c to properly return fail
374 status.
375
376 19 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
377
378 The new canonicalize() function in libsandbox.c also resolved symlinks,
379 which caused on cleaning sandbox errors if the symlink pointed to a
380 file in the live root. Ripped out canonicalize() and realpath() from
381 glibc; removed the symlink stuff, and changed them to ecanonicalize()
382 and erealpath().
383
384 18 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
385
386 Ripped out all the wrappers, and implemented those of InstallWatch.
387 Losts of cleanups and bugfixes. Implement a execve that forces
388 $LIBSANDBOX in $LD_PRELOAD. We can now thus do away with the feared
389 /etc/ld.so.preload (*g*) ... Made the needed changes to sandbox.c,
390 sandbox.h and sandbox_futils.c. Rewrote the Makefile for most
391 parts; it now have an install target.
392
393 Reformat the whole thing to look somewhat like the reworked sandbox.c
394 and new sandbox.h and sandbox_futils.c from:
395
396 Brad House <brad@mainstreetsoftworks.com>.
397
398 Additional Copyrights now due to the InstallWatch code:
399
400 Copyright (C) 1998-9 Pancrazio `Ezio' de Mauro <p@demauro.net>

Properties

Name Value
svn:eol-style native
svn:keywords Author Date Id Revision

  ViewVC Help
Powered by ViewVC 1.1.20