/[path-sandbox]/trunk/ChangeLog
Gentoo

Contents of /trunk/ChangeLog

Parent Directory Parent Directory | Revision Log Revision Log


Revision 78 - (show annotations) (download)
Tue May 10 07:08:21 2005 UTC (9 years, 2 months ago) by azarah
File size: 19500 byte(s)
Do not use LD_PRELOAD if it contains libtsocks.so, as it breaks sandbox
for some odd reason, bug #91541.

1 # ChangeLog for Path Sandbox
2 # Copyright 1999-2005 Gentoo Foundation; Distributed under the GPL v2
3 # $Header$
4
5 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
6 Do not use LD_PRELOAD if it contains libtsocks.so, as it breaks sandbox
7 for some odd reason, bug #91541.
8
9 09 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
10 Fix typo (sizeof -> strlen).
11
12 08 May 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
13 rewrote the sbcontext caching code so it accounts for env changes since lib
14 initialization.
15
16 05 May 2005; Martin Schlemmer <azarah@gentoo.org> configure.in, libctest.c:
17 We create libctest.c via configure, so no need to keep it around. Do some
18 cleanup related to libctest.c and libctest during configure.
19
20 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
21 Add rename support of symlinks pointing to protected files/directories.
22
23 * sandbox-1.2.5 (2005/05/04)
24
25 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
26 sandbox.bashrc:
27 Do not reset already set LD_PRELOAD when starting sandbox. If LD_PRELOAD is
28 already set, init of the env vars fails for some reason, so do this later on,
29 and do not warn (bug #91431).
30
31 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
32 sandbox.bashrc:
33 Fixup sandbox and sandbox.bashrc to call bash with the proper .bashrc.
34
35 * sandbox-1.2.4 (2005/05/03)
36
37 03 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
38 Do not init the env entries with each call, as it creates too many calls to
39 lstat, etc. Should speedup things a bit, bug #91040.
40
41 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
42 Add /dev/pty to default write list. Noticed by Morfic.
43
44 02 May 2005; Mike Frysinger <vapier@gentoo.org> configure.in, localdecls.h,
45 sandbox.h:
46 uClibc doesn't support dlvsym() so add a configure check to make sure it doesn't
47 exist. Also update localdecls.h so BROKEN_RTLD_NEXT isn't defined in uClibc.
48
49 * sandbox-1.2.3 (2005/04/29)
50
51 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> configure.in:
52 Do not check for (*&#$(* CXX or F77.
53
54 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
55 Do not append '/' to pathname in filter_path() if it already ends with it.
56
57 28 Apr 2005; Mike Frysinger <vapier@gentoo.org> Makefile.am, configure.in:
58 With az's help, clean up autotools to work with cross-compiling.
59
60 * sandbox-1.2.2 (2005/04/28)
61
62 28 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
63 Only check for /dev/{null,zero} for unlink hack, else ricers using /dev/shm
64 have issues; bug #90592.
65
66 * sandbox-1.2.1 (2005/04/23)
67
68 23 Apr 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
69 getcwd.c, libsandbox.c, localdecls.h, sandbox.h, sandbox_futils.c:
70 Make sure all functions used in libsandbox.c is declared static. Define
71 SB_STATIC in localdecls.h for this. Include sandbox_futils.c rather than
72 linking with its object. Hopefully this will fix bug #90153.
73
74 * sandbox-1.2 (2005/04/23)
75
76 22 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
77 Allow lchown a symlink in write-allowed path pointing to write-denied
78 target.
79
80 21 Mar 2005; Marius Mauch <genone@gentoo.org> libsandbox.c:
81 Also show resolved symlink names in the log.
82
83 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, libsandbox.c:
84 Seems -nostdlib was the problem with the constructor/destructor - remove it
85 from Makefile.am, and change the constructor/destructor names again.
86
87 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
88 Also rename the _init() and _fini() declarations.
89
90 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
91 Fixup the constructor/destructor function names again (they should be _init()
92 and _fini() it seems, and not being called caused sandbox_lib_path to be
93 unset, and thus breaking the execve() wrapper's LD_PRELOAD protection).
94 Add both the path in given SANDBOX_x variable, as well as its symlink
95 resolved path in init_env_entries(). Modify filter_path() to be able to
96 resolve paths without resolving symlinks, as well as to be able to resolve
97 symlinks. Fix a possible segfault in check_access(). Add symlink resolving
98 to check_access() resolving bug #31019. Add 'hack' for unlink, as the fix
99 for bug #31019 cause access violations if we try to remove a symlink that is
100 not in protected path, but points to a protected path. Fix a memory leak in
101 sandbox.c (sandbox_pids_file in main()). Fix the realpath() calls in main()
102 (sandbox.c) being unchecked. Fix the debug logname not having the pid in it
103 (pid_string was uninitialized). General syntax cleanups.
104
105 09 Mar 2005; Brian Harring <ferringb@gentoo.org> sandbox.c: Fixed the
106 infamous "pids file is not a regular file" w/out newline bug.
107
108 09 Mar 2005; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in:
109 Correct libc_version path detection, since it was screwing up if libdir !=
110 "/lib/".
111
112 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
113 Hack to make sure sandboxed process cannot remove a device node, bug #79836.
114
115 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am:
116 Fix symbols.in not added to dist.
117
118 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
119 getcwd.c, libsandbox.c, sandbox.c, sandbox.h, sandbox_futils.c:
120 White space fixes.
121
122 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
123 configure.in, getcwd.c, libsandbox.c, symbols.in:
124 Fix inverse test logic in canonicalize.c, use a strncpy. Fix gcc warning in
125 getcwd.c. Add symbols.in and logic to Makefile.am to generate symbol versions
126 for glibc and other libc's that use this. Update libsandbox.c to use these
127 symbol versions if available. Fix exec wrapper to re-export LD_PRELOAD if the
128 process unset it.
129
130 01 Mar 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
131 killed off _init and _fini in favor of
132 void __attribute__ ((constructor)) init_func and
133 void __attribute__ ((destructor)) closing_func. _(init|func) were deprecated.
134
135 06 Dec 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, libsandbox.c,
136 canonicalize.c, getcwd.c: Fixed compilation *again*. Hopefully cvs is done
137 having the hick-ups.
138
139 04 Dec 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, getcwd.c,
140 Makefile.am: Fixed compilation.
141
142 01 Dec 2004; Brian Harring <ferringb@gentoo.org> aclocal.m4:
143 Gutted the bugger so it stops checking for a c++ and fortran compiler.
144 Do *not* regenerate aclocal.m4 for making a release until a better
145 solution is created.
146
147 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, sandbox_futils.c:
148 Removal of more hardcoded paths.
149
150 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in,
151 sandbox_futils.c: tweaks to install sandbox.bashrc, and use it.
152
153 19 Nov 2004; Brian Harring <ferringb@gentoo.org>:
154 Sandbox is now autotooled, create-localdecls needs to be killed and the code
155 shifted into configure.in. Currently builds *one* libsandbox.so- if multiple
156 are desired (-m64 and -m32 for amd64), the ebuild should do it (imo).
157 To get to a point of testing, automake && autoconf; created requisite files w/
158 a(utomake|clocal)-1.8, and autoconf 2.59. Installs to /usr/, instead of
159 /lib and /usr/lib/portage/bin.
160
161 14 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox.c:
162 closing out bug #70225, potential overflow of the sandbox_pids_file var.
163
164 07 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c: c99 standard,
165 (think it was at least) allows intermixing of code and data segments. bug #70351
166 should be fixed by this.
167
168 03 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox_futils.c:
169 futils fix from bug #65201 via solar, and libsandbox log path checks via #69137
170
171 02 Aug 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Code from
172 Seth Robertson that tracked down all adjuct flags for read operations that
173 do not invoke a write operation.
174
175 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
176 Another fix from jstubbs regarding a free() on a stack variable for the
177 environment -- tracking now prevents extraneous free()'s segfault.
178
179 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
180 J. Stubbs tracked down a new bug where mkdir was failing to the patch on
181 the lstat in mkdir... it now only returns 0 or -1 as documented for mkdir.
182 Also remove the errno = ESUCCESS settings as documentation points out that
183 a library isn't allowed to do that.
184
185 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Added a
186 file_security_check() function to check random potential exploits on files
187 that sandbox is to load and read -- Normally sandboxpids.tmp. This fixes
188 the 'system-crippling' exploits (bug 21923) and catches a few other
189 potential problems.
190
191 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> Makefile: Updates for
192 32/64 bit sandbox. Made CC and LD '?=' values to allow passed in CC to work.
193
194 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c:
195 bug 42048 -- Fixed the lstat/errno conditions for mkdir <caleb@g.o>.
196 Added the 64/32 bit sandbox patch for AMD64 bug 32963 <brad/azarah>.
197
198 29 Feb 2004; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c :
199 Fix permissions and group of pids file and logs. Permissions should be 0664
200 and group should be 'portage'. Bug #34260.
201
202 28 Feb 2004; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
203 Besides a small cleanup, redo how we replace LD_PRELOAD in the environ passed
204 to the real execve (in our execve wrapper). Seems that on some arches (sparc
205 among others) do not allow us to tamper with the readonly copy passed to
206 execve, so pass our own copy of the environment. Bug #42290.
207
208 11 Jan 2004; Nicholas Jones <carpaski@gentoo.org> create-decls:
209 Changed tail to head and added a notice about duration of glibc check.
210
211 21 Dec 2003; Nicholas Jones <carpaski@gentoo.org> create-decls:
212 Changed the glibc subversion check to use /usr/bin/* instead of /bin/sh
213 as there isn't a guarentee that it is dynamic.
214
215 02 Nov 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
216 If 'file' passed to before_syscall(const char *func, const char *file) is
217 invalid, we should set errno to ENOENT, and not EINVAL. This should
218 close bug #32238.
219
220 14 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
221 Fix a bug that occurs mainly on 64bit arch, where the file passed to
222 the functions we wrap, is invalid, and then cause canonicalize to pass
223 garbage to before_syscall(), thanks to great detective work from
224 Andrea Luzzardi <al@sig11.org> (bug #29846).
225
226 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
227 Add a uClibc detection patch from Peter S. Mazinger <ps.m@gmx.net>.
228
229 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
230 Fix a bug in libsandbox.c 's checking in the rename wrapper - it basically
231 only checked the destination patch, and not the source, so we could move
232 a protected file to a unprotected directory, and then delete/modify it.
233 Thanks to Andrea Luzzardi (scox) <al@sig11.org>, bug #30992, for this fix.
234
235 12 Oct 2003; Nicholas Jones <carpaski@gentoo.org> sandbox.c :
236 Added python2.3 to the predict section/variable.
237
238 28 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
239 sandbox.h, sandbox_futils.c :
240 Add support to set the pids file via SANDBOX_PIDS_FILE at startup. If
241 it is not set, it will revert to its old value.
242
243 27 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
244 Fix our mkdir wrapper to check if the dir exist, and return EEXIST if so,
245 rather than failing with a violation, bug #29748.
246
247 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
248 Fix canonicalize() to ignore calls with path = "".
249
250 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c,
251 sandbox_futils.c, canonicalize.c :
252 Once again coreutils fails, as my systems had 2.5 kernel, the getcwd system
253 call handled strings larger than PATH_MAX (bug #21766). It however does not
254 work the same on 2.4 kernels.
255
256 To fix, I added the posix implementation of getcwd() (from glibc cvs) that
257 do not need the system call. We use the default getcwd() function via a
258 wrapper (egetcwd), and then lstat the returned path. If lstat fails, it
259 means the current directory was removed, OR that the the system call for
260 getcwd failed (curious is that it do not fail and return NULL or set
261 errno, but rather just truncate the retured directory - usually from the
262 start), and if so, we use the generic getcwd() function (__egetcwd). Note
263 that we do not use the generic version all the time, as it calls lstat()
264 a great number of times, and performance degrade much.
265
266 29 Jun 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls,
267 libsandbox.c :
268 Make sure SB_PATH_MAX will not wrap. Fix two possible memory leaks.
269
270 22 Jun 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, canonicalize.c
271 create-localdecls :
272 When checking path names of files accessed, we need to canonicalize it, else
273 it may be a symlink in a 'write allowed' directory pointing to a file in a
274 directory we should not have write access to.
275
276 With something like coreutils-5.0, we have two problems:
277 1) One of the tests checks if getcwd() can return a path longer than
278 PATH_MAX. This test then tries to create a dir which even while
279 created local (mkdir("conftest2")), it ends up being resolved with
280 a name that is much larger than PATH_MAX. The problem now is that
281 canonicalize() have undefined behaviour when the path was too long
282 (returned wrongly truncated paths, etc), and pass the wrong path to
283 before_syscall() (causing the bogus sandbox violations).
284 2) The ecanonicalize() function we used, along with the canonicalize()
285 function did not support longer than PATH_MAX. This is partly a
286 cause for 1), but the error checking (rather lack of it) of calls
287 to erealpath() in canonicalize() was the prime reason for 1).
288
289 As we do not use this canonicalized name to call the function, we resolve this
290 by fixing canonicalize() to do better error checking, and ecanonicalize() as
291 well as all functions in libsandbox.c to use a PATH_MAX of 'PATH_MAX * 2'.
292 While they will resolve paths properly now, and can check if a write/read is
293 allowed, the functions called from the sandboxed environment will still work
294 as expected.
295
296 This should resolve bug #21766.
297
298 06 Apr 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
299 For some reason sandbox fails with a 'open_wr' if you run 'locale -a' under
300 it (bug #16298).
301
302 Problem is that for some reason locale fopen's locale.alias with mode "rm".
303
304 -------------------------------------------------------
305 nosferatu root # grep fopen locale.log
306 fopen("/usr/share/locale/locale.alias", "rm"ACCESS DENIED open_wr: /usr/share/locale/locale.alias
307 nosferatu root #
308 --------------------------------------------------------
309
310 I checked the source of locale, but it have fopen with mode 'r', so
311 not sure where the "rm" mode comes from. Anyhow, changed the check in
312 before_syscall_open_char() to also see mode "rm" as readonly.
313
314 23 Feb 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
315
316 Add glibc-2.3 support.
317
318 22 Feb 2003; Martin Schlemmer <azarah@gentoo.org> sandbox.c :
319
320 Some /etc/ld.so.preload fixes. Just changed the #if defines to cover all
321 operations releated to preload, as well as only try to modify ld.so.preload
322 if we can. Also modify to write the pid to /tmp/sandboxpids.tmp even when
323 not using ld.so.preload. Fix to not write this instance of sandbox's pid
324 to /tmp/sandboxpids.tmp on exit if this is not the last sandbox running.
325
326 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> Makefile :
327
328 Changed the LD to CC for hppa.
329
330 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
331
332 Killed the previous changes I made.
333
334 17 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
335
336 Added parisc to BROKEN_RTLD_ARCHLIST to see if it we can fix the relocation probs.
337
338 09 Jan 2003; J Robert Ray <jrray@gentoo.org> sandbox.c :
339
340 Don't segfault if $HOME isn't set, set $HOME to "/" instead. Fixes bug 10868.
341
342 16 Dec 2002; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
343
344 Fix memory leak for mips, bug #12236. Thanks to Torgeir Hansen <torgeir@trenger.ro>
345 for this fix.
346
347 4 Dec 2002; J Robert Ray <jrray@gentoo.org> sandbox.h sandbox_futils.c :
348
349 sandbox_futils defined a dirname() function that was masking the same
350 function in glibc and was broken (e.g.: SANDBOX_DIR was being set to
351 '/usr/lib/portage/bi/'). Fixed function to return expected results and
352 renamed it to sb_dirname() to no longer mask the glibc function. Closes bug
353 11231.
354
355 4 Dec 2002; Martin Schlemmer <azarah@gentoo.org> :
356
357 Fix a segfault in libsandbox.c if canonicalize() was called with
358 first parameter = NULL.
359
360 1 Sep 2002; Martin Schlemmer <azarah@gentoo.org> :
361
362 Fix my braindead 'return 1;' in a void function. Updated sandbox.c,
363 cleanup() for this.
364
365 Change cleanup() in sandbox.c not to exit with fail status if
366 the pidsfile is missing. We really should still display sandbox
367 violations if they occured.
368
369 31 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
370
371 Update cleanup() in sandbox.c to remove the PIDSFILE if this is
372 the last sandbox running.
373
374 25 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
375
376 Major cleanups to mainly libsandbox.c again.
377
378 22 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
379
380 Add copyrights to sandbox.h and sandbox_futils.h. If wrong, the
381 parties involved should please contact me so that we can fix it.
382
383 Add opendir wrapper to libsandbox.c.
384
385 21 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
386
387 Do some more cleanups to ecanonicalize(), as it dropped filenames in
388 rare cases (after my symlink cleanups), and caused glibc to bork.
389 These fixes went into canonicalize.c.
390
391 20 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
392
393 Fix spawn_shell() and main() in sandbox.c to properly return fail
394 status.
395
396 19 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
397
398 The new canonicalize() function in libsandbox.c also resolved symlinks,
399 which caused on cleaning sandbox errors if the symlink pointed to a
400 file in the live root. Ripped out canonicalize() and realpath() from
401 glibc; removed the symlink stuff, and changed them to ecanonicalize()
402 and erealpath().
403
404 18 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
405
406 Ripped out all the wrappers, and implemented those of InstallWatch.
407 Losts of cleanups and bugfixes. Implement a execve that forces
408 $LIBSANDBOX in $LD_PRELOAD. We can now thus do away with the feared
409 /etc/ld.so.preload (*g*) ... Made the needed changes to sandbox.c,
410 sandbox.h and sandbox_futils.c. Rewrote the Makefile for most
411 parts; it now have an install target.
412
413 Reformat the whole thing to look somewhat like the reworked sandbox.c
414 and new sandbox.h and sandbox_futils.c from:
415
416 Brad House <brad@mainstreetsoftworks.com>.
417
418 Additional Copyrights now due to the InstallWatch code:
419
420 Copyright (C) 1998-9 Pancrazio `Ezio' de Mauro <p@demauro.net>

Properties

Name Value
svn:eol-style native
svn:keywords Author Date Id Revision

  ViewVC Help
Powered by ViewVC 1.1.20