/[path-sandbox]/trunk/ChangeLog
Gentoo

Contents of /trunk/ChangeLog

Parent Directory Parent Directory | Revision Log Revision Log


Revision 82 - (show annotations) (download)
Tue May 10 07:38:49 2005 UTC (9 years, 2 months ago) by azarah
File size: 19711 byte(s)
Fix typo in code that checks if we got valid group information, causing a
segmentation fault, bug #91637.

1 # ChangeLog for Path Sandbox
2 # Copyright 1999-2005 Gentoo Foundation; Distributed under the GPL v2
3 # $Header$
4
5 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
6 Fix typo in code that checks if we got valid group information, causing a
7 segmentation fault, bug #91637.
8
9 * sandbox-1.2.6 (2005/05/10)
10
11 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
12 Do not use LD_PRELOAD if it contains libtsocks.so, as it breaks sandbox
13 for some odd reason, bug #91541.
14
15 09 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
16 Fix typo (sizeof -> strlen).
17
18 08 May 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
19 rewrote the sbcontext caching code so it accounts for env changes since lib
20 initialization.
21
22 05 May 2005; Martin Schlemmer <azarah@gentoo.org> configure.in, libctest.c:
23 We create libctest.c via configure, so no need to keep it around. Do some
24 cleanup related to libctest.c and libctest during configure.
25
26 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
27 Add rename support of symlinks pointing to protected files/directories.
28
29 * sandbox-1.2.5 (2005/05/04)
30
31 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
32 sandbox.bashrc:
33 Do not reset already set LD_PRELOAD when starting sandbox. If LD_PRELOAD is
34 already set, init of the env vars fails for some reason, so do this later on,
35 and do not warn (bug #91431).
36
37 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
38 sandbox.bashrc:
39 Fixup sandbox and sandbox.bashrc to call bash with the proper .bashrc.
40
41 * sandbox-1.2.4 (2005/05/03)
42
43 03 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
44 Do not init the env entries with each call, as it creates too many calls to
45 lstat, etc. Should speedup things a bit, bug #91040.
46
47 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
48 Add /dev/pty to default write list. Noticed by Morfic.
49
50 02 May 2005; Mike Frysinger <vapier@gentoo.org> configure.in, localdecls.h,
51 sandbox.h:
52 uClibc doesn't support dlvsym() so add a configure check to make sure it doesn't
53 exist. Also update localdecls.h so BROKEN_RTLD_NEXT isn't defined in uClibc.
54
55 * sandbox-1.2.3 (2005/04/29)
56
57 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> configure.in:
58 Do not check for (*&#$(* CXX or F77.
59
60 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
61 Do not append '/' to pathname in filter_path() if it already ends with it.
62
63 28 Apr 2005; Mike Frysinger <vapier@gentoo.org> Makefile.am, configure.in:
64 With az's help, clean up autotools to work with cross-compiling.
65
66 * sandbox-1.2.2 (2005/04/28)
67
68 28 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
69 Only check for /dev/{null,zero} for unlink hack, else ricers using /dev/shm
70 have issues; bug #90592.
71
72 * sandbox-1.2.1 (2005/04/23)
73
74 23 Apr 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
75 getcwd.c, libsandbox.c, localdecls.h, sandbox.h, sandbox_futils.c:
76 Make sure all functions used in libsandbox.c is declared static. Define
77 SB_STATIC in localdecls.h for this. Include sandbox_futils.c rather than
78 linking with its object. Hopefully this will fix bug #90153.
79
80 * sandbox-1.2 (2005/04/23)
81
82 22 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
83 Allow lchown a symlink in write-allowed path pointing to write-denied
84 target.
85
86 21 Mar 2005; Marius Mauch <genone@gentoo.org> libsandbox.c:
87 Also show resolved symlink names in the log.
88
89 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, libsandbox.c:
90 Seems -nostdlib was the problem with the constructor/destructor - remove it
91 from Makefile.am, and change the constructor/destructor names again.
92
93 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
94 Also rename the _init() and _fini() declarations.
95
96 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
97 Fixup the constructor/destructor function names again (they should be _init()
98 and _fini() it seems, and not being called caused sandbox_lib_path to be
99 unset, and thus breaking the execve() wrapper's LD_PRELOAD protection).
100 Add both the path in given SANDBOX_x variable, as well as its symlink
101 resolved path in init_env_entries(). Modify filter_path() to be able to
102 resolve paths without resolving symlinks, as well as to be able to resolve
103 symlinks. Fix a possible segfault in check_access(). Add symlink resolving
104 to check_access() resolving bug #31019. Add 'hack' for unlink, as the fix
105 for bug #31019 cause access violations if we try to remove a symlink that is
106 not in protected path, but points to a protected path. Fix a memory leak in
107 sandbox.c (sandbox_pids_file in main()). Fix the realpath() calls in main()
108 (sandbox.c) being unchecked. Fix the debug logname not having the pid in it
109 (pid_string was uninitialized). General syntax cleanups.
110
111 09 Mar 2005; Brian Harring <ferringb@gentoo.org> sandbox.c: Fixed the
112 infamous "pids file is not a regular file" w/out newline bug.
113
114 09 Mar 2005; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in:
115 Correct libc_version path detection, since it was screwing up if libdir !=
116 "/lib/".
117
118 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
119 Hack to make sure sandboxed process cannot remove a device node, bug #79836.
120
121 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am:
122 Fix symbols.in not added to dist.
123
124 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
125 getcwd.c, libsandbox.c, sandbox.c, sandbox.h, sandbox_futils.c:
126 White space fixes.
127
128 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
129 configure.in, getcwd.c, libsandbox.c, symbols.in:
130 Fix inverse test logic in canonicalize.c, use a strncpy. Fix gcc warning in
131 getcwd.c. Add symbols.in and logic to Makefile.am to generate symbol versions
132 for glibc and other libc's that use this. Update libsandbox.c to use these
133 symbol versions if available. Fix exec wrapper to re-export LD_PRELOAD if the
134 process unset it.
135
136 01 Mar 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
137 killed off _init and _fini in favor of
138 void __attribute__ ((constructor)) init_func and
139 void __attribute__ ((destructor)) closing_func. _(init|func) were deprecated.
140
141 06 Dec 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, libsandbox.c,
142 canonicalize.c, getcwd.c: Fixed compilation *again*. Hopefully cvs is done
143 having the hick-ups.
144
145 04 Dec 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, getcwd.c,
146 Makefile.am: Fixed compilation.
147
148 01 Dec 2004; Brian Harring <ferringb@gentoo.org> aclocal.m4:
149 Gutted the bugger so it stops checking for a c++ and fortran compiler.
150 Do *not* regenerate aclocal.m4 for making a release until a better
151 solution is created.
152
153 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, sandbox_futils.c:
154 Removal of more hardcoded paths.
155
156 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in,
157 sandbox_futils.c: tweaks to install sandbox.bashrc, and use it.
158
159 19 Nov 2004; Brian Harring <ferringb@gentoo.org>:
160 Sandbox is now autotooled, create-localdecls needs to be killed and the code
161 shifted into configure.in. Currently builds *one* libsandbox.so- if multiple
162 are desired (-m64 and -m32 for amd64), the ebuild should do it (imo).
163 To get to a point of testing, automake && autoconf; created requisite files w/
164 a(utomake|clocal)-1.8, and autoconf 2.59. Installs to /usr/, instead of
165 /lib and /usr/lib/portage/bin.
166
167 14 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox.c:
168 closing out bug #70225, potential overflow of the sandbox_pids_file var.
169
170 07 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c: c99 standard,
171 (think it was at least) allows intermixing of code and data segments. bug #70351
172 should be fixed by this.
173
174 03 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox_futils.c:
175 futils fix from bug #65201 via solar, and libsandbox log path checks via #69137
176
177 02 Aug 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Code from
178 Seth Robertson that tracked down all adjuct flags for read operations that
179 do not invoke a write operation.
180
181 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
182 Another fix from jstubbs regarding a free() on a stack variable for the
183 environment -- tracking now prevents extraneous free()'s segfault.
184
185 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
186 J. Stubbs tracked down a new bug where mkdir was failing to the patch on
187 the lstat in mkdir... it now only returns 0 or -1 as documented for mkdir.
188 Also remove the errno = ESUCCESS settings as documentation points out that
189 a library isn't allowed to do that.
190
191 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Added a
192 file_security_check() function to check random potential exploits on files
193 that sandbox is to load and read -- Normally sandboxpids.tmp. This fixes
194 the 'system-crippling' exploits (bug 21923) and catches a few other
195 potential problems.
196
197 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> Makefile: Updates for
198 32/64 bit sandbox. Made CC and LD '?=' values to allow passed in CC to work.
199
200 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c:
201 bug 42048 -- Fixed the lstat/errno conditions for mkdir <caleb@g.o>.
202 Added the 64/32 bit sandbox patch for AMD64 bug 32963 <brad/azarah>.
203
204 29 Feb 2004; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c :
205 Fix permissions and group of pids file and logs. Permissions should be 0664
206 and group should be 'portage'. Bug #34260.
207
208 28 Feb 2004; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
209 Besides a small cleanup, redo how we replace LD_PRELOAD in the environ passed
210 to the real execve (in our execve wrapper). Seems that on some arches (sparc
211 among others) do not allow us to tamper with the readonly copy passed to
212 execve, so pass our own copy of the environment. Bug #42290.
213
214 11 Jan 2004; Nicholas Jones <carpaski@gentoo.org> create-decls:
215 Changed tail to head and added a notice about duration of glibc check.
216
217 21 Dec 2003; Nicholas Jones <carpaski@gentoo.org> create-decls:
218 Changed the glibc subversion check to use /usr/bin/* instead of /bin/sh
219 as there isn't a guarentee that it is dynamic.
220
221 02 Nov 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
222 If 'file' passed to before_syscall(const char *func, const char *file) is
223 invalid, we should set errno to ENOENT, and not EINVAL. This should
224 close bug #32238.
225
226 14 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
227 Fix a bug that occurs mainly on 64bit arch, where the file passed to
228 the functions we wrap, is invalid, and then cause canonicalize to pass
229 garbage to before_syscall(), thanks to great detective work from
230 Andrea Luzzardi <al@sig11.org> (bug #29846).
231
232 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
233 Add a uClibc detection patch from Peter S. Mazinger <ps.m@gmx.net>.
234
235 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
236 Fix a bug in libsandbox.c 's checking in the rename wrapper - it basically
237 only checked the destination patch, and not the source, so we could move
238 a protected file to a unprotected directory, and then delete/modify it.
239 Thanks to Andrea Luzzardi (scox) <al@sig11.org>, bug #30992, for this fix.
240
241 12 Oct 2003; Nicholas Jones <carpaski@gentoo.org> sandbox.c :
242 Added python2.3 to the predict section/variable.
243
244 28 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
245 sandbox.h, sandbox_futils.c :
246 Add support to set the pids file via SANDBOX_PIDS_FILE at startup. If
247 it is not set, it will revert to its old value.
248
249 27 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
250 Fix our mkdir wrapper to check if the dir exist, and return EEXIST if so,
251 rather than failing with a violation, bug #29748.
252
253 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
254 Fix canonicalize() to ignore calls with path = "".
255
256 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c,
257 sandbox_futils.c, canonicalize.c :
258 Once again coreutils fails, as my systems had 2.5 kernel, the getcwd system
259 call handled strings larger than PATH_MAX (bug #21766). It however does not
260 work the same on 2.4 kernels.
261
262 To fix, I added the posix implementation of getcwd() (from glibc cvs) that
263 do not need the system call. We use the default getcwd() function via a
264 wrapper (egetcwd), and then lstat the returned path. If lstat fails, it
265 means the current directory was removed, OR that the the system call for
266 getcwd failed (curious is that it do not fail and return NULL or set
267 errno, but rather just truncate the retured directory - usually from the
268 start), and if so, we use the generic getcwd() function (__egetcwd). Note
269 that we do not use the generic version all the time, as it calls lstat()
270 a great number of times, and performance degrade much.
271
272 29 Jun 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls,
273 libsandbox.c :
274 Make sure SB_PATH_MAX will not wrap. Fix two possible memory leaks.
275
276 22 Jun 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, canonicalize.c
277 create-localdecls :
278 When checking path names of files accessed, we need to canonicalize it, else
279 it may be a symlink in a 'write allowed' directory pointing to a file in a
280 directory we should not have write access to.
281
282 With something like coreutils-5.0, we have two problems:
283 1) One of the tests checks if getcwd() can return a path longer than
284 PATH_MAX. This test then tries to create a dir which even while
285 created local (mkdir("conftest2")), it ends up being resolved with
286 a name that is much larger than PATH_MAX. The problem now is that
287 canonicalize() have undefined behaviour when the path was too long
288 (returned wrongly truncated paths, etc), and pass the wrong path to
289 before_syscall() (causing the bogus sandbox violations).
290 2) The ecanonicalize() function we used, along with the canonicalize()
291 function did not support longer than PATH_MAX. This is partly a
292 cause for 1), but the error checking (rather lack of it) of calls
293 to erealpath() in canonicalize() was the prime reason for 1).
294
295 As we do not use this canonicalized name to call the function, we resolve this
296 by fixing canonicalize() to do better error checking, and ecanonicalize() as
297 well as all functions in libsandbox.c to use a PATH_MAX of 'PATH_MAX * 2'.
298 While they will resolve paths properly now, and can check if a write/read is
299 allowed, the functions called from the sandboxed environment will still work
300 as expected.
301
302 This should resolve bug #21766.
303
304 06 Apr 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
305 For some reason sandbox fails with a 'open_wr' if you run 'locale -a' under
306 it (bug #16298).
307
308 Problem is that for some reason locale fopen's locale.alias with mode "rm".
309
310 -------------------------------------------------------
311 nosferatu root # grep fopen locale.log
312 fopen("/usr/share/locale/locale.alias", "rm"ACCESS DENIED open_wr: /usr/share/locale/locale.alias
313 nosferatu root #
314 --------------------------------------------------------
315
316 I checked the source of locale, but it have fopen with mode 'r', so
317 not sure where the "rm" mode comes from. Anyhow, changed the check in
318 before_syscall_open_char() to also see mode "rm" as readonly.
319
320 23 Feb 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
321
322 Add glibc-2.3 support.
323
324 22 Feb 2003; Martin Schlemmer <azarah@gentoo.org> sandbox.c :
325
326 Some /etc/ld.so.preload fixes. Just changed the #if defines to cover all
327 operations releated to preload, as well as only try to modify ld.so.preload
328 if we can. Also modify to write the pid to /tmp/sandboxpids.tmp even when
329 not using ld.so.preload. Fix to not write this instance of sandbox's pid
330 to /tmp/sandboxpids.tmp on exit if this is not the last sandbox running.
331
332 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> Makefile :
333
334 Changed the LD to CC for hppa.
335
336 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
337
338 Killed the previous changes I made.
339
340 17 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
341
342 Added parisc to BROKEN_RTLD_ARCHLIST to see if it we can fix the relocation probs.
343
344 09 Jan 2003; J Robert Ray <jrray@gentoo.org> sandbox.c :
345
346 Don't segfault if $HOME isn't set, set $HOME to "/" instead. Fixes bug 10868.
347
348 16 Dec 2002; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
349
350 Fix memory leak for mips, bug #12236. Thanks to Torgeir Hansen <torgeir@trenger.ro>
351 for this fix.
352
353 4 Dec 2002; J Robert Ray <jrray@gentoo.org> sandbox.h sandbox_futils.c :
354
355 sandbox_futils defined a dirname() function that was masking the same
356 function in glibc and was broken (e.g.: SANDBOX_DIR was being set to
357 '/usr/lib/portage/bi/'). Fixed function to return expected results and
358 renamed it to sb_dirname() to no longer mask the glibc function. Closes bug
359 11231.
360
361 4 Dec 2002; Martin Schlemmer <azarah@gentoo.org> :
362
363 Fix a segfault in libsandbox.c if canonicalize() was called with
364 first parameter = NULL.
365
366 1 Sep 2002; Martin Schlemmer <azarah@gentoo.org> :
367
368 Fix my braindead 'return 1;' in a void function. Updated sandbox.c,
369 cleanup() for this.
370
371 Change cleanup() in sandbox.c not to exit with fail status if
372 the pidsfile is missing. We really should still display sandbox
373 violations if they occured.
374
375 31 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
376
377 Update cleanup() in sandbox.c to remove the PIDSFILE if this is
378 the last sandbox running.
379
380 25 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
381
382 Major cleanups to mainly libsandbox.c again.
383
384 22 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
385
386 Add copyrights to sandbox.h and sandbox_futils.h. If wrong, the
387 parties involved should please contact me so that we can fix it.
388
389 Add opendir wrapper to libsandbox.c.
390
391 21 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
392
393 Do some more cleanups to ecanonicalize(), as it dropped filenames in
394 rare cases (after my symlink cleanups), and caused glibc to bork.
395 These fixes went into canonicalize.c.
396
397 20 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
398
399 Fix spawn_shell() and main() in sandbox.c to properly return fail
400 status.
401
402 19 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
403
404 The new canonicalize() function in libsandbox.c also resolved symlinks,
405 which caused on cleaning sandbox errors if the symlink pointed to a
406 file in the live root. Ripped out canonicalize() and realpath() from
407 glibc; removed the symlink stuff, and changed them to ecanonicalize()
408 and erealpath().
409
410 18 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
411
412 Ripped out all the wrappers, and implemented those of InstallWatch.
413 Losts of cleanups and bugfixes. Implement a execve that forces
414 $LIBSANDBOX in $LD_PRELOAD. We can now thus do away with the feared
415 /etc/ld.so.preload (*g*) ... Made the needed changes to sandbox.c,
416 sandbox.h and sandbox_futils.c. Rewrote the Makefile for most
417 parts; it now have an install target.
418
419 Reformat the whole thing to look somewhat like the reworked sandbox.c
420 and new sandbox.h and sandbox_futils.c from:
421
422 Brad House <brad@mainstreetsoftworks.com>.
423
424 Additional Copyrights now due to the InstallWatch code:
425
426 Copyright (C) 1998-9 Pancrazio `Ezio' de Mauro <p@demauro.net>

Properties

Name Value
svn:eol-style native
svn:keywords Author Date Id Revision

  ViewVC Help
Powered by ViewVC 1.1.20