/[path-sandbox]/trunk/ChangeLog
Gentoo

Contents of /trunk/ChangeLog

Parent Directory Parent Directory | Revision Log Revision Log


Revision 86 - (show annotations) (download)
Wed May 11 15:42:45 2005 UTC (9 years, 2 months ago) by azarah
File size: 20144 byte(s)
Remove NO_FORK stuff, as its not used, and 'strace -f' works just fine.

1 # ChangeLog for Path Sandbox
2 # Copyright 1999-2005 Gentoo Foundation; Distributed under the GPL v2
3 # $Header$
4
5 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
6 Remove NO_FORK stuff, as its not used, and 'strace -f' works just fine.
7
8 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
9 Remove USE_SYSTEM_SHELL stuff, as it is not secure, and not in use.
10
11 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
12 Remove ld.so.preload crap - we are not going to use it again.
13
14 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
15 Fix typo in code that checks if we got valid group information, causing a
16 segmentation fault, bug #91637.
17
18 * sandbox-1.2.6 (2005/05/10)
19
20 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
21 Do not use LD_PRELOAD if it contains libtsocks.so, as it breaks sandbox
22 for some odd reason, bug #91541.
23
24 09 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
25 Fix typo (sizeof -> strlen).
26
27 08 May 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
28 rewrote the sbcontext caching code so it accounts for env changes since lib
29 initialization.
30
31 05 May 2005; Martin Schlemmer <azarah@gentoo.org> configure.in, libctest.c:
32 We create libctest.c via configure, so no need to keep it around. Do some
33 cleanup related to libctest.c and libctest during configure.
34
35 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
36 Add rename support of symlinks pointing to protected files/directories.
37
38 * sandbox-1.2.5 (2005/05/04)
39
40 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
41 sandbox.bashrc:
42 Do not reset already set LD_PRELOAD when starting sandbox. If LD_PRELOAD is
43 already set, init of the env vars fails for some reason, so do this later on,
44 and do not warn (bug #91431).
45
46 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
47 sandbox.bashrc:
48 Fixup sandbox and sandbox.bashrc to call bash with the proper .bashrc.
49
50 * sandbox-1.2.4 (2005/05/03)
51
52 03 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
53 Do not init the env entries with each call, as it creates too many calls to
54 lstat, etc. Should speedup things a bit, bug #91040.
55
56 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
57 Add /dev/pty to default write list. Noticed by Morfic.
58
59 02 May 2005; Mike Frysinger <vapier@gentoo.org> configure.in, localdecls.h,
60 sandbox.h:
61 uClibc doesn't support dlvsym() so add a configure check to make sure it doesn't
62 exist. Also update localdecls.h so BROKEN_RTLD_NEXT isn't defined in uClibc.
63
64 * sandbox-1.2.3 (2005/04/29)
65
66 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> configure.in:
67 Do not check for (*&#$(* CXX or F77.
68
69 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
70 Do not append '/' to pathname in filter_path() if it already ends with it.
71
72 28 Apr 2005; Mike Frysinger <vapier@gentoo.org> Makefile.am, configure.in:
73 With az's help, clean up autotools to work with cross-compiling.
74
75 * sandbox-1.2.2 (2005/04/28)
76
77 28 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
78 Only check for /dev/{null,zero} for unlink hack, else ricers using /dev/shm
79 have issues; bug #90592.
80
81 * sandbox-1.2.1 (2005/04/23)
82
83 23 Apr 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
84 getcwd.c, libsandbox.c, localdecls.h, sandbox.h, sandbox_futils.c:
85 Make sure all functions used in libsandbox.c is declared static. Define
86 SB_STATIC in localdecls.h for this. Include sandbox_futils.c rather than
87 linking with its object. Hopefully this will fix bug #90153.
88
89 * sandbox-1.2 (2005/04/23)
90
91 22 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
92 Allow lchown a symlink in write-allowed path pointing to write-denied
93 target.
94
95 21 Mar 2005; Marius Mauch <genone@gentoo.org> libsandbox.c:
96 Also show resolved symlink names in the log.
97
98 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, libsandbox.c:
99 Seems -nostdlib was the problem with the constructor/destructor - remove it
100 from Makefile.am, and change the constructor/destructor names again.
101
102 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
103 Also rename the _init() and _fini() declarations.
104
105 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
106 Fixup the constructor/destructor function names again (they should be _init()
107 and _fini() it seems, and not being called caused sandbox_lib_path to be
108 unset, and thus breaking the execve() wrapper's LD_PRELOAD protection).
109 Add both the path in given SANDBOX_x variable, as well as its symlink
110 resolved path in init_env_entries(). Modify filter_path() to be able to
111 resolve paths without resolving symlinks, as well as to be able to resolve
112 symlinks. Fix a possible segfault in check_access(). Add symlink resolving
113 to check_access() resolving bug #31019. Add 'hack' for unlink, as the fix
114 for bug #31019 cause access violations if we try to remove a symlink that is
115 not in protected path, but points to a protected path. Fix a memory leak in
116 sandbox.c (sandbox_pids_file in main()). Fix the realpath() calls in main()
117 (sandbox.c) being unchecked. Fix the debug logname not having the pid in it
118 (pid_string was uninitialized). General syntax cleanups.
119
120 09 Mar 2005; Brian Harring <ferringb@gentoo.org> sandbox.c: Fixed the
121 infamous "pids file is not a regular file" w/out newline bug.
122
123 09 Mar 2005; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in:
124 Correct libc_version path detection, since it was screwing up if libdir !=
125 "/lib/".
126
127 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
128 Hack to make sure sandboxed process cannot remove a device node, bug #79836.
129
130 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am:
131 Fix symbols.in not added to dist.
132
133 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
134 getcwd.c, libsandbox.c, sandbox.c, sandbox.h, sandbox_futils.c:
135 White space fixes.
136
137 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
138 configure.in, getcwd.c, libsandbox.c, symbols.in:
139 Fix inverse test logic in canonicalize.c, use a strncpy. Fix gcc warning in
140 getcwd.c. Add symbols.in and logic to Makefile.am to generate symbol versions
141 for glibc and other libc's that use this. Update libsandbox.c to use these
142 symbol versions if available. Fix exec wrapper to re-export LD_PRELOAD if the
143 process unset it.
144
145 01 Mar 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
146 killed off _init and _fini in favor of
147 void __attribute__ ((constructor)) init_func and
148 void __attribute__ ((destructor)) closing_func. _(init|func) were deprecated.
149
150 06 Dec 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, libsandbox.c,
151 canonicalize.c, getcwd.c: Fixed compilation *again*. Hopefully cvs is done
152 having the hick-ups.
153
154 04 Dec 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, getcwd.c,
155 Makefile.am: Fixed compilation.
156
157 01 Dec 2004; Brian Harring <ferringb@gentoo.org> aclocal.m4:
158 Gutted the bugger so it stops checking for a c++ and fortran compiler.
159 Do *not* regenerate aclocal.m4 for making a release until a better
160 solution is created.
161
162 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, sandbox_futils.c:
163 Removal of more hardcoded paths.
164
165 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in,
166 sandbox_futils.c: tweaks to install sandbox.bashrc, and use it.
167
168 19 Nov 2004; Brian Harring <ferringb@gentoo.org>:
169 Sandbox is now autotooled, create-localdecls needs to be killed and the code
170 shifted into configure.in. Currently builds *one* libsandbox.so- if multiple
171 are desired (-m64 and -m32 for amd64), the ebuild should do it (imo).
172 To get to a point of testing, automake && autoconf; created requisite files w/
173 a(utomake|clocal)-1.8, and autoconf 2.59. Installs to /usr/, instead of
174 /lib and /usr/lib/portage/bin.
175
176 14 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox.c:
177 closing out bug #70225, potential overflow of the sandbox_pids_file var.
178
179 07 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c: c99 standard,
180 (think it was at least) allows intermixing of code and data segments. bug #70351
181 should be fixed by this.
182
183 03 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox_futils.c:
184 futils fix from bug #65201 via solar, and libsandbox log path checks via #69137
185
186 02 Aug 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Code from
187 Seth Robertson that tracked down all adjuct flags for read operations that
188 do not invoke a write operation.
189
190 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
191 Another fix from jstubbs regarding a free() on a stack variable for the
192 environment -- tracking now prevents extraneous free()'s segfault.
193
194 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
195 J. Stubbs tracked down a new bug where mkdir was failing to the patch on
196 the lstat in mkdir... it now only returns 0 or -1 as documented for mkdir.
197 Also remove the errno = ESUCCESS settings as documentation points out that
198 a library isn't allowed to do that.
199
200 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Added a
201 file_security_check() function to check random potential exploits on files
202 that sandbox is to load and read -- Normally sandboxpids.tmp. This fixes
203 the 'system-crippling' exploits (bug 21923) and catches a few other
204 potential problems.
205
206 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> Makefile: Updates for
207 32/64 bit sandbox. Made CC and LD '?=' values to allow passed in CC to work.
208
209 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c:
210 bug 42048 -- Fixed the lstat/errno conditions for mkdir <caleb@g.o>.
211 Added the 64/32 bit sandbox patch for AMD64 bug 32963 <brad/azarah>.
212
213 29 Feb 2004; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c :
214 Fix permissions and group of pids file and logs. Permissions should be 0664
215 and group should be 'portage'. Bug #34260.
216
217 28 Feb 2004; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
218 Besides a small cleanup, redo how we replace LD_PRELOAD in the environ passed
219 to the real execve (in our execve wrapper). Seems that on some arches (sparc
220 among others) do not allow us to tamper with the readonly copy passed to
221 execve, so pass our own copy of the environment. Bug #42290.
222
223 11 Jan 2004; Nicholas Jones <carpaski@gentoo.org> create-decls:
224 Changed tail to head and added a notice about duration of glibc check.
225
226 21 Dec 2003; Nicholas Jones <carpaski@gentoo.org> create-decls:
227 Changed the glibc subversion check to use /usr/bin/* instead of /bin/sh
228 as there isn't a guarentee that it is dynamic.
229
230 02 Nov 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
231 If 'file' passed to before_syscall(const char *func, const char *file) is
232 invalid, we should set errno to ENOENT, and not EINVAL. This should
233 close bug #32238.
234
235 14 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
236 Fix a bug that occurs mainly on 64bit arch, where the file passed to
237 the functions we wrap, is invalid, and then cause canonicalize to pass
238 garbage to before_syscall(), thanks to great detective work from
239 Andrea Luzzardi <al@sig11.org> (bug #29846).
240
241 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
242 Add a uClibc detection patch from Peter S. Mazinger <ps.m@gmx.net>.
243
244 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
245 Fix a bug in libsandbox.c 's checking in the rename wrapper - it basically
246 only checked the destination patch, and not the source, so we could move
247 a protected file to a unprotected directory, and then delete/modify it.
248 Thanks to Andrea Luzzardi (scox) <al@sig11.org>, bug #30992, for this fix.
249
250 12 Oct 2003; Nicholas Jones <carpaski@gentoo.org> sandbox.c :
251 Added python2.3 to the predict section/variable.
252
253 28 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
254 sandbox.h, sandbox_futils.c :
255 Add support to set the pids file via SANDBOX_PIDS_FILE at startup. If
256 it is not set, it will revert to its old value.
257
258 27 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
259 Fix our mkdir wrapper to check if the dir exist, and return EEXIST if so,
260 rather than failing with a violation, bug #29748.
261
262 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
263 Fix canonicalize() to ignore calls with path = "".
264
265 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c,
266 sandbox_futils.c, canonicalize.c :
267 Once again coreutils fails, as my systems had 2.5 kernel, the getcwd system
268 call handled strings larger than PATH_MAX (bug #21766). It however does not
269 work the same on 2.4 kernels.
270
271 To fix, I added the posix implementation of getcwd() (from glibc cvs) that
272 do not need the system call. We use the default getcwd() function via a
273 wrapper (egetcwd), and then lstat the returned path. If lstat fails, it
274 means the current directory was removed, OR that the the system call for
275 getcwd failed (curious is that it do not fail and return NULL or set
276 errno, but rather just truncate the retured directory - usually from the
277 start), and if so, we use the generic getcwd() function (__egetcwd). Note
278 that we do not use the generic version all the time, as it calls lstat()
279 a great number of times, and performance degrade much.
280
281 29 Jun 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls,
282 libsandbox.c :
283 Make sure SB_PATH_MAX will not wrap. Fix two possible memory leaks.
284
285 22 Jun 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, canonicalize.c
286 create-localdecls :
287 When checking path names of files accessed, we need to canonicalize it, else
288 it may be a symlink in a 'write allowed' directory pointing to a file in a
289 directory we should not have write access to.
290
291 With something like coreutils-5.0, we have two problems:
292 1) One of the tests checks if getcwd() can return a path longer than
293 PATH_MAX. This test then tries to create a dir which even while
294 created local (mkdir("conftest2")), it ends up being resolved with
295 a name that is much larger than PATH_MAX. The problem now is that
296 canonicalize() have undefined behaviour when the path was too long
297 (returned wrongly truncated paths, etc), and pass the wrong path to
298 before_syscall() (causing the bogus sandbox violations).
299 2) The ecanonicalize() function we used, along with the canonicalize()
300 function did not support longer than PATH_MAX. This is partly a
301 cause for 1), but the error checking (rather lack of it) of calls
302 to erealpath() in canonicalize() was the prime reason for 1).
303
304 As we do not use this canonicalized name to call the function, we resolve this
305 by fixing canonicalize() to do better error checking, and ecanonicalize() as
306 well as all functions in libsandbox.c to use a PATH_MAX of 'PATH_MAX * 2'.
307 While they will resolve paths properly now, and can check if a write/read is
308 allowed, the functions called from the sandboxed environment will still work
309 as expected.
310
311 This should resolve bug #21766.
312
313 06 Apr 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
314 For some reason sandbox fails with a 'open_wr' if you run 'locale -a' under
315 it (bug #16298).
316
317 Problem is that for some reason locale fopen's locale.alias with mode "rm".
318
319 -------------------------------------------------------
320 nosferatu root # grep fopen locale.log
321 fopen("/usr/share/locale/locale.alias", "rm"ACCESS DENIED open_wr: /usr/share/locale/locale.alias
322 nosferatu root #
323 --------------------------------------------------------
324
325 I checked the source of locale, but it have fopen with mode 'r', so
326 not sure where the "rm" mode comes from. Anyhow, changed the check in
327 before_syscall_open_char() to also see mode "rm" as readonly.
328
329 23 Feb 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
330
331 Add glibc-2.3 support.
332
333 22 Feb 2003; Martin Schlemmer <azarah@gentoo.org> sandbox.c :
334
335 Some /etc/ld.so.preload fixes. Just changed the #if defines to cover all
336 operations releated to preload, as well as only try to modify ld.so.preload
337 if we can. Also modify to write the pid to /tmp/sandboxpids.tmp even when
338 not using ld.so.preload. Fix to not write this instance of sandbox's pid
339 to /tmp/sandboxpids.tmp on exit if this is not the last sandbox running.
340
341 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> Makefile :
342
343 Changed the LD to CC for hppa.
344
345 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
346
347 Killed the previous changes I made.
348
349 17 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
350
351 Added parisc to BROKEN_RTLD_ARCHLIST to see if it we can fix the relocation probs.
352
353 09 Jan 2003; J Robert Ray <jrray@gentoo.org> sandbox.c :
354
355 Don't segfault if $HOME isn't set, set $HOME to "/" instead. Fixes bug 10868.
356
357 16 Dec 2002; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
358
359 Fix memory leak for mips, bug #12236. Thanks to Torgeir Hansen <torgeir@trenger.ro>
360 for this fix.
361
362 4 Dec 2002; J Robert Ray <jrray@gentoo.org> sandbox.h sandbox_futils.c :
363
364 sandbox_futils defined a dirname() function that was masking the same
365 function in glibc and was broken (e.g.: SANDBOX_DIR was being set to
366 '/usr/lib/portage/bi/'). Fixed function to return expected results and
367 renamed it to sb_dirname() to no longer mask the glibc function. Closes bug
368 11231.
369
370 4 Dec 2002; Martin Schlemmer <azarah@gentoo.org> :
371
372 Fix a segfault in libsandbox.c if canonicalize() was called with
373 first parameter = NULL.
374
375 1 Sep 2002; Martin Schlemmer <azarah@gentoo.org> :
376
377 Fix my braindead 'return 1;' in a void function. Updated sandbox.c,
378 cleanup() for this.
379
380 Change cleanup() in sandbox.c not to exit with fail status if
381 the pidsfile is missing. We really should still display sandbox
382 violations if they occured.
383
384 31 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
385
386 Update cleanup() in sandbox.c to remove the PIDSFILE if this is
387 the last sandbox running.
388
389 25 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
390
391 Major cleanups to mainly libsandbox.c again.
392
393 22 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
394
395 Add copyrights to sandbox.h and sandbox_futils.h. If wrong, the
396 parties involved should please contact me so that we can fix it.
397
398 Add opendir wrapper to libsandbox.c.
399
400 21 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
401
402 Do some more cleanups to ecanonicalize(), as it dropped filenames in
403 rare cases (after my symlink cleanups), and caused glibc to bork.
404 These fixes went into canonicalize.c.
405
406 20 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
407
408 Fix spawn_shell() and main() in sandbox.c to properly return fail
409 status.
410
411 19 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
412
413 The new canonicalize() function in libsandbox.c also resolved symlinks,
414 which caused on cleaning sandbox errors if the symlink pointed to a
415 file in the live root. Ripped out canonicalize() and realpath() from
416 glibc; removed the symlink stuff, and changed them to ecanonicalize()
417 and erealpath().
418
419 18 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
420
421 Ripped out all the wrappers, and implemented those of InstallWatch.
422 Losts of cleanups and bugfixes. Implement a execve that forces
423 $LIBSANDBOX in $LD_PRELOAD. We can now thus do away with the feared
424 /etc/ld.so.preload (*g*) ... Made the needed changes to sandbox.c,
425 sandbox.h and sandbox_futils.c. Rewrote the Makefile for most
426 parts; it now have an install target.
427
428 Reformat the whole thing to look somewhat like the reworked sandbox.c
429 and new sandbox.h and sandbox_futils.c from:
430
431 Brad House <brad@mainstreetsoftworks.com>.
432
433 Additional Copyrights now due to the InstallWatch code:
434
435 Copyright (C) 1998-9 Pancrazio `Ezio' de Mauro <p@demauro.net>

Properties

Name Value
svn:eol-style native
svn:keywords Author Date Id Revision

  ViewVC Help
Powered by ViewVC 1.1.20