/[path-sandbox]/trunk/ChangeLog
Gentoo

Contents of /trunk/ChangeLog

Parent Directory Parent Directory | Revision Log Revision Log


Revision 91 - (show annotations) (download)
Wed May 11 23:35:14 2005 UTC (9 years, 3 months ago) by azarah
File size: 20913 byte(s)
Set SANDBOX_ON *before* doing the child's env stuff, else its not set
for the child.

1 # ChangeLog for Path Sandbox
2 # Copyright 1999-2005 Gentoo Foundation; Distributed under the GPL v2
3 # $Header$
4
5 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
6 Set SANDBOX_ON *before* doing the child's env stuff, else its not set
7 for the child.
8
9 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
10 Remove global preload_adaptable as it is no longer used.
11
12 12 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
13 Rewrite environment stuff to only be set when execve'ing the child process
14 to try and avoid issues like bug #91541 that causes sandbox to crash if
15 we set LD_PRELOAD sandbox side already.
16
17 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
18 Move print_sandbox_log() up to make things neater.
19
20 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
21 Remove load_preload_libs(), as its not used anymore.
22
23 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
24 Remove NO_FORK stuff, as its not used, and 'strace -f' works just fine.
25
26 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
27 Remove USE_SYSTEM_SHELL stuff, as it is not secure, and not in use.
28
29 11 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h:
30 Remove ld.so.preload crap - we are not going to use it again.
31
32 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox_futils.c:
33 Fix typo in code that checks if we got valid group information, causing a
34 segmentation fault, bug #91637.
35
36 * sandbox-1.2.6 (2005/05/10)
37
38 10 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
39 Do not use LD_PRELOAD if it contains libtsocks.so, as it breaks sandbox
40 for some odd reason, bug #91541.
41
42 09 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
43 Fix typo (sizeof -> strlen).
44
45 08 May 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
46 rewrote the sbcontext caching code so it accounts for env changes since lib
47 initialization.
48
49 05 May 2005; Martin Schlemmer <azarah@gentoo.org> configure.in, libctest.c:
50 We create libctest.c via configure, so no need to keep it around. Do some
51 cleanup related to libctest.c and libctest during configure.
52
53 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
54 Add rename support of symlinks pointing to protected files/directories.
55
56 * sandbox-1.2.5 (2005/05/04)
57
58 04 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
59 sandbox.bashrc:
60 Do not reset already set LD_PRELOAD when starting sandbox. If LD_PRELOAD is
61 already set, init of the env vars fails for some reason, so do this later on,
62 and do not warn (bug #91431).
63
64 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox.h,
65 sandbox.bashrc:
66 Fixup sandbox and sandbox.bashrc to call bash with the proper .bashrc.
67
68 * sandbox-1.2.4 (2005/05/03)
69
70 03 May 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
71 Do not init the env entries with each call, as it creates too many calls to
72 lstat, etc. Should speedup things a bit, bug #91040.
73
74 03 May 2005; Martin Schlemmer <azarah@gentoo.org> sandbox.c:
75 Add /dev/pty to default write list. Noticed by Morfic.
76
77 02 May 2005; Mike Frysinger <vapier@gentoo.org> configure.in, localdecls.h,
78 sandbox.h:
79 uClibc doesn't support dlvsym() so add a configure check to make sure it doesn't
80 exist. Also update localdecls.h so BROKEN_RTLD_NEXT isn't defined in uClibc.
81
82 * sandbox-1.2.3 (2005/04/29)
83
84 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> configure.in:
85 Do not check for (*&#$(* CXX or F77.
86
87 29 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
88 Do not append '/' to pathname in filter_path() if it already ends with it.
89
90 28 Apr 2005; Mike Frysinger <vapier@gentoo.org> Makefile.am, configure.in:
91 With az's help, clean up autotools to work with cross-compiling.
92
93 * sandbox-1.2.2 (2005/04/28)
94
95 28 Apr 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
96 Only check for /dev/{null,zero} for unlink hack, else ricers using /dev/shm
97 have issues; bug #90592.
98
99 * sandbox-1.2.1 (2005/04/23)
100
101 23 Apr 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
102 getcwd.c, libsandbox.c, localdecls.h, sandbox.h, sandbox_futils.c:
103 Make sure all functions used in libsandbox.c is declared static. Define
104 SB_STATIC in localdecls.h for this. Include sandbox_futils.c rather than
105 linking with its object. Hopefully this will fix bug #90153.
106
107 * sandbox-1.2 (2005/04/23)
108
109 22 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
110 Allow lchown a symlink in write-allowed path pointing to write-denied
111 target.
112
113 21 Mar 2005; Marius Mauch <genone@gentoo.org> libsandbox.c:
114 Also show resolved symlink names in the log.
115
116 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, libsandbox.c:
117 Seems -nostdlib was the problem with the constructor/destructor - remove it
118 from Makefile.am, and change the constructor/destructor names again.
119
120 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
121 Also rename the _init() and _fini() declarations.
122
123 14 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c:
124 Fixup the constructor/destructor function names again (they should be _init()
125 and _fini() it seems, and not being called caused sandbox_lib_path to be
126 unset, and thus breaking the execve() wrapper's LD_PRELOAD protection).
127 Add both the path in given SANDBOX_x variable, as well as its symlink
128 resolved path in init_env_entries(). Modify filter_path() to be able to
129 resolve paths without resolving symlinks, as well as to be able to resolve
130 symlinks. Fix a possible segfault in check_access(). Add symlink resolving
131 to check_access() resolving bug #31019. Add 'hack' for unlink, as the fix
132 for bug #31019 cause access violations if we try to remove a symlink that is
133 not in protected path, but points to a protected path. Fix a memory leak in
134 sandbox.c (sandbox_pids_file in main()). Fix the realpath() calls in main()
135 (sandbox.c) being unchecked. Fix the debug logname not having the pid in it
136 (pid_string was uninitialized). General syntax cleanups.
137
138 09 Mar 2005; Brian Harring <ferringb@gentoo.org> sandbox.c: Fixed the
139 infamous "pids file is not a regular file" w/out newline bug.
140
141 09 Mar 2005; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in:
142 Correct libc_version path detection, since it was screwing up if libdir !=
143 "/lib/".
144
145 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> libsandbox.c:
146 Hack to make sure sandboxed process cannot remove a device node, bug #79836.
147
148 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am:
149 Fix symbols.in not added to dist.
150
151 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
152 getcwd.c, libsandbox.c, sandbox.c, sandbox.h, sandbox_futils.c:
153 White space fixes.
154
155 02 Mar 2005; Martin Schlemmer <azarah@gentoo.org> Makefile.am, canonicalize.c,
156 configure.in, getcwd.c, libsandbox.c, symbols.in:
157 Fix inverse test logic in canonicalize.c, use a strncpy. Fix gcc warning in
158 getcwd.c. Add symbols.in and logic to Makefile.am to generate symbol versions
159 for glibc and other libc's that use this. Update libsandbox.c to use these
160 symbol versions if available. Fix exec wrapper to re-export LD_PRELOAD if the
161 process unset it.
162
163 01 Mar 2005; Brian Harring <ferringb@gentoo.org> libsandbox.c:
164 killed off _init and _fini in favor of
165 void __attribute__ ((constructor)) init_func and
166 void __attribute__ ((destructor)) closing_func. _(init|func) were deprecated.
167
168 06 Dec 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, libsandbox.c,
169 canonicalize.c, getcwd.c: Fixed compilation *again*. Hopefully cvs is done
170 having the hick-ups.
171
172 04 Dec 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, getcwd.c,
173 Makefile.am: Fixed compilation.
174
175 01 Dec 2004; Brian Harring <ferringb@gentoo.org> aclocal.m4:
176 Gutted the bugger so it stops checking for a c++ and fortran compiler.
177 Do *not* regenerate aclocal.m4 for making a release until a better
178 solution is created.
179
180 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, sandbox_futils.c:
181 Removal of more hardcoded paths.
182
183 20 Nov 2004; Brian Harring <ferringb@gentoo.org> Makefile.am, configure.in,
184 sandbox_futils.c: tweaks to install sandbox.bashrc, and use it.
185
186 19 Nov 2004; Brian Harring <ferringb@gentoo.org>:
187 Sandbox is now autotooled, create-localdecls needs to be killed and the code
188 shifted into configure.in. Currently builds *one* libsandbox.so- if multiple
189 are desired (-m64 and -m32 for amd64), the ebuild should do it (imo).
190 To get to a point of testing, automake && autoconf; created requisite files w/
191 a(utomake|clocal)-1.8, and autoconf 2.59. Installs to /usr/, instead of
192 /lib and /usr/lib/portage/bin.
193
194 14 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox.c:
195 closing out bug #70225, potential overflow of the sandbox_pids_file var.
196
197 07 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c: c99 standard,
198 (think it was at least) allows intermixing of code and data segments. bug #70351
199 should be fixed by this.
200
201 03 Nov 2004; Brian Harring <ferringb@gentoo.org> libsandbox.c, sandbox_futils.c:
202 futils fix from bug #65201 via solar, and libsandbox log path checks via #69137
203
204 02 Aug 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Code from
205 Seth Robertson that tracked down all adjuct flags for read operations that
206 do not invoke a write operation.
207
208 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
209 Another fix from jstubbs regarding a free() on a stack variable for the
210 environment -- tracking now prevents extraneous free()'s segfault.
211
212 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c, sandbox.c:
213 J. Stubbs tracked down a new bug where mkdir was failing to the patch on
214 the lstat in mkdir... it now only returns 0 or -1 as documented for mkdir.
215 Also remove the errno = ESUCCESS settings as documentation points out that
216 a library isn't allowed to do that.
217
218 04 Apr 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c: Added a
219 file_security_check() function to check random potential exploits on files
220 that sandbox is to load and read -- Normally sandboxpids.tmp. This fixes
221 the 'system-crippling' exploits (bug 21923) and catches a few other
222 potential problems.
223
224 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> Makefile: Updates for
225 32/64 bit sandbox. Made CC and LD '?=' values to allow passed in CC to work.
226
227 20 Mar 2004; Nicholas Jones <carpaski@gentoo.org> libsandbox.c:
228 bug 42048 -- Fixed the lstat/errno conditions for mkdir <caleb@g.o>.
229 Added the 64/32 bit sandbox patch for AMD64 bug 32963 <brad/azarah>.
230
231 29 Feb 2004; Martin Schlemmer <azarah@gentoo.org> sandbox.c, sandbox_futils.c :
232 Fix permissions and group of pids file and logs. Permissions should be 0664
233 and group should be 'portage'. Bug #34260.
234
235 28 Feb 2004; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
236 Besides a small cleanup, redo how we replace LD_PRELOAD in the environ passed
237 to the real execve (in our execve wrapper). Seems that on some arches (sparc
238 among others) do not allow us to tamper with the readonly copy passed to
239 execve, so pass our own copy of the environment. Bug #42290.
240
241 11 Jan 2004; Nicholas Jones <carpaski@gentoo.org> create-decls:
242 Changed tail to head and added a notice about duration of glibc check.
243
244 21 Dec 2003; Nicholas Jones <carpaski@gentoo.org> create-decls:
245 Changed the glibc subversion check to use /usr/bin/* instead of /bin/sh
246 as there isn't a guarentee that it is dynamic.
247
248 02 Nov 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
249 If 'file' passed to before_syscall(const char *func, const char *file) is
250 invalid, we should set errno to ENOENT, and not EINVAL. This should
251 close bug #32238.
252
253 14 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
254 Fix a bug that occurs mainly on 64bit arch, where the file passed to
255 the functions we wrap, is invalid, and then cause canonicalize to pass
256 garbage to before_syscall(), thanks to great detective work from
257 Andrea Luzzardi <al@sig11.org> (bug #29846).
258
259 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
260 Add a uClibc detection patch from Peter S. Mazinger <ps.m@gmx.net>.
261
262 13 Oct 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
263 Fix a bug in libsandbox.c 's checking in the rename wrapper - it basically
264 only checked the destination patch, and not the source, so we could move
265 a protected file to a unprotected directory, and then delete/modify it.
266 Thanks to Andrea Luzzardi (scox) <al@sig11.org>, bug #30992, for this fix.
267
268 12 Oct 2003; Nicholas Jones <carpaski@gentoo.org> sandbox.c :
269 Added python2.3 to the predict section/variable.
270
271 28 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, sandbox.c,
272 sandbox.h, sandbox_futils.c :
273 Add support to set the pids file via SANDBOX_PIDS_FILE at startup. If
274 it is not set, it will revert to its old value.
275
276 27 Sep 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
277 Fix our mkdir wrapper to check if the dir exist, and return EEXIST if so,
278 rather than failing with a violation, bug #29748.
279
280 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
281 Fix canonicalize() to ignore calls with path = "".
282
283 27 Jul 2003; Martin Schlemmer <azarah@gentoo.org> getcwd.c, libsandbox.c,
284 sandbox_futils.c, canonicalize.c :
285 Once again coreutils fails, as my systems had 2.5 kernel, the getcwd system
286 call handled strings larger than PATH_MAX (bug #21766). It however does not
287 work the same on 2.4 kernels.
288
289 To fix, I added the posix implementation of getcwd() (from glibc cvs) that
290 do not need the system call. We use the default getcwd() function via a
291 wrapper (egetcwd), and then lstat the returned path. If lstat fails, it
292 means the current directory was removed, OR that the the system call for
293 getcwd failed (curious is that it do not fail and return NULL or set
294 errno, but rather just truncate the retured directory - usually from the
295 start), and if so, we use the generic getcwd() function (__egetcwd). Note
296 that we do not use the generic version all the time, as it calls lstat()
297 a great number of times, and performance degrade much.
298
299 29 Jun 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls,
300 libsandbox.c :
301 Make sure SB_PATH_MAX will not wrap. Fix two possible memory leaks.
302
303 22 Jun 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c, canonicalize.c
304 create-localdecls :
305 When checking path names of files accessed, we need to canonicalize it, else
306 it may be a symlink in a 'write allowed' directory pointing to a file in a
307 directory we should not have write access to.
308
309 With something like coreutils-5.0, we have two problems:
310 1) One of the tests checks if getcwd() can return a path longer than
311 PATH_MAX. This test then tries to create a dir which even while
312 created local (mkdir("conftest2")), it ends up being resolved with
313 a name that is much larger than PATH_MAX. The problem now is that
314 canonicalize() have undefined behaviour when the path was too long
315 (returned wrongly truncated paths, etc), and pass the wrong path to
316 before_syscall() (causing the bogus sandbox violations).
317 2) The ecanonicalize() function we used, along with the canonicalize()
318 function did not support longer than PATH_MAX. This is partly a
319 cause for 1), but the error checking (rather lack of it) of calls
320 to erealpath() in canonicalize() was the prime reason for 1).
321
322 As we do not use this canonicalized name to call the function, we resolve this
323 by fixing canonicalize() to do better error checking, and ecanonicalize() as
324 well as all functions in libsandbox.c to use a PATH_MAX of 'PATH_MAX * 2'.
325 While they will resolve paths properly now, and can check if a write/read is
326 allowed, the functions called from the sandboxed environment will still work
327 as expected.
328
329 This should resolve bug #21766.
330
331 06 Apr 2003; Martin Schlemmer <azarah@gentoo.org> libsandbox.c :
332 For some reason sandbox fails with a 'open_wr' if you run 'locale -a' under
333 it (bug #16298).
334
335 Problem is that for some reason locale fopen's locale.alias with mode "rm".
336
337 -------------------------------------------------------
338 nosferatu root # grep fopen locale.log
339 fopen("/usr/share/locale/locale.alias", "rm"ACCESS DENIED open_wr: /usr/share/locale/locale.alias
340 nosferatu root #
341 --------------------------------------------------------
342
343 I checked the source of locale, but it have fopen with mode 'r', so
344 not sure where the "rm" mode comes from. Anyhow, changed the check in
345 before_syscall_open_char() to also see mode "rm" as readonly.
346
347 23 Feb 2003; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
348
349 Add glibc-2.3 support.
350
351 22 Feb 2003; Martin Schlemmer <azarah@gentoo.org> sandbox.c :
352
353 Some /etc/ld.so.preload fixes. Just changed the #if defines to cover all
354 operations releated to preload, as well as only try to modify ld.so.preload
355 if we can. Also modify to write the pid to /tmp/sandboxpids.tmp even when
356 not using ld.so.preload. Fix to not write this instance of sandbox's pid
357 to /tmp/sandboxpids.tmp on exit if this is not the last sandbox running.
358
359 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> Makefile :
360
361 Changed the LD to CC for hppa.
362
363 22 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
364
365 Killed the previous changes I made.
366
367 17 Feb 2003; Nicholas Jones <carpaski@gentoo.org> create-localdecls :
368
369 Added parisc to BROKEN_RTLD_ARCHLIST to see if it we can fix the relocation probs.
370
371 09 Jan 2003; J Robert Ray <jrray@gentoo.org> sandbox.c :
372
373 Don't segfault if $HOME isn't set, set $HOME to "/" instead. Fixes bug 10868.
374
375 16 Dec 2002; Martin Schlemmer <azarah@gentoo.org> create-localdecls :
376
377 Fix memory leak for mips, bug #12236. Thanks to Torgeir Hansen <torgeir@trenger.ro>
378 for this fix.
379
380 4 Dec 2002; J Robert Ray <jrray@gentoo.org> sandbox.h sandbox_futils.c :
381
382 sandbox_futils defined a dirname() function that was masking the same
383 function in glibc and was broken (e.g.: SANDBOX_DIR was being set to
384 '/usr/lib/portage/bi/'). Fixed function to return expected results and
385 renamed it to sb_dirname() to no longer mask the glibc function. Closes bug
386 11231.
387
388 4 Dec 2002; Martin Schlemmer <azarah@gentoo.org> :
389
390 Fix a segfault in libsandbox.c if canonicalize() was called with
391 first parameter = NULL.
392
393 1 Sep 2002; Martin Schlemmer <azarah@gentoo.org> :
394
395 Fix my braindead 'return 1;' in a void function. Updated sandbox.c,
396 cleanup() for this.
397
398 Change cleanup() in sandbox.c not to exit with fail status if
399 the pidsfile is missing. We really should still display sandbox
400 violations if they occured.
401
402 31 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
403
404 Update cleanup() in sandbox.c to remove the PIDSFILE if this is
405 the last sandbox running.
406
407 25 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
408
409 Major cleanups to mainly libsandbox.c again.
410
411 22 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
412
413 Add copyrights to sandbox.h and sandbox_futils.h. If wrong, the
414 parties involved should please contact me so that we can fix it.
415
416 Add opendir wrapper to libsandbox.c.
417
418 21 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
419
420 Do some more cleanups to ecanonicalize(), as it dropped filenames in
421 rare cases (after my symlink cleanups), and caused glibc to bork.
422 These fixes went into canonicalize.c.
423
424 20 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
425
426 Fix spawn_shell() and main() in sandbox.c to properly return fail
427 status.
428
429 19 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
430
431 The new canonicalize() function in libsandbox.c also resolved symlinks,
432 which caused on cleaning sandbox errors if the symlink pointed to a
433 file in the live root. Ripped out canonicalize() and realpath() from
434 glibc; removed the symlink stuff, and changed them to ecanonicalize()
435 and erealpath().
436
437 18 Aug 2002; Martin Schlemmer <azarah@gentoo.org> :
438
439 Ripped out all the wrappers, and implemented those of InstallWatch.
440 Losts of cleanups and bugfixes. Implement a execve that forces
441 $LIBSANDBOX in $LD_PRELOAD. We can now thus do away with the feared
442 /etc/ld.so.preload (*g*) ... Made the needed changes to sandbox.c,
443 sandbox.h and sandbox_futils.c. Rewrote the Makefile for most
444 parts; it now have an install target.
445
446 Reformat the whole thing to look somewhat like the reworked sandbox.c
447 and new sandbox.h and sandbox_futils.c from:
448
449 Brad House <brad@mainstreetsoftworks.com>.
450
451 Additional Copyrights now due to the InstallWatch code:
452
453 Copyright (C) 1998-9 Pancrazio `Ezio' de Mauro <p@demauro.net>

Properties

Name Value
svn:eol-style native
svn:keywords Author Date Id Revision

  ViewVC Help
Powered by ViewVC 1.1.20