/[gentoo-x86]/net-misc/networkmanager/files/networkmanager-1.0.0-remove-bashisms.patch
Gentoo

Contents of /net-misc/networkmanager/files/networkmanager-1.0.0-remove-bashisms.patch

Parent Directory Parent Directory | Revision Log Revision Log


Revision 1.1 - (show annotations) (download) (as text)
Sun Jan 25 12:52:57 2015 UTC (4 years, 3 months ago) by remi
Branch: MAIN
CVS Tags: HEAD
File MIME type: text/x-diff
net-misc/networkmanager: fix build with /bin/sh != bash

(Portage version: 2.2.15/cvs/Linux x86_64, signed Manifest commit with key 901AB08A)

1 From 4c3c9a38272112fe7a6a248ba521d55ac1b66892 Mon Sep 17 00:00:00 2001
2 From: =?UTF-8?q?R=C3=A9mi=20Cardona?= <remi@gentoo.org>
3 Date: Sun, 25 Jan 2015 13:02:19 +0100
4 Subject: [PATCH] build: use POSIX-compliant 'printf' instead of 'echo'
5 MIME-Version: 1.0
6 Content-Type: text/plain; charset=UTF-8
7 Content-Transfer-Encoding: 8bit
8
9 Fixes the following error when running ./configure with dash:
10
11 checking for QT... yes
12 checking for moc-qt4... no
13 checking for moc... moc
14 configure: error: --with-udev-dir must be an absolute path or 'yes' or
15 'no'. Instead it is '/lib/udev'
16
17 As per the Autoconf Manual's section on "Limitations of Shell Builtins":
18
19 The simple echo is probably the most surprising source of portability
20 troubles. It is not possible to use ‘echo’ portably unless both
21 options and escape sequences are omitted.
22
23 https://www.gnu.org/software/automake/faq/autoconf.html#echo
24 https://bugs.gentoo.org/536540
25 ---
26 configure.ac | 2 +-
27 1 file changed, 1 insertion(+), 1 deletion(-)
28
29 diff --git a/configure.ac b/configure.ac
30 index b407686..5c87c7e 100644
31 --- a/configure.ac
32 +++ b/configure.ac
33 @@ -302,7 +302,7 @@ AM_CONDITIONAL(WITH_QT, test "${enable_qt}" = "yes")
34
35 AC_ARG_WITH(udev-dir, AS_HELP_STRING([--with-udev-dir=DIR], [Absolute path of the udev base directory. Set to 'no' not to install the udev rules]), [], [with_udev_dir="yes"])
36 if (test "$with_udev_dir" != 'no'); then
37 - if (test "$with_udev_dir" != 'yes' && echo -n "$with_udev_dir" | grep -v -q '^/'); then
38 + if (test "$with_udev_dir" != 'yes' && printf '%s' "$with_udev_dir" | grep -v -q '^/'); then
39 AC_MSG_ERROR([--with-udev-dir must be an absolute path or 'yes' or 'no'. Instead it is '$with_udev_dir'])
40 fi
41 if (test "$with_udev_dir" = 'yes'); then
42 --
43 2.2.1
44

  ViewVC Help
Powered by ViewVC 1.1.20