summaryrefslogtreecommitdiff
path: root/vnc.c
diff options
context:
space:
mode:
authorStefan Weil <weil@mail.berlios.de>2009-05-24 22:33:34 +0200
committerAnthony Liguori <aliguori@us.ibm.com>2009-05-27 09:45:26 -0500
commitafd3216027e3b28b0e180ac99d87e981d169b91c (patch)
tree87f5c4e92496136f16545da1d7d51bb38e22df6a /vnc.c
parentDrop bdrv_create2 (diff)
downloadqemu-kvm-afd3216027e3b28b0e180ac99d87e981d169b91c.tar.gz
qemu-kvm-afd3216027e3b28b0e180ac99d87e981d169b91c.tar.bz2
qemu-kvm-afd3216027e3b28b0e180ac99d87e981d169b91c.zip
VNC: Fix memory allocation (wrong structure size).
Pointer vs addresses a VncDisplay structure, so it is sufficient to allocate sizeof(VncDisplay) or sizeof(*vs) bytes instead of the much larger sizeof(VncState). Maybe the misleading name should be fixed, too: the code contains many places where vs is used, sometimes it is a VncState *, sometimes it is a VncDisplay *. vd would be a better name. Signed-off-by: Stefan Weil <weil@mail.berlios.de> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Diffstat (limited to 'vnc.c')
-rw-r--r--vnc.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/vnc.c b/vnc.c
index 3f5d622ab..41defc2b4 100644
--- a/vnc.c
+++ b/vnc.c
@@ -2033,9 +2033,8 @@ static void vnc_listen_read(void *opaque)
void vnc_display_init(DisplayState *ds)
{
- VncDisplay *vs;
+ VncDisplay *vs = qemu_mallocz(sizeof(*vs));
- vs = qemu_mallocz(sizeof(VncState));
dcl = qemu_mallocz(sizeof(DisplayChangeListener));
ds->opaque = vs;