aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlan Modra <amodra@gmail.com>2019-11-18 12:31:55 +1030
committerAlan Modra <amodra@gmail.com>2019-11-18 22:06:09 +1030
commit9aea1e31371a883452e80bd96e8818289c3e6b6e (patch)
treec1a28a6b86dfa423cef5cb9cc6057deb8df83264
parentgas: Add --gdwarf-cie-version command line flag (diff)
downloadbinutils-gdb-9aea1e31371a883452e80bd96e8818289c3e6b6e.tar.gz
binutils-gdb-9aea1e31371a883452e80bd96e8818289c3e6b6e.tar.bz2
binutils-gdb-9aea1e31371a883452e80bd96e8818289c3e6b6e.zip
PR25196, abort in rewrite_elf_program_header
This patch introduces a new "sorry, cannot handle this file" bfd error status. The idea is to use this error in cases where bfd hasn't found a bfd_bad_value error, ie. an input file or set of options that are invalid, but rather an input file that is simply too difficult to process. Typically this might happen with fuzzed object files such as the one in the PR, a wildly improbable core file. Some things are just not worth wasting time over to fix "properly". PR 25196 * bfd.c (bfd_error_type): Add bfd_error_sorry. (bfd_errmsgs): Likewise. * elf.c (rewrite_elf_program_header): Don't abort on confused lma/alignment. Replace bfd_error_bad_value with bfd_error_sorry. (_bfd_elf_validate_reloc): Use bfd_error_sorry. (_bfd_elf_final_write_processing): Likewise. * bfd-in2.h: Regenerate.
-rw-r--r--bfd/ChangeLog11
-rw-r--r--bfd/bfd-in2.h1
-rw-r--r--bfd/bfd.c2
-rw-r--r--bfd/elf.c9
4 files changed, 19 insertions, 4 deletions
diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 9370b7a8d0..2184208038 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,14 @@
+2019-11-18 Alan Modra <amodra@gmail.com>
+
+ PR 25196
+ * bfd.c (bfd_error_type): Add bfd_error_sorry.
+ (bfd_errmsgs): Likewise.
+ * elf.c (rewrite_elf_program_header): Don't abort on confused
+ lma/alignment. Replace bfd_error_bad_value with bfd_error_sorry.
+ (_bfd_elf_validate_reloc): Use bfd_error_sorry.
+ (_bfd_elf_final_write_processing): Likewise.
+ * bfd-in2.h: Regenerate.
+
2019-11-12 Jim Wilson <jimw@sifive.com>
PR 25181
diff --git a/bfd/bfd-in2.h b/bfd/bfd-in2.h
index 3244905b45..a00dfa3515 100644
--- a/bfd/bfd-in2.h
+++ b/bfd/bfd-in2.h
@@ -6964,6 +6964,7 @@ typedef enum bfd_error
bfd_error_bad_value,
bfd_error_file_truncated,
bfd_error_file_too_big,
+ bfd_error_sorry,
bfd_error_on_input,
bfd_error_invalid_error_code
}
diff --git a/bfd/bfd.c b/bfd/bfd.c
index 94e9f27e9d..e92213b543 100644
--- a/bfd/bfd.c
+++ b/bfd/bfd.c
@@ -655,6 +655,7 @@ CODE_FRAGMENT
. bfd_error_bad_value,
. bfd_error_file_truncated,
. bfd_error_file_too_big,
+. bfd_error_sorry,
. bfd_error_on_input,
. bfd_error_invalid_error_code
.}
@@ -688,6 +689,7 @@ const char *const bfd_errmsgs[] =
N_("bad value"),
N_("file truncated"),
N_("file too big"),
+ N_("sorry, cannot handle this file"),
N_("error reading %s: %s"),
N_("#<invalid error code>")
};
diff --git a/bfd/elf.c b/bfd/elf.c
index be060d579c..e10099842b 100644
--- a/bfd/elf.c
+++ b/bfd/elf.c
@@ -7324,7 +7324,7 @@ rewrite_elf_program_header (bfd *ibfd, bfd *obfd)
: 0),
output_section->alignment_power)
!= output_section->lma)
- abort ();
+ goto sorry;
}
else
{
@@ -7363,7 +7363,8 @@ rewrite_elf_program_header (bfd *ibfd, bfd *obfd)
negative size - or segments that do not contain any sections. */
if (map->count == 0)
{
- bfd_set_error (bfd_error_bad_value);
+ sorry:
+ bfd_set_error (bfd_error_sorry);
free (sections);
return FALSE;
}
@@ -9277,7 +9278,7 @@ _bfd_elf_validate_reloc (bfd *abfd, arelent *areloc)
/* xgettext:c-format */
_bfd_error_handler (_("%pB: %s unsupported"),
abfd, areloc->howto->name);
- bfd_set_error (bfd_error_bad_value);
+ bfd_set_error (bfd_error_sorry);
return FALSE;
}
@@ -12249,7 +12250,7 @@ _bfd_elf_final_write_processing (bfd *abfd)
_bfd_error_handler (_("symbol type STT_GNU_IFUNC is unsupported"));
if (elf_tdata (abfd)->has_gnu_osabi & elf_gnu_osabi_unique)
_bfd_error_handler (_("symbol binding STB_GNU_UNIQUE is unsupported"));
- bfd_set_error (bfd_error_bad_value);
+ bfd_set_error (bfd_error_sorry);
return FALSE;
}
}